[00:00:14] already abandoned^ [00:00:15] or git review -R skin-rewrite, that is [00:01:01] hmm no it's not info boxes it's something else [00:01:45] this article does not scroll in chrome beta with mobile frontend non-beta [00:01:46] http://en.m.wikipedia.org/wiki/Ambrose,_Modoc_County,_California [00:02:26] jdlrobson: tfinc mentioned you had made some changes to address scrolling issues in chrome beta - did we push those today? [00:02:37] jdlrobson: i'm noticing some interesting touch triggers on article sections . the bar that divides articles highlights when you tap it [00:03:04] another broken scrolling example: http://en.m.wikipedia.org/wiki/Anuthatantrum [00:03:31] awjr are you looking at beta of site or normal version? [00:03:37] jdlrobson: normal [00:03:57] scrolls fine in desktop chrome though :p [00:04:04] arrggh [00:04:12] :( [00:04:22] i made a change to beta_common.css but not common.css [00:04:37] need to confirm but i think that's what's happened here [00:04:46] jdlrobson: scrolling works fine on those articles in the beta [00:05:03] yeh i've messed up https://gerrit.wikimedia.org/r/#q,5442,n,z [00:05:09] the change there should have also applied to common.css [00:05:11] i'll push now [00:05:18] any chance we can patch live version or is it too late now? [00:05:19] awjr: can you put up an ether pad were we can note issues [00:05:50] jdlrobson: yeah, push it and awjr can get it live ASAP [00:05:51] then we can update bugs for changes that can be fixed immediately [00:06:08] aye [00:06:16] http://etherpad.wikimedia.org/MobileFrontend-Deployment-Issues-20120423 [00:07:21] New patchset: Jdlrobson; "follow up to 3fb78d6cb21566d009a4ce0117ad7babf23c0d70" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5700 [00:07:43] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/5700 [00:07:59] just realised i haven't changed getDom() back to member.... tomorrowwwww [00:08:29] jdlrobson was that the fix to push? [00:08:34] up [00:08:36] k [00:08:36] *yup [00:08:57] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5700 [00:15:22] okidoke common.css updated on the clsuter [00:16:32] css files are now all resource loader-ified right? [00:16:50] i dont need to bump resource version or clear any cache or anything? [00:16:52] preilly ^ [00:17:32] awjr: that is correct [00:17:54] yay [00:18:07] jdlrobson: scrolling works now on chrome beta :D [00:18:13] woot! [00:18:13] \o/ [00:18:23] happy day. [00:18:47] cool im not really seeing any other major issues [00:19:01] jdlrobson: does it look good to you? [00:19:08] or at least british good [00:19:26] it looks british good yes (acceptable) [00:19:28] wtf i can't click in the text area in the etherpad to reposition the cursor [00:19:39] oh wait now i can [00:19:40] i hate computers [00:19:47] i'm a bit worried by the flicker problems awjr was mentioning [00:20:29] jdlrobson do you have an ICS device to test on? [00:21:06] i have an emulator [00:21:12] but that's rubbish under normal circumstances [00:23:00] jdlrobson yeah :( i dont see the flicker in chrome beta (MobileFrontend beta), but toggling is still a *little* funky, like a big sluggish [00:25:19] awjr does http://mobile-geo.wmflabs.org/w/index.php?title=San%20Francisco&useformat=mobile have the same problem? [00:25:45] so the flicker is mostly in non-beta? [00:26:13] jdlrobson, no, beta [00:26:17] jdlrobson: i think i'm starting to see less of the issues now. new pushes that fixed it ? [00:26:26] jdlrobson however i just killed a bunch of apps that were open and im not really seeing the flicker anymore [00:26:31] i only pushed one thing :-) [00:26:32] toggling just seems really sluggish [00:26:58] i suspect the transitions are causing problems [00:27:18] is that toggle resource intensive? [00:27:53] even if it is i would expect my galaxy nexus to have no problemo with it [00:28:15] ahha just saw flicker again [00:29:20] on http://en.m.wikipedia.org/wiki/Interface_(Star_Trek:_The_Next_Generation) [00:29:39] which has a cool picture of geordi la forge on it [00:29:41] +1 to awjr for using TNG related articles for testing [00:29:49] :D [00:31:18] mm [00:31:31] do you see flicker on this article? http://mobile-geo.wmflabs.org/w/index.php?title=San%20Francisco&useformat=mobile#_ [00:33:30] jdlrobson one sec there's no way in hell im typing that into my phone :p [00:33:55] ok bitly one sec [00:34:27] no worries i just txtd it to mysefl [00:34:45] http://bit.ly/I4UsLg [00:34:47] k [00:42:03] jdlrobson sorry one sec [00:43:12] lindsey / phil around? [00:43:35] jdlrobson: nope [00:43:43] booo [00:44:16] if anyone wants to play with some of the new nav mockups - http://jonrobson.me.uk/wikipedia/experiments/nav/index3.html and http://jonrobson.me.uk/wikipedia/experiments/nav/index.html [00:44:32] jdlrobson: i will after i finish playing with todays deployed changes [00:44:45] jdlrobson for some obnxious reason i cant get that article to load in mobilefrontend beta even though i'm logged in to the beta, probably a caching thing [00:44:47] jdlrobson: this phantom reference reveal is really bizarre [00:44:49] im gonna keep poking it for a sec [00:45:27] jdlrobson: could you rig a fake set of search results to it ? [00:45:50] possibly [00:45:52] just for the search results display [00:45:56] they don't have to point to anywhere [00:46:06] the phantom reference reveal does it just flash [00:46:09] or does it show text? [00:46:22] jdlrobson: no text [00:46:25] have been unable to replicate so fr.. [00:46:25] it only flashes [00:46:33] jdlrobson: what phone are you testing on? [00:46:55] jdlrobson ok got it - it is not flickering, but the toggling is just sluggish [00:47:08] hang on tfinc [00:47:18] just going to make a change awjr and you can tell me if any better [00:47:28] k [00:47:31] k [00:48:08] try now.. awjr [00:48:40] flickering seems to be due to images not being loaded at start [00:49:48] jdlrobson i *think* it's better, it's still a big sluggish and now i've looked at it enough that it's ahrd to tell [00:50:01] mm [00:50:12] 1 more test.. [00:50:31] now [00:50:36] any difference noticed? [00:51:31] jdlrobson: worse now [00:51:39] on Music of Wisconsin article [00:51:43] mm [00:52:15] better now? [00:52:15] it's not so much flickering now - it seems more like a fade-in that's really rough [00:52:41] no same problem [00:52:42] actually [00:52:47] jdlrobson one sec lemme clear my cache [00:54:13] jdlrobson: there's a slight delay when i click the toggle, but then the section appears smoothly [00:54:34] yeh I dropped transitions altogether.. [00:54:34] jdlrobson but the delay is ~1s [00:54:50] closer to 2s, maybe 1.5 [00:54:56] try now [00:54:57] as you can tell im measuring this very scientifically [00:56:01] preilly: do you know why MF images look blurry on retina within an article but look fine on the detail page ? [00:56:26] jdlrobson still a delay [00:56:30] grr [00:56:33] now? [00:56:44] it's the kind of delay that's just long enough to make you want to click the seciton header a second time [00:57:05] that's an annoying delay [00:57:15] i know we had a similar problem on ios [00:57:27] where clicks were too slow due to trying to detect touch events [00:57:35] i wonder if this is similar [00:59:05] jdlrobson this one seems a bit better [01:00:17] mm [01:00:59] * jdlrobson going to bed soon [01:01:40] try refreshing now awjr [01:07:01] jdlrobson worse :( [01:07:29] errg [01:07:37] so yeh I'm not going to get to the bottom of this tonight [01:07:38] b [01:07:48] but it doesn't seem to like transitions [01:07:53] jdlrobson you might check in with brion vibber - i remember him mentioning something to me about toggling being an issue on ICS in the native browser but in the context of it being a bug in the native browser itself [01:09:41] jdlrobson: awesome work though, it's cool that we're down to the nit-picky stuff :) [01:10:07] jdlrobson: +1 i really can't use the old interface anymore [01:10:13] its makes my eyes bleed [01:10:15] :D [01:10:19] :) [01:11:12] tfinc: this http://upload.wikimedia.org/wikipedia/commons/thumb/a/a5/Union_square_san_francisco.jpg/250px-Union_square_san_francisco.jpg vs http://upload.wikimedia.org/wikipedia/commons/a/a5/Union_square_san_francisco.jpg [01:12:10] ok im gonna head out. good night everyone [01:14:03] night awjr [01:14:18] nite nite awjr [01:14:59] preilly: ok [01:15:03] seeya awjr [01:15:06] ok tfinc the results of today are - http://jonrobson.me.uk/wikipedia/experiments/nav/index.html, http://jonrobson.me.uk/wikipedia/experiments/nav/index3.html, http://jonrobson.me.uk/wikipedia/experiments/nav/index4.html - only search on the 1st one [01:15:22] tfinc: this page http://en.m.wikipedia.org/wiki/Union_Square,_San_Francisco renders horribly [01:15:34] whats the difference between each of the versions ? [01:15:36] jdlrobson: --^ [01:16:12] 1st one: main menu on left, page options accessible from button on right of search [01:16:47] index3: page options are also on left menu but on far right [01:16:57] index4: search thrown into left menu [01:17:01] jdlrobson: sweet. thanks [01:17:14] just updating phil.. [01:18:10] jdlrobson: sweet [01:18:39] great [01:18:43] well i'm gonna head to sleep now [01:18:49] thanks jdlrobson [01:18:55] drop me an e-mail if anything major comes up and needs fixing [01:19:48] jdlrobson: will do [01:33:12] tfinc: Dismiss keyboard when users is scrolling through full screen search reulsts [01:33:38] tfinc: fixed spelling of: https://bugzilla.wikimedia.org/show_bug.cgi?id=36191 - Dismiss keyboard when users is scrolling through full screen search results [01:34:32] thanks [01:35:52] tfinc: updated http://www.mediawiki.org/wiki/Extension:MobileFrontend/Deployments#Upcoming [01:36:52] nice [01:36:57] how easy was that to generate ? [01:38:43] not too hard [01:38:59] replace all the | with empty string [01:40:36] this is sad. i'm starting up the android emu because i know that it'll be slow enough to show one of the bugs that i'm seeing in the beta [01:40:50] wow [01:51:38] almost done triaging the bugs from todays deployment … new tracking bug for beta ui going default https://bugzilla.wikimedia.org/show_bug.cgi?id=36189 [01:52:00] so, no bugs on https://bugzilla.wikimedia.org/show_bug.cgi?id=36189 [01:52:04] yet? [01:52:23] i've marked five bugs blocking it [01:52:31] nothing too difficult [01:52:42] i'm most worried about the phantom reference reveal [01:52:55] okay, so just https://bugzilla.wikimedia.org/show_bug.cgi?id=36190 https://bugzilla.wikimedia.org/show_bug.cgi?id=36191 https://bugzilla.wikimedia.org/show_bug.cgi?id=36192 https://bugzilla.wikimedia.org/show_bug.cgi?id=36193 https://bugzilla.wikimedia.org/show_bug.cgi?id=36194 [01:53:07] what the fuck Adium [01:53:08] so far [01:53:14] hmm ? [01:53:34] did the formatting of what I posted look messed up? [01:53:56] looks fine [01:54:08] hmm [01:54:19] well never mind my cursing [01:55:44] tfinc: [Bug 36194] Image enable/disable requires page reload to work after tapping link in beta — isn't marked as MobileFrontend [01:56:08] actually it is [01:56:09] hmm [02:07:53] tfinc: is shttp a new protocol that I don't know about? [02:08:01] hmm? [02:08:07] tfinc: https://bugzilla.wikimedia.org/show_bug.cgi?id=36198 [02:08:16] lolz [04:35:27] anyone around? mobext is throwing fatals like crazy in prod [04:41:44] nm, it looks like scap failed to a couple servers earlier today, the fatals were due to corrupt code deploys [11:42:12] New patchset: Jdlrobson; "add basic test for references" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5713 [11:42:13] New patchset: Jdlrobson; "fix for Bug 36192" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5714 [14:15:02] New patchset: Jdlrobson; "deal with footer links better" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5718 [14:15:03] New patchset: Jdlrobson; "reduce footer font-size for tiny screens" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5719 [15:40:37] New patchset: Jdlrobson; "fix bug for 36196" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5722 [15:55:01] Change abandoned: MaxSem; "(no reason)" [mediawiki/extensions/MobileFrontend] (skin-rewrite) - https://gerrit.wikimedia.org/r/5699 [15:55:27] Change restored: MaxSem; "(no reason)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5240 [15:56:29] Change abandoned: MaxSem; "(no reason)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5240 [15:56:41] Change restored: MaxSem; "(no reason)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5361 [15:56:56] New patchset: MaxSem; "Skin rewrite" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5361 [15:57:20] Gerrit gives me the creeps [15:57:54] [WikipediaMobile] jdlrobson pushed 2 new commits to master: http://git.io/aM_G5w [15:57:54] [WikipediaMobile/master] Fix Page actions not showing up on iOS - YuviPanda [15:57:54] [WikipediaMobile/master] Merge pull request #212 from yuvipanda/ios-fix-page-action - Jon Robson [16:29:29] good morning, awjr [16:29:36] wassup MaxSem [16:29:55] https://gerrit.wikimedia.org/r/5361 [16:31:03] MaxSem i'll take a look shortly [17:32:56] MaxSem: this issue was not a part of your changeset but something i noticed while testing your changeset - line 100 of SpecialMobileFeedback.php should probably use 'getLocalURL' rather than 'getFullURL', otherwise there may be funky results with multiple domain set ups. [17:33:15] *looking* [17:33:25] alternatively, wrap the full url in a call to getMobileURl [17:34:14] MaxSem: same thing on line 34 [17:34:36] in general be careful with getFullURL - if you're intending someone to stay on the mobile domain, it should be wrapped in a call to getMobileURL [17:35:22] awjr, does it need a separate fix or your branch is close to a merge? [17:35:45] MaxSem i think it needs a separate fix [17:37:27] hmm, do HTTP redirects support local URLs? [17:37:31] better not risk [17:38:23] greetings all [17:38:42] YuviPanda: hows @zeljkofilipin been doing for testing ? [17:40:06] awjr: i'm going to read through my morning mail and then we can sync up about contact us [17:40:07] tfinc: he found issues with our contact page which are weird (and reproducible), but scrolling's been fine for him [17:40:23] tfinc sounds good [17:40:34] MaxSem: yeah i think better to use the full url [17:43:55] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/5713 [17:43:58] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5713 [17:46:02] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/5714 [17:46:04] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5714 [17:46:07] New review: awjrichards; "Comments in-line. Basic usage testing looks good, but these changes should also be performance teste..." [mediawiki/extensions/MobileFrontend] (master); V: 1 C: -1; - https://gerrit.wikimedia.org/r/5361 [17:46:22] MaxSem ^ [17:47:10] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/5718 [17:47:12] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5718 [17:47:59] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/5719 [17:48:01] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5719 [17:49:08] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/5722 [17:49:10] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5722 [17:54:05] YuviPanda: bummer [17:54:14] YuviPanda: useful but not exactly what we were looking for [17:54:28] yes. [17:54:58] New review: MaxSem; "(no comment)" [mediawiki/extensions/MobileFrontend] (master) C: 0; - https://gerrit.wikimedia.org/r/5361 [17:55:05] awjr, ^^ [18:01:26] New review: preilly; "Why didn't you use the skin-rewrite remote branch?" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/5361 [18:01:55] MaxSem: ^^ [18:02:38] awjr: are you using a ubuntu VM? [18:02:40] preilly, because I got tired of fighting with gerrit [18:02:59] MaxSem: what part was not working? [18:03:17] New review: awjrichards; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: -1; - https://gerrit.wikimedia.org/r/5361 [18:03:53] it constantly attempted to push a shitload of changes, like it did yesterday [18:04:21] MaxSem: delete and recreate the remote branch off of the current head [18:04:27] MaxSem: then it won't do that [18:04:53] why use remote branch at all? new patchsets work just fine [18:05:05] MaxSem: not really [18:05:21] MaxSem: we want to be able to A/B test this change against the current master [18:05:34] MaxSem: and a remote branch provides for a little bit more isolation [18:05:40] awjr: wget http://pecl.php.net/get/xhprof-0.9.2.tgz [18:05:49] awjr: tar zxf xhprof-0.9.2.tgz [18:06:02] awjr: cd xhprof-0.9.2/extension [18:06:16] awjr: phpize [18:06:31] awjr: sudo touch /etc/php5/conf.d/xhprof.ini [18:06:39] awjr: sudo vim /etc/php5/conf.d/xhprof.ini [18:06:51] so yesterday patrick and i were talking about bugs like 36193 which have long text breaking our mobile interfaces. typical once a string gets translated … the translator doesn't know about the length limits and picks something that matches the term very well but doesn't have enough context to pick an appropriate length. if mw introduce a soft and hard limit on text length we could fix this at the root of the problem [18:06:59] tboughts? [18:07:04] thoughts* [18:07:18] and has this ever been discussed for mw ? [18:07:32] awjr: [xhprof] [18:07:33] extension=xhprof.so [18:07:33] xhprof.output_dir="/tmp/xhprof" in that file. [18:07:45] tfinc, you mean display maximum length during translation? [18:08:10] MaxSem: yes [18:08:26] a soft and then hard maximum of characters for flexibility [18:08:54] this would be an optional parameter in any i18n message [18:08:56] Q: Is it possible to set "max length" for strings? [18:08:57] A: No. Patches - with proper UI or configuration welcome - although UIs should allow considerably wider translated text than source texts. [18:08:58] Reply [18:08:59] Parent [18:09:00] More [18:09:01] siebrand‎15:42, 11 July 2011 [18:09:05] from http://www.mediawiki.org/wiki/Extension_talk:Translate [18:10:00] preilly: thats not good enough for a mobile interface [18:10:15] tfinc: I know [18:10:30] tfinc: I'm just pointing out what was said by Siebrand in the past [18:10:53] tfinc: also, I just asked that same question again in #mediawiki-i18n [18:11:03] we can just add a warning to qqq about minding the length with a nice [18:14:19] preilly, your opinion on https://gerrit.wikimedia.org/r/#patch,sidebyside,5361,2,skins/SkinMobile.php line 121? can we break b/c by introducing a separate config var for minifyJS? [18:16:44] MaxSem: hmm [18:17:32] MaxSem: I understand your point on isBetaGroupMember but, I think that it should be referenced the same way as isBetaGroupMember [18:17:37] MaxSem: does that make sense? [18:18:27] preilly: awjrichards@virtualbot:~/src/xhprof-0.9.2/extension$ $ php -m | grep xhprof [18:18:27] PHP Warning: PHP Startup: Unable to load dynamic library '/usr/lib/php5/20090626/xhprof.so' - /usr/lib/php5/20090626/xhprof.so: cannot open shared object file: No such file or directory in Unknown on line 0 [18:18:42] tfinc: also, I just asked that same question again in #mediawiki-i18n [18:20:14] preilly, I would like to separate frontend from backend (to the point where ExtMobileFrontend gets renamed to MobileBackend or something), so I was kinda reluctant to keep a skin-related variable in ExtMobileFrontend [18:23:56] preilly do i need to do ./configure? [18:24:20] yes it looks like it [18:25:53] bingo [18:25:57] awjr: ./configure make make install [18:26:02] yah [18:26:08] then restart apache [18:26:21] sudo /etc/init.d/apache2 restart [18:26:25] awjrichards@virtualbot:~/src/xhprof-0.9.2/extension$ $ php -m | grep xhprof [18:26:25] xhprof [18:26:27] \o/ [18:26:36] awjr: not so fast sunshine [18:26:42] aww [18:27:00] awjr: I'm using a slightly GUI enhanced version fork of the official FB one preinheimer @ github >> https://github.com/preinheimer/xhprof [18:27:10] awjr: Clone it somewhere where you can let apache reach it. [18:27:18] awjr: git clone git://github.com/preinheimer/xhprof.git [18:27:25] awjr: cd xhprof_lib/ [18:27:33] awjr: cp config.sample.php config.php [18:27:42] awjr: Change necessary values in config.php [18:27:56] awjr: you'll need to create a database and put the values in the config [18:28:25] awjr: the table schema you need to create is in the mysql php file [18:28:33] cool [18:28:36] awjr: then add php_admin_value auto_prepend_file "/path/to/xhprof/external/header.php" [18:28:46] awjr: to your apache config [18:29:03] awjr: after that you should be able to add ?_profile=1 to a request to profile it [18:35:02] New patchset: MaxSem; "Fix non-mobile URLs in Special:MobileFeedback" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5730 [18:36:51] [WikipediaMobile] brion pushed 4 new commits to master: http://git.io/XRd_QA [18:36:51] [WikipediaMobile/master] Tweak to index.html - Brion Vibber [18:36:51] [WikipediaMobile/master] Update WinPhone to cordova 1.6.1 - Brion Vibber [18:36:51] [WikipediaMobile/master] fix styles, scrolling, show/hide section icons for WinPhone - Brion Vibber [18:37:48] brion: only winphone updated to 1.6.1, I presume? [18:38:23] YuviPanda: yep, didn't touch the others yet [18:38:42] there's a few js tweaks for winphone which shouldn't hurt anything else, but please feel free to test around :) [18:39:01] ios seems ok, i'm still updating android sdk so haven't double-checked there [18:39:23] winphone's picky about loading local files over ajax, you have to use full path [18:39:33] brion: ugh, okay. Do you think you can do the winphone stuff on a branch that we can merge in later? [18:39:46] brion: last two weeks have made me super paranoid about touching anything :| [18:39:57] heh [18:40:05] well this is all my changes for now, and it's pretty isolated [18:40:21] the UI looks awful but we'll be doing a major redo anyway, so that's no biggie [18:40:26] :) [18:40:28] ok [18:40:45] no gradient support, if you can believe that! primitive :) [18:40:58] well, it is IE :) [18:41:09] hehe [18:43:27] ok, confirmed l10n and sitematrix.json load properly on android [18:43:30] be back later [18:56:52] preilly: can you take https://bugzilla.wikimedia.org/show_bug.cgi?id=36213 ? [18:57:25] especially as you can also squash https://bugzilla.wikimedia.org/show_bug.cgi?id=36194 if you fix it [19:10:28] no more hacks, i'll just rewrite saved pages tomo. [19:10:30] gnite everyone. [19:25:33] tfinc: okay [19:43:51] New patchset: L10n-bot; "Localisation updates from http://translatewiki.net." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5751 [19:43:55] New review: gerrit2; "Auto-approving/merging l10n updates" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/5751 [19:43:55] Change merged: gerrit2; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5751 [19:46:13] preilly: http://dl.dropbox.com/u/4187555/WiktionaryActivity-v101b2.apk [19:58:03] New patchset: MaxSem; "Skin rewrite" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5361 [20:45:57] New patchset: preilly; "Fixes: * Bug 36213 - [CSRF] Special:MobileOptions/DisableImages needs token ** https://bugzilla.wikimedia.org/show_bug.cgi?id=36213 * Bug 36194 - Image enable/disable requires page reload to work after tapping link in beta ** https://bugzilla.wikimedi" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5771 [20:50:34] New review: MaxSem; "Why not use User::getToken()?" [mediawiki/extensions/MobileFrontend] (master) C: 0; - https://gerrit.wikimedia.org/r/5771 [20:51:30] MaxSem: we need to support anonymous users as well [20:52:16] MaxSem: and also wanted to store it in a different session space [20:52:53] New review: preilly; "MaxSem: we need to support anonymous users as well and also wanted to store it in a different sessio..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/5771 [20:52:56] New review: Catrope; "Fine except for empty() usage." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/5771 [20:52:59] > echo $wgUser->getToken(); [20:52:59] 5d22ea8c0995e985ac0fd8dc88908193 [20:53:37] so tokens aren't empty for anons [20:54:48] * MaxSem wonders what's so harmful about DisableImages CSRF [20:55:07] New patchset: preilly; "Fixes: * Bug 36213 - [CSRF] Special:MobileOptions/DisableImages needs token ** https://bugzilla.wikimedia.org/show_bug.cgi?id=36213 * Bug 36194 - Image enable/disable requires page reload to work after tapping link in beta ** https://bugzilla.wikimedi" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5771 [20:55:47] MaxSem: editToken isn't empty [20:55:58] MaxSem: but, it's also not stored in the session [20:56:29] MaxSem: I mean getToken [20:56:44] MaxSem: also, I want a separate session storage space [20:57:21] New review: Catrope; "Also getToken() doesn't appear to store its token in the session, which makes me doubt whether it'll..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/5771 [20:57:45] New review: Catrope; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/5771 [21:00:11] preilly_, tokens in getURL() will be cached in Varnish with rendered pages, so people will receive mostly wrong token if they're not logged in [21:03:00] MaxSem: so, I guess I should move that to JS [21:03:39] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: -2; - https://gerrit.wikimedia.org/r/5771 [21:08:40] JS sounds fragile [21:08:59] MaxSem: okay, so what do you think? [21:15:01] * MaxSem sunk in thoughts [21:15:54] after all, we don't even require tokens for logouts, a much more disruptive operation [21:28:56] preilly, MaxSem: i am suddenly getting a PHP warning in mobilefrontend on masteR: [21:28:59] Warning: in_array() expects parameter 2 to be array, null given in /home/awjrichards/Dev/wikimedia_git/extensions/MobileFrontend/MobileFrontend.body.php on line 1002 [21:29:00] Call Stack: [21:29:00] 0.0036 1086568 1. {main}() /home/awjrichards/Dev/wikimedia_git/core/index.php:0 [21:29:01] 0.1194 15263976 2. MediaWiki->run() /home/awjrichards/Dev/wikimedia_git/core/index.php:58 [21:29:02] 0.1195 15273136 3. MediaWiki->main() /home/awjrichards/Dev/wikimedia_git/core/includes/Wiki.php:502 [21:29:03] 0.2965 29482424 4. MediaWiki->finalCleanup() /home/awjrichards/Dev/wikimedia_git/core/includes/Wiki.php:593 [21:29:04] 0.2966 29502432 5. OutputPage->output() /home/awjrichards/Dev/wikimedia_git/core/includes/Wiki.php:405 [21:29:05] 0.3204 31339320 6. SkinMobile->outputPage() /home/awjrichards/Dev/wikimedia_git/core/includes/OutputPage.php:1982 [21:29:06] 0.3538 32948728 7. ExtMobileFrontend->DOMParse() /home/awjrichards/Dev/wikimedia_git/extensions/MobileFrontend/skins/SkinMobile.php:25 [21:29:07] 0.3716 33360888 8. ExtMobileFrontend->getSearchTemplate() /home/awjrichards/Dev/wikimedia_git/extensions/MobileFrontend/MobileFrontend.body.php:848 [21:29:08] 0.3731 33431696 9. ExtMobileFrontend->buildLanguageSelection() /home/awjrichards/Dev/wikimedia_git/extensions/MobileFrontend/MobileFrontend.body.php:933 [21:29:09] 0.3789 33833808 10. in_array() /home/awjrichards/Dev/wikimedia_git/extensions/MobileFrontend/MobileFrontend.body.php:1002 [21:29:52] awjr: fixed in https://gerrit.wikimedia.org/r/#patch,sidebyside,5771,2,MobileFrontend.body.php line 1003 [21:30:03] far out. [21:30:34] or just do $supportedLanguages = array(); [21:30:39] as in my branch [21:31:08] MaxSem yeah, i just wanted to make sure whoever broke it was aware :) [21:31:24] he is aware:) [21:59:36]