[00:12:30] New patchset: preilly; "Fixes: * Bug 36213 - [CSRF] Special:MobileOptions/DisableImages needs token ** https://bugzilla.wikimedia.org/show_bug.cgi?id=36213 * Bug 36194 - Image enable/disable requires page reload to work after tapping link in beta ** https://bugzilla.wikimedi" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5771 [00:12:45] awjr: can you look at ^^ [00:13:50] New review: preilly; "Added the following to the mobile view api ?action=mobileview&page=mobiletoken&override=1&format=xml" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -2; - https://gerrit.wikimedia.org/r/5771 [02:44:25] https://en.wikipedia.org/w/index.php?diff=489081184&oldid=489080938 [03:42:03] thanks Joan [03:48:27] New review: Catrope; "Has a broken API parameter and some minor issues with the JS changes, but looks good otherwise." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/5771 [08:22:51] * tfinc yawns [08:23:33] jdlrobson: check your pm [08:23:54] tfinc: go to sleep [08:24:01] YuviPanda: its only 1:23 [08:24:16] and since when do you take my role of telling *you* guys to sleep [08:24:19] ;) [08:24:37] :D Wah, I've been up for 4 hours and it is only 2 [08:24:39] not bad. [08:26:56] YuviPanda: how is our iOS feedback looking? [08:27:33] tfinc: not great [08:27:37] tfinc: still bad [08:27:42] what are people reporting? [08:28:13] tfinc: most of them seem to be 'the old app was good, why did you update, this sucks and is slow!' [08:29:04] scrolling on iOS 5.1 and 'slowness' are the only 'specific' issues reported, other than general 'it sucks' comments [08:29:43] 'BOTTOM LINE IS THEY TOOK MY FAVORITE APP AND DESTORYED IT' is copy pasting from one, which seems to be the general consensus there [08:30:24] so the ui comments i can understand but the slowness worries me. where are they reporting it? [08:31:08] general laginess. Again, nothing specific [08:32:00] I'm guessing most of it is 1. Initial load time 2. no 'instant' feedback on touching menus. [08:32:39] what can we do for the latter? [08:32:47] https://bugzilla.wikimedia.org/show_bug.cgi?id=35778 [08:32:47] that would make the app on both android and iOS better [08:32:59] right, so i've a branch called 'faster-clicking' [08:33:07] it *does* have more instant feeback [08:33:12] except that it breaks scrolling [08:33:53] i've been fighting with saved pages again, hopefully should have them fixed today. Saved pages and scrolling are taking an disproportionate amount of time to get right :( [08:34:25] so once I've this figured out, I'll be able to go see why that breaks scrolling and fix that. I'm pretty sure we'll ship a fastclick implementation for 1.2/3.2 [08:34:31] k [08:35:35] YuviPanda: can you respond to Maarten subject: " Android Wikipedia Mobile app v1.1.1 (background of saved page)" [08:35:50] i did, and got a response back. should respond to the response [08:36:00] YuviPanda tfinc - out of interest would it not make sense to allow downloading of the old app but mark it as not undergoing further development ? It might reduce the comment noise to useful ones if people who **loved** the old one can still download it [08:36:22] some people in general don't like change :) [08:36:32] jdlrobson: i pitched that as an option a couple of weeks ago [08:36:40] YuviPanda didn't like it much ;) [08:36:59] * aude waves [08:37:00] YuviPanda: whats your thought a couple of weeks later [08:37:02] hey aude [08:37:25] * aude says yes, keep the old app for iOS :) [08:37:35] tfinc: so, of late I've contemplated abandoning PhoneGap, and just maintaining separate iOS and Android native apps. [08:37:57] YuviPanda: whats causing you want to do that? [08:38:06] it would be a drastic and costly shift [08:38:11] now that program and scholarships are done, i have time to help with maps stuff [08:38:16] aude: nice [08:38:32] aude: we've been waiting on ops to get our new hardware in [08:38:44] * jdlrobson doesn't like native apps full stop and looks forward to a world where people just use the web [08:38:47] YuviPanda: and one that were not setup to handle [08:38:47] tfinc: we have labs project to work with now and it's good [08:38:55] aude: sweet [08:38:58] figure out what configuration works well [08:39:09] tfinc: indeed. I've not fully thought it out. [08:39:48] so YuviPanda I'm just suggesting we make the old app available under some different name and eventually make the iOS app a lot better so people switch over [08:40:18] jdlrobson: what about a simple "lite" version with no maps [08:40:26] * aude cant believe i'm saying that! [08:40:38] i think just for reading articles :) [08:40:44] maps aren't complicating anything [08:40:49] that's fine by me but the larger question is if we poured the same amount of time we poured into phonegap into the native iOS (or android) versions, we might have a better app? [08:40:50] oh, okay [08:40:50] there is no need to remove them [08:41:05] no I think we should push the app as far as possible - but from the sound of it people liked the old ios app for whatever reason and moving to our phone gap app was too drastic a change for them [08:41:07] it is also very much possible that I just need to put in more work :) [08:41:11] though, on older phones, the new app is incompatible [08:41:26] jdlrobson: true, we never ran into this issue with Androdi market, which had no 'old app' [08:41:30] exactly [08:41:36] and in the android market the feedback is more useful [08:41:42] aude: it supports the same exact phones as our previous app on ios [08:41:49] like why doesn't it do X why doesn't it do Y [08:41:51] tfinc: i don't think so [08:42:00] or i haven't updated my app in a long time [08:42:22] jdlrobson: indeed. Plus we're at a good 4.5 after 8k ratings, with iOS much lower. [08:42:29] * aude has a really old iphone but it's not broken and i don't want to pay for a new one [08:42:30] actually i take it back. we likely ran on 3.x [08:42:39] but honestly the distribution of those phones is tiny these days [08:42:39] tfinc: it did :) [08:42:47] that is almost negligible [08:42:54] grrrr [08:43:16] we make the same trade offs on the desktop [08:43:21] exactly. So my recommendation is we revert to the old app on itunes store and provide another download - even calling it something different e.g. WikipediaPlus making it clear it's a new app that's in development that will be more functional and one would hope we'd get better more useful reviews for that [08:43:34] if viewership is below our base % then its not officially supproted [08:43:48] tfinc: :( [08:44:11] jdlrobson: so, essentially, we revert 'official' wikipedia app to native one, and then rename phonegap one to something else marked 'unstable'? [08:44:46] when i drop my phone in the toilet, then i get a new one ;) [08:44:51] thats always been the case. endlessly trying to support every version means we don't reach anyone else. causing to fail our community and donors. we can't do that. and besides. iOS users upgrade faster then any other platform [08:45:00] Considering that'll actually improve our ratings, I'll do a +0 on that [08:45:01] jdlrobson: ^ [08:45:03] kind of... only i wouldn't call it official and in the description I'd say development on this has ceased and we are working on a new app (linking to it) [08:45:22] so encourage people to move to the new app [08:45:37] eventually when downloads get low enough we remove it from itunes store altogether [08:46:23] jdlrobson: what are your thoughts on page curl mockup for attribution ? [08:46:28] although we'd have to think about such a move carefully to avoid confusing people [08:46:59] jdlrobson: yes, 'auto updating' them to an older app might not be the greatest idea [08:47:08] yeh [08:47:20] * jdlrobson doesn't have an iphone so is not familiar with the update process [08:47:57] sounds tricky [08:48:03] tfinc: i really like it - my main worry is how the transition works. If people see a page curl I'd expect a fancy animation which is something I haven't looked into. I'm not sure how achievable it is on older devices [08:48:12] jdlrobson: i'm not enamored by it. using a page curl to trigger another browser to open is bizarre [08:48:18] YuviPanda: if we added a link in the description to the old app would people find it [08:48:29] people would, i'm not sure how apple will like it [08:48:34] a page curl should show a smaller set of text . here we'd be opening the browser and taking them to view history [08:49:11] so tfinc I was imagining it would give the illusion of looking on the back of the page [08:49:28] jdlrobson: right but that means were doing something pretty fancy here [08:49:45] but now I think more... maybe that would make more sense for an edit function [08:49:45] which as you said compatibility wise would be tought [08:49:47] tough* [08:50:06] i'm don't think the page curl is going to work [08:50:09] * tfinc wonders what else we could do [08:50:13] * YuviPanda likes a simple link :) [08:50:13] worse case scenario tfinc we could just not show the page curl and show a button for legacy browsers [08:50:29] YuviPanda: the link is simple. too bad its hideous looking [08:50:30] tfinc, are you sure you wanna se all our faces? :P [08:50:36] MaxSem: bring them on! [08:50:37] :D [08:50:41] well tfinc we'll have a new nav sometime soon - http://jonrobson.me.uk/wikipedia/experiments/nav/ :) [08:50:54] tfinc: can't it be made non-hideos? [08:50:57] we could put it in the menu on the left [08:50:58] hideous [08:51:08] jdlrobson: i need something before the nav bar or pete will (rightfully so) keep hounding us [08:51:16] (in the mean time placing it under the wikipedia icon menu) [08:51:22] yeah [08:51:26] i suggested that a while back [08:51:30] next to home and random [08:51:43] as people familiar with the W icon opening a menu will still click it on the new nav and get the same stuff [08:51:48] jdlrobson: that works for mobile web. but what about the app [08:51:54] the app is the main problem [08:52:12] actually.. and now I think about it linSmith wanted to keep page functions together [08:52:18] which would mean it would actually be in the sub menu [08:52:33] (e.g. button on right of screen) [08:52:42] we've transitioned those W options into the native menus [08:52:51] so we have to have something from the apps [08:53:18] if we give YuviPanda something pretty shiny then we could sneak it into the native menu [08:53:22] but I'm sure he'll revert it [08:53:23] ;) [08:53:37] * YuviPanda sneaks 'hand me a pony' into native menu [08:53:38] well in the app the search button doesn't do much right? - could we not replace that with the more icon which when clicked gives just the history icon [08:54:24] * tfinc raises YuviPanda to a rainbow unicorn  [08:54:41] New review: MaxSem; "I've made core's action=tokens extendable in https://gerrit.wikimedia.org/r/5781" [mediawiki/extensions/MobileFrontend] (master) C: 0; - https://gerrit.wikimedia.org/r/5771 [08:54:48] jdlrobson: so, currently building from master the app has *no* footer. I'm adding a variant of the footer, so I'll add a link to history there. We'll kill it when we have something better. [08:54:49] tfinc: ^ [08:55:11] another suggestion (I know it's awful) but for the app couldn't we just tuck contributors into the more menu.. [08:55:12] YuviPanda: jdlrobson i'm likely going to fall asleep soon. can you guys keep the conversation going and find something else that will work [08:55:28] jdlrobson: that's what tfinc meant by the 'native' menu :) [08:55:33] ah sorry [08:55:38] but yeh that seems to be the way to go [08:55:48] jdlrobson: so, the app currently has no footer. [08:55:53] as it does feel like it's going to end up in a more menu of some description [08:56:09] does the app need a footer? [08:56:29] are you talking about the "Text is available under the Creative Commons Attribution-ShareAlike License; additional terms may apply. See Terms of use for details. [08:56:29] Wikipedia® is a registered trademark of the Wikimedia Foundation, Inc., a non-profit organization. [08:56:29] Contact us" text ? [08:56:31] jdlrobson: so, it doesn't. we can put 'contact', 'privacy', 'about', 'disclaimers', 'terms of use' in settings [08:56:32] yes [08:56:38] so, what I suggest is [08:56:50] that we can just have 'Content available under CC BY-SA 3.0' as a footer [08:56:53] and link history out of there [08:56:59] yes agreed [08:57:17] * YuviPanda goes to do that [08:57:25] -> Content available under CC BY-SA 3.0 - view authors [08:57:31] something like that [08:57:35] I wouldn't use the word history [08:57:36] yup [08:57:46] authors/contributors/ [08:57:58] Content available under CC BY-SA 3.0 (Contributors) [08:57:58] so in the mobile app I'll stick it in the W icon [08:58:03] if tfinc is fine with that [08:58:05] or view contributors. [08:58:23] * jdlrobson thinks [08:58:27] jdlrobson: i'm confused. I was suggesting putting this on the end of the page content (footer) [08:58:37] where that uglyish text is right now [08:58:46] sorry I meant mobile site [08:58:48] !! [08:58:53] ah [08:58:54] ok [08:59:09] why not have 'view contributors' next to the cc link in the site as well/ [08:59:11] ? [08:59:44] brion has checked in some wp7 code, I wonder what else it breaks :) [09:00:26] this sounds nicer -> Content provided by these people and available under CC BY-SA 3.0 [09:00:45] jdlrobson: re: your comment on the menu.js code. Our menu code is currently way too spread out and messed up. Should spend a cycle 'settling tech debt', but unsure when. Hopefully right after 1.2 [09:00:47] jdlrobson: agreed [09:01:07] I guess we'd need to check any copy text with phil [09:01:17] well, we can always add and change later [09:01:31] YuviPanda: agreed - the menu.js was a landmine field to walk through :) [09:01:43] especially since android code is different :) [09:02:05] brion likes overriding globals. but then again, it was essentially 'stick to the current code's style'. [09:02:18] jdlrobson: i'd reccomend checking out a commit that was 4-5 months back and looking around :) [09:02:20] I'll update the ticket suggesting the footer with text 'Content provided by these people and available under CC BY-SA 3.0' [09:02:26] ok [09:02:34] i'll take a break from saved pages and implement this. [10:08:04] So lucb1e my plan was to make a few tweaks to this url - http://bit.ly/JoIoZ8 - and you comment if they fix the scrolling [10:08:18] okay [10:08:41] i'm assuming in the current form the scrolling problem is present? [10:08:52] * lucb1e tries [10:08:57] yes [10:09:15] and there is a php error on top btw, but you'll probably see that too [10:09:57] yeh I just saw that shouldn't matter for our needs [10:10:02] okay [10:10:07] ok so I'm going to make a quick change [10:10:31] can you refresh now and tell me if the problem is still present? [10:11:02] it's still present [10:11:26] can you refresh now [10:11:32] is it still present? (toggling should break) [10:12:59] hm it's incedibly slow now, testing if my phone is doing something in the background... [10:13:13] as in the scrolling is even slower? [10:13:29] or as in loading? [10:13:34] sometimes the page is very slow to load :( [10:13:41] no I mean it lags, not less scrolling distance per click [10:14:07] Ok let me know when you've checked any background apps are not running [10:14:09] it's only on the wiki page, as soon as I switch to another website it doesn't lag anymore [10:14:23] ok [10:14:39] can you try now ... is it any better? [10:15:26] yes, no lag and normal scrolling distance! No toggling either btw [10:15:37] ok [10:15:43] try now [10:15:46] toggling should return [10:16:04] hopefully lag will not... [10:16:26] yes, and the scrolling issue is not present. The scrolling distance is normal (and there is no lag)! [10:16:38] ok it looks like its related to the search bizarrely [10:16:44] can you refresh one more time [10:16:46] that should confirm it [10:17:28] no scrolling bug anymore :) [10:17:30] and then I'll try and find a more specific reason :) [10:17:32] and toggling [10:17:35] ok [10:17:41] so now the scrolling bug is back yes? [10:17:45] (just updated) [10:18:02] yes [10:18:11] I think I know the problem... [10:18:37] refresh now.. [10:18:40] btw when I open something, then close it again, it says "ShowHideShow", the buttontext gets appended instead of replaced [10:19:08] scrolling problem appears again [10:19:20] ok.. so it wasn't what I thought :) [10:19:42] can you refresh now [10:19:47] well I don't know what you are trying, but it feels like we're getting close now :P [10:20:09] yup we are [10:20:11] scrolling problem appears again [10:20:27] how about now? [10:20:48] scrolling problem appears again [10:21:07] still? mm that's very strange [10:21:38] reloaded again after you said "still?", and yes it still appears [10:22:03] try reloading now [10:22:08] I'm just double checking it is search related [10:22:15] this could well be a memory problem [10:23:02] scrolling problem is present [10:23:13] ok... just to check are you on the beta or the normal version [10:23:28] the beta has images for arrows, the normal version has buttons with 'show' text [10:23:36] I think you have the normal version so this is most strange [10:23:52] where should I see that? [10:24:03] I'm just reloading whereever it redirects to after that bit.ly link [10:24:59] oh wait just read where I can see that (missed it) [10:25:13] yes the normal version, I have toggle buttons [10:25:20] ok great [10:25:34] if you refresh now is the problem still there - just checking this is not caching related [10:25:55] was thinking about caching too, but this worked before... Anyway, reloading and trying now... [10:26:10] the problem is not there now [10:26:15] it works normal [10:26:19] right it was caching related.. this makes more sense now [10:26:49] refresh now - if the scrolling problem is still not there I think I've worked out the problem :) [10:27:21] the problem is not there now! [10:27:42] and if you refresh now is it still there? [10:27:49] *still not there [10:28:09] indeed, still not there [10:28:29] and now if you refresh it is back :) [10:28:52] indeed! [10:29:02] awesome.. we have a fix :) [10:29:06] yay :D [10:29:07] thanks so much [10:29:18] especially you, you did all the work :P [10:29:19] * jdlrobson does a dance [10:30:17] hmm how fast does stuff get updated on the live wikipedia website? [10:30:33] we do a deployment every Monday [10:30:38] sometimes more often [10:30:47] that's Monday afternoon PST [10:31:11] okay, and after that it's until everyones cache has refreshed by itself or do you make sure it expires? Just wondering [10:31:24] so Tuesday AM next week at the latest the problem should disappear... although saying that we also have a new design mOnday [10:31:28] have you seen the beta? [10:31:42] if not -> http://bit.ly/Jnjabh [10:31:47] I don't think I've seen it [10:31:50] you might want to check that works in your Nokia as well :) [10:32:28] actually, it lags hugely [10:32:36] eek [10:32:42] we should look into that as well [10:32:46] if you have the time? [10:33:03] hmm I think I can make the time [10:33:17] right does the lag disappear now? [10:33:28] it's possibly related to the last problem [10:33:35] if I drop out at some point, I'll either reappear within about half an hour or contact you via email again (or just check if you're here some other time) [10:33:37] * lucb1e checks [10:33:39] ok no worries [10:33:48] hopefully this will be quicker now we know what caused the last one [10:34:16] no lag and no scrolling issue now :) [10:34:24] ok yeh so it's search again.. let me see [10:34:26] and the toggle buttons still "ShowHideShowHide" [10:35:15] how about now? [10:35:35] (hm when I visit the page on my pc there aren't even buttons lol) [10:35:48] scrolling is fine and no lag [10:35:52] yep the new design has no icons [10:35:56] no buttons [10:36:00] icons instead on the far right [10:36:01] well it does on my phone :P [10:36:55] how about now.. does the lag return? [10:37:34] no lag [10:37:42] (and no scrolling issue) [10:37:57] oh and no buttons now [10:38:07] but the lag returns now? [10:38:08] looks neat :) [10:38:15] sounds like caching problems [10:38:16] nah there is no lag [10:38:28] if you refresh now there should be lag...? [10:38:37] oh, /me refreshes [10:38:52] no, there isn't any problem now [10:39:27] does search work you as well? [10:39:50] If you search for San you should get several results (although they might be slow to appear) [10:40:48] search results should look a bit like this - http://www.mediawiki.org/wiki/File:Mobile_min_A.png [10:40:49] hm when I mouseover the search the whole page goes blank and it lags hugely, the only thing visible is my cursor (which changed to a pointer/hand), the php error on top and an icon that was to the left of the search [10:41:21] attempting to click the now invisible searchbar, it does focus. Let's try searching... [10:41:36] it sounds like a host of caching problems :-S [10:41:42] this server is not brilliant [10:42:16] lag disappeared as soon as I selected the bar, typing something results appear rather quick and I can click them [10:42:41] ok but there is lag when you scroll the page? [10:42:54] no [10:43:00] ok great [10:43:04] so I think we're okay then [10:43:49] so when I mouseover it, it lags for some reason, when I focus the field the lag disappears, when I mouseout the field the lag disappears (or blur by moving the mouse out works too) [10:44:14] how very strange [10:44:25] it's workable, but not sure if everyone will get what's happening, especially since the search bar disappears (though the cursor is still a hand/pointer) [10:45:15] ok as long as it's workable [10:45:21] the search sounds like it needs a bit more tweaking though [10:45:45] might be good if it didn't do anything on mouseover [10:47:46] does the issue happen now if you refresh? [10:47:52] on a mouseover [10:48:33] yes [10:49:05] and only when I mouseover the search box, the wikimedia logo on the left or search icon on the right is no problem [10:50:14] hm one thing changed though, the page doesn't disappear anymore as I mouseover the searchbox [10:50:22] yeh that's what I changed [10:50:23] :) [10:50:30] if you refresh now.. same problem? [10:50:52] yes [10:51:39] most bizarre [10:52:53] if you create a debug output div below the search, I can tell which ones appear before it lags (and it lags so much that every mousemovement takes seconds, plenty of time to read "action $i executed" [10:53:24] and it's only mouse mouse movement over search? [10:53:27] so just put those messages all over the js and try :P Or that's how I'd try this [10:53:38] hm I don't have a tab button or touchscreen [10:53:45] there is no other way to reach it [10:53:51] if that's what you meant [10:54:17] so to be clear you are saying that when you move your cursor over the search box lag appears? [10:54:23] but it's only when you go over the search? [10:56:58] I'm not sure what you exactly mean (the diff between 'search box' and 'search'), but this is the area that makes the problem occur: http://g2f.nl/0mr78bi [10:57:34] (printscreened on pc, the problem only occurs on my phone of course) [10:57:59] thanks that helps a lot [10:58:05] and if you refresh now is the problem still present? [10:58:17] also the text "Type your search here" disappears onmouseover [10:58:19] * lucb1e tries [10:58:42] problem is still there [10:58:53] you sure this time that it's not caching related? [10:59:02] and now? [10:59:15] it shouldn't be caching related.. i'm updating cache as i make the fixes [10:59:26] oh I meant browser cache [10:59:31] not sure how caching works on the server's side [10:59:39] problem is gone! [10:59:40] I'm forcing you to download new js each time so don't worry :) [10:59:44] *trying search itself* [10:59:56] search will be broken now :) [11:00:11] indeed [11:00:29] mm [11:00:32] so that's very weird [11:01:40] ok try now [11:01:42] is the problem still gone [11:01:45] search should work this time [11:02:39] problem reappears [11:02:51] eek [11:03:05] and search broke [11:03:35] hm as soon as something is inputted in the search, there is no problem anymore when I mouseover [11:03:49] how about now? [11:03:51] emptying the box makes the problem appear again [11:03:55] oh! Maybe I know what this is! [11:04:03] I just saw an autocomplete flash by [11:04:25] yeh I think I know the problem [11:04:27] takes ages for that to load when the box is empty (so it matches * and shows all my thousands of previous searches) [11:04:28] if you refresh it should be okay? [11:04:33] let's try [11:06:40] the moment I mouseover the page disappears like I described before, but search works [11:07:08] mouseout'ing the box, the page does not reappear [11:07:11] Yes the page should disappear.. I think maybe it's just not rendering nicely in your browser [11:07:55] you might want to make it disappear onclick/onfocus instead of onmouseover, every time someone scrolls past it now... [11:08:42] the weird thing is it should disappear only on a click.. I'm not sure why your browser is triggering the event [11:09:02] oh, that'd explain why so many websites have this [11:09:07] if you refresh now the problem is still gone yes? [11:09:08] well, many, far from all [11:09:15] * lucb1e tries [11:09:49] lag issue reappears [11:09:55] ohh no! [11:10:37] ok so what is happening here is that your browser as you hover over the search is repeatedly firing blur and focus events [11:11:03] this is most annoying [11:11:21] trying with an own page with only a
lipsum
on the middle of the page, it never fires the event except when I click the div [11:11:24] if you look now the problem goes away? [11:12:04] yes, works perfectly now [11:12:43] ok [11:12:46] only onclick the page disappears and when I type the search is working (although slowly) [11:12:51] i'll have to think about this a bit more but I have a few ideas [11:13:04] yep that's the correct behaviour [11:13:08] it will be quicker on a faster device [11:13:16] the problem is you are seeing an empty search screen [11:13:22] (the page is underneath) [11:13:27] possibly a problem with our design [11:14:37] yeah the device isn't too fast, but most things go alright with enough patience :P [11:15:04] great [11:15:11] well I'll get some fixes out sometime today and update the ticket [11:15:25] I really appreciate you taking the time to help me troubleshoot this - so much harder without a real device! [11:17:53] yes I can imagine how hard and annoying it must be to debug [11:18:09] and well, doing this also improves reading wikipedia from my phone for me, you're spending all this time on it ;) [11:18:27] is it possible to see how many users have a symbian s60v3 device or even this E75? [11:19:09] We have tables somewhere.. [11:19:11] I'm trying to find [11:21:04] http://stats.wikimedia.org/wikimedia/squids/SquidReportClients.htm [11:21:56] I guess the information is somewhere in there! [11:23:36] haha, well it's not findable with ctrl+f when searching 'e75' or 'symbian', let's see what my browser useragent is and if I can find anything with that :P [11:24:26] still neat to see that detailed data, statcounter's global stats are good for an overview but this is really an in-depth look [11:25:31] hm nokia is in there [11:25:45] can you check something for me if you still have your nokia handy? [11:25:53] I can [11:26:06] http://bit.ly/JoIoZ8 [11:26:14] is scrolling lag present there? [11:26:48] no scrolling lag, but there is the scrolling distance per click-problem [11:27:32] scrolling distance per click? [11:28:27] the original problem I reported on bugzilla [11:28:35] ahh that's what i meant [11:28:38] so every time I click it only moves half the distance it should [11:28:39] ok that's not a good solution then :) [11:28:40] okay [11:29:41] hmm, that sortof half-sounds like the iOS 5.1 scrolling problem [11:32:06] lucb1e: have thought of a different fix [11:32:08] can you refresh now? [11:32:11] it should go away [11:32:17] if so I'll push the fix and close the bug [11:33:32] argg actually that's no good either! [11:33:38] scrolling works good now [11:36:44] ok looking into the beta now [11:42:48] 1 last test lucb1e is the mouseover lag present in http://bit.ly/Jnjabh [11:44:00] no lag, search works, page disappears onclick, no scrolling dist/click. Perfect :) [11:44:29] awesome [11:44:32] will push the fixes [11:44:43] :D [11:47:24] I'm going to go, thanks a lot for fixing this issue! :) [11:47:49] if there ever is anything, just call on me by e-mail! [11:48:01] see you [11:49:24] New patchset: Jdlrobson; "fix for bug 32773" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5788 [11:49:25] New patchset: Jdlrobson; "better beta support for nokia E75" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5789 [12:00:06] * jdlrobson is disappearing for lunch [12:49:28] New review: Amire80; "I didn't review the code in detail, but the problem described in bug 35911 doesn't appear any more i..." [mediawiki/extensions/MobileFrontend] (master) C: 0; - https://gerrit.wikimedia.org/r/5361 [12:57:53] I like how tiny things turn into huge marathons. [12:58:05] * YuviPanda continues to try to find out how to force a link to open in external browser [14:22:38] New patchset: Logicwiki; "Fix sitename-footer message" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5797 [14:27:46] New review: Demon; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/5730 [14:27:49] Change merged: Demon; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5730 [15:18:33] New patchset: Jdlrobson; "reduce max-height property for smoother animations" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5801 [15:18:34] New patchset: Jdlrobson; "dismiss keyboard when scrolling through search" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5802 [15:18:54] New review: MaxSem; "(no comment)" [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/5797 [15:21:10] New review: Jdlrobson; "Needs review by Arthur on ICS before merging in" [mediawiki/extensions/MobileFrontend] (master) C: 0; - https://gerrit.wikimedia.org/r/5801 [16:12:04] New patchset: preilly; "Fixes: * Bug 36213 - [CSRF] Special:MobileOptions/DisableImages needs token ** https://bugzilla.wikimedia.org/show_bug.cgi?id=36213 * Bug 36194 - Image enable/disable requires page reload to work after tapping link in beta ** https://bugzilla.wikimedi" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5771 [16:12:16] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5771 [16:17:40] New review: MaxSem; "(no comment)" [mediawiki/extensions/MobileFrontend] (master) C: 0; - https://gerrit.wikimedia.org/r/5771 [16:19:14] New review: Catrope; "What Max said. Looks good to me otherwise." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/5771 [16:28:03] MaxSem: you there? [16:28:07] yup [16:30:12] MaxSem: so I don't want to use action=tokens right now because it's not in core yet [16:30:19] MaxSem: in 1.19 for example [16:30:41] do we still have 1.19 wikis? [16:30:54] MaxSem: almost everything is 1.19 still [16:31:04] preilly, also - do you make that API request for every page view? [16:31:05] MaxSem: we only have a few 1.20 test wikis [16:31:28] MaxSem: yes, right now it's for every page view [16:31:37] MaxSem: I guess I could cookie it [16:31:41] also needs to be fixed [16:31:58] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -2; - https://gerrit.wikimedia.org/r/5771 [16:32:30] preilly, I don't mind a temporary hack if it dies as soon as we have 1.20 everywhere [16:35:14] MaxSem: okay [16:35:37] MaxSem: so how do you think we should handle the api request? [16:37:28] what do you mean, how API should provide the token? create a tiny ApiTokensGetTokenTypes hook handler [16:37:36] MaxSem: no not that [16:37:55] MaxSem: e.g, should I make the request once and store the result in a temporary cookie [16:39:18] preilly for tracking the token? [16:39:21] for how long do our sessions live? what will happen if some anon's session expires? [16:40:06] awjr: for the mobile token [16:40:13] awjr: for CRSF protection [16:41:02] MaxSem: I'm not sure what the session expiry is [16:41:07] preilly that's how i've done it before and i believe how MW handles CSRF prevention tokens anyway (for editing, login, etc) [16:42:26] i had to set something similar up for credit card donations and we would expire the token after successful form submit, although that doesn't make sense here [16:42:53] perhaps it would make sense to expire the cookie at the end of their session - ie when they close the browser [16:43:36] awjr: okay [16:44:35] hey awjr you there? [16:44:40] jdlrobson yo [16:44:49] i just saw your email about bug 36190 [16:44:52] did you get my latest email about contact us - problems with beta_common [16:44:55] and that yep brilliant :) [16:45:04] i'll test it on labs after the standup [16:45:09] * jdlrobson really hopes that fixes 36190 [16:45:26] jdlrobson what was the problem with beta_common? [16:45:52] mine seems to be outdated but I might be wrong [16:46:01] it has stuff related to contact us form styling in it [16:46:20] jdlrobson it's possible that there are artifcats that i incorrectly merged last time i fetched changes from master [16:46:33] possibly ill do a git blame and see what i find [16:46:39] as long as the other stuff is in there :) [16:46:53] :) [16:46:56] it also has references in there.. [16:47:30] and search :S [16:47:58] jdlrobson: it is likely my fault [16:48:11] mm [16:48:17] does look like a weird merge [16:48:21] i remember the merge for beta_common being funky :( [16:48:27] ill scan through beta_common history [16:50:04] i think possibly something went wrong here https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/MobileFrontend.git;a=commit;h=17ab5cf98bda2bf51e72705a2f42f3fa82a0324d [16:51:23] aye [16:51:57] jdlrobson i would believe it - iirc the other files seemed straightforward but there was something weird about beta_common [16:52:23] yeh it was at the time we separated all the css into separate files [16:52:30] i should have communicated that better with you [16:54:39] i'll have this sorted in a jiffy [16:56:30] doh sorry about that [16:58:03] how do i redo a merge? [16:58:28] basically the resulting patch of git diff -R fb2c09a5ca6b3253e75784a2ae404aabb5f992dd...17ab5cf98bda2bf51e72705a2f42f3fa82a0324d stylesheets/beta_common.css [16:58:43] needs to be applied at 17ab5cf98bda2bf51e72705a2f42f3fa82a0324d [16:59:00] can I do a git rebase --interactive on a local branch or does that have to be done by you ? [16:59:19] im not sure [16:59:22] preilly might know ^ [16:59:43] basically all of the red in https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/MobileFrontend.git;a=blobdiff;f=stylesheets/beta_common.css;h=bcbff17e7f1edf37f771302600f5e71e1d6f1e50;hp=6995bdba37f14c10277208d332bdec7e3064542a;hb=17ab5cf98bda2bf51e72705a2f42f3fa82a0324d;hpb=0efdb21438618b9ec7e255e7478616b91656c3b1 needs to disappear [16:59:53] I'm pretty sure if you do git rebase --interactive fb2c09a5ca6b3253e75784a2ae404aabb5f992dd [17:00:31] give it a whirl [17:01:13] ok … let do our standup [17:05:56] tfinc: so far nothing from you? [17:06:11] YuviPanda: i called you.. no response [17:06:20] tfinc: from which one? [17:06:34] tfinc: google plus? [17:06:40] or did i jump the gun? [17:06:43] skype [17:06:46] its not monady [17:06:46] ugh [17:06:54] monday* [17:07:00] call me in again? [17:07:15] unless it is too late.. [17:08:00] * YuviPanda notes to not read emails when just woken up [17:11:22] btw for making the beta live does anyone have any issues with just switching $wgMFConfigProperties 'isBetaGroupMember' to true for this iteration ? < awjr preilly [17:11:45] also awjr I'm struggling to work out how to correct that merge.. never done this before :S [17:11:48] jdlrobson you mean in produciton? [17:11:57] jdlrobson: I'm getting a Uncaught TypeError: Cannot call method 'readCookie' of undefined when I try to call MobileFrontend.banner.readCookie( 'mobileTokenCookieName' ); [17:12:17] is banner.js loading preilly ? [17:12:25] or are you on minified js? [17:12:31] we should really move that cookie handling code out of banner.js [17:12:36] jdlrobson: yes [17:12:50] um [17:13:05] i'll look at that in a sec but I don't know of any reason why that would be happening... [17:13:12] YuviPanda tfinc : https://bugzilla.wikimedia.org/show_bug.cgi?id=34292#c11 <-- [17:13:15] jdlrobson: it's on my local box [17:13:16] (i like the suggestion) [17:13:31] jdlrobson: you've a pull request. [17:13:42] jdlrobson: so, that didn't fit in on one line, so I used something slightly different [17:13:52] ok .. so lets talk attribution [17:13:53] YuviPanda: yep seen I'll merge them in either later tonight or first thing tomo if that's okay? Still very much in MobileFrontend mode [17:13:58] jdlrobson: YuviPanda whats your current idea? [17:13:59] jdlrobson: sure. [17:14:01] jdlrobson: does opting OUT of the beta set a cookie for users, or just unset the beta opt in cookie? [17:14:09] tfinc:https://bugzilla.wikimedia.org/show_bug.cgi?id=34292#c11 <--idea [17:14:13] jdlrobson: tfinc let me get you a screenshot. it's been implemented [17:14:17] jdlrobson: oh [17:14:19] just a link in the footer [17:14:37] ok so awjr preilly hold that thought - I'll come back to your problems in a bit [17:14:46] kk [17:14:47] jdlrobson: if I console.log(MobileFrontend); I see Object [17:14:48] banner: Object [17:14:49] init: function init() { [17:14:51] readCookie: function readCookie( name ) { [17:14:52] arguments: null [17:14:53] caller: null [17:14:54] length: 1 [17:14:55] name: "readCookie" [17:14:58] So yes tfinc nothing special - but making better use of the copy text [17:15:02] jdlrobson: so that makes sense for mobile web. what about app. app doesn't have a footer [17:15:11] jdlrobson: yeah, i like that idea for mobile web [17:15:12] its elegant [17:15:22] with a rewording of "these people" [17:15:29] YuviPanda added a footer :) [17:15:33] interesting [17:15:41] YuviPanda: which branch should i pull to see it? [17:15:42] i'm setting up a screenshot, give me a second [17:15:51] tfinc: new-content-footer [17:15:55] on my repo [17:17:06] New patchset: MaxSem; "Fixed undefined index warning" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5815 [17:17:10] tfinc: jdlrobson https://bugzilla.wikimedia.org/show_bug.cgi?id=34292 [17:17:16] so preilly it sounds like whatever is calling MobileFrontend.banner.readCookie is doing so too early. Let me check [17:17:32] tfinc: i'll again note that I picked that text since it fit in one line. Very much iteratable [17:17:47] preilly, quick fix of that yesterday's warning^^ [17:17:55] though i'd want to cut down 'provided' too, so it reads 'From these people, under CC BY-SA 3.0' [17:18:21] preilly: I will jslint the code - I think I see the problem [17:18:56] tfinc: also left comments on that bug [17:19:05] k, i'm pulling the changes [17:19:09] might as well move it to application.js while I'm at it! [17:19:34] jdlrobson: can you hold off on moving it [17:19:40] jdlrobson: what do you think the issue is? [17:19:43] tfinc: ok. There's also a screenie at http://bug-attachment.wikimedia.org/attachment.cgi?id=10466 [17:19:51] jdlrobson: writeCookie works [17:19:59] jdlrobson: it's just readCookie that fails [17:20:29] well there are 2 things it could be - application.js uses it when you click desktop view - technically on a really really slow connection you might use the banner library before it's loaded [17:22:12] * tfinc spins up emu [17:22:15] jdlrobson: how come I can see it in console.log(MobileFrontend); [17:22:19] jdlrobson: but not call it? [17:22:20] YuviPanda: http://www.youtube.com/watch?v=dnlNGkMlbUU [17:22:40] philinje: take a look at the screenshot that yuvi sent http://bug-attachment.wikimedia.org/attachment.cgi?id=10466. its an alternative idea for attribution [17:22:52] you are saying you can't run MobileFrontend.banner.readCookie() in your console ? [17:23:09] srikanthlogic: lol, how did you find that? [17:23:18] works for me... [17:23:20] mm [17:23:28] YuviPanda: someone tweeted and I just searched [17:23:48] jdlrobson: I can do it in console: [17:23:49] MobileFrontend.banner.readCookie('mobiletoken'); [17:23:49] "abcdddf2c2e70e457f9ea591d34b2d3e" [17:23:59] jdlrobson: just not from toggle.js [17:24:05] ahhh ok [17:24:11] well toggle.js is executed straight away [17:24:16] and I believe toggle.js is loaded before banner.js [17:24:19] so it won't be loaded [17:24:22] awjr, ready for a performance talk? [17:24:26] preilly: do you have any problem with me setting up another MW instance on the mobile-enwp instance for my own testing/demoing? like, /var/www/arthur [17:24:35] MaxSem: sure [17:24:46] awjr: that's fine [17:24:46] simplest thing to do preilly is to move toggle.js below banner.js [17:24:53] MaxSem i haven't had the chance to dive particularly deeply to find the bottlenecks [17:24:57] long term we should stop them being self executing [17:25:40] awjr, quick testing with network tab in browser doesn't show any significant change in request times [17:25:43] jdlrobson: okay, that works [17:25:57] awesome [17:26:03] preilly: do you know how to fix a bad merge? [17:26:09] YuviPanda: jdlrobson i like the placement and general idea. i'm just thinking about how to reword it. "these people" sounds bizarre to me [17:26:17] philinje: what are your thoughts on the text? [17:26:23] yeh tfinc I didn't like that wording either [17:26:26] I couldn't find the right word [17:26:33] MaxSem one sec lemme take some screenshots for you [17:26:36] but i agree that it *has* to be short [17:26:47] tfinc: sure, as long as it is one line and has two links :) [17:26:54] yes YuviPanda [17:26:55] ;) [17:27:36] well how about.. Content provided by the Wikipedia community under the CC BY-SA 3.0 license [17:28:15] Or Content provided by the citizens of Earth under the CC BY-SA 3.0 license (a bit more fun) [17:28:23] we can rotate :P [17:28:33] MaxSem disregard the email i just sent you the screenshots didn't come out right [17:28:44] is this intended to be above the footer? [17:28:53] philinje: this is for the app [17:28:55] philinje: > https://bugzilla.wikimedia.org/attachment.cgi?id=10466 [17:28:58] which has no footer [17:29:24] question is whether there will be a footer in the apps [17:29:26] I actually like "Content provided by the citizens of Earth under a CC BY-SA 3.0 license" [17:29:39] philinje there won't be [17:29:48] jdlrobson: why 'provided' [17:29:48] as we don't need it for functionality [17:30:03] it needs a verb YuviPanda [17:30:05] Content carefully curated the citizens of Earth under the CC BY-SA 3.0 license [17:30:12] *curated by [17:30:21] "Content written by Wikipedians, provided under CC BY-SA 3.0" [17:30:25] standard language could be "By these contributors under CC-BY-SA 3.0" [17:30:28] Content carefully screened by the content cabal? [17:30:29] +1 tfinc [17:30:34] +1 on tfinc [17:30:39] :) [17:30:50] MaxSem: i just sent an email to your gmail account, subject 'xhprof summary stats' [17:31:10] it has two screenshots of the xhprof summaries - one for what's in master, one for your skin rewrite changes [17:31:17] could also make this more personal > Content written by Wikipedians for YOU and provided under CC BY-SA 3.0 [17:31:26] jdlrobson: too long [17:31:30] YuviPanda: will hate you for that [17:31:31] "by Wikipedians" has two issues: sounds a little exclusive and doesn't imply the particular contributors of this article [17:31:37] font-size is your friend :) [17:31:54] we can fontsize it, or we can actually make it two lines [17:32:00] written by on one and license on the other [17:32:07] actually [17:32:09] "Article written by .. blah blah" [17:32:13] we can have content written on one line [17:32:16] s/Content/Article [17:32:17] and the cc iconography? [17:32:37] better without the iconography, i think [17:32:40] perhaps we should xhprof set up on our labs instance [17:32:53] philinje: any particular reason? [17:32:54] awjr: virts are not meant to be performance tests [17:33:02] guys I have to shoot off in a bit but I'm planning on being online later in the evening - before I go awjr I would quite like to solve that merge issue [17:33:10] awjr: virts are meant for functional tests [17:33:16] tfinc good point [17:33:25] YuviPanda: one of our lawyers had a reaction to it previously, bit hard to explain [17:33:25] it would be nice if we had a common reference point though [17:33:33] awjr: I'm reading an article and it starts with .. "The merge was pushed [17:33:34] This is Hard." :-S [17:33:36] awjr: if you need a performance tests steal a cluster box and point real traffic to it ;) [17:33:40] awjr: but, a VM will never be [17:33:51] awjr, first page load after code changes is always slower, does it repro after a few reloads? [17:33:52] jdlrobson: sending you an email - can you do the TOC differently in the mock-ups? [17:34:03] awjr: a VM can fluctuate throughout the day wildly [17:34:14] philinje: I can but it's going to be later in your day now... [17:34:14] that makes sense [17:34:16] * MaxSem rushes to install xhprof [17:34:16] terrible idea. [17:34:19] awjr: agreed but a virt will never be that [17:34:21] jdlrobson: what time will you be back? [17:34:40] I'm planning around 11pm/0am my time for a couple of hours [17:35:09] ok [17:36:11] * tfinc steps into a meeting while noodling on this [17:36:24] tfinc: philinje i'd still want to try out the iconography. [17:36:32] what icons are we thinking ? [17:36:40] tfinc: the CC By-SA icons from CC? [17:36:49] YuviPanda: to make it shorter? [17:37:00] tfinc: we'll have the first part as text - it can be longer as well. second part instead becomes an icon on next line [17:37:01] yes [17:37:16] plus, I think the icons have enough of a recognizable value already for it to make sense [17:37:52] philinje: what caused us to *not* use the icons on the mobile web footer ? [17:38:08] * YuviPanda notes that bandwidth is not an issue here. [17:38:22] back later! [17:38:23] YuviPanda: the problem for the lawyer was the recognizable value of the icon drew attention away from the Wikipedia-specific nature of the license [17:38:36] the license is Wikipedia-specific? [17:38:50] New patchset: preilly; "Fixes: * Bug 36213 - [CSRF] Special:MobileOptions/DisableImages needs token ** https://bugzilla.wikimedia.org/show_bug.cgi?id=36213 * Bug 36194 - Image enable/disable requires page reload to work after tapping link in beta ** https://bugzilla.wikimedi" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5771 [17:39:27] philinje: http://en.m.wikipedia.org/wiki/Wikipedia:Text_of_Creative_Commons_Attribution-ShareAlike_3.0_Unported_License?useformat=mobile this looks boiler plate cc by sa to me [17:39:33] YuviPanda: like i said, a bit hard to explain here, but it seemed to say more about CC than the fact that this was Wikipedia [17:39:34] +1 on tfinc [17:39:39] the context was the footer [17:40:04] that feels like 'let us not dilute the brand' to me :) [17:40:08] MaxSem, awjr: can you look at https://gerrit.wikimedia.org/r/#change,5771 again [17:40:09] CC and Wikipedia are on the same side here, no? [17:40:15] i would think so [17:40:19] so that is why we went with the word Wikipedia on the top line of the footer [17:40:48] it would be ok to put Wikipedia together with the icon [17:41:00] that was just the feedback from one lawyer [17:41:19] a small version of http://mirrors.creativecommons.org/presskit/buttons/88x31/png/by-sa.png [17:41:31] New patchset: preilly; "Fixes: * Bug 36213 - [CSRF] Special:MobileOptions/DisableImages needs token ** https://bugzilla.wikimedia.org/show_bug.cgi?id=36213 * Bug 36194 - Image enable/disable requires page reload to work after tapping link in beta ** https://bugzilla.wikimedi" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5771 [17:41:44] brion: can you shoot out a email to wikitech about the phone gap / microsoft hackatnon ? [17:41:45] philinje: tfinc that sounds very much like 'let us not dilute our brand' to me [17:41:56] because the license *is* cc by-sa, nothing specific [17:42:12] its a copy and paste :D [17:42:14] yes, but the appearance was the issue [17:42:16] tfinc, shall i repost my mail to mobile-l? [17:42:21] ohh [17:42:21] you mailed [17:42:23] nm thne [17:42:33] i'll haven't gone through todays emails yet [17:42:37] thanks [17:42:38] we can try it and run it past more lawyers [17:42:39] \o/ [17:42:56] so lets come up with two versions [17:42:59] 1) with logo [17:43:01] 2) sans logo [17:43:31] tfinc: okay. [17:43:41] actually [17:43:43] what about [17:44:05] "Article contributions provided under CC BY-SA 3.0" [17:44:31] i just checked with Ironholds who tells me we're plain vanilla unported CC BY-SA 3.0 with nothing extra [17:44:32] Similar to my suggestion: By these contributors under CC-BY-SA 3.0 [17:44:40] tfinc: i'll use that as text, and do one with the image. [17:44:44] YuviPanda: k [17:45:30] [17:45:34] woot! [17:46:50] brion: also, I was unaware of http://en.wikipedia.org/wiki/Brion_Vibber [17:46:59] :) [17:53:20] i *am* MediaWiki! ;) [17:53:34] brion: Indeed :) [17:53:37] * YuviPanda patches brion  [17:53:52] tfinc: another issue is how we surface the attribution in the mobile site, as this kind of raises the bar [17:54:05] MaxSem: it's possible those numbers i sent you are not accurate relative to eachother. patrick reminded me i was testing those on my local VM, which has tomasz and patrick were just talking about, is not a reliable place to do performance testing [17:54:47] philinje: this is simply interim. you and lindsey need to find the real home for it [18:00:53] well, whether it is interim or not, we will live with this for a while [18:02:43] YuviPanda: can you add the mock-ups to this page: https://www.mediawiki.org/wiki/Mobile_design/Contributors [18:05:55] tfinc: how do you think we should respond to http://www.newscientist.com/blogs/onepercent/2012/04/bloated-website-code-drains-yo.html [18:07:13] philinje: will do, but i'll again note that they're not really mockups but actual code :) [18:07:33] preilly: i think the first comment says it all [18:07:48] talk about that [18:07:50] resource loader [18:07:58] skin changes [18:07:59] etc [18:08:03] tfinc: okay [18:31:17] tfinc: http://etherpad.wikimedia.org/bloated-website-code-drains-yo [18:31:33] "drains yo!" [18:31:41] reading [18:33:00] MaxSem: ha ha [18:33:11] preilly: what about touching on the comment from the very first article ? [18:33:50] preilly, we don't even fully use RL [18:35:23] New review: Catrope; "I don't really understand why the token is fetched from the API (and then cached in a cookie for per..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/5771 [18:36:01] New review: Catrope; "(no comment)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5771 [18:38:00] New review: MaxSem; "Roan, HTML is cached." [mediawiki/extensions/MobileFrontend] (master) C: 0; - https://gerrit.wikimedia.org/r/5771 [18:40:17] MaxSem: but, we will moving forward [18:41:14] MaxSem: hence me stating, "So, one of the ways that we are looking to improve our mobile browser energy consumption is by implementing..." [18:44:23] preilly the latest patchset for the CSRF proteciton stuff seems to be missing one of Max's points from an inline comment on patchset 8 in regards to people running wikis with .php5 extension [18:45:19] preilly out of curiosity, do we have any idea what percentage of our mobile have javascript disabled/not supported? [18:50:50] awjr: .php5 isn't supported in opensearch.js either [18:51:09] :( [18:51:31] awjr: we don't have hard numbers on disabled javascript [18:55:28] New review: Catrope; "Patrick explained that the HTML is cached in Varnish, so the token can't be output there. There's a ..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/5771 [18:58:21] tfinc: regarding http://etherpad.wikimedia.org/bloated-website-code-drains-yo what do you think? [18:58:59] New review: awjrichards; "To Roan's point, we don't really know what percentage of our users have JS enabled or not supported...." [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/5771 [18:59:01] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5771 [18:59:32] tfinc: preilly: what about touching on the comment from the very first article ? [19:00:15] tfinc: http://www.newscientist.com/blogs/onepercent/2012/04/bloated-website-code-drains-yo.html [19:00:27] tfinc: subpixel on April 18, 2012 5:15 AM ?!? [19:00:55] preilly: Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5771 [19:02:53] MaxSem: were you able to get xhprof installed and configured? [19:03:12] awjr, Fatal error: Class 'XHProfRuns_Default' not found in /var/www/w/xhbottom.php on line 5 Call Stack: 0.0002 645592 1. {main}() /var/www/w/index.php:0 0.7303 39180448 2. require_once('/var/www/w/xhbottom.php') /var/www/w/index.php:62 [19:03:42] MaxSem: preilly helped me get things set up, he can probably help you get it sorted [19:03:42] I'm using http://techportal.ibuildings.com/2009/12/01/profiling-with-xhprof/ [19:04:16] MaxSem: At the moment, XHProf is only available for Linux and FreeBSD (and is expected to work with Mac OS). [19:04:22] MaxSem: Aren't you on Windows? [19:04:29] MaxSem there's some magic you can do that will make it so you don't have to do stuff like 'xhprof_enable(XHPROF_FLAGS_CPU + XHPROF_FLAGS_MEMORY);' [19:04:47] * MaxSem is on everything VirtualBox supports [19:05:04] MaxSem: so, are you using this in a VM? [19:05:09] MaxSem does that mean you're setting up xhprof in a vm? [19:05:11] jinx [19:05:30] yus [19:05:56] MaxSem: what OS? [19:05:57] even in VM, MW works faster than on Windows;) [19:06:05] Ubuntu 10.04 [19:06:10] MaxSem: take a look at this then: http://stojg.se/notes/install-xhprof-for-php5-on-centos-ubuntu-and-debian/ [19:07:56] awjr: can we push that last change live? [19:08:26] preilly i don't see why not [19:08:45] im off for lunch, back in a bit [19:21:06] tfinc: philinje updated https://bugzilla.wikimedia.org/show_bug.cgi?id=34292 [19:21:16] tfinc: very much a fan of http://bug-attachment.wikimedia.org/attachment.cgi?id=10469 [19:21:17] philinje: ^ [19:21:30] * tfinc is on a call [19:23:08] preilly, I'm getting "Invalid Run Id" in xhprof UI [19:25:50] NVM [19:30:59] New patchset: L10n-bot; "Localisation updates from http://translatewiki.net." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5838 [19:31:16] awjr, my results are different from yours: master 419ms, skin-rewrite 313ms [19:32:02] (I pressed F5 several times before taking measures after a branch switch) [19:40:54] hmmm, master displays no page text on 1.0.04 for me, unlike my branch, whattha...? [20:06:47] alright, i'm off. [20:07:07] tfinc: philinje please do leave comments on the bug for the footer. [20:07:39] the fastclick implementation is also in. should fix the biggest 'sluggish' complaint though :) [20:07:40] gnite everyone [20:13:40] MaxSem: yeah, it hadn't occurred to me previously, but perf testing in a VM will likely not give accurate results [20:14:37] awjr_lunch, at least the numbers for skin's output() are very similar [20:15:40] awjr, my point is that you shouldn't measure performance on the first page view, it will be much slower than consequent ones [20:15:41] we should figure out a way that we can do reliable performance testing for this kind of stuff [20:16:07] MaxSem: indeed, but even locally my numbers vary wildly upon subsequent requests [20:16:16] awjr, get someone with a Linux as a primary OS? [20:16:50] well i think it would be cool if we had a box we could all access [20:16:55] * preilly listens to "Hits From The Bong" — Cypress Hill Black Sunday (Explicit) ♫ [20:17:03] non-Labsy [20:17:08] yep [20:17:13] it needs to be actual hardware [20:17:22] preilly: great song. [20:17:24] awjr: binasher and I can figure something out [20:17:29] \o/ [20:17:34] that would be dope. [20:18:41] preilly did you get your changes pushed out? [20:18:48] awjr: nope [20:19:01] awjr: do you think we should or wait? [20:19:51] mmm, I think I've ruined Apache on my VM [20:20:02] requests simply hang [20:20:03] preilly: i feel like i've got a lot to do and am not stoked about doing a deployment right now. since i don't think the issue is particularly serious, it's probably fine to wait until Monday [20:20:17] awjr: okay agreed [20:20:20] word [20:21:42] awjr, so my opinion is that there's no significant difference in performance [20:22:00] MaxSem you are testing in a VM? [20:22:10] based on both VM and non-VM observations [20:22:24] observations?!? [20:23:24] how else can you call profiling that can give 50% inaccurate results? :P [20:23:35] MaxSem: ha ha ha [20:24:01] MaxSem wait so you've got xhprof #s from a non-VM? can we see them? [20:24:14] nope [20:24:21] then i dont believe you [20:24:33] :p [20:24:37] on Windows, I simply measured page load times [20:24:44] awjr: also you need to do these tests with no memcache or apc [20:24:51] aye [20:25:09] preilly how long do you think it will take to get something set up for perf testing? [20:25:31] awjr: not sure [20:25:45] I think I'll just try MW profiling [20:26:32] awjr: binasher is heading off to lunch but we'll talk after [20:26:54] cool [20:29:11] preilly im setting up a separate MW instance on our labs virt - can i git clone extensions directly into the extensions directory from a git checkout of core? [20:29:28] awjr: yes [20:29:35] that is rather handy [20:29:43] that always annoyed me about svn [20:30:37] awjr: I've got this script too http://pastebin.mozilla.org/1597238 [20:31:09] awjr: called git_pull_all.sh [20:31:10] preilly cool thanks [20:31:24] awjr: that way I can run one command and update them all at once [20:32:06] theres update-extensions.sh now [20:38:18] MaxSem: where is that located? [20:39:27] [WikipediaMobile] brion pushed 4 new commits to master: http://git.io/FLndHQ [20:39:27] [WikipediaMobile/master] Tweak to index.html - Brion Vibber [20:39:27] [WikipediaMobile/master] Merge branch 'master' of github.com:wikimedia/WikipediaMobile - Brion Vibber [20:39:27] [WikipediaMobile/master] Merge branch 'master' of github.com:wikimedia/WikipediaMobile - Brion Vibber [20:41:10] preilly: top level of /extensions I just discovered it myself, along with update_submodules.sh [20:44:05] MaxSem: that's not the same thing https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions.git;a=blob;f=update-submodules.sh;h=139870e69556f1e1530020c8d7ad61aa243da00f;hb=HEAD [20:44:42] MaxSem: I meant https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions.git;a=blob;f=update-extensions.sh;h=cfd31696c3b6b0efab9e2534014d76a0b0137177;hb=HEAD [20:45:04] yeah, but this one updates everything [20:45:42] MaxSem: yeah, but you don't need everything [20:50:42] preilly is there a copy of the enwiki sql file on the labs instance somewhere? [20:50:56] was starting to msyqldump it then realized it's rather large [20:51:04] awjr: nope [20:51:44] k [20:54:57] awjr: take a look at: http://www.percona.com/doc/percona-xtrabackup/howtos/setting_up_replication.html [20:56:38] preilly are you suggesting i replicate from the existing enwiki db on the labs instance to another db on the labs instance? [20:57:20] awjr: I was just trying to say use innobackupex to backup the existing one [20:57:27] ah roger [20:57:40] what does innobackupex do that mysqldump does not? [20:57:53] awjr, using native MW profiling: https://www.mediawiki.org/wiki/User:MaxSem/prof [21:01:30] cool MaxSem, pretty close [21:02:12] awjr, took me several F5s to pick lowest numbers in both cases even outside of VM [21:02:16] plus the rewrite appears to use less mem [21:02:40] MaxSem what do the 'Each' and '%' mean? [21:02:57] i presume 'Total' is running time? [21:02:59] each is time per call [21:03:01] in ms? [21:03:04] ah ok [21:03:23] % is dunno what:) [21:17:05] New review: Reedy; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/5838 [21:17:07] Change merged: Reedy; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5838 [21:30:08] New patchset: MaxSem; "Skin rewrite" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5361 [21:32:23] preilly or awjr, can you review https://gerrit.wikimedia.org/r/#change,5815 ? [21:33:32] MaxSem not this minute, about to go do an interview [21:58:57] [WikipediaMobile] brion pushed 1 new commit to master: http://git.io/vdoSKQ [21:58:57] [WikipediaMobile/master] Add solid color fallbacks to gradients for Windows Phone - Brion Vibber [22:04:54] MaxSem: that is already fixed in https://gerrit.wikimedia.org/r/#patch,sidebyside,5771,10,MobileFrontend.body.php [22:07:52] well, I committed it before it was merged:) [22:08:04] Change abandoned: MaxSem; "(no reason)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5815 [22:08:20] MaxSem: no worries [22:09:45] in my branch, it's also fixed [22:22:44] So there is a queue dedicated to mobile issues on OTRS - anybody here with access/knowledge want to review the 5 tickets in there? They date back as far as a month and a half. [22:35:35] New patchset: MaxSem; "Skin rewrite" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5361 [22:35:46] RD: i'll take look [22:35:48] a [22:36:08] Thanks. They are all brief and to the point. Shouldn't be too much of a pain. :) [22:36:11] [WikipediaMobile] brion pushed 1 new commit to master: http://git.io/rQziqw [22:36:11] [WikipediaMobile/master] bug 36256: handle back button on Windows Phone 7 - Brion Vibber [22:36:13] np [22:37:41] hey jdlrobson [22:38:04] preilly: did we want to include anything about caching of js/css across page views on the blog post ? [22:38:13] preilly: or did you want to keep this purely on resource loader [22:38:18] hey tfinc [22:38:31] tfinc: have you looked at it again? [22:39:11] tfinc: see number 11 [22:40:10] line 11 FTW [22:40:13] preilly: looks great [22:40:16] lets get it on the blog [22:40:56] we can have jay/Guillaume/matt to do a copy edit [22:42:46] philinje: you there? [22:43:17] tfinc: http://blog.wikimedia.org/wp-admin/post.php?post=12729&action=edit&message=10 [22:43:36] tfinc, https://en.wikipedia.org/wiki/Wikipedia:VPT#Can.27t_Tap_Status_Bar_to_Scroll_Up._Bug.3F [22:46:29] MaxSem: file a bug [22:46:37] it needs a graphic [22:49:08] tfinc: I'll add http://upload.wikimedia.org/wikipedia/commons/archive/a/ad/20111119024051%21Galaxy_Nexus_smartphone.jpg [22:49:47] tfinc, https://bugzilla.wikimedia.org/show_bug.cgi?id=36261 [22:53:41] preilly there doesn't seem to be any way to restore data backedup from innobackupex into a different db, unless i am missing something - do you know how to do it? [22:54:50] tfinc: http://blog.wikimedia.org/?p=12729&preview=true [22:55:00] awjr: rename it [22:55:27] preilly rename what/where? [22:56:17] tfinc: - still a bit confused about https://bugzilla.wikimedia.org/show_bug.cgi?id=36197 [22:56:31] wow my galaxy nexus just randomly rebooted itself... [22:57:40] what is the storage engine? [22:57:44] awjr: ^^ [23:00:27] preilly innodb [23:10:44] awjr: damn [23:10:51] awjr: well, you'll need to: [23:10:52] mysqladmin create DB_name -u DB_user --password=DB_pass && \ [23:11:05] mysqldump -u DB_user --password=DB_pass DB_name | mysql -u DB_user --password=DB_pass -h DB_host DB_name [23:11:30] obviously replace DB_* with your MySQL settings. [23:11:35] awjr: ^^ [23:15:32] yeahhhh [23:15:42] it's gonna take foreva [23:19:11] awjr: not really if you are piping it in [23:19:12] awjr: did you try the patch? https://bugzilla.wikimedia.org/show_bug.cgi?id=36190 [23:23:24] jdlrobson sorry today has been a day of me getting hella sidetracked. i'll be looking at it shortly [23:23:30] no worries [23:23:46] just tomorrow is my last day to fix it as i'm going to a wedding friday so will be ooo [23:23:56] i hate wordpress formatting [23:23:56] i will definitely have it tested before i leave for the day [23:24:18] jdlrobson: sure [23:24:19] so [23:24:38] originally when we were wanting the footer to rollup .. the arrows were in the wrong direction [23:24:46] if were rolling down .. then its fine [23:24:54] we seem to have a hybrid on the devices that i've tested [23:24:59] as it opens mid way [23:25:11] jdlrobson: but .. you'll notice that i've removed it as blocking [23:25:14] its not important enough [23:25:41] sure... I was just a bit confused what was meant as it being different from the others ... unless I'm being stupid it is the same [23:26:17] jdlrobson: close it as wont fix [23:26:27] i'm more worried about the slow expand/collapse [23:26:30] how is that going ? [23:27:25] I've been struggling to replicate it on my ics emulator [23:27:33] I've potentially got a fix but I wanted awjr to check it [23:30:48] jdlrobson are you working on the labs instance right now? [23:30:56] nope [23:31:12] there appear to be a lot of local changes on there [23:32:28] jdlrobson: if you pass me a link i can test it [23:32:43] awjr feel free to git stash [23:32:47] i was debugging earlier [23:32:49] word [23:32:58] the permissions are all wonky in there too [23:33:14] jdlrobson i think im just going to finish setting up my own MW instance on th ere [23:34:25] also awjr I'm struggling to fix that bad merge [23:34:40] jdlrobson do you have a copy of what the beta_css file is suposed to look like? [23:35:01] instead of changing the merge, maybe just commit it the way it's suppsoed to be to the branch [23:35:03] well basically we need to apply the reverse of this https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/MobileFrontend.git;a=blobdiff;f=stylesheets/beta_common.css;h=bcbff17e7f1edf37f771302600f5e71e1d6f1e50;hp=a64b9c714cbb37dfd7ebed50809ef8043c03f00d;hb=17ab5cf98bda2bf51e72705a2f42f3fa82a0324d;hpb=b58aad17506cb153aecfc372c679b71e785c9585 [23:35:33] it crossed my mind awjr but just seems wrong :) [23:36:00] jdlrobson yeah i know the feeling, but we have a remote branch so we can screw things up without affecting everyone else :D [23:36:24] it is probably the most expedient thing. [23:46:50] ok awjr pushed [23:47:09] shall i setup an instance with the patch from https://bugzilla.wikimedia.org/show_bug.cgi?id=36190 ? [23:47:26] New patchset: Jdlrobson; "revert damage in 17ab5cf98bda2bf51e72705a2f42f3fa82a0324d" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/5867 [23:47:26] New patchset: Jdlrobson; "minor css tweaks" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/5868 [23:49:55] jdlrobson: that patch is no good either :( i still get hella flicker [23:50:01] doh [23:50:19] flicker or lag? [23:50:22] or both? [23:50:22] have you checked with brion about possible bug in the native browser? [23:50:26] jdlrobson both [23:50:48] boooooooooooooogs [23:52:05] hello brion awjr1 we're discussing laggy css transitions on ICS - just found this http://code.google.com/p/android/issues/detail?id=24833 [23:52:23] are you pre 4.0.3 awjr1? [23:52:32] :( [23:54:01] i'm on 4.0.2 on my galaxy nexus [23:54:28] brion is toggling laggy for you on http://m.wikipedia.org/wiki/San Francisco?mobileaction=beta ? [23:55:04] im 4.0.2 also [23:55:17] brion you can see an example of the issue here: [23:55:20] http://mobile-geo.wmflabs.org/w_awjr/index.php?title=San_Francisco [23:55:32] oo actually you need to be in the beta version first [23:55:38] http://m.wikipedia.org/wiki/San Francisco?mobileaction=beta [23:55:42] http://mobile-geo.wmflabs.org/w_awjr/index.php?title=San_Francisco [23:55:45] just pasting those to myself [23:55:59] http://mobile-geo.wmflabs.org/w_awjr/index.php?title=San_Francisco [23:56:01] no [23:56:05] http://mobile-geo.wmflabs.org/w_awjr/index.php?title=Special:MobileOptions/BetaOptIn [23:56:53] toggling the sections in the mobile beta on ICS with the native browser is icky [23:56:57] awjr1: you can append mobileaction=beta to force beta mode [23:56:57] the section flickers [23:57:00] and is slow to load [23:57:07] jdlrobson that is good to know and much easier [23:57:17] yep that's why I put it in :) [23:57:26] so brion: http://mobile-geo.wmflabs.org/w_awjr/index.php?title=San_Francisco&mobileaction=beta [23:57:28] ssslllooowwww just to load up the page so far [23:58:10] srsly [23:58:27] awjr1: is http://dev.sencha.com/deploy/sencha-touch-2-b1/examples/kitchensink choppy for you ? [23:58:58] ok, section expand feels a bit ... choppy and there's a lot of redraw [23:59:18] brion are you seeing the flicker? [23:59:22] yeah [23:59:25] native browser, 4.0.2 [23:59:50] at least, whole thing seems to flicker in and out between white a few times while it's going