[00:00:05] <awjr>	 night MaxSem thanks for looking and for the feedback
[00:14:09] <gerrit-wm>	 New patchset: awjrichards; "* Makes user-facing text rely on i18n messages rather than hardcoded value * provides configurable links for the various links that appear on the contact us form * exposes a hook for alternative configuration handling of the aforementioned feedback form l" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/5931
[00:45:30] <tfinc>	 http://www.sfhtml5.org/events/52635632/?eventId=52635632&action=detail
[00:48:15] <tfinc>	 i'll likely head down and say hello
[00:48:17] <tfinc>	 as its close
[01:04:48] <awjr>	 tfinc: is jon also aware of supporting non-beta + beta for the contact us form? i'm not sure the beta css supports the old form
[01:07:53] <tfinc>	 awjr: send an update mail so that we can be 100% sure
[01:22:30] <gerrit-wm>	 New patchset: awjrichards; "Have contact-us-redesign support the non-beta version of the form" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/5942
[01:23:21] <gerrit-wm>	 New patchset: awjrichards; "Have contact-us-redesign support the non-beta version of the form" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/5942
[08:14:51] <gerrit-wm>	 New review: Jdlrobson; "Out of interest is this needed considering " [mediawiki/extensions/MobileFrontend] (contact-us-redesign) C: 0;  - https://gerrit.wikimedia.org/r/5942
[08:38:06] <gerrit-wm>	 New patchset: Jdlrobson; "separate the cookie csrf code from the toggling code" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5951
[11:02:40] <aharoni>	 YuviPanda, hallo. in case you are not following the blogs: http://ultimategerardm.blogspot.com/2012/04/duh-three-letter-challenge-to-google.html
[12:11:22] <gerrit-wm>	 Change abandoned: MaxSem; "Meh, I thought the original change hasn already been merged" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5938
[12:23:38] <YuviPand_>	 aharoni: hello!
[12:23:41] <YuviPanda>	 aharoni: I left a comment there
[13:03:55] <gerrit-wm>	 New patchset: MaxSem; "Tweak login form generation, less DOM manipulation" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5963
[15:44:35] <gerrit-wm>	 New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/5951
[15:44:38] <gerrit-wm>	 Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5951
[15:45:32] <gerrit-wm>	 New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/5937
[15:45:35] <gerrit-wm>	 Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5937
[15:45:55] <gerrit-wm>	 New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/5963
[15:45:59] <gerrit-wm>	 Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5963
[15:46:41] <gerrit-wm>	 New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (contact-us-redesign); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/5931
[15:46:44] <gerrit-wm>	 Change merged: preilly; [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/5931
[15:47:07] <gerrit-wm>	 New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (contact-us-redesign); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/5942
[15:47:10] <gerrit-wm>	 Change merged: preilly; [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/5942
[15:48:30] <preilly>	 MaxSem: can we try to minimize our usage of globals
[15:48:51] <MaxSem>	 mmm
[15:48:53] <preilly>	 MaxSem: e.g., can we make all of our configuration options an array that is a property
[15:49:48] <MaxSem>	 preilly, awjr objected to one array being used for setting options of different classes, so I started adding separate variables
[15:51:37] <preilly>	 MaxSem: okay
[15:51:43] <gerrit-wm>	 New patchset: MaxSem; "Improved function docs" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5975
[15:52:13] <gerrit-wm>	 New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/5975
[15:52:16] <gerrit-wm>	 Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5975
[15:54:21] <MaxSem>	 preilly, Chad threatens to invent a configuration system that will make globals unneeded,  but so  far nobody have seen it:)
[15:54:35] <preilly>	 MaxSem: okay
[15:57:26] <preilly>	 MaxSem: what if we made a base settings class?
[15:58:08] <MaxSem>	 hmm
[16:02:38] <preilly>	 MaxSem: does hmm mean you're still thinking?
[16:02:46] <MaxSem>	 yes
[16:03:04] <MaxSem>	 can't make up my mind if I like this idea
[16:04:15] <preilly>	 MaxSem: well noodle it for a bit
[16:04:31] <preilly>	 MaxSem: check out http://scribunto.wmflabs.org/v8.php
[16:15:51] * MaxSem  rushes to the hospital, mom's being moved out of intensive care

[16:26:02] <preilly>	 MaxSem|away: best of luck with everything
[16:40:17] <hashar>	 YuviPanda: INFO: Received POST for https://github.com/wikimedia/WikipediaMobile
[16:40:33] <hashar>	 YuviPanda: so at least it seems github is sending notifications to jenkins \O/
[16:41:01] <YuviPanda>	 when in doubt, blame the component written in java :P
[16:42:33] <mw-jenkinsbot>	 Project WikipediaMobile - Nightly builds build #350: SUCCESS in 24 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/350/
[16:42:33] <mw-jenkinsbot>	 * Brion VIBBER: Tweak to index.html
[16:42:34] <mw-jenkinsbot>	 * s.mazeland: Localisation updates from http://translatewiki.net.
[16:42:34] <mw-jenkinsbot>	 * niklas.laxstrom: Localisation updates from http://translatewiki.net.
[16:42:35] <mw-jenkinsbot>	 * yuvipanda: Don't reset scroll when not needed
[16:42:35] <mw-jenkinsbot>	 * yuvipanda: Removed unneccessary .empty() calls
[16:42:36] <mw-jenkinsbot>	 * yuvipanda: Fix Page actions not showing up on iOS
[16:42:36] <mw-jenkinsbot>	 * Brion VIBBER: Tweak to index.html
[16:42:37] <mw-jenkinsbot>	 * Brion VIBBER: Update WinPhone to cordova 1.6.1
[16:42:38] <mw-jenkinsbot>	 * Brion VIBBER: fix styles, scrolling, show/hide section icons for WinPhone
[16:42:38] <mw-jenkinsbot>	 * Brion VIBBER: Fix message, sitematrix load on winphone
[16:42:39] <mw-jenkinsbot>	 * Brion VIBBER: Update Windows Phone tile & icon
[16:42:39] <mw-jenkinsbot>	 * Brion VIBBER: Add solid color fallbacks to gradients for Windows Phone
[16:42:39] <mw-jenkinsbot>	 * Brion VIBBER: bug 36256: handle back button on Windows Phone 7
[16:42:40] <YuviPanda>	 right :)
[16:42:40] <mw-jenkinsbot>	 * yuvipanda: Updated to latest version of MobileFrontend
[16:42:40] <mw-jenkinsbot>	 * yuvipanda: Remove extra button in section headers
[16:42:41] <mw-jenkinsbot>	 * jdlrobson: when toggling add openSection class to button
[16:42:41] <mw-jenkinsbot>	 * yuvipanda: Fastclick for all menu items
[16:42:46] <YuviPanda>	 hashar: thanks! :D
[16:42:48] <hashar>	 so hmm
[16:42:52] <YuviPanda>	 so what broke?
[16:42:54] <hashar>	 at least the manual build does work :(
[16:43:04] <YuviPanda>	 oh :(
[16:43:51] <hashar>	 YuviPanda: well I have no idea right now
[16:44:16] <hashar>	 YuviPanda: can you open a bug about it please?  Will poke it wednesday if you remember me about it ;-]
[16:44:25] <YuviPanda>	 hashar: sure!
[16:44:31] <hashar>	 for now, I am heading back to my daughter and preparing my brother in law wedding :D
[16:44:33] <hashar>	 cya!
[16:44:40] <YuviPanda>	 hashar: thanks! bye!
[16:52:53] <preilly>	 awjr: come to my desk
[16:53:00] <awjr>	 preilly one sec
[17:01:32] <awjr1>	 stand up!
[17:22:08] <tfinc>	 greetings all
[17:23:47] <tfinc>	 YuviPanda: i hear we just need to review your pull requess
[17:23:51] <tfinc>	 requests*
[17:24:12] <YuviPanda>	 indeed. except for b36184 which i'm working on now
[17:24:28] <tfinc>	 YuviPanda: how is the main page doing ?
[17:24:41] <YuviPanda>	 tfinc: blank.
[17:24:48] <tfinc>	 k, thats fine for the beta
[17:24:52] <YuviPanda>	 also you can't apparently trigger the keyboard open from js in iOS.
[17:25:13] <YuviPanda>	 tfinc: I updated https://bugzilla.wikimedia.org/show_bug.cgi?id=33283 on the main page
[17:25:26] <YuviPanda>	 tfinc: but I still think our 'initial content' page should be something local, not main page
[17:26:03] <YuviPanda>	 could give them options to go to main page, or view last article visited.
[17:26:30] <tfinc>	 YuviPanda: is jon the only person who can review the changes ? i imagine we could get others to help
[17:26:56] <YuviPanda>	 he is the only one who has been doing it for the last month...
[17:27:20] <YuviPanda>	 one of the pull reqs i'd want to have him review, since it also involves changes in MF i want to discuss with him.
[17:27:29] <YuviPanda>	 the rest, I wonder who I can poke...
[17:27:58] <YuviPanda>	 brion: want to CR/merge my pull reqs?
[17:31:05] <brion>	 YuviPanda, on github?
[17:31:18] <brion>	 or did you poke MobileFrontend
[17:31:58] <YuviPanda>	 brion: github
[17:32:32] <YuviPanda>	 #218 possibly needs discussion with jdlrobson, but can you look at my other three?
[17:34:46] <YuviPanda>	 brion: that's interesting, I force pushed a branch that removed that commit…
[17:34:47] <YuviPanda>	 looking
[17:36:01] <brion>	 https://github.com/wikimedia/WikipediaMobile/pull/213 looks like it's missing some end tags in index.html, unless the diff is cut off
[17:36:15] <brion>	 ah nevermind
[17:36:18] <brion>	 the display was confusing
[17:36:44] <YuviPanda>	 brion: I assumed pull reqs will handle force push properly. Apparently they don't
[17:43:03] <tfinc>	 awjr: how would you feel about picking the sibling project changeover to mobile next week ?
[17:43:07] <tfinc>	 its a short pre WLM task
[17:43:10] <tfinc>	 that would be a huge win
[17:43:20] <tfinc>	 plus it gets you to tinker more with the ops stalk
[17:43:40] <awjr>	 tfinc: sound intriguing - what exactly is the 'sibling project changeover'?
[17:44:09] <tfinc>	 awjr: so you know how all mobile phone page views of any language wikipedia go to .m ?
[17:44:15] <brion>	 for some reason i can't scroll the 'about' page in 213 (new-content-footer)
[17:44:23] <YuviPanda>	 oh?
[17:44:25] <tfinc>	 awjr: we need to do the same for wiktionary, wikibooks, etc
[17:44:29] <YuviPanda>	 brion: OS?
[17:44:35] <brion>	 ios 5.1 sim
[17:44:50] <awjr>	 tfinc: i thought that already happens for a majority of the projects?
[17:44:50] <tfinc>	 awjr: we'll need to setup a rollout plan and communicate out
[17:45:02] <awjr>	 for example: http://en.m.wikibooks.org/
[17:45:05] <tfinc>	 awjr: so its enabled .. and you can load their .m dounterparts
[17:45:08] <MaxSem>	 anyone interested in MF-->core talk?
[17:45:08] <tfinc>	 counterparts*
[17:45:13] <tfinc>	 but its not *defualt*
[17:45:17] <awjr>	 tfinc ahha
[17:45:27] <YuviPanda>	 brion: true. I'm unable to open about as well
[17:45:28] <awjr>	 tfinc sounds cool, sign me up
[17:45:28] <tfinc>	 so its doing that last caching layer bit
[17:45:28] * YuviPanda  checks

[17:45:31] <tfinc>	 great
[17:45:48] <YuviPanda>	 brion: infact, tapping about seems to have frozen the app
[17:46:16] <YuviPanda>	 brion: investigaitng
[17:46:17] <YuviPanda>	 *gating
[17:46:19] <brion>	 oy
[17:48:54] <awjr>	 has anyone else noticed that section toggling is broken in master right now?
[17:50:08] <awjr>	 i presume it was one of the commits mentioned here: https://bugzilla.wikimedia.org/show_bug.cgi?id=36190
[17:50:21] <preilly>	 awjr: it isn't broken for me
[17:50:31] <awjr>	 really?
[17:50:38] <awjr>	 wtf
[17:50:42] <preilly>	 awjr: yes, want to see?
[17:50:44] <awjr>	 it's broken for me locally and on labs
[17:50:45] <awjr>	 yes i do
[17:51:15] <MaxSem>	 awjr, anything in error console?
[17:51:36] <awjr>	 checking
[17:51:59] <awjr>	 no
[17:53:57] <MaxSem>	 works for me, too
[17:58:24] <awjr>	 this is very strange.
[18:00:43] <awjr>	 are you guys seeing toggleable sections here? http://mobile-geo.wmflabs.org/w_awjr/index.php/Gustav_Mahler
[18:01:09] <awjr>	 MaxSem, preilly ^
[18:04:19] <MaxSem>	 awjr, no, I don't see them....
[18:05:10] <YuviPanda>	 brion: so, the about page bug is not from that pull req.
[18:05:15] <MaxSem>	 awjr, the setting to turn minified scripts off has changed
[18:05:22] <YuviPanda>	 brion: is present in master as well
[18:05:26] <MaxSem>	 $wgMFMinifyJS = false;
[18:05:31] <YuviPanda>	 brion: I'll file a bug and look into it now.
[18:05:52] <brion>	 funky. thx
[18:06:02] <brion>	 i'll go ahead and merge 213 since it seems ok otherwise
[18:06:07] <YuviPanda>	 ok
[18:06:21] <wikipedia-github>	 [WikipediaMobile] brion pushed 5 new commits to master: http://git.io/PBiazg
[18:06:21] <wikipedia-github>	 [WikipediaMobile/master] Added footer showing license and history link - YuviPanda
[18:06:21] <wikipedia-github>	 [WikipediaMobile/master] Added contact us link to settings page - YuviPanda
[18:06:21] <wikipedia-github>	 [WikipediaMobile/master] Hide footer during initial load - YuviPanda
[18:06:23] <YuviPanda>	 number-of-times-scrolling-has-broken++
[18:06:29] <brion>	 hehe
[18:06:44] <brion>	 ironically the scrolling DOES work on my ios 4.3 device :D
[18:08:12] <YuviPanda>	 brion: whooo :D
[18:08:18] <awjr>	 preilly: actually opting in doesn't seem to change anythin
[18:08:32] <preilly>	 awjr: yeah, I don't have that cookie either
[18:08:38] <awjr>	 MaxSem thanks - i was wondering why minifyJs -> flase wasn't working
[18:08:40] <awjr>	 er
[18:08:41] <awjr>	 false
[18:08:41] <preilly>	 awjr: so, it works for me and MaxSem
[18:08:45] <awjr>	 !!!!!
[18:08:47] <awjr>	 rage.
[18:09:03] <awjr>	 have there been any settings changes that i might not be aware of?
[18:09:23] <awjr>	 aside from wgMinifyJs
[18:10:53] <preilly>	 awjr: can you try a fresh git clone?
[18:10:54] <awjr>	 preilly, MaxSem is this working for you? http://mobile-geo.wmflabs.org/w/index.php/Gustav_Mahler?mobileaction=beta&useformat=mobile
[18:11:09] <awjr>	 that's the shared labs instance, and it is not working for me either
[18:11:19] <preilly>	 awjr: that doesn't work for me
[18:11:51] <MaxSem>	 Uncaught exception: TypeError: 'a.updateQueryStringParameter' is not a function
[18:11:51] <MaxSem>	 Error thrown at line 1, column 1040 in c(i, h, j) in http://mobile-geo.wmflabs.org/w/extensions/MobileFrontend/javascripts/settings.min.js?version=:
[18:11:51] <MaxSem>	     return a.updateQueryStringParameter(i,h,j)
[18:11:54] <YuviPanda>	 brion: handle-images seems to be much more complicated.
[18:12:06] <YuviPanda>	 brion: I don't think there's an easy way of detecting file links, thanks to namespace translations
[18:12:16] <preilly>	 MaxSem: you need to minify
[18:12:33] <MaxSem>	 preilly, not me;)
[18:12:43] <awjr>	 just disabled mini js
[18:12:46] <awjr>	 same problem.
[18:12:57] <awjr>	 (on mobile-geo.wmflabs.org/w/
[18:12:59] <awjr>	 )
[18:13:16] <awjr>	 so maybe try again
[18:14:09] <MaxSem>	 if I remember it right, Usability Initiative stored both original and minified files in source control in those dark pre resource loader times
[18:14:42] <awjr>	 we do too, but the minified version doesn't always reflect the non-minified version
[18:14:50] <MaxSem>	 maybe, we should do it, too?
[18:15:15] <awjr>	 can we do a post or pre commit hook to minify js files when they change?
[18:15:38] <awjr>	 regardless, wtf is going on with http://mobile-geo.wmflabs.org/w/index.php/Gustav_Mahler?mobileaction=beta&useformat=mobile
[18:15:50] <awjr>	 and why the hell is it working OK for you guys locally?
[18:16:35] <MaxSem>	 javascript is so javascript
[18:16:45] <awjr>	 lulz
[18:17:11] <awjr>	 can i take a look at one of your local settings files to compare?
[18:18:08] <MaxSem>	 are sure you need this mess?
[18:19:39] <awjr>	 well, perhaps just the relevant parts :p
[18:20:12] <awjr>	 i dont know why else master would behave differently on my machine/labs than on yours or preilly's
[18:20:49] <MaxSem>	 mmm, nothing relevant but:
[18:20:53] <MaxSem>	 if ( @preg_match( '/\bm\./', $_SERVER['HTTP_HOST'] ) ) $wgMFConfigProperties['useFormat'] = 'mobile';
[18:21:00] <MaxSem>	 $wgMobileUrlTemplate = "%h0.m.%h1.%h2";
[18:21:10] <MaxSem>	 $wgMFMinifyJS = false;
[18:33:03] <preilly>	 MaxSem: preg_replace_callback in the headingTransform method in MobileFormatter.php seems to be failing
[18:33:42] <MaxSem>	 eh?
[18:34:47] * MaxSem  сщттусеы ещ дфиы

[18:34:54] <MaxSem>	 *connects to labs
[18:37:01] <preilly>	 MaxSem: ты видишь эту проблему
[18:37:24] <MaxSem>	 нет, на моей машине всё работает
[18:37:34] <awjr>	 preilly: it is working for you correctly locally though?
[18:38:22] <preilly>	 awjr: yes
[18:42:28] <awjr>	 preilly what version of php are you using?
[18:42:40] <MaxSem>	 hmm, no notices or warnings on mobile-geo
[18:42:53] <MaxSem>	 http://mobile-geo.wmflabs.org/phperr.log
[18:43:23] <awjr>	 none locally for me either, but headingTransformCallbackXHTML() doesn't seem to be getting called for some reason
[18:43:56] <MaxSem>	 core parser change?
[18:44:27] <awjr>	 MaxSem preilly told me he's using latest master on core as well but is working for him; im not sure it's parse related as the callback just doesnt seem to be getting called
[18:48:13] <MaxSem>	 I'm still getting  TypeError: 'a.updateQueryStringParameter' is not a function
[18:48:25] <MaxSem>	 (on mobile-geo
[18:48:29] <MaxSem>	 )
[18:49:47] <awjr>	 MaxSem URL? i am not seeing that
[18:49:59] <MaxSem>	 awjr, http://mobile-geo.wmflabs.org/w_awjr/index.php?title=Earth&mobileaction=toggle_view_mobile
[18:50:02] <MaxSem>	 Opera
[18:50:10] <awjr>	 MaxSem: s/w_awjr/w
[18:50:41] <MaxSem>	 gah
[18:52:12] <awjr>	 but, just fixed config on w_awjr so that shouldn't happen anymore :p
[18:52:44] <awjr>	 MaxSem, preilly: what version of php are you using?
[18:53:04] <MaxSem>	 5.3.5
[18:54:29] <MaxSem>	 awjr, preilly, who made local hacks to MF on labs? can I revert them?
[18:54:45] <awjr>	 MaxSem i think preilly is debugging there
[18:55:04] <MaxSem>	 mid-air collision)
[18:55:05] <preilly>	 awjr: I am
[18:55:27] <MaxSem>	 I was going to make a little bisect
[18:56:53] <preilly>	 MaxSem: what are you trying to do?
[18:57:35] <MaxSem>	 I wanted to revert to something before the  <br> fix
[18:57:56] <awjr>	 i think it's something with the regex itself
[18:58:04] <preilly>	 awjr: I'm on PHP 5.3.6-13ubuntu3.6
[18:58:05] <awjr>	 on a whim i did:
[18:58:06] <awjr>	 $s = preg_replace_callback(
[18:58:06] <awjr>	 			'<h2>',//'/<h2(.*)<span class="mw-headline" [^>]*>(.+)<\/span>\w*<\/h2>/',
[18:58:06] <awjr>	 			array( $this, $callback ),
[18:58:06] <awjr>	 			$s
[18:58:06] <awjr>	 		);
[18:58:11] <awjr>	 and now the callback is getting called
[18:58:17] <awjr>	 locally, that is
[18:58:53] <awjr>	 labs and i are on 5.3.2 but slightly different variants
[19:00:35] <YuviPanda>	 MaxSem: thoughts on making action=mobileview work with File: pages?
[19:03:41] <MaxSem>	 YuviPanda, I can poke at it on Monday. you should know however that even core has problems with shared file pages: https://en.wikipedia.org/wiki/File:Octagon_delete.svg?action=render
[19:04:34] <YuviPanda>	 MaxSem: sigh.
[19:06:34] <YuviPanda>	 MaxSem: ugh. it works on commons
[19:06:35] <YuviPanda>	 MaxSem: http://commons.wikimedia.org/w/api.php?action=mobileview&format=json&page=File%3AA%20farmer%20and%20his%20cows.jpg&sections=all
[19:06:48] <YuviPanda>	 but not on wikis
[19:06:57] <MaxSem>	 of course, because it's local for commons
[19:07:30] <YuviPanda>	 right.
[19:07:33] <MaxSem>	 we'll have to use 1337 magic to borrow file description from somewhere
[19:07:54] <YuviPanda>	 or I could handle this internally in the app with a massive hack...
[19:08:12] <YuviPanda>	 which finds out everything with a File: type url (including links) and uses different API to handle them...
[19:08:15] <MaxSem>	 mmm, ImagePage is 39k
[19:08:30] <MaxSem>	 what API?
[19:08:57] <YuviPanda>	 imageinfo, I think
[19:09:13] <YuviPanda>	 yeah, prop=imageinfo
[19:09:16] <YuviPanda>	 action=query
[19:10:53] <YuviPanda>	 MaxSem: ^
[19:11:11] <YuviPanda>	 but for that, I need to know every namespace translation of File:
[19:11:21] <MaxSem>	 do you want to see file description page?
[19:11:27] <YuviPanda>	 yes
[19:11:55] <MaxSem>	 well, you can get local namespaces with action=query&meta=siteinfo
[19:12:32] <MaxSem>	 however, prop=imageinfo doesn't return file's description page
[19:13:15] <YuviPanda>	 MaxSem: it doesn't, but atleast I get info I can format and show
[19:13:44] <MaxSem>	 you have to show copyright info
[19:13:59] <MaxSem>	 or Joan will get angry
[19:14:08] <awjr>	 MaxSem, preilly: locally the closing </h2> for the section headers appears on a new line  which is i think is why the regex is failing
[19:14:21] <YuviPanda>	 MaxSem: yeah, so i'm building a script that takes local namespaces + main page name into a json we can ship
[19:14:25] <preilly>	 awjr: that is the issue
[19:14:52] <awjr>	 doing this instead seems to work:
[19:14:53] <awjr>	 $s = preg_replace_callback(
[19:14:53] <awjr>	 			'/<h2(.*)<span class="mw-headline" [^>]*>(.+)<\/span>\w*/',
[19:14:53] <awjr>	 			array( $this, $callback ),
[19:14:53] <awjr>	 			$s
[19:14:53] <awjr>	 		);
[19:14:56] <MaxSem>	 lemme guess: and the culprit is....
[19:15:05] <preilly>	 awjr: see http://mobile-geo.wmflabs.org/w/index.php/Quark?mobileaction=beta&useformat=mobile#_
[19:15:05] <MaxSem>	 L#$^!^@#L
[19:15:34] <awjr>	 preilly did you do the same(ish) thing?
[19:15:47] <preilly>	 awjr: '/<h2(.*)<span class="mw-headline" [^>]*>(.+)<\/span>\w*/',
[19:15:59] <awjr>	 heh
[19:16:00] <awjr>	 yeah.
[19:18:00] <awjr>	 preilly are you committing the fix?
[19:19:36] <preilly>	 awjr: no
[19:19:44] <preilly>	 awjr: that isn't a good fix
[19:20:21] <awjr>	 it suffers the same essential problem
[19:28:33] <YuviPanda>	 hmm, I also need to handle namespace aliases, along with translations
[19:31:01] <preilly>	 awjr: '%<h2(.*)<span class="mw-headline" [^>]*>(.+)</span>.*?([\r\n]).*/h2>%'
[19:31:51] <awjr>	 preilly seems to work
[19:32:07] <preilly>	 awjr: okay, feel free to commit that
[19:32:43] <MaxSem>	 wait
[19:32:45] <awjr>	 preilly but i wonder if even that could be too rigid?
[19:33:04] <MaxSem>	 I don't like the greedy quantifier
[19:33:07] <preilly>	 awjr: well ?([\r\n]) is optional
[19:33:33] <MaxSem>	 on the other hand ^> will not allow it to cause mess
[19:33:36] <awjr>	 but it assumes <h2(.*)<span class="mw-headline" [^>]*> is on the same line, which im not sure is safe to do
[19:34:18] <awjr>	 given the issue we're seeing here
[19:36:29] <preilly>	 awjr: so you are afraid of a newline before the closing span?
[19:36:41] <awjr>	 before opening span
[19:36:56] <preilly>	 awjr: if that is the case just add another *?([\r\n]) in front and behind
[19:36:57] <awjr>	 or sure, before closing span too
[19:37:16] <awjr>	 im afraid of newlines everywhere.
[19:38:43] <awjr>	 preilly is your regex working for you locally as well?
[19:48:04] <gerrit-wm>	 New patchset: awjrichards; "Preilly's regex fix for bug 36306" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6007
[19:58:26] <awjr>	 preilly, MaxSem ^
[20:00:56] <gerrit-wm>	 New review: preilly; "This doesn't work correctly for me." [mediawiki/extensions/MobileFrontend] (master); V: 1 C: -2;  - https://gerrit.wikimedia.org/r/6007
[20:02:25] <gerrit-wm>	 New patchset: L10n-bot; "Localisation updates from http://translatewiki.net." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6022
[20:04:28] <preilly>	 awjr: %<h2(.*)<span class="mw-headline" [^>]*>(.+)</span>.*/h2>%sU works for me
[20:04:57] <MaxSem>	 .*/h2> will match the last </h2> on the page
[20:05:14] <preilly>	 MaxSem: not with sU
[20:05:34] <MaxSem>	 well, it matched for me
[20:05:50] <MaxSem>	 all sections got collapsed under the first one
[20:05:59] <preilly>	 MaxSem: look at http://mobile-geo.wmflabs.org/w/index.php/Quark?mobileaction=beta&useformat=mobile#_
[20:06:03] <preilly>	 MaxSem: it works there
[20:07:08] <MaxSem>	 preilly, I tried that particular commit on my box
[20:07:33] <preilly>	 MaxSem: not the one Arthur did
[20:07:44] <preilly>	 MaxSem: try it as %<h2(.*)<span class="mw-headline" [^>]*>(.+)</span>.*/h2>%sU
[20:10:13] <MaxSem>	 preilly, looks better
[20:12:13] <gerrit-wm>	 New patchset: preilly; "Fix for bug 36306" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6039
[20:12:13] <gerrit-wm>	 Change abandoned: preilly; "(no reason)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6007
[20:12:29] <preilly>	 MaxSem: can you take a look ^^
[20:12:41] <preilly>	 MaxSem: https://gerrit.wikimedia.org/r/#change,6039
[20:13:18] <MaxSem>	 preilly, you changed a lot of files
[20:13:29] <preilly>	 MaxSem: I added the minified js
[20:13:39] <preilly>	 MaxSem: with the newest JS
[20:14:12] <preilly>	 MaxSem: I guess it should have been another commit
[20:14:42] <preilly>	 MaxSem: can you approve it?
[20:15:48] <gerrit-wm>	 New review: MaxSem; "(no comment)" [mediawiki/extensions/MobileFrontend] (master) C: 1;  - https://gerrit.wikimedia.org/r/6039
[20:16:17] <gerrit-wm>	 New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/6039
[20:16:20] <gerrit-wm>	 Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6039
[21:10:04] <awjr>	 preilly what happened with https://gerrit.wikimedia.org/r/#change,6007 ?
[21:10:07] <gerrit-wm>	 New review: Demon; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/6022
[21:10:10] <gerrit-wm>	 Change merged: Demon; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6022
[21:12:29] <awjr>	 preilly: https://gerrit.wikimedia.org/r/#change,6039,patchset=1 doesn't appear to have resolved the issue...
[21:13:47] * tfinc  waits for android emu to boot

[21:14:47] <awjr>	 preilly i take it back, was looking at cached page
[21:32:42] <YuviPanda>	 off for the night. Will get some stuff done over the weekend too. gnite everyone
[21:49:24] <gerrit-wm>	 New patchset: awjrichards; "Merge branch 'master' into contact-us-redesign" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/6041
[22:03:05] <gerrit-wm>	 New patchset: awjrichards; "Cleaning up merge cruft in MobileFrontend.php" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/6043
[22:05:14] <gerrit-wm>	 New review: awjrichards; "(no comment)" [mediawiki/extensions/MobileFrontend] (contact-us-redesign); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/6041
[22:05:17] <gerrit-wm>	 Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/6041
[22:05:42] <gerrit-wm>	 New review: awjrichards; "(no comment)" [mediawiki/extensions/MobileFrontend] (contact-us-redesign); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/6043
[22:05:44] <gerrit-wm>	 Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/6043
[22:10:41] <gerrit-wm>	 New patchset: awjrichards; "Update beta group check to reflect changes in property visibility in master" [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/6046
[22:11:07] <gerrit-wm>	 New review: awjrichards; "(no comment)" [mediawiki/extensions/MobileFrontend] (contact-us-redesign); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/6046
[22:11:10] <gerrit-wm>	 Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (contact-us-redesign) - https://gerrit.wikimedia.org/r/6046
[22:11:49] <preilly>	 Object* recv = *receiver;
[22:11:50] <preilly>	     Object*** argv = reinterpret_cast<Object***>(args);
[22:12:07] <preilly>	 argh, wrong window
[22:46:10] <awjr>	 tfinc: the nexus s has an OTA update for 4.0.4 already
[22:46:22] <awjr>	 but no updates for my galaxy nexus :(
[23:55:47] <satdav>	 hey guys
[23:56:01] <satdav>	 can i suggest we get a iphone and blackberry app also