[16:29:12] New review: Jdlrobson; "Now I think about this more the beta has a special logo on wikipedia.org that we don't want to displ..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/5885 [16:36:04] greetings all [16:36:59] MaxSem: you around ? [16:37:21] yup [16:37:32] hi tfinc [16:37:34] excellent. lets test google hangout pre meeting to make sure you can hear and see me ok [16:38:02] via Google Chat? [16:38:32] google hangout [16:38:40] so you'll see it if your logged into gmail [16:38:50] hello [16:38:58] hey jdlrobson [16:39:23] jdlrobson: i'll invite you too to help test [16:39:28] i also need to test google hangout [16:39:33] ok cool :) [16:39:39] * MaxSem scratches his head since he has 3 google accounts [16:40:26] is awjr around today? [16:40:58] jdlrobson: no, he'll be back tomorrow [16:41:06] tfinc: ok.. if you still have your android ics i will need help investigating 36190 [16:41:09] jdlrobson: he's recovering from his bachelor party :) [16:41:17] ahh! I had no idea [16:41:22] awesomeness [16:41:23] jdlrobson: MaxSem did you get my google hangout invites ? [16:41:33] i haven't tfinc - no emails have come [16:41:37] this is the direct link https://plus.google.com/hangouts/_/c2817724c59c53384f6aa3926d437b8df0cf28fb?authuser=1&hl=en# [16:41:42] not sure if you can just click through [16:42:28] whaa, plus? I don't have a single social network account [16:42:44] MaxSem: its just part of your normal @wikimedia.org account [16:44:33] tfinc: might be of interest, Jon Kohl has the front page of http://www.stickyminds.com this week, interview on mobile testing [16:47:37] chrismcmahon: woot! [16:47:57] MaxSem: jdlrobson : now as long as our wifi doesn't fail us we should be ok [16:48:10] i did notice that whenever the signal degraded we *all* saw it [16:48:13] * jdlrobson touches wood [16:48:50] MaxSem: when you load a dev version of current MobileFrontend master do you get beta or old site? [16:49:34] oh no it's just me being stupid and overriding it in the settings [16:49:49] although now the front page is not loading.. [16:54:39] i'll wait till after stand up.. [16:55:48] jdlrobson, I see beta (all cookies killed) [16:57:01] jdlrobson, and upon page load I see a weird animation a if something falls down the page [16:57:04] do you see the home page? [16:57:04] as mine appears blank now for some reason [16:57:05] (footer?) [16:57:26] main page looks ok [16:57:33] * tfinc wonders where Yuvi is [16:57:59] what browser MaxSem ? [16:58:06] Opera desktop [16:58:23] note: I refresh with #section_1 in URL [17:00:39] ok .. no yuvi .. lets get started [17:01:06] invites sent to @wikimedia.org addresses [17:01:36] direct link https://plus.google.com/hangouts/_/7c1d2032aad0adb65ca750995e14efed24ca4acc?authuser=1&hl=en# [17:01:49] * yuvipanda looks around [17:01:55] hey YuviPanda [17:01:56] yuvipanda: > https://plus.google.com/hangouts/_/7c1d2032aad0adb65ca750995e14efed24ca4acc?authuser=1&hl=en# [17:01:58] tfinc: hey tfinc [17:01:59] ok [17:02:03] are the direct links working ok? [17:02:34] no one has been invited to my hang out :( [17:02:40] i have max [17:03:35] jdlrobson: we're just missing you [17:03:45] I go to that link and I'm not seeing anything [17:03:55] are you sure it is right? [17:04:16] ahh there we go [17:05:45] i'm not hearing anything :S [17:05:48] tfinc: ^ [17:06:17] it's better with yuvipanda [17:09:17] hangouts .. their a silly place [17:09:18] the first time I see jdlrobson and he's wearing a pretty cool hat. [17:09:22] nice [17:09:25] the quality was pretty terrible for me :( [17:09:30] i got to see everyone though [17:09:36] that was fun [17:09:39] +1 [17:09:40] YuviPanda: jdlrobson MaxSem : how was the audio/video ? [17:09:47] id say that YuviPanda and MaxSem seemed to work great for us [17:09:52] pretty good for me [17:09:53] jdlrobson: your video was a bit bad [17:09:53] audio was awful and video froze a lot [17:10:05] I don't know what happened between the test earlier and now [17:10:09] but I'm on wifi at a good place today, Wednesday would be the real test :) [17:10:11] maybe yuvipanda :) [17:10:13] (for me) [17:10:18] tfinc, sound from people in the office who were far away from your laptop was very weak [17:10:42] * jdlrobson joins call with philinje  [17:10:43] MaxSem: could you hear Patrick ? [17:10:52] Max was the worst for me [17:11:01] all I heard was 'file pages' and 'yuvi' [17:11:07] I think I've just got a bad connection today though [17:11:14] it keeps dropping out [17:11:19] barely. I had to increase volume and then got deafened when someone with a normal sound level spoke [17:11:29] jdlrobson: if yuvi could hear us halfway across the world .. then yes ..its your connection [17:11:36] hmm ok [17:11:36] :) [17:11:42] i'm glad that we have a day to sort it out [17:11:43] can we try Skype? [17:11:49] MaxSem: sure [17:11:57] we'll have to pay extra for the though [17:12:01] and anyone on linux will be screwed [17:12:15] thats the benefit on google hangout .. it works on all platforms [17:12:37] + I get to see hats [17:12:38] aren't most people here either mac emos or windows cynics? [17:12:41] next i'm going to switch us to one of the standup areas with a large screen and very sensitive mic [17:12:51] that should help the feed from the office regardless of what tool we use [17:15:28] yuvipanda, so which parts of image description page would you like to get? [17:15:36] MaxSem: let me look [17:15:43] i'd like to get it in mobileview itself [17:15:54] 1s changing connections [17:15:56] image, description, revision table, usage information? [17:21:10] MaxSem: image, desc seem okay to me [17:21:40] MaxSem: image, desc, copyright status [17:21:41] actually [17:22:01] I don't see the point of usage info on mobile [17:22:13] copyright status=desc [17:22:21] jdlrobson: when do you think you'll be able to look at the pull reqs? [17:22:25] MaxSem: ah, okay. [17:22:30] MaxSem YuviPanda: do you guys have a quick minute to test out a new mic setup on google hang out with me ? [17:22:38] sure [17:22:42] tfinc: sure. [17:23:21] invites sent [17:23:45] tfinc: haven't got any? [17:23:58] this was on which id? [17:24:09] @wikimedia.org [17:24:12] direct link https://plus.google.com/hangouts/_/02009b2d941546daf26bc2b64ae4a83b7de11f68?authuser=1&hl=en# [17:24:35] i'm on it but see no invite [17:24:39] direct link works [17:24:42] *works [17:27:36] jdlrobson: connection problems [17:30:41] sorry about that pchang can we just talk over irc by connection is being very funny today :( [17:31:07] philinje: sorry connection is being very funny today - shall we just talk over irc? [17:32:16] MaxSem: how hard would it be to have action=mobileview work with File: pages consistently? [17:32:35] "consistently"? [17:32:41] MaxSem: local and remote ones [17:32:46] MaxSem: it seems to work for local pages [17:32:51] i.e. on commons [17:33:00] so philinje I was wondering if maybe an animation could work here on page load [17:33:02] *local files [17:33:08] well, I've already started refactoring ImagePage [17:33:13] ah :) [17:33:34] not sure how far will it have go yet [17:34:01] jdlrobson: hi, what is "here"? [17:34:13] here in irc :) [17:34:25] jdlrobson: so philinje I was wondering if maybe an animation could work here on page load [17:34:44] sorry, "could work here" - animation of what? [17:34:45] to suggest it can be clicked [17:34:52] say a decompression [17:35:08] * jdlrobson tries to find an example [17:35:15] oh, the W to main menu as an intro the action [17:35:18] YuviPanda: MaxSem : whats been working better to let you know a hangout is happening 1) invite 2) direct link [17:35:30] direct link [17:36:05] MaxSem: does the direct link just let you in? any additional steps once you click through on it ? [17:36:12] so for instance philinje http://jsfiddle.net/Kyle_Sevenoaks/zMRPK/ <- on this one you click it and it expands, and then click it again and it goes back to normal - imagine this playing on load without the clicking [17:36:27] ('it' being the 'I scale?' button) [17:36:53] because I'm looged into multiple accounts, I kept hitting the wall with a wrong account until I received a link via IRC [17:37:12] tfinc: direct link [17:37:34] tfinc: multiple accounts. Direct link on IRC should work well [17:37:43] now i wonder if i can pass on the direct link *without* inviting you … that would make is super easy [17:38:16] i wonder if a hangout it always public [17:38:52] * yuvipanda wonders when jdlrobson would have time to merge pull requests  [17:39:28] YuviPanda: my audio is off but see if you can join this hangout https://plus.google.com/hangouts/_/3389920442067d43a70e17980029ccac66bb5452?authuser=1&hl=en# .. this will tell me wether i *have* to invite you [17:39:47] jdlrobson: not seeing the i scale button but i get the idea - worth trying [17:40:07] this will be my last test for now [17:40:14] philinje: load http://jonrobson.me.uk/wikipedia/experiments/nav/index-final2.html [17:40:28] whoops failed to upload 1s [17:40:39] jdlrobson: lindsey has a few minor tweaks for you, i need to run fairly soon [17:40:42] also linSmith can I get that hex code? [17:42:03] YuviPanda: did the link work? [17:42:05] jdlrobson #006699 [17:42:17] try refreshing http://jonrobson.me.uk/wikipedia/experiments/nav/index-final2.html philinje now [17:42:22] thanks linSmith [17:42:39] jdlrobson: ah, so the W expands out then in quickly [17:42:55] yes. so you get the idea it is clickable [17:43:01] or has some significance [17:43:15] it's a cool idea [17:43:36] can you do two prototypes, one with the animation, one without? [17:43:43] yup 1s [17:43:45] that way i can test them on user testing.com [17:44:39] done [17:44:42] tfinc: it did [17:44:47] http://jonrobson.me.uk/wikipedia/experiments/nav/index-final3.html [17:44:55] YuviPanda: excellent [17:45:03] tfinc: it works [17:45:06] i'm just in a dark room [17:45:09] awesome [17:45:22] so for wed we'll just have a direct link. no need to do invites [17:45:25] that makes it a ton easier [17:45:28] k, i'll mail [17:45:42] :) [17:45:42] ok [17:45:50] jdlrobson: thanks [17:46:21] is that all philinje ? [17:46:29] (before you go) [17:46:37] lindsey has a bunch of tweaks for you [17:46:45] yes thanks [17:46:55] hope my email with the next steps makes sense [17:48:04] ok cool - i won't look at this till tomorrow as I want to focus on the beta release today [17:48:12] preilly: are you there? i have a few questions for you [17:48:30] jdlrobson: I'm here [17:48:48] awesome [17:48:51] so I need some php help [17:49:06] in i18n I have 'mobile-frontend-footer-contributors' => 'Article by contributors like you', [17:49:17] I want to replace that $0 with the link to the history page for the current article [17:49:26] firstly is there a better way to do that? [17:49:43] afaik I can't do substitution in msgHtml [17:49:56] firstly, parameters start with 1 [17:50:13] jdlrobson: yeah, what make said [17:50:19] k [17:50:49] 2) how do I do the replace? I tried escapeAppendQuery( 'action=history' ), $this->getMsg( 'mobile-frontend-footer-contributors' ) ) ?> but it printed in plain text [17:50:56] (obviously $1 now) [17:52:10] jdlrobson, what file are you editing? there should be no $wgRequest nor escapeAppendQuery() in master [17:52:49] SkinMobile.php [17:53:39] jdlrobson, git pull --all [17:53:56] or you're on a branch? [17:54:35] jdlrobson: Parameters to the message, which can be used to insert variable text into it, can be passed to this function in the following formats: [17:54:35] One per argument, starting at the second parameter [17:54:36] As an array in the second parameter These are not shown in the function definition. [17:54:53] jdlrobson: no need for str_replace [17:55:14] perfect [17:55:38] jdlrobson: has contact us not been merged with master? [17:55:47] i don't think so [17:56:00] awjr wrote an email saying it was ready to go once we've checked it and are happy with it [17:56:06] that was what i wanted to sort out after this.. [17:56:14] jdlrobson: are you happy with it? [17:56:52] I need to double check it preilly [17:56:57] one sec let me sort out footer [17:57:03] jdlrobson: okay [17:57:24] so MaxSem I've added global $wgRequest in SkinMobile.php - that's probably naughty I guess - what would be the better way [17:58:09] $this->getRequest() [17:58:26] and no escapeAppendQuery(), please [17:58:36] just appendQuery() [17:58:39] k [17:59:23] YuviPanda: your on a 3G connection right ? [17:59:30] for todays standup [18:00:16] tfinc: no [18:00:25] YuviPanda: or were you on wifi ? [18:00:26] tfinc: i was on a very decent wifi [18:00:29] k [18:00:35] tfinc: i'd be on 3G on Wednesday [18:00:42] jdlrobson: the bug you asked me to file the other day https://bugzilla.wikimedia.org/show_bug.cgi?id=36355 [18:00:44] YuviPanda: that'll be interesting [18:01:00] tfinc: very much os. [18:01:00] *so [18:07:48] preilly: can you look at a diff for me and tell me what I'm doing wrong.. sorry php not my strong point... yet:( [18:09:56] http://pastebin.com/7Vm3E6dH < preilly MaxSem - so what I'm getting outputted here is the link followed by the text rather than the substitution occuring :( [18:11:05] thanks yuvipanda for the link and i'll pull/review your stuff once 36355 is taken care f [18:11:41] jdlrobson, html( 'historyLink' ) ?> [18:12:33] MaxSem: that just gives me the url rather than the message substituted with the url [18:13:58] preilly: i'm scheduling open path + art and logic for tues [18:14:03] preilly: trying to fit them into 12-2 [18:14:24] tfinc: okay [18:15:09] jdlrobson: pushing out a beta today would be nice. Think you can fit that in? [18:15:14] jdlrobson, don't use HTML in messages, use wikilinks instead [18:15:42] yuvipanda: i'll try I just need help on a few things MFE side this current thing included [18:16:01] so that it'll be 'mobile-frontend-footer-contributors' => 'Article by [$1 contributors] like you', [18:16:04] YuviPanda: lets block the app beta on the mobile web beta push [18:16:20] the big mail to mobile-l [18:16:36] we can have everything prepped [18:18:04] so MaxSem that still outputs /w/index.php?title=Main_Page&mobileaction=toggle_view_mobile&action=historyArticle by [$1 contributors] like you [18:18:28] jdlrobson, $tpl->set( 'historyLink', $this->msg( 'mobile-frontend-footer-contributors', $this->getRequest()->appendQuery( 'action=history' ) ) ); [18:18:45] then just $this->html( 'historyLink' ) it [18:19:03] QuickTemplate doesn't accpet message parameters [18:19:21] tfinc: ok [18:19:26] mmmm [18:20:01] and link needs to be put through wfExpandUrl(0 and $this->extMobileFrontend->getMobileUrl() [18:20:11] tfinc: i'll continue bugfixing, etc on the app then [18:20:20] ok this is the problem I'm running into MaxSem [18:21:00] YuviPanda: mail it out to mobile tech for a quick round [18:21:41] also preilly don't know if you saw my comment about beta push > https://gerrit.wikimedia.org/r/#q,5885,n,z [18:21:42] tfinc: it needs jdlrobson to pull in ~5 pull reqs before it can hit beta [18:21:50] YuviPanda: k [18:22:09] YuviPanda: web beta->default is priority #1, app beta is priority #2 [18:22:16] tfinc: got it/ [18:22:16] and tfinc yuvipanda I can't enter app mode until I'm done with MFE beta :-) from experience I can't work on both at the same time.. just confuses me :( [18:22:25] jdlrobson: exactly [18:22:42] ok :) [18:22:43] thats why were going to block app beta until web beta is out [18:22:50] it'll be fien [18:22:55] and will actually go faster [18:23:11] Context switching would slow us down [18:23:13] agreed. Just wanted to know how we're doing it. clear now [18:23:37] New patchset: preilly; "Merge branch 'contact-us-redesign'" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6137 [18:24:36] MaxSem: are you free to look into the message parameter stuff to free me up to look at some other outstanding bugs? [18:24:50] yup [18:25:02] awesome - bug 35616 - is basically just that diff working [18:25:09] * jdlrobson goes to check the contact us stuff is fine [18:25:18] MaxSem: http://pastebin.mozilla.org/1607798 jdlrobson: http://pastebin.mozilla.org/1607798 [18:26:54] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/6137 [18:26:56] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6137 [18:28:37] preilly: on your local machine do you see your main page? Mine has disappeared [18:28:44] seems to ignore the special casing [18:29:06] jdlrobson: can you git pull on master [18:29:12] i have preilly [18:29:16] still no homepage [18:29:28] i'm looking at contact us styling [18:30:17] jdlrobson: I just merged contact us into master [18:30:28] jdlrobson: can you switch to master and pull there [18:30:34] i have preilly :) [18:30:39] i'm testing [18:30:51] jdlrobson: I don't have main page content either [18:30:52] it's looking fine so far [18:31:07] MaxSem: can you update your master and look at the home page [18:31:14] homepages are broken [18:32:00] preilly, WFM [18:32:21] MaxSem: you probably just have text as your main page [18:32:33] I'm preparing a review on that branch merge [18:32:48] MaxSem: can you update your copy of master [18:32:56] just did [18:32:58] try
[18:32:59] test [18:32:59]
[18:33:02] MaxSem: and try putting
[18:33:03] This is a test 2! [18:33:03]
[18:33:07] as your home page [18:33:11] yeh same as preilly [18:33:57] now it doesn't [18:34:24] but I had a configured main page before =why it worked? [18:35:12] MaxSem: can you look into it [18:37:10] preilly, some stuff is cut in your diff: [18:37:12] + $feedbackArticlePersonalLinkText = $this->msg( 'mobile-frontend-leave-feedback-article-personal-link-text [18:37:12] + $feedbackArticleFactualLinkText = $this->msg( 'mobile-frontend-leave-feedback-article-factual-link-text' [18:37:12] + $feedbackArticleOtherLinkText = $this->msg( 'mobile-frontend-leave-feedback-article-other-link-text' )->e [18:37:15] Why is the file javascripts/application.js on http://mobile-geo.wmflabs.org/w/index.php alerting the UA? [18:38:19] oh preilly so that's because I need to point tfinc at it [18:38:40] tfinc can you visit the link http://mobile-geo.wmflabs.org/w/index.php on your ICS and tell me what it alerts then if the transitions are still weird for you? [18:38:44] that's if preilly hasn't changed it.. [18:38:56] jdlrobson: I haven't [18:39:05] cool tfinc ^ [18:39:15] or if anyone else has ICS 4.0.2 [18:40:21] also why did we stop using $wgMFConfigProperties in favour of $wgMFMinifyJS [18:40:38] jdlrobson: ask MaxSem [18:41:26] ask awjr, I originally used it [18:42:00] New review: MaxSem; "This shouldn't have been merged so hastily." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6137 [18:46:06] jdlrobson: FYI: you don't need use format anymore on http://mobile-geo.wmflabs.org/w/index.php/Quark [18:47:35] you mean useformat preilly ? [18:47:42] New patchset: preilly; "Remove unneeded comment" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6138 [18:47:45] sorry I'm getting myself confused already and it's only early in the day :) [18:48:14] jdlrobson: yes [18:48:32] i'm guessing tfinc is not around? [18:48:34] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/6138 [18:48:34] New review: MaxSem; "(no comment)" [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/6138 [18:48:37] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6138 [18:48:41] jdlrobson: he is in a meeting [18:49:58] MaxSem: do you want to provide fixes for some of your comments on https://gerrit.wikimedia.org/r/#change,6137 [18:50:36] will do [18:52:33] MaxSem: can you also look at the Main Page content issue as well [18:52:47] MaxSem: e.g., http://mobile-geo.wmflabs.org/w/index.php/Main_Page [18:53:13] preilly: A&L has a blocker 12-2 .. they can do 11-12 but i won't be able to make it then [18:53:30] preilly: if your fine with that then i'll confirm [18:53:36] tfinc: can they do anything later? [18:53:37] and we can sync up after [18:53:39] yeah [18:53:56] tfinc: I'd rather you be there too [18:54:00] k [18:59:24] let me see if they can do 3-4 [19:02:23] New patchset: Jdlrobson; "prevent self-initialisation bug 36355" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6141 [19:02:30] YuviPanda: ^^ [19:02:34] does that do what you want? [19:03:02] jdlrobson: looking [19:05:50] tfinc: ping me when you are free :) [19:07:30] jdlrobson: pm me. i'm going to be in and out today [19:07:47] or just mesg me if its not private [19:08:15] jdlrobson: thats not private at all :) [19:08:27] brion: do you your ICS phone around ? [19:08:54] have* [19:09:27] jdlrobson looks good, i'll try it now [19:10:06] cool YuviPanda [19:10:12] i'm still not 100% happy with it [19:10:16] but it seems to do the job [19:11:14] brb changing location [19:11:55] tfinc, i do [19:14:25] brion could I borrow you and your ICS for a moment? [19:14:33] brion: jdlrobson needs some ICS help [19:14:47] moment [19:17:00] jdlrobson, ok what you need me to check out [19:17:08] basically I need you to point your ICS at http://mobile-geo.wmflabs.org/w/index.php/San_Andreas,_California?useformat=mobile [19:17:12] tell me what it alerts [19:17:22] and then if when you toggle open sections it flickers at all [19:17:34] awjr was saying the toggling wasn't quite working on his devic [19:18:51] Mozilla/5.0 (Linux; U; Android 4.0.2; en-us; Galaxy Nexus Build/ICL53F) AppleWebKit/534.30 (KHTML, like Gecko) Version/4.0 Mobile Safari/534.30 [19:18:56] match! [19:19:16] and how is the toggling experience? [19:19:27] it looks like there's no animation of the toggling, it just opens/closes [19:19:29] no flicker or anything [19:21:17] mm that's what I expected [19:21:31] yay [19:21:34] I'll mark that as WFM then.. I'm not sure what awjr was describing :) [19:21:53] hopefully it was caching or something.. [19:22:11] MaxSem: any luck on the main page issue? [19:22:37] preilly, broken by me with
changes, working on fix and tests [19:22:47] MaxSem: okay, cool [19:23:28] jdlrobson: i'll have to stub a MobileFrontend.registerModule call. [19:23:29] jdlrobson: but I guess that's acceptable [19:23:37] * YuviPanda goes to do that [19:23:59] afraid so.. :-/ hence why I wasn't so happy with the solution [19:24:05] I think it does the job for now though [19:24:17] it does [19:24:29] better than having to patch submodules [19:25:24] btw does anyone know how to fix this -> https://bugzilla.wikimedia.org/show_bug.cgi?id=30902 [19:25:30] it's getting quite old now [19:25:52] YuviPanda: guessing you'll update your pull requests with these changes and without the patch? [19:26:06] jdlrobson: yup. Doing that now... [19:26:33] preilly: so I'm happy with contact us just one slight tweak to the css.. [19:26:34] New patchset: Jdlrobson; "fixed heights are bad" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6150 [19:26:38] (that one) [19:30:17] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/6150 [19:30:20] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6150 [19:32:36] jdlrobson: okay [19:32:59] preilly: so how do we ensure the logo on beta is the same as the logo on normal wikipedia? [19:33:17] preilly: context -> https://gerrit.wikimedia.org/r/#q,5885,n,z [19:35:58] https://bugzilla.wikimedia.org/show_bug.cgi?id=36189 < 1 more to go \o/ [19:36:54] jdlrobson: this isn't a safe change https://gerrit.wikimedia.org/r/#patch,sidebyside,5885,1,MobileFrontend.body.php [19:37:57] i wasn't sure but it was merged.. :-/ ... what would you recommend instead? [19:37:58] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/6141 [19:38:01] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6141 [19:38:01] Amgine: aude devgeeks and others .. we need your feedback on http://lists.wikimedia.org/pipermail/mobile-l/2012-April/005560.html [19:38:12] jdlrobson: so, only the beta design is going live [19:38:26] jdlrobson: and we still need the beta for other stuff in the future [19:38:35] what about references.js ? [19:38:42] I assume that too? [19:38:46] jdlrobson: yeah, that too [19:39:03] k I was just a bit worried it might be a messy process [19:39:07] [19:39:08] jdlrobson: so, you need to change the check around those sections to be the default not changed he is beta flag [19:39:10] want to revert that and I'll try again [19:39:37] * jdlrobson wonders if instead of using a beta flag we should use a version number [19:39:41] jdlrobson: just fix it with a new commit that also toggles the other bits correctly [19:39:50] ok preilly [19:39:55] thanks Amgine [19:42:28] tfinc: looks good to me [19:42:39] aude: throw those comments on the feedback page [19:42:42] both good & bad [19:43:04] silence is hard to gauge and i know that their are more thoughts then erik and me [19:44:14] ok :) [19:44:29] i'm looking at the page on my phone [19:45:37] New patchset: MaxSem; "Fixed main page formatting" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6151 [19:47:04] aude: great [19:47:14] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/6151 [19:47:16] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6151 [19:47:37] MaxSem: Change has been successfully merged into the git repository. [19:47:43] cool [19:48:44] preilly: guessing I should rename beta_common.css to common.css ? [19:49:04] jdlrobson: yes [19:49:52] tfinc: so there are 2 places to "click" and popup a menu [19:50:09] the one to the right of the searchbar, what's that called? [19:51:14] aude: there are two tappable surfaces. both are located in the search bar [19:51:39] one is the main menu button while the other is the article action button [19:52:32] within in the proto type those are the 'W' and the three dots [19:52:56] the three dots are not obvious to me [19:53:07] the "W" is, as it's been used before [19:53:25] aude: thats great feedback. to keep things organized can you add that to the feedback page mentioned in the email [19:53:43] done [19:54:23] thanks [19:54:28] and then when i click on the 3 dots, i'm not quite sure what the 4 icons (4 buttons) do [19:55:06] aude: that lines up well with they feedback that eloquence left [19:56:04] noted it [19:56:54] but then not sure how to design it differently to be more clear yet take minimal amount of screen space [20:02:51] aude: we just updated the icons [20:04:18] preilly: think this does it... [20:04:43] New patchset: Jdlrobson; "Revert "make beta the default"" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6153 [20:04:44] New patchset: Jdlrobson; "promote beta to production status" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6154 [20:08:24] New review: MaxSem; "(no comment)" [mediawiki/extensions/MobileFrontend] (master) C: 0; - https://gerrit.wikimedia.org/r/6154 [20:10:42] philinje: look same to me [20:11:22] bah... [20:18:44] New patchset: Jdlrobson; "promote beta to production status" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6154 [20:22:25] * YuviPanda is off to slepep [20:22:35] gnite everyone! [20:22:44] night YuviPanda [20:22:48] will pull some stuff either later or tomorrow am [20:22:53] more likely the latter :) [20:23:05] jdlrobson: :D Will poke you tomorrow. [20:23:23] MaxSem: any luck with passing parameters to i18n messages or did you get sidetracked by homepage? [20:23:33] the latter [20:24:42] aude: try this link http://jonrobson.me.uk/wikipedia/experiments/nav/index-final2.html [20:25:39] New review: MaxSem; "Undefined variable $feedbackGeneralLink" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6137 [20:27:10] New review: MaxSem; "echo '!is good editing mw.o';" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6137 [20:27:33] preilly, have you consulted awjr before merging? :P [20:29:03] New patchset: L10n-bot; "Localisation updates from http://translatewiki.net." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6178 [20:29:58] linSmith: looking [20:31:24] this is an intimidatingly long read, btw. [20:33:18] jdlrobson: can you participate in a meeting at 9pm your time Thur? [20:33:58] linSmith: much better! [20:35:10] aude: great, thanks for the feedback [20:41:20] the labels help a lot and the icons are clear now [20:41:30] and that it's something to click, next to search [20:51:40] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/6178 [20:51:43] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6178 [20:54:12] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/6153 [20:54:15] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6153 [20:54:57] MaxSem: have you looked at this new patch set https://gerrit.wikimedia.org/r/#change,6154 [20:56:15] PHP looks OK to me, though I'm a bit doubtful about beta module set to normal module [20:56:37] guess it'll work as a fallback for now [20:57:30] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/6154 [20:57:32] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6154 [21:04:15] aude: sent an email to mobile-l with the new link [21:04:38] I encourage everyone to take a look ;) [21:04:58] New patchset: preilly; "Fix debug output" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6201 [21:05:04] philinje: thanks! [21:08:05] MaxSem: take a look at https://gerrit.wikimedia.org/r/#change,6201 [21:11:01] preilly, http://dpaste.com/740489/ [21:12:57] philinje: https://www.mediawiki.org/w/index.php?title=Mobile_design%2FWikipedia_navigation%2FInitial_menu_feedback&diff=530833&oldid=530830 [21:13:45] commented [21:14:56] New patchset: preilly; "Fix debug output and return value" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6201 [21:14:58] MaxSem: ^^ [21:18:08] MaxSem: also, see http://pastebin.mozilla.org/1599582 [21:19:11] tfinc: should we prepare a blog post for pushed beta changes [21:19:11] jdlrobson: yes [21:19:12] I drafted one early as I thought we might [21:19:17] I'll draft it on the blog.. [21:20:08] MaxSem: did you look at https://gerrit.wikimedia.org/r/#change,6201 patch set 2? [21:20:09] New review: MaxSem; "(no comment)" [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/6201 [21:21:00] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/6201 [21:21:04] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6201 [21:22:07] MaxSem: do you see any other issues? [21:22:23] preilly, you want to deploy today? [21:23:56] MaxSem: yes [21:23:56] mmm, could be dangerous w/o Arthur [21:23:57] (and me, cause I shifted my schedule to go to bed and get up earlier now) [21:25:04] jdlrobson: we've already done a post about them [21:25:10] we have tfinc ? [21:25:10] tfinc: but, as the default? [21:25:10] not as the default, about the beta design [21:25:50] i wasn't too concerned with doing a separate post about this as we've already talked about it in http://blog.wikimedia.org/2012/03/26/wikipedia-mobile-gets-a-face-lift/ [21:26:02] one secon [21:26:02] and we haven't make any large scale changes since [21:26:02] just bug fixes [21:26:02] http://blog.wikimedia.org/?p=12995&preview=true [21:26:20] (if that works for you) is what I had in mind [21:26:20] jdlrobson: your link is a 404 [21:26:20] as some people might have messed the beta facelift and as a result might come to the blog to find out more [21:26:20] tfinc: you might need to login [21:26:20] i was talking about http://blog.wikimedia.org/2012/03/26/wikipedia-mobile-gets-a-face-lift/ [21:26:57] yup - i'm suggested that we should maybe just summarise that we've pushed the design out to a wider audience and link to that for more detail [21:27:18] MaxSem: well, I still plan on deploying today [21:27:18] jdlrobson: we can do that tomorrow . focus on the changes [21:28:08] MaxSem: how much longer will you be around today [21:28:12] the only change I have left I'm blocked on - https://bugzilla.wikimedia.org/show_bug.cgi?id=35616 [21:28:20] preilly, 30 minutes [21:28:23] (apart from that I'm testing various devices) [21:29:14] MaxSem: okay, thanks [21:39:03] jdlrobson, my currrent solution is http://dpaste.com/740508/ but I don't like it [21:40:24] what don't you like about it [21:41:52] CSS in messages [21:42:46] currently interrogating Siebrand regarding ways to improve it [21:42:46] you mean html ? [21:43:35] the output would be quite stupid