[17:52:54] image pages are more complicated [17:53:00] I'm waiting for review of my first refactoring step [17:54:25] MaxSem: hmm, okay [17:55:57] looking forward to the tidying of the api, then :) [17:58:00] Rolken: you might be interested in http://en.wikipedia.org/wiki/Special:ApiSandbox [18:00:21] thanks :o [18:01:17] awjr, tfinc: http://test.wikipedia.org/wiki/Main_Page?useformat=mobile&134123467 is updated with jon's changes [18:01:42] preilly: do you have the change set ? [18:01:57] cool looking now [18:02:57] preilly: i found them 6224,6225, and 6226 [18:03:38] tfinc: 11aee2e6bfa0485661f3830cd367153982991ec4 [18:06:56] tfinc: [18:06:56] I7dafa016 update minified versions of js [18:06:58] I972f5d67 Change name to Patrick Reilly as per other extensions [18:06:59] I12f6b102 add coverage for hasClass (MERGED) Jdlrobson mediawiki/extensions/MobileFrontend master [18:07:01] I672d4cfb stop using globals in unit tests (MERGED) Jdlrobson mediawiki/extensions/MobileFrontend master [18:07:01] binasher: is there anything you guys need from us to get http://rt.wikimedia.org/Ticket/Display.html?id=2756 closed? we still can't test our staged deployments from a mobile device [18:07:02] I31576536 return tests for banner.js and toggle.js (MERGED) Jdlrobson mediawiki/extensions/MobileFrontend master [18:07:04] Idca2bded no need to clean fixtures any more (MERGED) Jdlrobson mediawiki/extensions/MobileFrontend master [18:07:05] I1c8c180b move page enhancements into a separate function invoked my init [18:07:07] I04fd9a52 bring back tests for application.js (MERGED) Jdlrobson mediawiki/extensions/MobileFrontend master [18:07:08] I4954a124 don't self initialise fixtures / cleanup [18:07:09] Ib03669b1 fix jump to top [18:07:10] Iafe4a7e7 remove special casing of rtl mode [18:07:11] Ia0796677 make list items in footer inline-block [18:09:14] awjr: the next step on that is in ryan's court [18:09:28] eh? [18:09:37] Ryan_Lane: http://rt.wikimedia.org/Ticket/Display.html?id=2756 [18:09:37] dns for test.m [18:09:41] pointing at the mobile vip [18:10:25] awjr: Ryan_Lane says he spent 6 hours trying to make the dns change and he refuses to look at it again [18:10:57] ok… then what do we need to do to get it fixed? [18:11:27] binasher, Ryan_Lane ^ [18:11:50] it wasn't the DNS that I spent time figuring out [18:11:55] it was the apache bs [18:12:00] I'll make the DNS change [18:12:24] kk thanks Ryan_Lane, hopefully that will do the trick :) [18:12:33] if it doesn't you guys are SOL [18:12:45] [WikipediaMobile] yuvipanda pushed 2 new commits to master: http://git.io/3GsbKQ [18:12:45] [WikipediaMobile/master] Made headings in CHANGELOG consistent - YuviPanda [18:12:45] [WikipediaMobile/master] Updated version numbers and added CHANGELOG - YuviPanda [18:12:49] then we will need to come up with an alternative [18:17:12] done [18:17:59] reassigned to asher [18:38:50] New patchset: L10n-bot; "Localisation updates from http://translatewiki.net." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6287 [18:42:40] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/6287 [18:42:43] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6287 [18:53:57] sigh, iOS provisioning is frustrating. [19:00:43] Thehelpfulone: [19:00:46] * YuviPand2 pokes Thehelpfulone [19:00:52] hi :) [19:00:55] hi :D [19:01:08] Thehelpfulone: think you can validate http://dl.dropbox.com/u/8768784/Wikipedia%20Mobile.ipa for me? [19:01:16] it's the new app beta. [19:01:21] sure [19:01:25] Thehelpfulone: awesome :) [19:02:13] any change log? [19:02:22] Thehelpfulone: yes [19:02:25] give me a second [19:02:31] sure [19:02:40] Thehelpfulone: https://github.com/wikimedia/WikipediaMobile/blob/master/CHANGELOG [19:02:49] reversed, so you'll need to head to the bottom for the latest release [19:03:30] Thehelpfulone: essentially biggest change is decoupling it from the HTML used for the site (uses API), newer styles. [19:03:40] Thehelpfulone: this means that changes to MobileFrontend won't break the app. [19:04:20] ok [19:08:05] Thehelpfulone: any luck? [19:08:34] just trying to install it now [19:09:08] New patchset: awjrichards; "Ensure that the 'returnto' URL on the thank you page of feedback form points to mobile url." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6313 [19:11:44] heh silly itunes sync [19:12:09] the point of iCloud should be that I don't have to sit and wait whilst it syncs! I'll let you know when it's done YuviPand2 [19:12:50] YuviPand2: the screen is in the bug, hope you saw it [19:13:16] philinje: yes, responded on it [19:13:17] preilly: were still confirmed for a&l @ 3. i don't have a confirmation from op yet [19:13:35] philinje: linSmith thanks :) [19:15:04] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/6313 [19:15:07] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6313 [19:15:24] tfinc: okay [19:20:35] awjr_lunch: can we meet 4-4:30 today? [19:20:49] preilly: if i can move my 1:1with awjr_lunch then open path is @ 4:30 [19:22:53] tfinc: okay, great [19:24:14] YuviPand2: okay so a couple of things from my first use - first of all if I open up the app in landscape view to begin with [19:24:18] I can't scroll down on any page [19:24:29] and also, the interwiki links to change the language don't seem to work [19:24:47] say for example I'm on "Ryder cup" [19:24:59] clicking on the spanish one doesn't do anything - I'm still on the english version [19:25:53] hmm I can't seem to scroll down on the enwiki homepage either [19:26:02] and I get a rather ugly "Main_Page" at the top [19:26:33] with the welcome to wikipedia...... banner that is chopped off just after the first column of bullet points [19:28:23] Thehelpfulone: the Main page is currently broken, but you should still be able to scroll. [19:28:26] sigh [19:28:28] Thehelpfulone: OS? [19:28:33] 5.1 [19:28:50] Thehelpfulone: try searching? [19:29:32] yep that works [19:29:41] YuviPand2, there will be special casing in output for MP and section information will be unavailable [19:29:41] Thehelpfulone: scrolling after you went to a searched article? [19:29:44] and now scrolling seems to work [19:30:21] MaxSem: cool :) [19:30:24] cause sections in parser output don't correspond to MP sections [19:31:15] Thehelpfulone: interwiki? [19:31:58] yeah the ones that I image the view this page in a different language use? [19:32:21] MaxSem: that's fine. So it'll all come down as one section with action=mobileview? [19:32:47] without all the usual section info [19:36:03] sorry, bad connection [19:36:38] Thehelpfulone: so those language links work? [19:36:44] nope [19:36:44] tfinc: can you put two files into dumps. for me? [19:36:50] tfinc: http://dl.dropbox.com/u/8768784/Wikipedia-v1.2-beta1.ipa and http://dl.dropbox.com/u/8768784/Wikipedia-v1.2-beta1.apk [19:36:51] sure [19:37:01] they dont take me anywhere [19:38:50] downloading [19:39:06] Thehelpfulone: right. I can repro that. Give me a minute [19:39:13] ok [19:45:19] Thehelpfulone: i've fixed that. Pushing out another build now. Try out the other parts of the app? [19:45:28] (that -> 'view in other language') [19:45:28] ok [19:47:11] [WikipediaMobile] yuvipanda pushed 1 new commit to master: http://git.io/1U535g [19:47:11] [WikipediaMobile/master] Make pages work for other languages, rather than just default - YuviPanda [19:48:28] Thehelpfulone: try http://dl.dropbox.com/u/8768784/Wikipedia-v1.2-beta1.ipa [19:48:31] ? [19:48:38] Thehelpfulone: just replaced it with a build that fixes the 'read in other languages' problem [19:48:58] ok [19:49:12] Thehelpfulone: how has it been so far? [19:49:13] yuvipand1: http://dumps.wikimedia.org/iOS/Wikipedia-v1.2-beta1.ipa <-- shouldn't that be 3.2 ? [19:49:28] yuvipand1: http://dumps.wikimedia.org/android/Wikipedia-v1.2-beta1.apk [19:49:37] gah [19:49:38] yes [19:49:40] it should be [19:49:41] * tfinc needs to grab food soon [19:49:52] yuvipand1: does the ipa have the right version ? [19:49:54] string [19:49:58] I still don't like that theres a delay between pressing the button and it actually working yuvipand1 [19:50:06] tfinc: also, Thehelpfulone is being very helpful :) So I'm testing out with him, will push out a final beta version when he's done [19:50:12] Thehelpfulone: that should've been much reduced now Thehelpfulone [19:50:16] Thehelpfulone: thanks for being awesome [19:50:34] Thehelpfulone: which button is being laggy? [19:50:49] yuvipand1: need anything quick from me … my stomach is eating itself [19:50:57] tfinc: nope. [19:50:59] k [19:51:01] bbiab [19:51:22] all of them in general yuvipand1 [19:51:27] there's a bug report for this somewhere [19:51:29] * Thehelpfulone looks for it [19:51:33] indeed. [19:51:36] I like that the languages stay though now [19:51:48] it was fixed, though. [19:51:59] I added a fastclick implementation. [19:52:08] Thehelpfulone: what do you mean by 'languages stay'? [19:52:32] I meant that when you were scrolling up and down in the list of languages [19:52:42] it would become a white list and all the languages would disappear [19:52:56] ah yes [19:52:57] https://bugzilla.wikimedia.org/show_bug.cgi?id=35779 [19:53:07] this is the delay bug: https://bugzilla.wikimedia.org/show_bug.cgi?id=35778 [19:53:08] it was a relatively nasty webkit bug [19:53:35] hmm somehow I'm stuck in my settings window [19:54:38] Thehelpfulone: back button not working? [19:54:53] I just restarted the app - not sure why it didn't work [19:55:03] okay so https://bugzilla.wikimedia.org/show_bug.cgi?id=35778 -- when I click on any of the buttons there's still that 1-2 second delay [19:55:33] it could be related to loading the page actually [19:55:50] yeah it's when it tries to load the "read page in..." links [19:55:54] and the settings page [19:56:57] by default the app should open the main page yuvipand1 - it doesn't seem to be doing that [19:58:36] Thehelpfulone: ah, so - 'read page in' -> it does a request to get those [19:58:42] Thehelpfulone: others should be fast? [19:58:52] Thehelpfulone: also, you'll notice that the spinner is spinning when it does network requests.. [19:58:54] yes, but the settings one is slow [19:58:59] yep I noticed that [19:59:07] the settings one is slow but I can't think why it would be [19:59:30] Thehelpfulone: it is loading the list of languages [19:59:34] Thehelpfulone: it should be faster the second time [19:59:49] ah yes it is [19:59:55] it's not much more to load it the first time is it? [20:00:04] I meant when it loads the page [20:00:16] Thehelpfulone: well, language links? [20:00:22] yes [20:00:31] Thehelpfulone: that's data transfer the user didn't ask for, I'm not sure how we should do that :) [20:00:50] ok [20:01:00] ah I should try the new IPA you linked me to [20:01:11] Thehelpfulone: but the other buttons work snappier than previous versions? [20:01:20] yes a lot better [20:01:34] for some reason the wikipedia app doesn't show up with an icon on itunes yuvipand1 [20:01:36] any idea why? [20:01:47] Thehelpfulone: It never did for me when I was testing... [20:01:51] or is it because it's an IPA? [20:02:02] very possible Thehelpfulone [20:04:28] Thehelpfulone: page loads should also be slightly faster with this. [20:06:15] Thehelpfulone: also, a variant of http://bug-attachment.wikimedia.org/attachment.cgi?id=10490 will become the default start page before release [20:06:20] ok [20:06:21] http://stackoverflow.com/questions/173247/how-can-i-make-my-ad-hoc-iphone-applications-icon-show-up-in-itunes [20:06:31] yuvipand1: that might be helpful for the IPA icon? [20:06:44] * yuvipand1 looks [20:07:07] that's interesting [20:07:11] is there still the option to hide the search bar after a bit as on the iphone there's not too much space to read [20:08:05] Thehelpfulone: i'm afraid not. No consensus on that was reached, and IIRC current status is 'holding until new nav' [20:08:14] ok [20:16:55] Thehelpfulone: think this is 'good enough' to go out as a beta release? [20:17:37] hmm the settings page still delays for a few seconds yuvipand1 [20:19:00] also on the settings page [20:19:06] that nav bar with settings in the white text [20:19:14] the font is different to the "About" one [20:19:26] oh? [20:19:39] on the whole page that font is wrong IMO [20:19:48] I think it's time new roman or something [20:19:54] that's weird/interesting [20:19:56] * yuvipand1 pokes [20:19:56] when it should be whatever it is on "About" [20:20:23] Thehelpfulone: the lag for opening settings - I'll try to optimize it. Moving it to app start will only add that time to app start. [20:21:02] Thehelpfulone: the fonts look fine to me. [20:21:44] hmm [20:22:49] yuvipand1: try changing the font size [20:22:54] then search for something [20:23:01] and if you try to click on a search result [20:23:02] it doesn't work [20:23:49] Thehelpfulone: try again? I just tried that and it works fine... [20:24:27] and now it works.. :S [20:25:02] can the "contact us" [20:25:06] be a part of the actual app? [20:25:16] instead of taking you to safari [20:25:59] Thehelpfulone: hmm, will file a bug. [20:26:06] ok [20:26:42] New patchset: MaxSem; "Main page transform support for action=mobileview" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6317 [20:26:50] yuvipand1, ^ [20:27:36] wooo :) [20:32:25] Thehelpfulone: filed https://bugzilla.wikimedia.org/show_bug.cgi?id=36393 and https://bugzilla.wikimedia.org/show_bug.cgi?id=36394 [20:32:28] anythign else? [20:32:32] yep I saw [20:32:40] there's still that stuck in landscape mode [20:32:45] it seems to be intermittent too [20:32:51] not stuck in landscape mode [20:32:54] back [20:32:57] sorry, doesn't scroll in landscape mode [20:33:01] Thehelpfulone: still doesn't? [20:33:12] tfinc: update on the QA position? [20:33:19] oh did you fix it? [20:33:21] * Thehelpfulone tries again [20:33:23] YuviPanda: you already asked me that today [20:33:44] well, it was technically yesterday :P [20:33:52] not in my timezone ;) [20:33:56] good try though [20:34:19] :D [20:34:24] ok I can reproduce it [20:34:30] iphone in landscape mode [20:34:32] go to the main page [20:34:40] change your language through settings to another language [20:35:00] then when you go back to that page, you can't scroll downwards ( still in landscape mode) [20:35:12] turning portrait will fix it [20:36:07] hmmm [20:36:14] Thehelpfulone: when in unscrollable landscape mode [20:36:17] Thehelpfulone: try searching? [20:36:27] ok I'll go back to it [20:36:50] searching works [20:36:55] and scrolling works too [20:37:22] Thehelpfulone: can you file a bug? me filing might miss out details... [20:38:17] sure [20:39:51] done https://bugzilla.wikimedia.org/show_bug.cgi?id=36396 [20:40:19] awesome [20:40:28] Thehelpfulone: so three bugs filed. Anything more? [20:41:03] I'll just double check [20:41:23] main page doesn't work - you've got that already YuviPanda? [20:42:15] Thehelpfulone: yup [20:42:21] also YuviPanda there should be an option in the search bar to clear what's been entered [20:42:24] Thehelpfulone: there's a bug filed and MaxSem just checked in a patch that should fix it [20:42:34] a little X like apple has [20:43:05] Thehelpfulone: so that's another problem we ran into earlier and had to get rid of. Some versions have trouble with letting you put items on top of a input element [20:43:09] will try again though [20:43:20] ok [20:43:32] there's that font one as well YuviPanda but you can't seem to reproduce it [20:44:07] YuviPanda: if we want to remove Surprise me from the initial screen, do you need a new graphic? [20:44:23] philinje: no, it is fine [20:44:30] Thehelpfulone: me neither [20:44:50] I *can* reproduce it, I mean that ou can't :) [20:44:58] Thehelpfulone: screenshot? [20:46:16] yep [20:46:18] sending [20:46:38] YuviPanda: thinking we should remove the three links at the bottom [20:46:43] i put a comment in the bug [20:48:00] replied [20:48:01] philinje: ^ [20:48:10] ok [20:49:15] sent YuviPanda [20:49:18] YuviPanda: hang on, is there a problem going to the main page? [20:49:44] philinje: not really. They can hit the 'W' and go to it [20:49:57] but *right* now there is a problem - Main Page is broken, MaxSem just checked in a change that'll fix it soon [20:50:11] Thehelpfulone: that's indeed very weird :| [20:50:17] I see that it is a serif font [20:50:20] yep :( [20:50:27] Thehelpfulone: open a bug, put that in as an attachment? [20:50:34] ok [20:50:49] YuviPanda: so this screen is temporary, right? [20:50:58] preilly: whats a good status update for http://www.mediawiki.org/wiki/Wikipedia_Zero ? [20:51:21] preilly: also http://www.mediawiki.org/wiki/Wikipedia_over_SMS_%26_USSD [20:51:51] philinje: yup [20:52:28] YuviPanda: so, my inclination is not to put functionality in it, which makes it look permanent [20:53:03] YuviPanda: this is a bigger issue that requires some more thought in the context of the new UI [20:53:04] philinje: also, if the center bit is an image - I'm not sure how that will localize [20:53:14] ah good point [20:53:23] philinje: so, I assume that a similar 'start page' will be ther in the new UI as well. Just that it won't/need not be the same [20:53:39] hmm, not sure [20:54:14] the idea is to load initial content in a 'static' way, that does not involve network requests [20:54:15] done, https://bugzilla.wikimedia.org/show_bug.cgi?id=36397 [20:54:41] you're leaning that way because of the spinner being deceptive - the user thinks they have to wait? [20:54:58] yup [20:55:40] ok, let me noodle on this with Lindsey and others [20:55:58] off to another meeting... [21:08:04] awjr: see my message about our 1:1 ? [21:08:21] tfinc: no i did not [21:08:27] awjr: i need to move it [21:08:29] to earlier [21:08:36] 4-4:30 [21:08:39] ok, what time? i'm open [21:08:40] ah ok [21:08:42] no problem. [21:08:52] tfinc i seem to no longer have a calendar invite for our 1:1s [21:09:49] Thehelpfulone: the iTunesArtwork file seems to have no effect. I'm pushing out the beta anyway. [21:09:56] ok [21:10:05] awjr: sent [21:10:07] ty [21:16:27] tfinc: replace the iOS ipa with http://dl.dropbox.com/u/8768784/Wikipedia-v3.2-beta1.ipa [21:16:30] ? [21:17:22] sure [21:18:02] YuviPanda: its up [21:18:07] thanks [21:19:35] tfinc: can you give me the link again? [21:19:41] dumps.wikimedia.org/what? [21:19:49] http://dumps.wikimedia.org/iOS/Wikipedia-v3.2-beta1.ipa [21:20:01] ah [21:20:01] okay [21:20:21] awjr: are you working today? [21:20:23] chrismcmahon: heads up, we're going to start a beta cycle. [21:20:26] preilly yes [21:20:38] awjr: can you look into an issue for me? [21:20:43] YuviPanda: ping me if can help [21:20:49] preilly what is it? [21:21:03] awjr: the zero banner is missing with the new design [21:21:10] chrismcmahon: I'm writing out the email, will run it through you once. It might be possible that the messaging is not clear enough to entice people to test [21:22:08] preilly: no good :( [21:22:12] how does the banner get triggered? [21:22:49] awjr: from a header [21:23:44] awjr: RequestHeader set X-CARRIER "Wikimedia" [21:23:45] RequestHeader set X_DEVICE webkit [21:26:33] MaxSem: you around? [21:26:39] yup [21:26:41] MaxSem: the zero banner is missing with the new design [21:28:27] tfinc: http://rt.wikimedia.org/Ticket/Display.html?id=2582 [21:31:21] preilly, missing or hidden? [21:32:00] MaxSem: missing I believe [21:32:43] hmm i set the directive to set the X-CARRIER in my htaccess but im not seeing it in the headers [21:33:10] awjr: it's a request header [21:34:56] YuviPanda: fire at will [21:39:16] awjr: you will also need $wgEnableZeroRatedMobileAccessTesting = true in your LocalSettings [21:39:29] yeah got that - im looking through the code now. [21:42:24] preilly it seems to be generating the banner html but setting an inline style for the banner div of "display:none" [21:42:53] awjr: yeah, that is what banner.js is for [21:42:57] roger [21:43:34] preilly, http://dpaste.com/741109/ [21:43:57] lost this piece during conversion [21:44:05] does it help? [21:44:57] preilly there doesn't seem to be anything in banner.js to actually make the banner visible [21:45:51] awjr: yeah [21:45:57] awjr: just to turn it off [21:46:07] awjr: MaxSem why did that get refactored out? [21:46:16] awjr: I think we've found the issue [21:46:20] oversight [21:46:22] word [21:46:51] New patchset: preilly; "restore zero rated banner" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6326 [21:47:35] awjr: please review https://gerrit.wikimedia.org/r/#change,6326 [21:47:53] looking [21:48:04] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/6317 [21:48:06] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6317 [21:51:05] New review: awjrichards; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/6326 [21:51:07] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6326 [21:51:08] chrismcmahon: http://etherpad.wikimedia.org/wikipedia-mobile-1-2-beta1-notes is what I got so far [21:51:13] preilly: ^ seems to fix it [21:51:26] chrismcmahon: I'll be filling in various suggestions on things to test in there now. [21:51:30] awjr: okay, thanks [21:51:39] MaxSem: thanks, for adding that back [21:51:42] YuviPanda: reading... [21:54:32] YuviPanda: I suggest you switch the order of the iOS instructions, put the info for noobs at the bottom. something like "if you haven't sent us the UDID of your device, see instructions at the bottom" [21:55:04] chrismcmahon: i'm thinking of moving that out to a wiki page [21:55:20] that works [22:06:47] chrismcmahon: I think I'm done [22:08:06] chrismcmahon: looks ok? [22:10:22] YuviPanda: taking one more look, but I like it [22:11:19] YuviPanda++ I like it [22:11:24] chrismcmahon: cool :) [22:11:33] chrismcmahon: is this self sufficient enough to be tweeted out / forwarded? [22:11:59] I think so, but just confirming [22:12:39] I think so too. I'll tweet to a link of it, and quote that first sentence [22:14:16] awesome [22:14:20] i'll post this to mobile-l now [22:16:12] chrismcmahon: http://lists.wikimedia.org/pipermail/mobile-l/2012-May/005566.html [22:16:15] tweetable link [22:16:31] tfinc: beta is out ^ [22:16:59] woot [22:17:23] New patchset: preilly; "Add missing global" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6331 [22:17:44] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/6331 [22:17:46] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6331 [22:17:51] i'll have to look at it after meetings [22:18:34] tfinc: am tweeting and then crashing for the night [22:18:43] Thehelpfulone: thanks for being helpful :) [22:19:49] New patchset: preilly; "Remove CSRF check" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6332 [22:20:15] okay, am crashing. [22:20:17] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/6332 [22:20:17] gnite everyone [22:20:19] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6332 [22:20:22] thanks chrismcmahon and Thehelpfulone :) [22:21:38]