[09:48:52] MaxSem: what exactly is 'override' in the action=mobileview params? [09:54:26] yuvipanda, ask preilly with his hacks [09:56:26] hmmm hacks [09:56:58] MaxSem: It gets you a...token? [09:57:03] I'm confused [09:57:14] ignore it [09:57:26] or, better, press him to remove it;) [09:58:06] I'm possibly very confused. [09:58:07] sigh [09:58:40] hmm, so this was the hack for retreiving a token [09:58:41] ok [09:59:15] * yuvipanda makes a note to ask preilly  [10:29:50] hmm, 'invalidtitle' is actually 'page not found' [10:29:51] ok [10:39:44] hmm, the app is only around 3000 lines of code. [10:39:46] not bad :) [10:40:56] are you testing not on labs? [10:41:21] cuz I've swapped invalidtitle with missingtitle now [10:41:29] should make a bit more sense [10:46:48] MaxSem: I was looking at a checkout of MobileFrontend. Was a bit antiquated [12:09:26] MaxSem: http://mobile-geo.wmflabs.org/ is down? [12:17:27] MaxSem: definitely down [12:46:32] rebooted [14:34:01] MaxSem: thanks. Main page transforms work :) [14:35:01] yuvipanda, next time you can just reboot the instance yourself. labs is too unstable:( [14:37:09] hmm, I've access but haven't really used it at all [14:37:14] MaxSem: will do. Thanks! [15:39:06] hello jdlrobson [15:39:11] hey YuviPanda [15:39:17] you've given me quite the backlog ;-) [15:39:26] :D [15:39:34] jdlrobson: many of them are quite small [15:40:26] i hope so for your sake ;-) [15:40:30] i've got a new hat for you today btw [15:40:39] and internet connection should be __lots__ better [15:41:33] ah [15:41:38] jdlrobson: mine should be a lot worse [15:41:47] i'll very probably be black rectangle today [15:43:58] :( [15:44:24] soon you'll be //that guy// who looks like a black rectangle [15:44:46] some day, it'll be a standup of 5 black rectangles [15:54:59] jdlrobson: when do you think you can look at the pull reqs? [15:55:04] I'm hoping to push out a beta today... [15:55:08] mm [15:55:09] to the Google Play store [15:55:13] i was hoping tomorrow, but we'll see [15:55:16] :( [15:55:34] i'll try my best to get them done today [15:55:50] i need to review the current situation with mobile site as there is a deployment today and i want to fix a lot of the screw ups I made last week [15:55:57] (relating to older browsers) [15:56:38] jdlrobson: ok :) [16:07:23] k YuviPanda reviewed them all and made some comments will pull and test them later when hopefully they are taken care of :) [16:10:47] jdlrobson: replied to / fixed most of them :) [16:18:27] jdlrobson: hi [16:21:40] jdlrobson: hi [16:25:54] yuvipanda: sorry i dropped my laptop so i didn't catch your last message [16:29:56] jdlrobson: hey Jon [16:30:00] hey philinje [16:30:07] how wa your weekend? [16:30:11] was [16:32:34] very good [16:32:43] lots of nature - relaxing [16:32:57] my mind is clear and feeling very productive today :) [16:34:26] * yuvipanda has a cold and is reasonably drowsy [16:34:40] jdlrobson: just replied saying fixed/replied to most of them [16:34:58] thanks yuvipanda - will merge them before I get started on anything else [16:35:06] hopefully will be done in next 2 hours [16:35:34] woo [16:46:40] greetings all [16:46:55] yuvipanda: iPhone3G came in [16:48:29] wooo [16:48:36] now just need to beam it here [16:48:43] hang out is up and running https://plus.google.com/hangouts/_/28a2c7a297ce7c76ea75cdb254b8865099462031?authuser=1&hl=en# [16:49:21] i'm staying pretty good to my word of having this up and running 10min before the actual standup [16:49:39] heh [16:49:47] jdlrobson: nice to hear, glad you had a good one. Sounds like I should bug you in a couple hours [16:50:09] jdlrobson: i surfaced a nasty bug in opera mini that we should talk about [16:50:38] excellent! (not that there is a nasty bug but that you found something and we are going to talk about it) [16:50:42] currently debugging on a nokia n95 [16:50:44] lots of fun [16:50:46] (another nasty bug) [16:51:14] are there any other type when you're dealing with client side mobile browsers? [16:51:27] BlackRectangle: seriously [16:51:47] jdlrobson: this one is really bad though as it brakes search on opera mini [16:51:53] breaks* [16:52:04] hopefully its the same one I'm looking at now then as search is also broken on nokia n95 :) [16:52:23] all hail the black screen that is yuvi on hangout [16:52:33] hey awjr [16:52:35] i should have better wifi today [16:52:36] \o/ [16:52:36] tfinc_: you're on mute [16:52:43] hi tfinc_+ [16:52:45] er [16:52:46] tfinc_ [16:53:01] tfinc_: ( 6.33%) unspecified Opera Mini - a substantial percentage of traffic [16:54:14] awjr: https://plus.google.com/hangouts/_/28a2c7a297ce7c76ea75cdb254b8865099462031?authuser=1&hl=en# [16:54:23] this saves even more bandwidth! [16:54:41] lolz [16:54:50] jdlrobson: how many hats do you have anyway? [16:55:12] currently 4, only 2 regulars though [16:55:17] ah [16:55:24] hi mobile team, can you give me an example user agent for the 1.0.3 version of the app? [16:55:29] the other 2 are being phased out [16:55:32] ;-) [16:55:55] jdlrobson: deprecated, you mean? :) [16:56:01] exactly [16:56:15] one seems to make me look a bit schoolboyish these days - think it might need starching [16:56:27] tfinc_: 36490 search is probably broken in more devices / older browsers [16:56:32] drdee_: WikipediaMobile/1.0.3 [16:56:38] srikanthlogic: looking into it now :) [16:56:45] managed to replicate on a nokia n95 [16:56:56] jdlrobson: great! [16:57:06] * BlackRectangle has zero hats. Should change before berlin [16:57:08] hoping to get it fixed for todays deployment [16:57:12] thanks BlackRectangle! [16:57:19] It might be summer there, but am pretty sure I'll be under multiple layers of clothing again [16:57:41] MaxSem: awjr : did you get the hangout link ? [16:57:42] BlackRectangle: does that apply to both the iOS and Android versions? [16:58:12] drdee_: yes, though iOS is 3.x+ [16:58:23] * BlackRectangle waves at MaxSem  [16:58:29] just missing awjr now [16:58:41] where are you guys? [16:58:49] preilly wont be joing us today as hes not feeling well [16:58:56] linSmith: next to r34/r35 [16:58:59] BlackRectangle many thanks! [17:05:10] New review: awjrichards; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/6753 [17:05:12] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6753 [17:05:16] BlackRectangle is a cheater! [17:06:09] philinje: https://bugzilla.wikimedia.org/show_bug.cgi?id=36017 [17:06:28] jdlrobson: is that tea? [17:06:34] MaxSem: how what why/ [17:06:34] ? [17:06:54] yup [17:06:56] you've seen us while we haven't seen you [17:06:59] very english [17:07:27] philinje: was this the page you were just talking about? http://www.mediawiki.org/wiki/MobileFrontend/Photo_upload i actually did look at this and went through the various links last week [17:07:31] MaxSem: Choice is between you seeing me or me hearing you everyone :P [17:07:50] justifications, justifications [17:08:01] MaxSem: I might be hopping to another city for a week or so in another week or so. Maybe I'll have working wifi there! [17:08:29] MaxSem: my current city has 2 hours of scheduled power cut a day. Outskirts have up to 9 hours of scheduled power cuts. Wifi might be a bit too much to ask for :P [17:09:31] :D [17:11:08] * tfinc boots up the new iPhone3G test phone [17:11:29] * tfinc is amused/annoyed by the "Do not update software - Phone will relock" [17:11:54] tfinc, philinje: when you'll be able to chat about PageImages? [17:12:32] tfinc: thoughts on how long it will take to get here? [17:13:09] rachel will coordiante that. lets see if it beats us meeting in berlin [17:13:10] ;) [17:13:28] tfinc: when do we want to setup intercontinental debugging? [17:13:39] * tfinc looks at calendar for today [17:13:52] 11-12 [17:14:10] jdlrobson: should we meet later today? [17:14:27] should be fine philinje - just depends how long this search problem takes to get fixed [17:14:44] ok let us know [17:15:04] MaxSem: can you give me a little background PageImages? [17:16:56] philinje, it does 3 things: associates images with pages to 1) make this information available via the API to match Geonames 2) replace lame thumbnalis of OpenSearchXml 3) search for pages with/without images [17:17:13] so 3) especially concerns you [17:18:30] shweet [17:18:33] * YuviPanda goes afk for a bit [17:18:37] tfinc: will poke you at 11AM PDT [17:20:24] YuviPanda: sure [17:20:36] MaxSem: did you wind up doing the deployment with Patrick last week? [17:21:11] awjr, no I fell aslep earlier [17:21:19] MaxSem: sounds awesome [17:22:24] YuviPanda: since this a new phone i'll have to do a new build. what should i build form ? [17:22:25] from* [17:22:26] MaxSem: was the original motivation related to photo uploads, because it will help with that [17:22:39] philinje, tfinc, the question is about sufficiency of functionality [17:23:12] philinje, it was taken into account, yes [17:24:30] MaxSem: new project page in progress: https://www.mediawiki.org/wiki/MobileFrontend/Photo_upload [17:24:57] MaxSem: this might be useful: https://www.mediawiki.org/wiki/MobileFrontend/Photo_upload/Upload_Wizard_mobile_port [17:25:32] philinje, tfinc, I have the fundamental question of whether we will need finer-grained search capabilities. we discussed this stuff with you Phil, options being search for pages with less than some number of images or some other criteria [17:25:52] ah yes [17:26:13] to set a parameter for the number of images threshold [17:26:44] search by number of images is problematic because there is no set number of "enough" images per page [17:27:32] yes, that's where we left it last time, but perhaps just allow a parameter to be modified by experimentation [17:27:54] another thought: position of images in the page (or the lack thereof) [17:28:00] I tried experimenting with more complex scoring system, the outcome was some system that has the same problems as search by number of images, but with criterias less clear to mortal humans [17:28:57] we will have a somewhat different issue with Wiki Loves Monuments: [17:29:07] philinje, I actully use scoring for determining which image should be associated with a page, and scores take into account the position of image on page [17:29:16] i see [17:29:40] is the scoring system on w wiki page somewhere? [17:29:47] no [17:30:09] it's not something for end-users [17:30:16] could you create a page under Photo upload and put it there? [17:30:35] yes, some pages are not for end users but for developers [17:30:59] there's extension's page for such things (and I should really add more information to it besides the infobox) [17:31:18] ok, let me know where that is [17:31:34] awjr: how is our deployment looking for today? [17:31:45] tfinc: good question :) [17:31:49] awjr: let me know when the wiki page is up to date and i'll good through the changes [17:31:52] once i get through my mail backlog i'll let you know [17:31:58] awjr: k [17:32:05] tfinc: i have no idea how patrick was formatting the pages to look all pretty [17:32:09] MaxSem: the WLM issue is: number of photos uploaded per monument [17:32:12] do you? [17:32:28] tfinc, philinje, so the question is: do we need to search for something more than presence/absence of images on page? [17:32:53] philinje, this is tangential to this extension's purpose [17:33:09] not all photos uploaded are supposed to be on any given page [17:33:27] yes, though the WLM case may or may not be related to an article - the issue is monuments [17:34:59] it's like another type of article [17:35:10] so WLM will need a different image accounting system [17:35:40] my question is about the PageImages scope [17:36:22] MaxSem: they already have one - uploads are categorized by monument, then eventually the winners are chosen for the monument articles [17:36:58] MaxSem: ok, could you explain about the lame thumbnails? [17:37:30] tfinc: back [17:37:37] tfinc: gimme a second, will make you a branch. [17:37:45] tfinc: master's a bit behind, since there are 10 open pull reqs [17:37:52] MaxSem: happy to talk on Skype [17:38:12] philinje, sure [17:39:06] ok one sec [17:40:16] moving to a meeting room [17:40:24] YuviPanda: k [17:47:43] awjr: MaxSem : over the weekend we had some nasty twitter traffic around vandalism on the cinco de mayo article. it was quickly corrected on the desktop but it took forever for mobile to pick it up. what's the typical delay we should exect ? [17:48:36] YuviPanda: just fixing nasty search bugs then I will go pull crazy [17:48:58] jdlrobson: ok :) [17:49:09] * tfinc wonders what pull crazy jdlrobson looks like [17:49:31] tfinc: you'll basically see nothing in irc for a few mins ;-) [17:49:56] does pull crazy jdlrobson come with a hat? i'm imagingin an action figure here [17:49:59] so basically the search problem seems to effect browsers that don't support texContent [17:50:07] * textContent [17:50:55] btw tfinc I can't make standup friday due to my visa interview \o/ [17:51:23] bingo [17:51:28] fixed search on nokia n95 [17:51:30] tfinc: im not sure - looking at the response headers from a mobile request, the s-maxage for cache-control is 300s [17:51:34] jdlrobson:k, just mail out like normal [17:52:00] awjr: so in this case it was certainly hours. if you guys are sure that it should be quick then i'll have to experiment and see if i can reproduce it [17:52:04] this was certainly hours [17:52:10] tfinc: i am definitely NOT sure [17:52:32] tfinc: i'll have to ask asher/preilly [17:53:10] awjr: k, just find out the frequency. i'm still not sure about the extent of the problem [17:53:15] but it led to comments like this https://twitter.com/#!/gorelickingood/status/198967986353213440 [17:53:27] err [17:53:32] tfinc: pull from intercontinental-debugging-may-7-2012 on my repo? [17:53:41] this one shows it https://twitter.com/#!/meglanker/status/198968645819432960 [17:55:20] tfinc: i'll get the info from asher as soon as i see him online [17:55:25] awjr: thanks [17:55:28] np [17:56:38] tfinc is there a bug open about this? [17:56:52] awjr: i'll open one as soon as you tell me what the cahce settings should be [18:01:36] * YuviPanda pokes tfinc  [18:05:27] tfinc: here's what we have so far for today's deployment: http://www.mediawiki.org/wiki/Extension:MobileFrontend/Deployments/2012-05-07 [18:05:31] * tfinc punches git for not pulling from remote branches [18:05:41] awjr: thanks [18:07:51] New patchset: Jdlrobson; "support browsers that do not support textContent (add get text function)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6803 [18:07:52] New patchset: Jdlrobson; "make sure nokia rule is important" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6804 [18:07:53] New patchset: Jdlrobson; "jslint codebase" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6805 [18:07:54] New patchset: Jdlrobson; "move updateQueryStringParameter into settings.js" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6806 [18:07:55] New patchset: Jdlrobson; "get rid of default list styling on search results" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6807 [18:08:11] philinje: should i try to fix the email address configurations for the feedback form today when i deploy, so that only the english addresses have the 'q' or 'c' suffix? [18:08:19] in git do i have to do anything special to update my remote branches? .. besides a pull [18:08:43] awjr: if ossible, that would be great [18:08:48] tfinc: pull should work, but I like doing fetch + checkout [18:08:56] doh labs is down again [18:09:01] git remote add yuvipanda [18:09:03] git fetch YuviPanda [18:09:17] YuviPanda: but for some reason git branch -a isn't showing your new branch [18:09:20] i see all of your old ones [18:09:36] i already have you as a remote [18:09:40] so tfinc git fetch https://gerrit.wikimedia.org/r/mediawiki/extensions/MobileFrontend refs/changes/07/6807/1 && git checkout FETCH_HEAD should hopefully fix opera mini search - it fixes s60 (cc @srikanthlogic ) - if labs comes back I'll stick it on there for testing purposes [18:09:46] * jdlrobson gets ready to go pull crazy [18:10:18] hmmm [18:10:31] tfinc: can't checkout yuvipanda/ [18:10:31] ? [18:11:25] nope .. even though my local checkout thinks its up to date [18:11:46] tfinc: did a git fetch? [18:12:08] ahh i see why now [18:12:13] intercontinental-debugging-may-7-2012 new (next fetch will store in remotes/yuvi) [18:12:25] that explains it [18:12:29] :) [18:12:42] hmm, I don't remember seeing that though [18:13:39] New review: awjrichards; "Aside from trailing whitespace, looks good to me." [mediawiki/extensions/MobileFrontend] (master); V: 1 C: -1; - https://gerrit.wikimedia.org/r/6803 [18:14:32] New review: awjrichards; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/6804 [18:15:11] * YuviPanda pokes philinje about  [18:15:11] ~f@wikipedia/Ironholds (freenode) [18:15:16] err [18:15:20] bad copy paste bad [18:15:36] * YuviPanda pokes pchang about https://bugzilla.wikimedia.org/show_bug.cgi?id=36017 [18:15:41] * YuviPanda pokes philinje ^ [18:15:41] New review: awjrichards; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/6805 [18:16:54] awjr: have you ckedked in the email change already? [18:17:00] git is still not behaving [18:17:21] philinje: no, it's something i'll do during deployment. it's just a configuration change. [18:17:38] ohh .. i think i have it [18:17:54] Switched to a new branch 'intercontinental-debugging-may-7-2012' :D [18:18:13] git fetch yuvi FTW! [18:18:21] i see - Tomasz was wondering if we should bundle up changes for next monday, but if it's part of the deployment, then sounds fine [18:18:26] binasher: what is the TTL for mobile pages? looking at page response headers it seems like it ought to be 300s but it sounds like in reality it's more on the scale of hours [18:18:34] yes, for some reason 'fetch ' always is funny :) [18:18:45] awjr: that would leave one small text change for next Monday [18:19:01] yeah, i thought a 'git pull' would hit all origins but clearly it didn't [18:19:12] philinje: the email address generation logic happens at the configuration level - i can wait til next week to do it though [18:19:14] i had to explicitly say the remote [18:19:17] philinje: what's the one small text change? [18:19:24] ah, no - it doesn't [18:19:59] * tfinc goes to build a new ips [18:20:00] New review: awjrichards; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/6806 [18:20:01] ipa* [18:21:00] New review: awjrichards; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/6807 [18:21:50] New patchset: awjrichards; "support browsers that do not support textContent (add get text function)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6803 [18:22:32] New review: awjrichards; "i went ahead and fixed the trailing ws as a commit amend." [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/6803 [18:22:36] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6803 [18:23:01] YuviPanda: i have the app running now [18:23:07] tfinc: how's scrolling? [18:23:09] YuviPanda: where would you like me to focus testing [18:23:11] tfinc: plus what version of iOS is? [18:23:26] 4.2 [18:23:41] tfinc: so, two things: 1. scrolling on articles 2. scrolling after expansions / contractions of sections 3. performance during expansion / contraction of sections [18:23:49] YuviPanda: spin up an etherpad and i'll take notes there rather then cluttering up IRC [18:23:59] New review: Jdlrobson; "Thanks Arthur for the whitespace - I'm kicking myself for missing that!" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6803 [18:24:18] jdlrobson: no worries, i make WS mistakes all the time :p [18:24:27] tfinc: tfinc http://etherpad.wikimedia.org/intercontinental-debugging-may-07-2012 [18:24:34] jdlrobson: you need to rebase the outstanding commits before they can be merged [18:24:56] k [18:24:57] 1 s [18:26:14] tfinc: spinner not going away means something is very broken [18:26:18] tfinc: did you do submodule update? [18:26:32] nope. let me do that [18:27:00] * tfinc has no idea why he can't ever remember to do that [18:28:39] jdlrobson: how's your timing for a talk today? [18:28:41] YuviPanda: scrolling is super jittery [18:29:32] hey philinje - i probably need about an hour to merge yuvi's stuff so he can get a beta out [18:30:49] no problem [18:31:14] YuviPanda, do image pages look ok in the app? [18:31:56] MaxSem: I tested on labs, it seemed okay (I didn't error out) but need to test more. Fixing iOS issues now [18:31:59] MaxSem: why? [18:32:11] New patchset: Jdlrobson; "jslint codebase" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6805 [18:32:12] New patchset: Jdlrobson; "make sure nokia rule is important" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6804 [18:32:12] New patchset: Jdlrobson; "get rid of default list styling on search results" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6807 [18:32:13] New patchset: Jdlrobson; "move updateQueryStringParameter into settings.js" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6806 [18:32:16] YuviPanda, I was concerned about styling [18:32:23] awjr: did that do it? got myself confused [18:33:10] New review: awjrichards; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/6804 [18:33:12] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6804 [18:33:40] New review: awjrichards; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/6805 [18:33:42] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6805 [18:33:49] YuviPanda: my initial notes are in the etherpad [18:34:34] New review: awjrichards; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/6806 [18:34:36] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6806 [18:34:49] New review: awjrichards; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/6807 [18:34:52] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6807 [18:34:53] jdlrobson: looks like it :) [18:34:55] tfinc: pull now and try? [18:34:58] sweet [18:35:22] jdlrobson: i've found it a lot easier to try and not make commits that are dependent on one another [18:35:25] * tfinc builds new ipa [18:35:35] sometimes it's unavoidable though [18:35:51] but if you havea bunch of dependent commits, sometimes it's easier to just squash them into one commit for review [18:36:07] i don't believe in squashing [18:36:10] I like small commits [18:36:32] you can still do small commits locally [18:36:55] but if I squash and do a git blame do i get the squashed commit on the smaller more specific commit? [18:37:03] * YuviPanda doesn't like squashing either [18:37:14] i don't mind rebasing so much - usually my pulls are small enough for it not to be an issue [18:37:16] YuviPanda: better [18:37:19] jdlrobson: no, you would get the squashed commit [18:37:26] jdlrobson right on [18:37:33] tfinc: how much better? [18:37:41] labs is still down? :( [18:37:59] YuviPanda: really good [18:38:32] tfinc: article expansion? [18:38:33] i need to load a long article and expand all its sections to really test this [18:38:37] err [18:38:40] err [18:38:43] s/article/section [18:38:44] section expansion, I mean [18:38:46] yeah [18:41:39] tfinc: pull again and try? [18:41:45] k [18:44:59] YuviPanda: that update made the app very unhappy [18:45:20] i *cant* scroll anymore [18:45:54] sigh [18:46:38] tfinc: pull now? [18:46:43] k [18:46:52] tfinc: scrolling should be okay and the 'can't scroll below a certain point sometimes' should be gone [18:50:06] YuviPanda: yes. both look good now [18:50:23] tfinc: test the 'can't scroll' a bit more? [18:50:26] tfinc: it's *very* intermittent [18:50:41] and *very* device specific [18:50:45] which sucks [18:51:07] sure [18:51:32] awjr: did you see philinje comments on http://www.mediawiki.org/w/index.php?title=Talk:Mobile_design/Contact&diff=0&oldid=519041 ? [18:52:02] jdlrobson: yeah, im going to fix the email address issue during deployment (it's a change i'll have to make in configuration) [18:52:07] sweet [18:53:04] philinje: is "Unless you agree to have your information made public, please do not include personal information in your comments."" final? [18:53:29] YuviPanda: i'm not seeing it happen again [18:53:49] tfinc: pull again? [18:54:03] k [18:54:04] awjr: cache ttls are set by mediawiki [18:54:14] hacks.css ;) [18:54:22] binasher: s-maxage, right? [18:54:25] yeaaah [18:54:32] yeah [18:54:46] YuviPanda: what can we do about the flickering that happens when you expand a section ? [18:54:51] tfinc: so this is all because of css hacks needed for inline styles [18:55:12] binasher according to tfinc pages are being cached for durations in the range of hours rather than minutes. [18:55:17] tfinc: good question. Let me see if I can repro that in the sim [18:55:27] binasher, even on enwiki which has a ttl of 300s [18:56:08] ? [18:56:31] Cache-control: s-maxage=2678400, must-revalidate, max-age=0 [18:56:35] that's the default from mediawiki [18:56:45] mobile is no different [18:57:17] YuviPanda: i'm going to grab lunch @ 12 ... should be back within 10-15 [18:57:30] binasher i am seeing Cache-Control:s-maxage=300, must-revalidate, max-age=0 on enwiki [18:58:04] you aren't going to see the apache headers from either varnish or squid [18:58:28] look at your test mediawiki instance [18:58:35] YuviPanda: what changed with this update? [18:58:59] tfinc: ok [18:59:04] tfinc: i got back hacks.css [18:59:10] tfinc: but killed a few styles [18:59:20] tfinc: we need to figure out *which* styles exactly are causing the problem and kill them [18:59:25] easier now since hacks.css is fast [18:59:26] err [18:59:27] smaller [19:00:09] k. as soon as the old iPhone3G finishes charging i'm going to hand the new one to our admin to send out to you [19:00:55] ok [19:00:57] awesome [19:01:03] yo mobile team: another question, why is the mimetype of SSL requests to mobile servers set to NONE/mobilewikipedia and not either text/html or application/json or whatever is appropriate? [19:01:05] YuviPanda: i'm stepping out to grab food .. bb in 10-15 [19:01:52] tfinc: ok [19:02:15] drdee: is this from the apps? [19:02:24] oh hey [19:02:27] drdee [19:02:31] that isn't the mime type [19:02:32] yes [19:02:33] the next field is [19:02:34] yes [19:02:39] NONE/$proxy_host [19:02:40] i just noticed [19:02:43] comes from nginx [19:02:45] sorry sorry sorry [19:02:58] cool [19:03:30] binasher: oh i see. so why would a non-mobile page view appear way fresher than a mobile page view? is it because non-mobile pages get purged upon edit while mobile do not? [19:04:30] mobile should get purges too [19:04:35] according to http://wikitech.wikimedia.org/view/MobileFrontend it should get purged [19:04:41] philinje: jdlrobson just curious, how is 'search traffic' being measured? on API calls to search? [19:04:53] non-canonical URLs again? [19:05:16] yeh I was wondering the same YuviPanda philinje - it's possible that the new search module just makes less calls to the api... [19:05:22] +1 [19:05:47] jdlrobson: I checked and noticed that it has a typingspeed delay before it makes the call, so that would naturally result in fewer calls if the older implementation didn't have that [19:06:22] binasher, tfinc has been getting reports of incredibly stale mobile pages while non-mobile pages appear fine. tfinc, can you recap? [19:06:38] also does it include api calls from the mobile app? [19:15:49] YuviPanda: not sure what's going on here but in the app on the 'Jon Bon Jovi' article - if I open Awards and Nominations I do not get the tables that I see on http://en.m.wikipedia.org/wiki/Jon_Bon_Jovi#_ [19:16:30] * YuviPanda looks [19:16:50] * jdlrobson is half way through testing and merging yuvi's stuff [19:19:04] jdlrobson: yup, the infobox doesn't seem to show up :( [19:19:09] :( [19:19:13] * YuviPanda investigates [19:24:16] jdlrobson: I missed your last message, I think [19:24:23] nope [19:24:36] btw YuviPanda just trying out remove-images-special-casing [19:24:42] and nothing happens when I click an image [19:24:43] that normal? [19:24:59] just see the spinner.. [19:25:20] jdlrobson: yeah, it needs today's deploy [19:25:26] ahh k [19:25:52] jdlrobson: I think it's okay to leave that one out till the deploy goes out [19:26:58] so YuviPanda you don't agree we should just have the one error message handler? https://github.com/wikimedia/WikipediaMobile/pull/232 [19:27:01] tfinc: poke me when you're back [19:27:11] philinje: only 2 more pull requests to go and I'm all yours [19:27:51] jdlrobson: we'd need one for 'modal error' (search errors and langlink errors) and a non-modal one (page not retrievable) [19:28:20] jdlrobson: the non-modal one already takes a status param and has 404 vs 'other errors' modes. [19:28:34] jdlrobson: I'm just unsure what *other* problems than network errors can crop up for search and langlinks [19:29:10] jdlrobson: 'A problem has occured' type error messages without pointing to anything are very infuriating, no? I'd rather not have it *that* generic [19:29:30] 500 error? [19:30:21] jdlrobson: yes, but word it as what? "Server error?" [19:31:12] [WikipediaMobile] jdlrobson pushed 9 new commits to master: http://git.io/tIHFug [19:31:12] [WikipediaMobile/master] Fix reference display not dismissing when user taps outside it - YuviPanda [19:31:12] [WikipediaMobile/master] Fix scrolling in search results, history and lang links on iOS4.x - YuviPanda [19:31:12] [WikipediaMobile/master] Disable Animation for Reference Reveal - YuviPanda [19:31:43] 'Our servers are experiencing problems please try again' / or something [19:32:11] YuviPanda: can you rebase https://github.com/wikimedia/WikipediaMobile/pull/237 ? [19:32:28] one moment [19:32:35] sure [19:36:29] jdlrobson: pushed [19:37:24] sure? git fetch yuvipanda not getting me anything... [19:38:14] jdlrobson: nope, pushed? [19:38:23] it took a bit to get through, so try again? [19:38:27] there we go [19:39:33] YuviPanda: does https://github.com/wikimedia/WikipediaMobile/pull/237/files have any visible effect? [19:40:07] also YuviPanda -> https://github.com/yuvipanda/WikipediaMobile/commit/01a21fc6d96ff7cf6ea80a4778574a894370d0a0 [19:40:11] see comment [19:41:11] jdlrobson: so - that line was no longer needed in setErrorPage and was actively causing it to crash. [19:41:19] Should've had a commit prior to that one that removed just that [19:41:46] let me go do that [19:42:20] thx [19:42:27] member:YuviPanda: does https://github.com/wikimedia/WikipediaMobile/pull/237/files have any visible effect? [19:42:38] I can't see any but wanted to check [19:45:35] checking [19:45:59] jdlrobson: not before the deploy. [19:46:05] YuviPanda: when was WikipediaMobile/1.0.3 released? [19:46:32] is anyone able to bring mobile-enwp.pmtpa.wmflabs back to life? MaxSem maybe? [19:46:37] jdlrobson: after the deploy, redlinks should give 404 [19:46:41] k [19:46:44] and main page should be mobile formatted [19:46:49] drdee: let me check [19:46:50] i'll take your word for it and merge it in [19:46:55] YuviPanda: back [19:47:13] [WikipediaMobile] jdlrobson pushed 2 new commits to master: http://git.io/tIxvZw [19:47:13] [WikipediaMobile/master] Special case Main Page naming - YuviPanda [19:47:13] [WikipediaMobile/master] Handle both error conditions that can result from mobileview API - YuviPanda [19:47:28] drdee: ~ Jan 30 [19:47:39] both Android and iOS? [19:47:40] tfinc: when I get labs back I will need your help debugging https://bugzilla.wikimedia.org/show_bug.cgi?id=36530 [19:47:47] tfinc: did you pull and try again? [19:47:48] or awjr_lunch when he's back from lunch [19:47:49] drdee: not iOS [19:47:53] jdlrobson, it OOM'ed [19:48:04] :/ [19:48:11] is there a wiki with release dates of different versions and OS's? [19:48:25] hmm, not that I know of. There should be [19:48:28] tfinc: ^ [19:48:40] jdlrobson: sure. can you replicate it ? [19:48:56] noo I only have android 2.3.3 [19:49:05] jdlrobson, try rebooting it yourself so that you could do it when I'm not around:) [19:49:14] i don't know how MaxSem [19:49:21] i can't ssh into it [19:49:41] but by all means inform me... i'm all for self service [19:49:52] go to labsconsole.wikimedia.org [19:49:56] log out [19:49:59] log in [19:50:14] click on Manage Instances [19:50:26] reboot mobile-enwp [19:51:46] YuviPanda: pm [19:54:08] tfinc: is there a wiki with release dates of different versions and OS's? [19:54:35] (of the mobile app) [19:55:01] drdee: the app project page has the status updates of when they were releaed. if you need something more fine graind we can look those up for you [19:55:12] what is the URL? [19:56:31] http://www.mediawiki.org/wiki/Wikimedia_Apps/status [19:57:45] YuviPanda: new ipa built. i'm stepping into an interivew so le tme know what you would like me to test with this rev [19:58:38] tfinc: same things [19:58:42] scrolling + setion expansion [19:58:44] k [20:00:04] drdee: if you need more specific dates YuviPanda and/or philinje can pull those for you [20:02:00] thx [20:02:40] interview time ... [20:03:01] drdee: what are you hoping to see about release dates? [20:03:05] jdlrobson still need help testing https://bugzilla.wikimedia.org/show_bug.cgi?id=36530 ? [20:03:19] YuviPanda: worse [20:03:30] YuviPanda: scrolling is pretty jerky [20:03:33] please awjr [20:03:36] tfinc: ok [20:03:44] jdlrobson is a fix live on labs or something? [20:03:45] YuviPanda: well actually .. its unpredictabel .. sometimes its ok .. sometimes its bad [20:03:47] just need to reboot labs thanks to MaxSem 's instructions [20:03:55] i shoudl test more before i say anything else [20:03:56] ok [20:04:11] hmmm [20:04:20] tfinc: can you sortof narrow down where it is bad? [20:05:13] YuviPanda: yes. i'm trying to figure that out [20:05:33] doing that while interviewing someone is fun multi tasking :D [20:05:39] phone interview [20:06:04] so MaxSem reboot doesn't seem to do anything [20:06:12] tfinc: heh [20:06:57] ah its back no worries [20:07:54] jdlrobson: i am back from lunch but waiting for Lindsey [20:08:09] k i'm ready when you are.. just going to do some fun debugging with awjr [20:08:40] http://bit.ly/JjAG0p < awjr [20:10:22] jdlrobson, http://mobile-geo.wmflabs.org/w/index.php/Main_Page#_ [20:10:34] jdlrobson it seems a lot better to me [20:11:26] it's been reduced somewhat [20:11:30] it is still crappy though? [20:11:42] yep thanks MaxSem it took a while to reboot :) [20:11:50] jdlrobson i think it's ok, at least in dolphin HD on 2.3.6 [20:12:53] awjr, did you install xhprof on labs? [20:13:04] well hopefully tfinc can also clarify that [20:13:13] i think people just don't like transitions [20:13:18] and am thus tempted to kill them all together [20:14:18] imho transitions cause me nothing but problems on my android devices [20:14:29] maybe we should just kill them then [20:14:35] it's just a case of adding a class to the body tag [20:14:45] we could allow them to be enabled in a future settings page [20:14:55] jdlrobson: so search appears to behave just as quickly in dophin and native browser on 2.3.6, as well as between dolphin, native and chrome beta on ICS [20:15:17] what benefit comes from even having the transitions? eye candy? [20:15:58] yep just eye candy [20:16:18] and a 0.2s delay in the content being visible which I guess is too much for many people [20:16:21] but the new mobile web view is so sexy already [20:16:47] we could use twitter to see what people think.. that's if anyone there is listening [20:17:15] it would be a good thing to test, if we could figure out a good way to do it [20:17:59] jdlrobson: i got responses when i asked about search [20:18:29] awjr: I can stick a bit of code in application.js that will turn it off [20:18:34] (via hash link) [20:18:53] that way we could send out http://wikipedia.org/Article#animation:off [20:18:55] maybe im just dreaming but i think it would be cool if we had a way to objectively a/b test these kinds of things [20:18:58] to allow people to try without [20:19:03] we'd have to figure out why kind of metric to use though [20:19:05] we did the same with references [20:19:16] but maybe just subjective feedback is good enough [20:19:21] awjr: jdlrobson if you guys want to test it just ask philinje [20:19:27] and coordinate some user testing [20:19:27] i think the people that dislike animations will be more vocal though [20:19:46] i think that's the problem with subjective testing/feedback [20:19:49] the people saying they love the new design might love the transitions also [20:21:41] jdrlrobson perhaps some focussed user testing would be instructive? [20:22:04] tfinc: try pulling again? [20:22:06] eek .. http://arstechnica.com/tech-policy/news/2012/05/jury-rules-google-violated-copyright-law-google-moves-for-mistrial.ars [20:23:10] tfinc: 'eek' or 'finally' depends on how the Judge rules - if it is ruled that APIs are not copyrightable, then that's a good thing [20:24:02] i worry about them ruling that they *are* copyrightable [20:24:08] which would be really bad [20:24:11] and dumb [20:25:57] it sounds like it could be a death knell for java if they rule that way [20:28:10] tfinc: were you able to pull and try again? [20:33:48] YuviPanda: nope. this call is taking me full attention righ tnow [20:34:01] it wont run the full hour [20:34:06] i bet i'll be off of it in 15min [20:34:07] ok [20:40:29] jdlrobson, http://stackoverflow.com/questions/10480827/what-is-the-new-appended-to-wikipedias-urls-why [20:40:58] it should be pretty harmless but is unnecessary [20:41:04] i keep meaning to take that out [20:42:00] jdlrobson: almost ready, maybe 10 min? [20:42:09] yep ready when you are philinje [20:42:14] YuviPanda: still needing the start page graphic? [20:42:56] New patchset: L10n-bot; "Localisation updates from http://translatewiki.net." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6840 [20:43:20] philinje: yup [20:47:05] YuviPanda: we are thinking about the globe only, without the word Wikipedia [20:48:00] philinje: without any words what so ever? [20:48:16] philinje: it would be trivial to just put the local word for 'Wikipedia' right under the globe... [20:50:29] New review: Siebrand; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/6840 [20:50:31] Change merged: Siebrand; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6840 [20:52:01] New patchset: Jdlrobson; "only do hash trick when there is a hash" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6868 [20:52:13] jdlrobson: is the minified js in master the latest? [20:52:24] nope awjr if you merge the above i'll do that now :) [20:52:32] awesome [20:53:01] New review: awjrichards; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/6868 [20:53:03] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6868 [20:53:16] jdlrobson ^ [20:54:13] New patchset: Jdlrobson; "minify javascript in preparation for release" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6869 [20:54:27] gerrit is annoying [20:54:37] wish it was easier to filter out messages which have comments and messages which don't [20:56:01] * jdlrobson needs coffee [20:56:25] New review: awjrichards; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/6869 [20:56:27] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6869 [20:58:48] jdlrobson: we are heading to the 6th floor to get a meeting room [20:58:56] ok philinje [20:59:27] YuviPanda: the globe itself has been posted in the bug, do you need it placed in a larger graphic? [21:00:40] YuviPanda: just saw your comment about the word, Wikipedia - is it worth going to that effort for something temporary? [21:01:41] philinje: looking at it now [21:02:20] ok back [21:02:35] hah, I thought that was an animated GIF [21:02:40] YuviPanda: pulling your changes now [21:02:40] turns out to be a slow SVG renderer :) [21:02:57] philinje: just that would be a bit too 'empty' no? [21:03:41] YuviPanda: it'll be there by Sat [21:03:47] possibly earlier [21:04:23] awesome [21:04:27] \o/ [21:04:46] tfinc: definitely beats meeting in berlin :) [21:05:43] YuviPanda: assuming customs doesn't slam you with additional fees [21:05:52] and paperwork [21:06:31] YuviPanda: i think it's ok as a temporary measure [21:06:43] YuviPanda: the flicker is still pretty bad [21:07:16] jdlrobson: MaxSem lolz about the stack overflow question [21:07:22] now were officially internet famous [21:07:23] :D [21:07:30] philinje: hmm, okay. I'll put it in tomorrow and see how things are [21:07:44] tfinc: plus, a random person was actually able to *use* the gerrit interface! [21:07:47] :D [21:07:50] unless that is totally not a random person... [21:07:55] tfinc, now I wonder if I should publish the Gerrit link there [21:08:03] YuviPanda: outside of all these peformance issues. We have to circle back about the arrows in the app. i dont think they good [21:08:08] MaxSem: haha [21:08:18] tfinc: which arrows? section header arrows? [21:08:34] yeah [21:08:48] they're the same ones as the mobile web site [21:08:52] oh i know [21:09:15] but the it looks bizarre with the top and bottom tool bar [21:09:20] we'll worry about that later [21:09:27] i don't want to get into style issues yet [21:09:28] tfinc: file a bug, perhaps? [21:09:31] yes [21:09:45] awjr: what did you find out about caching ? [21:10:02] i'm sure its somewhere in the backscroll ... [21:10:26] tfinc: also, I'm able to repro flicker on the sim, so I should be able to debug that [21:10:32] k [21:10:38] tfinc: do you still have scrolling issues? [21:10:55] tfinc: according binasher, the ttl for mobile pages views should be the same as desktop, and pages should get purged on edit just like from the desktop. i asked asher why there might've been a discrepancy with the cinco de may article instance you mentioned, but i am still waiting to hear back [21:11:16] YuviPanda: i do not [21:11:27] tfinc: ok. Let me try something. [21:11:36] * tfinc worries whenever YuviPanda says that [21:13:26] tfinc: pull? [21:13:46] tfinc: check if the device explodes, producing a portal into the netherworlds where people who love IE6 live? [21:13:49] tfinc: also, scrolling [21:14:00] :) [21:15:52] YuviPanda: worse [21:16:13] sigh [21:16:28] jdlrobson: hacks.css can't have div[style] type selectors either, i'm afraid [21:16:37] jdlrobson: they break iscroll too, not just div[style*='soemthing'] [21:17:08] awjr: its weird because the vandalism on todays FA was cleaned up right away for mobile [21:17:10] right after edit [21:17:20] tfinc: just to confirm, pull now and check scrolling? [21:17:29] sure [21:17:30] tfinc which conforms to what binahser was saying [21:18:06] tfinc do we know of any other instances similar to what happened with 5 de mayo? [21:19:01] smooth [21:19:02] * YuviPanda wonders if the de mayo article was just subjected to repeated vandalism [21:19:30] awjr: i've heard of it happening but haven't been able to find a pattern [21:19:32] thought we were done with it [21:19:43] hmm [21:19:45] till i caught this on twitter over the weekeend [21:19:50] tfinc perhaps it's worth opening an rt ticket? [21:20:17] from what was explained to me, it sounds like the phenomenon should not happen. [21:20:40] i'll cut a BZ bug to us for now [21:20:47] and when we have real details we can push it to RT [21:25:30] and its time like this where i hate how we handle page history [21:25:37] as i can't find the edit at all [21:26:57] yeah, this sounds like something we'll need to get more reports on [21:27:06] and hopefully find a live example [21:28:48] BZ bug open. i'll get it to ops when we have some real debug info. i hate throwing things over the fence if i can't repo them [21:29:48] word [21:31:24] tfinc: jdlrobson https://bugzilla.wikimedia.org/show_bug.cgi?id=36605 [21:32:46] tfinc: can you load http://cubiq.org/dropbox/iscroll/flickering.html in your device and tell me if it flickers? [21:33:00] sure [21:33:21] heads up that i have another interview @ 4:15 [21:33:27] and then climbing after [21:33:29] * tfinc loads url [21:35:26] YuviPanda: no flicker [21:35:33] that's bad [21:35:36] tfinc: this is the same iPhone no? [21:35:58] yes [21:36:06] ok [21:36:46] ? [21:37:09] looks like flickering is not an iScroll issue [21:37:26] but a DOM expansion one [21:40:32] jdlrobson: do comment on https://bugzilla.wikimedia.org/show_bug.cgi?id=36605 when you can. [21:40:58] jdlrobson, MaxSem: today's deployment changes should be live on testwiki [21:41:39] tfinc: i'll head to sleep shortly. jdlrobson has merged in all my pull requests, so I'll be able to release the beta when I wake up. [21:41:46] tfinc: thanks for doing intercontinental debugging :) [21:42:16] YuviPanda: sure thing [21:43:55] awjr: thanks for http://www.mediawiki.org/wiki/Extension:MobileFrontend/Deployments/2012-05-07 ... it helps me stay in the loop [21:44:07] after a couple more iterations of it we can decide how we want to tweak it [21:44:27] tfinc np - this week i wanted to try keeping the change long on its own page - otherwise the main deployment page gets way too cluttered [21:45:28] agreed [21:45:30] woo, the API fixes for the app are going in :) [21:45:39] is anyone else but me finding that page useful ? [21:45:55] i'll take that as a yes from yuvi [21:45:57] tfinc: I just checked it to make sure the API fixes I asked MaxSem to make are beign deployed [21:46:00] yeah [21:46:03] +1 from me [21:46:16] though I don't like the merge commits being there :) [21:46:50] yeah i wonder if it would make more sense to trim out the merge and l10n comits [21:47:12] * YuviPanda heads to sleep [21:47:14] gnite everyone! [21:47:43] i kinda want to write a script to automate that logging [21:47:51] and by kinda i mean really [21:48:00] night YuviPanda [21:53:15] awjr: do it [21:53:26] and/or if you can link to somethign in gerrity that can just show it ... even better [21:54:16] MaxSem: whats on your todo list for right now ? [21:54:41] awjr: after the deployment lets talk about http://www.mediawiki.org/wiki/Mobile_support_in_MediaWiki_core [21:54:53] k [21:54:54] tfinc, redoing some parts of PageIm ages after discussing it today with Phil [21:54:59] im still not seeing any updates on where we are really at [21:55:02] MaxSem: k [21:57:41] http://betanews.com/2012/05/07/the-mobile-web-is-dead/ [21:57:51] "So outside Wikipedia, the mobile web is dead. It's mostly apps now" [21:59:55] wow ... thats a sorry state for the web for the browser to die that fast [22:00:06] anybody else having problems loading test.wikipedia.org? [22:02:15] awjr, me too [22:05:10] its just hanging for me [22:05:48] awjr: did you start the scap ? [22:05:51] 504 Gateway Time-out [22:06:45] -_- [22:08:16] tfinc no [22:08:25] but roan was scapping for pagetriage [22:08:33] discussion going on in #wikimedia-operations [22:11:32] things are getting sorted - PageTriage is running over their window so i'm going to let them finish up before i do anything else for the deployment [22:15:31] awjr: did Roan let you know that he was running over? [22:15:46] tfinc: no, both roan and i collided [22:15:57] he didnt realize we had a deployment window [22:16:09] he didn't realize we have a weekly deployment window that never changes? [22:16:26] and i was reading the deployment schedule for the wrong wek (Apr 30) and thought there was no one else deploying today so i started a little arly [22:16:26] one that he's helped us with many of times [22:16:28] *early [22:16:39] tfinc: correct [22:16:44] * tfinc sighs [22:17:17] tfinc: i wonder if it's worth adding out deployments weekly - we've had problems with people not noticing our 'ongoing' window before [22:17:33] and honestly, i've not noticed other people in the ongoing section before as well [22:18:01] oh, actually, it looks like we are ALSO on this week's schedule [22:18:08] adding out ? [22:18:15] yes. were on both [22:18:16] s/out/our [22:18:21] but now irreleveant :p [22:18:38] in fact robla asks me every week wether we need it ... just to make sure ... and i say yes if we are deploying [22:18:44] so that check is already in palce [22:18:47] place* [22:19:07] so ppl just aren't paying attn [22:19:17] yup [22:19:40] if a deployment is going over the engineer doing that deployment shoudl notify anyone else whos going to be impacted by it [22:19:50] especially if its this tightly scheduled [22:20:05] otherwise we get silly problems like this [22:20:16] but whats done is done [22:20:25] hows their deployment look? [22:22:34] awjr: --^ [22:22:57] tfinc there are ongoing issues [22:23:22] that seem potentially wrapped up with NFS issues [22:24:07] lovely [22:24:21] awjr: whats your cut off for getting the deployment done today? [22:24:26] s/the/out [22:24:28] our* [22:24:38] tfinc: 430 is the latest i can safely do it [22:24:55] starting scap at 430, that is [22:25:05] awjr: let roan know so that he understands our time window [22:25:22] because if he's going to run over we need to scrap and move it tomorrow [22:25:35] kk [22:25:46] looks like they've just about got their issues sorted [22:26:06] woot [22:28:01] ok we're clear now [22:28:24] jdlrobson, MaxSem: are you guys satisfied with your changes on test.wikipedia.org? [22:28:34] yup [22:29:12] yup [22:32:04] ok scap'ing now. [22:38:42] woot [22:43:06] can't tell if this page is intentionally or unintentionally hilarious http://en.wikipedia.org/wiki/Business_process_management [22:43:39] * MaxSem falls asleep [22:47:35] ok sync is done [22:47:43] tfinc MaxSem jdlrobson ^ [22:48:16] l\o/ [22:48:35] awjr: you made maxsem fall asleep on his keyboard :( [22:48:56] hahaha i thought it was the link Rolken shared about business process management... [22:49:36] philinje: just finished synchronizing our changes to the cluster, including the contact us config change to fix the non-en email addresses [22:50:29] right on, thanks [22:50:37] should i file a bug anyway about that? [22:51:52] jdlrobson changes look good in production? [22:52:02] philinje, meh probably not [22:52:14] * jdlrobson looks [22:52:39] awjr: mm i'm still seeing old toggle code [22:52:48] damn it forgot to bump version # [22:52:49] one sec [22:56:48] awjr: the css also looks old.. [22:57:00] jdlrobson should be ok now [22:57:19] nope [22:57:21] still seeing old css [22:57:39] can you show me an example? [22:58:24] well http://bits.wikimedia.org/en.wikipedia.org/load.php?debug=false&lang=en&modules=ext.gadget.teahouse%7Cext.mobileFrontend%2Cwikihiero%7Cext.mobileFrontend.webkit%7Cmediawiki.legacy.commonPrint%2Cshared&only=styles&skin=SkinMobile&* contains margin-left:-22px; margin-right:-22px; [22:58:27] which shouldn't be there [22:59:02] hmm css is getting loaded by resource loader now, right? [22:59:18] yup [22:59:33] i also seem to still be getting the old js [22:59:46] you can tell as the new js doesn't turn the hash to #_ on startup [23:00:17] it does for me [23:00:31] as in you don't get the hash? [23:00:37] as in i do get the has [23:00:37] h [23:00:40] then you have old js [23:00:56] hmm well the js is getting loaded with the new version #: http://bits.wikimedia.org/static-1.20wmf2/extensions/MobileFrontend/javascripts/application.min.js?version=1336431194 [23:01:22] jdlrobson is it possible an old js file was minified? [23:01:44] nope [23:01:47] in dev version look for if(window.location.hash){window.location.hash="#_"} [23:01:54] it matches [23:01:56] in http://bits.wikimedia.org/static-1.20wmf2/extensions/MobileFrontend/javascripts/toggle.min.js?version=1335223911 it doesn't [23:02:20] jdorbson that link definitely points to an old JS file [23:02:27] http://bits.wikimedia.org/static-1.20wmf2/extensions/MobileFrontend/javascripts/toggle.min.js?version=1336431194 [23:02:45] but im also not seeing it in there [23:02:47] :/ [23:02:55] guys i have an impromptu 5pm meeting that i need to suddenly prep for. if you need me for anything send me a mail and i'll take a look after [23:03:50] k [23:04:29] jdlrobson i wonder if this is a by-product of our deployment collision with pagetriage [23:04:31] give me a second [23:04:34] mm [23:05:32] omg [23:05:34] i see the problem [23:05:43] what? [23:06:02] it's not a big deal but i forgot that roan had chagned how getting stuff into the deployment branch works [23:06:29] it used to be that you could just 'git push' stuff into the deployment branch, but now you have to put your deployment changes through the same review process [23:06:39] so, long story short, the changes didnt get merged to deployment [23:07:36] :-o [23:07:38] any of them? [23:07:41] no [23:07:44] eek [23:07:46] yeah [23:07:52] too late to re-do it? [23:07:59] nope im doing it now one sec [23:08:10] lol [23:08:20] no wonder testing test was so non-problematic ;-) [23:08:31] hahaha yea.... [23:09:07] ok almost there [23:09:39] awjr: were the docs updated to reflect that? [23:11:58] tfinc looks like they were but in the spot i didn't read because i thought i knew what i was doing. roan sent out an email about it right after the last time i deployed (2 weeks), it slipped my mind. [23:12:08] jdlrobson things are up on testwiki now [23:14:03] jdlrobson look better? [23:15:02] 500 [23:15:20] 500x better or you're getting a 500 error? [23:16:00] 500 error on my android [23:16:08] varnish error [23:16:13] guru meditation [23:16:23] yeah you still can't test test.wikipedia.org on a mobile device. [23:16:25] i'm still seeing old javascript on test though.. [23:16:32] awjr: that sentence is funny :) [23:16:38] heheh [23:16:41] it's absurd [23:16:44] yup [23:16:52] jdlrobson i am getting new JS, i think - the hash is not appearing on init [23:17:05] ok yeh force refresh sorted it [23:17:20] the css looks new [23:17:23] cool good [23:17:25] i cant verify though without testing on my android [23:17:33] :-/ [23:17:43] live testing ftw [23:18:01] jdlrobson: confident enough for me to push to production? [23:18:48] yup [23:19:00] k [23:19:38] yey its raining again - wonderful weather of england [23:20:22] 90F and sunny here [23:20:39] not to rub it in, or anything [23:20:58] errgg i believe opera mini search is still broken - finally found a way to replicate :( [23:21:50] any chance of a second deployment this week? [23:22:45] jdlrobson if it's something urgent [23:22:58] it's reasonably since opera mini gets a lot of use [23:23:52] i don't see why not [23:24:33] cool - i'll try and get a fix out tomorrow [23:24:56] * jdlrobson just realises he has opera 4 on his old nokia n95 [23:26:11] * jdlrobson realises it doesn't work any more [23:26:21] :( [23:29:19] sync is almost doneā€¦.... [23:33:10] awjr: deployment is happening? i'm seeing weirdness [23:33:25] jdlrobson sync is still going, should be almost done [23:33:39] http://en.m.wikipedia.org/wiki/Roma_Party#_ search overlaps icon [23:33:41] very bizzare [23:34:02] let's check again when sync is done [23:34:20] yup [23:36:34] i lied, this is taking forever. [23:49:11] :( [23:50:29] fixed opera mini [23:50:29] New patchset: Jdlrobson; "don't use timeout method on opera mini" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6892 [23:50:30] New patchset: Jdlrobson; "use cached u variable instead of MobileFrontend.utils" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6893 [23:50:32] shame so late in day [23:52:08] ok jdlrobson, done [23:52:23] * jdlrobson checks [23:52:43] don't suppose there is any easy way to fold the above change in? [23:53:36] works for me awjr [23:53:43] jdlrobson i cant right now [23:53:54] but we can schedule something for tomorrow or weds [23:54:00] that would be great [23:54:50] updated bug awjr https://bugzilla.wikimedia.org/show_bug.cgi?id=36532 [23:56:24] things are looking fine to me under ICS [23:58:01] \o/