[00:01:51] i think we should indeed get rid of the toggle transitions. not having them on ICS is actually really nice - it's just cleaner and faster. on 2.3.6 they work fine, but the toggle transition is just a smidge slow and choppy - and it seems like the text doesn't fully render until the transition is done, making it seem even more choppy [00:01:59] i agree [00:06:43] jdlrobson will you be around during PST hours at all tomrorow? [00:06:52] probably not.. [00:07:08] i've noticed sometimes you overlap in the morning [00:07:11] what about weds? [00:07:21] i'd rather push the opera fix when you're around [00:07:42] well tomorrow.. im out in the evening [00:07:42] b [00:07:46] but i can be back this sort of time [00:07:51] for about an hour [00:08:13] could you do a bit earlier, like 3pm pst? [00:08:51] * jdlrobson does timezone math [00:08:52] New patchset: Jdlrobson; "turn off transitions by default" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6895 [00:08:57] oh wait that's no good for me [00:09:05] wtf [00:09:11] wtf? [00:09:14] tfinc: is our 1:1 at 330 tomorrow? [00:09:18] just scheduling confusion :) [00:09:31] ok [00:10:10] awjr: I can be here anywhere between 11pm BST and 1.30am BST - that's 3pm PST - 5.30 [00:10:18] we can push the above as well [00:10:38] ok - jdlrobson, let's shoot for 3-4pm PST (11pm - 12am BST) and i'll clear up my scheduling with tomasz when he's free [00:10:44] k np [00:10:48] if that needs to change i'll shoot you an email tonight. [00:10:51] i'm going to catch some z's now [00:10:56] cool sleep well! [00:30:00] New review: awjrichards; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/6895 [00:30:04] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6895 [00:32:24] New review: awjrichards; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/6892 [00:32:26] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6892 [00:32:47] New review: awjrichards; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/6893 [00:32:49] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6893 [00:55:50] awjr: i'm still in the meeting but move it to whatever works [01:23:24] tfinc: ok i moved the meeting to 5pm tomorrow so i can work with jon to get the opera bug fixes out. also, i added status updates to http://www.mediawiki.org/wiki/Mobile_support_in_MediaWiki_core/status - not sure if that's quite what you were looking for, but i wasn't really sure how else to show progress since most things that have happened so far have been very preliminary and not apparently for end-users. [02:02:59] still some folks around? [02:04:35] preilly? [02:06:09] awjr? [02:06:19] a bit [02:06:20] what's up? [02:06:40] you guys use jquery for search on mobile, right? [02:07:03] i think on devices that support jquery [02:07:15] so iphone/ android [02:07:26] do you know if you have something similar in your code base: [02:07:27] $.ajaxSetup({ scriptCharset: "utf-8" , contentType: "application/json; charset=utf-8"}); [02:08:12] not off the top of my head, but you should feel free to take a look - you can check the MobileFrontned code out from our git repository [02:08:20] most important aspect is the contentType [02:08:30] okay, what file(s) are most suspect? [02:08:42] wait i can grep it [02:08:46] nevermind [02:08:53] just clone it from github? [02:10:01] you can find details here: http://www.mediawiki.org/wiki/Extension:MobileFrontend [02:10:08] thx [02:10:12] np [08:19:27] New patchset: Jdlrobson; "revert bad rule introduced in dbaa7218" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6915 [09:22:36] jdlrobson, how do you like those usertesting videos? :) [09:22:46] yeh they are brilliant [09:22:49] just watching them no [09:33:54] https://gerrit.wikimedia.org/r/6915 is big problem [09:34:01] noticed lots of people commenting about it on twitter :( [09:45:50] sigh, why doesn't everyone have a 4-inch displays and fastt WiFi? [09:46:31] sections collapsed a minute after page seemed to have loaded just killed me [09:47:50] * MaxSem goes to try it on mom's S60 [09:53:51] sigh [09:55:39] MaxSem: > https://bugzilla.wikimedia.org/show_bug.cgi?id=36633 [10:05:15] * jdlrobson goes to run errands [10:43:35] MaxSem: the table issue is really worrying me [10:43:53] is there any way we can fix it in production before this evening [10:44:30] let's ask in #wikimedia-dev [10:45:11] New review: MaxSem; "(no comment)" [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/6915 [10:46:39] now that we're 100% on Git, we should get back to giving ne a deployment banhammer [10:48:10] can't believe this one slipped through the test net [10:49:04] we direly need QA [10:49:16] why does http://bits.wikimedia.org/zh.wikipedia.org/load.php?debug=true&lang=zh&modules=site&only=styles&skin=SkinMobile&* load Vector's css? [10:49:31] I mean MediaWiki:Vector.css [10:51:14] liangent, because Mobile isn't 100% registered, so on this request system assumes default skin [10:51:21] * MaxSem goes to bz [10:55:50] liangent, i've submitted the bug, might poke at it later [10:56:16] MaxSem: maybe someone in another room might be able to help? is there a list of people who are able to deploy on a wiki somewhere? [10:56:36] http://meta.wikimedia.org/wiki/System_administrators [10:56:44] #wikimedia-tech and #wikimedia-operations [10:56:56] not sure that's updated [10:56:57] but they should all be in -dev already [10:57:44] Katie_WMDE, it's dreadfully outdated [10:57:49] yeah [10:58:42] * Katie_WMDE imagines Jimbo doing sysadmin stuff [10:59:32] he used to do that 10 years ago, so why not? [11:04:50] demon is around [11:07:13] could mail him? [11:07:32] yea [11:07:33] s [11:22:49] * jdlrobson has a laptop battery that's about to die [11:35:26] no choice i think but wait for SF people [11:59:20] New review: Dzahn; "per demon and Katie. just remove "display: none;" from table CSS to fix mobile site layout." [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/6915 [11:59:22] Change merged: Dzahn; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6915 [12:05:42] hi all [12:06:06] Katie_WMDE: anything us non-SF folks could help with? [12:06:08] mutante: heya [12:06:09] demon just told us (ops) about mobile site breakage [12:06:19] YuviPanda: yeah, make sure the fix is good [12:06:22] he couldnt merge the fix, is in final exam or something [12:06:28] so i merged that just now [12:06:34] * Katie_WMDE does not want to be responsible for breaking things [12:06:37] okay, I just came on so I've no idea what you guys are talking about [12:06:43] but i don't know about the deployment part now, after merging it in gerrit [12:06:51] MaxSem ^ [12:06:58] * YuviPanda goes to check logs [12:07:07] YuviPanda: https://gerrit.wikimedia.org/r/#/c/6915/ [12:07:14] there was "display: none" in CSS on table [12:07:18] now it is removed again [12:07:33] it said that was a clear mistake that it was ever in there [12:08:04] Katie_WMDE just showed us this example: http://en.m.wikipedia.org/wiki/Motorola_6847 [12:10:27] ah, right. [12:10:43] https://bugzilla.wikimedia.org/show_bug.cgi?id=36627 [12:11:03] <-- looks like this is not actually resolved [12:34:41] mutante, the only thing I know is http://wikitech.wikimedia.org/view/How_to_deploy_code [12:42:34] MaxSem: yeah..hm,,,bugzilla says a deployment is planned for today anyways, i would leave it at that [12:43:11] that made somebody call the ticket resolved already, well reopened it, i don't know when today though [12:43:49] heh, if you haven't delpoyed code before, now it's probably not quite an emergency for a crash course:P [12:43:56] so, it's patrick and arthur who do it? [12:44:06] i am guessing just a couple hours more [12:44:19] dont expect them to do it late in the afternoon in US time zone [12:45:03] * Katie_WMDE reads http://www.mediawiki.org/wiki/Extension:MobileFrontend/Deployments [12:45:14] MaxSem: no i haven't. i just happened to be in this because demon asked us to answer questions as he wasnt able to get to a keyboard / on the server right now [12:46:32] ^demon will be back in a few hours also [12:46:49] yeah. pretty sure he will be back asap [12:48:26] Katie_WMDE: or Roan [12:48:37] yes [13:11:12] jdlrobson: one look at https://github.com/yuvipanda/WikipediaMobile/commit/97e4116af30b86607ccf48738e16781796f4d19c for CR? [13:11:15] single commit only [13:11:32] sure [13:12:13] what a wonderful thing credit card fraud is [13:12:14] xhr is just a string ? [13:12:14] sigh [13:12:20] you've had credit card fraud ? [13:12:33] jdlrobson: it seems to be just a string when there is no network [13:12:43] jdlrobson: and an xhr object when there is 'other' error [13:12:47] jdlrobson: yup [13:12:53] jdlrobson: on my GSoC 2011 card, none the less [13:13:02] about 350$ of telephone usage in Mexico [13:13:14] so I now need to get a new card shipped to Google HQ and have them ship it to me [13:14:12] :( [13:14:17] ahh man [13:14:31] ok yuvipanda [13:14:37] CR = looks good [13:14:52] so about 30 mins spent on the phone with Citi today - at least it was free via skype. International calling would've killed me [13:15:00] jdlrobson: cool, I'll just go ahead and merge that pull req then :) [13:15:38] jdlrobson: done. Thanks :) [13:15:44] YuviPanda: thanks [13:15:46] [WikipediaMobile] yuvipanda pushed 5 new commits to master: http://git.io/hZ2DFg [13:15:46] [WikipediaMobile/master] Show error page when retrieving page data - YuviPanda [13:15:46] [WikipediaMobile/master] Handle network failures during searching properly - YuviPanda [13:15:46] [WikipediaMobile/master] Removed extranous console.logs - YuviPanda [13:15:55] jdlrobson: I guess table: none explains why you weren't seeing infoboxes in the app yesterday :) [13:16:01] yehh [13:16:06] i'm kicking myself for not making the connection [13:16:10] horrible horrible horrible [13:16:48] a fairy inside me dies everytime someone tweets something along the lines of why is wikipedia not showing me pictures [13:16:54] hoping someone can deploy the fix soon [13:16:56] soon enough [13:17:05] in a way it was useful [13:17:13] as it made the user testing less easy [13:17:21] and we got some useful information from it [13:17:28] (usually people find the answers in the info box) [13:17:32] YuviPanda, did you use your card online often? [13:18:51] YuviPanda: you might like localphone.com [13:19:13] MaxSem: for a year [13:19:16] MaxSem: and locally too [13:19:31] MaxSem: a day before the fraud happened, I used it to pay for my servers at prgmr [13:20:22] mutante: I wasn't using it for telephony services. I looked into my card today and found it had only $17 in it, rather than the ~$300 I expected [13:20:30] mutante: (This is a Google Summer of Code prepaid card) [13:20:49] YuviPanda: we should start getting some tests into the app after this next release - lack of tests is killing us imo [13:22:26] jdlrobson: qunits? [13:22:32] yup [13:23:11] jdlrobson: agreed. [13:23:47] jdlrobson: Unsure how to go about it though - I'll be jumping into WLM app right after this. [13:24:02] YuviPanda: just saying when i saw you saying "international calls would've killed". it gives you a local "alias" number for an international number you can call from phone without a laptop. saved me when i had to call airline in foreign country to get a ticket rebooked [13:24:14] At least that one I can start from ground up with tests + proper jslinting. [13:24:18] mutante: aaah, thanks! [13:24:58] YuviPanda: they have different products, but this is "local numbers" .. see the 1 2 3 on http://www.localphone.com/services/local_numbers [13:25:13] mutante: yup, was looking at it [13:25:20] rates lower than skype..ack [13:25:27] mutante: I'll use this next time I need to make a call that is not toll free [13:25:34] mutante: citi's number was, thankfully, toll free :) [13:27:04] yea, i had this ticket from Malaysia airlines and their number was toll free from "within Malaysia" but i was never in the country, they were just my airline [13:27:11] haha [13:27:23] I guess this might come in useful for German/EU things now [13:27:28] mutante: thanks! :) [13:27:46] yes, i thought so. but gotta check which country combinations work [13:29:37] New patchset: Jdlrobson; "add support for browsers based on ie8" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6924 [13:29:38] New patchset: Jdlrobson; "clearly define variables" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6925 [13:40:29] hi YuviPanda, do you know whether you guys have something like this [13:40:30] $.ajaxSetup({ scriptCharset: "utf-8" , contentType: "application/json; charset=utf-8"}); [13:40:46] in the frontend when doing an api / open search call? [13:42:23] i did a quick grep but couldn't find it myself [13:42:57] the reason i am asking is that it I am finding "application/json; charset=utf-8" in the server logs and that extra space is causing a lot of headache [13:43:04] New patchset: Jdlrobson; "move padding from absolute to relative element (bug 36618)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6926 [13:43:05] New patchset: Jdlrobson; "hide back links in reference overlay" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6927 [13:43:12] YuviPanda: > https://gerrit.wikimedia.org/r/6927 [13:43:12] drdee_: IIRC no, we don't [13:43:45] jdlrobson: thanks :) [13:44:04] YuviPanda: I wonder what piece of code is responsible for doing this [13:44:09] drdee_: perhaps webkit is doing that by default? [13:44:35] drdee_: search.js in the app, beta_opensearch.js on MF [13:44:38] jdlrobson: ^ [13:46:26] drdee: able to share a dump of the logs? [13:47:10] we don't use ajaxSetup anywhere in MobileFrontend extension [13:48:00] it's not about ajaxSetup, it's about setting the contentType to application/json; charset=utf-8 [13:48:24] I don't think we access json anywhere in the MobileFrontend extension [13:48:26] maybe jQuery does that by default? [13:48:33] * jdlrobson googles [13:48:33] that's also possible [13:48:44] jdlrobson: the opensearch API call is not json? [13:48:53] nope.. using xml at moment [13:49:03] but it also happens to text/xml [13:49:07] has the same problem [13:49:13] jquery ajax default ajax call is Default: 'application/x-www-form-urlencoded' [13:51:26] it doesn't seem to me that the nginx / varnish servers modify this, it seems to come from the frontend, or not? [13:54:14] I'm not sure what could be causing this [13:56:25] who might know more about this? [13:59:14] hi jdlrobson [13:59:20] hi Katie_WMDE [13:59:35] drdee_: maybe MaxSem ? [13:59:37] ^demon can help with deploying if it's urgent enough [13:59:47] there's a deploy this afternoon SF time i understand [14:00:09] <^demon> I love being volunteered for things ;-) [14:00:24] well basically ^demon the mobile site is not showing **any** tables [14:00:37] <^demon> Yeah I gathered that much. [14:00:38] thanks jdlrobson! i'll ask MaxSem (is he PDT?) [14:00:54] MaxSem should be around now [14:01:14] drdee_, are talking about request or response headers? [14:01:25] ^demon: have you ever done a MobileFrontend deployment? [14:01:57] request headers because it shows up in the server log [14:01:59] jdlrobson, it shouldn't be any different from any other deployments [14:02:20] <^demon> jdlrobson: Unless there's something magic and different from a normal extension's deployment, I've done my share :) [14:02:38] drdee_, I'm a backend guy [14:02:38] well it should be just a case of applying the patch to the css [14:02:54] and then refreshing the caches [14:03:18] no refresh needed, it's RL [14:03:20] the patch is just the removal of a line > https://gerrit.wikimedia.org/r/#/c/6915/ [14:03:27] ok well then it's just applying that patch then :) [14:03:41] * MaxSem looks at backscroll [14:03:52] * Katie_WMDE wonders how it got broken [14:04:10] Katie_WMDE: how tables disappeared? [14:04:21] <^demon> Checking out 1.20wmf2 so I can update it. [14:04:22] yeah [14:04:32] that would be me.. :-/ i was doing some debugging and some how committed that line - it was a big diff and i must have missed it [14:04:37] no cookies for me this week [14:04:52] what kind of testing is there for MF? [14:04:56] (although to be fair wasn't noticed in code review :)) [14:05:11] just unit tests at the moment [14:05:13] MaxSem: as a backend guy, why do a lot of the mobile server requests have as mime type a charset append to it? like "application/json; charset=utf8" for example [14:05:16] i'm not sure how best to catch css stuff like this [14:05:29] yeh me neither -selenium would cover it somehow - but we'd need real content [14:05:29] * Katie_WMDE is learnign testing for wikidata [14:05:49] ie. test: go to this page check table visible [14:05:56] yeah [14:06:44] drdee_, at a first glance, MobileFrontend's JS doesn't set any content headers (tested with Firebug) [14:06:54] i'm hoping when I move to the SF office I'll be able to grab someone and get something setup - e.g. a dev labs instance running selenium tests [14:07:09] MaxSem: yeh that's what I thought [14:07:15] drdee_: could it be coming from a 3rd party app? [14:07:18] * MaxSem wonders if squids, varnishes of other insane stuff we use add one [14:07:43] jdlrobson: no it's coming from WikipediaMobile [14:07:54] that sounds like the app [14:07:57] drdee_, do you have an example request logged, or there's no complete information? [14:08:06] got plenty of examples [14:08:26] indeed it does [14:08:31] * drdee_ preparing anonymized examples [14:08:48] drdee_: thanks [14:09:44] ^demon: let me know if you need any help [14:10:33] <^demon> Can you do a sanity check on gerrit changes 6928 and 6929 for me before I merge? [14:15:20] <^demon> jdlrobson: ^? [14:15:29] sure thing [14:16:28] [WikipediaMobile] yuvipanda pushed 3 new commits to master: http://git.io/EtXbSw [14:16:28] [WikipediaMobile/master] Updated to latest MobileFrontend - YuviPanda [14:16:28] [WikipediaMobile/master] Removed hacks.css temperoarily - YuviPanda [14:16:28] [WikipediaMobile/master] Updated CHANGELOG and version numbers - YuviPanda [14:16:46] looks ok to me - MaxSem can you triple check ? ^ [14:17:12] <^demon> Jenkins is claiming merge conflict. Wonder if I missed something. [14:18:12] jdlrobson, MaxSem: check pastebin.com/W2ggQD8g (first 2 hits have charset set, third one not) [14:18:24] ^demon, LGTM [14:18:40] <^demon> Hmm, I think jenkins is just being stupid. [14:19:43] ^demon, if you're updating to head you'll need to increment $wgMobileResourceVersion like in old good times:) [14:20:06] <^demon> Hmm. It seems to be stuck in merge pending. [14:20:48] iPhone app 3.1.... [14:21:19] * ^demon whacks gerrit with a 2x4 [14:25:35] hmm, that is from the iPhone app [14:26:09] there is no code that explicitly sets that, however [14:26:17] drdee_ YuviPanda what version of jquery was that using? [14:26:38] drdee_: 1.7.1 [14:26:39] <^demon> jdlrobson: Well, nobody's deploying this revision. Something's up with gerrit. [14:26:52] ^demon: :( [14:27:12] jdlrobson: ^ [14:27:35] thanks for trying ^demon.. i guess it will have to wait till later today [14:27:47] <^demon> I'm asking #gerrit for support ;-) [14:28:33] YuviPanda: so it this new behaviour with query 1.7.1? [14:29:16] drdee_: it is possible. I'm unsure. [14:29:22] drdee_: I can check in a bit. [14:29:33] no idea drdee_ .. but looks like jQuery might be doing something to do that ... either way.. if people don't upgrade their app that's going to continue regardless of what we do [14:29:50] * YuviPanda greps through http://code.jquery.com/jquery-1.7.1.js [14:30:48] I see nothing unusual [14:31:29] f ( s.data && s.hasContent && s.contentType !== false || options.contentType ) { [14:31:30] maybe? [14:31:50] oh no that's to do with ajaxSetup [14:32:13] I don't see contentType being set anywhere other than the default [14:32:35] and no mention of the string 'utf' at all [14:33:10] so weird [14:34:16] yeah, we seem to be using that phrase very often in this channel [14:34:16] sigh [14:34:21] from the examples, it only happens with http traffic and not https traffic [14:34:46] drdee_: http traffic is *only* from the app on iOS 4.2, and nowhere else [14:34:49] (if that helps [14:34:51] ) [14:36:34] so is this caused by iOS 4.2 (because if you look at the pastebin then you see it 2 GET requests, one API and one regular article and they both have charset appended [14:38:36] drdee_: possible [14:39:14] drdee_: I don't have access to a 4.2 device or sim now, so can't test that with wireshark :( [14:40:15] Thehelpfulone: new beta! http://dumps.wikimedia.org/iOS/Wikipedia-v3.2-beta2.ipa [14:40:19] i'll be mailing it out shortly [14:40:54] ok :) [14:41:00] I can try it on 5.1.1 [14:41:12] Thehelpfulone: wonderful :) [14:41:29] Thehelpfulone: testing saved pages + scrolling would be awesome :) [14:41:35] ok [14:41:41] i'm going to grab dinner, brb [14:43:23] nah, it also happens on Android [14:44:28] * jdlrobson must go - doctors appointment - be back soon [14:58:08] hi guys! [14:58:25] i'm working with diederik to figure out why mobile requests are including the charset in the content type field of access logs [14:58:44] wanted to ask you some Qs about how you guys develop [14:58:45] hey ottomata [14:58:55] particularly about how code locally and test [14:59:00] hiya Yuvi! [14:59:08] ottomata: MobileFrontend (web) or the apps? [14:59:08] do you have a standard setup you all use? [14:59:12] ummmm [14:59:16] i think web [14:59:21] or either maybe? [14:59:22] MaxSem: ^ [14:59:35] do you guys make up your own apache and whatever else configs locally? [14:59:43] ottomata: Extension:MobileFrontend is pretty easy to setup, and IIRC you can use useformat=mobile locally to test [14:59:44] or is there some standardization that puts your configs closer to what might be in prod? [14:59:45] yes [14:59:59] ottomata, what do you want to test? [15:00:13] i want to find out why the content-type header looks like this in the logs [15:00:19] Content-Type: text/html; charset=UTF-8 [15:00:27] and i'm wondering [15:00:36] if you guys use the same apache configs [15:00:38] that production uses [15:00:40] while you develop [15:00:47] * MaxSem doesn't [15:00:48] if so, then I can look at that and we can test locally [15:01:01] * YuviPanda doesn't either [15:01:05] ha [15:01:12] so you make up your own setup, right? [15:01:16] install apache, [15:01:18] modify sites [15:01:19] etc. [15:01:20] ? [15:01:31] ottomata, production has extremely tricky setup [15:01:42] including a Squid extension [15:01:55] so nobody has this setup exactly [15:02:04] yeah, wouldn't need exact setup, but a version that was close to prod would be good, no? [15:02:12] including all the proxies/caches [15:02:21] anyyyway, ok, i got my answer :) [15:02:26] will go bug ops now [15:02:31] thank youuuuuuuuuuu! [15:09:19] Thehelpfulone: able to test? [15:09:47] yep just grabbing that cable to download and sync [15:10:08] awesome [15:15:18] MaxSem: so, action=mobileview on image pages shows all the image info and license info [15:15:23] but doesn't seem to be showing the actual image [15:15:41] MaxSem: just checked with File:BradPittBAR08.jpg on en.wikipedia.org [15:16:25] was it needed? [15:16:47] sigh, working without specs has its own cons [15:17:05] I just assumed that it was obviously needed. Sorry :| [15:17:17] butt... what use would a image info page be without the image?! [15:18:01] btw, I asked you to look at it last week;) [15:18:10] I could try to smuggle it into today's deployment [15:18:17] I looked at the html, it seemed fine :P [15:18:21] I didn't look hard enough. [15:18:39] but what width should the image have? [15:19:47] MaxSem: hmmm, I guess is just the default image... [15:19:57] default image size thumbnai, I mean [15:19:59] wassdat? [15:20:20] which is 180-220 pixels... [15:20:28] paste fail [15:20:29] i meant [15:20:37] http://en.wikipedia.org/wiki/File:BradPittBAR08.jpg and http://en.m.wikipedia.org/wiki/File:BradPittBAR08.jpg [15:21:11] this one is too small itself [15:21:15] how about http://en.wikipedia.org/wiki/File:Nikolic_Tomislav.jpeg [15:21:31] it's huge for mobil3e screens and bandwidths [15:22:27] hmm current mobile site doesn't do anything special either [15:22:50] MaxSem: I suppose for a start we just push out the default, and then open a thread on the mailing list about how to handle this? [15:22:56] MaxSem: I'd suppose it would have to be different per image [15:23:08] should it be an app setting? [15:23:45] MaxSem: about? [15:23:50] image size [15:23:51] size of images to display/ [15:23:51] ? [15:23:53] doubt it [15:24:35] It's either per-image, or perhaps we request for different sizes based on the screen's size [15:24:45] sigh, moar copypasta from core [15:25:11] can't refactor? [15:25:17] ah, backwards compat cabal? [15:27:31] cat CHANGELOG [15:27:33] grr [15:37:33] time to transport self elsewhere [15:37:35] brb [15:40:01] YuviPanda: I'd added one item to my saved page list [15:40:07] I click on the X in the top right [15:40:11] it opens the confirmation up twice [16:03:52] ^demon: any luck with gerrit? [16:04:01] <^demon> Nope. [16:04:10] :( [16:05:11] gerrit is so gerrit [16:06:13] srikanthlogic: are you able to replicate https://bugzilla.wikimedia.org/show_bug.cgi?id=36407 ? [16:06:34] * srikanthlogic checks [16:06:36] hmm, no aharoni [16:06:39] * YuviPanda checks #mediawiki [16:11:19] jdlrobson: while I do that, another feedback [16:12:06] It might just be my phone, but when I clicked section expand on today FA, it took a long time, when I expanded second section I got a memory full error [16:13:09] jdlrobson: and latest Opera Mobile is 12, 9.8 was around a year back IIRC [16:13:31] jdlrobson: on a shorter article, I cant reproduce it [16:14:38] :/ [16:15:53] jdlrobson: suggest you deliver old skin for old phones :) [16:16:40] S60 / S40 will have trouble loading big pages with js on their small memory [16:19:48] yeh... we need dynamic sections [16:20:20] YuviPanda: Android should have a "Share to Bugzilla" option in the camera. [16:20:34] Instant screenshots of bugs! [16:20:37] hehe, maybe I should build that :D [16:21:43] * YuviPanda is tempted to go look up the BZ API for uploads [16:21:54] actually every app should have such feature [16:22:09] srikanthlogic: with Android, such features need not be in the app [16:22:20] srikanthlogic: I just need to build a bugzilla app that exposes this to other apps [16:23:42] YuviPanda: ah yes, even in S60 for that matter. I wish I had gravity supporting bugzilla along with twitpic, yfrog, etc :P [16:25:08] New patchset: MaxSem; "Turns out image pages need to actually display images:)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6934 [16:25:14] YuviPanda, ^^ [16:27:09] MaxSem: :D [16:28:11] * MaxSem has cut his finger [16:28:23] 50% off typing speed [16:28:35] MaxSem: which one? [16:29:13] one of them:P [16:29:30] :) [16:31:34] MaxSem: I wish we had time to implement http://www.mediawiki.org/wiki/MobileFrontend/Dynamic_Sections - I'm sure it would solve a lot of the page loading problems! [16:32:51] jdlrobson: hi [16:32:57] jdlrobson: once 1.2 is out and I move to WLM, I hope to spend some off time moving the app to dynamic sections. [16:33:19] WLM :) [16:33:21] hey philinje [16:33:32] philinje: are you in the office? [16:33:39] yes, is now good? [16:33:42] YuviPanda, and geonames --> geodata? [16:33:53] first is anyone in the office who can help deploy a fix to production [16:34:04] there is quite a big bug on the site - in that no tables are visible [16:34:18] ^demon has been trying but having issues with gerrit [16:34:21] ah, not on our team, maybe Ops? [16:34:55] if ^demon couldn't beat gerrit into submission - i'm afraid we're doomed [16:35:08] <^demon> I'm thinking of resubmitting. #gerrit's not being helpful today [16:35:18] <^demon> I was going to ask Roan but he doesn't seem to have logged on yet. [16:35:22] i am in a meeting room across the floor, but let me go over there [16:35:24] can we just do a new patch? [16:35:28] and reject that change [16:35:46] <^demon> Patch to master is fine, patch to branches got stuck between submission and merging. [16:36:21] log into that box and merge manually?:P [16:36:36] edit the files in production live? [16:36:48] :D [16:36:57] <^demon> Live hacks suck and I'd expect to be tar & feathered :) [16:37:05] :o [16:37:12] ou won't be if you went for lunch right afterwards :P [16:37:15] *you [16:37:25] <^demon> Deploying then leaving is just as bad ;-) [16:37:28] plus forget a semicolon before saving [16:37:50] ...and not in JS! [16:37:52] hey, i hear you guys need a push ? [16:38:13] YuviPanda: ? [16:38:32] LeslieCarr: MaxSem ^demon and jdlrobson are poking at it. Gerrit troubles, I believe [16:38:50] <^demon> LeslieCarr: I've got it. Gerrit's being retarded. [16:38:56] okay :) [16:39:25] jdlrobson: do you want to have the call now, or later? [16:39:49] i don't have any time later philinje - i'm suppose to be coming back at 11pm but that's to help awjr with another deployment [16:43:23] aharoni: also, would be glad if you could test Saved pages across language [16:43:26] *s [16:43:36] ok [16:52:07] MaxSem: Hi. Can you review this please? - https://gerrit.wikimedia.org/r/#/c/6071/ [16:52:39] done [16:53:15] MaxSem++ thanks. [16:53:26] jdlrobson what's up [16:53:40] i broke wikipedia wm-bot [16:53:42] awjr: [16:53:47] (not wm-bot ) [16:53:57] still broken? [16:54:15] jdlrobson is this what you're referring to? https://bugzilla.wikimedia.org/show_bug.cgi?id=36627 [16:54:16] no tables showing [16:54:21] oops [16:54:26] exctly [16:54:42] just needs to be deployed.. has been fixed since 9am-ish [16:54:52] but haven't been able to get it live :( [16:55:03] * Katie_WMDE stabs gerrit [16:55:26] awjr, in other good news, gerrit is screwed up and doesn't merge into wmf branches [16:55:32] jdlrobson ok im taking a look [16:55:34] MaxSem [16:55:35] oh [16:55:43] that might make getting this out rather tricky [16:56:08] MaxSem what's the problem with gerrit and is someone fixing it? [16:56:20] i need to run off soon as well [16:56:27] but will be back at 11pm BST [16:56:29] the problem is http://p.defau.lt/?a58233Vhyf5XY941dpOgxw [16:56:37] and chad's on it [16:57:10] oops [16:57:31] ok, jdlrobson i assume i won't be able to do anything until gerrit is fixed [16:57:44] :-( [16:57:48] jdlrobson i'll try to get your fix out though asap [16:57:50] greetings all [16:57:52] ok thanks [16:58:00] jdlrobson can you show me a sample article suffering from the problem? [16:58:04] what'sup tfinc [16:58:13] awjr: there are many [16:58:15] awjr: how are we looking post deployment ? [16:58:15] oh nm [16:58:17] anything with a track listing for example [16:58:21] i see there's one in the bug [16:58:22] yeah [16:58:35] no cookies for me this week tfinc :( [16:58:39] tfinc: there's a small issue with tables not being displayed [16:58:43] https://bugzilla.wikimedia.org/show_bug.cgi?id=36627 [16:58:53] jdlrobson: did you break things ? [16:58:59] "small" [16:59:12] tfinc: jdlrobson has it fixed and i'd like to just get it deployed but apparently there's a problem with gerrit [16:59:25] isn't gerrit itself the problem ;) [16:59:27] 'small' indeed [16:59:30] which i've gathered needs to first be resolved before i can get the fix into the deployment branch [16:59:41] whats the gerrit issue and who's working on it ? [17:01:32] was the table issue the big bug with yesterdays release [17:02:02] ? [17:03:22] tfinc: chad is fixing gerrit AND is trying to get the fix deployed [17:03:25] ok [17:03:35] thanks for the info [17:03:45] np [17:04:00] it sounds like gerrit is ok for most things, just not merging into the wmf branches [17:09:09] must go but be back later awjr [17:09:25] jdlrobson: ok - chad is working on fixing gerrit and getting your bugfix out [17:09:31] jdlrobson we can finish the rest later this afternoon as planned [17:09:36] cool [17:09:37] or evening for you [17:18:35] whee https://en.m.wikipedia.org/w/index.php?title=Richard_II_of_England [17:18:42] Reedy/Chad just pushed out jon's fixes [17:18:58] MaxSem can you help dbl check things are ok real quick? [17:19:21] I've just posted a link;) [17:19:28] to a working again infobox [17:19:35] oh, i thought you were just excited about Richard II [17:19:51] yeah, I was investigating the mobile-l email and infoboxes magically appear now without having me turn them on with js in the console [17:20:43] uhoh i still see a problem though, at least in native browser on ICS [17:21:14] Cache? [17:21:20] * Katie_WMDE cheers [17:21:24] MaxSem i clicked 'ancestry' in the Richard II article and the table that comes up overflows through the footer and off the viewport [17:21:55] oh actually, it looks like the infobox is not going away when i try to toggle close the ancestry section [17:22:05] well, it wasn't displayed completely before [17:24:09] i think we need to clear the varnish cache [17:24:29] the Richard II article looks f'd up for me on android 2.3.6 [17:26:23] * YuviPanda goes to manually email people who have done beta testing before [17:28:13] hmm, actually, let me mass bcc people than do individual emails this time and see how things differ [17:28:57] hmm cache flushed but im still seeing weirdness with the table under 'ancestry' on the richard II article [17:29:22] on 2.3.6 i dont even see the table, just the table's title. on 4.0.2, i see the table, but i can't un-see it when i try to close the section [17:30:36] * YuviPanda is also seeing just the title on the app, iOS 4.x sim, with MF master stylesheets [17:30:58] MF is still pretty broken. the san francisco article looks whack on ICS - it appears to be loading some of the images OVER the sections [17:31:18] we need QA [17:31:31] [17:32:29] [17:34:47] tfinc can you confirm that the SF article looks totally busted on your phone? [17:35:32] awjr, I too see only ancestry table header on desktop opera [17:37:50] we need to roll back the changes, [17:38:02] should we roll back to broken info boxes or pre-yesterday's deployment? [17:38:27] the question is when stuff got broken? [17:38:57] hi kul [17:39:07] is patric ill today? [17:39:16] MaxSem there were no complaint about brokens infoboxes before yesterday's deployment [17:39:22] Hi Katie! [17:39:30] awjr, of course [17:39:42] but what about another table weirdnesses? [17:39:55] jdlrobson, ^^^ [17:40:08] MaxSem: what do you mean? jon is gone for a few hours - until 11BST [17:40:39] awjr, the breakage was display:none on every table [17:41:24] MaxSem: right but the fixes deployed are also broken [17:41:27] it can't cause " oh actually, it looks like the infobox is not going away when i try to toggle close the ancestry section" [17:41:50] OH [17:41:55] they didn't just deploy that one revision [17:41:58] they deployed from master [17:41:59] folks, the user test videos Erik ran last night are outrageous [17:42:35] MaxSem: they deployed everything after commit 32fdaebcb1c0d083a3860a38329114448c46704c [17:42:37] we know! [17:43:13] MaxSem: we could try to roll back to the state when we deployed yesterday + cherrypick aeaf030c1fcbd6aef2ad996aa6408cb8a028a477 [17:43:15] and see if that works [17:43:37] if that doesn't fix it, we need to roll back to before yesterday's deployment [17:43:44] one possible way to test would be to test on the app, since it is the same html + mostly the same styles (straight from MFE) [17:43:49] MaxSem: I'm still waiting to hear back from Patrick. he was ill yesterday [17:43:50] no updates today [17:44:01] awjr: can you tell me the commit at which we deployed y'day? [17:44:09] hmm, it was there on the page [17:44:10] * YuviPanda goes [17:44:13] YuviPanda: 32fdaebcb1c0d083a3860a38329114448c46704c [17:44:20] http://www.mediawiki.org/wiki/Extension:MobileFrontend/Deployments/2012-05-07 [17:44:31] YuviPanda: then we need to cherry pick [17:44:32] aeaf030c1fcbd6aef2ad996aa6408cb8a028a477 [17:44:54] okay, setting it to 32fdaebcb1c0d083a3860a38329114448c46704c and seeing if tables are gone [17:44:57] tfinc, there's a question on ML about coordinates removal, I see that it's caused by MF rules that were here since times forgotten. so I wanted to ask Patrick why they were like that in the first place [17:45:13] YuviPanda: also make sure the section toggling is not totally whack [17:45:19] yup they are gone. [17:46:12] YuviPanda try cherry picking aeaf030c1fcbd6aef2ad996aa6408cb8a028a477 on top of that [17:47:20] awjr: cherry picking shows me infoboxes, etc [17:47:27] awjr: but richard II's ancestory still missing [17:47:33] only title is what I see [17:47:38] YuviPanda: take a look at the san francisco article [17:47:44] and play around with section toggling [17:47:48] how does that look? [17:48:18] awjr: style wise looks fine [17:48:37] however, I'll note that the app has slightly different section expansion code [17:48:43] ok [17:48:44] it calls into MF's code, but does DOM expansion first [17:48:49] hmm [17:48:51] so it's still 90% MF's toggle [17:48:55] and 100% of it's styles [17:49:01] i think we should roll back to yesterday's deployment + cherrypick the table fix and try it out [17:49:09] if it's still not quite right, roll back to before yesterday's deployment [17:49:18] tfinc are you following this at all? [17:50:08] i'm moving back to 2098297eb244cc0a6e6aa624e4c6c88a61b8ebd3 and seeing if that fixes richard ii's ancestory [17:50:16] ok ... patrick should be in office today [17:50:21] awjr: not really. whats going on? [17:50:30] ive been meeting with dan and going through my inbox [17:50:37] and trying to track down patrick :) [17:51:18] tfinc: when chad pushed the table fix, he sync'd from master rather than just cherry picking the fix. it mostly resolves the missing infobox issue, but i am seeing hella problems on android 2.3.6 and 4.0.2 [17:51:32] so i'd like to roll back to yesterday's deployment and cherry pick jon's fix onto it and try deploying that [17:51:47] awjr: reverting to 2098297eb244cc0a6e6aa624e4c6c88a61b8ebd3 for me still doesn't show the ancestory bit. I'm unsure if it ever showed. [17:51:53] if things are still broken, then just roll back to where we were before yesterday's fix [17:52:05] awjr: do it [17:52:05] awjr: ^ [17:52:09] did gerrit just die again? [17:52:12] YuviPanda: yeah, im less worried about the ancestry thing and more worried about the completely broken interface that i am experiencing right now :) [17:52:25] gerrit-wm has left irc.freenode.net:7070 (Ping timeout: 252 seconds)... beeeeeeeeautiful. [17:52:27] awjr, i'm trying to repro and bisect locally [17:52:29] but then i want us to discuss what made this explode [17:53:00] awjr: righto [17:53:13] deploying early and often is fun [17:53:44] hmm im getting git timeouts [17:54:13] philinje: i noticed that we removed the expand animation with yesterdays push. has anyone complained about it going away? [17:54:25] awjr: let me know if you need me to track down anyone in the office [17:54:31] k [17:54:32] hence I'm usually opposed to non-emergency deployment of stuff committed 15 minutes ago [17:54:33] gerrit is down again [17:54:48] MaxSem agreed [17:54:59] i didnt realize they had deployed form master instead of just cherrypicking the fix [17:56:33] awjr: question: a little out of context, but do you remember the "Did you mean" feature that was done at the SF Hackathon? [17:56:53] philinje: not a good time to bug awjr [17:56:56] philinje let's talk in a little bit, im trying to get a fix out [17:57:37] philinje: see my question above ? [17:57:39] ok [17:58:08] philinje: philinje: i noticed that we removed the expand animation with yesterdays push. has anyone complained about it going away? 10:54AM [18:01:55] philinje: it was done for the app, and has been in it since 1.1 [18:05:36] hmm, on my machine collapsible sections are DOA on head [18:06:56] YuviPanda: thanks, yeah it works great in the app, just wondering whatever happened to the site [18:07:17] philinje: any thoughts about what i asked about ? [18:08:13] tfinc: haven't seen any complaints, personally, i think it's better without the animation [18:08:50] philinje: k, lets keep watch within our feedback pipelines [18:09:26] tfinc: separately, i had some input from Trevor about CSS transformations, but may be specific to iPhone [18:11:32] New patchset: awjrichards; "Revert "turn off transitions by default"" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6942 [18:11:33] New patchset: awjrichards; "Revert "use cached u variable instead of MobileFrontend.utils"" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6943 [18:11:33] New patchset: awjrichards; "Revert "don't use timeout method on opera mini"" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6944 [18:11:57] awjr, "ancestry" was broken before those commits [18:12:04] cool [18:12:12] that is good-ish news :) [18:13:02] MaxSem awjr : preilly just stepped in. he'll be at his machine in a minue [18:13:13] please queue your questions and take a number :D [18:13:21] Change abandoned: awjrichards; "wrong branch" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6942 [18:13:31] awjr, it's because it is collapsed by default and enwiki's template designers are so roigh that they don't care it it will not work w/o their site JS [18:13:36] Change abandoned: awjrichards; "wrong branch" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6943 [18:13:46] Change abandoned: awjrichards; "wrong branch" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6944 [18:13:51] s/roigh/rough/ [18:15:08] MaxSem: what's up? [18:15:30] preilly, fallout after yesterday's deploymennt [18:16:11] heads up that i'm in meetings till 5pm today ... ohhh the joy! [18:16:34] awjr, so I'm not sure if your selective reverts will help anything [18:16:40] * YuviPanda finishes sending out email, hopes the response this time will be better [18:17:09] tfinc, which amendments says something about cruel and unusual punishment? [18:17:19] MaxSem: the interface is currently broken in other ways for me [18:17:34] under android 2.3.6 as well as 4.0.2 [18:18:04] do you guys have an ether pad created with a list of the current issues? [18:18:59] preilly no [18:19:07] awjr: should there be? [18:19:15] awjr: I mean if it's a hassle that's cool too [18:19:22] i think it would be useful [18:19:36] also, can someone else confirm that the interface is borked at least in android so i dont feel like im crazy? [18:20:12] I can confirm that sections aren't quite collapsible on desktop [18:20:15] Opera [18:20:43] though on WP it looks better [18:20:46] tweets coming in about interface issues https://twitter.com/#!/xRaymond9250/status/199926343817900032 ... could this be related to yesterdays deployment ? [18:21:06] tfinc i think it is what is in production right now [18:21:57] is iPhone getting an Opera stylesheet? [18:22:35] http://etherpad.wikimedia.org/MobileFrontend-20120507-deployment-issues [18:23:37] hmm, opening the SF article on my phone and trying to expand a section crashed browser [18:23:49] YuviPanda: throw it on the etherpad [18:23:49] "images not displaying" is due to vanished infoboxes, see Erik's videos [18:23:55] yeah doing it [18:23:57] MaxSem: k [18:25:24] awjr: i see that you have this. let me know if you need anything. i'm going to step away to tend to some of our other projects [18:25:35] k [18:27:49] hmm, screwed up sections are due to caching [18:27:56] riiiight [18:28:08] awjr: after things settle send out an update to mobile-tech summaring what happened and where we are at [18:28:41] I told Chad to bump $wgmobileResourceVersion when deploying the fix, but it was deployed by Sam [18:29:04] so JS was out of date [18:29:48] we need to deliver both JS and CSS via RL or they will be out of sync after every deployment [18:30:03] causing panic each time [18:36:45] MaxSem: well we can't do RL for JS until we figure out the jQuery dependency issues [18:37:03] awjr: so if we clear the varnish cache for mobile are we all good? [18:37:20] preilly no, already tried that, thats when is tarted seeing the interface issues [18:37:52] preilly: im trying to roll back our deployment branches to yesterdays deployment point + cherry pick jon's fix on top of it [18:38:11] preilly, I was thinking about doing a limited-scale RL-fication: minification, concatenation and versioning but not jQuery-based loading [18:38:29] will need core support though [18:38:33] MaxSem: that's smart [18:38:53] New patchset: awjrichards; "revert bad rule introduced in dbaa7218" [mediawiki/extensions/MobileFrontend] (wmf/1.20wmf2) - https://gerrit.wikimedia.org/r/6946 [18:39:20] New review: awjrichards; "(no comment)" [mediawiki/extensions/MobileFrontend] (wmf/1.20wmf2); V: 1 C: 2; - https://gerrit.wikimedia.org/r/6946 [18:39:23] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (wmf/1.20wmf2) - https://gerrit.wikimedia.org/r/6946 [18:40:30] awjr: the display should have been fine [18:40:50] awjr: more specific styles would have overridden it [18:41:06] preilly im not totally following [18:41:46] awjr: like it is fine in table and could be overridden in table.infobox [18:41:51] there were more changes pushed out this morning than just the table display fix that i assume are what causing the problem [18:44:42] actually, the other changes would not have made a difference - as they were made in js and the minified versions were never updated to reflect those changes [18:45:10] preilly ^ [18:45:11] awjr: the minified version were not updated during a code push? [18:45:29] preilly: not this morning's code push which was handled by chad and sam [18:45:51] awjr: okay, I guess that makes sense then [18:46:13] awjr: so what is the state of things right now? [18:46:44] preilly well im wrapping up setting up a wmf/1.20wmf2 deployment branch for MobileFrontend [18:47:07] so we can roll back wmf/1.20wmf2 and wmf/1.20wmf1 to an earlier state [18:49:00] awjr: are all the issues listed on http://etherpad.wikimedia.org/MobileFrontend-20120507-deployment-issues still valid? [18:49:53] preilly i can only confirm the ones that i added, but yes [18:50:14] YuviPanda: phone has been mailed. i'll send you tracking info once i have it [18:50:56] awjr: so you don't think it's possible to fix master? [18:51:05] jdlrobson: ping [18:51:10] jon is not around [18:51:20] im sure it is possible, but i figured rolling back would be most expedient since jon's not around [18:51:20] awjr: would it help if he was? [18:51:24] yes [18:51:35] or we can just roll back and wait for him to come back, he's out for the evening [18:51:57] awjr: okay that is fine too [18:52:49] now that i've thought about it a little more, i think we should roll back to where we were prior to yesterday's deployment [18:53:25] awjr: okay, that makes sense [18:54:33] preilly im not quite sure how to get the deployment branches back to that state, however [18:54:50] i just created a wmf/1.20wmf2 deployment branch for the MF submodule [18:55:39] preilly, why MF removes #coordinates? there was a ML complaint about this [18:55:42] tfinc: awesome [18:56:41] awjr: drop the one you just created [18:56:59] awjr: and in gerrit create a new remote branch based off of the correct change id [18:57:02] * YuviPanda goes back to Berlin paperwork, which is ~10x that of the US visa [18:57:24] MaxSem: I'm not sure [18:57:46] MaxSem: I think we could keep it and just make sure it is styled correctly and doesn't float over the search box [18:58:29] preilly, how about making a separate MediaWiki:Mobile.css for such things? [18:58:41] MaxSem: that makes sense too [18:59:05] MaxSem: if we do that it would also make sense to move all the common css to that file instead of our custom one [18:59:31] preilly ok, created a new remote branch [18:59:46] awjr: did you base it off of the correct change id? [18:59:49] though it will cause breakages for sites that don't care about mobile CSS [19:00:05] preilly yeah, i based it off of commit 81801251c480e7a9777decf071c6debd8a9c9fb1 which was where we were prior to yesterday's deployment [19:00:21] awjr: okay, that's great [19:00:36] awjr: so you should be able to push that live with no issue [19:00:51] preilly so now i just need to update the submodules in core deployment to point to that branch, right/ [19:01:15] awjr: yeah basically just follow what's on the software deployment page [19:06:41] preilly: https://gerrit.wikimedia.org/r/#/c/6950/ and https://gerrit.wikimedia.org/r/#/c/6949/ [19:10:47] YuviPanda: I didn't see if you replied to my bug [19:10:54] the one about the saved pages double confirmation message [19:12:18] hi tfinc [19:13:04] I added a version 3.2 to the Wikipedia App product on Bugzilla [19:14:37] Thehelpfulone: Been stuck in some paperwork, haven't looked into it yet. Sorry [19:15:31] ok, i have reverted what's in production back to the 30 April deployment [19:15:34] preilly ^ [19:15:40] and leslie flushed the varnish cache [19:16:08] awjr: what's up with https://gerrit.wikimedia.org/r/#/c/6949/ ? [19:16:37] awjr: it depends on I10e73cdc [19:17:06] aw wtf [19:17:33] doing this all in git is taking some serious getting used to [19:19:35] preilly the dependencies for that revision were abandoned [19:20:07] awjr: try to git pull and amend your commit [19:20:27] that would explain why things dont look fixed. [19:22:26] preilly: [19:22:27] awjrichards@virtualbot:~/Dev/wikimedia_git/deployment/core$ [wmf/1.20wmf2]$ git review [19:22:27] You have more than one commit that you are about to submit. [19:22:27] The outstanding commits are: [19:22:27] 55bbb41 (HEAD, wmf/1.20wmf2) Rolling back MF to state after deployment on 30 april 2012 [19:22:27] 74056a8 Updating MobileFrontend [19:22:28] 7e569f5 Reverting three revisions from MobileFrontend [19:22:29] Is this really what you meant to do? [19:22:29] Type 'yes' to confirm: yes [19:22:30] remote: Resolving deltas: 100% (2/2) [19:22:30] To ssh://awjrichards@gerrit.wikimedia.org:29418/mediawiki/core.git [19:22:31] ! [remote rejected] HEAD -> refs/for/wmf/1.20wmf2/wmf/1.20wmf2 (no changes made) [19:22:31] error: failed to push some refs to 'ssh://awjrichards@gerrit.wikimedia.org:29418/mediawiki/core.git' [19:23:00] preilly should i … git rebase -i HEAD~3 [19:25:50] preilly ? [19:27:23] awjr: you should probably rebase [19:27:37] so i tried that [19:27:40] but got the same error [19:28:05] what if i just unabandon those changes? [19:29:01] awjr: you could try that [19:29:09] awjr: or a rebase onto maybe [19:32:52] der [19:32:52] now fenari is dead [19:33:04] awjr: you'll want to git rebase --onto [WHAT WMF2 IS AT SHA1] [WHAT IS THE YOUNGEST CHANGE YOU WANT] see http://learn.github.com/p/rebasing.html [19:33:16] preilly i think i got it sorted im just getting it onto fenari now [19:34:42] awjr: so did you just unabandon those changes and gerrit merged it? [19:35:26] preilly: correct [19:36:49] ok the changes are out now for both wmf1 and wmf2 [19:37:11] i think we need a cache flush and we should be back to where we were after 4/30 deploy [19:37:31] awjr: okay, can you test first [19:37:39] awjr: by bypassing the cache [19:37:47] preilly: how do i bypass the cache? [19:38:09] awjr: append anything to the query string [19:38:50] awjr: if that looks good have Leslie clear the cache [19:38:56] awjr: I'm going to grab some food [19:39:00] k she already has, things loko good [19:39:03] *look [19:39:35] YuviPandno problem [19:39:56] and this channel suddenly got quite busy - do we have a meeting going on in here? [19:46:02] * yuvipand1 heads to sleep. Long queue at the consulate tomorrow. [19:46:06] gnite everyone [20:09:14] New patchset: L10n-bot; "Localisation updates from http://translatewiki.net." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6966 [20:12:37] New review: Siebrand; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/6966 [20:12:39] Change merged: Siebrand; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6966 [20:48:22] New patchset: awjrichards; "Updating removeQueryStringParameter() to reflect pending changes to WebRequest::removeQueryValue() in core" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6989 [20:49:11] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/6989 [20:49:13] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6989 [20:51:54] MaxSem you around? [20:52:00] yup [20:53:10] MaxSem where are you in terms of moving stuff into core? [20:53:48] awjr, I'm currently switched to a different stuff [20:53:54] right on [20:54:16] then, my plans are to move HtmlFormatter and prop=extracts to the core [20:54:18] MaxSem i know you had already started making some changes - did you have a plan/strategy in mind? [20:54:28] ^ [20:54:42] MaxSem cool [20:54:56] MaxSem in the case do you think it would be ok for me to start moving device detection into core? [20:55:34] or do you have thoughts about what might be a good next candidate to be migrated? [20:55:40] hmm, at least you wouldn't collide with me mid-air [20:55:49] that is kinda what i was thinking [20:56:09] DeviceDetection, anyting else with it? [20:57:41] good question, im not sure what makes the most sense to go next - i feel like skin stuff should probably wait for HTMLFormatter to get moved [20:57:41] so [20:58:03] perhaps view toggling? [20:58:30] skin requires MobileFormatter, I'm going to touch just its base HtmlFormatter [20:59:01] once MW can be device aware, we should make it able to switch between views based on device etc [20:59:01] I think skin will logically be the last [20:59:18] i think that makes sense [21:04:53] awjr, are we going to contact the general developer audience before starting with it? [21:05:37] MaxSem that is probably a good idea [21:10:50] philinje: what was it you were trying to ask me about earlier this am? [21:11:51] awjr: yes, it was about what happened to "Did you mean" on the mobile site [21:12:05] you mean the search suggestions? [21:12:17] i can't remember if that ever got added to MobileFrontend [21:12:40] i dont think it did, i think i had just added it to the app [21:12:46] no, as i recall, at the SF Hackathon you worked on "Did you mean" - yes? [21:13:05] philinje correct, but i'm pretty sure i had only finished it for the mobile apps, not for MobileFrontend [21:13:22] i see. That was it [21:27:52] awjr ! [21:27:58] hi jdlrobson [21:28:13] i take you read the email? [21:28:21] yup [21:28:23] rolled back [21:28:31] yeah [21:28:41] im trying to replicate the problem i was seeing in production on mobile-geo right now [21:28:43] what was wrong with toggling? [21:28:55] it just wouldn't… toggle [21:29:01] :/ [21:29:07] or it would toggle one out of a few times [21:29:08] as in nothing would open? [21:29:13] caching, /me says it's caching! [21:29:13] yeah [21:29:20] MaxSem: cache was flushed [21:29:23] was this with just the patch? [21:29:37] jdlrobson in essence, yes [21:29:46] mm [21:29:52] while the other changes were also deployed, they would have had no effect sine the minified JS was never updated [21:30:00] * jdlrobson boots up dev instance [21:30:23] i was only noticing the issue on the San Francisco article, i presume because it's huge and fancy [21:30:43] i was not having toggle issues on the few random other articles i tried [21:31:03] also concerning was the pictures getting overlayed on ICS [21:31:16] plus YuviPanda reported toggling causing his browser to crash under 4.0.4 [21:31:38] jdlrobson: http://etherpad.wikimedia.org/MobileFrontend-20120507-deployment-issues [21:33:54] mm .. i'm not sure what has changed in the toggling code [21:34:06] is that with transitions turned off? [21:34:33] e.g. https://gerrit.wikimedia.org/r/#/c/6523/ [21:34:42] sorry https://gerrit.wikimedia.org/r/#/c/6895/ [21:38:18] jdlrobson that change was deployed this AM, but i dont think it should've had any effect since the minified JS wasn't updated [21:38:23] mm [21:43:21] awjr: can't find anything weird.. [21:43:25] mmmm [21:43:40] brion: were scheduled for 3-4 ... just checking in to make sure you can make it [21:43:44] to talk wlm [21:43:56] PageImages rewrite is over, switching back to MF [21:44:13] tfinc, yep [21:44:23] one sec jdlrobson [21:44:27] awjr, who will email wikitech-l about our evil plans? [21:44:27] i'm just watching some downloads atm, grab me when ready [21:45:01] jdlrobson i've tried a few things on mobile-geo to replicate the issue but haven't been able to [21:45:18] i feel like we'd need to get all the infobox templates and images in order to repro it [21:46:01] export/import + InstantCommons [21:46:10] MaxSem good question; i think we need to firm up our migration strategy and the one of us can draft the email [21:48:45] jdlrobson since we can't repro the issues... [21:49:02] i guess we could try syncing production to master again while you're around [21:49:11] yeh I think that makes sense [21:49:34] New patchset: Jdlrobson; "hide sections on load (bug 36633)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7000 [21:49:35] New patchset: Jdlrobson; "retain hash on page load" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7001 [21:49:38] jdlrobson can you update the minified js? [21:51:10] sure thing [21:51:25] do you want to merge the above or is it wiser to avoid any more changes? [21:51:40] let's avoid any more changes for now [21:51:44] k [21:51:55] awjr: why? [21:52:07] awjr, http://etherpad.wikimedia.org/MobileFrontend-core [21:52:26] preilly: so we don't introduce more variance into something that wasn't working previously? [21:52:58] preilly we still haven't figured out what the problem is [21:53:19] awjr: okay [21:54:13] New patchset: Jdlrobson; "update minified js in prep for deployment" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7002 [21:54:34] New review: awjrichards; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/7002 [21:54:36] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7002 [21:57:09] woooah what happened to main page? [21:57:14] http://en.m.wikipedia.org/http://en.m.wikipedia.org/ [21:57:43] huh looks broken. [21:58:39] also the W icon isn't clickable any more [21:58:50] on any page.. [21:59:32] the W icon isn't clickable any longer? [22:00:02] no... [22:00:03] wtf [22:00:07] confirmed here too [22:00:14] here as ewll [22:00:21] let's get these changes pushed out - i'll be ready in just a minute [22:00:34] but what's happened to the home screen?! [22:00:44] has there been a recent redesign? [22:01:08] awjr: you are missing a main page fix that I did [22:01:26] preilly: what is it? [22:01:47] $("#mp-upper, #mp-other, #mp-sister, #mp-lower, #mp-lang").remove() [22:01:56] if it's in master it's about to go out. [22:02:00] why have all these mobile prefixes been added? [22:02:50] awjr: [22:02:53] $nodesArray = array(); [22:02:54] foreach ( $body->childNodes as $node ) { [22:02:54] $nodesArray[] = $node; [22:02:56] } [22:02:57] foreach ( $nodesArray as $nodeArray ) { [22:02:58] $body->removeChild( $nodeArray ); [22:02:59] } [22:03:00] in getText [22:03:27] it's in master [22:03:39] i just sync'd the deployment branches to master [22:03:45] [22:03:55] im going to push them to prod in just a minute [22:03:57] awjr: so, is everything fixed in master now? [22:04:01] this looks like a really old version of application.js [22:04:12] preilly define 'everything fixed' [22:04:31] we haven't identified the cause of the problem that we were seeing this morning and haven't been able to replicate it elsewhere [22:04:33] awjr: all the issues that we saw earlier [22:04:54] now that jon's back, im going to sync prod back to master, so if the issue is still there jon can at least take a look [22:05:46] https://twitter.com/#!/xRaymond9250/status/199980463689961476 < positive feedback [22:05:47] awjr: okay, so everything is minified as well? [22:05:58] preilly yeah jon minified the latest in master [22:06:03] yup [22:06:34] awjr: so what about all of this stuff —> https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/MobileFrontend,n,z [22:07:58] preilly: it's not going out this minute [22:08:19] i think we should get whatever issue we're experiencing sorted before pushing out new stuff [22:08:23] * jdlrobson thinks that the current live production version of wikipedia looks like a very old version of MobileFrontend [22:13:24] Amgine: i'm in meetings [22:13:34] kk, nm. Tah! [22:15:35] ok, master has been pushed to production [22:16:12] preilly, jdlrobson ^ [22:17:32] * jdlrobson looks [22:17:44] so homepage is fixed +1 [22:18:05] hmm i bumped the resource version but am still getting old js [22:18:41] still a bit of flicker on sections [22:18:45] there's a beta icon in search bar [22:18:57] MaxSem: sounds like you have beta enabled [22:18:58] it it supposed to be so? [22:19:14] awjr: the logo is still not clickable [22:19:31] fine on local [22:19:34] jdlrobson can you verify the version # of the javascript resources you're getting? [22:20:06] ahh cache busted and its back [22:20:46] i don't seem to be seeing new toggle code [22:20:52] application code sorry [22:21:21] now i do.. [22:21:45] main page is screwed up for me [22:22:35] ok, so on the enwiki san francisco article under 4.0.2, i am seeing images appearing over the toggleable sections (i have not yet toggled any sections - this is upon page load) [22:24:27] awjr: for me san francisco toggling is very slow [22:24:27] does anybody see the usual main page content above the mobile one? [22:24:29] and i am experiencing the toggle problems under 2.3.6 - tapping on the section arrows on the SF article does nothing [22:24:35] same [22:24:41] the arrows get highlighted, but have no effect [22:25:42] MaxSem, jdlrobson: the home page looks busted because you're seeing the cached version [22:25:50] if you bust the cache it looks correct [22:25:54] awjr: home page is fine for me [22:26:22] awjr: I can replicate toggling problem on my android [22:26:25] not sure wtf is going on [22:26:56] jdlrobson are you able to see the issue with the image overlays? [22:27:01] im only seeing it 4.02 [22:27:03] no... screenshot? [22:27:07] lemme see [22:27:25] MaxSem: that is cached data [22:27:37] yeah [22:27:57] so awjr - click the heading [22:28:01] does toggling work then? [22:28:15] still laggy on mine mind you [22:28:21] just seems like the buttons are not clickable.. [22:28:30] test.m.wikipedia.org is now up [22:29:02] woot! [22:29:05] seems to just be a problem with larger articles [22:29:26] jdlrobson: ygm - screenshot of whackass image overlay [22:29:37] binasher: you are the shit. [22:30:07] awjr: that's reallllyy weird [22:31:03] i have one theory [22:31:08] but not sure how to check [22:31:40] remove line -webkit-transform: translateZ(0); /* attempt to enable graphics processing unit */ from sections.css [22:34:15] awjr: ^ ? [22:34:33] o sorry was playing with my device. [22:34:39] hmm [22:34:46] damn. i wish we could reprogram this somewhere [22:34:52] or reproduce, rather [22:35:19] im not sure jdlrobson [22:35:26] i guess we could try a live hack, but it makes me feel dirty [22:35:33] not in a good way [22:35:40] me too but i have a good feeling that's the cause [22:36:07] yeah I think that's it too [22:37:01] * jdlrobson decides he hates css transforms [22:37:09] * jdlrobson (and css transitions) [22:38:04] ok sync'ing live hack... [22:40:25] I see blue background in favicon in FF mobile [22:40:36] jdlrobson: how's it look now? [22:41:03] jdlrobson, preilly i think that worked [22:41:08] knew t [22:41:14] that bastard transform [22:41:39] there's still something a little weird, but can probably live with it for now [22:41:59] when i expand the 'cityscape' section of san francisco to reveal the images, then click the section header to close the section [22:42:12] the section appears to close, yet the image stays visible for a second or so before disappearing [22:42:55] remaining issue i see is clicking buttons on my android has no effect [22:42:59] I have to click the heading :/ [22:43:30] doesn't happen on dev on the same device [22:43:32] so bizarre [22:44:24] jdlrobson you might be seeing old css [22:44:30] append some randomness to your query string [22:44:30] i guess the images are killing the page as its only the san francisco article [22:44:38] it appears to be working for me on 2.3.6 with that hack [22:46:13] yeh it's better [22:46:15] yeah, section toggling is working on the SF article with the hack - some of the sections are just really slow to toggle [22:46:16] but SF article is very slow [22:46:25] it's memory I'm sure of it [22:47:18] we //need// to have http://www.mediawiki.org/wiki/MobileFrontend/Dynamic_Sections [22:48:44] that would be hot. [22:48:44] New patchset: Jdlrobson; "removing webkit transform" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7012 [22:48:53] i need held on the server side [22:48:58] maybe something for berlin? [22:49:50] New review: awjrichards; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/7012 [22:49:51] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7012 [22:51:18] awjr: ready for a 2nd deployment with all the outstanding stuff? :-) [22:51:31] jdlrobson let's do it [22:51:37] \o/ [22:52:30] preilly can you help review jdlrobson's stuff so we can try and push it out? i need to take 5 [22:52:32] at least we've got test.m. now [22:52:54] yup [22:52:58] test.m gonna be fun [22:53:40] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/7001 [22:54:19] i love how 2 of the conclusions i've seen so far in user testing are that the dilophosaurus **does** spit venom [22:55:58] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/7000 [22:56:00] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7001 [22:56:01] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7000 [22:56:16] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/6934 [22:56:18] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6934 [22:56:53] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/6927 [22:57:20] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/6926 [22:57:22] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6927 [22:57:23] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6926 [22:57:45] we've got iPhone videos! [22:58:05] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/6925 [22:58:36] jdlrobson: trailing whitespace in https://gerrit.wikimedia.org/r/#/c/6924/1/DeviceDetection.php [22:58:46] thx [22:58:47] [22:59:30] jdlrobson: but, other than that https://gerrit.wikimedia.org/r/#/c/6924/ looks good [22:59:42] s/than/then [22:59:55] just amending now [23:01:04] New patchset: Jdlrobson; "clearly define variables" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6925 [23:01:04] New patchset: Jdlrobson; "add support for browsers based on ie8" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6924 [23:01:23] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/6924 [23:01:25] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6924 [23:01:29] jdlrobson: thanks! [23:01:31] np [23:01:53] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/6925 [23:01:55] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/6925 [23:02:22] cool that looks like everything? [23:02:26] awjr: okay, the queue https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/MobileFrontend,n,z is clear [23:02:36] awesome im going to merge to deployment now [23:03:01] wooow https://twitter.com/#!/robinzachariahs/status/199953139070275584 and from a blackberry user!! [23:03:10] i hope that's not sarcasm ;-) [23:03:25] jdlrobson: ha ha ha [23:03:42] jdlrobson: how's 12:03am Wednesday (BST) treating you? [23:04:05] better than 12.03am Tuesday BST [23:04:15] jdlrobson: ha ha ha [23:04:26] and as long as i get 5 hrs sleep that will be a personal best for the week [23:04:40] jdlrobson: wow [23:05:19] ahaha List of heavy metal bands was also affected by the table bug [23:05:24] awjr: FYI — I'm stepping away from my desk for a few minutes [23:05:30] preilly no worries [23:06:04] jdlrobson, usually you sleep less? [23:06:16] https://twitter.com/#!/jinkhet/status/199888179522834432 < tfinc [23:06:40] i'm not really sleeping too much these days - mixture of excitement, stress and time zones ;-) [23:09:42] MaxSem: i've decided the table bug was actually a good thing - as it gave us more to observe in the videos :) [23:09:48] thus i was meant to break it ;-) [23:10:06] troll! [23:10:17] ok syncing changes to production now [23:11:53] jdlrobson, preilly: changes should now be in production [23:13:01] jdlrobson: sections appear greyed out [23:13:44] we skipped test? [23:13:49] ah [23:13:52] yeah.. [23:14:00] looks like application.js hasn't updated [23:14:10] did the js get minified? [23:14:30] i'm guessing not.. [23:14:53] k jdlrobson can you take care of that? i'll not skip test this time.. [23:15:11] you reverting? [23:15:28] yeah [23:16:09] * jdlrobson looks forward to a world where we don't need to minify :) [23:16:12] New patchset: Jdlrobson; "minify js" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7015 [23:16:27] actually just getting this out might be faster assuming it works [23:16:35] New review: awjrichards; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/7015 [23:16:37] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7015 [23:18:37] k [23:19:02] * jdlrobson watches twitter to see if anyone notices [23:22:10] abuse! [23:22:36] what am I looking for jdlrobson? ;) [23:22:52] jdlrobson: changes live on test. [23:22:54] nothing Thehelpfulone everything is fine - nothing to see here ;-) [23:23:00] :P [23:23:47] jdlrobson sections look right on test [23:23:56] yup [23:23:57] looks good to me [23:24:05] ok pushing to prod [23:27:09] jdlrobson sf article looks good in prod with a cache busting url [23:27:18] \o/ [23:27:26] testing on my devices [23:28:33] jdlrobson looks good [23:28:40] same [23:28:44] at least on my andoirds [23:29:27] binasher: i think we've got our issues fixed - can you please flush the mobile varnish cache? [23:29:37] and this time we tested first :p [23:33:44] binasher nm Lelie's taking care of it [23:35:12] yay mobile wikistuff looks correct and awesome again. [23:35:55] jdlrobson, preilly ^ [23:35:59] tfinc ^ [23:36:01] MaxSem ^ [23:36:24] awjr: great. i'll be out of my last meeting @ 5 and will take a look [23:36:41] awjr: send out an update email to mobile-tech [23:37:06] already drafting it [23:37:44] thanks [23:40:13] right im off to bed guys [23:40:20] thanks jdlrobson [23:40:28] glad to be of service :) [23:40:56] phew thanks a lot jdlrobson [23:40:58] get some rest. [23:43:59] jdlrobson: thanks, man [23:57:56] tfinc_meetings: any update from legal on J2ME [23:58:13] tfinc_meetings: or, will that take a bit to iron out [23:59:55] preilly: i'll let you know as soon as i do