[00:00:06] usually 1-2 days for it to come back [00:00:08] tfinc: okay, cool [00:05:48] awjr: send a tweet from @WikimediaMobile that we've stabalized [00:06:00] and ask for feedback in case people still see issues [00:06:05] tfinc: k - login details? [00:06:12] awjr: on office wiki .. let me pm you the link [00:06:16] k [00:07:29] awjr: that way we have continuity with https://twitter.com/#!/WikimediaMobile/status/199926522361032704 [00:07:36] tfinc yup [00:10:45] * aude wonders who's doing all the tweeting? [00:16:39] * tfinc goes to test and file bugs for todays changes [00:20:11] awjr: anything lingering post deployment that i should know/triage/etc ? ... i'm going to spend some time testing [00:21:05] tfinc the only thing i've seen so far is on ICS - on the SF article, when i toggle some of the sections with images in them open, then close the section, the section closes but the image lingers for a second or so before disappearing [00:21:21] awjr: do we have an open bugs about it? [00:21:25] and toggling is just generally slow on very large articles for both 2.3.6 and 4.0.2 [00:21:36] lets get bugs open to track that [00:21:39] i blieve there's a bug open for slow toggling but not for the ICS issue i mentioned [00:22:20] also, YuviPanda had mentioned a scary bug on 4.0.4 where toggling on the SF article caused the native browser to crash [00:22:37] but i haven't been able to confirm or deny its continued existence. [00:23:49] k [00:24:35] binasher: https://gerrit.wikimedia.org/r/#/c/6618/ [00:25:02] binasher: I guess https://gerrit.wikimedia.org/r/#/c/6618/1/templates/varnish/mobile-frontend.inc.vcl.erb is a better link [00:26:26] preilly: the problem is the regex on line 74 [00:37:42] hmm that california gold rush bug is a weird one [00:51:31] tfinc: you there? [00:52:04] Thehelpfulone: yes but i'm going to be busy for a while. mail me if you have anything [00:52:45] just a quick question about this user testing website [00:52:50] I want to add annotations to the videos [00:52:59] do I need a username/password for this? [00:53:08] I tried to add it as a note but it didn't work [00:54:09] Thehelpfulone : i have no idea about that. philinje do you ? [00:56:04] could be http://www.usertesting.com/features "Take notes while you review videos to mark key learnings. Export to Excel for further analysis." [00:58:44] Thehelpfulone: it might be but i have no clue about how reviews work on that site. respond to phil on the thread and ask [00:58:49] i'm not a good person to answer that [00:58:53] ok [01:56:10] tfinc: we've got these http://www.mediawiki.org/wiki/Mobile_support_in_MediaWiki_core/status [08:39:03] [WikipediaMobile] jdlrobson pushed 2 new commits to master: http://git.io/rAJsHQ [08:39:03] [WikipediaMobile/master] Fixing the command since it's "git submodule" with no 's'. - Waynn Lue [08:39:03] [WikipediaMobile/master] Merge pull request #238 from waynn/patch-1 - Jon Robson [08:56:40] New patchset: Jdlrobson; "follow up to 2bc935f081082fe37c2bce1002a21fe5966a431f" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7038 [10:31:35] New patchset: MaxSem; "Integrate CssDetection into HtmlFormatter" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7042 [10:54:50] New patchset: Jdlrobson; "minor change to contact disclaimer" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7044 [10:55:44] New patchset: Jdlrobson; "scrollTo top of page only if no hash present" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7045 [10:55:45] New patchset: Jdlrobson; "hide address bar on focus of search (bug 36667)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7046 [10:57:03] New patchset: Jdlrobson; "blackberry search box rendering" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7047 [11:11:57] New patchset: Jdlrobson; "don't float boxes on small screens (bug 36528)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7050 [11:12:35] New patchset: Jdlrobson; "don't float boxes on small screens (bug 36528)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7050 [11:12:41] New patchset: MaxSem; "Collision avoidance now that ApiQueryExtracts is in core" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7051 [12:02:56] Hallo. Does anybody know whether there is a good reason to have 6 identical messages in the Zero Rate Mobile Access? [12:02:58] http://translatewiki.net/w/i.php?title=Special%3ATranslate&taction=translate&group=ext-zeroratedmobileaccess&language=nl&limit=100&task=view [12:05:11] <^demon> Well they're identical right now. With country names like that, presumably the idea is that we can customize the messages on a per-country basis. [12:05:17] <^demon> But I'm just guessing. [12:23:21] yeh I suspect it's to be country specific [13:48:07] Hallo YuviPanda. Are you related to the Zero Rated thing? [13:48:44] aharoni: hello [13:48:51] aharoni: no, preilly is the one taking care fo that [13:48:52] *of [13:48:59] OK. [14:59:54] New patchset: Jdlrobson; "allow customisation of footer watermark (bug 35994)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7058 [15:38:28] hi all, user testing videos are up on commons now https://commons.wikimedia.org/wiki/Category:Wikimedia_Mobile_videos [15:45:02] cool [15:46:19] though why publicize this embarrassment? [15:46:28] :P [16:09:56] Hi preilly. I've been told that you work with the Zero Rated thing. [16:10:14] Is there a good reason to have ~6 identical messages in the Zero Rate Mobile Access? [16:11:12] aharoni: they are placeholders at this point [16:11:19] aharoni: they will change soon [16:11:39] Cool, thank you. [16:12:26] preilly: could we not to use {{zero-rated-placeholder}} for them all for the time being? [16:12:41] that way there would only be one string for people to translate [16:14:46] jdlrobson: we could I suppose [16:18:43] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/7038 [16:18:45] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7038 [16:19:35] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/7042 [16:19:37] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7042 [16:20:23] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/7044 [16:20:25] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7044 [16:21:14] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/7045 [16:21:16] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7045 [16:21:43] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/7046 [16:21:45] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7046 [16:22:20] jdlrobson: trailing space https://gerrit.wikimedia.org/r/#/c/7047/1/stylesheets/blackberry.css [16:22:44] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/7050 [16:22:46] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7050 [16:23:32] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/7058 [16:23:34] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7058 [16:24:04] jdlrobson: we should have a deployment note regarding https://gerrit.wikimedia.org/r/#/c/7058/ and $wgMFCustomLogos [16:24:54] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/7051 [16:24:56] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7051 [16:26:35] jdlrobson: also does it make sense to always update the minified file when you touch a source js file? [16:28:02] no that would be far too messy diffs wise [16:28:10] i don't like the minified js in the codebase full stop :) [16:28:30] at least in the current situation when we do minify it gives an idea of stability and a release [16:29:01] jdlrobson: okay [16:29:16] jdlrobson: can you please fix the trailing space in https://gerrit.wikimedia.org/r/#/c/7047/1/stylesheets/blackberry.css [16:29:22] sure [16:29:25] i'm getting sloppy obviously [16:29:49] jdlrobson: not quite [16:31:25] New patchset: Jdlrobson; "blackberry search box rendering" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7047 [16:31:43] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/7047 [16:31:46] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7047 [16:31:54] jdlrobson: thanks [16:32:24] jdlrobson: I'd really like to see most of those changes go out ASAP [16:32:39] * jdlrobson is likely the daily deployment schedule :) [16:34:09] New patchset: preilly; "Update minified javascript" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7059 [16:34:18] jdlrobson: can you approve ^^ [16:34:33] i can +1 [16:34:46] New review: Jdlrobson; "(no comment)" [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/7059 [16:34:51] seems strange +1 ing minified js :) [16:35:05] i suppose technically i should be minifying it myself and checking it is the same [16:35:08] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/7059 [16:35:10] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7059 [16:35:30] jdlrobson: yeah [16:35:54] jdlrobson: that is why I wondered if it made sense to update it more often when js source files change [16:36:05] jdlrobson: even though that isn't a good long term solution at all [16:37:32] * jdlrobson is looking into bug 36681 and bug 33649 [16:38:06] jdlrobson: S60 search stuff, fixed on opera mini, not yet on stock browser though :( [16:38:22] :( slowllly getting there [16:38:34] Indeed, there was someone on twitter asking me if it is possible to go back to the old skin [16:38:40] that always hurts :( [16:38:41] yeh i saw yuvipanda [16:38:48] i couldn't replicate though [16:39:09] awjr, https://gerrit.wikimedia.org/r/#/c/7048/ [16:39:31] I've started with large chunks:) [16:40:43] hello [16:40:43] yuvipanda: does your android 4.0.4 browser still crash on the san francisco article on enwiki? [16:41:04] awjr: haven't tried since today's deployment, let me check [16:41:07] MaxSem: https://gerrit.wikimedia.org/r/#/c/7048/1/tests/phpunit/includes/HtmlFormatterTest.php trailing whitespace [16:41:41] preilly, it's a copy+paste [16:41:55] I haven't modified this file [16:42:09] MaxSem: well just fix the trailing whitespace in both places [16:42:10] well whaddayaknow [16:42:17] awjr: it freezes the browser for about 5-7 seconds [16:42:20] before opening it [16:42:22] doesn't crash though [16:42:34] might be because i just turned it on, while it had other apps running y'day [16:44:02] awjr1: not sure if you got my other messages [16:44:08] it freezes the browser for about 5-7 seconds [16:44:12] before expanding the section [16:44:14] doesn't crash though [16:44:17] dang [16:44:21] jdlrobson ^ [16:44:25] might be because I just turned it on, while it had other things running in the background y'day [16:44:28] let me try the app [16:44:34] and see if it exhibits similar behavior [16:44:50] yuvipanda we made some changes in production yesterday afternoon (pst) that might have resolved the issue [16:44:54] awjr1: i might have fixed that [16:45:00] yeah [16:45:03] there was a problem with transitions not being turned off [16:45:17] yuvipanda can you try again on the mobile site? [16:45:17] * jdlrobson looks for commit [16:45:22] awjr1: I just tried it [16:45:26] like, right now [16:45:27] o [16:45:32] cache perhaps? [16:45:35] * yuvipanda clears cache [16:45:45] awjr1: PDT [16:45:54] thanks, preilly [16:45:59] cleared, trying again [16:47:23] still recurring [16:47:37] also it seems to mistake my scrolling for pinch and zoom multiple times [16:48:22] * jdlrobson has confused himself [16:48:23] :( [16:48:49] jdlrobson: hi, just a note to say Lindsey posted the icons on the Whiteboard [16:49:03] yeh i saw philinje but i forgot today was my 20% day [16:49:13] MaxSem: more whitespace in https://gerrit.wikimedia.org/r/#/c/7048/2/includes/api/ApiQueryExtracts.php [16:49:39] MaxSem: line 197 and 218 [16:49:41] jdlrobson: will the new layout take a while, do you think? [16:50:43] jdlrobson: awjr still happens, completely cleared cache and tried again [16:50:52] awjr: https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/MobileFrontend.git;a=commit;h=f0a5d406cbe8108f8aee2bf08f7c9726532e241c [16:50:52] greetings all [16:50:57] that should fix the problem with ics [16:51:17] hang out is up and running https://plus.google.com/hangouts/_/aade7b2c86e1c8ba065bed373d6273e430384fc1?hl=en# [16:51:20] transitions got turned back on :-S [16:51:42] awjr: is your ICS device doing fine [16:51:42] ? [16:53:06] jdlrobson: by you? [16:53:18] jdlrobson: or on production? [16:53:32] jdlrobson: because wasn't that just a live hack by awjr [16:53:49] no the live hacks in [16:53:52] i think [16:53:59] preilly jdlrobson had checked in a change to replace the live hack [16:54:19] awjr: did you push that change and update the deployment branch? [16:54:33] preilly which change are you referring to? [16:54:34] the live hack dealt with images appearing above sections [16:54:45] awjr: the transition change [16:55:05] preilly: https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/MobileFrontend.git;a=commitdiff;h=f0a5d406cbe8108f8aee2bf08f7c9726532e241c;hp=d43f5f19ff3599f16200d247b6838cfb04ef1473 ? [16:55:25] my audio is spotty if I'm not a black rectangle [16:55:47] awjr: i suspect that commit is what is causing your issues [16:55:51] with freezing etc [16:56:07] Mobile staff are weird. [16:56:21] Reedy: duly noted [16:57:12] philinje: will take a look at new nav tomorrow - will make sure i dedicate tomorrow to it [16:57:42] preilly this is not in production (https://gerrit.wikimedia.org/r/#/c/7038/) nor in the deployment branch right now [16:58:09] jdlrobson: if you can hear us we can't hear you [16:58:47] awjr: MaxSem : https://plus.google.com/hangouts/_/aade7b2c86e1c8ba065bed373d6273e430384fc1?hl=en# [16:59:45] Can we all join in? [16:59:54] was actually wondering the same [17:00:12] Reedy: hashar: only if you join on mute [17:00:18] Boring [17:00:36] thought about coming in real life since we are both in SF :-]]]] [17:05:12] feel free [17:06:07] Thehelpfulone: General feel for the new beta? [17:06:29] I reported the error about the save page bug BlackRectangle [17:06:40] i.e. if you save a page for later then try to clear it [17:06:48] you get a double notification confirmation window [17:07:05] and my phone battery just died... one sec :) [17:07:08] Thehelpfulone: do you have a bug number? My bz search skills seem to suck [17:07:11] ah [17:07:12] oh BlackRectangle you're Yuvi Panda :P [17:07:14] :) [17:07:23] Thehelpfulone: ah yes :) [17:07:24] ooops didn't put it in bugzilla [17:07:46] and BlackRectangle I created 3.2 version product code on bugzilla, is that where you'd prefer to put it? [17:07:59] Thehelpfulone: good question. [17:08:04] Thehelpfulone: 1.2 Android == 3.2 iOS [17:08:14] i'd like to keep things together as much as possible. [17:08:18] so, stick to 1.2? [17:08:36] ok I'll rename to (iOS) on the end [17:09:17] ok so https://bugzilla.wikimedia.org/enter_bug.cgi?product=Wikipedia%20App [17:09:37] any product version missing or need amendments? [17:10:39] * YuviPanda hopes that the time five minutes before standup turns into a 'who can be the most ridiculous' contest [17:10:50] Thehelpfulone: there was a field for 'mobile OS'? [17:10:55] IIRC it was a custom field added [17:11:07] i'm disappointed i can't make friday's as i have the best prop for next time... [17:11:31] jdlrobson: you can make up for it monday [17:11:42] YuviPanda: yes it's under advanced [17:11:46] sadly the Panda's the most I've got here. [17:12:02] Thehelpfulone: so I'm guessing that plus version 1.2 would do? [17:12:24] hmm I don't think I quite understand [17:12:27] on https://bugzilla.wikimedia.org/enter_bug.cgi?product=Wikipedia%20App [17:12:32] where it says Version: [17:12:45] there's 3.1.1 (iOS), 3.1.2 (iOS) [17:12:51] and I just added 3.2 (iOS) [17:12:58] you're saying 1.2 there is for android? [17:13:08] hmm, we don't have clear cut guidelines for it yet [17:13:14] I suppose we can kill all current versions [17:13:15] anyone got an ideas what's going wrong with http://mobile-geo.wmflabs.org/w/index.php/Test-driven_development ? [17:13:15] and just have [17:13:24] Warning: wfMkdirParents [17:13:29] 1.2 (android) / 3.2 (iOS) [17:13:40] 1.1 (android) / 3.1 (iOS) [17:13:40] etc [17:13:42] as versions? [17:13:50] Thehelpfulone: since most of the issues are common to both Operating systems [17:13:55] MaxSem: if you fix the whitespace in this https://gerrit.wikimedia.org/r/#/c/7048/ I'm cool to approve it [17:14:01] yeah that could be done [17:14:03] Thehelpfulone: the double prompt, for example, would be there in both iOS and android [17:14:07] I'm not sure spacing wise though, one sec [17:14:41] preilly, don't you want someone from the core team do this? [17:15:01] ergg ie6 is a mess [17:15:13] YuviPanda: https://bugzilla.wikimedia.org/enter_bug.cgi?product=Wikipedia%20App [17:15:14] MaxSem: I was just going to, "+1 Looks good to me, but someone else must approve" [17:15:15] refresh that [17:15:30] you want that instead of the individual 1.2 and 3.2? [17:15:47] tfinc: ^ have a look at that too :) [17:15:49] Thehelpfulone: yeah! [17:16:06] Thehelpfulone: let me make a list of versions that already existed along with their iOS counterparts [17:16:09] thanks [17:16:13] Thehelpfulone: what am i looking at? [17:16:22] look at the versions section [17:16:24] of the bug report [17:16:42] I've made a new version, 1.2 (Android) / 3.2 (iOS) [17:16:51] Yuvi said most bugs are common to both platforms? [17:17:02] Thehelpfulone: http://hastebin.com/seyacikosa.coffee [17:17:16] Thehelpfulone: did you move all exiting bugs to 1.2 Android then ? [17:17:19] MaxSem: what is a good Victory Day wish for someone? [17:17:22] s/existing/existing 1.2 [17:17:26] yeah, be careful so that we don't lose them :) [17:17:29] tfinc: not yet, if we agree that we want it then I will do it [17:17:35] cleanup good, data loss bad :) [17:17:37] YuviPanda: do you like this change? [17:17:47] he suggested it ;) [17:17:50] tfinc: http://hastebin.com/seyacikosa.coffee is the list of versions I came up with [17:17:53] Thehelpfulone: ^ [17:17:53] Thehelpfulone: move all the bugs 1.2 bugs then [17:18:07] ok [17:18:08] Thehelpfulone: can't you 'rename'? [17:18:13] so that current bugs are kept? [17:18:18] yeah I think so [17:18:24] i dont want a 1.2, 1.2 Android, and 3.2 iOS [17:18:26] I was just going to check if there were any ios bug to move [17:18:27] two is enough to confuse us [17:18:34] three is just asking for trouble given how dumb bugzilla is [17:18:49] preilly, for a non-Russian congratulating a Russian, just a concise congratulation [17:18:56] wow ... github went icon crazy today [17:19:24] preilly: how does device detection work on mobile-geo ? [17:19:25] all hail our new multi colored 8x8 overlords [17:23:10] tfinc: new icons look weird to me [17:23:11] ok refresh YuviPanda / tfinc [17:23:20] was wondering where all my folders went [17:23:29] so because 1 is before 3, the new version numbers are coming in the middle of the list [17:23:36] should I put the 3.1 (iOS) at the front instead? [17:23:44] so that the version numbers are order from oldest to newest [17:25:45] tfinc: out of interest when you try and open a section on E63 do you click the images? [17:26:16] jdlrobson: srikanthlogic is the one with the E63, unless tfinc has one too? [17:26:17] as it WFM - i just have a weird zooming issue [17:26:26] no this is using an emulator [17:26:30] i have the same emulator [17:26:35] https://bugzilla.wikimedia.org/show_bug.cgi?id=36681 [17:26:53] i'm using the desktop emu [17:27:22] same [17:27:26] but I can open sections.. [17:27:42] brb [17:34:18] Thehelpfulone: that will still cause problems with ordering when we get the next version out, no? [17:34:22] hmm, or maybe not [17:34:29] Thehelpfulone: try it and see if it renders correctly? [17:34:31] (iOS verison first) [17:34:52] New patchset: Jdlrobson; "serve all other ie versions < 8 html mobile site" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7062 [17:35:53] ok [17:37:12] YuviPanda: have a look? [17:37:59] * YuviPanda refreshes [17:38:13] Thehelpfulone: no change [17:38:53] clear cache? [17:38:54] https://bugzilla.wikimedia.org/enter_bug.cgi?product=Wikipedia%20App [17:39:15] Thehelpfulone: i see the change but the order hasn't changed [17:39:39] it did for me [17:39:40] hmm [17:39:48] clear the cookie of the bugzilla page [17:40:35] hmm [17:40:40] i'm trying in a different browser now [17:41:04] ok [17:41:12] Thehelpfulone: nope, still see 3.x at the bottom [17:41:18] hmm, wait, I think that's fine [17:41:23] or maybe not [17:41:25] yeah that's how I want it ;) [17:41:32] hmm that's actually fine :) [17:41:35] Thehelpfulone: thanks! [17:41:42] no problem :) [17:42:28] YuviPanda: refresh one more time? [17:42:31] I think that's what you wanted [17:43:22] aaah what I expected :) [17:51:53] jdlrobson: you might be interested in http://html9responsiveboilerstrapjs.com/ [17:52:54] :) [17:53:28] documentation is very helpful ;-) https://github.com/impressivewebs/HTML9-Responsive-Boilerstrap-js/blob/master/README.md [17:53:32] preilly & awjr, you've modified the regex in MobileFormatter - do you remeber the exact breakage scenario? [17:54:05] MaxSem not the exact one, but it involved having section header HTML spread across two lines [17:54:52] I'm gonna change it again, so would be great if you added a test case to avoid another breakage [17:56:03] MaxSem: new lines [17:56:26] where exactly in the header? [17:57:26] in the section headings [17:57:29] MaxSem can't remember off the top of my head - I may have a sample saved somewhere [17:57:36] it was newline [17:58:08] philinje: I updated https://bugzilla.wikimedia.org/show_bug.cgi?id=36017 with a screenshot of how the app looks with just the globe. Veerrry bland. I didn't ship it with beta2 [18:03:26] YuviPanda: ok, but is a blank screen better? [18:03:38] jdlrobson: ready for the meeting? [18:04:16] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/7062 [18:04:18] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7062 [18:04:39] philinje: no, as brion mentioned and I agree, a blank screen makes the app look 'broken' [18:05:01] philinje: I liked the first design, one with 'wikipedia' + a few actions underneath it. Perhaps something similar with the globe? [18:06:22] jdlrobson: you there? trying to call on skype [18:06:43] yep philinje sorry my mac crashed (i know!!) [18:06:55] i'm still in shock [18:07:57] the apple team will be there shortly to memory charm jdlrobson [18:08:55] philinje: you there? [18:12:22] New patchset: MaxSem; "Bug 36670: inside of section headings causes empty section titles" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7064 [18:16:40] MaxSem: weird whitespace in https://gerrit.wikimedia.org/r/#/c/7064/1/tests/MobileFormatterTest.php [18:17:00] MaxSem: ha ha but I guess you need that for your test [18:17:21] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 0; - https://gerrit.wikimedia.org/r/7064 [18:17:37] awjr: can you take a look at https://gerrit.wikimedia.org/r/#/c/7064/ [18:17:59] preilly i'll take a look once im out of this mtg [18:18:05] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 1; - https://gerrit.wikimedia.org/r/7064 [18:19:11] awjr_meeting, what are they doing to you? :P [18:39:44] props to whoever responded to @sumitsinha [18:41:50] philinje: thanks for your comments on the mailing list [18:41:53] can you do one for the wikipedia apps like I mentioned in the email? [18:41:54] probably best to do it on the new release when it comes out? [18:44:29] tfinc: that was me and YuviPanda [18:45:04] awjr: don [18:45:05] t [18:45:06] [18:45:12] awjr: forget to take a look at take a look at https://gerrit.wikimedia.org/r/#/c/7064/ [18:45:13] eh? [18:45:19] im leaving my comments now [18:45:22] awjr: that was weird [18:46:31] New review: awjrichards; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: -1; - https://gerrit.wikimedia.org/r/7064 [18:46:41] preilly, MaxSem ^ [18:47:18] awjr: the whitespace in https://gerrit.wikimedia.org/r/#/c/7064/1/tests/MobileFormatterTest.php is needed for the test [18:47:54] * MaxSem digs up the parser [18:47:58] oic [18:48:10] then i take it back. [18:48:32] awjr: maybe worth amending your comment [18:48:35] * jdlrobson goes out for beer - see you later [18:48:40] jdlrobson: enjoy [18:49:13] preilly: maybe worth adding a code comment? [18:49:24] awjr: I think .*/h2>%sU was fine [18:49:52] s (PCRE_DOTALL) and U (PCRE_UNGREEDY) did the trick [18:50:17] because if this modifier is set, a dot metacharacter in the pattern matches all characters, including newlines. Without it, newlines are excluded. This modifier is equivalent to Perl's /s modifier. A negative class such as [^a] always matches a newline character, independent of the setting of this modifier. [18:50:50] preilly that's what i thought too but why is it not working for articles like the gold rush? [18:51:01] and U (PCRE_UNGREEDY) modifier inverts the "greediness" of the quantifiers so that they are not greedy by default, but become greedy if followed by ?. It is not compatible with Perl. It can also be set by a (?U) modifier setting within the pattern or by a question mark behind a quantifier (e.g. .*?). [18:51:13] awjr, because there's second [18:51:37] oh and ungreedy [18:52:16] and with two greedy quantifiers nobody knows for sure what the hell it's gonna capture [18:52:27] right could capture the whole page [18:52:38] New review: awjrichards; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: -1; - https://gerrit.wikimedia.org/r/7064 [18:52:39] awjr: are you saying http://en.m.wikipedia.org/wiki/Gold_rush is broken? [18:53:00] preilly: http://en.m.wikipedia.org/wiki/California_gold_rush [18:53:02] that is broken [18:53:23] the history section is there (the first section) but there is no label for it [18:54:40] awjr: because it's

[edit] History

[18:55:12] so, this is messing it up [18:55:50] yeah [18:56:25] hmm [18:56:37] so, that is a good example of even the new regex sucking too right? [18:57:41] yup. so … look for text between '>' and '<' but within '', accommodating for spaces/newlines [18:58:29] what I don't understand is where did that newline came from [18:58:48] Linker::makeHeadline() contains no newlines [18:59:24] philinje: can you point to the mail you sent out ages about about creating mobile main pages for other languages ? [19:01:09] MaxSem: maybe it was an errant carriage return by the editor? does Linker::makeHeadline() trim? [19:01:51] it outputs what Parser feeds into it [19:02:11] tfinc: search for, "TO: All Wikimedia Project Administrators" [19:02:14] :q! [19:02:19] der [19:02:19] ww [19:02:23] k [19:02:34] however, there is guaranteed that there is nothing between and [19:02:58] tfinc: see http://www.gossamer-threads.com/lists/wiki/wikitech/260064 [19:04:21] except for \s\n\r :p [19:04:33] preilly: thanks. im also trying to track down the mails that went to the top level wikipedia lists [19:05:36] tfinc: to wikipedia-l@lists.wikimedia.org,wiktionary-l@lists.wikimedia.org,wikiquote-l@lists.wikimedia.org,textbook-l@lists.wikimedia.org,wikisource-l@lists.wikimedia.org,wikinews-l@lists.wikimedia.org,wikiversity-l@lists.wikimedia.org,wikispecies-l@lists.wikimedia.org,wikitech-l@lists.wikimedia.org,commons-l@lists.wikimedia.org,incubator@lists.wikimedia.org [19:06:02] date: Tue, Nov 15, 2011 at 8:48 AM [19:06:03] subject: [Wikitech-l] Final mobile switch-over [19:06:08] preilly: thanks [19:06:10] tfinc: are you talking about that one [19:06:15] awjr, so the newline must have been somewhere else. you'd better recall where ;) [19:06:39] hmm [19:06:41] philinje: are we meeting @ 12 ? [19:07:01] MaxSem: I think you fixed the newline issue [19:07:10] MaxSem: it was part of your
related stuff [19:07:24] ahaaaa [19:07:37] it was put through DOMParse [19:08:55] MaxSem: this was the issue: https://bugzilla.wikimedia.org/show_bug.cgi?id=36306 [19:09:05] but yeah, it had been resolved [19:12:06] ____ . _ . [19:12:07] /# /_\_ |\_|/__/| [19:12:07] | |/o\o\ / / \/ \ \ [19:12:07] | \\_/_/ /__|O||O|__ \ [19:12:07] / |_ | |/_ \_/\_/ _\ | [19:12:09] | ||\_ ~| | | (____) | || [19:12:11] | ||| \/ \/\___/\__/ // [19:12:14] | |||_ (_/ || [19:12:16] \// | | || [19:12:19] || | | ||\ [19:12:21] ||_ \ \ //_/ [19:12:24] \_| o| \______// [19:12:26] /\___/ __ || __|| [19:12:29] / ||||__ (____(____) [19:12:31] (___)_) [19:13:12] hmm [19:13:17] #wikimedia-office got a cat [19:13:24] i'm unsure what we got [19:13:28] nope, my trollish friend, we don't have monospace font in our IRC clients [19:13:37] ren and stimpy, i think [19:13:40] but yeah, monospace fail. [19:13:53] well, I'm on irssi [19:14:04] so I see some sort of dog with a crown on the right [19:14:09] unsure what's on the left, though [19:14:18]