[00:00:09] the beta in master is hella broken [00:04:16] awjr: hi, back again [00:04:23] hi philinje [00:04:25] i sent you an emial [00:04:25] should we chat on Skype? [00:04:26] *email [00:04:27] sure [00:05:09] ok let me find a room [00:07:22] awjr: are you on Skype? [00:07:37] yep [00:44:31] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/7899 [00:44:33] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7899 [00:46:19] preilly you 'round? [01:01:57] New patchset: awjrichards; "* Added error messaging for when something goes wrong during remote posting from beta feedback form * Changed 'echo' statements in remote posting API client to throw exceptions in beta feedback form * Changed validation rules for beta feedback form, per b" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7918 [01:04:16] ghost town in here [01:04:21] :) [01:04:24] we're not all ghosts [01:04:27] lolz [01:04:45] yeah… i think this is the quietest i've ever seen this place [01:04:54] its a bit eerie isn't it? [01:05:00] i'll have to fix that tomorrow [01:05:04] heh [01:05:09] we'll have to bring archer bot back [01:05:14] lol [01:05:18] i'm sure preilly can revive him [01:12:25] awjr: whats your targer for contact us going default ? [01:12:34] tfinc: Monday [01:13:28] nice [01:13:36] i've got two related commits awaiting review - one with some polishing up changes (after chatting with Phil) and one making it default [01:13:41] i was curious since i know your 20% day is coming up [01:13:53] yeah, i awnted to make sure i got everything done today [01:13:55] let me know if need to find a reviewer for it [01:13:58] thanks [01:14:18] max did the bulk of it, i just need preilly to ok it and merge it to master [01:14:34] k [01:14:52] flag it for him and if you have any trouble getting it reviewed let me know [01:15:04] yep [01:17:20] oh man verizon is no longer grandfathering in unlimited data customers unless they pay full price for a phone [01:17:30] glad i got my galaxy nexus when i did [01:18:07] seriously [01:18:21] i've regularly been going over 4gb of data/mo... [01:21:59] im out - have a good night folks [06:30:51] * YuviPanda looks around [10:50:06] New patchset: MaxSem; "rm unused message mobile-frontend-sopa-notice" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7939 [11:04:36] MaxSem: there? [11:04:43] yup [11:04:44] https://meta.wikimedia.org/w/index.php?title=Www.wikipedia.org_template/temp < how do I render the html view of this page? [11:04:48] any ideas? [11:04:53] googling is failing me [11:05:04] https://meta.wikimedia.org/wiki/Talk:Www.wikipedia.org_template/temp [11:05:05] ahh found it finally [11:05:12] hidden away under that arrow [11:05:44] i was looking for some text saying "live preview portal textarea" [11:05:51] ok sweet [11:05:55] thanks [13:33:21] New patchset: Jdlrobson; "additional styling for infoboxes" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7948 [13:39:02] *finally* [13:39:09] jdlrobson: https://github.com/wikimedia/WikipediaMobile/pull/246 [13:39:15] fucking hairy [13:40:20] :) [13:40:49] my big achievement for the day -> http://bug-attachment.wikimedia.org/attachment.cgi?id=10619 [13:41:11] woooS [13:41:13] *sweet! [13:41:42] will be interesting to see what people think [13:41:48] it's only a bit of extra css [13:41:53] possibly more bikeshed? [13:43:52] well could well go down that route but i mean - the mobile site is current mess, i'm not touching the desktop site other than adding 879 bytes [13:45:50] the bug list for the mobile site is getting reassuringly low :) https://bugzilla.wikimedia.org/buglist.cgi?query_format=advanced&field0-0-0=bug_severity&bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&type0-0-0=notequals&value0-0-0=enhancement&component=MobileFrontend&resolution=---&resolution=LATER&resolution=DUPLICATE&product=MediaWiki%20extensions&list_id=116638 [13:46:12] i won't stop till it's empty! [13:46:24] the 1.2 list got empty with that pull request :) [13:46:47] there are two bugs that've been fixed that I need to verify though [13:46:49] * YuviPanda goes to verify [13:47:24] i don't know why.. but this coffee shop i'm in seems to be a hotspot for people talking about their past lives and future lives (e.g. reincarnation) [13:47:33] it's always interesting background noise [13:48:15] jdlrobson: I stopped working out of coffee shops since 90% of the time I found myself the single guy among a lot of people on dates [13:48:33] haha [13:48:45] this is the one thing I'm going to miss when I move to the SF office [13:48:47] working out of random places [13:48:57] jdlrobson: I was once on a bus writing some random code. It stopped, we looked out, and there was one guy chasing another one with a pretty big machete-like knife (common here) [13:49:06] followed by another guy with blood all over his shirt [13:49:11] and another one bleeding out of his ears :D [13:49:11] oh dear [13:49:25] for a moment I was wondering if they got *on* the bus [13:49:36] thankfully they ran past us and the bus went on its way [13:49:41] take that for 'background noise' [13:49:52] come to think of it, I *should* have been more shaken than I was [13:50:51] you're desensitised to it? [13:50:58] i think the strangest place i've worked out of so far to date was a recording studio (that was fun albeit a bit noisy and no knives luckily) [13:51:38] jdlrobson: no, I'm not. That was the first time that happened to me. [13:51:46] hmm, or maybe I am [13:51:56] it *did* feel like something exactly out of a movie [13:52:14] people running after each other like that is to tamil movies what something destroying NYC is to hollywood [13:52:37] I wasn't even coding. I was reading reddit [13:52:42] oh well [13:53:12] YuviPanda: when's the next release planned? [13:53:26] jdlrobson: next week. Once this goes in I'll do an RC [13:53:32] any particular date? [13:53:40] want to put a reminder in my calendar to phase out those dreadful buttons [13:54:19] jdlrobson: none yet, but I'll be on to WLM app from Monday. The app itself would definitely be out before Friday [13:54:56] k [13:55:00] the shittiest part of working like this is *definitely* the mosquitoes [13:55:03] scheduled for 28th [13:55:06] i'll move it if necessary [13:55:12] haha [13:55:18] btw what are your plans for Berlin? [13:55:20] it's a wonder I've not had malaria or anything [13:55:33] I've not been to one of these mediawiki hackathons before so I'm not sure what to expect.. how do they usually work? [13:55:35] jdlrobson: so, I fly in on 31, fly out on 9. 4-8 is my time off, and I've no idea wtf I'll be doing then :D [13:55:46] jdlrobson: i've only been to pune and bombay, so this is completely different [13:56:00] you've never left india? [13:56:13] oohh you mean for the hackathons? [13:56:26] jdlrobson: yeah [13:56:31] jdlrobson: berlin is an 'inreach' hackathon [13:56:36] i've only been to 'outreach' ones [13:56:46] they usually work by having a half a day for 'tutorials', then people pick things and hack on them [13:56:59] from what I gather, In reach ones are the same, except for the topics covered [13:57:02] outreach is 'hello world' [13:57:11] in reach would be 'intricacies of Lua in wikitext' [13:57:14] i was thinking it would be call to hack with some people on making MFE dynamically load sections [13:57:25] but I don't know if that would be possible [13:57:33] although would be a rather cool achievement [13:58:09] jdlrobson: :D [13:58:23] jdlrobson: there's a wikimedia hackathon happening here tomorrow [13:58:31] i'll see if I can find someone to hack that into the app [13:58:33] sweet you going? [13:58:38] I'm organizing :P [13:58:42] awesome [13:58:48] I like doing little 'unofficial' wikimedia hackathons [13:58:54] third one I'm doing :0 [13:59:01] that's great :) [13:59:40] indeed [13:59:44] last one had about 20 people [13:59:48] ~15 of them new [13:59:51] i'd suggest holding off dynamic sections in the app though - i think it would make more sense in the mobile site first as it will require some changes to the references code [13:59:54] we 'retained' 1 guy [14:00:30] jdlrobson: hmm, true. Maybe should ask MaxSem to add a way to get just section 0 and the ones that have 'references'? [14:00:48] ideally it would be good to request references via the api [14:00:56] doable [14:01:28] MaxSem: shall I file a bug? [14:01:37] MaxSem: would that be a special string in the 'sections'? [14:01:51] so I can do something like 0|references [14:01:54] or something? [14:02:03] I'll see to it [14:02:07] no need in bug [14:02:14] wheeee! [14:02:35] jdlrobson: when can you look at the pull req? [14:03:22] i will do YuviPanda - give me 30 minutes though just catching up with a friend [14:03:36] brb [14:03:45] awesome [14:05:16] MaxSem: just to clarify - the new feature would let me specific 'references' in sections and let me get all references sections? [14:05:23] so I can do something like sections=0|references [14:05:24] right? [14:05:38] yes [14:05:58] awesome [14:07:35] whee, only one bug in 1.2 now [14:07:38] and that's pending a pull request [14:07:39] sweet [14:55:25] * YuviPanda looks around [15:13:56] Detected bug in an extension! Hook ExtMobileFrontend::getCacheVaryCookies failed to return a value; should return true to continue hook processing or false to abort. [15:13:56] ;) [15:14:06] so most probably everyone sleeping still [15:16:30] MaxSem: ping ? ;°D [15:16:41] pongpongpong [15:16:43] good [15:16:53] some of your mobile context feature in MobileFrontend cause an error [15:17:08] $wgHooks['GetCacheVaryCookies'][] = array( &$this, 'getCacheVaryCookies' ); [15:17:17] where $this is ExtMobileFrontend which extends ContextSource [15:17:25] I guess it should extends MobileContext instead [15:17:43] I4fb0a126cb358a7bdd5a80577a85f69fbaf9e2f7 [15:17:53] MaxSem: stacktrace on beta : http://test.wikimedia.beta.wmflabs.org/ [15:18:14] https://gerrit.wikimedia.org/r/#/c/7795/ [15:18:37] no, it shouldn't inherit from MobileContext [15:21:20] I have moved my checkout of mobile fronted extension before that commit meanwhile [15:21:28] do you want me to open a bug MaxSem ? [15:21:40] New patchset: MaxSem; "Return getCacheVaryCookies() back to ExtMobileFrontend" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7961 [15:21:54] WORKSFORME:P [15:22:06] ...now [15:22:19] hehe [15:22:57] * YuviPanda pokes jdlrobson [15:23:09] heyyy YuviPanda poking me about saved pages? [15:23:17] yup! [15:23:22] New review: Hashar; "Caused some stack trace on beta labs, root cause https://gerrit.wikimedia.org/r/#/c/7795/" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/7961 [15:23:24] Change merged: Hashar; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7961 [15:23:30] sorry just getting some changes to beta done for a call in an hour [15:24:12] jdlrobson: ok [15:24:22] I'll go check out the WLM app in the meantime [15:24:23] MaxSem: fixed on beta labs ;-) Danke! [15:29:09] YuviPanda: on https://bugzilla.wikimedia.org/show_bug.cgi?id=36396 [15:29:15] there's an option to close a bug as WORKSFORME [15:29:20] under the resolved bit [15:29:22] I did do that [15:29:23] IIRC [15:29:29] noope [15:29:31] fixed that now [15:29:31] nope it's just fixed [15:29:41] clumsy fingers, I think [15:29:44] thanks :) [15:29:45] Thehelpfulone: fixed it now Thehelpfulone :) [15:36:18] MaxSem: was the plan that Special:MobileOptions would be a settings page e.g. http://www.mediawiki.org/wiki/File:Browser-set4.png [15:39:21] New patchset: Jdlrobson; "style languages and toc consistently with full search search results" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7962 [15:39:22] New patchset: Jdlrobson; "reduce size of main menu to be same as header" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7963 [15:39:22] New patchset: Jdlrobson; "first version of main menu navigation" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7892 [15:41:40] jdlrobson, so fat it has been just a faithful port of existing functionality [15:42:03] ok MaxSem - any reasons why we couldn't use it? [15:42:17] (for that purpose as a generic settings page) [15:42:28] none? [15:42:33] awesome [15:43:32] though it will probably reduce the discoverability [15:46:27] in what way? [15:49:00] also MaxSem any idea what's going on here - http://mobile-geo.wmflabs.org/w/index.php/Special:MobileOptions/BetaOptIn [15:49:22] ahh forget that - it was caching [16:14:35] jdlrobson: hi Jon [16:14:40] hey philinje [16:14:52] didn't have time to update the whiteboard last night [16:15:08] how is the test site looking? [16:15:14] I noticed :) it's looking much better now [16:15:17] I just mailed you with details [16:15:27] great thanks [16:17:36] i wonder if we should go with close a section, instead of jump back [16:17:44] also rows not clickable in main menu [16:19:22] going back from Actio bar stuff like Contents should close Action Bar, same when opening main menu [16:20:23] will put all this on the whiteboard [16:28:48] jdlrobson: ready for the call? [16:29:47] yup [16:33:57] YuviPanda|food: just noticed "Sent from my tricorder" lols [16:53:25] New patchset: MaxSem; "Allow users to specify that they want all sections containing " [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7966 [16:53:39] jdlrobson, YuviPanda|food ^^^ [16:53:51] \o/ [16:55:33] * yuvipanda is on a phone in traffic [16:59:25] greetings all [16:59:29] hang out is up https://plus.google.com/hangouts/_/5418beddc870fb56200f85abe54e88201943aecc?authuser=1&hl=en [16:59:46] sorry for the delay ... im feeling crappy today [17:00:21] I am in traffic will miss it. Sent mail [17:00:36] yuvipanda: yes ... i saw your mail. thanks [17:01:11] awjr: jdlrobson MaxSem https://plus.google.com/hangouts/_/5418beddc870fb56200f85abe54e88201943aecc?authuser=1&hl=en [17:02:06] jdlrobson: joing us ? [17:10:55] * tfinc_meetings coughs up a storm again [17:11:20] jdlrobson: just realized - will the beta have the W inside the search bar (like the last prettype)? [17:11:28] yes [17:11:41] ok [17:13:46] twitter continues to be really quiet. how unnerving [17:13:47] :) [17:15:31] MaxSem: did you see that, "Detected bug in an extension! Hook ExtMobileFrontend::getCacheVaryCookies failed to return a value; should return true to continue hook processing or false to abort." reported by hashar [17:15:49] already fixed an merged [17:16:20] MaxSem: okay, great [17:17:24] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/7939 [17:17:26] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7939 [17:18:26] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/7966 [17:18:28] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7966 [17:19:32] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/7918 [17:19:34] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7918 [17:20:37] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/7948 [17:20:39] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7948 [17:21:28] MaxSem: why does https://gerrit.wikimedia.org/r/#/c/7670/ delete all the javascripts? [17:21:51] because ResourceLoader minifies them itself [17:21:58] MaxSem: is it just because we don't need minify directly anymore? [17:22:04] yep [17:22:07] MaxSem: okay cool [17:22:16] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/7670 [17:22:23] tfinc: no news on twitter is good news [17:22:32] twitter is mostly used to moan ;-) [17:22:46] merge conflict? [17:22:52] MaxSem: Your change could not be merged due to a path conflict. Please merge (or rebase) the change locally and upload the resolution for review. [17:23:03] New patchset: Jdlrobson; "fixing rendering issues in firefox beta" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7969 [17:23:03] New patchset: Jdlrobson; "style languages and toc consistently with full search search results" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7962 [17:23:04] New patchset: Jdlrobson; "reduce size of main menu to be same as header" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7963 [17:23:05] New patchset: Jdlrobson; "first version of main menu navigation" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7892 [17:23:07] philinje: fixed firefox issues ^ [17:23:26] jdlrobson: master (MissPiggy) [17:23:47] what about it preilly [17:23:48] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/7969 [17:24:08] jdlrobson: agreed [17:24:12] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/7963 [17:24:20] jdlrobson: tell me again what you are proposing for beta opt-in? [17:24:21] awjr: see. already more chatter today [17:24:21] jdlrobson: funny choice of name [17:24:37] tfinc im still waiting for preilly to turn on archerbot [17:24:45] preilly: we'll need archer bot today [17:24:47] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/7962 [17:24:57] preilly: all our design pushes are named after muppets characters. that's my prerogative ;-) [17:25:04] after the ghost town in here yesterday we'll need archer bot to come back [17:25:47] philinje: I was just saying we can do things like "sneak preview of new designs for wikipedia - let us know what you think http://mobile-geo.wmflabs.org/w/index.php/San_Francisco?useformat=mobile&mobileaction=beta " [17:25:58] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 0; - https://gerrit.wikimedia.org/r/7892 [17:27:29] tfinc: i'm going to try and fix the history back button problem monday am since i'll be working uk time so hopefully that will be possible to push in the beta [17:28:23] jdlrobson: thanks [17:28:40] jdlrobson: k [17:28:56] awjr: preilly MaxSem : we should pick a cut off date so that jon knows that time his changes have to come in by [17:28:57] jdlrobson: sneak preview with a beta URL, in other words [17:29:12] in order for them to get reviewed, deployed, etc [17:29:24] basically yeh - taking advantage of it's easy to click a link and it's a pain having to opt into a beta with link, button press, find page [17:29:47] jdlrobson: sure, but as soon as they navigate, the UI will change [17:30:48] I know but they'll still be able to get a feel for what it's going to look like and how it feels to use up to that point which is more than we did in the last beta push [17:31:00] awjr: Do you like that show archer? [17:31:01] : Sterling: Conway, wait! Just answer me one question.Conway: Yeah, but make it quick—my ride's here. And your lungs are filling up with blood.Sterling: Did you have sex with my mother?Conway: Wait, what? That is your only question? Not who am I, not how did I infiltrate ISIS, or, or, or who's flying the helicopter?Sterling: Just answer the question!Conway: No, Archer, I didn't have sex with your mom. [17:31:30] jdlrobson: i see, as an incentive to opt-in [17:31:40] \o/ [17:31:51] it's better to have the URL option rather than not, for sure [17:33:05] jdlrobson: thinking we should prioritize the beta opt-in functionality in the UI before we do a big beta push - maybe the one after next Monday [17:33:27] sure.. that was next on my todo list (the settings page) [17:33:34] I'm all for URL options [17:34:30] please portal preview https://meta.wikimedia.org/w/index.php?title=Www.wikipedia.org_template%2Ftemp if you get a chance [17:34:35] (you'll need to resize the window) [17:34:39] can't the beta opt-in functionality in the UI just be next to the random button for now? [17:35:46] the settings page would be pretty much that [17:35:59] just a page with a heading and the beta opt in functionality [17:36:05] jdlrobson: what is the status of https://gerrit.wikimedia.org/r/#/c/7892/ ? [17:36:15] i'm waiting for review preilly [17:36:23] jdlrobson: so that doesn't seem like it would take too long [17:36:23] i'm happy with it [17:36:27] awjr: should take a look [17:36:34] ! [17:36:43] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/7892 [17:36:45] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7969 [17:36:46] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7963 [17:36:47] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7962 [17:36:48] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7892 [17:36:52] preilly: nope shouldn't take that long... depends what's more important for monday am - the back button bug or this [17:36:53] jdlrobson what should i look at? [17:36:57] happy to do either first thng [17:37:05] https://gerrit.wikimedia.org/r/#/c/7892/ < awjr [17:37:08] and MaxSem [17:37:11] if you have the time [17:37:20] oh wow. [17:37:21] i got rid of the it's not as scary as it looks [17:37:27] looks like preilly already merged it [17:37:30] most is just renaming variables [17:37:39] jdlrobson i'll take a quick look [17:37:45] MaxSem: can you fix https://gerrit.wikimedia.org/r/#/c/7670/ please [17:38:06] oh so he did. I'm not expecting any issues awjr if there are let me know and I'll push some further commits [17:38:20] the main ones to look are at the php as everyone knows my php is terrible [17:38:26] jdlrobson i see a couple of small issues in SkinMobile.php [17:38:30] preilly that should not have been merged :( [17:38:32] awjr: like what? [17:38:37] preilly, rebased, waiting for Roan to run the last sanity chack past him [17:38:58] *check [17:39:09] is he at the office, btw? [17:39:13] preilly one sec lemme actually check this out [17:39:29] awjr: just seen some bad whitespace (sorry!) [17:39:36] yeah there's that [17:39:37] awjr: I just saw whitespace [17:40:08] line 178 should be removed [17:40:23] but it is benign [17:40:53] New patchset: preilly; "remove whitespace" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7972 [17:40:53] MaxSem: sweeet! :) [17:40:59] heya tfinc [17:41:08] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/7972 [17:41:10] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7972 [17:41:24] want to rebase and for me to resubmit? [17:41:56] jdlrobson: no [17:42:00] k [17:42:10] yeah besides that SkinMobile.php looks better [17:42:19] awjr: you want $frontend = $this->extMobileFrontend; removed? [17:42:19] does ArcherBot want to fire an arrow at me? [17:42:20] : Malory: Have I made myself clear?Sterling: You're looking for the word yes.Malory: Yes.Sterling: Then, yes. [17:42:25] jdlrobson: yeah, that was me responding from my mobile (tricorder) [17:42:32] :) [17:42:32] preilly yeah [17:42:43] YuviPanda: yo [17:43:00] heads up that i'm feeling pretty crappy and will head home likely around noon [17:43:04] New patchset: preilly; "remove unneeded frontend reference" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7973 [17:43:05] anything else you want from me before I go.. YuviPanda very sorry but the saved pages is going to have to wait now [17:43:15] jdlrobson: ok :( monday? [17:43:17] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/7973 [17:43:19] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7973 [17:43:31] tfinc: sorry to hear that [17:43:41] tfinc: I hope you feel better soon [17:43:52] tfinc: I'm waiting for jdlrobson to merge in saved pages before rolling RCs. Bugzilla list is zero for 1.2 besides that. Should start on WLM from Monday [17:43:54] tfinc bummer - i hope it doesn't mess up your weekend [17:43:56] yup YuviPanda will make it my priority.... i still think we need tests though.. migrations of data are scary [17:43:58] * YuviPanda pokes tfinc with a 'get better' stick [17:44:00] feel better little guy [17:44:03] thanks guys [17:44:11] aww .. thanks ArcherBot [17:44:11] : I'm not saying I invented the turtleneck. But I was the first person to realize its potential as a tactical garment. The tactical turtleneck! The... tactleneck! [17:44:12] jdlrobson: true. But that's a rabbit hole [17:44:15] lol [17:44:15] good luck getting better tfinc [17:44:17] lolz [17:44:20] so many ArcherBot lolz [17:44:20] : See that? He was putting on his pants, and I stopped him. So you just watch your step, mister ... dammit. [17:44:21] a good rabbit hole YuviPanda [17:44:32] jdlrobson: agreed, but a rabbit hole nonetheless :) [17:45:17] jdlrobson: and not one I would want to touch right now, since this now goes into 'maintenance mode' and I go to the WLM app for a while. [17:45:25] jdlrobson: 1.3! [17:46:00] come on YuviPanda ! http://www.alice-in-wonderland.net/alicepic/disney-movie/alice-in-front-of-rabbit-hole.jpg [17:46:47] jdlrobson: tempting, but not for 1.2 :D [17:48:04] jdlrobson, could you pngcrush you images before committing? they usually can be much smaller [17:48:34] this is required reading http://en.wikiquote.org/wiki/Archer_(TV_series) for the mobile team [17:49:02] MaxSem: well you can do it for him now [17:49:04] :) [17:49:05] New patchset: MaxSem; "Compress images" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7974 [17:49:16] exactly what I'm doing [17:49:17] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/7974 [17:49:19] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7974 [17:49:38] MaxSem: I know that is why I said it ;) [17:51:21] or http://radsoapco.files.wordpress.com/2011/07/down_the_rabbit_hole4.jpg [17:51:29] any other os x users have problems with firefox randomly devouring all your cpu cycles? [17:51:43] awjr: yup. Kills battery on my Air [17:51:52] awjr: means I have no choice but to use chrome [17:51:56] wtf is that about [17:52:00] in general is a hog [17:52:04] and then suddenly it'll spike [17:52:18] awjr: that's just firefox being firefox :) [17:52:32] sigh [17:52:47] awjr: take a look at http://support.mozilla.org/en-US/kb/Firefox%20consumes%20a%20lot%20of%20CPU%20resources [17:53:09] wow thanks ArcherBot [17:53:09]