[09:38:17] New patchset: Jdlrobson; "limit hash changes by using replaceState (bug 36848)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8311 [10:20:15] New patchset: Jdlrobson; "tests: follow up to Change-Id: I9d19f7530a29abeaec026ea1d58dd44652c4cea0" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8313 [10:22:08] * YuviPanda looks around [10:23:02] hello jdlrobson [10:23:06] hey YuviPanda [10:24:00] jdlrobson: any chance of looking at the saved pages code today? [10:24:08] yup its on my todo list [10:24:15] sweet [10:24:41] just exploring some mobile site bugs [10:34:38] New patchset: Jdlrobson; "follow up to Id8cbcffd443ed4d27be58c5a7fd675cb9aee32cc" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8314 [11:15:45] * YuviPanda reads through WLM discussions on their ML [11:16:52] YuviPanda: have you seen the android usertesting video yet? [11:17:10] Thehelpfulone: No! I saw the iPhone one. [11:17:16] they had twitter integrated on their phone but it was't showing as a sharing option [11:17:16] didn't see it on mobile-l. Link? [11:17:37] it's got private data so it's not going to go on the ml or wiki [11:17:55] oh :| [11:18:12] Thehelpfulone: sharing on android is completely handled by the operating system. Perhaps they were using Twitter on web browser? [11:18:17] hmm, I think Phil should be passing it on to you [11:18:32] Yuvi, nope, they explicitly said that it was integrated with their phone [11:19:44] Thehelpfulone: are there ways to contact the user? They could try sharing from other apps, and if twitter doesn't show up there, it's an OS issue. If it does, then that is a very, *very* weird app issue [11:19:53] i'll poke phil when he's up [11:20:16] yes, you can send them a follow up question - yeah poke Phil he'll give you a link to the video [11:20:23] will do! [11:20:32] we also have a test done on the iPad, that was quite good too - but Read it Later fails :( [11:21:08] I can PM you the link to that one, no private data and it will be going on wiki soon I think [11:21:33] Thehelpfulone: RIL has been flaky on their end. Not answering support requests at all. I'm considering removing it [11:21:42] see pm YuviPanda, nice long 18 min video [11:21:47] yup, got it! [11:21:57] yeah the reason I put it in a test was to see if people could figure out how to use it [11:22:06] they also changed their name to 'Pocket' [11:25:58] Thehelpfulone: I think it is confusing too. I'd probably remove it for RC [11:27:05] yeah, and I'm surprised we don't have a share via email or text message option on iOS [11:28:48] Thehelpfulone: we essentially bolted on the easiest to bolt on ones :) [11:29:05] email was hard? o_O [11:29:06] our initial cut had a lot more sharing features, but the library was festering - completely unmaintained and buggy [11:29:27] http://getsharekit.com/ [11:30:34] Thehelpfulone: on iOS we need to build the entire UI ourselves. There is no way to just 'farm it out' to the local email app like you can on android [11:31:06] hm, that's odd [11:31:14] so this get share it says it allows email? [11:31:29] Thehelpfulone: yes, it does. except that it doesn't work :) [11:31:35] all of sharekit is completely buggy [11:31:37] heh [11:31:48] we had to completely rip it out and replace it with manual implementations of facebook, twitter and RIL [11:32:43] Thehelpfulone: iOS will also always be slower than comparable android devices - Apple disallows JIT on Javascript in any app that is not Safari, so our javascript will be *much* slower on iOS than on Android [11:56:25] hi YuviPanda [11:56:31] hi aude [11:56:44] YuviPanda: quick question..... [11:57:04] sure! [11:57:05] we're finalizing the wikimania schedule and want to know if you are still plannign to come? [11:57:21] * aude needs to poke the other mobile people too [11:57:29] aude: yup! [11:57:36] YuviPanda: great [11:57:52] we need you to fill out a short form, with an abstract for the program [11:58:07] I think I got that email and filled it in a long time back? [11:58:13] https://docs.google.com/spreadsheet/viewform?formkey=dFlFbGEyNHBYcmppa0d5Z3U3emNQVGc6MQ#gid=0 [11:58:16] let me check [11:58:36] ok, it says "only if i get a scholarship" but you're coming [11:58:40] so we're good [11:59:03] and we might need another 1-2 sentences [12:00:00] YuviPanda: and you're coming to berlin, right? [12:00:03] aude: yup! [12:00:10] good :) [12:00:19] aude: have a visa interview on 25th. Everything looks good :) [12:00:26] try to get maps rendering setup by then [12:00:43] i'm on labs for wikidata so know how it works now [12:00:56] New patchset: Jdlrobson; "link to contact us from navigation menu" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8319 [12:01:36] sweet! [12:01:37] alright, i'll wait for tfinc and kul to come on later [12:03:28] New patchset: Jdlrobson; "include hash in menu links, keep navigation menu open when following links" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8320 [12:04:08] New patchset: Jdlrobson; "improve styling of Special:MobileOptions/BetaOptIn with bottom margin" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8321 [12:16:02] New patchset: Jdlrobson; "update Makefile for navigation js" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8323 [12:19:17] New review: Nikerabbit; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/8323 [12:22:30] New review: Nikerabbit; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/8321 [12:23:56] New patchset: Jdlrobson; "prevent default to avoid bad user experience with back button" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8324 [12:24:43] New review: Nikerabbit; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/8314 [12:28:03] New review: Nikerabbit; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 2; - https://gerrit.wikimedia.org/r/8311 [12:52:42] New patchset: Jdlrobson; "make entire link clickable in main menu" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8327 [12:52:43] New patchset: Jdlrobson; "close action bar on clicking link in content of overlay" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8328 [13:50:49] YuviPanda: can you fix up the merge conflicts on https://github.com/wikimedia/WikipediaMobile/pull/246 [13:51:13] hmm, there are merge conflicts? [13:51:14] * YuviPanda looks [13:52:32] fuck, brion's pushed a *lot* of changes to master :| [13:58:02] jdlrobson: done [13:58:06] thanks YuviPanda [14:04:36] kk YuviPanda few issues [14:05:02] shoot! [14:05:13] so YuviPanda first things first - get the user to confirm the migration step. It's quite scary loading the app and straight away see the screen for migration without any say in the matter. Especially if I'm on a 3G connection and have a limited data allowance [14:05:31] New review: Nikerabbit; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 2; - https://gerrit.wikimedia.org/r/8025 [14:05:57] hmmm, agreed. [14:06:37] secondly it seems quite slow [14:06:42] to the point i worry it is frozen [14:06:55] it's been updating Bob Marley for about 1 minute so far [14:07:05] it might be nice to allow me to cancel it [14:07:05] jdlrobson: what version did you update from? [14:07:19] YuviPanda: upgrading from the commit before this [14:07:29] jdlrobson: ah, so this upgrades from v1.1.1 [14:07:40] (and various articles I've saved since I first started to using the app) [14:07:40] it isn't upgrading for a long time, it has completely errored out :) [14:08:03] well we need to think about users that have been testing and saving articles with the beta versions right? [14:08:30] hmm, now that there's a version of the beta on the store, you're right. [14:08:36] let me fix that. [14:08:39] cool [14:08:43] those issues aside it looks good [14:08:53] I had completely forgotten about that. Usually we just ask people to uninstall and reinstall for betas [14:08:59] the user just needs more say in the process [14:10:58] jdlrobson: the say is essentially 'now' or 'next startup' [14:11:12] but wil ss [14:11:14] *add [14:14:17] yup [14:14:18] that's fine [14:14:21] just give the choice :) [14:34:05] sorry, shitty internet [15:06:56] hmm, I wish some form of deferreds were integrated into js [15:14:22] too many levels of indenting [15:14:24] * YuviPanda stabs self a bit [15:24:42] damn [15:24:44] just missed jon [16:17:02] New patchset: MaxSem; "Mobile script delivery via ResourceLoader" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7670 [16:38:04] greetings all [16:38:46] hi tfinc [16:39:31] tfinc: there's a usertesting.com video on the wikipedia app on android which needs a review, but it's got private details so it's not going to go on wiki - have you got login details? [16:40:50] Thehelpfulone: ask phil about it when he gets in. he has those details and should be in in the next 30min [16:41:04] jdlrobson: https://bugzilla.wikimedia.org/show_bug.cgi?id=30389 is getting a bit lengthy for a bug [16:41:14] tfinc: I have the details, I meant to ask if you had access :) [16:41:18] anytime design issues are thrown into bugs its gets a bit unruly [16:41:43] Thehelpfulone: i'm sure i have them somewhere deep in the recesses of my inbox [16:42:37] heh, when Phil comes in ask him for a reminder ;) [16:43:13] maplebed: does your copy of linkinus ever stop updating the full chat window and only updates it in place ? [16:43:27] maplebed: its likely easier to just show you [16:45:53] jdlrobson: i've been watching that bug on the periphery to see what you guys come up with vs whats been discussed in the past [16:46:31] jdlrobson: one key difference from our previous discussions is that showing all possible languages hurts rather then actually helping [16:46:49] jdlrobson: the overwhelming amount of choices produced confusion in almost every user test we did [16:46:54] jdlrobson: and that was on the desktop [16:47:03] jdlrobson: imagine it on a smaller screen [16:47:09] so tfinc what would you suggest? [16:47:56] make the page smarter but auto detecting the users location and showing them languae prefs relative to our squid country breakdown report [16:48:00] s/but/by [16:48:10] tfinc: i **hate** that with a passion [16:48:22] the amount of times I've sweared when travelling and google forces me on to a country specific page [16:48:23] allow wiki admins to ovewrite that with anything additional languages they feel are missing [16:48:51] and people hate being overwhelmed with languages with a passions [16:48:55] so we have to solve that too [16:49:06] oh sorry i misunderstood - you mean just limit the list? [16:49:08] keep in mind that this is not a priority right now. nav is [16:49:10] correct [16:49:21] yup it just seemed like low hanging fruit. Nav is coming along nicely. [16:49:35] we'd adjust the languages listed wherever its present on the portal page [16:51:10] so the problem that needs to be solved eventually is that almost all users who visit the portal page don't need 98% of the languages listed and it more confusing rather then helpful to list them as is [16:52:30] hangout is up https://plus.google.com/hangouts/_/3e7b4d5b78d9edc06e5a29d47f35feb439739354?authuser=1&hl=en [16:53:39] * YuviPanda looks around [16:53:39] hey YuviPanda https://plus.google.com/hangouts/_/3e7b4d5b78d9edc06e5a29d47f35feb439739354?authuser=1&hl=en [16:53:44] yo brion [16:53:57] hey tfinc [16:53:58] * YuviPanda clicks [16:54:29] my conneciton seems to be extra laggy today :( [16:54:40] * YuviPanda clicks again [16:54:53] we all welcome the black rectangle to the hangout [16:55:20] it has errored out twice so far [16:55:30] 'there was a problem with the page, please try reloading' [16:56:06] YuviPanda: must be on your end as MaxSem joined just fine [16:56:14] yes, on my end [16:56:21] jdlrobson: is the link working for you? [16:56:24] i have 2,000 ms ping times :| [16:56:44] YuviPanda: yeah thats going to work poorly at best [16:57:34] tfinc: language problem sounds like a job for javascript [16:58:27] haha g+ thinks the sound of the tuk tuk is me talking [16:58:33] 100ms ping [16:58:34] whee [16:58:45] mornin [16:58:47] hangout url? [16:59:05] awjr: https://plus.google.com/hangouts/_/3e7b4d5b78d9edc06e5a29d47f35feb439739354?authuser=1&hl=en [16:59:45] inappropriately cut off user name [17:03:49] how much of that did you guys get? [17:11:40] hey philinje [17:11:58] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/7670 [17:12:00] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/7670 [17:12:16] jdlrobson: was that on updating from beta or from 1.1.1/ [17:12:16] ? [17:12:38] mixture.. i forget [17:12:48] some are likely to be saves not from releases [17:13:05] but the fact is they are greyed out.. if there's not a problem with them they shouldn't be greyed out [17:13:07] jdlrobson: the testing I did last week was all from releases to this, rather than from beta. [17:13:14] yes, I'm fixing that now [17:13:34] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/8025 [17:13:36] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8025 [17:13:54] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/8026 [17:13:56] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8026 [17:14:07] awjr: preilly hows todays deployment look? [17:14:13] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/8027 [17:14:15] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8027 [17:14:28] tfinc_meetings: preilly will be doing today's deployment [17:14:36] tfinc: looks fine [17:14:48] MaxSem: will you be shadowing todays deployment ? [17:14:59] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/8313 [17:15:01] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8313 [17:15:26] tfinc, I'll try to but I had to get up early today [17:15:33] philinje: can you respond to the email from 'Takamura' [17:15:40] #1 already has a bug open [17:17:56] MaxSem: well we should either plan for you to be there or not. anything in between just creates extra work. its better to say that you wont be around for it and do it next week then to find out that you cant make it last minute. preilly awjr i'll leave this one with you guys to coordinate [17:19:51] awjr & preilly, will we collide if I change DeviceDetection right now? [17:20:07] MaxSem are you changing it to what you showed me on friday? [17:20:13] yes [17:20:21] MaxSem also are you making the change in core or in the ext? [17:20:23] or both? [17:20:28] both [17:21:08] MaxSem I dont think it should be a problem for me, i'll just try and keep an eye on the changes you're making [17:33:42] jdlrobson: philinje: is the nav beta going up today? [17:35:38] tfinc: yes it's been reviewed [17:35:57] obviously not fully functional yet [17:36:28] jdlrobson: yup, i'm assuming it'll look like what ive seen in the prototypes [17:36:45] menu, contents, languages, and everything else disabled [17:36:51] oh random [17:38:43] YuviPanda: hows is RC1 looking ? [17:38:59] tfinc: final tweaks for jdlrobson. [17:39:02] how difficulty are the bugs that you mention in your standup [17:39:22] tfinc: the tiny but annoying variety [17:39:23] tfinc: yup [17:39:35] k [17:39:46] i seem to have fixed them :) [17:39:50] jdlrobson: updated pullr eq [17:39:51] *req [17:40:08] Thanks YuviPanda [17:41:07] New patchset: Jdlrobson; "settings page (incomplete early prototype)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8343 [17:41:24] preilly, are you going to deploy the ResourceLoader change today? [17:41:24] tfinc: I'm going to remove 'Share to Read It Later'. Those guys have not responded to bug reports at all, plus as Thehelpfulone pointed out, it seems to confuse many people. [17:41:48] New review: Jdlrobson; "Publishing this for review and assistant from MaxSem" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/8343 [17:41:49] YuviPanda: yep thanks, and philinje will be sending you the link to the android video [17:42:02] YuviPanda: aww ... ok. i always hate removing features but if its broken then we can't keep it [17:42:12] it's broken + the devs ain't responding [17:42:14] right I'm off now. YuviPanda will look at pull request first thing tomorrow [17:42:19] YuviPanda: chuck it [17:42:21] okay! [17:42:24] yeah, doing that [17:42:29] hello brion! [17:42:43] tfinc: if only convincing you to ditch saved pages was this easy :P [17:42:50] :D [17:43:03] that reminds me, the betas would have been sending us data now [17:43:08] * YuviPanda pokes drdee2 [17:43:19] fancy, did you sync up with phil so that he knows what were doing ? [17:44:11] tfinc: so I don't even know if that works, since we've not checked the clicktracking logs yet :D [17:44:17] New review: MaxSem; "(no comment)" [mediawiki/extensions/MobileFrontend] (master) C: 0; - https://gerrit.wikimedia.org/r/8343 [17:44:29] every time I remember it I seem to not be able to catch any of the analytics team [17:44:35] * YuviPanda goes to staff list to see who else to catch [17:44:40] howdy yuvi [17:44:47] jdlrobson??? [17:45:12] heya brion [17:45:21] brion: looks like i'll be pestering you for CR in WLMMobile :) [17:45:56] brion: i already made a tiny pull req a while back. I'm running around the codebase now, figuring how things work [17:45:57] YuviPanda: also, if your turning on *any* analytics then make sure to talk wiht phil so that we can clear it with legal [17:46:20] MaxSem: Jon had to run off today/night [17:46:20] tfinc: yes, but we talked about this to legal when we had the discussion first [17:46:27] you talked to howie, etc, IIRC [17:46:32] howie isn't legal [17:46:42] YuviPanda: click-tracking is enabled now? [17:46:44] get phil to wrangle legal for you [17:47:00] philinje: not click tracking, we're using the clicktracking api to count the number of people saving pages [17:47:06] the number of pages being saved, to be exact [17:47:20] ah, i see, cool [17:47:49] philinje: so tfinc wants you to clear that with legal. shall i write an email explaining what exactly we track? [17:47:57] what else is saved/tracked - would user agent be attached to the saved pages data? [17:48:00] YuviPanda, excellent, i'll peek in a bit [17:48:10] yes, that's better, thanks [17:48:44] brion: thanks! [17:48:47] YuviPanda: will email you the android test, can't be sent publicly because the guy's personal info is right there in the video [17:48:59] ah ok [17:49:04] thanks philinje [17:49:36] brb [17:49:47] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/8319 [17:49:49] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8319 [17:49:51] BTW, a comment from an iPad user/tester: I was unable to "Save to Read it Later". When I got to the form to sign up for that feature, it would not let me type in the form, so I found that to be frustrating. It made me think that the app was released before all of the kinks were worked out [17:50:06] philinje: see my message earlier about the feedback from 'Takamura' ? [17:50:15] MaxSem: can we push the resource loader change today? [17:50:19] here on IRC? [17:50:27] philinje: mobile-feedback [17:50:38] hang on [17:50:53] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/8320 [17:50:56] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8320 [17:51:11] preilly, it depends on a core change, so you'll have to cherrypick it, too [17:51:22] * MaxSem looks if it's an easy thing to do [17:51:33] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/8323 [17:51:52] MaxSem: the core change has already been approved [17:52:14] preilly, but it's not live yet on both WMF branches [17:52:19] MaxSem: and merged but is it in production yet [17:52:30] MaxSem: are you sure? [17:52:39] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/8323 [17:52:49] it was last week [17:52:58] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/8321 [17:53:00] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8321 [17:53:06] tfinc: found Takamura's email, not yours, nice [17:53:13] MaxSem: what is the url to the core change [17:53:34] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/8324 [17:53:36] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8324 [17:53:59] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/8314 [17:54:01] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8314 [17:54:20] preilly, https://gerrit.wikimedia.org/r/#/c/7302/ [17:54:25] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/8311 [17:55:28] MaxSem: thanks [17:55:28] it's not live even on wmf3: https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=history;f=includes/resourceloader;hb=f4ebd67fd264071a89f4b514e7adc39f318b6671 [17:55:42] but it should be cherrypickable [17:56:22] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/8327 [17:56:40] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/8328 [18:06:08] bback [18:11:55] New patchset: preilly; "make entire link clickable in main menu" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8327 [18:12:11] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/8327 [18:12:14] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8327 [18:16:41] New patchset: preilly; "close action bar on clicking link in content of overlay" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8328 [18:17:00] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/8328 [18:17:02] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8328 [18:19:04] New patchset: preilly; "limit hash changes by using replaceState (bug 36848)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8311 [18:19:17] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/8311 [18:19:19] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8311 [18:21:11] Change abandoned: preilly; "CONFLICT (delete/modify): Makefile deleted in HEAD and modified in update Makefile for navigation js..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8323 [18:38:31] awjr & preilly, https://gerrit.wikimedia.org/r/#/c/8350/ [18:48:18] MaxSem: what do you mean by, "Stuff that needs to die [18:48:19] such as css_file_name has not been exposed for new interfaces"? [18:49:34] I intend to incapsulate RL modules support into these classes, so just CSS files make no sense [18:56:13] [WikipediaMobile] brion pushed 1 new commit to master: http://git.io/DsTuKg [18:56:13] [WikipediaMobile/master] Win8: fixes for snapped mode - Brion Vibber [19:01:03] Thehelpfulone: i've removed RIL with https://github.com/wikimedia/WikipediaMobile/pull/247 [19:01:23] ok, did you get a chance to watch that android video? [19:01:45] Thehelpfulone: nope, am on a connection that won't give me a sane video experience. Will do tomorrow morning [19:01:55] sure [19:02:07] thanks! [19:07:22] * YuviPanda continues being on the way to another city for visa stuff [19:12:42] okay, I'm off. [19:12:42] gnite everyone [19:21:48] MaxSem: is X-DEVICE support messed up in master? [19:23:35] * MaxSem looks [19:25:10] awjr: when you get a chance can you look at https://bugzilla.wikimedia.org/show_bug.cgi?id=36383 and verfiy [19:26:34] MaxSem: okay it works it just changed a bit [19:26:39] preilly, just tried setting this header manually in Dragonfly - looks [19:26:43] normal [19:27:01] preilly, what have changed? [19:27:05] philinje: what was the bug number for the startup help page ? [19:27:07] in the app [19:27:39] MaxSem: HTT_X_DEVICE used to work [19:27:44] MaxSem: but doesn't anymore [19:27:57] nm found it [19:27:58] MaxSem: I had to change my htaccess to have X-DEVICE now [19:30:27] preilly, what function_exists( 'apache_request_headers' ) outputs for you? [19:31:00] tfinc: i can't actually confirm the issue as i don't have ICS 4.0.4. wikipedia on chrome beta works fine as far as i can tell on 4.0.2 [19:31:52] MaxSem: php -r ' var_dump(function_exists("apache_request_headers"));' [19:31:53] bool(false) [19:32:32] preilly, from the web, it shouldn't exist in CLI [19:32:56] bool(true) from web [19:35:48] s/ HTT_X_DEVICE/HTTP_X_DEVICE [19:36:00] but I think that you knew what I meant [19:43:31] preilly, you used htaccess to set $_SERVER directly? [19:44:15] MaxSem: yes [19:44:21] MaxSem: RequestHeader set X-DEVICE webkit [19:44:51] preilly, the code now uses WebRequest which pulls the headers directly from Apache if possible [19:46:06] MaxSem: okay, got it [19:47:09] preilly: can you respond to dans email about 'New Partner - Zero/m.' sent 5/17 [19:59:34] hi tfinc [20:03:00] tfinc: I already did respond to him in person about it [20:03:55] preilly: is kul around? [20:04:14] aude: he is in the office [20:04:43] ok [20:05:09] we are finalizing the wikimania schedule [20:05:35] want to figure out the mobile sessions and get a short abstract from him [20:05:41] * aude can email [20:05:49] aude: email is probably the best [20:06:05] ok [20:10:00] Reedy: http://www.newegg.com/Product/Product.aspx?Item=N82E16820148530 [20:12:07] Reedy: thats the 7mm version of what i have. mine continues to be the awesome [20:22:57] tfinc: for your wikimania talk, could you give us a short abstract (sometime by tomorrow)? [20:23:04] https://docs.google.com/spreadsheet/viewform?formkey=dFlFbGEyNHBYcmppa0d5Z3U3emNQVGc6MQ#gid=0 [20:23:11] kul also [20:24:24] New patchset: L10n-bot; "Localisation updates from http://translatewiki.net." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8384 [20:28:49] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/8384 [20:28:51] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8384 [20:29:06] tfinc: so for sure you are doing my talk? [20:29:26] aude: shoot me an email with what you need from me ... i'm in the middle of something [20:29:44] tfinc: ok [20:29:52] preilly: im happy to if erik has no more budget to send more staff members [20:29:53] it's basically, the google doc form [20:32:06] New patchset: awjrichards; "Update new contact form for forward-compatibility with pending HTMLForm updates in core" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8404 [20:44:18] [WikipediaMobile] brion pushed 1 new commit to master: http://git.io/I1QwUg [20:44:18] [WikipediaMobile/master] Win8: snapped mode fixes, listview fixes - Brion Vibber [21:06:46] good night everyone [21:12:13] [WikipediaMobile] brion pushed 1 new commit to master: http://git.io/3XF35g [21:12:13] [WikipediaMobile/master] win8: basic offline detection - Brion Vibber [21:29:22] great, my nick got blacklisted or something for failing to auth [21:29:23] wheeeee [21:40:13] whee got my nick fixed [21:46:31] preilly: is dan all setup on labs? [21:46:56] tfinc: I sent him the forms [21:47:09] tfinc: I don't know if he finished filling it out [21:57:19] awjr: http://test.m.wikipedia.org/ [22:03:05] preilly the contact form is posting remotely, but it does not appear to be using the API user [22:05:28] preilly im not seeing $wgMFRemotePostFeedbackUsername in common settings [22:06:57] hmm although it appears to be posting correctly from enwiki [22:09:59] awjr: PrivateSettings.php:$wgMFRemotePostFeedbackUsername = "mobilefrontend"; [22:10:09] hmm [22:10:21] awjr: those credentials are in PrivateSettings.php [22:10:24] preilly isn't PrivateSettings.php being included before MobileFrontend.php? [22:10:29] in /home/wikipedia/common/wmf-config [22:10:52] preilly yeah, but if it gets included before MobileFrontend.php, MobileFrontend.php will overwrite the variables [22:11:00] CommonSettings.php:require( "$wmfConfigDir/PrivateSettings.php" ); [22:11:30] CommonSettings.php:191:require( "$wmfConfigDir/PrivateSettings.php" ); [22:11:49] CommonSettings.php:2336: require_once( "$IP/extensions/MobileFrontend/MobileFrontend.php" ); [22:13:07] preilly maybe change the $wgMF variables in PrivateSettings.php to $wmgMF vars and assign them to the $wgMF vars after MobileFrontend.php gets included? [22:16:22] should the nav box in the beta collapse after selecting a menu item (eg random)? [22:16:27] awjr: already changed it [22:16:57] also, i'm seeing one of the nav items below the footer (settings) even when the nav box is closed [22:18:09] the beta nav has some issues [22:18:36] after you close the nav box, the hash is left in the URL, so refreshing the page will load the page with the nav box expanded [22:19:21] i think that's the same reason the nav box doesn't close after you select an item - the #mw-mf-page-left hash is left on the URLs for the nav items [22:20:44] awjr: oka [22:20:45] y [22:25:37] awjr: can you refresh and try it again [22:26:02] http://www.mediawiki.org/wiki/Extension:MobileFrontend/Deployments/2012-05-21 updated [22:27:55] preilly opting in to the beta on test is redirecting me to test.zero.wikipedi [22:28:42]