[00:02:04] yeah, i've been following this [00:15:28] tfinc: you mean track page views of the editing article? [00:19:07] philinje: tracking existing edting on mobile devices [00:19:14] specifically looking at tablets [00:21:15] ah, good idea [00:24:29] preilly: http://www.meetup.com/jsmeetup/events/64906452/?a=cr1.2_grp&rv=cr1.2&_af_eid=64906452&_af=event [00:24:39] * preilly clicking [00:25:00] extra fun since Krux is sponsoring [00:34:14] preilly: http://mlb.sbnation.com/2012/5/21/3033910/att-park-field-stormer-scenetap-advertisement [02:03:06] * YuviPanda looks around [02:06:24] hi [02:06:39] heya devgeeks [02:06:51] TIL I'm an idiot who needs to grow more brains. [02:06:59] lol [02:07:04] Why is that? [02:07:07] devgeeks: assumed that I needed to provide full UI for 'share via email', then realized that mailto: links exist [02:07:17] hahaha [02:07:42] Well, the only issue with mailto: is if they don't use Mail.app for their email [02:07:46] devgeeks: also we just killed RIL integration. Too buggy, unresponsive devs plus confusing [02:07:54] Yeah [02:08:00] I don't blame you :( [02:08:17] me neither :P [02:08:18] Maybe they will make a new SDK for pocket that is less sucky and we can try again [02:08:23] maybe [02:09:29] Or rewrite it in REST [02:09:58] But that would mean writing a login UI [02:09:59] :/ [02:12:10] But I would avoid them till their api at least says pocket... mid-rename is too flakey [02:18:51] devgeeks: yeah, i already got rid of them [02:19:13] and I'd be wary before giving them a go again [02:20:20] yeah [02:20:26] Evernote? ;) [08:48:56] MaxSem: $wgMFConfigProperties = array( 'isBetaGroupMember' => true ) is no longer turning beta on for me in LocalSettings - did we throw that away on purpose? [08:49:31] jdlrobson, yo [08:49:49] this whole thing has been seriously revamped [08:49:59] * jdlrobson listens [08:50:05] now you'll have to... [08:50:25] (also were you involved in deployment yesterday... not 100% sure I understand what all the issues were) [08:50:28] $wgExtensionFunctions[] = 'efMyFunction'; [08:50:50] no, I was asleep [08:51:32] function efMyFunction() { MobileContext::singleton()->setBetaGroupMember(true); } [08:52:11] jdlrobson, do you know that W3C's validator doesn't approve your mobile options form? [08:52:31] i'm sure it doesn't ... it's still very rugged [08:52:37] i'm playing around with markup and css [08:52:49] hence I marked as early preview ... long way from being merged [08:52:56] yeah [08:53:08] I'm guessing checkboxes in labels are not allowed for example :) [08:53:46] are you able to do the php side of that form? e.g. create a basic form without styling that can set those options? [08:53:49] I've started working on it, but wonder if I should do the backend stuff before there's mature HTML or not [08:54:33] I don't think we need mature HTML. Just checkboxes for all the settings. I'm assuming your use a HEREDOC for html anyhow so I can tweak that if need be [08:55:40] nah, I wanted to use HTMLForm to take advantage of its XSRF protection and other niceties [08:56:21] in its present state, your HTML will require a custom field class [08:57:11] ohhh i see [08:58:52] MaxSem: > http://www.mediawiki.org/w/index.php?title=Extension:MobileFrontend&oldid=538600&diff=cur&shownotice=1#Configuration_settings [08:59:48] also http://www.mediawiki.org/w/index.php?title=Extension%3AMobileFrontend&diff=540180&oldid=540179 [09:01:40] New patchset: Jdlrobson; "remove note about needing to minify js" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8441 [09:02:59] jdlrobson, and why did you add a core variable to our manual? [09:03:50] because I'm an idiot? :) [09:03:58] How best to document turning on/off beta? [09:04:20] to a faq/howto? [09:18:38] jdlrobson, was the change to SkinMobile intentional? [09:18:49] which change was that? [09:20:03] options form [09:20:20] https://gerrit.wikimedia.org/r/#/c/8343/1/skins/SkinMobile.php [09:21:11] oh no it was just so I could hack a form in. I had no idea of the best way to do it. [09:21:52] I'm not a php developer yet.. will be working on fixing that with preilly when I get to SF ;-) [09:22:04] brb just grabbing some breakfast [12:42:34] New patchset: Jdlrobson; "hide the left panel on smaller pages" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8450 [12:42:34] New patchset: Jdlrobson; "limit hash links to ones in content" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8451 [12:42:35] New patchset: Jdlrobson; "optimise navigation for smaller screens with media query support" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8452 [13:57:51] New patchset: Jdlrobson; "disable action bar menu items when no languages / contents" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8458 [14:00:15] [WikipediaMobile] jdlrobson pushed 2 new commits to master: http://git.io/ZAZmLQ [14:00:15] [WikipediaMobile/master] Removed Share to Read It Later from iOS App - YuviPanda [14:00:15] [WikipediaMobile/master] Merge branch 'master' of github.com:wikimedia/WikipediaMobile - Jon Robson [14:55:42] New patchset: Jdlrobson; "link up contact us page to main menu" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8460 [15:04:09] jdlrobson, is it possible to swap a checkbox with its label via CSS? [15:04:34] what do you mean? swap position? [15:05:18] was [x] Boobooboo [15:05:25] ... you can float it into another position under certain circumstances or if its fixed width/height position it but it's all a bit hacky [15:05:32] I want Boobooboo [x] [15:05:55] so yes theoretically you could but its a pain. [15:06:07] I'm using absolute positioning in the settings page anyway [15:06:10] so not a problem for me [15:06:19] but I'll need a wrapper for the label and input [16:34:35] New patchset: Jdlrobson; "settings page (incomplete early prototype)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8343 [16:35:16] New review: Jdlrobson; "Do not merge. Stable html and css." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/8343 [16:35:20] MaxSem: ^ not for merging but the html is pretty stable now [16:35:57] * MaxSem looks [16:40:40] * YuviPanda comes back from a horrendous day with a lot of paperwork for getting readmission to Googl [16:40:43] fuck [16:40:47] I mean, readmission to College [16:40:52] I have no idea why I said Google [16:44:07] even more than for getting admission into Germany? [16:44:40] MaxSem: possibly, because I needed to go run around around the same place a lot more [16:44:51] MaxSem: besides, getting admission into germany is at least *useful* [16:47:39] is kul around? [16:48:16] New patchset: Jdlrobson; "settings page (incomplete early prototype)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8343 [16:48:46] New review: Jdlrobson; "Don't merge me. For review only." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/8343 [16:59:53] jdlrobson: did you get all the other stuff fixed? [17:00:02] yup preilly [17:00:12] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/8441 [17:00:14] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8441 [17:00:16] i have 30 mins if you want to quickly check [17:00:32] (and can possibly be available later for any emergencies..) [17:00:46] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/8460 [17:00:48] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8460 [17:01:29] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/8450 [17:01:31] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8450 [17:01:48] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/8451 [17:01:50] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8451 [17:02:07] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/8458 [17:02:09] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8458 [17:02:31] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/8452 [17:02:33] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8452 [17:02:53] jdlrobson: have you updated mobile-testing? [17:03:09] nope having touched mobile-testing [17:03:11] should I have? [17:03:46] jdlrobson: well it's just a good common place to test is all [17:05:25] want me to update preilly ? [17:05:36] jdlrobson: if you don't mind [17:06:28] jdlrobson: actually I can just do it [17:06:31] jdlrobson: it's fine [17:06:34] i'm doing it now [17:06:48] jdlrobson: oh okay [17:06:57] getting merge conflicts so taking longer then hoped [17:07:26] i'm a bit confused to why I'm getting merge conflicts at all.. [17:09:22] New patchset: MaxSem; "settings page (incomplete early prototype)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8343 [17:10:02] New review: MaxSem; "(no comment)" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/8343 [17:10:06] jdlrobson, ^^^ [17:10:13] YuviPanda: are you good for meeting in 15 minutes or so? [17:10:25] philinje: yup! [17:10:27] skype? [17:10:39] yes [17:10:43] sweet [17:10:58] sending out Lindsey's wireframes - draft - by email now [17:11:52] cool MaxSem ! you around tomorrow to take this further (i have to go now) [17:12:01] jdlrobson: later [17:12:08] preilly: test is up to date now [17:12:10] well should be [17:12:23] yep looks good [17:13:29] philinje: cool [17:19:20] New patchset: Jdlrobson; "align search results with left of search box" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8468 [17:26:21] greetings all [17:26:58] hello! [17:27:20] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/8468 [17:27:22] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8468 [17:27:58] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/8404 [17:28:00] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8404 [17:30:45] [WikipediaMobile] brion pushed 1 new commit to master: http://git.io/cbBVDg [17:30:45] [WikipediaMobile/master] Stub promotional images for win8 store - Brion Vibber [17:32:41] YuviPanda: ready? [17:32:57] philinje: yup! [17:33:09] are you on Skype? [17:33:42] philinje: yeah [17:33:56] hmm, it was stuck in some update loop [17:33:58] should be on now [18:11:26] New patchset: MaxSem; "Don't display two similar headings on beta opt in/out forms" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8476 [18:11:48] brion: do you want to poke Chad about migration or shall I? [18:12:12] * YuviPanda goes to turn on noisy fan after 35 mins of no noisy fan [18:14:52] YuviPanda: go ahead [18:14:58] YuviPanda: hows is RC1 looking ? [18:15:25] brion: ok [18:16:23] tfinc: more back and forth with jdlrobson. He's still finding code issues that prevent the last bit from being merged. I couldn't find enough common time with him today, so should be able to fix all his concerns in a few minutes and get it merged tomorrow [18:16:39] it isn't really blocking me, since a lot of it is just waiting for jdlrobson - the last few days our timezone overlap has been sadly minimal. [18:17:44] https://github.com/mtyeh411/mediawiki-bootstrap#readme <-- mobile mediawiki skin [18:22:55] YuviPanda: https://twitter.com/#!/Vign_esh/status/204824951289679872 [18:23:02] * YuviPanda looks [18:23:45] responded [18:24:40] also https://twitter.com/#!/bendycakes/status/204928985547808769 [18:24:54] preilly: how are we looking for todays deployment ? [18:25:33] New patchset: MaxSem; "Refactoring of option cookies" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8479 [18:25:49] hmmm, will test then respond [18:28:29] tfinc: good shape [18:39:38] thanks YuviPanda [18:39:46] :) [18:59:57] hey preilly [19:01:10] drdee2: hey [19:01:39] when do you think we can deploy device detection stuff? [19:02:56] drdee2: probably by end of next week [19:03:39] cool beans! [19:03:49] that's when we are in berlin? [19:04:14] drdee2: yeah [19:05:47] cool, bertrand, the guy from devicemap / apache who we spoke to on the phone a couple of weeks ago will be in berlin that weekend as well [19:05:56] i'll probably have a coffee with him on sunday [19:05:58] drdee2: sweet [19:20:22] YuviPanda: what Android SDK's do you have installed locally? [19:20:51] preilly: 4.0.3, 2.2, 2.3 and 3.0 [19:20:59] though tablet (3.0) perf on my machine sucks majorly [19:22:39] YuviPanda: do we support 2.2 and 2.3? [19:22:45] preilly: yup [19:23:09] so you don't have 3.0 or 3.1 installed? [19:23:39] I have 3.0 installed, but it is unusable (very very slow) [19:33:03] * tfinc noms on his irish/eritrean wrap from https://twitter.com/#!/EireTrea [19:33:21] great new food truck for those of us in SF [19:52:19] irish and eritrean! what a combo [21:11:07] gnite [21:11:29] preilly, what do we use the Application_Version: header for? [21:11:37] MaxSem: nothing anymore [21:11:47] so kill with fire? [21:11:56] MaxSem: you could [21:26:40] bah. Every frigging wiktionary on m.wiktionary I have to reapprove the broken CA... [21:28:09] Amgine, give up and use unsafe connection:P [21:28:31] heh. [21:29:29] #34788 keeps getting duplicate bugs filed, and its been a high priority bug since you filed it in February. [21:29:57] I think maybe someone oughtta fix that... [21:33:38] MaxSem: line 312 (https://gerrit.wikimedia.org/r/#/c/8350/2/includes/DeviceDetection.php) [21:33:51] i suggested changing the var name to $deviceName from $formatName [21:33:56] woops wrong tense [21:33:59] i suggest [21:34:15] but other than that it all looks good [21:34:59] and I changed the function name:) [21:35:16] MaxSem yeah i saw that, looks much better [21:36:16] awjr, updated [21:40:45] w00t looks good, MaxSem [21:48:17] New patchset: MaxSem; "Remove deadbeef" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8506 [21:48:56] are we deploying today? [21:49:00] MaxSem: i was just starting to make MobileFrontend aware of whether or not DeviceDetection exists in core [21:49:12] MaxSem but then realized you might have already done that? [21:49:48] awjr, yes - if a class already registered in autoloader, MF doesn't touch it [21:50:01] MaxSem: i thought we'd be deploying today but i don't see it on the deployment calendar [21:50:12] so not sure [21:50:20] i guess that would be a question for preilly [21:50:36] awjr: it is [21:51:00] awjr: Tuesday, 22:00-23:00 UTC (3pm-4pm PDT): Updated MobileFrontend code (see mw:Extension:MobileFrontend/Deployments) [Patrick, Arthur] [21:51:05] awjr: under ongoing [21:51:21] oh yeah ok [21:51:27] didn't think to look under ongoing [21:52:11] looks like that discussion about a separate Google calendar for deployments have died [21:52:48] imho i think it's ridiculous to expect that we will remember to update both the deployment page AND google calendar items [21:53:12] thus the deployment page should die:O [21:53:12] i try to do both but don't always remember. but i think of the deployment page as the definitive source [21:54:12] there should be some kind of locking on fenari: as long as you have it, it's ok to deploy [21:54:49] i usually just open initialise and common settings so no one else can mess with them :p [21:54:55] but then sometimes i forget to close them :( [21:55:25] open is separate screen sessions? [21:55:31] s/is/in/ [21:55:32] MaxSem yeah [21:56:14] you'll get yelled at though if you forget to close them when you're done [21:56:56] but that leaves the possibility that someone will change something other than the config and then scap happily [21:59:13] it is true [21:59:20] which has happened to me before [21:59:34] and is no bueno [22:00:17] btw, I tried playing with HTMLForm in Special:Userlogin, but discovered that extension compatibility will be hurt badly [22:00:28] why's that? [22:01:05] they depend on it using a template [22:01:56] so I'll have to rewrite the template for mobile compatibility instead [22:03:26] oh yeah [22:03:30] oh well [22:03:39] HTMLForm is kind of a pita anyway [22:04:10] changing half dozen WMF-deployed extensions is no fun either [22:04:34] and who knows how many more obscure extensions will break... [22:05:09] MaxSem you mean from changing the login form? [22:05:32] yes [22:06:14] yeah [22:06:26] preilly, will you teach me? [22:06:35] those templates make my eyes bleed [22:07:13] MaxSem: teach you what? [22:07:24] deployment stuff [22:26:13] MaxSem: Oh, I thought awjr already did [22:27:01] I thought it was supposed to consist of 2 lessons [22:27:44] yeah i believe that's what we said in the email thread about it all [22:33:05] awjr: can you take a look at http://test.m.wikipedia.org/w/index.php [22:34:08] preilly sure thang [22:34:38] oh, it cooled off to 105F outside [22:35:20] is sync-common still needed now that we use RL? [22:37:53] MaxSem: yes [22:38:01] preilly: on the beta, i am seeing the 'settings' item from the nav appearing behind short articles, eg http://test.m.wikipedia.org/w/index.php?title=Special:Search&search=quark [22:38:02] MaxSem: the two mount points are different [22:38:17] awjr: yeah, I'm seeing that still too [22:38:19] :( [22:38:47] awjr: I have a fix for it [22:38:56] awjr: but I thought we would try jon's fix [22:39:06] awjr: can you look at the other stuff that you noticed? [22:39:08] preilly: yeah, i thought you had fixed it yesterday [22:39:09] yup [22:39:16] the table on testwiki's main page scrolls for me on Android [22:39:28] preilly: in ICS, i can no longer scroll to the right when the nav is open (this is a good thing, i think) [22:39:51] preilly: in ICS, when i open the nav on the main page and then close it, the table showing the projects still remains pushed off to the right [22:40:20] im gonna try on froyo [22:41:43] New patchset: L10n-bot; "Localisation updates from http://translatewiki.net." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8533 [22:42:30] whoa on ios, rotating the screen with the nav open makes the nav labels disappear [22:42:36] all i see are the icons [22:42:43] awjr: yeah [22:42:47] on purpose? [22:42:51] awjr: that is something jon added today [22:43:03] awjr: it's the media query change [22:44:40] on froyo, selecting 'random' form the nav will take me to a random page AND collapse the nav on the subsequent page. whereas on ICS, the nav stays expanded [22:44:57] also, froyo does not seem to have the same problem with the nav and tables like ICS does [22:46:16] so yeah still seeing some issues with the beta, but less awful than yesterday [22:49:02] on ios, like on froyo, the nav collapses when 'random' is selected, but not when any of the other items are selected. ics seems to have consistent behavior with the nav remaining open after any nav item is tapped [22:49:32] New patchset: preilly; "fix mw-mf-page-left min height issue" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8550 [22:52:00] i think gerrit-wm is not as verbose as it used to be - for instance it did not announce that ^ was merged [22:55:46] awjr: can you try http://test.m.wikipedia.org/w/index.php?title=Special%3ASearch&search=jjjjj again [22:58:21] preilly: fixed in ics, froyo, ios5 and chrome [22:58:58] awjr: so what are your feelings regarding pushing this live? [22:59:25] preilly: i still haven't tested non-beta [22:59:38] preilly but the beta changes are probably ok to push i guess, since they're beta after all [22:59:45] awjr: yeah [23:00:11] we should really get jon an ICS device so he can test better [23:01:56] awjr: yeah [23:03:01] is there a quick way to clear cookies in safari on ios? [23:03:07] awjr: can you look at non beta and approve [23:03:13] preilly yeah almost done [23:03:16] awjr: clear them in settings [23:03:43] yeah [23:03:55] but no way to do it from the browser itself? [23:04:03] i find ios very confusing [23:04:07] awjr: nope [23:05:00] preilly ok i think the non-beta looks fine to me [23:06:30] MaxSem: what do you think? [23:11:11] awjr: so are you okay for this to go live? [23:11:17] preilly i am [23:11:25] MaxSem: and you? [23:12:28] * preilly — scap 'MobileFrontend Weekly Deployment' [23:19:46] looks good for me [23:20:04] MaxSem: okay, thanks! [23:25:46] awjr: ready when you are [23:26:30] ok tfinc, ready [23:38:42] good night [23:39:21] MaxSem: night [23:50:23] awjr_mtg: does http://en.m.wikipedia.org/wiki/Main_Page look messed up to you? [23:52:03] awjr_mtg: it looks like resource loader is having an issue [23:52:55] preilly: yes [23:53:41] yeah, both beta and non-beta are messed up [23:55:55] awjr_mtg: does http://en.m.wikipedia.org/?p=26 look right to you in the beta? [23:56:56] awjr_mtg: also try http://en.m.wikipedia.org/wiki/Main_Page?debug=true in non beta [23:58:04] beta is still hosed, non-beta looks better with debug=true [23:58:20] try beta with debug=true