[00:01:03] that works [00:13:08] preilly what was it? [00:13:59] resource loader on bits cached an empty response [00:14:07] doh [00:14:12] so here's something weird [00:14:19] i don't have the beta cookie [00:14:22] but im seeing the beta site [00:15:02] oh wtf [00:15:13] cookie is set in the request header [00:15:20] but im in a new private browsing session... [00:20:04] awjr: are you using a plug in? [00:21:05] preilly no, but i have the cookie set in my non-private browsing session [00:21:28] i've seen that before where sometimes a private browsing session will still get resources from the non-private browsing session in chrome [00:21:41] lame [00:22:24] so i just opted in to beta on my ICS device [00:22:31] then go to san francisco article, and see non-beta [00:22:43] but then go to some other page and see beta [00:23:54] oh maybe it was just cached in the browser [00:24:41] awjr: yeah [00:27:42] well it looks people have started to use the new contact form [00:28:25] awjr: nice [00:40:07] preilly: did you wind up going over any deployment stuff with max today? [00:40:31] assuming he gets accounts set up, think he'd be ok to do next week's deployment with one of us watching over his shoulder? [00:40:34] awjr: I copied everything that I did to him in a PM [00:40:41] cool [00:41:15] preilly assuming he gets accounts set up, think he'd be ok to do next week's deployment with one of us watching over his shoulder? [00:41:35] yeah [00:41:43] word [00:42:51] it will be nice having another person, epscially in a very different timezone, available to do deploys [00:45:10] yeah [00:45:20] so we should make that happen [00:46:03] for real [00:46:29] we should probably have him pick a time for deployment so he's actually awake [00:46:38] but also when one of us can be around [00:49:43] awjr: okay [08:41:07] jdlrobson: hey there [08:41:14] had a quick question for you before i crash for the night [08:53:24] hey tfinc sorry [08:53:26] still there? [08:53:29] yup [08:54:00] so i was curious what prompted us adding 'Last edited on 00:28, 13 April 2012' into the beta [08:54:20] no one i talked to today could tell me what motivated us to add it [08:54:49] yeh so this was a big screw up on my part .. I just mailed Phil about it [08:55:16] (just digging out link) [08:56:17] https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/MobileFrontend.git;a=commit;h=e347eba346fdd530ceb5994a9b47896c543edce2 so basically during my 20% day I did a follow up to one of the messages on the MobileFrontend page and I submitted it as a patch for review and I was meant to chat about whether we should merge it only got massively sidetracked and it got merged anyway [08:56:23] i'm sorry! :( [08:56:48] so was it simply a feature that your thought would be useful or did someone ask for it? [08:56:49] On hindsight I should have opened a bug with a patch attached [08:56:58] if its in the email you sent phil then just forward that over [08:57:00] https://www.mediawiki.org/wiki/Thread:Extension_talk:MobileFrontend/Add_dynamic_context_to_the_footer [08:57:43] there was a ton of confusion in the office today about how it showed up. glad i finally know where it came from [08:58:19] lets pull it from the beta. we should discuss this more and figure out what the intention is and then how were goign to do it [08:58:29] right now it looks rushed and ill placed with everything else [08:58:32] sure.. I'll send a commit to revert it today [08:58:58] sorry again.. feel a bit of a idiot [08:59:02] i'm not saying its a bad feature. we should just chat about what its trying to do, decided if we need it, and then figure out where to put it [08:59:20] now that you've given me background the mystery is solved [08:59:24] thats a plus [08:59:53] Yeh I agree.. I'm more annoyed with myself for how I got sidetracked and allowed it to get sneaked in [09:00:12] next time make sure we have some kind of discussion about it so that people know when/if/etc about such a prominent change as we'll get question about it [09:00:25] hmm, tfinc is still up [09:00:27] * YuviPanda goes to check logs [09:00:31] YuviPanda: barely [09:00:39] its 2AM here and i'm about to crash [09:00:53] just wanted to catch jdlrobson to explain the footer myster today [09:01:51] yep tfinc - will make sure in future I open bugzilla bugs with patches instead of sending for review. I guess I'm missing github style branches where you can share things in a way that doesn't suggest they want to be merged [09:02:12] * aude waves [09:02:25] jdlrobson: yes. we need a way where you can check in your work but not have it land in master [09:02:28] thats important to have [09:02:33] https://www.mediawiki.org/wiki/Special:Contributions/Mobilefrontend is spammy :( [09:03:54] aude: yeah its like OTRS/mailman ;) [09:04:16] we'll likely have to step up spam filtering on the contact us page [09:04:23] New patchset: Jdlrobson; "remove last edited information from footer" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8573 [09:04:26] tfinc: ^ [09:04:47] jdlrobson: open up a bug so that we don't forget about it [09:04:55] already on it :) [09:04:59] and chat with phil tomorrow to figure out what we should do with it [09:05:01] thanks [09:08:43] https://bugzilla.wikimedia.org/show_bug.cgi?id=37045 < tfinc [09:08:49] thanks [09:15:01] now its time to crash if i want any chance of being up in the morning [09:15:08] seeya guys in a couple hours [09:27:14] YuviPanda|food: ping me when you get back [09:30:17] jdlrobson, have you seen my changes? [09:30:27] not yet MaxSem [09:30:57] * jdlrobson looks now [09:31:11] essentially this -> https://gerrit.wikimedia.org/r/#/c/8343/4/specials/SpecialMobileOptions.php ? [09:31:51] yup. just a few comments: all messages should be in sentence case and should comply with general practice, e.g. "log in" instead of "login" [09:33:04] sure. I need to i18n them too [09:33:17] so its just the submitting we need to take care ? [09:34:15] (and obviously linking up the logout/login button. [09:34:30] (and the header) [09:35:49] speaking of login, we still can't create accounts from the mobile site [09:36:18] thus I'm not sure if we should make this link widely available right now [09:36:33] create as in register? [09:37:15] yup. the best course of actions would be to make the core MW forms mobile-friendly [09:37:30] well logging in is useful - http://en.m.wikipedia.org/wiki/Special:UserLogin [09:37:37] we could always just link to desktop register form [09:38:02] MaxSem: although saying that login seems broken [09:38:36] quite possible - because we redo this form in MF manually [09:40:23] can you take a look at the desktop login/register forms to find out what needs to be done to make them mobile-friendly? (reformat from tables to divs, I guess) [09:52:56] MaxSem: will look into it tomorrow (20% day today) but sure it won't be too hard [09:53:36] cool, thanks [09:53:38] i'm pretty sure we can use the exact html code just with some additional styling [09:53:46] although not sure why login doesn't seem to work [09:59:25] hey jdlrobson [09:59:38] are you sure it was from either of the two versions I mentioned? [09:59:38] hey YuviPanda just looking at your ShortUrl extension [09:59:43] ahh, sweet :D [09:59:55] YuviPanda: no idea about where the saved page comes from [09:59:58] first MediaWiki code I ever wrote :) [10:00:10] jdlrobson: it will break in unexpected ways if it is not from a released version. [10:00:18] just figured if we can detect where it goes wrong we should at least delete the saved page if it can't be upgraded [10:00:32] but on subject of ShortUrl [10:01:00] have you got a script / code snippet for creating the mediawiki.shorturls table ? [10:01:20] jdlrobson: yup, it's included in the extension [10:01:33] which one? [10:01:34] populateShortUrlTable [10:01:37] .php [10:01:54] doesn't create table.. [10:02:09] just inserts [10:02:25] ah, for creating the table you need to run maintenance/update.php [10:02:30] on your mediawiki install [10:02:35] ahh [10:02:45] that'll update all extensions' database structure modification needs [10:03:09] perfect [10:03:10] thanks [10:03:21] jdlrobson: :) [10:36:19] YuviPanda or jdlrobson poke [10:36:50] hello THO|Cloud [10:37:22] hey :) got a question about [[User:Mobilefrontend]] - are those edits supposed to be public? [10:37:31] I think so, yes [10:37:33] jdlrobson: ^ [10:37:51] they were reverted last time because they were making IP addresses and UA public [10:38:21] yeah, this time it's just UA info [10:38:47] and also, the feedback for http://en.m.wikipedia.org/w/index.php?title=Special:MobileFeedback - where does that go if I choose technical problem? [10:40:13] * YuviPanda peeks [10:40:31] I'm unsure, haven't been following it too closely [10:40:32] jdlrobson: ? [10:40:53] but can you confirm that http://www.mediawiki.org/wiki/Special:Contributions/Mobilefrontend is something from the mobile team? [10:41:19] one of the stewards just deleted the page because it looks like that account is just giving out rubbish / spam, but those are all edits from different people, no? [10:42:10] I'm pretty sure, but since I've not been following it, I'm looking through the codebase to find out [10:42:11] give me a moment [10:42:23] ok sure [10:45:41] THO|Cloud: it is [10:46:51] and where are people going to get those edits done YuviPanda? [10:47:24] THO|Cloud: i think jdlrobson is the better person to talk about this. My knowledge is simply hearsay from hearing them work. Sorry! [10:47:27] * YuviPanda pokes jdlrobson  [10:47:32] ok [10:47:51] sorry [10:48:50] sooo this is all configurable if I remember correctly so it depends how it has been configured [10:49:19] awjr is the best person to talk about the current status [10:49:24] heh [10:49:36] I'm looking at the code now to see [10:49:44] but where are people going to write those comments jdlrobson that become this account's edits? [10:49:45] ok [10:50:20] THO|Cloud: I *think* you're looking for http://en.m.wikipedia.org/w/index.php?title=Special:MobileFeedback? IIRC things from Contact US were posted as that account [10:50:52] jdlrobson: it posts as user with name $wgMFRemotePostFeedbackUsername, but that's set in wiki configurations, which IIRC aren't public [10:50:53] ah yes ok [10:54:22] sorry mac crashed.. [10:54:27] np [10:54:55] I updated http://www.mediawiki.org/wiki/User:Mobilefrontend to reflect this, [10:56:03] THO|Cloud: are you able to inspect LocalSettings.php ? $wgMFRemotePostFeedback should point to that url [10:56:37] hmm not localsettings.php, isn't it initiliasesettings.php for wikimedia? [10:56:50] not sure how it's setup... [10:57:11] ahh my mistake $wgMFRemotePostFeedbackArticle is the variable [10:58:05] I suspect $wgMFRemotePostFeedbackUsername is User:Mobilefrontend [10:58:16] ok it's in here https://noc.wikimedia.org/conf/highlight.php?file=CommonSettings.php [10:59:09] I'll update the docs [10:59:34] jdlrobson: on http://www.mediawiki.org/wiki/MobileFrontendFeedback - I presume it's ok to remove the spam? [10:59:51] yes as long as its spam I don't see why not [11:00:11] http://www.mediawiki.org/wiki/MobileFrontendFeedback#Text_Color for instance is not spam [11:03:35] agreed [11:03:58] updated documentation at https://www.mediawiki.org/w/index.php?title=Extension:MobileFrontend#Configuration_settings [11:06:17] ok some people are complaining about it being in main space jdlrobson, do you have the ability to tweak that? [11:06:39] tweak where it saves to? [11:06:42] so from MobileFrontendFeedback to Project:MobileFrontendFeedback [11:06:43] yeah [11:06:48] afraid not.. [11:06:50] maybe MaxSem does? [11:06:58] you'll need to edit CommonSettings.php and need a +2 in gerrit [11:12:42] THO|Cloud: To my knowledge I don't have that ability... is CommingSettings.php on git? [11:12:47] *CommonSettings.php [11:12:50] yes [11:13:04] mark said he doesn't do those changes unless it's critical [11:16:18] also, you'll need someone to actually dep.loy that +2;) [11:16:37] MaxSem: https://gerrit.wikimedia.org/r/#/c/8586/ [11:16:53] can you confirm that is okay in #wikimedia-operations and ask someone nicely to deploy it? ;) [11:19:42] I'd rather see a WP-style page name [11:19:48] all I've done is https://gerrit.wikimedia.org/r/#/c/8586/1/wmf-config/CommonSettings.php [11:20:11] oh [11:20:55] the old one was http://www.mediawiki.org/wiki/Project:Mobile_Extension_Feedback [11:23:06] jdlrobson, have you seen the feedback about pages being grayed out? https://www.mediawiki.org/wiki/MobileFrontendFeedback [11:23:56] yup MaxSem [11:24:19] MaxSem: what name would you like then? :) [11:24:40] Project:Mobile site feedback [11:26:01] MaxSem: I'm just not sure what he's referring to [11:27:05] brb just popping out for lunch [14:17:48] jdlrobson: you there? [14:17:53] yup [14:18:13] ok, I think you designed the new mobile site so http://en.m.wikipedia.org/w/index.php?title=Special:MobileFeedback [14:18:20] when I go to change my language there - it's greyed out [14:18:32] that's because there's no interwiki links there I imagine -- but it would be good to allow you to change your language [14:18:47] any way you could make it work? [14:20:01] are you on the beta? [14:21:26] could be actually yes [14:21:42] what does it look like for normal people? [14:21:57] ah yeah it doesn't have it there [14:22:00] if it is the beta you have the text beta on the icon [14:22:10] btw MaxSem > http://fr.m.wikipedia.org/wiki/Wikip%C3%A9dia:Accueil_principal < that seems to be rendering without css or js for me.. [14:22:29] likewise > http://pt.m.wikipedia.org/wiki/Wikip%C3%A9dia:P%C3%A1gina_principal [14:22:32] this is rather worrying [14:22:41] works for me [14:22:55] THO|Cloud: so the language option doesn't seem to work with Special pages - do you want to raise a bug ? [14:23:02] jdlrobson: yeah I'm in beta [14:23:08] ehm, works on Opera, but not FF [14:23:17] THO|Cloud: > do you get styling on http://pt.m.wikipedia.org/wiki/Wikip%C3%A9dia:P%C3%A1gina_principal ? [14:23:30] in my Chrome I don't, but Safari I do. [14:23:31] mmm, non-beta styles screwed up? [14:23:39] yes I do [14:23:52] but only on beta [14:24:03] I think so MaxSem [14:24:35] oh fuck [14:24:51] also MaxSem I can't seem to opt out [14:25:11] the RL core tweak was cherrypicked into 1.20wmf3 but not wmf2 [14:25:50] :-O [14:27:29] MaxSem: can you do anything? [14:38:22] looks like I need a clean checkout [14:38:44] pulls from gerrit are ssssssooooo sssssslowwwwww [15:09:27] MaxSem: any luck? [15:09:36] anything I can help with? [15:10:18] if you have a core checkout w/o extensions, you could cherrypick it yourself [15:12:32] daeeeemn, git isn't interested in giving up easily [15:14:50] I don't :( [15:16:18] * MaxSem makes a YET ANOTHER clean checkout [15:32:32] its getting there MaxSem at least the css is back now [15:33:07] I think the grey text comment on the feedback must have been related to no javascript running through resource loader as I'm seeing that problem now [16:01:42] huh, it _had_ been cherrypicked - so it's probably lack of an update? [16:17:17] maplebed: do you have +2 in operations/mediawiki-config? [16:17:28] I don't know! [16:17:39] heh [16:17:41] https://gerrit.wikimedia.org/r/#/c/8612/ [16:18:03] can you review that change please? it's to do with the mobile feedback, some people were complaining that it should be in project: namespace instead of main space [16:18:38] preilly or tfinc - do you have an opinion on that change? [16:18:51] [16:18:52] or tfinc_meetings [16:19:30] it's true, Amgine I save vs. outages. [16:19:38] [16:20:50] Thehelpfulone: http://www.mediawiki.org/wiki/Project:Mobile_site_feedback currently has no content, so I'm not going to merge the change. [16:21:10] maplebed: before you do it I will move the other page [16:21:14] once the content of http://www.mediawiki.org/wiki/MobileFrontendFeedback gets migrated, then the change might be move-worthy [16:21:35] or alternatively I can history merge the two pages [16:21:54] so as it turns out I do have +2 rights, but I need to hear from preilly or tfinc before merging anything. [16:22:01] but if I do it before and then you don't merge the change it creates a mess because the user account still posts on the page [16:22:08] right. [16:22:31] yeah, ok. when I get confirmation from them we can do the merge and move together. [16:22:40] great :) [16:23:06] New patchset: MaxSem; "Simplify robots and Apple touch icon outputting" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8614 [16:23:57] maplebed, you have my approval [16:24:12] Thehelpfulone: as long as i can find it ... i dont care what its named :) [16:24:47] thanks ;) [16:24:59] maplebed: can you do the merge, then I'll move as soon as you've done it? [16:25:28] Thehelpfulone: one sec - I need to make sure that I understand what the merge does as it relates to the servers actually running mediawiki. [16:25:42] sure [16:25:48] but yes, as soon as I figure that out we're good to go. [16:26:23] jdlrobson: hi Jon [16:26:27] Thehelpfulone: just let philinje know as he's been tailing that page and can update anyone else. just leave a redirect [16:26:30] hi philinje [16:26:44] MaxSem: > http://es.m.wikipedia.org/wiki/Italia [16:26:49] still not working [16:26:51] ready for a call? [16:26:56] yep philinje [16:27:03] ok one sec [16:27:30] philinje: ok, so we're moving http://www.mediawiki.org/wiki/MobileFrontendFeedback to http://www.mediawiki.org/wiki/Project:Mobile_site_feedback because people complained about it not being in Project: namespace [16:27:43] but to do this we need a config change which maplebed is reviewing [16:27:54] and hi btw :) [16:27:55] ah, ok [16:28:38] jdlrobson, also, Special:MobileOptions looks screwed up on that wiki ... i18n problem [16:28:57] MaxSem: I'm also not getting styles or javascript [16:28:59] (on non-beta [16:29:30] Thehelpfulone: hi! [16:29:55] jdlrobson, looks like we'll have to poke preilly [16:30:35] interestingly MaxSem it's working on my phone though :/ [16:30:53] JS differences - beta looks ok [16:31:33] well no javascript on my phone.. just css [16:33:29] jdlrobson: ready? [17:00:30] hang out is up https://plus.google.com/hangouts/_/bea1222d32b83dd49f5236ba78f2305c4b224d2b?authuser=1&hl=en [17:01:11] jdlrobson: Yuvi|Paperwork MaxSem --^ [17:01:17] Thehelpfulone: I'm set whenever you're ready. [17:01:38] MaxSem: what's the issue? [17:05:02] maplebed: I'm good to go [17:05:11] tell me when you've merged and I'll move :) [17:06:07] preilly, 1.20wmf2 looks like as if https://gerrit.wikimedia.org/r/#/c/8346/ hasn't been synched [17:08:00] jdlrobson: it's a bug. I'm trying to track down the exact place js decides to stop executing [17:08:14] involved putting console.log('1'); console.log('2') in a lot of places [17:08:20] should write a vim plugin that does this sometimes [17:08:22] sigh [17:08:29] BlackRectangle: FYI I did push it since you said it was fine for main releases [17:08:52] can i help debug with my remaining few minutes? [17:08:58] tfinc, has there been any response to the request for deployment rights for me? [17:09:02] nah, i've sunk enough time into it :) [17:09:11] let me see if I can push one for review within your next fea minues :) [17:09:13] *few minutes [17:09:30] MaxSem: grep -rn '$isRaw' * [17:09:31] includes/resourceloader/ResourceLoader.php:688: $isRaw = false; [17:09:32] includes/resourceloader/ResourceLoader.php:767: $isRaw |= $module->isRaw(); [17:09:33] includes/resourceloader/ResourceLoader.php:772: if ( $context->shouldIncludeScripts() && !$context->getRaw() && !$isRaw ) { [17:09:48] New patchset: Jdlrobson; "use history api to avoid problems with buggy browsers (bug 37059)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8620 [17:09:51] MaxSem: 1.20wmf2 is fine [17:09:58] preilly, is it deployed, or just lies on fenari? [17:10:08] hmm didn't seem to work maplebed [17:10:16] MaxSem: what wiki are you looking at? [17:10:25] Thehelpfulone: sorry, I hit an unexpected permission denied. [17:10:26] I got the email.. [17:10:32] ah [17:10:34] one sec. [17:10:41] sure [17:10:47] preilly, http://es.m.wikipedia.org/wiki/Italia [17:11:10] preilly: make sure you are not beta [17:11:40] jdlrobson: https://twitter.com/DerBastiS4/status/205315011747389442 [17:11:47] BlackRectangle: js stops executing? [17:11:57] i bet its a similar issue to @thomaspashko [17:12:01] Krinkle: yup. Happens all the time with phonegap and iOS [17:12:06] I know what the issue is [17:12:08] thx tfcin ... I'm not sure. Blackberrys are the most troublesome browsers for me [17:12:11] BlackRectangle: Oh, phonegap :P [17:12:17] Krinkle: no feedback at all what so ever (mostly) [17:12:18] as I have problems with my emulators and no physical devices and they vary so much [17:12:21] BlackRectangle: meh, I only care about mediawiki/resourceloader ;-) [17:12:23] so you just drop printfs everywhere [17:12:40] Krinkle: heh :D [17:12:40] but seriously though, that sounds like an annoying problem to debug. No exceptions thrown? [17:12:46] MaxSem: try http://es.m.wikipedia.org/wiki/Italia?adsf=adsf now [17:12:47] tfcin: will you contact him or do you want me to poke him for more? [17:12:48] Krinkle: nothing. [17:12:52] jdlrobson: respond to him and lets at least capture the kind of black berry he has [17:12:52] Krinkle: Android throws things [17:12:56] preilly \o/ [17:12:58] right [17:13:03] Krinkle: It doesn't throw even if you left in a syntax error, for example [17:13:06] o_0 [17:13:12] Varnish fun? [17:13:20] MaxSem: nope [17:13:28] MaxSem: RL had cached an empty response [17:13:31] this isn't a syntax error, so makes things worse - trace the execution of flow by hand and keep dropping printfs everywhere [17:13:36] Thehelpfulone: ok, I think it's out now. please verify? [17:13:44] jdlrobson: preilly: we should plan on a late week deployment for black berry issues. i don't want to leave their experience broken for a week [17:14:01] preilly, so how did you fix it? [17:14:02] sure [17:14:32] yes works [17:14:53] MaxSem: forced RL to see a file change in the styles and generate a new bundle version [17:15:25] sigh [17:16:03] so the culprit was that MF got updated before MW? [17:16:42] try http://es.m.wikipedia.org/wiki/Italia again [17:16:50] the cache has been flushed [17:17:45] MaxSem: no MF wasn't updated before MW [17:18:14] MaxSem: MW had your change pushed the day after you made them [17:18:57] nope, just yesterday: https://gerrit.wikimedia.org/r/#/q/I9410ffbf6633075e07bd06b10a98a4d12d9b6106,n,z [17:19:27] so MaxSem am I really going to need to drastically change my form html? [17:19:50] because that would suck [17:19:51] and I've seen other errors with caching, e.g. mw.loader.state() calls [17:19:59] MaxSem: that's two days ago not yesterday [17:20:08] jdlrobson, options? [17:20:21] preilly, that was yesterday on my time:P [17:20:23] well... I need this html markup https://gerrit.wikimedia.org/r/#/c/8343/4/specials/SpecialMobileOptions.php [17:20:29] YuviPanda: How are you tracing execution flow on iOS (I know a way, but wonder what way you use) [17:20:41] Krinkle: console.logs [17:20:42] lots of them [17:20:49] e.g. span with checkbox inside inside a li [17:20:52] YuviPanda: Hm... okay. [17:20:58] there are debuggers that sortof work, but they don't really [17:20:58] I guess instead of an li I could get away with a div though [17:21:14] they seem to have intricate xcode and iOS version combination requirements that I don't seem to be able to satisfy [17:21:19] jdlrobson, I see no problems with HTML [17:21:23] YuviPanda: I'm not sure if it's do-able within a PhoneGap environment, but do you know the Chrome Inspector tools etc. where you can pause etc.? [17:21:42] YuviPanda: The latest Chrome (17+) has the ability to do this remotely for any WebKit browser. [17:21:53] Krinkle: yup, so does mobile safar since 5.1 (I think) [17:21:58] so you can use that kind of toolkit on the live dom of the iPhone [17:22:00] Krinkle: i've managed to get it to work for safari [17:22:04] but not for phonegap [17:22:07] awesome [17:22:09] a, too bad. [17:22:27] why not? [17:22:33] Krinkle: http://www.iwebinspector.com/ is something that was supposed to work, but didn't work the last time I tried [17:22:38] same with weinre [17:22:48] mono, you don't need that [17:22:49] MaxSem: well if we can keep the html for https://gerrit.wikimedia.org/r/#/c/8343/4/specials/SpecialMobileOptions.php - then all we need to do is add the submit behaviour [17:23:13] MaxSem forget that [17:23:23] WebKit has this built-in now. Only from WebKit to WebKit though, and needs to be within LAN (those other tools can go across the web and some other browsers such as Firefox as well) [17:23:25] you've done that already I see :) [17:23:33] but you have WebKit only and are within the LAN, right? [17:24:04] Krinkle: that's what iWebInspector uses (built in webkit remote debugging) [17:24:10] okay [17:24:12] jdlrobson, we just need to add i18n, XSRF prevention and make ids/class names less generic [17:24:19] Krinkle: I haven't tried it directly, however. Perhaps I should do that. [17:24:23] agreed MaxSem [17:24:28] and fix the title [17:24:47] YuviPanda: I'm reading that website now. Wondering what it does that it doesn't do by default. Interesting... [17:24:56] MaxSem: will do that first thing tomorrow [17:24:58] nothing special, just wraps things around in a package [17:25:05] ok [17:25:12] yeah, I'd try using it directly :) [17:25:33] mmm will do Krinkle! [17:26:16] I haven't had an iOS device or mobile app to try it on, but that's what I'd try. I don't know how that works exactly though, I only tried it from desktop to desktop and with Chrome. [17:26:41] Krinkle: okay! Will try in a bit [17:26:45] For Chrome a comnand-line option has to be passed to enable it. I wonder how that works on iOS... [17:26:56] Krinkle: won't help me with this though, 'coz this looks like it's a iOS 4.x specific thing [17:27:01] (current issue i'm debugging) [17:27:04] ok [17:30:02] MaxSem: how are your C chops ? [17:31:07] well, I used to program in it on my previous work, but I'm unfamiliar with the GNU toolchain [17:32:09] k, i'm looking around to see who can unblock arthur on the redirector changes [17:33:07] i think it'll help to show you the changes and then we can figure out how much you can help [17:33:12] katie might be able to help us as well [17:33:18] i'll let arthur coordinate it [17:36:04] New patchset: Jdlrobson; "settings page (incomplete early prototype)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8343 [17:36:04] tfinc_, http://svn.wikimedia.org/viewvc/mediawiki/trunk/debs/squid/redirector.c?view=markup ? [17:36:26] gotta go.. see you tomorrow! [17:36:28] MaxSem: yup, thats the one [17:36:32] jdlrobson: seeya [17:37:07] tfinc_, so you need to change it to redirect other projects, too? [17:38:21] MaxSem: yes. let me forward you the email that arthur sent and then we can figure out if you can tackle it [17:45:15] MaxSem: cc'd you on the mail [17:47:00] MaxSem: basically more pattern and replacement_url conditions [17:47:07] yup [17:48:05] why it's still in SVN?:P [17:49:23] MaxSem: all debs are [17:49:36] how lame:D [17:58:15] tfinc_, replied [18:06:13] MaxSem: thanks [18:29:53] brion: ping [18:34:11] preilly, moment [18:34:40] properly, [18:39:11] woot http://www.groklaw.net/article.php?story=20120523125023818 ! [18:55:17] i'm glad the jury made the right call on oracle vs google [18:56:40] thank god [18:56:47] that's a big relief [18:58:15] drdee2: agreed. its nice to know that API's can't be ruined by being secret [18:58:23] would have been abusrd to let that pass [19:18:16] New patchset: L10n-bot; "Localisation updates from http://translatewiki.net." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8665 [19:21:22] YuviPanda: you around? [19:21:28] preilly: yup [19:23:02] YuviPanda: I'm trying to update to 1.7.0 [19:23:22] YuviPanda: and I'm getting a page with out article text [19:23:35] preilly: master? [19:23:38] YuviPanda: and show/hide fails with a jquery error [19:23:42] YuviPanda: yeah, master [19:23:59] preilly: pastebin? [19:29:10] [WikipediaMobile] preillyme pushed 1 new commit to 1.7-migration: http://git.io/K4mCwA [19:29:10] [WikipediaMobile/1.7-migration] initial migration attempt - Patrick Reilly [19:29:22] YuviPanda: https://github.com/wikimedia/WikipediaMobile/commit/ee849cdb2bd1ba97a2be9d205bf84975fecdb673 [19:30:57] preilly: thanks! Tracking down a weird bug on iOS now, will look at this after. [19:31:15] do you have pastebin of what the error message in the log was? [19:32:05] [WikipediaMobile] preillyme pushed 1 new commit to 1.7-migration: http://git.io/Nsf55Q [19:32:05] [WikipediaMobile/1.7-migration] fix access origin - Patrick Reilly [19:37:43] YuviPanda: http://pastebin.mozilla.org/1648705 [19:41:51] hmm, don't see anything obvious, preilly [19:41:59] will dig deeper once i'm out of my current hole [19:44:12] YuviPanda: okay can you try to run it locally and check [19:44:19] YuviPanda: I mean once you're free [19:44:24] yup! [19:44:29] will do and poke you [19:53:25] fuck [19:53:35] i spent this much time trying to nail down the issue [19:53:38] thought it was the app [19:53:43] while it turns otu that the API is borked [19:53:46] * YuviPanda pages MaxSem  [19:53:54] ? [19:54:32] MaxSem: sections=all seems to return nothing? [19:54:45] hmm, it seems to work in api sandbox :| [19:55:25] https://en.wikipedia.org/w/api.php?action=mobileview&page=Mobile§ions=all [19:55:27] WFM [19:55:34] how to repro? [19:56:18] MaxSem: figuring out. Same commit, worked yesterday before last deploy, doesn't today [19:58:04] MaxSem: so, http://en.wikipedia.org/w/api.php?action=mobileview&format=json&page=India&redirect=yes§ions=all&prop=sections§ionprop=level%7Cline&noheadings= doesn't provide me text [19:58:07] while it did yesterday [19:58:34] well, you didn't tell it to return you the text;) [19:58:46] so it was a bug that I was relying on apparently that was fixed :P [19:59:04] yup, I fixed it while adding sections=references [19:59:16] YuviPanda: so that might be my issue too [19:59:18] what up mobile people [19:59:21] preilly: think so! [19:59:32] MaxSem: what needs to be added? [19:59:39] preilly: making that commit now [19:59:53] YuviPanda: to master or 1.7-migration? [20:00:01] preilly: master. It's a one line change [20:00:56] [WikipediaMobile] yuvipanda pushed 1 new commit to master: http://git.io/jfOppA [20:00:56] [WikipediaMobile/master] Explicitly request text of the page's sections in API - YuviPanda [20:02:04] preilly: ^ [20:02:42] [WikipediaMobile] preillyme pushed 1 new commit to 1.7-migration: http://git.io/8h0uoA [20:02:42] [WikipediaMobile/1.7-migration] Explicitly request text of the page's sections in API - Patrick Reilly [20:03:58] YuviPanda: wow I've got page text now [20:04:23] quite very amazing :D [20:04:43] YuviPanda: ha ha ha [20:04:52] :D [20:05:12] though I do feel like an idiot for completely looking at the wrong place for this [20:06:06] tfinc_: we're ready for RC! You'd need to do the iOS builds, since you've the FB key. [20:06:22] YuviPanda: can you check out 1.7-migration and take a look [20:06:29] yup, doing so now. [20:07:34] YuviPanda: I've only done Android not iOS [20:08:28] preilly: you would want to rebase on master before upgrading iOS, since we've killed one iOS plugin in the meantime [20:10:55] wow, I seem to have managed to break my micro USB cable's pin! [20:12:13] [WikipediaMobile] preillyme pushed 4 new commits to 1.7-migration: http://git.io/iGA42A [20:12:13] [WikipediaMobile/1.7-migration] initial migration attempt - Patrick Reilly [20:12:13] [WikipediaMobile/1.7-migration] fix access origin - Patrick Reilly [20:12:13] [WikipediaMobile/1.7-migration] Explicitly request text of the page's sections in API - Patrick Reilly [20:22:39] YuviPanda: sure, which branch should i pull from? [20:23:05] tfinc_: master, but give me a moment. Got sidetracked by 1.7, let me update changelogs [20:23:08] and the version numbers [20:23:12] YuviPanda: why don't i just give you the fb key so that you can just do it [20:23:19] tfinc_: that'd be swell too [20:28:27] YuviPanda: need anything else from me ? [20:28:35] tfinc_: nope! [20:29:40] * tfinc_ wonders where phil is [20:30:31] [WikipediaMobile] yuvipanda pushed 1 new commit to master: http://git.io/LELyVA [20:30:31] [WikipediaMobile/master] Bumped version numbers and updated changelog - YuviPanda [20:33:08] awjr: you name blockers ... i make sure you have patches when you come back ;) [20:33:10] lolz [20:34:04] :D [20:34:15] expertly done, sir [20:34:56] awjr: how was the tele conference ? [20:35:23] tfinc_: i though it was *really* good [20:35:54] awjr: sounds like a sumamry to engineer/wikitech/staff would be good then [20:35:57] summary* [20:36:17] i was weirded out by the format at first (just audio from the presenters), but it actually worked. it was really well moderated by sarah novotny from o'reill/oscon [20:36:21] tfinc_: definitely [20:36:40] tfinc_: im going to wait to do the summary for when they have the recording of the panels posted (should be in a few days, they tell me) [20:41:55] nice [20:44:24] awjr: preilly MaxSem: we need to get an update on http://www.mediawiki.org/wiki/Mobile_support_in_MediaWiki_core [20:45:05] preilly: did we deploy our js test for http://www.mediawiki.org/wiki/Improved_Mobile_Device_Detection ? [21:05:48] [WikipediaMobile] yuvipanda force-pushed beta from 2749868 to 0ae2792: http://git.io/UAGDHg [21:05:48] [WikipediaMobile/beta] Apply transformations to make the app into 'Beta' - YuviPanda [21:07:04] hmm, all setup [21:07:20] I will push it out tomorrow - pushing out betas and going to sleep is not-good [21:08:06] I also seem to have broken the kindle microusb I was using with my phone, so shall test preilly's changes tomorrow with a working cable. [21:08:52] in the meantime, tfinc_ can you put up http://dl.dropbox.com/u/8768784/Wikipedia-v3.2RC1-iOS.ipa on dumps.wikimedia.org/iOS and http://dl.dropbox.com/u/8768784/Wikipedia-v1.2-beta2-market.apk on dumps.wikimedia.org/android [21:08:52] ? [21:09:04] i'd bug apergos if you weren't around, but since you are… :D [21:13:48] sure [21:14:56] YuviPanda: why just a beta2 for android ? [21:15:23] ah, that's because apparently I'm an idiot :) [21:15:27] tfinc_: correct link is http://dl.dropbox.com/u/8768784/Wikipedia-v1.2-RC1-market.apk [21:15:29] thanks for spotting that [21:15:55] :) [21:16:49] [WikipediaMobile] preillyme pushed 1 new commit to 1.7-migration: http://git.io/tL9bAg [21:16:49] [WikipediaMobile/1.7-migration] initial migration attempt - Patrick Reilly [21:17:15] tfinc_: next week we are doing it [21:17:29] tfinc_: he and I are going work on it in Berlin [21:17:57] YuviPanda: http://dumps.wikimedia.org/iOS/Wikipedia-v3.2RC1-iOS.ipa / http://dumps.wikimedia.org/android/Wikipedia-v1.2-RC1-market.apk [21:18:12] sweet! Thanks! [21:18:19] preilly: k, throw in an update to the project page [21:18:26] to recap what you guys have in place now [21:19:13] tfinc_: okay in a minute [21:19:38] YuviPanda: I've got iOS working if you want to take a look at http://git.io/tL9bAg [21:19:43] "Come on guys, fix it. We're dying out here." [21:19:46] "The app for iPhone has been a wreck for the last 3updates. The version before that worked fine. The list of problems is too long to list. I have to go through Google to use Wiki now. Try it on the iPhone, you should (1) fix it(2) get rid of it (3) put the rev. back you had 3 versions ago. Just do something please!" [21:20:07] MaxSem: go back, there are plenty of people telling us how badly it sucks. [21:20:13] in cruder language [21:22:37] for example, 'Blows dead dog dick' [21:24:08] YuviPanda: can you take a look at the iOS and Android updates in 1.7-migration when you get a chance [21:24:18] preilly: yup, will do! [21:24:37] i'll probably write out a mail to mobile-l about RCs and crash today. Will definitely look at the 1.7-migration tomorrow! [21:25:26] YuviPanda: okay that's cool [21:31:02] preilly: when i click on the 'share' or history/saved/nearby menu icons in ios i get: ERROR: Plugin 'ActionSheet' not found, or is not a CDVPlugin. Check your plugin mapping in Cordova.plist. [21:32:06] wtf can't scroll on the about screen [21:35:24] * YuviPanda heads to sleep [21:35:35] do try out the new RC I just posted to the mailing list :) [21:35:37] gnite everyone [21:35:44] nighty night [22:33:17] New patchset: MaxSem; "Bug 37049: Non-latin characters get converted into entities" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8722 [22:50:55] MaxSem: do we really need the above? [22:51:58] MaxSem: isn't it mb_convert_encoding not DOMDocument that is causing the issues? [22:52:31] without it, all unicode is screwed up [22:53:45] preilly: is the proxy on mobile-sms or mobile on labs ? [22:54:20] tfinc_: it's not a proxy [22:54:31] tfinc_: it's just ssh on fenari [22:54:51] tfinc_: e.g., SSH -AND 8080…. [22:55:47] k [22:56:49] then do you care which box we give him access to ? [22:56:58] we have to add him to one of the projects [22:57:44] tfinc_: I've already added him to bastion, mobile and mobile-sms [22:58:06] let me reload the list [22:58:19] tfinc_: look at https://labsconsole.wikimedia.org/wiki/Special:NovaProject [22:58:28] oh i was on the page [22:59:05] but he wasn't on the list. hence me asking. but now that you've added him all is well [23:37:50] tfinc_: I've talked Dfoy through setting up a SOCKS5 based proxy using SSH and showed him how to configure Firefox to use this proxy [23:38:19] tfinc_: he is just confused on killing the SSH session so he is going to come down for that part [23:38:57] preilly: thanks. lets get him to document it after so that you don't have to walk kul and amit through the same steps [23:40:05] tfinc_: yeah, makes sense [23:55:40] anyone know what yahoo actually does these days ? http://www.launch.co/blog/yahoo-to-launch-chrome-killer-tonight.html [23:56:23] seriously?