[00:03:39] oh good, more browsers [00:04:31] awjr: nope [00:04:41] awjr: it's an extension to your browser [00:04:47] awjr: not a browser [00:05:23] oh? [00:05:24] "Yahoo! Axis is a new browser that redefines what it means to search and browse" [00:06:08] awjr: well if you go to http://axis.yahoo.com/ [00:06:20] and click "Get it Now!" DESKTOP [00:06:20] yeah imi checking out the vids [00:06:36] it installs a chrome extension [00:06:41] and that's it [00:08:23] awjr: Yahoo is getting into the browser business with its new Axis browser. There are versions for iPad and iPhone, and plug-ins for the desktop browsers Chrome, Firefox, IE, and Safari. [00:08:33] least browserful browser…. ever. [00:08:53] in the video they referred to it both as a browser and a plugin [00:10:09] awjr: lame [00:10:19] so if they used that idea but let you use google search i think it would be pretty cool [00:10:44] ha ha ha [00:12:46] ha there's no android version [00:13:55] what's android? [00:14:14] lulz [00:24:12] tfinc_: screw google I do oldschool http://i.imgur.com/DeOjC.jpg [00:24:40] philinje: got that imei for me ? [01:18:01] preilly, tfinc_ have you been monitoring http://www.mediawiki.org/wiki/Project:Mobile_site_feedback ? [01:18:08] so much of it is junk [01:18:25] and people are giving all sorts of details [01:19:51] Thehelpfulone: yup, ive been reloading it through the day to better understand what people will send on mobile devices [01:20:22] tfinc_, I'd like to get the page oversighted so far if that's okay with you (just the history, the stuff on there that I've left can stay) [01:20:35] people have been putting phone numbers, email addresses, bank details (!) [01:20:46] remind me what happens when a page is oversighted [01:21:04] the history of the page will be inaccessible for viewing [01:21:22] except for which accounts ? [01:21:24] the existing content will remain, but the history will be hidden so only stewards can view it (or local oversighters but mediawiki.org doesn't have any) [01:21:42] if you have the global staff right you would be able to view it as well, I think [01:22:11] yes, if you are a global staff member you can also view it [01:22:39] which you are, so you would still be able to view it [01:23:30] Please send to me fuel/credit card [01:23:34] ha ha [01:23:34] tfinc_, anyone on http://meta.wikimedia.org/w/index.php?title=Special%3AGlobalUsers&username=&group=Staff&limit=50 should still be abel to view it [01:24:03] people make no sense to me sometimes [01:24:07] including preilly and MaxSem [01:24:09] etc* [01:24:17] especially since these are legitamete mobile ua's [01:24:29] legitimate* [01:25:09] tfinc_ so okay with oversighting the page? [01:25:50] Thehelpfulone: im fine as long as philinje and i can still see all the noise later [01:25:59] we'll need to think about how beset to filter it [01:26:36] hmm, you will be able to see it, philinje is not in the global staff group so he won't be able to [01:27:02] of course, if he signs the whole Contract of Doom then he should be able to see it to (if he gets global staff) [01:27:02] philinje: --^ [01:30:36] philinje: i have android app release dates. where would you like me to put them? [01:40:38] tfinc_meetings: I'm going to request the oversight, it can always be undone if needs be [01:40:45] ok [01:46:14] tfinc_: Did Geoff sign off on the user agents or somebody else from legal? [01:46:22] question from the steward oversighting [01:47:06] Thehelpfulone: yup [01:59:01] time for me to head out [08:57:21] New patchset: Jdlrobson; "settings page (incomplete early prototype)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8343 [09:06:40] hey jd [09:06:42] damn [09:06:44] tabfail [10:55:50] New patchset: Jdlrobson; "adjust transitions for change to full screen search" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8744 [11:30:16] New patchset: Jdlrobson; "fix broken tests" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8745 [11:30:17] New patchset: Jdlrobson; "remove tests moved to mf-navigation-legacy test" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8746 [12:55:13] New patchset: Jdlrobson; "settings page (incomplete early prototype)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8343 [12:56:42] New review: Jdlrobson; "See commit message" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/8343 [13:35:44] New patchset: Jdlrobson; "add beta class to body tag when beta enabled" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8757 [13:35:45] New patchset: Jdlrobson; "close section link in beta" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8758 [13:39:10] New patchset: Jdlrobson; "don't keep menu open when clicking menu items" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8759 [13:43:58] phewwwww [13:44:09] visa, at last [13:53:12] New patchset: Jdlrobson; "give navigation icons a min-width" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8762 [13:53:26] * YuviPanda looks around [14:02:07] New patchset: Jdlrobson; "deal with landscape differently" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8764 [14:02:39] jdlrobson, I tried browsing WP today - references didn't work for me in beta [14:02:50] really? [14:02:53] that's strage [14:02:59] * jdlrobson looks [14:03:59] so they don't.. interesting [14:05:43] New patchset: Jdlrobson; "settings page (incomplete early prototype)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8343 [14:06:08] New review: Jdlrobson; "See outstanding TODOs in commit message" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/8343 [14:08:35] so MaxSem apparently something is hiding references [14:08:37] bug fix on way [14:14:30] New patchset: Jdlrobson; "increment z-index of references on beta" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8766 [14:16:01] MaxSem: fixed. ^ [14:16:25] MaxSem: I did some work on the settings page again today [14:16:28] it's getting there [14:16:34] great [14:17:07] I couldn't work out how to make the disable images checkbox behave the same as the beta [14:17:19] the beta you check it and hit save and then it basically reloads the page with it checked [14:17:31] on disable images you have to refresh the page (as it sets a cookie) [14:19:12] I'll handle it [14:20:25] awesome thanks [14:22:48] brb [15:21:19] [WikipediaMobile] brion pushed 1 new commit to master: http://git.io/KJCY5w [15:21:19] [WikipediaMobile/master] win8: disable pin/unpin on non-articles to avoid crash - Brion Vibber [15:22:00] MaxSem: how does one define the title of a special page? [15:22:33] $this->getOutput()->setPageTitle() [15:23:25] or something like that, I rely heavily on autocompletion [15:23:52] autocompletion on PHP? [15:25:25] should that be at the top of execute MaxSem [15:25:52] YuviPanda, yes. and actually in more than one IDE [15:26:00] jdlrobson, yes [15:28:52] New patchset: Jdlrobson; "Add settings page" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8343 [15:29:13] New review: Jdlrobson; "Awaiting help from MaxSem" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/8343 [15:39:06] [WikipediaMobile] brion pushed 2 new commits to master: http://git.io/dD9S_w [15:39:06] [WikipediaMobile/master] win8: fix order of operations on startup - Brion Vibber [15:39:06] [WikipediaMobile/master] win8: avoid scroll problem when switching to snapped - Brion Vibber [15:58:30] jdlrobson, a note on HTML safety: wfMsg() returns unescaped data just like getLocalURL() so they should be either escaped or embedded in HTML via the Html class [15:58:39] I'll fix that [16:02:45] $this->msg( 'mobile-frontend-logged-in', htmlspecialchars( $username ) )->text(); is a mix of escaped and unescaped data [16:14:39] jdlrobson: are the blackberry fixes tested and ready to goout? [16:14:48] they should be tfinc .. there was just the one [16:15:34] tfinc its merged > https://gerrit.wikimedia.org/r/#/c/8620/ [16:15:47] preilly: awjr can one of you fast track that deployment ? [16:15:54] eh? [16:16:13] tfinc: you mean push this out? https://gerrit.wikimedia.org/r/#/c/8620/ [16:16:28] yeah, its a pretty broken experience as https://twitter.com/daramandaa/status/205493199186300929 points out [16:16:46] tfinc give me a sec - lemme see where things are at right now [16:17:40] jdlrobson: message https://twitter.com/daramandaa/status/205493199186300929 if there is a place she could test the fix [16:17:49] awjr: thanks [16:18:13] hmm there are a lot of deployments today [16:18:19] i can try to do it right now [16:18:28] * awjr gulps down his coffee [16:18:28] and another https://twitter.com/akosipv/status/205649895036698625 [16:18:57] and another https://twitter.com/#!/Bheki_K [16:19:14] https://twitter.com/Bheki_K/status/205620210458296320 [16:19:34] jdlrobson you gonna be around for a bit longer? [16:19:44] ok tfinc will do [16:20:20] jdlrobson: awjr if you can't deploy it today then schedule something for tomorrow and put the fix on a test site so that we can see if it fixes it for the users who are reporting it [16:20:31] no deploying on friday [16:20:34] ! [16:20:40] i'll get it out now [16:20:54] that works for me:) [16:21:55] awjr tfinc should I message them a link to labs ? [16:22:06] http://wikitech.wikimedia.org/index.php?title=Software_deployments&action=historysubmit&diff=47397&oldid=47396 [16:22:24] jdlrobson: it'll likely just be live in a few minutes :) [16:22:35] k sweet. poke me when done and I'll message them [16:23:06] jdlrobson cool i'll probably be ready for you to test on testwiki [16:23:10] in like 15 minutes [16:23:17] sweet [16:23:24] i'll boot up the horrible blackberry device [16:23:29] (on perfecto) [16:23:40] blackberry is the new ie6 [16:26:08] * tfinc hates bb [16:26:33] * jdlrobson gives tfinc a cookie [16:28:00] jdlrobson i thinik i need to just cherrypick that change for now [16:28:09] there's some big stuff sitting in master [16:28:10] sounds good [16:28:38] tfinc: new settings page is looking cool now [16:28:51] im excited to see it [16:29:26] it'll grow a lot over the next couple of months [16:29:34] errgg the curve is offline on perfecto [16:29:42] tfinc: i'll get it on labs for you [16:29:44] preilly are you around? [16:29:52] * YuviPanda pokes THO|Cloud  [16:30:16] first pass (that your doing now) will cover our existing mobile options. second pass (after all the initial nav work) will hit a lot of desktop user config options [16:30:40] jdlrobson: awjr i can help test when i get into the office ... about 45min from now [16:31:15] YuviPanda: http://randymcmillan.github.com/WikiCleaverView/ [16:31:34] tfinc: >http://mobile-geo.wmflabs.org/w/index.php/Special:MobileOptions [16:31:44] sweet! [16:32:08] jdlrobson: simple beta join FTW! [16:32:47] tfinc: is there a BB here i can access? [16:33:43] YuviPanda: response to or retweet https://twitter.com/RandyMcMillan/status/205558610745507840 [16:33:59] philinje: there are two in the cabinet and i have one with me thats coming back to the office [16:34:13] there is a curve and bold in the cabinet right now and i have a pearl on me [16:35:01] YuviPanda: on @WikimediaMobile of course [16:35:07] jdlrobson, speaking of page title, should we mention that these settings are mobile-only? [16:36:20] with the second pass i'll want use to look at how many of these options can be regular mw settings and push them to core [16:36:30] we might even want to consider it sooner [16:36:40] tfinc: oh well, locked [16:37:02] let me pm you the key location. its super secret [16:37:37] philinje: ok .. pm'd you the location of the key [16:37:50] does it say 'look under the cabinet'? [16:38:00] YuviPanda: its even more secret then that [16:38:07] sorry... my friend just arrived and he's managed to jam my doorbell and its deafening .. I need to go down with a screwdriver and sort it out.. :/ [16:38:11] inside the cabinet? [16:39:15] jdlrobson: philinje i see that we have a 'log in' link in the config settings. lets either a) avoid having it on the first release or b) understand what needs to change within the interface *when* someone logs in [16:39:52] that's not supposed to be there [16:40:05] tfinc: can't pm backk but got it [16:40:17] ok ... if i keep this up i'll never get into the office. i'm packing up and heading in [16:41:41] back [16:43:14] I like how minecraft beta is higher up in search results for wikipedia beta than wikipedia beta itself [16:45:47] YuviPanda, have you tried searching for "miserable failure"? [16:46:21] now that's just mean :P [16:52:42] New patchset: awjrichards; "Refactoring of option cookies" [mediawiki/extensions/MobileFrontend] (20120524-hotfix) - https://gerrit.wikimedia.org/r/8787 [16:52:44] New patchset: awjrichards; "Remove deadbeef" [mediawiki/extensions/MobileFrontend] (20120524-hotfix) - https://gerrit.wikimedia.org/r/8788 [16:52:45] New patchset: awjrichards; "Don't display two similar headings on beta opt in/out forms" [mediawiki/extensions/MobileFrontend] (20120524-hotfix) - https://gerrit.wikimedia.org/r/8789 [16:52:46] New patchset: awjrichards; "use history api to avoid problems with buggy browsers (bug 37059)" [mediawiki/extensions/MobileFrontend] (20120524-hotfix) - https://gerrit.wikimedia.org/r/8790 [16:52:46] New patchset: awjrichards; "Simplify robots and Apple touch icon outputting" [mediawiki/extensions/MobileFrontend] (20120524-hotfix) - https://gerrit.wikimedia.org/r/8791 [16:52:47] New patchset: awjrichards; "remove last edited information from footer" [mediawiki/extensions/MobileFrontend] (20120524-hotfix) - https://gerrit.wikimedia.org/r/8792 [16:52:48] New patchset: awjrichards; "Localisation updates from http://translatewiki.net." [mediawiki/extensions/MobileFrontend] (20120524-hotfix) - https://gerrit.wikimedia.org/r/8793 [16:52:50] gah fuck [16:52:57] awjr: how long till its up.. i have to run soon [16:53:04] my first set of leaving drinks [16:53:17] jdlrobson i might not be able to get this done in time [16:53:32] jdlrobson one more try [16:53:51] Change abandoned: awjrichards; "(no reason)" [mediawiki/extensions/MobileFrontend] (20120524-hotfix) - https://gerrit.wikimedia.org/r/8787 [16:54:03] Change abandoned: awjrichards; "(no reason)" [mediawiki/extensions/MobileFrontend] (20120524-hotfix) - https://gerrit.wikimedia.org/r/8788 [16:54:16] Change abandoned: awjrichards; "(no reason)" [mediawiki/extensions/MobileFrontend] (20120524-hotfix) - https://gerrit.wikimedia.org/r/8789 [16:54:41] Change abandoned: awjrichards; "(no reason)" [mediawiki/extensions/MobileFrontend] (20120524-hotfix) - https://gerrit.wikimedia.org/r/8790 [16:57:28] Change abandoned: awjrichards; "(no reason)" [mediawiki/extensions/MobileFrontend] (20120524-hotfix) - https://gerrit.wikimedia.org/r/8791 [16:57:40] Change abandoned: awjrichards; "(no reason)" [mediawiki/extensions/MobileFrontend] (20120524-hotfix) - https://gerrit.wikimedia.org/r/8792 [16:57:51] Change abandoned: awjrichards; "(no reason)" [mediawiki/extensions/MobileFrontend] (20120524-hotfix) - https://gerrit.wikimedia.org/r/8793 [17:01:03] New patchset: awjrichards; "use history api to avoid problems with buggy browsers (bug 37059)" [mediawiki/extensions/MobileFrontend] (20120524-jdlrobson-hotfix) - https://gerrit.wikimedia.org/r/8796 [17:01:04] New patchset: awjrichards; "Create 20120524-jdlrobson-hotfix branch and update .gitreview" [mediawiki/extensions/MobileFrontend] (20120524-jdlrobson-hotfix) - https://gerrit.wikimedia.org/r/8797 [17:01:24] New review: awjrichards; "(no comment)" [mediawiki/extensions/MobileFrontend] (20120524-jdlrobson-hotfix); V: 1 C: 2; - https://gerrit.wikimedia.org/r/8797 [17:01:34] New review: awjrichards; "(no comment)" [mediawiki/extensions/MobileFrontend] (20120524-jdlrobson-hotfix); V: 1 C: 2; - https://gerrit.wikimedia.org/r/8796 [17:01:36] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (20120524-jdlrobson-hotfix) - https://gerrit.wikimedia.org/r/8797 [17:01:37] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (20120524-jdlrobson-hotfix) - https://gerrit.wikimedia.org/r/8796 [17:04:46] preilly: 1.7-migration looks fine on Android [17:05:46] not seeing the problem on BB Storm2 [17:08:16] YuviPanda: how about on iOS [17:08:29] testing the android bits a bit more, will push to iOS after that [17:09:23] jdlrobson: changes should be live on test [17:10:10] jdlrobson once you verify it should just take a second to sync out [17:11:30] awjr: i can't get access to my blackberry and have to rush off now :( [17:11:41] shit really? [17:11:47] yeehh sorry :( [17:11:52] perfecto has a habit of taking devices offline [17:12:02] then we have to abort, we've already run into someone else's deployment window [17:12:12] and i've told people i'll meet them at 6pm :( [17:12:18] (its 6.12pm now) [17:12:25] tfinc are you in the office? [17:12:36] the answer is no [17:12:37] the problem is not universal on BB's [17:13:11] awjr: i tested this patch lots on my local if that makes you feel better.. [17:13:32] jdlrobson doing a quick litmus test on test.m.wikipedia.org things generally look OK [17:13:48] it's probably safe to push out and test later [17:14:26] jdlrobson im going to go ahead and push it out [17:14:26] oohh blackberry is back [17:14:29] i can verify quickly [17:14:33] oo plz do [17:17:56] sorry the cursor speed is sooooo slow [17:18:18] hehehe no worries i know perfecto can be a major pita [17:19:44] still scrolling... [17:22:02] MaxSem: so, http://en.wikipedia.org/w/api.php?action=mobileview&format=json&page=Main_Page seems to be pretty outdatd [17:22:09] ok now I can see it but its still scrolling [17:22:09] compared to http://en.wikipedia.org/wiki/Main_Page [17:22:15] i'm waiting for my click to kick in [17:22:23] MaxSem: looks like a cache bug with main page content? [17:22:48] * YuviPanda goes to file a bug [17:22:55] now the cursor has disappeared [17:23:23] fml [17:23:23] grr [17:23:30] what are you checking - the drop-down menu? [17:23:53] MaxSem: https://bugzilla.wikimedia.org/show_bug.cgi?id=37097 [17:23:54] the sections philinje [17:23:59] on a blackberry v5 [17:24:04] i'm about to give up [17:24:07] I can't work this emulator [17:24:10] thanks YuviPanda [17:24:14] it seems to be frozen now [17:25:51] so awjr I can't seem to get sections to open at all here [17:25:55] but at least they are not infinite looping [17:26:01] but now i reaalllly need to go [17:26:12] jdlrobson: should i push the change or wait? [17:26:21] push it as it might be jus a perfecto problem [17:26:27] I tested it previously and it had worked fine [17:26:33] k [17:26:44] just make sure we don't make any bold statements such as this is definitely fixed now [17:26:48] i'll check again tomorrow [17:26:49] heh ok [17:26:51] pushing now [17:26:57] sorry to be a pain [17:26:58] have fun! [17:27:01] see ya! [17:27:03] no worries i know how it goes [17:27:43] awjr: what problem are we checking exactly? [17:29:09] philinje: https://bugzilla.wikimedia.org/show_bug.cgi?id=37059 [17:33:49] greetings all [17:36:29] whattup tfinc [17:37:33] philinje: https://twitter.com/akosipv/status/205649895036698625 & https://twitter.com/Bheki_K/status/205620210458296320 [17:41:01] awjr: thanks for getting the fix out. philinje is going to be following up with the other twitter users to see if we have more issues [17:41:22] tfinc: do you have a reliable way to test the fix? jon was not 100% sure about it [17:41:45] perfecto was giving him a ton of trouble before he had to go [17:42:34] preilly: looks very good on android. But iOS doesn't even load up the bottom bar. [17:42:49] seems to have crapped out someplace, so no logs either - right from the start [17:45:52] YuviPanda: hmm it works for me [17:46:59] ah, new commits since my last pull. [17:47:01] sorry preilly. [17:47:02] it does work [17:47:25] hmm, ERROR: Plugin 'ActionSheet' not found, or is not a CDVPlugin. Check your plugin mapping in Cordova.plist. [17:48:33] ah, adding that to the plist fixes it [17:52:32] [WikipediaMobile] preillyme pushed 1 new commit to 1.7-migration: http://git.io/443tVw [17:52:32] [WikipediaMobile/1.7-migration] add back action sheet plugin - Patrick Reilly [17:52:37] awjr: im testing on deivce right now [17:52:45] tfinc: ty [17:53:08] YuviPanda: so does iOS look good now? [17:53:20] yes preilly. Checking if the fb plugin works okay now [17:53:23] tfinc: so it appears that the 1.7 migration looks good for Android [17:53:38] nice [17:53:40] tfinc: YuviPanda is still testing the iOS version of 1.7 migration [17:54:14] awjr: issue still exists. i can duplicate on device [17:54:30] :( [17:55:31] tfinc: it only took 96 changed files with 26,256 additions and 9,417 deletions to migrate to 1.7.0 [17:55:39] tfinc where were you testing? [17:56:13] preilly when you've got a sec can you verify that this is correct: http://www.mediawiki.org/wiki/Extension:MobileFrontend/Deployments/2012-05-22 [17:56:26] no rush [17:56:56] awjr: on device with an article off the main page [17:57:06] tfinc: oh i meant which project - enwiki? [17:57:22] yes [17:57:28] that sucks [17:57:35] lemme verify js [17:59:30] tfinc yeah im seeing the updated js on enwiki, so i guess it just doesnt quite work [17:59:48] preilly: it crashes the fb plugin :( [18:01:50] tfinc out of curiosity will you try again but with ?debug=true in the query string? [18:04:08] FAIL: https://threatpost.com/en_us/blogs/yahoo-includes-private-key-source-file-axis-chrome-extension-052412 [18:04:15] awjr: sure [18:05:23] wow this is a super annoying bug. i can't get the browser to stop refreshing [18:05:26] no wonder our users are pissed [18:06:18] :( [18:07:19] tfinc jon said he was able to verify that it worked it for him locally (before we pushed(, so i dunno what's wrong. i'm seeing the JS updates on enwiki, at least [18:07:29] to be fair. i dont see how people can use the black berry browser in general. i'd take a ie5 over this any day [18:07:39] owch [18:11:07] awjr: ohh .. with debug=true it works fine :D [18:11:29] tfinc: can you clear your cache and retry w/o debug=true? [18:11:29] was i getting an old cached copy before ? [18:11:32] maybe [18:11:39] i hope [18:11:46] or do we now have a special debug option that makes things actually work ? [18:11:49] clearing cache [18:12:56] New patchset: MaxSem; "Add settings page" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8343 [18:13:31] New review: MaxSem; "Still needs some work:" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/8343 [18:14:46] awjr, do you know how that redirector thigie is invoked? [18:15:00] MaxSem: from squid [18:15:29] awjr: initial test looks good. i'll resovle the bug after one more test. my only problem is that i may take a jackhammer to this phone before [18:15:58] lol and phew [18:16:23] preilly, yeah. I mean how easy is it to configure its command-line parameters, does it require a squid recompile or something? [18:17:20] MaxSem: take a look at http://wiki.squid-cache.org/Features/Redirectors [18:19:19] i serioulsy cant begin to understand how people would use/design/build these phones. its such a piece of crap [18:19:38] the keyboard is the *only* thing that's worthwhile about that phone [18:28:38] preilly: nope, facebook plugin still out of action. Otherwise looks good [18:30:29] preilly: https://bugzilla.wikimedia.org/show_bug.cgi?id=37093 [18:31:58] YuviPanda: okay [18:50:23] New patchset: MaxSem; "Bug 37097 - stuck action=mobileview cache" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8814 [18:55:21] anybody else getting js errors in master of MF? [18:57:49] awjr, mw.loader.state()? [18:57:50] alright, am off now. [18:57:57] visa interview tomorrow :) [18:58:04] MaxSem: thanks for the fix :) [18:58:06] huh mw is not defined [18:58:07] weird [18:58:12] gnite everyone [18:58:19] MaxSem the error im getting is . Uncaught ReferenceError: MobileFrontend is not defined http://mobiletest.m.localhost.org/mobile_dev/index.php?title=Main_Page&Adsf=&mobileaction=toggle_view_mobile [18:58:20] . window.onload [18:58:35] awjr, update core [18:59:07] MaxSem same problem [18:59:35] something wonky with RL? [19:00:25] awjr, you're loading non-raw modules. this is possible only when its support is not present [19:01:27] awjr, does includes/resourceloader/ResourceLoaderModule.php contain isRaw() for you? [19:02:00] YuviPanda: where is [FB-APP-ID]? [19:03:51] [WikipediaMobile] preillyme pushed 1 new commit to 1.7-migration: http://git.io/kH0x0w [19:03:51] [WikipediaMobile/1.7-migration] Cordova rename changes - Patrick Reilly [19:04:06] preilly_: it's from the fb dev console. tfinc has access and the app id, poke him to get it? [19:04:30] YuviPanda: can you try it again with my latest commit [19:04:50] MaxSem i figured it out - xhprof was not playing nicely due to a misconfiguration [19:04:58] thanks! [19:07:36] [WikipediaMobile] preillyme pushed 1 new commit to 1.7-migration: http://git.io/zeSsLA [19:07:36] [WikipediaMobile/1.7-migration] fix plugin reference - Patrick Reilly [19:07:58] YuviPanda: actually with my latest [19:08:35] preilly_: okay [19:09:34] YuviPanda: thanks! [19:12:24] YuviPanda: check this out https://www.mediawiki.org/wiki/File:Odd_state_flipping_in_Android_app.ogv [19:12:36] it's flipping between two articles over and over [19:12:39] WEIIRD :) [19:13:34] preilly_: works :) [19:13:54] brion: ugh. WIll look at it tomorrow. Visa interview in ~8 hours, should catch some sleep :) [19:14:00] [WikipediaMobile] preillyme pushed 1 new commit to 1.7-migration: http://git.io/Y17gKw [19:14:00] [WikipediaMobile/1.7-migration] fix cordova issues - Patrick Reilly [19:14:11] sleep well :) [19:14:21] thanks preilly_ [19:20:22] tfinc: iOS works with 1.7 migration [19:21:25] \o/ [19:30:36] brion: thanks! [19:38:47] [WikipediaMobile] preillyme pushed 1 new commit to 1.7-migration: http://git.io/X2PwdA [19:38:47] [WikipediaMobile/1.7-migration] do not use appViewController use viewController - Patrick Reilly [19:46:30] [WikipediaMobile] preillyme pushed 1 new commit to 1.7-migration: http://git.io/CtI6RQ [19:46:30] [WikipediaMobile/1.7-migration] rename registerPGHttpURLProtocol to registerURLProtocol - Patrick Reilly [20:01:16] [WikipediaMobile] preillyme pushed 1 new commit to 1.7-migration: http://git.io/E9cjbA [20:01:16] [WikipediaMobile/1.7-migration] use CDV.FB instead of window.plugins.FB - Patrick Reilly [20:24:14] woot for the migration! [20:24:21] which branch can i test off of ? [20:29:40] New patchset: L10n-bot; "Localisation updates from http://translatewiki.net." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8838 [20:35:22] stupid samsung copying the apple connector on the galaxy tab [20:35:30] out of battery and i can't charge it cause the cable's at the office [20:40:16] now i have to read books on my kindle! bah ;) [20:46:32] [WikipediaMobile] preillyme pushed 1 new commit to 1.7-migration: http://git.io/Lz02bw [20:46:32] [WikipediaMobile/1.7-migration] fix for Warning: no rule to process file '/Wikipedia-iOS/Plugins/ActionSheet/ActionSheet.js' of type sourcecode.javascript for architecture i386 - Patrick Reilly [20:46:57] o_O [20:48:50] [WikipediaMobile] preillyme pushed 1 new commit to 1.7-migration: http://git.io/vQGTUA [20:48:50] [WikipediaMobile/1.7-migration] remove unneeded Run Script in Build Phases - Patrick Reilly [20:56:09] https://www.mediawiki.org/wiki/Project:Mobile_site_feedback [20:56:14] This is getting massively abused [20:56:24] Krenair: yes, we agree [20:59:43] I wonder if Joan knows yet :P [21:07:51] awjr: arch a user on 1.19 http://wikiathletic.org/wiki/Main_Page?useformat=mobile [21:08:25] s/arch/argh [21:09:01] wait a minute... [21:09:08] there used to be a check for the existence of that function first [21:09:10] where did it go/ [21:09:15] that function only exists in 1.20 i think [21:09:18] or some version of 1.20 [21:09:36] awjr: yeah, MaxSem removed the check for it [21:09:39] ! [21:09:46] i thought we were still supporting 1.19 [21:09:56] awjr: he's logic was that we are forcing the isRaw RL change [21:10:00] nope, RL requires fresh 1.20 [21:10:14] awjr: so we no longer can support old stuff [21:10:18] er not that long ago we agreed that we would be supporting the stable version of MW [21:10:28] which is not 1.20 [21:10:58] if that's no longer the case it would be good to know :) [21:11:02] and that user is SOL [21:12:10] so … have we abandoned 1.19 support? [21:13:23] awjr: well unless we have a toggle for RL support for JS [21:13:51] awjr: I vote for configurable support for RL and added compat check back for proxy [21:14:08] preilly i concur, we should continue supporting the stable version of MW [21:14:09] awjr: we should be able to support the current stable for sure [21:14:14] yeah [21:14:48] or if we absolutely need to abandon it, then we should tag the point of divergence in git so people know where 1.19 support stops [21:14:50] MaxSem: thoughts? [21:15:56] separate support for both delivery ways would be a huge PITA [21:16:25] and once again, we're merging it into core anyway [21:17:35] but we never agreed to abandon support for 1.19 [21:17:46] so until that happens, we need to make sure that we continue supporting it [21:19:25] it seems we need an explicit decision one way or the other about 1.19 support [21:19:44] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/8838 [21:19:46] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8838 [21:20:19] What in the hell is https://www.mediawiki.org/wiki/Project:Mobile_site_feedback ? [21:20:26] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/8814 [21:20:28] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8814 [21:20:37] lol [21:20:43] I'm deleting that page. [21:20:54] Joan: an old page that our old feedback form posted to [21:21:21] old? https://www.mediawiki.org/w/index.php?title=Project:Mobile_site_feedback&action=history [21:21:30] hmm [21:21:44] Looks like there's 1 or 2 legitimate feedback posts there. [21:21:47] oh [21:21:50] Not anymore! [21:21:54] https://www.mediawiki.org/w/index.php?title=MobileFrontendFeedback is now redirecting to that page [21:22:00] Do I need to create-protect it? [21:22:12] actually i think you need to undelete it. [21:22:15] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/8744 [21:22:17] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8744 [21:22:23] And restore the spam and nonsense? [21:22:29] now it's back [21:22:35] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/8745 [21:22:37] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8745 [21:22:48] MaxSem is a notorious wheel-warrior. [21:22:50] Also, [21:22:55] we don't allow spam on Wikimedia wikis. [21:22:57] Or nonsense. [21:23:01] And that page is in the wrong namespace. [21:23:08] we need to decide what to do with this feedback, not play cowboys [21:23:10] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/8766 [21:23:12] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8766 [21:23:15] MaxSem: Excuse me? [21:23:19] The feedback? [21:23:23] yes [21:23:27] Let's read. [21:23:35] > [21:23:36] Business in Ghana [21:23:36] I am a Ghanian based businessman,and after going through your information,i believe we can establish a in Ghana,since we a fast growing country in Africa.I believe your line of business is good for us.I hope mine idea will be considered,that your company will be established in Ghana or we do business together espercially in the area of chemical.Thank you.email address mercycom17@yahoo.com. Mobilefrontend (talk) 12:27, 24 May 2012 (UTC) [21:23:39] Joan: we need to figure out how to resolve the problem itself instead of just deleting its symptoms [21:23:42] "Subcategories gone pale grey and faded over last 2 weeks" [21:23:42] > [21:23:42] > [21:23:44] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/8762 [21:23:45] I want 2 join your team sir plas try me out 18 year old 0795502274 REAGILE HOTTIE [21:23:46] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8762 [21:23:48] I want 2 join your school cricket try me out age 18 off spian right arm 4 4 batmen 0795502274 Mobilefrontend (talk) 12:36, 24 May 2012 (UTC) [21:23:52] > [21:23:54] > [21:23:57] no packet data access [21:23:59] can u please install packet data for me Mobilefrontend (talk) 12:40, 24 May 2012 (UTC) [21:24:00] Joan: if we delete the page, then the contact form will be broken on mobile devices [21:24:02] > [21:24:06] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/8764 [21:24:08] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8764 [21:24:25] awjr: And... nothing of value would be lost. [21:24:31] I'm going through getting rid of bad sections [21:24:33] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/8759 [21:24:35] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8759 [21:24:39] philinje have you seen the mobile feedback yet? [21:24:51] Joan, Berlin's next week, get off that Rechstag and take off your spiderman costume [21:24:51] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/8746 [21:24:52] You all talk about this like there's actual feedback. [21:24:53] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8746 [21:25:00] hmm, sounds like we need to revert the Contact page [21:25:01] It's feedback in the "loud noise you get when the microphone is too close" sense. [21:25:09] There's no signal. [21:25:10] It's all noise. [21:25:14] philinje: a vast majority appears to be spam or of 0 value: https://www.mediawiki.org/w/index.php?title=MobileFrontendFeedback [21:25:20] MaxSem: The city is next week? [21:25:24] yes, agreed [21:25:25] MaxSem: We don't allow spam. [21:25:29] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/8757 [21:25:55] this seems legit "I use Google App in my iPhone to see the "隐函数" through mobile wikipedia view. But the equation in this entry has lost the last part. That means I cannot see the equation completely. But when I changed to the pc view, it became well. I think you should fix this bug." [21:26:01] Oh, it's posting as a user? [21:26:04] This is so fucked up. [21:26:12] Joan: the Contact page also involves OTRS [21:26:31] philinje: In what way? [21:26:32] we really should have put a captcha on the form or something [21:26:52] awjr: that's an idea, or apply a spam filter? [21:27:13] New patchset: preilly; "add beta class to body tag when beta enabled" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8757 [21:27:14] That page needs to be moved. [21:27:26] * Joan shrugs. [21:27:42] philinje, spam filter's already applied [21:27:51] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/8757 [21:27:53] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8757 [21:27:57] MaxSem what is the spam filter? [21:28:21] Joan: can we make the page private? [21:28:26] No. [21:28:35] MediaWiki doesn't support per-page read restrictions. [21:28:39] everything that filters teh usual editing: SpamBlacklist + ConfirmEdit + AbuseFilter [21:28:39] New patchset: preilly; "close section link in beta" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8758 [21:29:02] philinje: You could make it a Special page. [21:29:12] And put the data in a separate table. [21:29:13] that's what I suggested [21:29:26] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/8758 [21:29:28] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8758 [21:29:29] I'm not sure what the hell the purpose is. [21:29:36] Are we soliiciting spam now? [21:29:39] soliciting [21:29:43] MaxSem: does that apply to API page edits by a logged in user? [21:29:49] Joan: t wa supposed to be a way for users to give us technical feedback [21:29:58] awjr: A bot, even.. [21:30:21] philinje: Have you ... ever met users? They can barely turn the device on, much less provide useful feedback. [21:30:23] awjr, yes. though our user is already autoconfirmed [21:30:29] MaxSem: And a bot. [21:30:50] How the hell did it get a bot flag?! [21:31:00] MaxSem: this seems wrong to me https://gerrit.wikimedia.org/r/#/c/8722/ [21:31:00] Probably to avoid flooding recent changes. [21:31:01] With spam. [21:31:26] Joan: we get plenty of feedback from users by email [21:31:34] philinje: Useful feedback? [21:31:37] Or Nigerian scams? [21:31:54] Yes, mostly useful. but we don't capture there user agent that way [21:31:57] MaxSem: do we really need fixLibXML [21:32:00] their [21:32:19] I've removed basically all bad sections [21:32:33] preilly, any other ideas how to fix it? this regression (from that
fix) makes non-English pages larger [21:33:22] MaxSem: well I'll approve it for now [21:33:29] MaxSem: but we should look into it more [21:33:35] so philinje i think we need to make a quick decision about how to proceed with the fedback page [21:33:37] philinje: Where should that page go? [21:33:46] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/8722 [21:33:48] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8722 [21:34:16] Isn't there a whole mobile section of the site? [21:34:19] Can't it go to some subpage? [21:34:30] Can we put user-agent into subject via a URL parameter? [21:34:43] I mean email subject [21:35:00] mailto supports ?subject=. [21:35:11] But you'll probably hit truncation issues. [21:35:30] MaxSem we could - but i think the reason they wanted to use a form instead of OTRS is for faster feedback [21:35:33] or at least one of the reasons [21:35:43] and yeah, we might run into truncation issues [21:35:55] Faster feedback? [21:36:03] Joan: by where does it go, do you mean moving the feedback page to a less visible place? [21:36:06] awjr, what kind of feedback? wiki posts are one-way communication as we can't reply to them [21:36:09] philinje: It doesn't go in the project namespace. [21:36:14] A namespace that nobody seems to understand. [21:36:21] That namespace is for pages about the MediaWiki wiki. [21:36:26] It's a meta-namespace. [21:36:33] Joan, yer suggeschenz? [21:36:36] MaxSem i belive the purpose of the form was to provide one centralized place for technical-oriented feedback [21:36:40] "Mobile site feedback" is available. [21:36:54] That matches Meta-Wiki's "Foundation wiki feedback". [21:37:06] Joan: that's fine [21:37:07] Joan, SWMTers moaned about it being in mainspace [21:37:10] it originally went to MobileFrontedFeedback [21:37:14] MaxSem: Why? [21:37:21] ask them [21:37:22] Because it's 99% spam? [21:37:34] the spam only started in the past day [21:37:47] philinje and it wont stop til we do something about it [21:38:01] once spammers realize there's an easy vector they won't stop [21:38:26] philinje: Most of the page history seems to have been obscured. [21:38:30] I'm not sure why. [21:38:44] even before that the feedback consisted mostly of nonsense [21:38:55] tomasz is back [21:39:33] hehehe MaxSem that is likely true [21:40:08] i think that's unavoidable when you put up a form with no real crap prevention mechanism on a top-5 website :p [21:40:18] I moved the page. [21:40:33] ok, where? [21:40:42] https://www.mediawiki.org/wiki/Mobile_site_feedback [21:40:58] awjr, I actually put crap protection into it: "feedback" has to be at least 20 chars [21:41:07] think that gets us back to the original problem [21:41:12] Joan, well, that won't work [21:41:14] i mean the location [21:41:15] MaxSem i was asked to remove that restriction [21:41:20] MaxSem: Why not? [21:41:27] awjr, why? [21:41:40] Joan, because of the way it posts stuff [21:41:40] It looks like the page history has been supressed. [21:41:48] MaxSem: That doesn't make any sense. [21:41:50] MaxSem: it was me, because 20 characters seemed too long [21:42:07] MaxSem: You mean it doesn't follow redirects or something? [21:42:12] MaxSem: 20 character restriction would not stop the crap that's showed up on the page anyway [21:42:20] philinje, can you imagine a shorter yet sensible feedback? [21:42:23] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: -1; - https://gerrit.wikimedia.org/r/8343 [21:42:29] "lol" [21:42:31] a captcha is probably the best solution, but captcha sucks on mobile devices [21:42:35] "what is this" [21:42:44] MaxSem: it was me, because 20 characters seemed too long [21:42:45] ... [21:42:47] CAPTCHAs are pretty awful on desktop computers too. [21:42:57] Can you make a useful feedback post in 20 characters? [21:43:10] Characters or bytes? [21:43:14] you probably can in kanji [21:43:22] awjr: lol [21:43:26] Just "This is a sentence." is 20 characters ffs [21:43:36] awjr, ...but we will not read it;) [21:43:50] Krenair: 19, isn't it? [21:43:56] ok … arguing about character length is not really productive to the issue at hand [21:44:04] is changing the character validation a code push or a config change? [21:44:12] code change [21:44:15] Joan, okay, just under 20 characters then :p [21:44:18] but philinje i do not think it will stop the problem. [21:44:26] awjr: You mixed the two. Code push or config change. [21:44:27] most of the crap on that page is over 20 chars [21:44:37] awjr: true [21:44:46] lol Joan thanks - it is a code change followed by a code push [21:44:57] but again, i think it is not an actual fix [21:45:00] I agree. [21:45:31] should we revert? [21:45:55] i dont htink we need to revert per se [21:46:06] but we could disable the feedback form itself for the time being while we figure out what to do [21:46:14]
[21:46:21] Are we boycoting
? [21:46:25] boycotting [21:46:29] God I can't type today. :-( [21:46:30] we could even have the 'technical feedback' point to an otrs email address for now [21:46:41] which actually might even just be a config change [21:46:43] lemme dbl check [21:47:04] ok [21:48:14] i take it back - it would require a code change [21:48:24] but that's not really a huge deal [21:49:11] i could probably have a good fix done and deployed by EOD [21:49:24] awjr: ok, disabling the form? [21:49:40] philinje: yeah and instead making 'Technical feedback' point to an otrs address [21:51:30] oh, but which address [21:51:33] philinje does that sound ok? if so, can you provide me with an OTRS email address to use? [21:51:38] :p [21:51:57] how about mobile-feedback-l [21:52:49] philinje does that exist? [21:53:09] yes, but we would get flooded [21:53:32] philinje well, it would be easy to filter [21:53:49] philinje becaues all subject lines would be prefaced with [Mobile feedback] as things are currently configured [21:55:44] awjr: but we get lots of useful feedback currently there [21:55:51] maybe we can create another alias [21:57:53] and i'm back [21:58:10] philinje ok - how about i just start hacking the fix into the code while you figure out the best email address to use? [21:58:11] Thank God. [21:58:40] awjr: ok [21:59:01] so is the basic issue that were seeing a really really high noise ration on the feedback form ? [21:59:13] yes [21:59:26] its impressive to see this many diverse mobile ua's spamming us [21:59:29] go internet [21:59:40] your free time continues to impress me [22:00:22] another code change - more than 20-character validation in message field? [22:00:40] sorry, no more message fielf [22:00:42] field [22:00:45] philinje i can do it but i think it's a red-herring [22:00:50] https://www.mediawiki.org/wiki/Project:Mobile_site_feedback [22:00:57] most of those have more than 20 chars in the message field. [22:01:21] philinje also the change im making will make the form go away, so the message length will be irrelevant [22:01:28] yes [22:03:12] or, just eliminate the technical feedback section altogether [22:03:54] (in terms of the UI) [22:04:11] would still be good to use that functionality n some other way [22:08:17] awjr: let's use mobile-feedback-l for now [22:08:52] tomasz points out Google will spam filter that to some degree [22:18:04] Philippe just said their message flow it's "minimally disruptive - Basically, we can handle it. Mobile folks will need to have some method of providing feeedback. If not this, then what?" [22:23:36] awjr: i just requested a new email alias from IT, if that gets done soon, let's use that [22:24:04] philinje ok that will be an easy config change later on anyway [22:24:11] philinje i'm almost done with the fix [22:24:27] awjr: great, thanks [22:24:30] philinje: the UploadWizard campaign API I added for the WLM mobile app is now live, so i'll be able to start querying from it in the app soon [22:24:44] philinje: awjr did either of you guys tweet about the blackberry fix that went out today? [22:24:51] brion: nice [22:25:37] nm .. i see it [22:32:22] New patchset: awjrichards; "* Makes feedback form for technical problems appear only if there is not a link configured for techcnical problem feedback * Changes getFeedbackHtml() to renderFeedbackHtml() since the method was already partially rendering the HTML anyway. Now it renders" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8873 [22:32:35] prielly can you take a look at ^ [22:33:05] it will allow us to temporarily disable the feedback form and instead expose a mailto link [22:33:12] or really, any link [22:34:36] New patchset: awjrichards; "* Makes feedback form for technical problems appear only if there is not a link configured for techcnical problem feedback * Changes getFeedbackHtml() to renderFeedbackHtml() since the method was already partially rendering the HTML anyway. Now it renders" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8873 [22:36:12] or MaxSem ^ [22:36:45] trailing ws [22:36:56] MaxSem look at patchset 2 [22:39:33] $feedbackTechnicalLink and friends don't seem to be HTML-escaped, but that's not new [22:40:34] otherwise looks good [22:40:45] ok cool [22:41:05] MaxSem those links come from configuration so in theory they should be safe, but i think you're right - they should still be escaped [22:41:46] tfinc: yes, i tweeted the BB fix right after it happened [22:42:06] it's also a matter of validity in addition to security [22:42:21] brion: awesome :D [22:42:50] philinje: brion http://www.macrumors.com/2012/05/24/facebook-launches-new-iphone-app-dedicated-to-posting-and-sharing-photos/ [22:43:58] tfinc: why they don't just fix the camera interface in their main app is a mystery to me [22:44:40] im sure the seperate app is a way to experiment more [22:44:46] true [22:44:47] it'll be folded in eventually [22:44:56] tfinc: this app is independent of Instagram [22:44:58] ? [22:45:02] philinje: correct [22:46:47] philinje: whats a good time to do a blog post on the new nav interface ? [22:47:56] New patchset: awjrichards; "* Makes feedback form for technical problems appear only if there is not a link configured for techcnical problem feedback * Changes getFeedbackHtml() to renderFeedbackHtml() since the method was already partially rendering the HTML anyway. Now it renders" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8873 [22:48:05] MaxSem - with escaping ^ [22:48:24] tfinc: well, we were targeting a real beta release next Mon/Tu, so maybe after that is stable? [22:48:29] ok [22:52:26] preilly can you approve https://gerrit.wikimedia.org/r/8873 [22:55:47] tfinc: is preilly around? i need to get that change approved and merged so i can deploy it to stop the spamflood on the feedback page [22:57:21] philinje ^ [22:57:45] awjr: looks like preilly is not at his desk, sorry [22:58:03] awjr: thanks for getting this done [22:58:09] np [22:58:27] i should have an email address from IT shortly [22:58:56] New review: awjrichards; "MaxSem claimed this looks OK" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/8873 [22:58:57] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8873 [22:59:46] tfinc: he should be back soon [23:01:34] New patchset: awjrichards; "* Makes feedback form for technical problems appear only if there is not a link configured for techcnical problem feedback * Changes getFeedbackHtml() to renderFeedbackHtml() since the method was already partially rendering the HTML anyway. Now it renders" [mediawiki/extensions/MobileFrontend] (20120524-jdlrobson-hotfix) - https://gerrit.wikimedia.org/r/8874 [23:01:54] New review: awjrichards; "(no comment)" [mediawiki/extensions/MobileFrontend] (20120524-jdlrobson-hotfix); V: 1 C: 2; - https://gerrit.wikimedia.org/r/8874 [23:01:56] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (20120524-jdlrobson-hotfix) - https://gerrit.wikimedia.org/r/8874 [23:09:15] wow ... they guys @ http://duolingo.com/ created a really nice interface [23:12:16] tfinc: ben's company [23:13:50] awjr: the email to use: feedbacktest@wikimedia.org [23:15:36] preilly tfinc no that's a separate co [23:15:44] ben's company is colingo.com [23:15:48] awjr: what is the name of his? [23:15:51] ha ha [23:15:52] colingo [23:16:01] duolingo is like recaptcha but for translating the internet [23:16:12] and the dude totally stole the name [23:16:23] philinje: ok cool - im pushing the changes now. [23:17:09] awjr: great [23:19:03] i think colingo and duolingo should team up - duolingo would be a really cool tool to have available in colingo [23:35:11] philinje: fix is live [23:37:51] philinje i also configured the feedback email for technical problems to include the user's UA in the body. lemme know if it does not look ok [23:38:59] Joan: i just pushed a change that disables the mobile feedback form and instead exposes a mailto link for technical problems [23:39:27] Joan so there shouldn't be any more posts to the feedback page - at least not from MobileFrontend [23:58:06] philinje can you please verify the contact form changes are OK? im going to be heading out soon