[00:01:40] awjr: so we need to add an alternative to RL to maintain compatibility [00:02:03] awjr: as well as the proxy check and work around [00:03:12] preilly: the proxy check already had a backwards compatibility check around it [00:03:46] awjr: yeah, that needs to be put back [00:04:02] preilly lemme see if ic an find the old code and fix it [00:04:11] awjr: it's the RL one that is the bigger issue [00:04:14] as for RL im not sure what the best approach is [00:04:15] yeah [00:04:21] awjr: e.g., two separate code paths [00:04:48] awjr: or maybe come up with a way around isRaw [00:05:30] philinje: I'm not sure we can do multitouch pinch-zoom on the map view in Android 2.x in PhoneGap; multitouch events don't seem to work until Android 3 & 4 [00:05:50] if it's important, we may want to consider a native android app instead -- i can prototype this in a couple days if you like [00:06:54] plus side is that gives us native-looking widgets free ;) [00:07:04] minus side is if we do decide to do an iphone version it'll be more work [00:07:10] downside is maintence and any kind of support [00:07:20] awjr: https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/MobileFrontend.git;a=commitdiff;h=59fa8d9a7071849c01b305e8a840664bdc462319 [00:07:31] *nod* that too [00:07:53] preilly yup [00:08:08] i'd soner remove the feature then do the native app [00:08:41] preilly can we still get rid of sendApplicationVersionVaryHeader? [00:08:49] or is that needed for compatibility/ [00:09:01] awjr: it can go [00:09:10] okidoke [00:09:15] i'll add the rest back in [00:09:15] i wish android were a lot better about pushing updates out, sigh [00:09:19] this seems fixed on 4.0 [00:12:01] no one has 4.0 [00:12:08] i do ;) [00:12:19] brion: its funny we have the same amount of traffic from 4.0 as 2.1 ;) [00:12:21] to the site [00:12:23] bah [00:12:31] how sad of a rollout is that [00:12:35] FAIL [00:12:56] it sounds like it may be possible to detect pinch-zoom gestures from the java side (as a phonegap plugin) and pass the event in; that may be good enough to do basic zoom in/out [00:12:59] i'll look into it [00:13:48] now if i can just find my nexus 1, i seem to have misplaced it :PPP [00:14:06] found it \p/ [00:14:06] brion: we have plenty of them in the office [00:14:57] awjr: also this is the isRaw change https://gerrit.wikimedia.org/r/#/c/7302/ [00:15:48] awjr: we might be able to substitute the old version with the new behavior [00:15:58] awjr: on older MW installs [00:16:59] awjr: it looks like you really only need to effect "Update module states" [00:17:20] awjr: e.g., line 774 of https://gerrit.wikimedia.org/r/#/c/7302/2/includes/resourceloader/ResourceLoader.php [00:17:36] awjr: s/774/772 [00:17:41] awjr: sorry wrong line [00:19:26] New patchset: awjrichards; "Reintroduces changes removed in 59fa8d9a7071849c01b305e8a840664bdc462319 that broke MW 1.19 compatibility." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8882 [00:22:04] preilly that makes sense - you mean just add the isRaw() functionality locally to MF for older MW versions? [00:27:08] awjr: yeah basically [00:35:09] ok i gotta jet [00:35:15] talk to you all tomorrow [00:37:47] awjr: https://www.google.com/search?sugexp=chrome,mod=12&sourceid=chrome&ie=UTF-8&q=gerrit+max+trustedproxy#hl=en&sclient=psy-ab&q=site%3Agerrit.wikimedia.org+%22Jon+Robson%22+%22background%3A+%23f9f9f9%3B%22&oq=site:gerrit.wikimedia.org+%22Jon+Robson%22+%22background%3A+%23f9f9f9%3B%22 [00:37:47] awjr: so google is better at searching gerrit that gerrit is [00:37:47] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/8882 [00:37:47] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8882 [09:28:07] New patchset: Jdlrobson; "make page take up full height for non-existant file pages" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8890 [10:22:54] New patchset: Jdlrobson; "Add settings page" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8343 [10:44:09] New patchset: Jdlrobson; "styling tweaks for browsers without javascript" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8892 [15:06:46] * YuviPanda looks around [15:20:32] see anything? [16:14:23] sweet, so Visa issues have been sorted [16:22:43] YuviPanda, what kind of issues? [16:23:01] they didn't want to let you in? [16:23:16] no, it went fine [16:23:27] just too much running around and finding stamped papers and standing in liens [16:23:29] *lines [16:23:37] yeah [16:25:09] jdlrobson: there ? [16:25:16] hey srikanthlogic [16:25:43] hello! [16:27:04] jdlrobson: in the new nav [16:27:43] contents language overlap on the respective images on my symbian browser [16:28:24] jdlrobson: hi [16:28:44] srikanthlogic: I saw something about that on the feedback page [16:28:53] can you update with the browser information and I'll check that out :) [16:28:56] hey philinje [16:29:27] can you put the current UI on a test server? [16:30:04] jdlrobson: also when I use the bit.ly link and opt-in I get redirected to desktop view always [16:30:21] philinje: with settings? [16:30:25] or just bug fixes? [16:30:35] even if I click mobile it still remains in desktop view as long as t=d552bf92724f748125e2cd211b1bc65fblahblah is present [16:30:58] jdlrobson: with settings would be great [16:31:03] k 1 sec [16:34:51] jdlrobson: how's it going? [16:35:06] slowly [16:35:07] http://mobile-testing.wmflabs.org/w/index.php/Main_Page [16:35:09] think i've got it up [16:35:33] cool [16:35:37] ready for the call? [16:35:39] yup [16:36:49] philinje: are we ready? [16:51:52] greetings all [16:51:56] hangout is up https://plus.google.com/hangouts/_/1d8bee0f9b8dd78de4d40ff75f01c2b6a4246567?authuser=1&hl=en [16:51:58] hello! [16:54:13] awjr: https://plus.google.com/hangouts/_/1d8bee0f9b8dd78de4d40ff75f01c2b6a4246567?authuser=1&hl=en [17:01:18] my chrome crashed [17:01:19] * BlackRectangle restarts [17:05:33] MaxSem: it looks like you do now have a cluster account - try logging into fenari with username maxsem [17:05:59] g+ crashed both my chrome and safari [17:06:16] and now typing this seems to display them at one character every other second [17:06:19] * BlackRectangle restarts computer [17:08:22] ddamn murphy's law :| [17:09:43] awjr, "no supported auth methods available" [17:12:28] MaxSem: are you using putty? [17:12:32] yup [17:12:34] tfinc: mailed in standup status [17:12:36] i feel like i've seen that issue before in putty [17:12:39] * YuviPanda sighs [17:12:55] MaxSem: http://support.rightscale.com/06-FAQs/FAQ_0038_-_How_can_I_get_PuTTY_to_work_to_SSH_into_running_instances [17:16:35] thanks YuviPanda [17:17:10] i need a guinea to test a different camera feed for the standup .. whos in? [17:17:16] guinea pig* [17:17:50] awjr: you available to test ? [17:18:04] hmm, just tried ssh from git-bash: "Permission denied (publickey)." [17:18:29] tfinc sure [17:18:40] awjr: https://plus.google.com/hangouts/_/ae71155b6d4600282123a4777b8279759e5f79f2?authuser=1&hl=en [17:18:43] MaxSem: talk to Jeff_Green in #wikimedia-operations [17:18:52] he's the one who handled setting up your accounts [17:52:16] okay, my access works now [18:00:37] MaxSem: awesome [18:00:48] MaxSem: are you able to +2 in gerrit yet? [18:01:01] MaxSem or push to the deployment branch? [18:01:12] i haven't heard any word from RobLa's team yet [18:01:15] nope [18:03:02] preilly, what are the licenses for all these images you're uploading? [18:03:21] * MaxSem recommends WTFPL [18:03:43] uh, wrong channel. oops [18:25:30] MaxSem: can you explain to me how you split functionality between MobileContext.php and MobileFrontend.body.php and why? I think i have some idea, but i think some explanation from you will help [18:27:00] context stores current state and allows to manipulate it. .body. contains hooks handlers and some legacy code e.g. DOM handling and Zero support [18:27:04] it looks like it was split up in such a way that makes MobileContext.php almost ready to just move into core, where a lot of the functionality currently existing in MobileFrontend.body.php wont be needed anymore [18:27:10] yeah ok [18:53:35] hi [18:54:05] heya Soapy [18:55:06] Soapy: thanks for joining us :) [18:55:19] Soapy: can you try https://play.google.com/store/apps/details?id=org.wikipedia.beta and see if your issues are still there? It's a newer version of the app [18:55:40] hi Soapy [18:57:16] I've got a screenshot of the beta not working on my phone [18:57:22] just need to get it off my phone [18:57:34] should I uninstall the other app first? [18:58:04] actually, I mgoing to uninstall it anyway [18:58:08] I hope the new one works better [18:58:17] hy tommorris [18:58:23] Soapy: no, you don't have to [18:58:44] ok [18:59:02] i cant find the beta on the app store [18:59:48] Soapy: search for 'wikipedia beta' [18:59:49] ? [19:00:17] ok [19:00:38] it says "Version 1.2beta2" [19:01:05] Soapy: okay, then can you just install http://dumps.wikimedia.org/android/Wikipedia-v1.2RC1.apk [19:01:16] http://dl.dropbox.com/u/10330141/SC20120525-195804.jpeg [19:01:17] Soapy: I just updated it to version 1.2RC1, which fixed a lot of bugs. [19:01:32] tommorris: try http://dumps.wikimedia.org/android/Wikipedia-v1.2RC1.apk if you don't want to wait for Google Play to push through the upgrade [19:01:42] tommorris: yup, known issue. Fixed in RC1 [19:01:45] huh? [19:01:46] ah okay [19:01:50] the beta doesnt work [19:01:59] thats very annoying [19:02:07] that's on a Galaxy S2 [19:02:21] tommorris: yup, known issue. Fixed in RC1. [19:02:44] Soapy: an update to it has been pushed through, Google's just taking some time propogating it [19:02:55] Soapy: in the meantime, you can go to http://dumps.wikimedia.org/android/Wikipedia-v1.2RC1.apk on your phone to install the updated version [19:02:56] if the new app is going to work like that Im never going to use it [19:03:17] it just loads up a list of sections with no article [19:03:29] where do I go to get hte actual article?> [19:03:51] Soapy: as I said, it was a bug in the previous version of the beta. Which we fixed with an update. Google's just taking some time propogating it, in the meantime you can go to the URL i mentioned above to install the updated version [19:04:20] sorry, thats just too annoying [19:04:50] I know you told me it was a beta and I shouldnt complain but that's really an unusable app [19:05:26] Soapy: *again*, that's an old beta that has been updated to fix that issue. If you try http://dumps.wikimedia.org/android/Wikipedia-v1.2RC1.apk, it will not have that issue [19:05:58] Google takes time before it pushes out updates live, so i'm just offering that link instead of waiting for however long google takes [19:08:10] Soapy: sorry that the betas aren't more stable :( [19:12:43] Soapy: still around? [19:13:21] hi [19:14:12] Soapy: did you try out the link I sent you? [19:14:30] I downloaded it from the app store [19:14:40] like I said it just loads every article as a list [19:14:42] https://meta.wikimedia.org/wiki/Mobile_Projects/WikipediaMobileAndroidFeedback [19:14:42] Soapy: can you try out the Link I sent you? [19:15:22] Soapy: as I've been trying to tell you a few times, it was a bug that was fixed and I gave you a link to a version with that bug fixed :) [19:16:21] Soapy: ? [19:16:36] I dont see anything else on the Android market besides the main app and the Beta [19:17:09] Soapy: do you see this link? http://dumps.wikimedia.org/android/Wikipedia-v1.2RC1.apk [19:17:29] Soapy: you have to download the apk on your phone, not through the store [19:17:34] Soapy: going to that link on your phone will install the newer version [19:18:12] as far as I know the only way to install applications is through the Android market [19:18:17] on this phone anyway [19:18:24] clicking a download link would just download a file [19:18:46] it's not like Windows where I can just double-click a program to install it [19:19:20] it should work [19:19:25] Soapy: unless it was specifically locked down by your carrier or manufacturer, all of Android can just 'double click' a program to install it [19:19:41] where would I go to do that? [19:20:14] easiest thing is to email the link to yourself and click on it in your email program on the phone [19:30:10] [WikipediaMobile] yuvipanda pushed 1 new commit to master: http://git.io/agj-pA [19:30:10] [WikipediaMobile/master] Use 'Update' consistently in english messages - YuviPanda [19:37:45] right, I got that, but I cant install it because it's not through the Market [19:38:58] as far as I Know that is the default in all smartphones in the USA [19:40:07] Thanks anyway [19:40:15] Im still going to try to run the app on some other smartphones [19:40:33] Soapy: thanks for trying :) Google should push out our update soonish, and the bugs in the beta will go away [19:42:01] Sorry if I come across as hostile, I get frustrated easily [19:42:24] I dont want to be seen as an enemy [19:43:06] Soapy: I understand. Beta testing can be very frustrating, especially with nacent-ish projects like the mobile app [19:51:51] Soapy: sorry, you need to change something in Settings to allow installation of non-market apps [19:52:44] Soapy: on my phone: Settings => Applications => Unknown sources [19:55:26] yeah Im not gonna do that [20:00:05] awjr: hi [20:00:11] hi philinje [20:01:11] is the Pro version an enhanced version of the free one, or a separate project? [20:01:26] It doesnt even look like it's by the same developer team [20:01:35] awjr: just wondering if we can add the referring page to emails [20:01:50] Soapy: there is no 'pro' version [20:01:56] Soapy: i think Pro might be a third party app? [20:01:58] Soapy: there are wikipedia apps by other people. [20:02:12] philinje: it's technically possible, but can we legally do it? [20:02:33] for emails, i think so, and it was requested by Philippe and Maggie [20:02:43] so adding it is not hard [20:02:45] ok [20:03:27] philinje: no, adding it's not hard. as long as it's cool to do with our privacy policy, i'm happy to add it in. it should be a quick addition and might be able to get it pushed next week [20:04:24] ok ,let me check, thanks [20:04:26] MaxSem: assuming we get your credentials sorted out, do you feel ready to try a deployment with prielly or myself watching over your shoulder? [20:04:30] philinje no problem! [20:04:40] awjr, yeah [20:05:02] btw, we are getting lots of emails that have no comments in them, but the UA is there [20:05:06] awjr, my key issue has already been resolved [20:05:16] and there were 2 that were real technical comments [20:05:34] and 1 that was someone asking about his Facebook account! [20:05:37] MaxSem: so you have access to fenari and you can merge to the deployment branches? [20:05:44] lol [20:05:52] ah, Gerrit perms [20:06:09] I can ping Robla about that again and harass Roan/Chad [20:06:16] thanks [20:06:20] if we can get that stuff sorted out in time, do you want to do next week's deployment? [20:06:43] I can try;) [20:07:10] MaxSem: what time would be best for you in PDT hours? [20:08:02] on this coming Tuesday, i mean [20:08:33] ehm, when everyone's still asleep in your parts:P /me checks the deployments page for more realistic timeslots [20:08:42] :) [20:08:50] yeah for this one, let's do it when patrick or i can be around [20:11:54] i vote for deploying on Wed [20:12:08] i know there will be some teaching of the beta UI on Tu [20:12:12] tweaking [20:12:40] preilly, MaxSem, tfinc what do you think? ^ [20:12:52] im ok with deploying Weds [20:13:22] yeah [20:13:49] the only potential problem is that core deployments could take longer than planned [20:14:40] MaxSem that is true, although we have yet to run into that problem with our monday deployments [20:17:51] Patrick is not here right now [20:18:24] New patchset: L10n-bot; "Localisation updates from http://translatewiki.net." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8958 [20:20:10] * YuviPanda goes to sleep [20:20:12] gnite everyone [20:20:26] should get some work done over the weekend - week's got too many paperwork-y distractions [20:21:31] ok [20:25:49] MaxSem: robla just approved your deployment branch access now we just need to wait for chad to add you - so i think you should be good to go next week [20:26:05] yeah, just received his email [20:46:03] * MaxSem curses ocaml [20:46:30] anyone know if beta opt-in is broken on geo-mobile test instance? [20:49:03] MaxSem what are you doing with ocaml? [20:49:24] trying to build texvc on Windows [20:49:36] awjr, trying to build texvc on Windows [20:49:41] ofun [20:49:58] philinje, works for me [20:52:06] speaking of Wednesday, I'll be in Berlin already [20:52:52] when does everyone else arrive? [20:54:24] i get in... thursday [20:58:44] awjr: hmm [20:59:03] if you deploy on wed then make sure you wont need anything from me ;0 [20:59:04] ;) [20:59:08] as i'll be in transit [20:59:14] yeah that's no good [20:59:14] it doesn't matter to me [20:59:23] if everyone's gonna be travelling weds would not be a good day [20:59:30] when is jon travelling? [20:59:45] later in the week as its a quick hop [20:59:55] well that might be ok then [21:00:02] i can pull the flights if you want [21:00:12] but we might need to wait for MaxSem to deploy until after berlin [21:00:26] awjr: i saw MaxSem should deploy right at the hackathon [21:00:27] :D [21:00:37] lets throw him in the deep end [21:00:42] then patrick can definitely watch over his shoulder [21:00:44] s/say/say [21:00:50] you know what i mean [21:00:50] yes [21:00:52] exactly [21:00:52] heh [21:00:54] im cool with that [21:01:07] even if its just to pick up some bug fixes ... then its worth it [21:01:18] if anything breaks someone in the room will yell at us and we can fix it fast [21:01:27] whee:) [21:01:32] hackathon starts on thursday or weds? [21:01:35] and that way we can reach my goal of having MaxSem deploying code by the end of the hackathon [21:01:39] friday [21:01:47] deploy on FRIDAY?! [21:01:51] just kdiding [21:01:58] go for it [21:02:01] i say we deploy *something* sat [21:02:06] we'll be there all day [21:02:22] it shoudln't be anything super critical [21:02:22] ok then perhaps jon and i can do a deployment on weds and max can do another at the hackathon? [21:02:27] yes [21:02:31] preilly: hows that sound ? [21:02:40] fine [22:22:36] awjr: can you take a look at http://www.mediawiki.org/wiki/Git/Tutorial [22:23:48] sure [22:23:53] preilly one sec [22:31:57] preilly im just gonna make some edits as i go, feel free to revert them if you dont like em [22:32:14] awjr: like what? [22:32:27] preilly like http://www.mediawiki.org/w/index.php?title=Git%2FTutorial&diff=542379&oldid=542377 [22:36:28] preilly and http://www.mediawiki.org/w/index.php?title=Git%2FTutorial&diff=542381&oldid=542379 [22:49:53] whoa i didnt know you could do git review -d to checkout a change [22:50:01] ha ha ha [22:52:01] also handy and new to me: git fetch --all [22:52:02] git remote update [22:55:39] New patchset: L10n-bot; "email -> e-mail" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8982 [22:56:10] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/8982 [22:56:12] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8982 [23:00:27] preilly cool looks good! i made a few more minor changes [23:00:37] awjr: okay cool