[00:37:38] time to go home ... [09:54:55] New patchset: Jdlrobson; "remove hover effect on main menu links" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/9234 [10:36:52] MaxSem: there? [10:37:23] New patchset: Jdlrobson; "Add settings page" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8343 [10:40:19] New patchset: Jdlrobson; "Add settings page" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8343 [11:07:59] New patchset: Jdlrobson; "add header to languages overlay to show number of languages available" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/9241 [12:49:00] New patchset: Jdlrobson; "clicking browser history buttons flicks between overlays and article view" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/9243 [15:20:07] * YuviPanda looks around [16:00:09] YuviPanda|sick, are you ok>=? [16:00:28] MaxSem: been puking all day, nothing seems to stay in my stomach [16:00:41] ouch [16:01:06] very most wonderful timing, too. Am 24 hours from leaving to berlin and have lots of things to do (Buy shoes, euros, etc) [16:01:10] hope it goes away tomorrow [16:03:16] * MaxSem suggests a desinfection [16:54:54] greetings all [16:54:56] awjr: yo [16:55:03] what's up tfinc [16:55:55] awjr: i need to move our 1:1 to earlier. can you accomodate ? [16:56:13] tfinc sure [16:56:26] tfinc i'm wide open today [16:56:36] i could do 1-2, 3-4 [16:56:54] tfinc let's do 3-4 [16:57:07] k, 3-3:30 it is [16:57:13] cool [16:57:33] hmm, no brion. [16:58:10] YuviPanda|sick: he's not in the office yet. possible flying already. you could check in with rachel to find out [16:58:21] yeah, looking for that spreadsheet no [16:58:21] w [16:58:54] nope, he's flying tomorrow [17:00:31] ill be out of here at 4pm pst so hit me up before that if you need anything [17:01:36] tfinc: I sent you expense reports :) [17:04:53] nope, Brion will depart tomorrow [17:05:05] eh, scroll fail [17:19:18] philinje: are we having a wlm updating meeting today? i'm at home office so let me know if i have to call in [17:21:50] brion: two pull requests :) [17:21:57] \o/ [17:22:25] brion: using require.js, so our modules will all be self-contained and not pollute global namespace [17:22:33] ooooh nice [17:22:39] plus moved all API to own module. [17:22:46] now need to figure out how to move ImageFetcher properly [17:23:18] brion: i'll note that one pull req (api-module) depends on another (require.js [17:23:18] ) [17:23:38] merging 1 [17:24:35] merging 2 [17:25:03] hope you feel less sick soon YuviPanda|sick ! [17:28:15] brion: hope so too [17:28:21] brion: awful timing [17:28:32] ain't that always the way [17:28:33] brion: code review looks okay? [17:28:42] brion: indeed. Murphy's law. [17:28:44] looks good [17:28:57] sweet [17:29:47] i did some more experimentation with pinchzoom in another branch to make it smoother by hooking into the map system's native pinch-zoom touch handlers, but something was wrong with the transformations (map would translate but not zoom during pinching) [17:30:01] i'll poke at it some more later probably, but at least we've got the basic response in [17:30:11] brion: :D [17:30:27] brion: i'm moving imagefetcher now, then will replace all of the DOM manipulation with http://underscorejs.org/ 's templates [17:30:36] \o/ [17:30:43] awesome [17:30:55] my next step'll probably be working on the actual upload description portion [17:31:06] getting the information from uploadwizard campaign api and filling out the details correctly [18:14:26] printing my berlin info, of course now my toner runs low [18:16:32] brion: hey Brion, wil you be in the office today? [18:16:55] no i'm working at my home office today [18:17:01] madly prepping for berlin :) [18:17:04] fly out tomorrow [18:17:12] we having a wlm meet? [18:17:25] if possible [18:17:42] YuviPanda|sick: hey Yuvi, how are you feeling? [18:17:59] brion: maybe not [18:18:14] philinje: not that great. Been puking all day, possible food poisoning. [18:18:20] hope to get better before I fly out [18:18:32] whoa, take it easy [18:18:42] :( [18:18:58] YuviPanda|sick: when are you supposed to leave? [18:19:04] in about 24 hours [18:19:08] * MaxSem notices that jdlrobson managed to sneak in GB spelling [18:19:15] no pasaran! [18:19:44] brion: how about tomorrow morning? Could do it on Skye with both you and Yuvi [18:19:54] sure [18:20:08] philinje: i'd probably be on the way to the airport tomorrow morning [18:20:17] ok [18:21:37] YuviPanda|sick: let me know how you're feeling later, get better soon ;) [18:22:10] brion: maybe an email summary of what you've done would help, in case we can't sync up in a call with Yuvi [18:22:14] New patchset: MaxSem; "Add settings page" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8343 [18:22:26] will do [18:23:12] thanks [18:24:37] New patchset: MaxSem; "Add settings page" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8343 [18:24:44] YuviPanda|sick: did you try and eat Indian food again? you know your stomach cant handle that [18:25:04] eh? what does he usually eat, then? [18:25:04] tfinc: most possible explanation :) [18:25:41] MaxSem: tfinc and preilly's assessment after seeing how I reacted during the Pune hackathon was that I'm actually from another country and just pretend to be indian :) [18:26:06] considering how I didn't recognize 90% of the food items there, didn't like the other 10% and couldn't speak a word of the local language.... [18:26:28] oh India [18:26:34] [18:26:57] MaxSem: he usually eats pizza [18:27:19] I mostly ate at Subway in SF [18:27:31] tfinc: you americans have *huge* pizzas. A 'personal' pizza I bought could've easily served 2 [18:27:33] ewww [18:27:54] YuviPanda|sick: you haven't even seen our *huge* pizzas [18:27:57] that's how we get so fat [18:28:01] huge pizzas and no food poisoning [18:28:02] MaxSem: there is no 'american cuisine' as such, so you make do with what you get. Huge Chcolate Muffins are awesome no matter where :) [18:28:31] tfinc: In my last startup, there was a period of about 2 weeks in which we had nothing but pizza. I've stopped eating pizza much after that :P [18:29:12] there's american cuisine, who else eats burgers?:O [18:29:21] brion: ImageFetcher pull req sent. Working on templates now [18:29:45] MaxSem: I tried McDonalds in SF. Most awful tasting food I've ever encountered [18:29:53] excellent [18:30:07] maybe we should get you sick more often, you're whipping through this code ;) [18:30:20] but your country had been there for thousands of years, why haven't a common cultural space been formed? [18:31:14] MaxSem: think of India more as Europe than a country by itself. They were independent nation-states before the British conquest. [18:31:34] brion: heh. Last week was horrible, since I kept getting interrupted by having to go stand in lines to get paperwork done. [18:31:56] hehe [18:34:23] New review: MaxSem; "Stuff still unresolved:" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/8343 [18:36:10] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/8890 [18:36:12] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8890 [18:36:59] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/8892 [18:37:01] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8892 [18:37:34] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/9121 [18:37:36] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/9121 [18:37:49] MaxSem: why did https://gerrit.wikimedia.org/r/#/c/9121 need to be reverted? [18:38:25] see email thread about b/cf [18:38:40] *b/c [18:38:46] What is b/c? [18:38:58] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/9123 [18:39:22] you're a happy man not to know about backwards compatibility [18:39:25] :P [18:39:29] MaxSem: https://gerrit.wikimedia.org/r/#/c/9123/ — Your change could not be merged due to a path conflict. Please merge (or rebase) the change locally and upload the resolution for review. [18:45:46] New patchset: MaxSem; "Restore b/c with 1.19 with an ugly hack" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/9123 [18:46:03] biab [18:46:41] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/9123 [18:46:43] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/9123 [19:02:10] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/9234 [19:02:12] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/9234 [19:04:17] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/9243 [19:04:19] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/9243 [19:05:19] MaxSem: what do you think about https://gerrit.wikimedia.org/r/#/c/9241/ [19:05:57] MaxSem: specifically this part https://gerrit.wikimedia.org/r/#/c/9241/1/javascripts/mf-navigation.js looks weird to me [19:09:42] `languages` should be called `$languages`, the number of messages we serve on every page view grows [19:11:13] MaxSem: did you add comments to the committed patch set? [19:11:53] preilly, what are your concerns about it? [19:12:31] MaxSem: mostly the string substitution [19:12:34] MaxSem: in JS [19:18:08] New review: MaxSem; "(no comment)" [mediawiki/extensions/MobileFrontend] (master) C: 0; - https://gerrit.wikimedia.org/r/9241 [19:32:24] brion: 'nother pull req, plus fix to the last one. [19:32:57] brion: I'll move the wlmapi to its own module before templatizing that [19:50:21] I should go lie down or something [19:50:23] gnite everyone [20:03:23] New patchset: L10n-bot; "Localisation updates from http://translatewiki.net." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/9303 [20:05:43] MaxSem: there? [20:05:53] yup [20:06:43] so reading through your notes.. bit confused by ""Disable images on mobile site: [on|off]" may look OK, but "Join the mobile beta? [on|off]" is definitely clumsy." <- i fixed this no? [20:06:50] should now say 'Beta mode' on/off [20:07:27] eww, I just copypasted it from my previous comment [20:07:48] ahh ok [20:07:48] jdlrobson: are you by any chance going to beavailable during deployment tomorrow? [20:07:52] yes awjr [20:07:57] I still don't like the language [20:07:57] i've moved a few things around [20:08:04] cool thanks jdlrobson [20:08:08] the language on 'Beta mode' MaxSem ? [20:08:22] both of them [20:08:41] * MaxSem takes a look at the general preferences [20:09:29] why does it need specially styled checkboxes? [20:10:28] MaxSem: I'm just working from the designs given to me [20:11:43] New patchset: Jdlrobson; "add header to languages overlay to show number of languages available" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/9241 [20:11:55] do we need to keep consistency with desktop site? [20:12:50] I assume not since what we've done so far is very different [20:13:54] 'Display article photos' is used instead of disable images here> http://www.mediawiki.org/wiki/File:6-settings.png [20:23:57] and where did the login stuff go? [20:24:30] MaxSem: phil told me to remove it see > http://www.mediawiki.org/w/index.php?title=Mobile_design/Wikipedia_navigation/Whiteboard#Friday.2C_May_25.2C_2012: [20:24:34] philinje: ^ [20:24:52] MaxSem: we will drop login for now [20:25:06] MaxSem: can you talk right now on Skype? [20:25:08] MaxSem: discussing Settings page with philinje now [20:25:39] I actually support this removal until we have new login/register forms [20:25:58] philinje, sure [20:26:09] ok [20:26:54] one sec [20:28:09] New review: awjrichards; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/9303 [20:28:11] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/9303 [20:57:15] New patchset: Jdlrobson; "Add settings page" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8343 [21:29:50] preilly: there? [21:29:54] or awjr ? [21:29:58] hi [21:30:07] any ideas how I can make the mobile site stick? [21:30:16] my local instance keeps switching to desktop on a link click [21:30:20] and I need to test something [21:30:49] hmm [21:30:59] and you have the mobile cookie enabled? [21:31:51] jdlrobson ^ [21:34:29] yes awjr [21:34:45] sorry got side tracked by my mother... one of the dangers of moving back home :D [21:34:47] jdlrobson that is weird and unnerving [21:34:48] no worries [21:34:50] hahaha [21:35:12] she's unravelling my mac power cable.. apparently it's dangerous ;-) [21:38:07] jdlrobson the mobile view is working ok for me locally… maybe try clearing your local cache? [21:39:40] mm [21:40:28] well I click random [21:40:30] I get desktop site [21:40:33] just cleared my cookies [21:40:39] anybody know if max is coming back on today? [21:40:51] I think he's prob gone [21:40:56] he sounded tired when I spoke to him [21:41:13] yeah ok and i think he's traveling to berlin tomorrow [21:42:05] yes he is [21:43:36] so awjr any other theories on my mobile non-stickiness? [21:43:43] is there any way I can force it permenantely in localsettings? [21:43:50] am keen to go to sleep and can't till this is done :( [21:44:02] jdlrobson there are known issues with caching and mobile stickiness on single-domain sites [21:44:24] you can force mobile view in your LocalSettings [21:44:42] but my guess is you just need to clear your cache or hard refresh on a page that hsould be mobile view but is in desktop [21:50:24] how do I do that in LocalSettings ? [21:51:53] works on my Safari [21:51:55] that will do [21:52:00] '(just not chrome) [21:54:44] that is weird, i have not had problems with chrome :( [21:55:09] im double checking the config for local settings [21:56:21] MF has changed a lot since last time i tried to do this... [21:59:34] jdlrobson i think you can do "$wgMFConfigProperties = array( 'useFormat' => 'mobile' ) [21:59:45] awjr: running about 5 min late [21:59:46] makes sense [21:59:53] tfinc: no worries [22:00:34] New patchset: Jdlrobson; "strengthen css rule so right menu icon hides on full screen search" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/9344 [22:00:35] New patchset: Jdlrobson; "restore history link" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/9345 [22:00:35] New patchset: Jdlrobson; "don't toggle navigation menu open when hash set" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/9346 [22:11:56] awjr: ok .. i'm all set [22:12:06] tfinc cool im on skype [23:04:51] awjr: hi [23:04:56] hi philinje [23:04:58] ready? [23:05:07] yup, let me grab a room