[00:16:40] New review: awjrichards; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: -1; - https://gerrit.wikimedia.org/r/9345 [00:30:34] New review: awjrichards; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/9346 [00:32:16] New review: awjrichards; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/9344 [00:32:18] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/9344 [00:34:15] New review: awjrichards; "Also, for the future, I encourage you to check in changes that are not dependent on other changes if..." [mediawiki/extensions/MobileFrontend] (master); V: 1 C: -1; - https://gerrit.wikimedia.org/r/9345 [00:43:05] awjr: you can rebase his change [00:43:30] preilly i know [00:44:04] it's just an easily avoidable pita [00:45:35] New review: awjrichards; "Toggling options on/off is a little funky - I think it's because the area responsive to the toggle t..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/8343 [00:48:25] New patchset: preilly; "restore history link" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/9346 [00:49:47] hmm [00:51:01] waitaminute.... [00:51:56] preilly i think something weird happened. [00:52:04] hence the hmm [00:52:24] oh i wasn't sure what kind of inflection i should've read that with. [00:54:42] New patchset: preilly; "Revert "restore history link"" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/9348 [00:55:23] Change abandoned: preilly; "(no reason)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/9348 [00:57:19] Change abandoned: preilly; "(no reason)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/9346 [01:02:51] New patchset: preilly; "don't toggle navigation menu open when hash set" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/9349 [01:03:03] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/9349 [01:03:05] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/9349 [01:05:34] Change restored: preilly; "(no reason)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/9346 [01:10:02] New patchset: preilly; "restore history link" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/9345 [01:11:38] Change abandoned: preilly; "(no reason)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/9346 [01:13:06] FUCKING GERRIT [01:18:15] New patchset: preilly; "restore history link" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/9345 [01:18:47] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/9345 [01:18:49] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/9345 [01:29:52] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/9241 [01:29:54] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/9241 [01:31:57] New review: preilly; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/8343 [04:00:25] so I have a crazy mobile app related question from wikimania program team [04:01:05] would a wikimania android/ios app be a crazy notion? [10:11:53] New review: Siebrand; "Key 'mobile-frontend-language-header' should use plural. I've created https://bugzilla.wikimedia.or..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/9241 [10:46:11] New patchset: Jdlrobson; "Add settings page" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8343 [10:49:32] New review: Jdlrobson; "Taken care of :)" [mediawiki/extensions/MobileFrontend] (master) C: 0; - https://gerrit.wikimedia.org/r/8343 [16:58:38] hi [16:58:48] jdlrobson: howdy [16:58:55] hey philinje [16:59:05] have been investigating back button behaviour.. doesn't seem to be limited to beta [16:59:08] is Arthur online? [16:59:14] https://bugzilla.wikimedia.org/show_bug.cgi?id=37224 [16:59:26] awjr will definitely be on later for deployment [16:59:38] ok thanks [17:00:37] i am not at the office yet, just got internet at home [17:00:59] will you be around during the deployment? [17:04:45] will be in the office in about 40 min [17:10:27] New patchset: Jdlrobson; "hide button for left menu where javascript is disabled" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/9409 [17:10:48] New patchset: Jdlrobson; "on clicking a link in navigation menu close it" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/9410 [17:13:14] New review: awjrichards; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/8343 [17:13:16] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/8343 [17:17:19] New patchset: Jdlrobson; "add br tag after history link" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/9412 [17:19:52] New review: awjrichards; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/9409 [17:19:54] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/9409 [17:23:25] New review: awjrichards; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/9410 [17:23:27] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/9410 [17:24:41] New review: awjrichards; "Huh, the change this fixes wasn't in what I reviewed yesterday (eg the
was not attempting to be..." [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/9412 [17:24:43] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/9412 [17:25:00] jdlrobson how's it going? [17:25:07] are all the major changes in? [17:25:15] for today's deployment, i mean [17:26:22] i think so awjr [17:26:30] there were a few issues with back button behaviour [17:26:33] but i think they might be out of my control [17:26:41] jdlrobson like what? [17:26:55] https://bugzilla.wikimedia.org/show_bug.cgi?id=37224 [17:27:57] ! [17:28:03] that is weird. [17:29:52] wtf [17:30:03] jdlrobson are we doing anything to back button behavior with js or something? [17:31:12] that problem seems to have existed for a while [17:31:27] eg it's currently live in production, on non-beta [17:31:43] awjr: same without javascript [17:31:55] (to test I'm using web inspector to reveal random button) [17:32:38] jdlrobson: it happens on the desktop site as well [17:33:51] i suspect the answer might lie in watching the headers.. [17:34:22] jdlrobson i watched the 'referrer' field in the headers and all looked normal [17:34:36] but then again, im not exactly sure how the 'back' button works [17:40:37] well jdlrobson i think we can safely say it's somebody else's problem [17:40:48] yeh.. what should I file it under? [17:45:59] guys just grabbing some dinner.. back in a it [17:46:08] kk [17:46:18] getting 503s on Special:Random on mobile sites [17:49:53] issue is now resolve [17:49:54] d [18:03:32] hi, in the office [18:04:58] hi phil [18:05:04] hey [18:05:23] the deployment is at 2pm today? [18:07:22] depending on where Jon is with some bugs, I wonder if we should push this back [18:07:24] philinje: that's correct [18:07:47] philinje if we don't deploy today it will have to wait probably until next week [18:07:51] unless folks in berlin want to pick it up [18:08:14] right, they were planning a deployment on Sat [18:08:48] philinje what do we need to wait for? [18:08:56] are there other things to push beside the UI? [18:09:05] philinje yeah, i think they were planning on a small easy deployment for Max since it will be his first [18:09:15] ok [18:09:29] this is not *totally* up to date but this should give you a general idea: [18:09:30] http://www.mediawiki.org/wiki/Extension:MobileFrontend/Deployments/2012-05-30 [18:09:38] it's missing work checked in yesterday and today [18:09:58] no harm in doing it, i guess we'll be where we will be at 2 [18:10:17] philinje yeah, i think so, unless there's a major blocking reason not to do it. [18:10:39] i gathered from jon that anything else is related to the beta, which imho would have to be pretty broken to be a show-stopper [18:10:43] awjr: maybe here :) [18:10:52] hi saper :) [18:10:54] i was thinking it was for the UI only [18:11:06] saper: feel free to file bugs for any issues you find [18:11:09] philinje: why should we push this back? [18:11:36] how are things going? sounded like you were dealing with the back bug [18:12:10] awjr: ah now I noticed "W[beta]" is kind of part of the search box [18:12:11] philinje: are you talking about https://bugzilla.wikimedia.org/show_bug.cgi?id=37224 ? if so, that's kinda out of our hands [18:12:14] very very strange [18:12:30] and philinje besides... wouldn't call that a showstopper [18:12:39] this beta is certainly a big improvement on the current deployed beta [18:12:49] saper: jdlrobson and philinje have been doing a lot of the work for the beta navigation [18:12:49] it has a few fixes plus the settings page [18:12:59] the settings page is hot. [18:13:09] i can't wait for that to be non-beta [18:13:10] awjr: feels strange - the button on the right to search - cannot guess what it does [18:13:12] awjr: before I forget we need to update the beta logo on search [18:13:32] behind it one of the options is gray contents and interwiki switch - IW switch is good to have finally [18:13:33] jdlrobson ok what do we need to do to do that? [18:13:42] saper: yup we are exploring this > see last bullet point http://www.mediawiki.org/w/index.php?title=Mobile_design/Wikipedia_navigation/Whiteboard#Tuesday.2C_May_29.2C_2012: [18:13:53] awjr: I'm not really sure but it's not a problem if we can't [18:13:54] saper: on a page with lots of sections, the content link should work [18:14:01] saper: oh actually, that might not be live yet [18:14:05] saper but it will be in a few hours [18:14:07] I believe there is something in LocalSettings.php pointing to an image that will need replacing [18:14:22] * awjr goes to look [18:15:20] awjr: ok but the whole point of this icon to the right is strange [18:15:34] saper im inclined to agree, i find it not very intuitive [18:15:35] awjr: http://upload.wikimedia.org/wikipedia/commons/1/16/W_logo_for_beta_test_of_Mobile_Frontend.gif needs to be replaced with http://www.mediawiki.org/wiki/File:Mobile_W_beta_light.png [18:15:35] I have one on the left (three bars) and to the right (a page with three dots) [18:15:49] I can guess three bars is some kind of menu [18:16:01] but the page? a print version? get me a bus ticket? [18:16:06] saper other people have definitely voiced your concerns [18:16:16] jdlrobson cool, found it [18:16:27] awjr: that can be changed now if easier [18:16:50] jdlrobson i have to wait til our window - there's another deployment going on now [18:16:54] np [18:17:08] is it worth beginning to test? [18:17:14] or is that not possible? [18:17:19] jdlrobson: seeing some strange stuff on full-screen search on mobile-geo [18:17:20] as I don't think I have any more patches [18:17:29] philinje: mobile-geo not up to date [18:17:33] want me to update it? [18:17:36] hang on im already in there [18:17:41] might be good [18:17:53] updating now [18:17:54] ok awjr will leave it to you [18:18:01] jdlrobson, philinje it is up to date [18:18:03] can settings page me merged awjr [18:18:06] ? [18:18:17] ahh it has been.. was looking at an old screen [18:18:20] jdlrobson already merged :) [18:18:39] awjr: thanks [18:18:44] np [18:19:21] jdlrobson: i like your idea of putting functions into the article [18:19:23] jdlrobson: I am using a very small screen of Huawei U8150, a very nice $80 android phone [18:19:37] jdlrobson, philinje: where is the best spot for saper to leave feedback about the new nav, etc? [18:19:46] one sec [18:20:29] https://www.mediawiki.org/wiki/Mobile_design/Wikipedia_navigation/Beta_feedback [18:20:36] saper ^ [18:21:01] that's a good place to leave public feedback about design/beta changes [18:21:30] awjr: thx [18:21:34] saper: np [18:21:43] saper thank YOU for the feedback :) [18:21:56] jdlrobson: try going to Contents then hitting back [18:22:03] hardware back [18:22:10] awjr: is mobile geo up to date? [18:22:32] he said said so [18:22:38] jdlrobson yes should be [18:22:45] you may need to flush your browser cache [18:22:47] ok got a bug I think [18:24:43] New patchset: Jdlrobson; "hide the left button when in full screen search" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/9418 [18:25:59] philinje: so what's wrong with clicking back on contents? [18:26:04] looks good for me [18:26:33] jdlrobson: working now, strange [18:26:36] sometimes URL bar hides, sometimes not, on back [18:27:17] New review: awjrichards; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/9418 [18:27:19] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/9418 [18:27:43] just updated mobile geo with ^ [18:28:14] jdlrobson: actually, when Contents is open, sometimes hardware back does nothing, for several clicks [18:28:23] hardware back? [18:28:40] yes, the back on the phone [18:28:47] which device? [18:28:56] cheers awjr [18:28:58] Android less than 4 [18:29:25] mine is Nexus One Android 2.3.6 [18:30:09] wowww opera mini has quite a big bug in the settings lol [18:30:43] :( [18:33:06] it's just a renderign problem [18:33:11] should be easy enough to fix [18:33:17] awjr: Dan just sent the details of what he needs deployed today [18:33:24] philinje: if you can replicate it consistently and create a minimum test case that would be very useful [18:33:34] ok [18:34:38] philinje cool - can you email it to me? [18:35:00] he emailed it to both of us [18:35:24] oh yeah cool thanks [18:39:27] awjr: Hi Arthur, does the email I sent make sense? Although changes are entered into translatewiki, they haven't propagated over to the file that I need changed. [18:39:46] dfoy hi there - it does, although im surprised because i thought i18n updates happened automatically [18:40:03] dfoy im going to look into it - worse case scenario i'll push the changes manually this afternoon [18:41:04] awjr: ok thanks, let me know if you need any clarification about this at all [18:41:18] jdlrobson: just noticed strange red lines in Settings on iPhone 4.2 [18:41:32] philinje: i'm debugging [18:41:52] are you using an iPhone or Android phone primarily? [18:42:10] dfoy do you have a link to the translation in translatewiki? [18:43:32] he just went upstairs [18:48:10] jdlrobson: looks like on iPhone 4 going to a section from Contents opens the section but doesn't move to the section [18:50:49] on Android: open Contents, hit back on phone, first click does nothing, second click goes to previous article [18:50:52] hope that helps [18:51:17] back in a bit [18:51:54] New patchset: Jdlrobson; "improve settings page for browsers with js disabled" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/9422 [18:58:39] awjr: Let me get the translation link for you [18:59:15] awjr: Here is the page link - https://translatewiki.net/w/i.php?title=Special%3ATranslate&taction=translate&group=ext-zeroratedmobileaccess&language=bn&limit=100&task=view [18:59:53] thanks dfoy [18:59:55] just sent you an email [19:00:11] your change should be pushed to code with the daily update (in ~15 mins) [19:00:27] and then i think the i18n changes get pushed to the cluster in ~5 or 6 hours from now [19:00:39] so unless you ened the change sooner, we should be able to just let it happen naturally [19:00:42] philinje: I can replicate the android back button problem, but not sure why that's happening. Can't replicate the iphone issue [19:00:42] dfoy ^ [19:00:43] ok cool - that will work [19:00:47] awesome [19:01:04] also the text to change is this entry on the page I sent - ↓...-text-grameenphone-bangladesh/bn [19:02:02] cool [19:05:14] ok i gotta go get some wedding suit alterations done and grab some lunch - back in ~1 hr [19:06:05] jdlrobson: are you on iPhone 5? [19:06:11] yes philinje [19:06:14] os 5 [19:09:22] i'm on 4.3.3 [19:09:36] for beta, iOS 5 is fine [19:14:20] k got it philinje [19:26:18] New patchset: Jdlrobson; "close overlay before setting hash on contents page link" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/9428 [19:26:19] philinje: fixed the contents bug ^ [19:32:57] New patchset: L10n-bot; "Localisation updates from http://translatewiki.net." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/9448 [19:36:43] jdlrobson: brilliant [19:38:24] New review: awjrichards; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/9448 [19:38:26] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/9448 [19:48:56] jdlrobson: wonder if you got my reply to the calls email [19:49:05] yup [19:52:15] brb [19:55:18] New review: awjrichards; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/9428 [19:55:20] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/9428 [19:55:51] New review: awjrichards; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/9422 [19:55:52] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/9422 [19:56:19] jdlrobson i merged your changes and updated mobile-geo [19:56:27] wait just kidding [19:56:48] ok now it's updated [19:57:11] awjr: I think he's away [19:57:21] no worries [20:03:35] seeing another bug: go to Contents, go to a section, hit back on the phone. First back goes to the top of the article, second click reloads the same page, third or more clicks do nothing, then a click finally goes back to the previous article [20:06:17] jdlrobson, philinje: heads up - i'm going to start merging code for deployment in about 30 minutes [20:07:39] ok [20:12:23] another variation of the bug: go to Contents, go to a section, hit back on the phone 5 or 6 times and eventually it goes back to the previous article [20:12:43] seeing this on Android 2.3.6 [20:21:28] i'm here awjr [20:22:07] tow versions of a Contents back bug, above [20:22:24] two [20:29:34] philinje: yes looking into it [20:29:59] could we record the expected behaviour somewhere for all these sorts of things? [20:33:07] sure, on the Whiteboard? [20:33:21] yup.. I think I've improved the situation somewhat [20:33:41] was the previous intention to go back to the top of the article with the first back? [20:38:00] anyway, that's what I'll put on the WB [20:38:31] New patchset: Jdlrobson; "adjust hash behaviour on navigation" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/9470 [20:38:32] so yeh.. the intention was one back button takes you to top, 2 back buttons to last page [20:38:43] I think that fixes it somewhat ^ [20:38:47] althought it's still not perfect [20:38:51] ok, that's what I thought [20:38:57] it's a tricky one [20:39:07] as we don't want the user to have to click the back button too many times [20:39:14] doesn't have to be perfect for now, let's keep playing with it [20:39:19] but we also want them to get back to things they feel they should get back to [20:39:29] it would be good to have a page detailing what happens when you press back [20:39:58] a whole page, or a section on the WB? [20:43:17] New review: awjrichards; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/9470 [20:43:19] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/9470 [20:44:49] philinje: just back button behaviour in general [20:45:05] for everything... [20:45:10] sure [20:45:40] you said a page, do we need a sub-page off the WB? [20:45:49] maybe that's more stable [20:46:28] awjr: any ideas how we could solve https://bugzilla.wikimedia.org/show_bug.cgi?id=37088 [20:46:44] philinje: yeh just somewhere we can collaborate on how the back button works [20:46:57] ok [20:47:05] e.g. click navigation menu, click contents page, click heading, click back see x, click back see y, click back see z [20:48:21] np [20:49:21] jdlrobson: are you around for much longer - wondering if we could talk for a bit? [20:49:44] philinje: i'm hanging around for the deployment then off [20:50:08] how late will you be available tomorrow? [20:50:16] philinje: I'm off to Berlin tomorrow [20:50:16] jdlrobson im not sure without some digging, i dont really know how language switching works [20:50:26] hence why I want to leave shortly after the deployment [20:50:59] can we talk now? [20:51:20] jdlrobson, philinje: im merging code to deployment branches and should have it running on test shortly [20:51:29] ok great [20:52:00] excellent.! [20:52:22] philinje: i'm not really chatty right now to be honest. pretty tired i'd rather just focus on testing which is what i'm doing now if that's okay [20:53:35] ok, will send another email. If you are around in the morning your time, I am often online at midnight or so [20:54:08] jdlrobson: what was the updated logo location again? [20:54:22] http://www.mediawiki.org/wiki/File:Mobile_W_beta_light.png [20:56:34] jdlrobson, philinje: changes are live on testwiki [20:56:51] * jdlrobson loads [20:58:30] meaning mobile-geo? [20:58:51] philinje: test.wikipedia.org [21:00:12] hang on, what is the opt-in link? [21:00:19] philinje: http://test.m.wikipedia.org/wiki/Special:MobileOptions/BetaOptIn [21:00:26] thanks [21:00:32] you guys will notice some messages missing (like on the settings page) [21:00:41] those won't display until we push the changes to the cluster [21:02:20] not much content on test [21:02:59] philinje indeed - that's why it's good for us to do functional/display testing on mobile-geo and just last minute sanity checking on test [21:03:03] seems like beta opt-in is not sticky [21:03:27] philinje you might need to clear your cache [21:04:05] New patchset: Jdlrobson; "don't fix height of toggle switch" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/9473 [21:04:15] sticky for me philinje [21:04:23] whoa - just noticed - Images button in Settings should be on by default, not off [21:04:38] philinje: it takes the current setting [21:04:44] or the meaning has reversed [21:05:14] oohh i see what you mean [21:05:14] y [21:05:17] good catch [21:05:19] i'll fix that now [21:05:22] clearing cache did it [21:06:54] not able to test Contents, but Language seems odd in terms of back [21:07:02] New patchset: Jdlrobson; "when images are disabled show checkbox for images as off not on" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/9474 [21:08:01] probably we should gray out the Action button when no Contents and Language are available - i can put that on the WB if too late for this push [21:09:03] Contact us and Settings seem to be pages in terms of back/forward [21:10:52] philinje: that's because they are pages [21:11:03] they have their own url [21:11:30] will that be difficult to change? [21:11:38] philinje: could potentially gray out the action button but probably worth thinking about some more.. especially since we are considering throwing it away [21:11:48] sure [21:13:05] i will mention Contact and Settings on the back page, with a note that they may be difficult to change [21:13:42] New review: awjrichards; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/9473 [21:13:44] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/9473 [21:14:05] i'm confused philinje - are you saying settings and contact should not be accessible via the back button? [21:14:12] New review: awjrichards; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/9474 [21:14:14] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/9474 [21:14:24] jdlrobson: yes, they are really submenus [21:14:41] philinje: I totally disagree. If anything I think the back button should expose more [21:15:06] hmm [21:15:28] let's discuss on the new page [21:15:32] imo the back button should take me back through the journey i took to get to a page [21:15:44] even if that is long and cumbersome at times [21:16:03] but wouldn't the same apply to all submenus then? [21:16:16] For example If I go to a settings page and turn on beta for instance and then do a search and load a page which is broken because of the beta I will expect back to take me back to it so I can remedy the problem [21:16:45] this is why I think we need a discussion on a wiki page about it... it's a complicated matter and I don't think we are doing it right at all right now :-( [21:18:37] good point about opting out - and opting in [21:21:15] which point philinje ? [21:21:25] going back to Settings [21:22:25] also, I suppose the items in the menu are usually pages, which makes sense in a browser [21:22:58] jdlrobson your latest changes are up on testwiki [21:23:05] * jdlrobson nods [21:25:37] jdlrobson: things look good to me [21:25:45] jdlrobson: let me know when you're satisfied and i'll push to the cluster [21:25:53] might just be me awjr but having some weirdness on settings page [21:26:02] what are you seeing? [21:26:15] clicking save hides the settings page [21:26:42] happening on several devices.. [21:27:08] jdlrobson im not seeing that on ics, however the settings page does not seem to remember my image settings... [21:27:37] awjr: same here on android 2.3.6 [21:27:43] also hitting save is toggling the checkbox :( [21:27:46] yeh awjr [21:27:50] sad :( [21:27:56] it originally defaulted to Images on, but then it went to off and I can't change it [21:28:14] think my lst commit wasn't so good [21:28:32] jdlrobson: i see what you mean about the settings page though [21:28:55] jdlrobson: the first time i view it (with beta disabled), clicking submit just shows the message [21:30:52] same awjr [21:31:00] i can't replicate on local.. [21:31:00] New patchset: Jdlrobson; "follow up to 39cc88cdaf68a585337a013b51deea171d08a42b" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/9480 [21:31:15] i wonder if it's this: if ( $request->getVal( 'token' ) != $context->getMobileToken() ) { [21:31:15] return; // Display something here? [21:31:15] } [21:31:27] * jdlrobson shrugs [21:33:44] still seeing the strange back behavior from Language, presumably the same with Contents: [21:33:51] jdlrobson my guess is it's a token issue - things seem to work fine on mobile-geo [21:33:59] jdlrobson im going to get your change on testwiki and try again [21:34:01] k [21:34:19] New review: awjrichards; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/9480 [21:34:21] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/9480 [21:34:27] when the submenu is open, clicking back on the phone does nothing for a couple clicks, then goes to the previous article [21:37:09] jdlrobson: the change should be live on testwiki [21:37:21] k [21:38:28] can't save the form annoyingly [21:38:39] yeah same problem [21:38:44] i wonder why it's happening on test and not elsewhere [21:39:09] verrry odd [21:39:41] jdlrobson it is indeed related to the token issue - the request is getting stuck in that if block in submitSettingsForm [21:39:49] mm [21:40:18] did you add hello ? [21:40:29] yeah [21:41:08] huh yeah the tokens don't match [21:41:16] interestingly... if in beta form works ok [21:41:19] if not doesn't [21:41:32] e.g. go to Special:MobileOptions/BetaOptIn [21:41:39] then change images and hit save [21:43:12] huh [21:43:27] jdlrobson out of curiosity in submitSettingsForm() why didn't you use the checkMobileToken() method? [21:43:46] * jdlrobson bad at php :) [21:44:03] oh also the token in the form is named differently from the token looked for in checkMobileToken [21:44:13]