[00:00:10] so, this is the piece of code i was to touch next [00:00:17] and i'd probably just use module level variables [00:00:19] I just think it's clearer to a newbie [00:00:20] *private variables [00:00:34] and just expose whatever needs to be exposed via accessors [00:00:40] otherwise it's hard to work out which variables are used throughout the code [00:00:43] than use this sortof public but not really [00:00:44] thing [00:00:53] also I'd question whether they need to be returned at all [00:01:38] heh, we're saying the same thing :) [00:02:19] also remind me with require where does the return value get stored? [00:03:06] it's in a variable with the name of first argument right? [00:03:19] no sorry now I'm being stupid [00:03:24] the first arguments are the dependencies [00:03:26] jdlrobson: https://github.com/yuvipanda/WLMMobile/pull/1 [00:03:28] err [00:03:32] function($, l10n, geo, Api, templates, MonumentsApi) { [00:03:43] require(['jquery', 'l10n', 'geo', 'api', 'templates', 'monuments', 'jquery.localize'], [00:03:54] they correspond to the arguments to the function [00:04:00] so jquery gets into $, l10n in l10n, etc [00:04:07] names don't matter [00:04:10] yuvipanda: fixed it [00:04:20] i hate key signing so much [00:04:30] even though organizer was clean of *any* old certs [00:04:41] my system was not. i found an old distro cert inside keychain access [00:04:48] tfinc: i hear there's a key signing party right before Wikimania. You should come protest outside :) [00:04:51] this made Xcode try to sign the app with the new and old cert [00:05:01] funny [00:05:23] yuvipanda: no issues were found [00:05:24] :) [00:05:45] i'll give it a quick pass and barring anything else i'll submit it for approval [00:05:45] tfinc: didn't you also need to do some fixups with the provisioning certificate, which was to expire at the end of the month or something? [00:05:50] tfinc: awesome! [00:06:17] tfinc: i did upgrade testing on it, but you might want to dhat too :) Instructions on the pre-launch checklist page [00:06:21] yes, i regenerated all the expired certs. removed all old certs from organizer but didn't also purge them from keychain [00:06:23] which is dumb [00:06:40] as Xcode should just use what organizer says [00:06:48] apple's stuff just works, except when it doesn't, at which point you're just in voodoo land [00:07:08] tfinc: document this for people from elsewhere running into key issues? [00:07:14] but i'm unsure where [00:07:33] also, how the fuck does one get to gitweb from gerrit? [00:07:33] grr [00:07:37] i'm going to add it to http://stackoverflow.com/questions/5264481/xcode-4-reinstalls-keychain-certs-that-i-delete [00:08:10] there's a tab called 'documentation' which lists perhaps the most useless pieces of documentation [00:08:13] wonderful [00:08:51] googling for 'gitweb mediawiki' seems to be the solution :D [00:09:44] yuvipanda: i'm not seeing images from my previously saved pages [00:10:07] yuvipanda: i can't scroll the about screen [00:10:28] tfinc: which page? [00:10:31] and which OS? [00:10:37] i just did that and got my prior images... [00:10:43] Delhi [00:11:01] tfinc: and OS? [00:11:08] i can scroll about fine on 4.2 [00:11:12] my saved copy would have come from Wikipedia iOS 3.1.2 [00:11:18] iOS5.1 [00:11:28] this is in the simulator [00:12:15] newly saved pages work just fine [00:13:08] tfinc: err, upgrade testing on a simulator? [00:13:17] tfinc: I don't think that'll work right [00:13:30] it noticed i had old pages and ran through the upgrade [00:13:36] old saved pages [00:15:53] okay, about doesn't scroll for me on 5.1 - scrolls on 4.x. [00:15:55] * yuvipanda is baffled [00:16:22] tfinc: so, can you try the saved pages again, but from a 'clean slate'? [00:16:35] it is possible you were testing an RC that it upgraded from, and the RC had a bug, etc [00:18:10] i'm trying on device now [00:21:28] i have the same scrolling issue on device yuvipanda [00:21:58] i can't scroll the config about scrten [00:22:00] screen [00:22:28] tfinc: yeah, i confirm that. am investigating [00:22:34] try upgrade testing [00:23:13] barring some style issues i can't find anything else busted [00:23:36] pinch and zoom works really nicely on map view [00:25:17] yuvipanda: is remotes/yuvi/v3.1.2-iOS the right remote to build from for upgrade testing ? [00:25:34] * jdlrobson takes a deep breath before startling some horses [00:26:49] tfinc: there should be one in the official repo too? [00:26:54] but that works as well [00:27:21] yuvipanda: duh [00:27:28] jdlrobson: number-of-times-scrolling-broke++ [00:27:37] good point. why don't i make it easy on myself by doing that [00:28:12] yuvipanda: http://dumps.wikimedia.org/iOS/ doesn't have it [00:29:08] tfinc: damn [00:29:17] well, upload it when you build a copy? [00:29:20] * yuvipanda adds that to checklist [00:29:41] and i don't have it on my machine [00:29:46] yuvipanda: you must have built it [00:29:53] tfinc: yes, i've a copy [00:30:07] dropbox it so that i can archive it [00:30:08] sending [00:31:22] meh [00:31:28] that was built with my key, not the public provisioning one [00:31:34] need to rebuild [00:32:54] tfinc: sending via email. Dropbox has decided to not work for me today [00:32:59] k [00:33:03] finder crashed earlier, might have been teh cause [00:39:54] got it [00:39:57] testing now [00:41:57] yuvipanda: first test didn't carry over *any* of my newly saved pages [00:42:42] but i wonder if its because i installed 3.1.2 from an ipa and 3.2 directly from xcode [00:43:25] tfinc: yup, don't do that. [00:43:33] tfinc: install both from iTunes [00:43:37] and make sure they have the same name [00:43:45] http://www.mediawiki.org/wiki/Wikimedia_Apps/Pre_launch_checklist [00:43:55] has a section on same names :) [00:44:00] tfinc: now you need to uninstall, then start over [00:48:40] * preilly installing iOS 6 beta on iPhone 4S (GSM) [00:49:44] yuvipanda: same result. i still don't see saves pages when i upgrade [00:51:13] tfinc: are you upgrading to master? [00:51:21] yes [00:51:31] tfinc: and are the ipa files named the same? [00:51:36] archive build from master [00:51:59] yes. i'll do it *one* more time [00:52:03] hmm, maybe they also need to be *signed* by the same key? [00:52:10] tfinc: ^ [00:53:44] tfinc: i think you should make a v3.1.2 build and sign it with your own cert and try? [00:53:55] i think it is possibly because the two versions are signed by different certs [00:54:42] could be. so remotes/yuvi/v3.1.2-iOS ? [00:55:03] tfinc: yeah [00:55:10] or even remotes/official/v3.1.2-iOS [00:55:12] all the same [00:58:17] yuvipanda: k, testing new build now [00:59:47] tfinc: so, about page scrolling works if i turn off 'native' scrolling [00:59:54] this makes no sense, since it was completely working fine prior to this [01:01:57] yuvipanda: no go. i still can't see saved pages across the upgrade even if i use the exact same signing key [01:02:05] since were not agreeing we should get someone else to test this [01:03:00] tfinc: yup. i just tested the upgrade process on the iphone 3g and the ipod and i got mine done nicely [01:03:09] boo [01:03:11] tfinc: how many pages are you saving? [01:03:12] preilly: can you test and validate [01:03:15] 2 [01:03:19] tfinc: which ones? [01:03:28] various links from article of the day on en [01:03:32] okay [01:03:37] and this is an iPhone 4s? [01:03:41] or older device? [01:18:12] tfinc: i've a fix for the scroll issue. [01:18:23] swapped the order of two calls, and it works [01:18:27] and scarily, i don't know why :| [01:18:35] but, it does work [01:19:28] jdlrobson-shinym: https://github.com/wikimedia/WikipediaMobile/pull/255 [01:19:31] tfinc: ^ [01:20:28] alright, i seem to be facekeyboarding veerrry hard [01:20:32] shall go to sleep [01:20:44] tfinc: email me results of your attempt to get saved pages to convert? [01:20:52] make sure you're able to open them in the older version of the app first [01:20:55] before upgrading to newer [01:21:18] and you should get a prompt right after app loads [01:21:31] now i am off [01:21:38] to plant my face on something that's not a keyboard [01:29:46] [WikipediaMobile] jdlrobson pushed 2 new commits to master: http://git.io/JXk6TA [01:29:46] [WikipediaMobile/master] Fix scrolling issues with About page & search results - YuviPanda [01:29:46] [WikipediaMobile/master] Merge pull request #255 from yuvipanda/scroll-fix-number-n - Jon Robson [15:02:48] * yuvipanda looks around [15:03:31] * chrismcmahon waves at yuvipanda [15:03:47] heya chrismcmahon :) [16:12:56] tfinc: I am able to reproduce the 'image missing' bug on migration. [16:14:03] k [16:18:20] New review: MaxSem; "(no comment)" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/10452 [16:48:46] jdlrobson, yo [16:48:52] morning MaxSem [16:49:58] jdlrobson, how hard could it be to make a limited version of ResourceLoader's localisation system for MF? e.g. https://en.wikipedia.org/w/load.php?modules=ext.apiSandbox&only=messages [16:50:22] yuvipanda: hey, can you reply to the email from James Haigh about saved pages? [16:52:09] greetings all [16:52:12] hangout is up https://plus.google.com/hangouts/_/accb2d5d75069c62d7c8ca82dfe6042c0e5e816e?authuser=1&hl=en [16:52:15] MaxSem: yuvipanda --^ [16:52:27] tfinc: I'm going to need a minute [16:52:36] preilly: you have 8 [16:52:39] tfinc: Zero related push right now [16:53:06] preilly: k [16:53:51] MaxSem: not sure really but we should move all messages to ResourceLoader [16:54:34] the problem is still the same: RL support across devices :( [16:54:35] in terms of the problem of languages you flagged about settings though - RL would still serve you them all right? [16:54:52] yes, but not on every page view [16:55:10] well that could be solved by having an addMessageToPage function [16:55:17] which the SpecialPage could add additional ones it needs [16:55:21] for example? [16:55:25] 1s [16:55:41] stand up in 5 min [16:56:05] got it [16:56:44] still, there's no reason to serve ANY JS messages on every page view [16:56:49] so I'm not sure at what point it would happen but in SpecialMobileOptions getSettingsForm I'd imagine a call to addMessageToPage(''mobile-frontend-language-site-nomatches', $val) [16:57:12] why not MaxSem.. it's got to be in js somewhere. [16:57:50] yuvipanda: you joining us ? [16:58:05] (addMessageToPage would add a key to mwMobileFrontendConfig messages) [16:58:06] because page size grows and mobile users have narrow bandwidth, sometimes with per-traffic fee [16:58:50] Sure... but if we're given them extra stuff with javascript that has messages - those need to be served somewhere [16:59:16] you can serve them once as