[13:42:11] MaxSem: is there going to be a deployment later tonight? [13:42:32] mmmmm [13:42:38] maybe [13:43:08] MaxSem: mmmmm ok [13:43:30] you wanted something deployed? [13:43:44] MaxSem: nah, was just wondering when notransform would go out [16:44:51] greetings all [16:45:19] yo [16:45:45] hello! [16:48:15] tfinc: https://github.com/wikimedia/WikipediaMobile/pull/262 Dynamic Sections! [16:48:30] well, not fully 'dynamic', but splits request into two -> much faster initial load [16:48:35] yuvipanda: hows the speed difference with dynamic selection? [16:48:54] lets measure it and add it as the second mobile perf blog post [16:48:59] its a really important change [16:49:21] tfinc: informal testing shows about 40% improvement on longer articles. [16:49:30] (to first load) [16:49:46] tfinc: but I'm on 3G. The slower the connection, the greater the gain [16:55:03] hangout is up https://plus.google.com/hangouts/_/ced38a0b54a498b6c71ae51fb8c5418994b4e1be?authuser=1&hl=en [16:55:22] yuvipanda: thats the kind of results we need to get [16:56:01] tfinc: i'm guessing jon should CR + pull it in, and I'm comfortable pushing it to android store beta [16:59:14] everyone at SF has some kinda drink [16:59:31] water, flask, water, starbucks [17:09:06] yuvipanda: we like our drinks [17:09:06] :D [17:09:30] tfinc: I could see that! [17:09:30] MaxSem: so your saying that our wlm changes were not performant enough. which parts of the app are effected by these slow queries ? [17:11:30] yuvipanda: is the dynamic selector code portable enough to be run on the mobile site ? [17:12:05] none. but the updates are sometimes so slow that query killer interrupts them. turns out that my assumptions for thursday's fixes were wrong, and things are still slow. of course, they're also slow because toolserver's DB is constantly overloaded [17:13:26] tfinc: as the mobile site currently stands, no [17:14:01] tfinc: also, 9s over 14s on iPhone 3G. ~40% reduction [17:14:10] (again on 3G) [17:14:27] yuvipanda: what would have to change? [17:15:32] tfinc: for it to be portable? The mobile site will have to require working jQuery all the time :) [17:15:37] prielly just reminded me that he's at velocity down in santa clara for the mobile performance sessions [17:16:00] yuvipanda: we already tiered to use jQuery on some phones [17:16:22] tfinc: plus the app loads entire content via API - mobile site will have to load lead section + references on first load + everything after that. So it is going to be a bit different. [17:17:03] that sounds like a fun challenge for MaxSem ;) [17:17:05] no rush [17:17:15] yuvipanda, does out app use gzip compression for API calls? [17:17:48] tfinc: yes, supporting non-js phones is the problem. Once jdlrobson and MaxSem figure out what's the best way to do this in a way that's degradable to non js, I'm sure the code here can be adopted (if needed) for the site [17:18:15] MaxSem: IIRC browsers do that automatically. I don't have to specify it [17:19:11] cause The True JSON means that all non-Latin stuff gets encoded like \u1234 [17:19:33] and that increases file size for other languages [17:20:04] MaxSem: i'm pretty sure i send it already, but let me confirm [17:20:13] philinje: any update on the analytics update? It's going to affect a fair bit of June data [17:21:38] yuvipanda: yes, I have notified Erik and Andre, but Andre will not be here at the time June is run, so I'll have to keep an eye on it [17:21:59] philinje: okay! [17:22:13] philinje: what analytics problem are you referring to? [17:22:25] our apps switched to the new API [17:22:29] philinje: if Dynamic Sections goes live, that'll make analytics more complicated too (each page will have two requests) [17:22:57] yes, i flagged that issue on the wiki page, is there a way to avoid that? [17:23:23] yuvipanda, philnje: can you give me some pointers about this because sounds like something that needs preparation [17:23:27] philinje: not that I know of, no. We can easiy find ways to mark the 'initial request' as such, so that analytics can count just that, however [17:23:55] yuvipanda: how would we recognize such an 'initial request' [17:24:03] actually, each article will have multiple pages, one for each section - yes, let's mark the initial page [17:24:26] drdee_: starting with android 1.2, iOS 3.2, we moved to using the API for this. Currently we just use make a single API request that gives us the entire page contents, and we render that [17:24:32] yuvipanda, what two requests? [17:24:45] drdee_: so, on stats.wikimedia.org/wikimedia/squids/SquidReportClients.htm, it will count under 'all requests', rather than 'html pages', so would need to be adjusted [17:25:20] yuvipanda: can you share some test log lines with me? [17:25:42] drdee_: here is the wiki page: http://www.mediawiki.org/wiki/MobileFrontend/Dynamic_Sections [17:25:46] drdee_: I'm unaware where I could get access to logs? [17:26:03] yuvipanda: in a labs test environment [17:26:19] and create some pageviews [17:26:35] drdee_: are you asking for the next version (split requests) or the current version (1 API request)? [17:26:53] the next version, i asume you have a test environment [17:27:13] drdee_: well, I don't have a test environment - the features I need are live on cluster right now. [17:27:24] I can make one, however. [17:27:50] okay, or give me instructions on how to recognize an initial request [17:28:13] MaxSem: the general idea is that each section of an article will be a separate request [17:28:28] drdee_: I was thinking I could simply append dummy GET params to make analytics easy. [17:28:31] but that\s not 2 requests per page [17:28:50] MaxSem: philinje no, this isn't fully 'dynamic' - it does one req for lead + references and 1 for everything else. [17:29:00] yuvipanda: oh i see [17:29:10] drdee_: adding 'reqType=initial' or something similar for initial request [17:29:32] okay sound good [17:29:38] MaxSem: it would be worth getting your input on the project page [17:30:12] philinje: I'll note that dynamic sections for the website are much harder than for the app, and have a different set of challenges. [17:30:33] yuvipanda: yes, good point [17:31:03] yuvipanda: but with the UI overhaul we are considering all of the design issues across apps and site [17:32:52] philinje: ah, okay! [17:33:42] hey philinje: i've invited you for asana, the tool the analytics team uses for keeping track of projects and tasks [17:34:05] if you click on 'Analytics Requests' then you will see a heading Mobile [17:34:07] yuvipanda: sounds like your approach is a good interim step, and maybe the best approach with the apps, but for example back behavior would differ between apps and site [17:34:12] drdee_: thanks [17:34:15] philinje: but should talk to jdlrobson and MaxSem - MaxSem was pointing out nasty cache invalidation issues that we could run into when doing dynamic sections on phones without js [17:34:23] please add any requests there and also rank-order them [17:34:41] drdee_: can you send a link? [17:34:46] i'll assign them to an engineer, starting at the top [17:34:55] you should receive a link shortly [17:35:17] let me know if you don't receive one [17:35:54] drdee_: thanks [17:37:15] philinje: yup! This optimizes for responsiveness, rather than bandwidth [17:37:50] yuvipanda: when you get a chance, could you take a look at https://www.mediawiki.org/wiki/Mobile/Release_history [17:38:12] jrobson: you should get a cloack, jrobson [17:38:29] it would be good to add a Notes column to the Apps table and note any major changes [17:38:51] a cloack? [17:39:00] jrobson: i mean a cloak [17:39:05] philinje: ah, okay! [17:39:10] http://www.etsy.com/listing/85346479/owl-cloak-in-had-painted-wool?ref=sr_gallery_8&ga_search_type=all&ga_includes%5B%5D=tags&ga_search_query=cloak&ga_view_type=gallery [17:39:39] .... [17:40:03] yuvipanda: I just added the Notes column [17:40:25] New review: Jdlrobson; "Only thing I'd say if being pedantic is to put refsections above sections to maintain alphabetical o..." [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/12788 [17:40:38] jrobson: http://24.media.tumblr.com/tumblr_m0omcg6MHF1qbwkxoo1_500.jpg [17:40:49] yuvipanda: by the way, is Wiktionary app using the new API? [17:41:08] exactly. Although I'm a bit worried all my friends now think I'm gay due to my recent adventures so this could cement that belief.. :P [17:41:38] jrobson: yes, those pictures were quite wonderful. [17:41:47] :) [17:42:25] philinje: https://www.mediawiki.org/wiki/Mobile/Release_history#Mobile site beta features is pretty out of date [17:42:33] philinje: how would you like to use it? [17:43:34] MaxSem: do we have a deployment today? [17:44:01] * MaxSem looks if there's something to deploy [17:44:26] * yuvipanda looks at notransform [17:44:38] jrobson: pull requests :) [17:44:45] yuvipanda: I'm working on it :P [17:47:55] tfinc: i'll update that table [17:48:34] philinje: thanks [17:48:48] yuvipanda: iTunes connect shows us that were still in review for 3.2 [17:50:22] twitter was down right silent about us over the weekend [17:50:54] tfinc, will Patrick be here today? There's one revision Yuvi would like to see deployed, but it needs a review. So if if there will be no one to review it before the window window, I'd rather deploy tomorrow. [17:51:07] MaxSem: it isn't really urgent, so I guess it can wait [17:51:27] tfinc: sigh, hopefully within the next few days. [17:52:02] MaxSem: as his mail says. he's @ velocity today. he's online the whole time [17:52:08] MaxSem: just mail him [17:53:47] tfinc, also, there was some subtlety I failed at last deployment - would like someone else to be around [17:56:08] philinje: the wiktionary app does not use the API [17:56:13] just checked [17:56:14] MaxSem: just mail him and setup a time [17:56:56] yuvipanda: arch. thats bad. lets get patrick hayes on that [17:57:41] yuvipanda: thanks [17:58:37] tfinc: should we blog post about the new API? [17:58:55] i remember MaxSem writing up a post at one point. how far did you get MaxSem ? [17:59:13] tfinc, to the point I asked for help:P [18:01:17] MaxSem: is it up on google docs and/or wordpress ? [18:03:07] nope. I couldn't chhose an appropriate approach to it - what exactly should it announce - "hey'weve got a mobile API!"? how much technical should it be - tech blog seems to be oriented at non-developers [18:06:26] philinje: can you work with MaxSem to craft the feeling and wording of it ? [18:07:38] New patchset: Jdlrobson; "hide address bar as soon as script loads" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/12901 [18:07:58] New patchset: Jdlrobson; "allow user to switch site-wide language from the settings page" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/10452 [18:08:15] MaxSem: can you help me with that and making it use SiteMatrix? I'm stumped and I'd like to get this out today ^ [18:08:47] jdlrobson, sure [18:08:48] tfinc: MaxSem ok, send me any basics in an email and I will draft something [18:09:26] philinje, the problem is that I don't know how to start:( [18:09:46] just send me the technical details and I will write it, that's what i meant [18:10:16] Thanks MaxSem - I wasn [18:10:17] 't [18:10:38] okay. tfinc - what did you want me to cover in this post? I remeber it started when we discussed the deprecation of the old JSON inteface [18:10:39] I wasn't sure what was the best way to check for the existence of SiteMatrix and how to get the available languages - since they seem to be tied to project names [18:11:24] MaxSem: so the overall theme of the post should be why developing this API has made our lives easier and how anyone who's still screen scraping mobile should switch [18:14:15] i should be able to read it as a mobile dev and say … "why wasn't i using this sooner" [18:21:29] MaxSem: send me text about the old and new approaches, with links to APIs, code samples, whatever you like - i will edit and add the tone [18:21:40] philinje, okay [18:22:09] yuvipanda: is 12 noon here ok for the showcase on Thur? [18:22:33] philinje: sure! [18:22:43] when does DST end for you guys? [18:23:48] yuvipanda: sometime in Aug or Sep, I think [18:24:19] wah ok [18:34:15] philinje: hows the feedback from the sibling move? [18:40:56] tfinc: no one has written email, aside from the one person about Farsi a week ago [18:49:02] philinje: then were just going to keep moving forward then [18:49:35] philinje: how soon can we get messages about creating main pages for our next batch ? [19:14:53] philinje: got asana invite? [19:36:34] [WikipediaMobile] jdlrobson pushed 2 new commits to master: http://git.io/pPWLUQ [19:36:34] [WikipediaMobile/master] Update app to work with latest MobileFrontend - YuviPanda [19:36:34] [WikipediaMobile/master] Merge branch 'master' of github.com:wikimedia/WikipediaMobile - Jon Robson [19:38:35] yuvipanda: can you rebae [19:38:39] *rebase https://github.com/wikimedia/WikipediaMobile/pull/262 [19:42:32] jrobson: one second [19:44:30] philinje: where can i find the backlog your creating for wiktionary? [19:45:42] jrobson: see branch dynamic-sections-2 on my remote [19:45:45] *repo [19:45:48] yuvipanda: most bizarre review ever "Wtf? I just installed, so why is the home page Homicide: Life on the Street? I didn't ask to see that. I've never even watched the show. I just opened the app and viola, Homicide! No home page. Homicide is my home page. Unistalling and will access thru browser. No homicide there." [19:46:57] SO yuvipanda I should close https://github.com/wikimedia/WikipediaMobile/pull/262 ? [19:47:14] tfinc: yuvipanda it suggests that people might expect a getting started page on the homepage [19:47:24] also yuvipanda found a weird bug in the release candidate [19:47:29] one of my saved pages will not load [19:47:33] all the others are fine.. [19:47:42] jrobson: you mean https://bugzilla.wikimedia.org/show_bug.cgi?id=36017 [19:47:49] jrobson: which one? [19:47:54] yep yuvipanda [19:47:59] For some reason House TV series [19:48:06] any way I can debug a release? [19:48:13] jrobson: House is just messing with you, I guess? :P [19:48:19] jrobson: yes, you can. open xcode, window -> organizer [19:48:22] jrobson: you can see the logs [19:48:33] jrobson: also, why did you need the rebase? there were no conflicts [19:49:02] didn't 44bb1ec just get merged? [19:49:10] https://github.com/yuvipanda/WikipediaMobile/commit/44bb1ec794093fb9936b03b00de9be2bb00c006a [19:49:31] jrobson: I included that commit in https://github.com/wikimedia/WikipediaMobile/pull/262 for the exact same reason :) [19:49:44] jrobson: so I guess there shouldn't be a problem? [19:49:46] * jrobson confused [19:49:46] when that gets merged? [19:49:52] okay, I think I took it the wrong way [19:49:53] yuvipanda: can you go through the errors for both wikipedia apps in the store this week? [19:50:15] tfinc: sure. [19:50:23] jrobson: okay, since there are no code comments i'll just force-push [19:50:41] jrobson: the fact that that commit is there still shouldn't cause problems, however. [19:51:30] also yuvipanda Facebook issue - 2012-06-25 11:45:24.138 Wikipedia-iOS[420:707] [INFO] Error in success callback: org.apache.cordova.facebook.Connect1 = ReferenceError: Can't find variable: FB [19:51:58] jrobson: thats because you haven't set the Facebook app id [19:52:08] let me add you as dev for it [19:52:56] i'd add yuvipanda but he's "Yuvaraj Pandian T is not a verified user." [19:53:34] tfinc: 'Your mobile phone has been successfully verified, and you are signed up for Facebook Mobile. [19:53:37] ' [19:53:39] that's been the case for quite a while [19:53:59] Facebook still tells me your unverified [19:54:07] i was able to add jdlrobson3 just fine [19:54:08] tfinc: I can't get my own name in the URL like https://www.facebook.com/yuvipanda without verifying [19:54:15] tfinc: so facebook seems messed up somewhere [19:55:21] Facebook is messed up in many of places [19:56:32] sadly including this [19:56:49] jrobson: i think that that's not a key issue. That's what is causing the first request after login to fail - hit share again and it should work. [19:57:43] Now when I share I see a Facebook page saying 'Error' - an error occurred please try again later [19:57:55] jrobson: ah, *this* is because you haven't added the key :) [19:58:06] jrobson: you need to run ./add-keys.bash and give it the key [19:58:13] what key do I give it? [19:58:20] sorry /me new to iOS dev [19:58:29] jrobson: the key from facebook dev center [19:58:38] jdlrobson3: go to developers.facebook.com [19:58:39] jrobson: you should be able to access the wikipedia app, since tfinc gave you access [19:59:16] jdlrobson3: https://github.com/wikimedia/WikipediaMobile/pull/262 has updated [20:02:21] yuvipanda: did you get all the graphic assets that you were waiting on ? [20:03:09] tfinc: yeah, i've been putting them in + fixing up the colors now [20:04:33] so yuvipanda I was playing with the release candidate - I've given up on that for the time being since it's released - just wanted to have a play around. Luckily I was unable to replicate the saved pages bug - I guess the save went a bit wonky. Tried saving again and there were no problems [20:05:35] jrobson: i'd definitely want to take out the facebook cordova plugin in a later release and add in the native fb support on iOS - but that's 2-3 releases down the line [20:05:54] jrobson: saved pages are always a PITA :( me no like them. [20:06:47] [WikipediaMobile] jdlrobson pushed 1 new commit to master: http://git.io/L5BBRg [20:06:47] [WikipediaMobile/master] Update style guidelines [20:07:19] https://github.com/wikimedia/WikipediaMobile/pull/173 < yuvipanda should we close this with comments? I think we discussed how we are not planning to support Qt platform? [20:08:16] jrobson: yes, we should. Kelson is working off of it, but that's going to be kept separate [20:08:24] jrobson: why don't we get sumana to help us review it . its a community contrib after all [20:08:54] tfinc: I don't think that fits here. It's the base for work Kelson (Emmanuel) is doing, which is in a different repo. [20:09:06] tfinc: I think closing it with a link to that repo is appropriate [20:09:07] which repot is kelson working in? [20:09:10] k [20:09:26] yuvipanda: we need to figure out how were going to run the showcase later this week [20:09:30] id like to have your run through the app steps [20:09:49] but we all know the emulator is slow [20:09:49] tfinc: i just asked him on irc, will update and close when he responds [20:09:55] k [20:10:00] tfinc: true that. Does marteen / elka have a phone? [20:10:06] err [20:10:08] android phone? [20:10:11] philinje: --^ [20:10:21] tfinc: what exactly is the goal of this showcase? [20:10:45] yuvipanda: to show them the first point to point running version of the app and see if were hitting the mark [20:11:17] philinje: this needs an update https://www.mediawiki.org/wiki/Mobile_design/Wikipedia_navigation [20:12:35] tfinc: alright. I think them trying it out hands on is the best way to go. [20:12:42] emulator / video of me showing stuff is going to suck [20:13:13] tfinc: the emulator's photo-taking capability is very suspect, so I don't expect that to work smoothly at all [20:14:51] yuvipanda: its crap [20:15:02] they better reveal something less shitty at google i/o this week [20:15:16] philinje: have you seen our in channel questions today? [20:15:37] tfinc: personally i'm hoping nexus tablet comes out and is available - perhaps i can score one after wikimania before I fly back :D [20:15:49] the'll show that i'm sure [20:15:56] tfinc: I think with 4.x it uses GPU if your system has them - a step up, but useless on macbook airs [20:16:36] it has to run as fast as the iOS simulator. simple as that [20:16:50] tfinc: not going to happen, sir :) [20:17:04] emulators will never be as fast as simulators, so unless Google puts out a simulator... [20:18:09] thats what they should do [20:18:39] yuvipanda: elke has an android phone, not sure about Maarten or others [20:19:58] tfinc: philinje: where can i find the backlog your creating for wiktionary? 12:44PM [20:20:19] tfinc: philinje: how soon can we get messages about creating main pages for our next batch ? 11:49AM [20:20:33] the feedback page is listed on Mobile/Feedback [20:21:06] tfinc: philinje: this needs an update https://www.mediawiki.org/wiki/Mobile_design/Wikipedia_navigation 1:11PM [20:21:12] we can run Global Message Delivery at any time, sooner the better [20:21:58] Wikipedia navigation - not really anything to report since 6/15, but there will be today [20:24:07] philinje: lets run it today then [20:24:18] ok [20:33:13] philinje: J2ME screen flow is now up on commons http://commons.wikimedia.org/wiki/File:WikiWorkflow.png [20:37:12] tfinc: ok [20:48:47] yuvipanda: I'm worrying that page.js is becoming very unreadable [20:54:38] jrobson: ? [20:54:41] jrobson: because of? [20:55:46] well i've not looked at this code in a while and looking at it with fresh eyes I'm thinking how do I get and print a page. [20:56:16] I'd hope to do something along the lines of var p = new Page('Page Title'); p.retrieve(); $("#content").p.toHtml()); [20:56:19] jrobson: getting a page is an async operation, so a 'new' won't work [20:56:23] $("#content").html(p.toHtml()); [20:56:26] jrobson: not a fan of pages that can be empty or not [20:56:32] that would be the most common use case right? [20:56:39] jrobson: retreiving html is also now an async operation [20:56:56] jrobson: well, it makes sense in a synchronous world :) [20:57:12] p.retrieve() can not really work, for example - since it would be asynchronous [20:57:32] I really hate the existence of Page.fromRawJSON and Page.requestFromTitle [20:57:59] jrobson: i think those two look similar because they share the API params [20:58:20] jrobson: i don't see what else they share, and that is easily refactorble [20:58:32] jrobson: fromRawJSON is used internally and externally (for saved pages). [20:58:42] jrobson: why exactly the hate for fromRawJSON? [20:59:26] jrobson: I'm unsure how exactly a better async API would be designed? [21:00:14] i should rename toHtml to toSkeletonHtml or something to maintain consistency with what it actually does [21:03:52] "Exit function would be really nice. What are your devs thinking? I have to use another app to close/kill your app. WAKE UP. [21:03:55] " [21:03:57] sigh [21:05:05] I think I need to go for a walk and clear my head.. just reviewing page.js has made me feel confused and uncomfortable. It feels like a page object should just take a json as a parameter and that fromRawJSON should be part of the constructor - it sets more of an expectation of how it should be used. Looking at it with fresh eyes I expect it to be an object that starts off empty when in fact it isn't [21:05:52] I think also attaching to the Page object itself feels weird [21:06:10] anyway brb with a clear head.. [21:07:22] * yuvipanda waits for jrobson with a clear head [21:08:20] jrobson, will you be around 3pm-4pm PDT for deployment? [21:08:31] yes MaxSem [21:12:38] jrobson: poke when back :) [21:13:51] tfinc, did you get my email the other day? [21:13:57] Thehelpfulone: yup [21:14:03] its starred. i'll respond to it later [21:14:47] sure, thanks [21:37:40] MaxSem: have you had any chance to look at https://gerrit.wikimedia.org/r/#/c/10452/ (in particular https://gerrit.wikimedia.org/r/#/c/10452/8/specials/SpecialMobileOptions.php L56 ? ) [21:37:51] had been hoping to get that out in todays deployment.. [21:38:19] nooope [21:38:24] :( [21:39:00] I'm not deploying complex commits that aren't merged 20 minutes before the deployment:) [21:40:23] by the way, $wgMFAvailableLanguages isn't initialized [21:40:53] and I need to add SiteMatrix support to it [21:41:08] can you help me get it in for next deployment then (whenever that is)? [21:41:51] it's already on my books [21:43:22] thanks [21:44:18] where did dl go?:P [21:46:49] jrobson: I renamed 'fullPage' to a more sensible 'isCompletePage'. Better suggestions welcome [21:47:20] and pushed to the pull req :) [21:47:30] so.. I'm still pondering but one of the things I don't like is exposing the Page object [21:48:00] jrobson: exposing -> ? [21:48:07] it feels like we should be using the helper functions fromRawJSON and requestFromTitle that return page objects [21:48:12] well Page is a global [21:48:25] but as I said I'm still pondering [21:48:49] jrobson: I could see how moving fromRawJSON to the constructor would help. [21:49:14] jrobson: requestFromTitle can never 'return' a Page object - async, etc. [21:49:54] jrobson: well, the Page constructor is global :) [21:50:17] yuvipanda: but requestFromTitle provides a page object in the callback [21:51:03] jrobson: yes in the callback. I think 'return' was me being a little bit pedantic :) [21:51:08] I just think we could signpost the entry points to the code better [21:51:32] jrobson: requestFromTitle is pretty much the one entry point. [21:51:50] if the page constructor was not a global it would make it clear that you create page objects from helper functions rather than create an empty page object and then do things with it [21:52:13] jrobson: how can you expose Page.fromRawJSON without exposing Page? [21:52:31] jrobson: also, I'm moving fromRawJSON into the constructor, so I think that'll alleviate that 'uncleanness' feeling? [21:53:08] well you'd have say window.pageHelper.jsonToPage() which returns a page object [21:53:27] it just wouldn't be possible to do new Page() anywhere outside page.js [21:53:50] maybe I'm unique but when I look at code I tend to console.log window and explore what's new [21:53:53] and make assumptions :P [21:57:41] jrobson: I just realized I'd need a 'dummy constructor' of sorts [21:57:51] jrobson: since iOS app does page saving by serializing the Page object into JSON and saving it [21:58:10] jrobson: also, pageHelper? pageFactoryFactoryFactoryManager next? :P [21:58:47] jrobson: Page.fromRawJSON is a 'class method' [21:59:02] jrobson: all your concerns seem to boil down to lack of documentation, which is a separate issue, no? [21:59:45] Yeh I know I'm not being helpful but it's more of a public/private thing - I don't like things being public if they shouldn't be used [21:59:58] and I don't think we should ever be doing new Page( in any of our code based on how it works [22:00:14] jrobson: yeah, so am now making a Page.deserializeFrom [22:00:51] jrobson: so then there would be no entry points that 'shouldn't' be used [22:00:55] commit coming up in a few mins [22:00:59] ok [22:01:09] (I know I'm a pain) [22:01:31] I've also got one eye on the mobile site and how that would work [22:01:56] jrobson: first, i'm wondering if page.js would be applicable at all [22:02:08] jrobson: since the request would send back content [22:02:14] at least the initial lead + references [22:02:57] jrobson: plus I'm unsure you'd want to use templates in the mobile site, so not sure what that code could help with either. [22:03:04] yes.. which is what is concerning me - that we'd need a lot of refactoring to share code [22:03:28] jrobson: yes, because in *this* case they're doing fundamentally different things. [22:03:37] jrobson: I think worrying about it now is premature architecting [22:03:45] possibly. I worry lots ;-) [22:04:01] jrobson: we can do that once you and MaxSem have figure out how you're going to do dynamic sections [22:04:05] but in future I want all page loads to go via javascript in which case they would do that same thing [22:04:15] so initial page load would just load sections [22:04:21] any further loads would do the same as the app [22:04:56] jrobson: I propose that when we start there, we can move this to a 'base' class and then just override implementations [22:05:19] jrobson: the API handling code, etc can be shared, while we can override 'config' things (like base URL) [22:05:45] jrobson: but worrying about that right now would be premature [22:06:04] jdlrobson, yuvipanda: the code is live on http://test.m.wikipedia.org/wiki/Main_Page - please test [22:06:32] MaxSem: is this deploying current master? [22:06:43] yes [22:06:52] MaxSem: ok :) [22:07:08] t/me goes to get some physical devices [22:17:03] MaxSem: do we know why the Wikipedia logo is not showing on wikipedia.org? http://test.wikipedia.org/w/static-1.20wmf6/extensions/MobileFrontend/stylesheets/images/logo-copyright-en.png [22:17:08] (in the footer) [22:17:30] jdlrobson, Arthur changed it before going on vacation [22:19:24] are we able to fix that? [22:21:10] https://bugzilla.wikimedia.org/show_bug.cgi?id=37328#c4 [22:24:34] * yuvipanda throws assorted weapons at PhoneGap [22:24:39] errors without fuckin line numbers [22:25:08] so far btw only found one bug - references don't seem to work on a nokia s60 [22:26:11] (but it is fine on my local copy..) [22:30:25] jrobson: Updated to have no dummy constructor - though I'm not sure if deserializeFrom is an improvement or a travesty. [22:35:42] MaxSem: WFM [22:36:54] jdlrobson, so it's good to go? [22:37:02] yup [22:40:13] philinje: what have we heard from global dev about sharing in the j2me app ? [22:40:22] jdlrobson, live on mw.org [22:40:53] mw.org ? [22:41:14] we deploy to mediawiki.org first now? [22:41:38] the only production wiki on 1.20wmf6 atm [22:42:17] cool [22:43:43] MaxSem: can you remind me how to surface page history though the api. preily showed me an example last week but i don't have the link in my history [22:44:04] mediawiki.org homepage needs to be mobile optimised btw [22:44:22] jdlrobson: its in a future batch for us to do [22:44:36] and mediawiki.org mobile site logo is wrong [22:44:40] jdlrobson: http://www.mediawiki.org/wiki/Mobile_default_for_sibling_projects#Timeline [22:44:43] we should configure that while we are there [22:44:59] (in fact it should be configured by default..) [22:45:00] https://en.wikipedia.org/wiki/Special:ApiSandbox#action=query&prop=revisions&format=json&rvlimit=10&titles=MediaWiki [22:45:05] not sure why it's showing the wikipedia logo [22:45:31] because technically it is [22:45:59] db name 'mediawikiwiki' = project 'wiki', language 'mediawiki' [22:46:23] and don't ask me if it makes sense, it doesn't have to:P [22:46:59] I hadn't seen that before, and here I was thinking commonswiki sortof didn't make sense [22:49:50] we're live on all the rest wikis [22:53:04] mediawiki.org looks fine MaxSem [22:57:47] yuvipanda: a happy ios app user -> http://twitter.com/Whatsinmypurse/statuses/217059494147002369 :) [22:59:34] jrobson: :) [22:59:50] jrobson: may their numbers increase :) (3.2 should make a few of them happy) [23:00:35] jrobson: do look at the pull req again when you've the time :) [23:00:53] will do… just curious about something I've discovered in WP7 [23:10:57]