[14:59:51] Hi MaxSem, for a general search it looks like we are supposed to use action=opensearch. I noticed the JSON format is a list where the objects are the original search term and the list of results. is this expected? [15:00:17] hi [15:00:55] I was expected to get back a full object {} for the main result and wanted to make sure I'm looking at this right [15:00:58] opensearch is a prefix search action, you'd better use action=search [15:01:07] ok [15:01:23] action=search is full-tgext [15:01:27] I didn't see search in the sandbox [15:01:47] brr, action=query&list=search [16:16:46] good morning jdlrobson [16:17:05] morning max [17:38:03] jdlrobson: have you seen patrick around? [17:38:20] he's not in the office [17:38:24] wasn't yesterday either.. don [17:38:29] 't know where he went [17:38:35] ok thnx [17:40:30] hey jdlrobson [17:40:37] yuvippandda! [17:40:49] is more accurate [17:44:59] ZombiePanda: are you as hungry for brains as i am? [17:45:08] jdlrobson just talked to patrick - he's out sick [17:45:24] :( [17:45:58] awjr: hungry for sleep, more like. Except that I can't seem to get any [17:46:27] awjr: more http://rookery.s3.amazonaws.com/1131500/1131740_5958_625x1000.jpg than http://lparchive.org/Resident-Evil-0/Update%2017/img-11.jpg [17:46:47] lol [17:46:59] ZombiePanda are you back home? [17:47:15] awjr: i'm at my parent's place. Will be back to my beach-abode tomorrow [17:47:19] (for some definition of tomorrow) [17:47:31] lol [17:47:39] the time change btwn us and india is brutal [17:47:56] awjr: to say the least [17:48:01] but i'm completely fine flying in to the US [17:48:04] flying out is what kills me [17:48:12] im the opposite [17:48:16] I think that might be saying something :P [17:48:22] but i think it's because i get so damn excited [17:48:27] heh [17:48:28] and then just collapse when i get home [17:48:50] I think maybe it is just that everyone collapses when they get home [17:49:04] hehehe [17:49:34] to make things very worse i've to be up for college at 7am [17:49:38] jdlrobson when you have a chance, i go the template issues sorted last night: https://github.com/wikimedia/WLMMobile/pull/53 [17:49:47] :( [17:49:59] awjr: did you get rid of upload.js? [17:50:03] i had no idea it was there! [17:50:10] awjr: will do.. just fixing up my pull request [17:50:10] and it wasn't really being used anywhere before [17:50:16] ZombiePanda: not entirely but i think it's now safe to get rid of [17:50:33] ZombiePanda: i moved the two useful functions out of it into app.js for now; the remaining function is unused [17:51:31] okay! [17:56:00] ZombiePanda just removed upload.js in my pull req [17:59:43] awjr: \o/ [18:10:40] awjr: progress on the admin tree stuff? [18:10:51] ZombiePanda: still waiting for my TS account. [18:11:04] ZombiePanda: but take a look at the bug; i whipped up what i could with my lack of access [18:11:24] awjr, any problems installing this thing locally? [18:11:55] MaxSem: actually since we talked about it Friday when I was doing my 20% I forgot to try [18:12:00] i'll take a stab at it in a bit [18:12:02] awjr: https://commons.wikimedia.org/wiki/Commons:Monuments_database/Setup/In_labs [18:12:09] should work for local setup too [18:12:13] sweet thanks ZombiePanda [18:12:20] ZombiePanda, he doesn't need 99% of this [18:12:31] just a DB with monuments_all [18:12:48] which is present in the dump [18:12:52] true that, but that's the only link I have :D [18:13:07] awjr, you're being trolled:P [18:13:13] plus maybe he'll need it if he does anything more involved in the future? [18:13:25] MaxSem: he needs the api anyway [18:13:50] hehehe [18:13:53] i'm sure i'll manage. [18:18:11] awjr, I've updated this manual, you don't need to hack the sources anymore [18:18:21] cool thanks MaxSem [18:19:22] thanks MaxSem! [18:22:00] awjr, ZombiePanda, jdlrobson: if we make the app use a WMF-hosted API, can we make it fall back to Toolserver if the former goes down/gets shut down permanently? [18:22:31] i dont see why not [18:25:29] i don't see why not either, but since it is toolserver, I don't think that counts much as 'redundancy' [18:27:45] ZombiePanda: there's no way i can separate these commits without becoming the new author right? https://github.com/wikimedia/WLMMobile/pull/55 [18:29:09] jdlrobson: well, you can always specifiy author name to git commit with a param [18:29:46] jdlrobson: --author [18:30:00] cool I'll do that then [18:36:02] ZombiePanda: > https://github.com/wikimedia/WLMMobile/pull/53 [18:36:09] didn't understand your last comment [18:36:27] did you mean keep it all on one line? [18:40:00] unless it gets very long or involves callbacks, yes [18:40:02] jdlrobson: ^ [18:40:09] k [18:40:11] than an arbit 80char limit [18:40:14] I'm testing and merging now [18:40:22] \o/ [18:40:56] i'm setting up eclipse, will review / test / merge your stuff right after [18:45:52] Feck. I've got that weird java bug again. I need to reboot [18:46:02] heh [19:15:44] hey plancalculus [19:15:50] thanks for the contributions! [19:15:57] hey [19:16:16] I have added a button to the ios application to share an article view mail [19:16:28] I wonder what I have to do to get the text translated [19:16:36] plancalculus: we merged that :) Should be in the next release [19:16:43] i don't think you need to do anything special [19:16:45] let me check [19:17:21] I think right now there is only an entry in the english translation file [19:17:43] plancalculus: you don't have to worry about that. The folks at translatewiki.net will take care of it [19:18:07] plancalculus: you usually just need to add entires for messages-en and messages-qqq [19:18:18] qqq -> Descriptive message explaining what the text is and where it is used [19:19:24] I did not add one to qqq, will catch that up [19:20:04] plancalculus: :D [19:20:36] plancalculus: any particular thing you're planning on working on nex? [19:20:37] *next? [19:20:58] Furthermore, I wonder whether there is any difference between strings enclosed in ' and the ones enclosed in " [19:21:09] I did not observe a pattern [19:21:46] there isn't any :) [19:21:50] we're sticking to new ones in ' [19:22:01] and anytime we touch we try to make it a ' [19:22:53] plancalculus: this started a long time ago with no style guidelines, which sortof came in later. so the style mess [19:23:34] So it's the usual approach ; ) [19:23:41] pretty much yeah :) [19:25:03] If I understand correctly, arguments of function are always enclosed in a single whitespace like f( arg ) [19:25:32] plancalculus: they *should* always be [19:25:35] old ones are not [19:25:48] but yes, you got that right :) [19:26:04] what if the argument is a higher order function and the braces as well as the paren are closed on a new line? [19:26:22] } ); [19:26:42] f( function( e ) { [19:26:44] .... [19:26:45] } ); [19:27:07] So there is no whitespace after the brace? [19:27:21] ? [19:27:37] there is no whitespace before ;, other than that, there's whitespace everywhere [19:28:21] I am sorry, in my irc client it looked like there is no whitespace between } and ) [19:28:43] ah, okay :) [19:28:49] i can pastebin it [19:29:04] plancalculus: http://pastebin.com/V6eEkEHB [19:31:48] plancalculus: if you're looking for more bugs to fix, https://bugzilla.wikimedia.org/show_bug.cgi?id=37722 is something i'd love to have :) [19:32:44] Sounds great. I have started working on bug 36393 [19:33:53] I am a little stuck now [19:34:23] I managed to display the main contact page in a similar way as the about page is shown [19:35:14] * ZombiePanda looks [19:36:23] plancalculus: hmm, that's possibly slightly complicated, since the app is not setup to run custom js from page (would be very dangerous) or to properly submit form actions [19:40:31] Ok, when I chose this bug I wasn't aware that the contact page is more than a single page [19:40:44] plancalculus: let me update that page with details [19:41:04] plancalculus: it currently is a page with email links, but it is actually supposed to be something much different [19:42:17] plancalculus: it was killed for now due to UA / privacy issues [19:45:05] plancalculus: updated [19:45:25] plancalculus: in short I don't think it's a good idea to work on that now 'coz contact us can/is-going-to change [19:47:13] :( [19:48:25] thanks very much for the info [19:48:51] jdlrobson probably has links to the discussions on enwiki that made us kill the form [19:49:01] but i think i've distilled that down a bit [19:49:54] plancalculus: just curious - do you also have an iPad? [19:50:04] because this would be a very welcome feature https://bugzilla.wikimedia.org/show_bug.cgi?id=37891 [19:51:09] No, although I am a fan of Apple products this one is still missing [19:51:16] heh :) [19:52:35] By the way does Wikipedia own devices especially android devices for testing? [19:55:03] plancalculus: yes, we do [19:55:08] quite a few at the office, IIRC [19:55:13] and iOS devices as well [19:55:20] but i'm in India, so sadly don't have access to most of those [19:55:31] and I now have a power cut too, so will be off any moment :( [19:57:00] Thanks very much for your time [19:57:38] plancalculus: thanks for contributing! [19:57:47] i'm sorry i've to go now [20:27:22] ouch! [20:27:26] action=search adm0=(user-input) (any number of them, till 3) srname=(user-input)% [20:27:39] that is atrocity [20:27:54] :( [20:28:32] * MaxSem was referring to https://www.mediawiki.org/wiki/Wiki_Loves_Monuments_mobile_application/Queries [20:52:38] so awjr I think the problems you are seeing with 49 are due to it not been rebased [20:52:43] the multiple messages was fixed elsewhere [20:52:54] oh interesting [20:53:15] let me try rebasing against upstream/master [20:56:36] I rebased on the pull [20:56:56] damn it jdlrobson you are right! [20:57:00] it looks fine [20:57:03] sorry about that [20:57:05] of course I AM! :P [20:57:07] ;-) [20:57:09] :p [20:59:46] feck [20:59:49] just screwed up a rebase [20:59:56] and pushed to origin :( https://github.com/wikimedia/WLMMobile/commit/59f4c5f95eeb6ebdbe503490b2914e983929f0d8 [20:59:58] :( [21:00:27] wait... [21:00:29] im confused [21:00:31] what happened? [21:00:46] I'm not sure [21:00:49] but that commits the same as https://github.com/wikimedia/WLMMobile/commit/54509ec388d644a2b725470ca32cc2ea447e3f35 [21:00:51] and it's confused me [21:01:22] basically you merged just after my rebase [21:01:33] and then i did a git pull origin master and then pushed to origin [21:02:45] hrm [21:03:26] hrm indeed [21:03:27] so 59f4c5 is a bad commit? [21:03:33] I guess so [21:03:37] but I'm a bit confused [21:03:43] i am too [21:03:51] ah I see what's happened [21:04:04] actually no i dont [21:04:08] lol [21:04:22] well the result is correct [21:04:24] as in the codebase [21:04:28] just not sure how we got to it [21:04:45] its like you rebased on top of a rebase [21:05:10] the history looks ok, at least at a quick glance [21:07:17] don't touch anything… [21:07:26] there's lots of confusing stuff going on ;-) [21:07:39] aye [21:12:17] jdlrobson looking closer at the history i think it's OK [21:12:25] just a smidge ewird [21:12:33] *weird [21:13:53] ahh wtf [21:14:24] i just tried to push some new stuff and it said it wasn't up to date again [21:14:25] eek [21:19:05] k i think I got it sorted [21:19:19] although for some reason I cannot build with ant any more [21:19:43] hurray for ant clean [21:24:48] my plan now is to get both remaining pulls merged [21:49:16] linSmith: are you upstairs? [21:49:37] jdlrobson yep [21:50:47] cool I'll come up in a bit to annoy you [21:51:03] MaxSem: is there any sample data for admin_tree? [21:51:27] you'll have to generate it from monuments_all [22:35:25] MaxSem ok cool - do you have a script that does that already or shall i whip something up? [22:36:20] I started from http://dpaste.org/7DIXf/ but it's just 3 levels [22:36:50] ok cool thanks [23:38:40] argh [23:38:42] * awjr stabs svn [23:47:17] awjr, http://i.qkme.me/360s7q.jpg [23:47:31] heh [23:47:44] just svn merge conflict nightmare because i cant commit yet :( [23:48:05] on the upside, my api appears to be working as spec'd in the bug [23:48:09] I can commit for you [23:48:26] MaxSem let me make a few more changes and i'll send you a diff [23:53:14] wtf [23:53:22] svn diff just appears to have deleted the file with my changes [23:53:24] sigh. [23:53:27] mmmmm, delicious sphinx. returns nothing when it should, it really should [23:54:06] ok i can make the changes again from memory i think, but wtf [23:54:23] MaxSem im gonna take a quick break and then fix this and send you the patch [23:54:53] okay, I'll take a look at it tomorrow [23:54:58] groovy [23:55:45] I thought only git can fsck up your working copy [23:56:18] id ont know wtf happened [23:56:42] svn is not very friendly when you make edits and cant commit :( [23:56:47] ok brb