[00:10:51] jdlrobson: did you happen to find the link to that original jquery.localize.js script? [00:11:14] hey dan-nl ! yes [00:12:25] dan-nl i replied on the pull request.. trying to dig out the link now [00:15:02] jdlrobson:now worries then, i'll look through the pull requests and find it [00:15:02] dan-nl: it's in the mediawiki core > https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=blob;f=resources/jquery/jquery.localize.js;h=27cae292bf69a88b92e1d444d7f7784a789c090f;hb=HEAD [00:15:25] nice, thanks :) [00:24:51] concur; all staff can be draining. [00:54:37] jdlrobson: feel free to email me if you have any further questions, enjoy our chat earlier today, thanks for taking the time [05:03:00] [WikipediaMobile] preillyme pushed 4 new commits to master: http://git.io/PVvQCA [05:03:00] [WikipediaMobile/master] README.md: add link to TWN project - jeremyb [05:03:01] [WikipediaMobile/master] README.md: rephrase fork, link fork URL directly - jeremyb [05:03:01] [WikipediaMobile/master] README.md: reformat - jeremyb [05:03:22] Project WikipediaMobile - Nightly builds build #363: SUCCESS in 12 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/363/ [05:03:22] * jeremy: README.md: add link to TWN project [05:03:23] * jeremy: README.md: rephrase fork, link fork URL directly [05:03:23] * jeremy: README.md: reformat [05:14:15] preilly: gah, thanks but you're too fast. i found some problems with my commits, more on the way ;) [05:14:58] i'll assume you want fast forwards not amends [05:15:01] at this point [05:15:22] yeah fast forwards [05:23:56] * jeremyb wonders why the bot doesn't report pull reqs [05:26:35] [WikipediaMobile] preillyme pushed 2 new commits to master: http://git.io/UGQTGg [05:26:35] [WikipediaMobile/master] README.md: followup 34ffccbef51e679e10 - jeremyb [05:26:35] [WikipediaMobile/master] Merge pull request #271 from bymerej/master - Patrick Reilly [05:26:39] jeremyb: yeah that's weird [05:26:44] Project WikipediaMobile - Nightly builds build #364: SUCCESS in 7.5 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/364/ [05:26:44] jeremy: README.md: followup 34ffccbef51e679e10 [05:28:01] preilly: also, why do i seem to have received no mail about all of this? [05:28:24] jeremyb: no idea [05:28:34] jeremyb: I can look into it tomorrow though [05:28:48] notifications were enabled for at least 270 [05:28:56] * jeremyb will double check [05:29:11] in other news i just misspelled github and landed at a squatter \o/ [05:29:14] okay I'm heading out [05:29:23] jeremyb: ha ha [05:29:46] bye! [06:25:13] preilly: Pong. [06:53:55] jerith: ping [06:54:09] preilly: Pong. [06:54:50] preilly: I can't seem to get to the internet from the labs vumi machine. [06:55:37] I need to set up a dev environment on there for the Tat integration. [06:55:43] *Tata [07:08:27] jerith: what does it do? [07:09:39] jerith@vumi:~$ curl github.com [07:09:39] curl: (7) couldn't connect to host [07:10:31] okay let me check really quick [07:12:33] jerith: can I reboot it? [07:12:46] Sure. [07:13:02] jerith: The system is going down for reboot NOW! [07:19:09] jerith: argh ssh: connect to host vumi port 22: No route to host [07:19:31] ;_; [07:19:41] Ryan_Lane: any reason https://labsconsole.wikimedia.org/w/index.php?title=Special:NovaInstance&action=consoleoutput&project=mobile-sms&instanceid=i-000001e5 would fail? [07:19:57] a 500? [07:20:08] Ryan_Lane: no response [07:20:08] ssh_exchange_identification: Connection closed by remote host [07:20:20] because of an issue with nova right now. or it's one of the corrupted instances [07:20:43] Ryan_Lane: it was working and I rebooted the instance [07:20:58] I'm not sure. [07:21:05] I'm about to go to sleep. can I look at it tomorrow? [07:21:13] Can we get that fixed? I need to use it today. :-/ [07:21:25] Ryan_Lane: jerith needs it working [07:21:30] I think tomorrow will be okay. [07:22:00] Ryan_Lane: okay go to bed [07:22:25] Today would be better, but not if it means you don't sleep. :-) [07:22:34] Ryan_Lane: have you watched episode 8 yet? [07:22:35] it wasn't one of the corrupted ones [07:22:37] not yet [07:22:47] Ryan_Lane: I'm watching it now [07:22:54] Ryan_Lane: it's totally worth watching thus far [07:23:06] Ryan_Lane: I don't think it was one of the corrupted ones [07:23:28] I just checked the email. it isn't [07:23:59] Ryan_Lane: preilly rebooted it because it couldn't see the public internet. [07:24:04] hm [07:24:31] Ryan_Lane: Rebooted instance i-000001e5. [07:24:35] yeah [07:24:45] seems nova-compute was down on virt1 [07:24:51] so the reboot action wasn't taken [07:25:17] * jerith makes coffee. [07:25:17] I just restarted that service [07:25:39] so, when it finished coming up, the reboot should start [07:28:21] Ryan_Lane: nova you mean? [07:28:36] nova-compute, yes [07:29:01] hm. libvirt caused theissue [07:31:36] * Ryan_Lane sighs [07:31:42] and now virt1 is unhappy [07:40:19] Ryan_Lane: what the heck [07:43:40] gm [07:43:42] hm [07:43:53] I wonder why its having network issues [07:44:06] I'm going to migrate it [07:44:42] Ryan_Lane: 07:43:46 [16/100]: url error [timed out] [07:44:42] 07:43:52 [17/100]: url error [timed out] [07:44:43] 07:43:58 [18/100]: url error [timed out] [07:44:46] yeah [07:45:35] Ryan_Lane: what causes that issue? [07:47:49] well, lack of network would do it ;) [07:48:08] let's see if it happens after migration [07:48:30] the metadata service failing would also cause the url issue [07:49:27] stop hitting the console, please [07:49:34] you're pollutting my log view [07:50:19] it's in the middle of migrating [07:50:59] it's up [07:51:12] virt1 is likely just way too overloaded [07:51:30] Ryan_Lane: I haven't clicked it [07:51:37] the instance is up [07:51:55] Ryan_Lane: okay cool [07:51:59] Ryan_Lane: is it all better now [07:52:58] great [07:53:06] ok. i'm going to bed [07:57:16] jerith: so I think we are good to go [07:57:27] jerith: can we get rid of vumi-gw1 [07:58:52] jerith: you there? [08:02:24] preilly: Yes, we can kill vumi-gw1. [08:02:49] jerith: killed [08:03:12] jerith: vimi should be all good now [08:03:37] Yup, it's pulling the repo. [08:03:40] vumi damn autocorrect [08:03:52] jerith: nice [08:37:16] @help [08:37:16] Type @commands for list of commands. This bot is running http://meta.wikimedia.org/wiki/WM-Bot version wikimedia bot v. 1.8.2.4 source code licensed under GPL and located at https://github.com/benapetr/wikimedia-bot [08:37:20] @trusted [08:37:20] I trust: petan!.*@wikimedia/Petrb (2admin), .*@mediawiki/Yuvipandan (2admin), [08:38:15] @configure [08:38:30] @logon [08:38:30] Permission denied [08:43:53] jerith: are you working on the package right now? [08:44:39] preilly: Packaging for Precise is sorted. Everything you need should be in that PPA. [08:45:07] jerith: what is the location of the PPA? [08:47:26] @trusted [08:47:26] I trust: petan!.*@wikimedia/Petrb (2admin), .*@mediawiki/Yuvipandan (2admin), [08:47:43] preilly: https://launchpad.net/~praekeltfoundation/+archive/ppa [08:47:58] @trustadd .*@wikipedia/preilly admin [08:47:58] Successfuly added .*@wikipedia/preilly [08:48:22] preilly: should be done, @whoami will tell you if it worked [08:48:41] We also still need the redis package from https://launchpad.net/~rwky/+archive/redis although we can probably remove the requirement on that if we're not using any reds 2.4 features. [08:48:57] Precise has redis 2.2 which is /probably/ recent enough. [08:53:09] jerith: okay [16:52:36] MaxSem: Erhm, what happened last night with the monuments database? Most of it is gone [16:52:58] multichill, /me didn't touch it:) [16:54:00] mmm, only 205444 rows [16:54:17] * multichill suspects fill_table_monuments_all.sql [16:54:21] Running manual update now [17:00:04] Found it and fixed it. That huge query should be really turned into a script with proper error handling..... [17:07:13] http://www.usatoday.com/news/world/story/2012-07-31/india-power-outage/56600520/1 [17:07:29] [620 million without power in India after 3 power grids fail] [17:09:23] preilly: Was Yuvi affected? [17:09:45] multichill: probably [17:09:50] judging by userlist... [17:09:56] ha ha [17:12:20] is awjr on the air? [17:12:26] s/on/in/ [17:12:38] MaxSem hey no still in the office [17:12:52] lol, I typed while you joined [17:12:57] :) [17:14:11] awjr: are you leaving today? [17:14:17] preilly yep [17:14:22] i'll be in the office til ~5 [17:14:26] awjr: damn [17:18:12] tfinc: https://www.mediawiki.org/wiki/Wiki_Loves_Monuments_mobile_application#Project_timeline [17:23:03] tfinc: how does that look? I want to send it to Matthew [17:24:46] philinje: i'll have to read it later today. on a call right now [17:42:44] awjr: What medium are we using? [17:43:08] multichill: we'll use one of the WMF conference lines for audio only and an etherpad for collaborative notes [17:43:21] No Skype? [17:44:02] for video/audio of a bunch of people in a room, skype/google hang out tends to not work well [17:44:47] Ok. What service are we using? So I can lookup the local number [17:45:00] it's hard to get the audio right. but if we just use a conference line, we can use the fancy conference phone in the meeting room which has much better audio [17:45:12] multichill: the WMF office # - let me get it for you [17:45:35] I'm in the Netherlands, calling a US number isn't very cost effective [17:46:45] awjr: tool server down? http://toolserver.org/~erfgoed/api/api.php?action=search&bbox=-34.453125%2C-38.54816542304656%2C34.453125%2C38.41055825094609&format=json [17:46:49] verrrrry slow [17:48:00] MaxSem, multichill: since both of you are calling internationally, let's try skype or google hangouts instead of the conference line. if the audio is crap, we'll figure something else out [17:48:17] multichill is google hangouts ok with you? i've found the audio/video to generally be better than skype [17:48:29] jdlrobson: yeah… that's exactly why we need to host the API ourselves [17:48:30] jdlrobson: I did run an update, but that's finished now [17:49:14] ah ok [17:49:32] still seems unresponsive multichill [17:50:03] philinje: i took a look at https://www.mediawiki.org/wiki/Wiki_Loves_Monuments_mobile_application#Project_timeline .. beta1 makes sense. i'm going to want awjr to take a look at the schedule relative to our sprints to make sure the team is ok with it [17:50:41] Reedy: UK VPS makes the olympics far easier to watch ;) [17:50:54] I gathered as much :p [17:51:11] yay for the BBCs 24 HD streams [17:52:01] lets see how quickly i eat through my 1TB of transit [17:52:06] tfinc, philinje: i think the timeline is fine - the question is what will actually be in those betas/final. since we have no idea what our actual velocity will be and we do not have estimated stories yet, we can't really know what features will be ready for those betas or even the final release. [17:52:58] awjr: we'll have to flush those out aggresively at the planning meeting [17:53:06] tfinc yes [17:53:27] that is the idea :) [17:53:36] The deadline is a hard deadline so we may have to drop things [17:53:40] jdlrobson yes, that sounds like the toolserver [17:54:13] tfinc: think of the BBCs bills for when they're streaming 50GB/s off their network ;) [17:54:24] * MaxSem 's back [17:54:30] Reedy: i debated for a while between proxy and vpn and then noticed that a socks5 ssh proxy would be cheaper and way more fun to use [17:54:56] yuvipanda: https://commons.wikimedia.org/wiki/File:Wikimania_2012_-_06_-_Mobile_table2.JPG [17:55:11] And did you guys see https://commons.wikimedia.org/wiki/File:Wikimania_2012_-_05_-_Mobile_table1.JPG ? ;-) [17:55:16] multichill: awesome. i'm really glad i brough all those phones [17:55:22] Is yuvipanda a pick pocket? [17:55:38] those are are just some of thesting phones that we keep in the office [17:55:46] if we bring our whole collection then we'd fill the table [17:55:47] ;) [17:55:59] brough* [17:56:02] brought* [17:56:03] :D [17:56:09] You should try taking a suitcase full of phones through airport security as carry on [17:56:15] SFO TSA will love you [17:56:25] funny enough they've never given me shit about it [17:56:26] multichill, MaxSem: https://plus.google.com/hangouts/_/cd44a32fce37d63199513c460b04ab76cf2a96c9?authuser=1&hl=en-US [17:56:28] i'm very happy about this [17:56:50] philinje I updated https://www.mediawiki.org/wiki/Wiki_Loves_Monuments_mobile_application/Marketing [17:57:17] these photos are great. i'm going to add them to some of our mobile pages in the future [18:00:20] multichill, MaxSem: http://etherpad.wikimedia.org/wlm-api-admin-tree [18:18:41] multichill: https://integration.mediawiki.org/WLMMobile/nightly/ [18:22:18] awjr / jdlrobson : Pasted some links in the etherpad to explain the iso codes [18:22:55] thanks multichill [18:27:29] awjr: i dont see a nightly for 7/31 [18:27:43] can you send hashar a note ? [18:28:05] tfinc sure - are those last modified dates utc? [18:28:15] they must be [18:30:06] awjr, I'm 99% done with WLM puppet fixes, but I ran into a stupid permissions issue. Can't tell if it's Apache or FS [18:30:17] MaxSem what's the problem? [18:30:28] http://mobile-wlm.wmflabs.org/api/api.php [18:30:52] the directory/script(s) are not readable by the apache user [18:31:49] perms look normal, 555 on dirs/444 on the file [18:34:19] MaxSem i seem to have lost sudo on mobile-wlm and i do not have permissions to get beyond /var but it looks like /varwww and /var/wlm are owned by root [18:35:33] does it matter if the others have rx on it? [18:36:39] well the wlm directory is only readable by root:wikidev [18:37:04] which won't work for the www-data user [18:37:30] ouch, stupid /me [18:37:44] what happened to your sudo? [18:37:57] i have no idea [18:41:00] hmm, probably puppet stuff [18:42:05] MaxSem looks like you fixed it :) [18:42:43] yup, thanks to you. now trying with puppet [18:47:49] pushed for review [18:54:40] MaxSem just left some comments [18:56:36] bleh, ws [18:56:59] evil evil ws [18:59:17] will fix with the next substaintial commit [19:16:22] jdlrobson: can you pick a branch point for beta1 on WLM? [19:16:41] then i'll pass the signing key to you and the passphrase [19:16:44] so that you can sign [19:16:52] Can I get in one more commit… it's the map stuff [19:17:01] I'm hitting a few issues with leaflet making it take a little longer [19:17:31] jdlrobson: its your shot call about where we branch [19:17:40] we just have to cut it today [19:17:45] and sign it for distro tomorrow [19:18:08] k [19:22:18] server down again :( [19:23:17] * jdlrobson decides to grab lunch [19:37:21] philinje: send me the link to the WLM marketing media. i'll include them within the metrics presentation [19:45:59] ok [19:46:22] https://www.mediawiki.org/wiki/Wiki_Loves_Monuments_mobile_application/Marketing [19:52:00] awjr MaxSem: > http://toolserver.org/~erfgoed/api/api.php?action=search&bbox=-184860%2C-90%2C185220%2C90&format=json [19:52:49] :( [19:52:55] jdlrobson, you attempted to load all the monuments into the memory [19:53:13] i did? [19:53:30] from -90 to +90 degrees [19:53:32] mm whys that happening [19:53:41] ahh i see [19:53:44] philinje: Please put your images on Commons, not on MediaWIki [19:53:49] leaflet is lying to me [19:54:00] there's a bbox-limiting code, but it's disabled on TS [19:54:10] * aude waves [19:54:25] * MaxSem waves to aude [19:54:50] got more time to work on maps and we're working to setup maps + puppet in labs [19:55:17] perhaps not feasible but would be awesome to have our own maps for WLM [19:55:45] Our own maps? What's wrong with OSM? [19:55:58] multichill: our own rendering :) [19:56:21] e.g. not mapquest although mapquest is very nice [19:56:31] Like http://toolserver.org/~erfgoed/map/ ? [19:56:46] (could use some help with that) [19:56:57] multichill: default osm = ugly (sorry!) [19:57:07] it has some issues ;) [19:57:19] * yuvipanda is ye to find someone who doesn't find the default rendering Ugly [19:57:35] multichill, MaxSem: i just checked in some code for the api that allows us to modify the enclosing node-names and gives us a little more flexibility in the API in general - it was easier than i initially thought it would be [19:57:56] * MaxSem looks [19:57:59] like trying to use the default rendering (as a tourist) in israel, but don't read hebrew [19:58:02] good luck! [19:58:07] MaxSem @789 [19:58:13] aha [19:58:15] or china, or any arabic or indic script countries [19:58:21] or cyrillic [19:58:37] wikimedia can fix that much [19:59:56] awjr: Ah, ok, but you still do the level=? and expose the internal id? [20:00:06] awjr, api requests are made through a static call? I guess we don't need to call API internally like in MW but still.. [20:00:07] multichill i'll take care of that in a future commit [20:01:04] ok, splitting this up looks good! [20:01:45] MaxSem: yeah - but we can change that if you think it will be a problem. i figured in this case it would be slightly lower overhead and i couldn't think of a good reason not to do a static call there [20:02:18] awjr, PHP overhead with this DB schema? :P [20:02:28] ;) [20:02:31] like 0.01%:) [20:02:41] Can you also add a "value" and a "lang" field? We need that later on anyway [20:03:36] name="by" value="Wit-Rusland" lang="nl"> something like that [20:03:42] (future future) [20:04:09] multichill there's no languag associated with the admin levels [20:04:14] at least not at the moment [20:04:23] No yet, dummy field for now [20:04:35] multichill we need to keep this as pared down as possible at the moment so we can get it all done in time for the contest [20:04:52] You don't want to show iso codes to end users, right? [20:09:30] yuvipanda: [20:09:32] there? [20:09:40] jdlrobson: [20:09:44] yes sir [20:10:04] awjr ^^ ? [20:10:06] I'm just concerned that if we do manage to get Resource Loader to output RTL css for us then we have to disassemble app.css to remove all the RTL definitions - it just seems easier to swap it out at a future date [20:10:54] (you saw my mail to krinkle and trevor right? [20:11:09] jdlrobson: yes I did. If we get RL to swap, we'll have two versions of app.css [20:11:25] and will need to conditionally load based on UI language [20:11:40] yep Krinkle - i need to reply still as I think there might be some confusion [20:11:51] so having it as two makes no sense, actually - since we'll need conditional loading *anyway* [20:12:11] you need RTL, such as for israel (me thinks) [20:12:21] yuvipanda: we don't know what we'll get - I would personally want an rtl.css which is a diff of app.css and the transformed RTL version [20:13:06] jdlrobson: If I understand correctly RL will just flip certain attributes, leave everything else in place and give it to us [20:13:23] let's see if i can get the app to run... [20:13:41] jdlrobson: so if you want to separate it out, you'll need to seperate both the LTR and RTL versions of the styles in question. [20:13:57] correct yuvipanda but I'm saying it would be nice if there was some way of just extracting just the bits we wanted rather than having 2 large stylesheets… anyway [20:14:07] jdlrobson: I think this 'problem' will go away if we just organized app.css and deal with RTL issues when we actually come across them [20:14:09] anyway it's not a massive deal i just think it might cause us necessary pain in future (albeit not necessarily that much pain) so go ahead and merge I've got bigger fish to fry :p [20:14:19] jdlrobson: we don't know how things will be when we deal with RL, and this is premature optimization [20:14:23] :P [20:14:23] I just wanted to make sure you're aware of my reasoning [20:14:56] indeed - that you want to conditionally load a smaller file than a larger file - makes it easier to keep in your head. Agreed. [20:15:05] but now is not the time to have that discussion :) [20:15:22] jdlrobson: i shall merge now, unless you've objections again [20:15:53] [WikipediaMobile] yuvipanda pushed 6 new commits to master: http://git.io/T4KD5w [20:15:53] [WikipediaMobile/master] Fix Back Forward button directions in RTL languages - YuviPanda [20:15:53] [WikipediaMobile/master] RTL section headers work on the right side - YuviPanda [20:15:53] [WikipediaMobile/master] List item icons show up correctly in RTL languages - YuviPanda [20:16:01] merged! [20:16:02] Project WikipediaMobile - Nightly builds build #365: SUCCESS in 8.4 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/365/ [20:16:03] * yuvipanda: Fix Back Forward button directions in RTL languages [20:16:03] * yuvipanda: RTL section headers work on the right side [20:16:04] * yuvipanda: List item icons show up correctly in RTL languages [20:16:04] * yuvipanda: RTL all the title bars properly [20:16:05] * yuvipanda: Fix spacing + clarify intent of scaleX(-1) [20:20:24] now i head to sleep. [20:20:45] jdlrobson: the photo bit is not complete, i'll be adding more commits. I wanted to open a pull req so you could look at the present ideas as i went along. [20:21:31] yuvipanda: k [20:21:56] i'll take a look.. i'll probably wait till post beta1 before merging [20:23:02] jdlrobson: +1 on that [20:23:33] jdlrobson: note that it'll change internal db structure, so people will have to 'clean install' after beta 1 when this gets merged in. But I think that's okay [20:23:51] yuvipanda: could you look at - https://github.com/wikimedia/WLMMobile/pull/87 [20:23:54] i'd like that in beta1 [20:24:08] looking at it now [20:25:15] code looks fine to me except for one comment :P [20:25:20] testing [20:25:52] aude: the wikipedia app has pretty complete RTL support (thanks in large parts to aamir, who made sure I fixed them all) [20:25:57] WLM, we haven't tested RTL yet :) [20:26:11] yuvipanda: ok [20:26:18] if i can get it to run, sure i can help test [20:26:48] * aude has had some success with iOS testing but not android yet [20:27:13] hang on a minute yuvipanda i think i've found another bug with maps [20:27:21] :( [20:27:38] jdlrobson: is this sans the leaflet 0.4 upgrade? [20:27:54] mm yuvipanda i can't reproduce it again.. but yeh pre leaflet [20:28:51] ok [20:29:21] jdlrobson: we should *Really* have a minimum zoom level at which we will do auto-update of monuments [20:29:28] requesting it for all of asia is a bad idea [20:29:30] + it seems to clear older ones [20:29:33] not good either [20:29:53] +1 yuvipanda [20:29:55] i opened, found some in belgium and 1 in russia. zoomed in, and found them in france only [20:30:26] and no auto update in campaign maps [20:30:31] but this pull req looks good [20:30:33] let me merge [20:30:34] yuvipanda: > https://bugzilla.wikimedia.org/show_bug.cgi?id=38653 [20:31:00] jdlrobson: i wonder if the changing of display to visibility will affect other parts of code [20:31:04] since IIRC .show will no longer work [20:31:48] jdlrobson: why exactly was that changed? [20:32:22] multichill: any idea what's happening with https://bugzilla.wikimedia.org/show_bug.cgi?id=38695 ? [20:33:12] Didn't see that one yet [20:34:50] you can reproduce though? [20:35:48] caxthelm, good news - today was merged my commit from last week that adds pagination and other memory-saving stuff to action=sitematrix [20:36:13] jdlrobson: geo.showMap() is using .show, which I think might break with the switch to visibility? [20:36:21] except in my testing it hasn't, which has left me confused [20:37:11] are we even using that yuvipanda ? [20:37:27] showMap and hideMap don't seem to get used anywhere so we should throw away [20:37:46] i'll add a commit [20:38:14] that's weird, showMap had extra code for the invalidateMap stuff that was needed for the 'shows tiles only in corner' bug [20:40:03] jdlrobson: It looks like the list were updated recently to reflect new listings in the Netherlands. For some reason the description was not included [20:40:44] is there a way we can prevent the api from sending those? [20:41:11] wonderful, thank you [20:42:01] yuvipanda: updated to remove the show and hideMap [20:42:37] weird the pull req isn't updating [20:42:38] according to https://commons.wikimedia.org/w/index.php?title=Commons:Monuments_database/Statistics&oldid=75180167 it's set for 775026 items ((96.75%) [20:43:02] awjr_meeting, speaking of overhead: echo sprintf( '', $this->api->getTopLevelNodeName() ); [20:43:03] jdlrobson: did you push? [20:43:09] Should probalby fix that upstream [20:43:10] yup just now [20:43:28] awjr_meeting, first of all, it can be simplified to printf( '', $this->api->getTopLevelNodeName() ); [20:43:31] sitll not here :( [20:43:38] MaxSem, does the pagination work with a continue and limit? [20:43:54] jdlrobson: but either way, fixing 'effects/affects' and making the comment a bit more explanatory would be good too [20:43:58] feel free to merge after that [20:44:02] yup i'll do that [20:44:05] rest of the code looks good to me! [20:44:06] OuKB you're right [20:44:10] awjr_meeting, or even better, echo "api->getTopLevelNodeName()}>" [20:44:11] i shall head off to sleep now! [20:44:52] OuKB sure that works too [20:44:54] caxthelm, yes, smcontinue=... and smlimit=10 [20:45:24] if( $this->api->getToplevelNodeName() === 'p' ) { echo '

'; } else if( $this->api->getTopLevelNodeName() === 'div' ) { echo ''; } .... [20:45:24] :P [20:45:42] yuvipanda, do that in assembly [20:46:35] OuKB: write code in assembly to generate the jump table assembly? :P [20:46:42] * yuvipanda wants to learn assemybly some day, so he can stop pretending [20:47:01] yuvipanda, it's fun, believe me [20:47:19] OuKB: in the short encounters i've had with it, i tend to agree [20:47:20] OuKB, great Thanks. [20:47:37] but i am not sure if doing it on x86 is fun any more. Need to do arduino / embedded stuff for it to really matter, i guess [20:47:41] unless it is reading disassembly [20:48:30] caxthelm, unfortunately, I can't deploy it into our staging wiki because SiteMatrix is creepy and iit's hard to set it up properly to give 100% right output [20:48:52] sweet dreams yuvipanda [20:50:16] that's ok. any other changes to its usage I should be aware of? [20:51:27] [WLMMobile] jdlrobson pushed 5 new commits to master: http://git.io/gRrdbw [20:51:27]