[00:17:21] awjr: i'm looking at the apk that phil sent me for beta2 [00:17:30] yah [00:17:33] how's it look? [00:17:35] awjr: md5sum 0b5721ee55bf3e6dcf7f9e4de7ecc993 [00:19:57] it failed install on upgrade for me. did you a) sign it and b) increment the version number ? [00:20:12] i didn't do anything to it; brion had prepared it earlier for phil [00:20:24] meaning that it's not properly signed [00:20:38] it has to be redone then [00:20:48] i asked phil about that; he said it was unsigned but that it should be suitable for non-store release [00:21:18] he's wrong. we signed the last one and we should sign this one so that peopel can easily upgrade [00:21:25] makes sense [00:21:36] awjr: can you tag this version per our release instructions [00:21:50] tfinc yeah let me finish what im doing first and i'll take a look [00:22:19] k [00:29:06] tfinc ok looking now [00:29:22] awjr: k. i added one more step to http://www.mediawiki.org/wiki/Wikimedia_Apps/HowToReleaseAnApp that was missing [00:29:38] internet is about to go down here [00:29:59] k [00:30:34] for future releases i'm going to want a noon time cut off for the final build. rushing this at 5:30 is way too late. [00:31:00] * tfinc jots down notes for the next retrospective [00:31:10] yeah and i have a hard-stop at 6 [00:31:55] awjr: if you tag the version and increment the version code i can make the apk [00:32:26] tfinc: i'm down to take a shot at building the apk - it shouldn't take more than 30 mins right? [00:32:42] it looks like the only tag for WLMMobile is v1.1 at the moment, is that right? [00:33:46] awjr: i'd love it if you can take care of all of it. that makes me less of a single point of failure [00:33:48] awjr: correct [00:33:58] so you'll be doing a new tag for 1.1beta2 here [00:34:16] but before you do [00:34:19] increment the version code [00:34:48] arbot_wiki:WLMMobile awjrichards$ git tag v1.1beta2 [00:34:48] arbot_wiki:WLMMobile awjrichards$ git tag [00:34:48] v1.1 [00:34:48] v1.1beta2 [00:35:30] oh [00:35:41] tfinc i can't push to wikimedia/WLMMobile [00:37:27] oh nm i was tyring to push to a read-only url [00:37:31] :| [00:37:44] tfinc ok i pushed v1.1beta2 tag [00:40:02] Were...mobile irc [00:40:08] Wee * [00:40:24] Awjr: see my line about version code? [00:40:40] tfinc yeah, i thought you meant in the tag name itself but now i gather you mean in the app [00:40:46] Well need that before you tag [00:40:53] hmm i need to undo the tag then. [00:41:01] i grep'ed android:versionCode and found three places where it exists in the code... [00:41:03] That's easy [00:41:14] which is the correct place to increment version code? [00:41:23] Android manifest [00:41:26] Top level [00:41:42] package="org.wikipedia.wlm" android:versionName="1.1" android:versionCode="1" android:installLocation="auto"> [00:41:51] Yes [00:41:53] so i increment android:versionCode to 2? [00:42:16] Yes [00:42:58] Version name can stay the same [00:45:01] Awjr: next time let's make a story for just building the release [00:45:04] [WLMMobile] awjrichards pushed 3 new commits to master: http://git.io/jXRvRA [00:45:04] [WLMMobile/master] Adds support for uselang param in API requests for admin zones - Arthur Richards [00:45:04] [WLMMobile/master] Fix formatting in function signatures in monuments.js - Arthur Richards [00:45:04] [WLMMobile/master] Merge branch 'master' of github.com:wikimedia/WLMMobile - Arthur Richards [00:45:12] Project WLMMobile - Nightly builds build #65: SUCCESS in 7.8 sec: https://integration.mediawiki.org/ci/job/WLMMobile%20-%20Nightly%20builds/65/ [00:45:13] * arichards: Adds support for uselang param in API requests for admin zones [00:45:13] * arichards: Fix formatting in function signatures in monuments.js [00:46:07] Now tag , sign, and send me the apk. I'll test upgrade when I have internet [00:48:50] [WLMMobile] awjrichards pushed 1 new commit to master: http://git.io/XD6yxA [00:48:50] [WLMMobile/master] Incrementing androidVersionCode for beta2 release - Arthur Richards [00:48:57] Project WLMMobile - Nightly builds build #66: SUCCESS in 7.4 sec: https://integration.mediawiki.org/ci/job/WLMMobile%20-%20Nightly%20builds/66/ [00:48:57] arichards: Incrementing androidVersionCode for beta2 release [00:50:04] I'm going to go in 10. With office internet then I'm useless [00:50:45] ok just pushed the tag, now im gonna try signing [00:52:12] and i'm back [00:52:12] :D [00:52:21] * flyingclimber goes to update the mw page [00:52:45] flyingclimber: im just double checking the build since i had some git funk [00:53:04] awjr: k [00:53:59] i snuck in support for translated country/subdivision names [00:54:22] ok looks good [00:54:23] so the way that android works is that the cert validates who you are as an app distributor, the android:versionName is what the user sees in manage apps, and android:versionCode is what android uses internall to know what this is the same, older, or newer version [00:54:35] its perfectly normal for android:versionName != android:versionCode [00:54:39] ok cool [00:54:44] now im gonna try signing [00:55:00] thinkof android:versionName as a text string that the os uses to notify the user of a version [00:55:08] yeah makes sense [00:55:37] tfinc should i be doing this in debug mode? [00:56:05] or release? [00:56:09] the reason why we *never* want to widely distribute unsigned apps is that there is *nothing* stopping someone from distributing an app with the exact same package name that completely destroys a users phone [00:56:20] awjr: what do you mean ? [00:56:53] flyingclimber: locally i've been building the app in debug mode. the signing docs have different steps for debug vs. release builds [00:56:57] http://developer.android.com/tools/publishing/app-signing.html [00:57:26] awjr: are you signing in eclipse or a cli ? [00:57:34] cli - i do not have eclipse set up [00:57:57] i have never signed it witha CLI [00:58:26] awjr: do it as a release [00:58:33] im going to guess i should be doing this in release mode since debug mode doesn't ahve instrux for using a private key [00:58:34] yeah [00:59:07] Caution: You cannot release your application to the public when signed with the debug certificate. [00:59:18] we want a release build here [01:01:54] tfinc: jarsigner: Certificate chain not found for: WLMMobile. WLMMobile must reference a valid KeyStore key entry containing a private key and corresponding public key certificate chain. [01:02:39] awjr: did you put in the right pass ? [01:02:45] that sounds like a password error [01:03:17] yeah i've tried a few times with what you gave me the other day [01:04:01] tfinc is there a separate pub key file? [01:04:46] awjr: no [01:05:15] awjr: try this 'keytool -list -v -keystore wmf-android-market.keystore' [01:05:18] and tell me what it says [01:05:28] you should see 'Alias name: google_android_market' [01:06:08] tfinc yah that worked, so that pw is good... [01:06:18] so that tells you that the keystore isfine [01:06:24] something is screwed up in the signing [01:07:06] hmm [01:07:50] are there separate pws for keystore/key? [01:08:19] actually that's a silly question, it's failing after i enter the keystore pw [01:09:17] oh i see, alias_name in the command needs to map to alias_name in the cert [01:09:20] awjr: same pass [01:09:24] one step closer, but still having problems [01:09:29] jarsigner: unable to open jar file: WLMMobile.apk [01:10:34] tfinc what is the filename for the APK usually? [01:10:46] WLM-v1.1betaX.apk [01:14:09] booyah ok i think i figured it out [01:14:48] awjr: woot! [01:15:11] ok now i just need to 'align' it [01:15:26] the real test is to install http://dumps.wikimedia.org/android/WLM-v1.1beta1.apk, then install beta1 ... the upgrade should be seemless [01:15:33] no uninstall required [01:15:36] you have to align it ? [01:16:01] fancy, eclipse takes care of that for me [01:17:38] er ok i think im done... [01:17:55] now what? should i email it to you tfinc? [01:19:59] awjr: mail it to me if your good and i'll put it up on download [01:20:37] oh no wonder sarah is glaring… it's 620 [01:20:46] ok just mailed apk [01:20:57] tfinc ^ [01:21:14] man the android signing docs are a little whack [01:22:44] awjr: 3ae44cef0883a9bb0618b686252f6e38 WLM-v1.1beta2.apk ? [01:22:57] awjr: its super easyin eclipse [01:23:07] awjr: i'll test out the upgrade [01:23:20] thanks [01:23:49] tfinc md5 looks good [01:24:14] now that i know how to do it, it's pretty easy on CLI too.. and i dont have to install eclipse :) [01:26:05] awjr: ill test post dinner [01:26:19] tfinc cool lmk how it goes - i have to run [01:26:24] happy weekend [22:58:49] what should I do with a piece of feedback about android app received on otrs? [22:59:14] do devs check any queue?