[00:10:45] MaxSem: thats good enough for me to pass on [00:10:46] thanks [00:16:57] MaxSem: can you pass me the URL for the wlm api repo? i do not have it on this machine [00:17:18] awjr, SVN? [00:17:23] MaxSem: yep [00:17:48] MaxSem also, the machine i had been using that was having the kernel panics has issues with memory like you suggested. i ran memtest over the weekend and it found, literally, millions of errors [00:17:51] https://svn.toolserver.org/svnroot/p_erfgoed [00:17:54] thanks! [00:28:17] MaxSem: it looks like we are missing language defaults for a lot of countries [00:29:13] by, lu, no, pt, rs [00:30:04] we have 30 countries in the app and only 5 of them are configured with default countries [00:30:08] er [00:30:13] s/default countries/default languages [00:31:41] no is a result of nn/nb dstinction [00:31:53] ? [00:31:59] awjr, I'll take a closer look at it tomorrow [00:32:07] MaxSem: ok no worries [00:33:51] awjr: is https://bugzilla.wikimedia.org/show_bug.cgi?id=38385 done? [00:34:16] kinda sorta [00:34:27] jdlrobson: i'll respond [00:34:32] thanks awjr [00:34:32] thanks for reminding me :) [00:38:38] awjr: also where are api parameters documented? [00:38:50] jdlrobson: i dont think they are atm [00:38:53] i need to know what to use to define an offset for my more button [00:39:01] i know limit limits the entire search [00:39:09] but how can i say give me monuments 50-100 [00:39:16] which action are you using? [00:39:24] i can probably tell you real quick [00:39:34] i have the code open in front of me already [00:40:20] the wlm api documentation right now is not autogenerated, but you can see incomplete (and potentially out-dated) documentation by just hitting api.php with no params [00:41:09] jdlrobson i think it's likely srcontinue [00:41:15] mm ok [00:41:47] but im not sure… this looks a little opaque... [00:44:53] jdlrobson: it looks like srcontinue is expected to be a pipe-delimited list of values, where the values are listed in order corresponding to the order of orderby [00:46:26] which i think if you're using this for monument searches, orderby is just the 'name' field [01:14:34] * tfinc notices that its almost time for climbing [01:19:26] * preilly notices that tfinc notices that it's almost his time for climbing [09:02:07] jerith: ping [09:02:27] preilly: Pong. [11:58:28] Hey, there's a MaxSem in here. [11:59:34] MaxSem: Can you take a look at vumi-wikipedia PR 14 at some point? [12:00:10] I'm not quite finished with the branch yet, but I've rewritten the article extract handling and I'd like your opinion on it. [12:00:40] It's basically the stuff we discussed yesterday or whenever it was. [12:27:25] "You forgot "mobile feedback" which is inundating OTRS with useless clutter. " [13:28:28] thedj, you know if we opened a bug for that? [13:28:36] we should have done one ages ago [13:44:24] ajerith, w00t - looks good however I don't like the name ArticleSectionExtract [13:44:36] what is a 'section extrct'? [13:45:11] MaxSem: It's like an ArticleExtract, except it's just a section of an article. [13:45:31] I don't like the name either. Do you have a better suggestion? [13:45:35] yeah, and not an extract;) [13:45:45] ArticleSection [13:46:03] Works for me. [13:47:42] Renamed. \o/ [13:48:06] So, I do some pretty whitespace stuff for section headings. [13:48:25] But then we flatten all the whitespace later. [13:49:28] I'd like to avoid doing that, but it would mean rewriting the truncation stuff again. :-/ [16:38:40] MaxSem: What namespace is https://ru.wikipedia.org/wiki/%D0%9F%D1%80%D0%BE%D0%B5%D0%BA%D1%82:%D0%A1%D0%B0%D0%BD%D0%BA%D1%82-%D0%9F%D0%B5%D1%82%D0%B5%D1%80%D0%B1%D1%83%D1%80%D0%B3/%D0%92%D0%B8%D0%BA%D0%B8%D0%BF%D0%B5%D0%B4%D0%B8%D1%8F_%D0%BB%D1%8E%D0%B1%D0%B8%D1%82_%D0%9F%D0%B5%D1%82%D0%B5%D1%80%D0%B1%D1%83%D1%80%D0%B3/%D0%9A%D0%B0%D0%BB%D0%B8%D0%BD%D0%B8%D0%BD%D1%81%D0%BA%D0%B8%D0%B9_%D1%80%D0%B0% [16:38:52] Ahum, https://ru.wikipedia.org/w/index.php?title=%D0%A1%D0%BB%D1%83%D0%B6%D0%B5%D0%B1%D0%BD%D0%B0%D1%8F%3A%D0%A1%D1%81%D1%8B%D0%BB%D0%BA%D0%B8+%D1%81%D1%8E%D0%B4%D0%B0&target=%D0%A8%D0%B0%D0%B1%D0%BB%D0%BE%D0%BD%3A%D0%9F%D0%B0%D0%BC%D0%90%D1%80%D1%85+row&namespace= [16:39:39] Is that something like list namespace? [16:43:01] multichill, Проект = Project [16:43:13] Ah, ok [16:43:14] Thank you [16:43:54] but not that generic Project: namespace [16:44:41] Weird Russians :P [16:46:19] So we had Russia in the database, than someone decided to move everything so it dropped out [16:47:03] yeah, that namespace was created recently [16:47:20] Википедия:Проект --> Проект: [16:48:13] Is that all around St. Petersburg MaxSem? [16:48:36] yup [16:49:25] Maybe you can help to add https://en.wikipedia.org/wiki/ISO_3166-2:RU to this? [16:50:23] I'm retired from ruwiki [16:53:00] hmmm, anonymous editing would do:) [16:58:03] multichill, like https://ru.wikipedia.org/w/index.php?diff=47388754&oldid=41682759 ? [16:59:12] If everything is in the same region I add it to the header template and keep it hidden [17:00:21] nope, it's either RU-SPE or RU-LEN [17:28:41] greetings all [17:28:50] hello [18:14:29] sigh tests broken again [18:16:19] my fault :( [18:16:35] awjr: can you merge https://github.com/wikimedia/WLMMobile/pull/141 [18:16:41] jdlrobson: will look shortly [18:16:49] i'll fix the other tests i broke [18:20:54] awjr: also https://github.com/wikimedia/WLMMobile/pull/146 [18:21:35] broken tests are not good [18:21:47] brion: ^ if you can in awjr absence even better [18:21:47] jdlrobson: i'll look when i get to a good stopping point [18:22:02] [WLMMobile] brion pushed 2 new commits to master: http://git.io/E4_yZQ [18:22:02] [WLMMobile/master] limit search results to 50 (bug 39182) - jrobson [18:22:02] [WLMMobile/master] Merge pull request #148 from jdlrobson/limit - Brion Vibber [18:22:03] just looking over pull reqs now :) [18:22:12] awesome [18:22:17] Project WLMMobile - Nightly builds build #71: SUCCESS in 11 sec: https://integration.mediawiki.org/ci/job/WLMMobile%20-%20Nightly%20builds/71/ [18:22:17] jrobson: limit search results to 50 (bug 39182) [18:22:30] [WLMMobile] brion pushed 2 new commits to master: http://git.io/dD56MA [18:22:31] [WLMMobile/master] fix tests broken by 360ba7eee7a51161e5270fd1b622473ec334ce53 - jrobson [18:22:31] [WLMMobile/master] Merge pull request #141 from jdlrobson/testfix - Brion Vibber [18:22:37] Project WLMMobile - Nightly builds build #72: SUCCESS in 7 sec: https://integration.mediawiki.org/ci/job/WLMMobile%20-%20Nightly%20builds/72/ [18:22:38] jrobson: fix tests broken by 360ba7eee7a51161e5270fd1b622473ec334ce53 [18:23:26] [WLMMobile] brion pushed 3 new commits to master: http://git.io/i_2qjg [18:23:26] [WLMMobile/master] Revert "throw away countries which are not described in campaigns-data.js" - jrobson [18:23:26] [WLMMobile/master] exclude monuments with unsupported campaigns from list - jrobson [18:23:26] [WLMMobile/master] Merge pull request #146 from jdlrobson/fix-bad-monuments - Brion Vibber [18:23:32] Project WLMMobile - Nightly builds build #73: SUCCESS in 7 sec: https://integration.mediawiki.org/ci/job/WLMMobile%20-%20Nightly%20builds/73/ [18:23:33] * jrobson: Revert "throw away countries which are not described in campaigns-data.js" [18:23:33] * jrobson: exclude monuments with unsupported campaigns from list [18:26:19] [WLMMobile] jdlrobson pushed 1 new commit to master: http://git.io/XFsF1g [18:26:19] [WLMMobile/master] Add '.jpg' extension to filename explicitly. - Brion Vibber [18:26:27] Project WLMMobile - Nightly builds build #74: SUCCESS in 7 sec: https://integration.mediawiki.org/ci/job/WLMMobile%20-%20Nightly%20builds/74/ [18:26:27] jrobson: Add '.jpg' extension to filename explicitly. [18:27:43] jdlrobson: in https://github.com/wikimedia/WLMMobile/pull/142 is the decodeURIComponent() still necessary on the translated string? [18:27:51] * jdlrobson looks [18:28:03] yes because this is to do with page history [18:28:05] which encodes it [18:28:12] ah i see [18:28:36] pagename/sub%2Fpage/page3 [18:28:47] ^^ that's what it's protecting against [18:29:03] [WLMMobile] brion pushed 2 new commits to master: http://git.io/vDXc5w [18:29:03] [WLMMobile/master] translate headings for admin tree levels - jrobson [18:29:03] [WLMMobile/master] Merge pull request #142 from jdlrobson/translate-regions - Brion Vibber [18:29:11] Project WLMMobile - Nightly builds build #75: SUCCESS in 7.3 sec: https://integration.mediawiki.org/ci/job/WLMMobile%20-%20Nightly%20builds/75/ [18:29:11] jrobson: translate headings for admin tree levels [18:30:29] [WLMMobile] brion pushed 2 new commits to master: http://git.io/Z0y_vA [18:30:29] [WLMMobile/master] separate sort header from sort buttons (bug 39313) - jrobson [18:30:29] [WLMMobile/master] Merge pull request #147 from jdlrobson/39313 - Brion Vibber [18:30:37] Project WLMMobile - Nightly builds build #76: SUCCESS in 7.1 sec: https://integration.mediawiki.org/ci/job/WLMMobile%20-%20Nightly%20builds/76/ [18:30:37] jrobson: separate sort header from sort buttons (bug 39313) [18:33:33] jdlrobson: anything further on https://github.com/wikimedia/WLMMobile/pull/124 needing tweaking? I reverted the usage of the tool server api point and did a whitespace tweak [18:33:46] there might be other queries where the uselang isn't getting through, i just don't know about them yet ;) [18:35:03] well.. there's an unrelated whitespace change - https://github.com/wikimedia/WLMMobile/pull/124/files#L1L6 - I could ignore this this time but as yuvipanda will tell you i'm fussy about dirty diffs ;-) [18:35:13] :D [18:36:19] added a commit to remove that stray tab :) [18:36:22] brion: re https://github.com/wikimedia/WLMMobile/pull/124 - is adding the lang parameter to the MonumentsApi function all that is necessary for getting lang -specific monuments? [18:36:52] awjr: uselang parameter, and that's what MaxSem told me :) [18:37:07] though last i heard it might not be implemented on all queries [18:37:27] eeeenteresting [18:37:37] brion, it is now [18:37:56] unless our QA proves me wrong:P [18:37:57] \o/ yay [18:37:59] hehe [18:39:40] ajerith: welcome back [18:39:58] Ah, preilly. [18:41:04] brion: can you rebase? [18:41:17] preferably into 1 single commit [18:44:00] working on it [18:44:12] fun merge conflicts :D [18:44:55] jdlrobson: how can i view the headers of a network request in safari's developer tools? i can see a list of network requests that were made and i can see the results of the network requests, but i cannot figure out how to view the headers :( [18:45:11] select one [18:45:16] you get headers and content tab [18:45:34] all i am seeing is content [18:45:52] awjr, why are Canadian ISO province names are available only in English? [18:46:10] MaxSem: eh? [18:46:50] awjr, CA-* are present only in SubdivisionsEn.php [18:47:06] oh jdlrobson i think i found it in a rather roundabout way [18:47:31] MaxSem: i presume the translating script did not find any translations [18:49:11] ok something ain't right [18:49:13] http://wlm.wikimedia.org/api/api.php?action=search&bbox=-122.43061065673827,37.751579570617366,-122.36881256103514,37.82198884575637&limit=50&uselang=en [18:49:18] uselang needs a country code [18:50:04] MaxSem: are there only limited places where i should be using uselang? [18:51:36] brion, basically if no adm0 is provided we have no way to determine the language fallback chain [18:51:49] hmm [18:52:04] so someone with Chinese UI in Europe will keeep getting no monuments [18:52:25] in a case like what brion showed, can ew determine the country from the lat/long? [18:52:35] MaxSem: so I should only pass uselang with MonumentsApi.getForAdminLevel()? [18:53:19] awjr, geonames has such service, but making another request will suck [18:53:42] MaxSem: can ew determine it from monuments that get returned for that query? [18:53:48] brion, ideally it should be used everywhere. sigh, I guess it needs a bit of rethinking [18:58:11] ok rebased version at https://github.com/wikimedia/WLMMobile/pull/150 but it's not ready just yet until we work out what to do [18:58:39] awjr: preilly MaxSem : are we deploying anything today? [18:58:47] * tfinc assumes we are not [18:58:55] tfinc: I did it last night [18:59:05] tfinc: I still need to update the deployment page [18:59:10] tfinc not that i am aware of unless preilly has stuff to push [18:59:11] oh [19:02:43] k [19:04:23] http://www.mediawiki.org/wiki/Extension:MobileFrontend/Deployments/2012-08-20 [19:04:30] I still need to fix the formatting [19:23:53] multichill: https://bugzilla.wikimedia.org/show_bug.cgi?id=39476 < is this a data issue? [19:24:46] * multichill looks [19:25:34] jdlrobson: SELECT COUNT(*) FROM monuments_all WHERE lat=0 AND lon=0; gives 136 items [19:25:45] :( [19:25:59] are we able to enrich this data in any wy [19:26:12] Total is 845081, so that's just a drop [19:26:44] if the api could not include longitude and latitude when they don't exist that would be useful on the client side [19:28:13] Oh, right, let's see how you get that back [19:29:21] aaargh [19:32:14] jdlrobson: See bug update [19:32:34] thanks [19:36:24] brion: Would be nice if you could fix https://bugzilla.wikimedia.org/show_bug.cgi?id=39540 ;-) [19:37:12] multichill: got the link to the api source handy? [19:37:47] https://fisheye.toolserver.org/browse/erfgoed/api [19:38:18] Or https://svn.toolserver.org/svnroot/p_erfgoed/api if you want to do a checkout [19:38:55] hey, I'm the API guy:) [19:39:31] yeah i'll leave that to MaxSem i'm not sure which bit to poke :D [19:40:04] brion: app.js is getting quite complicated.. think we need to refactor it? :( [19:40:37] brion: https://fisheye.toolserver.org/browse/erfgoed/api/includes/FormatJson.php?hb=true ? [19:40:40] jdlrobson: hmm, possibly [19:40:45] multichill, though the bot sets a lot of fields to empty string while they should be NULL [19:40:56] brion: at least we might consider introducing a ui.js file [19:41:03] that separates the ui components [19:41:12] multichill, MaxSem - yeah in outputRow() there is a (float) cast on lat and lon [19:41:17] that should check for null first [19:41:47] MaxSem: Sure? I only get 136 hits on that [19:42:14] ( SELECT COUNT(*) FROM monuments_all WHERE lat='' AND lon=''; ) [19:42:43] someone should anchor a buoy at coordinates (0,0) and declare it a monument, then we'd have to deal with it for sure ;) [19:42:43] SELECT COUNT(*) FROM monuments_all WHERE lat IS NULL AND lon IS NULL; returns 260317 [19:42:52] multichill, I meant other fileds [19:42:57] eg select * from monuments_all where adm1='' [19:43:17] Oh, right, yes [19:48:40] brion: is this still relevant? https://bugzilla.wikimedia.org/show_bug.cgi?id=38283 [19:49:06] sounds like that's done now [19:49:08] closing it out.. [20:01:54] [WLMMobile] brion pushed 2 new commits to master: http://git.io/J91k2A [20:01:54] [WLMMobile/master] remove broken link to 'country page' (bug 39249) - jrobson [20:01:54] [WLMMobile/master] Merge pull request #151 from jdlrobson/39249 - Brion Vibber [20:02:03] Project WLMMobile - Nightly builds build #77: SUCCESS in 7.7 sec: https://integration.mediawiki.org/ci/job/WLMMobile%20-%20Nightly%20builds/77/ [20:02:03] jrobson: remove broken link to 'country page' (bug 39249) [20:02:22] multichill, so should I just omit lat/lon then? [20:02:45] No, should be null [20:08:23] done [20:24:41] [WLMMobile] brion pushed 3 new commits to master: http://git.io/5euKrw [20:24:41] [WLMMobile/master] revert damage done to qqq message in 2cf98f78 - jrobson [20:24:41] [WLMMobile/master] separate urls for wiki loves monuments and wikipedia in about page text (bug 38981) - jrobson [20:24:41] [WLMMobile/master] Merge pull request #152 from jdlrobson/translationstuff - Brion Vibber [20:24:48] Project WLMMobile - Nightly builds build #78: SUCCESS in 7.1 sec: https://integration.mediawiki.org/ci/job/WLMMobile%20-%20Nightly%20builds/78/ [20:24:49] * jrobson: revert damage done to qqq message in 2cf98f78 [20:24:49] * jrobson: separate urls for wiki loves monuments and wikipedia in about page text (bug 38981) [20:25:33] found a bug in the api [20:26:26] http://wlm.wikimedia.org/api/api.php?action=search&limit=50&sradm0=be&sradm1=be-vlg&srname=~br*&format=json srcontinue is returned url encoded [20:26:29] i don't think it should be [20:26:43] it's creating double encoding issues for me (MaxSem awjr_mtg multichill ) [20:27:57] * jdlrobson goes for lunch [20:28:09] multichill, are there any tools that will be broken by the removal of urlencode there? [20:29:28] I'm not sure why it's urlencode, probably so that the client doesn't have to do that [20:29:36] You probably want to check with Platonides [20:31:04] Platonides, ^^ [20:36:27] [WLMMobile] jdlrobson pushed 2 new commits to master: http://git.io/6cvnVQ [20:36:27] [WLMMobile/master] include uselang parameter with Monuments API searches - Brion Vibber [20:36:28] [WLMMobile/master] Merge remote-tracking branch 'brion/lang-query2' into tt - jrobson [20:36:34] Project WLMMobile - Nightly builds build #79: SUCCESS in 7.2 sec: https://integration.mediawiki.org/ci/job/WLMMobile%20-%20Nightly%20builds/79/ [20:36:35] Brion VIBBER: include uselang parameter with Monuments API searches [20:36:47] eek merge commits [21:44:34] brion, the uselang error should be resolved [21:44:45] \o/ [21:44:46] MaxSem: did jdlrobson get that stuff implemented in the app for address searching? [21:44:47] awesome thx [21:45:25] awjr: i've done nothing [21:45:27] awjr, I've just merged and deployed it - now he can [21:45:35] jdlrobson, ^^ [21:45:35] excellent [21:45:43] MaxSem: what's the url for the commit? [21:45:55] will do that now before i forget [21:46:06] ah cool thanks [21:46:17] https://gerrit.wikimedia.org/r/#/c/20822/ [21:46:27] thanks MaxSem [21:46:50] do you remember what to do? [21:47:39] MaxSem: also iirc you asked me to review some code yesterday that i never got around to looking at. do you still need me to look? [21:47:51] jdlrobson, just s/srname/srquery/ and s/~// [21:47:54] MaxSem: srquery instead or surname ? [21:47:56] srname [21:48:00] (damn you autocorrect) [21:48:44] awjr, I had to merge it myself because the app needed it. post merge review will also be appreciated [21:48:57] MaxSem: no worries [21:49:16] i can diff head against my last update from yeterday [21:51:08] MaxSem: https://github.com/wikimedia/WLMMobile/pull/154 [21:51:11] that look good? [21:52:06] jdlrobson, yes [21:52:24] sweet [21:53:24] jdlrobson, though the use of the * symbol may need revisiting as it currently applies only to the last word in search query [22:01:46] MaxSem: i think the api changes look OK - am i reading correctly that in the event we don't have a language or a fallback, it won't bother filtering on language? [22:01:56] which i assume fixes the nearby search issue? [22:02:52] yes, the lack of uselang signifies backwards-compatible behaviour of outputting everything [22:03:26] MaxSem: i guess the only problem with that is that we might get duplicate monuments for multi-lingual campaigns, right? [22:03:59] no, the app should always provide uselang now [22:04:30] oh, sorry, i misunderstood - that was for b/c? [22:04:38] yes [22:04:42] ok cool makes sense [22:06:32] hmm [22:06:47] where do translations/human-readable versions of administrative zones come from? [22:06:54] like 'us' -> 'United States'? [22:07:09] adm0 translations from extension:CLDR [22:07:19] according to https://mingle.corp.wikimedia.org/projects/wlm_android_app/cards/138 i should be showing the administrative zones in the uploaded items list [22:07:22] adm1-2 from awjr's code [22:07:29] and i'm not sure i've got any way to look them up [22:07:37] i just seem to have the data in the monument record which is the short codes [22:08:06] brion, use action=admintree [22:08:23] that is probably the only way to currently get translated admin level names [22:09:01] hmm but it would require multiple api calls [22:09:01] http://wlm.wikimedia.org/api/api.php shows no help for action=admintree [22:09:07] yeah... [22:09:13] it isn't documented yet [22:09:16] heh [22:09:24] the api documentation isn't automagically generated unfortunately, so it's wayyy out of date [22:10:11] action=admintree&admtree=||… etc [22:10:26] admtree expects a pipe delimited list of admin levels, starting with adm0 [22:10:32] it must always start with adm0 [22:10:37] and go in heirarchical order [22:11:03] what you get back is a list of children, generally with human-readable names (except for in a few cases), and translated if possible [22:11:10] http://wlm.wikimedia.org/api/api.php?action=admintree&admtree=us just shows me the help page [22:11:24] derp [22:11:37] http://wlm.wikimedia.org/api/api.php?action=adminlevels&admtree=us [22:11:38] brion ^ [22:11:44] there we go :D [22:12:20] unfortunately that gives me children of what i asked for, not what i asked for :( [22:12:23] i feel like that's kind of a convoluted way to achieve what you want though [22:12:24] yeah [22:12:25] exactly [22:12:48] http://wlm.wikimedia.org/api/api.php?action=adminlevels will give you top-level admin zones [22:13:11] but still, you'd have to implement some annoying stuff int he app in order to get what you're looking for using that [22:13:23] yeah [22:13:24] it might be worth adding an api function [22:13:29] probably yeah [22:13:49] biron have you seen the api code yet? [22:13:55] or know where to check it out from? [22:14:04] i've got a svn checkout [22:14:07] groovy [22:14:22] you'll probably want to add a new api function in api/includes/ApiAdminTree.php [22:14:55] there are similarities to MW's API but also some quirks and peculiarities unique to this api implementation [22:16:11] brion, do you want to do it yourself? [22:16:29] MaxSem: nah you'll know better now to implement it in there probably [22:16:33] i'll just hurt myself ;) [22:16:39] exactly [22:16:42] hehehe [22:16:42] hehe [22:16:48] MaxSem: do you have spare cycles? [22:16:49] get back you your app [22:17:02] awjr, whaddaya want? [22:17:32] MaxSem: oh, i mean, if you have spare cycles to work on brion's api changes [22:17:42] yes I do [22:17:44] otherwise i might be able to shuffle some of my stuff around and take a stab [22:17:46] ok cool [22:17:55] MaxSem: i'll want to be able to ask for a tree (say "us|us-ca|[[San Francisco County, California]]") and get back the admin_level record with name and translation for each level [22:18:07] yup [22:18:11] awesome [22:18:20] i'll go untranslated for now and use that when it's available :D [22:28:32] awjr: i'm confused [22:28:38] :( [22:28:43] https://mingle.corp.wikimedia.org/projects/wlm_android_app/cards/129 is in ready for development but i'm pretty sure i did this last iteration [22:29:10] jdlrobson: not sure, it's possible it never got moved to ready for review [22:29:20] also is this complete now - https://mingle.corp.wikimedia.org/projects/wlm_android_app/cards/165 [22:29:25] i'm trying to find new work [22:29:31] and the fact it is not up to date is just confusing me [22:29:58] jdlrobson: im looking at the history for #129 and it never got moved out of 'ready for development' [22:30:07] mm [22:30:10] something strange at play here [22:30:14] shall i move it now? [22:30:17] yes please [22:30:29] jdlrobson: it will likely be easeier to change the status in the card itself [22:30:38] otherwise you'll have to move the card one lane at a time which is tedious [22:31:14] [WLMMobile] brion pushed 2 new commits to master: http://git.io/LiDG1w [22:31:14] [WLMMobile/master] apply heather's new shiny icons - jrobson [22:31:14] [WLMMobile/master] Merge pull request #155 from jdlrobson/sexyicons - Brion Vibber [22:31:23] Project WLMMobile - Nightly builds build #80: SUCCESS in 7.9 sec: https://integration.mediawiki.org/ci/job/WLMMobile%20-%20Nightly%20builds/80/ [22:31:24] jrobson: apply heather's new shiny icons [22:31:25] jdlrobson: as for 165, it also was not moved out of 'ready for development' during this iteration. so whoever was fixing it, should have moved the card [22:31:36] jdlrobson: please move to ready for review as well if it is indeed done [22:31:44] :( [22:31:52] i don't know if it is done [22:31:55] MaxSem: is it done? [22:32:30] jdlrobson: i moved 165 back to ready for dev for this iteration because there were issues with it after the previous iteration [22:32:44] ah ok [22:32:47] language support for monument searching had not been implemented [22:32:54] but someone should have moved it back into development [22:33:03] yup [22:33:15] that is, if someone has been working on it :) [22:33:31] shall i move it to in development? [22:33:38] or ready for review? [22:33:39] jdlrobson: are you working on it? [22:33:42] is anyone working on it? [22:33:50] well i sent a fix on the client side [22:34:04] oh, then is it done now? [22:34:10] i assume https://github.com/wikimedia/WLMMobile/pull/154 [22:34:16] is what it is referring to? [22:35:23] i think this is highlighting something that has been bugging me which is that some of these cards tend to have multiple people working on different tasks to fulfill the card [22:35:51] but the tasks and who's working on them aren't captured anywhere, so the story goes into this weird limbo state where it's unclear whether or not the work for it is totally done [22:35:53] [WLMMobile] brion pushed 2 new commits to master: http://git.io/VQUQyA [22:35:53] [WLMMobile/master] allow user via back button to escape blacklisted pages (bug 39348) - jrobson [22:35:53] [WLMMobile/master] Merge pull request #156 from jdlrobson/backfromblacklistedpages - Brion Vibber [22:35:56] brion, do you need these translations in country's default language? [22:36:00] Project WLMMobile - Nightly builds build #81: SUCCESS in 6.9 sec: https://integration.mediawiki.org/ci/job/WLMMobile%20-%20Nightly%20builds/81/ [22:36:01] jrobson: allow user via back button to escape blacklisted pages (bug 39348) [22:37:36] jdlrobson i think that card is actually done as of https://github.com/wikimedia/WLMMobile/pull/150 [22:37:56] that was the missing piece. i'll put it in in-review [22:38:03] MaxSem: probably in whatever ?uselang language if possible? [22:38:11] what do we give back on the admin levels? [22:38:25] er rather ready for review [22:38:27] based on uselang [22:38:34] okay, got it [22:39:35] is srquery support deployed? i'm testing https://github.com/wikimedia/WLMMobile/pull/154 and i get no results back [22:41:22] brion, http://wlm.wikimedia.org/api/api.php?action=search&srquery=house* [22:41:45] ok it was failing because i'd done a distance search and something broke [22:41:55] if i don't do a nearby lookup, it seems to be working…… [22:42:00] but seems inconsistent [22:42:54] in the first Andorra blob, searching for "mass" shows up "Casa Massip-Dolsa (Andorra la Vella)" but searching "mer" doesn't turn it up even though its address is "Av. Meritxell, 22" [22:44:06] waitaminute that didn't use srquery [22:44:17] i've got the wrong one checked out ;) [22:44:41] yeah, we're slowly going insane with this stuff:P [22:44:57] http://wlm.wikimedia.org/api/api.php?action=search&sradm0=ad&sradm1=ad-07&srquery=mer* works ok good [22:45:43] ok merging [22:45:52] [WLMMobile] brion pushed 2 new commits to master: http://git.io/7RQ2OQ [22:45:52] [WLMMobile/master] search address as well as name - jrobson [22:45:52] [WLMMobile/master] Merge pull request #154 from jdlrobson/fulltextsearch - Brion Vibber [22:46:01]