[09:56:04] <GitHub129>	 [WLMMobile] siebrand pushed 1 new commit to master: http://git.io/Ikxb7w
[09:56:04] <GitHub129>	 [WLMMobile/master] Localisation updates from http://translatewiki.net. - Siebrand Mazeland
[09:56:15] <mw-jenkinsbot>	 Project WLMMobile - Nightly builds build #129: SUCCESS in 8.3 sec: https://integration.mediawiki.org/ci/job/WLMMobile%20-%20Nightly%20builds/129/
[09:56:15] <mw-jenkinsbot>	 s.mazeland: Localisation updates from http://translatewiki.net.
[09:57:18] <wikipedia-github>	 [WikipediaMobile] siebrand pushed 1 new commit to master: http://git.io/OS4T3w
[09:57:18] <wikipedia-github>	 [WikipediaMobile/master] Localisation updates from http://translatewiki.net. - Siebrand Mazeland
[09:57:38] <mw-jenkinsbot>	 Project WikipediaMobile - Nightly builds build #373: SUCCESS in 12 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/373/
[09:57:39] <mw-jenkinsbot>	 s.mazeland: Localisation updates from http://translatewiki.net.
[14:23:48] <GitHub57>	 [WLMMobile] brion created bug39571 (+2 new commits): http://git.io/GuadyA
[14:23:48] <GitHub57>	 [WLMMobile/bug39571] Bug 39571: truncate long filenames - Brion Vibber
[14:23:48] <GitHub57>	 [WLMMobile/bug39571] Switch date format in filenames to YYYY-MM-DD - Brion Vibber
[14:24:09] <mw-jenkinsbot>	 Project WLMMobile - Nightly builds build #130: SUCCESS in 14 sec: https://integration.mediawiki.org/ci/job/WLMMobile%20-%20Nightly%20builds/130/
[15:58:30] <GitHub168>	 [WLMMobile] jdlrobson pushed 1 new commit to master: http://git.io/7571hQ
[15:58:30] <GitHub168>	 [WLMMobile/master] Bug 39691: force async loading of thumbs on incomplete screen - Brion Vibber
[15:58:38] <mw-jenkinsbot>	 Project WLMMobile - Nightly builds build #131: SUCCESS in 6.7 sec: https://integration.mediawiki.org/ci/job/WLMMobile%20-%20Nightly%20builds/131/
[15:58:38] <mw-jenkinsbot>	 jdlrobson: Bug 39691: force async loading of thumbs on incomplete screen
[16:08:34] <GitHub168>	 [WLMMobile] jdlrobson pushed 2 new commits to master: http://git.io/DKrZbw
[16:08:34] <GitHub168>	 [WLMMobile/master] Bug 38290 partial: save newly taken photos to photo gallery - Brion Vibber
[16:08:34] <GitHub168>	 [WLMMobile/master] Merge pull request #194 from brion/bug38290 - Jon Robson
[16:08:40] <mw-jenkinsbot>	 Project WLMMobile - Nightly builds build #132: SUCCESS in 6.7 sec: https://integration.mediawiki.org/ci/job/WLMMobile%20-%20Nightly%20builds/132/
[16:08:41] <mw-jenkinsbot>	 Brion VIBBER: Bug 38290 partial: save newly taken photos to photo gallery
[16:35:11] <GitHub159>	 [WLMMobile] jdlrobson pushed 1 new commit to master: http://git.io/gpolIQ
[16:35:11] <GitHub159>	 [WLMMobile/master] update fixtures for 2012e40b - jdlrobson
[16:35:18] <mw-jenkinsbot>	 Project WLMMobile - Nightly builds build #133: SUCCESS in 6.6 sec: https://integration.mediawiki.org/ci/job/WLMMobile%20-%20Nightly%20builds/133/
[16:35:19] <mw-jenkinsbot>	 jdlrobson: update fixtures for 2012e40b
[16:48:59] * awjr  waves

[16:55:35] <awjr>	 MaxSem: how's it going?
[16:55:54] <MaxSem>	 awjr, hi
[17:01:46] <MaxSem>	 okay, we've got logging ready for review: https://gerrit.wikimedia.org/r/21748 + https://gerrit.wikimedia.org/r/21753
[17:23:01] <awjr>	 yay MaxSem!
[17:23:06] <awjr>	 i can take a look in a bit
[17:28:29] <sumanah>	 multichill: is there a test plan somewhere for the WLM Android app?
[17:29:16] <MaxSem>	 sumanah, grab a bunch of humans, make them walk through SF making photos of live monuments
[17:29:24] <sumanah>	 so, no
[17:30:11] <MaxSem>	 awjr, I took #200
[17:30:49] <multichill>	 Hi guys, I added the big banner to https://www.mediawiki.org/wiki/Wiki_Loves_Monuments_mobile_application because it's the first hit when you look for "Wiki Loves Monuments mobile app" on Google
[17:31:14] <awjr_lostwallet>	 awesome MaxSem - sorry gotta run, i lost my wallet this am but i think someone found it
[17:31:19] <awjr_lostwallet>	 back shortly
[17:33:27] <sumanah>	 of course it might be not really useful at this date to encourage more testing of the app, in which case, ignore me :)
[17:35:56] <multichill>	 tfinc and other mobile people. Small tweak in the output. Now it's "[[user:<username>]]", could you change this to "[[user:<username>|<username>]]"?
[17:36:55] <multichill>	 Bigger tweak: Don't we know the coordinates of where the photo was taken? We should add that.
[17:38:49] <tfinc>	 multichill: context ?
[17:39:02] <awjr>	 sumanah: we've been testing the app fairly aggressively internally as well as within the WLM community
[17:39:16] <sumanah>	 right, yeah, I heard about that from Tomasz
[17:39:18] <multichill>	 https://commons.wikimedia.org/wiki/File:San_Francisco_Fire_Department_Engine_Co-_Number_2_%28taken_on_27Aug2012_13hrs44mins0secs%29.jpg or https://commons.wikimedia.org/wiki/Category:Uploaded_with_Android_WLM_App
[17:39:33] <sumanah>	 I wanted to check whether it would make sense to make one more push to get tests from another perspective, awjr
[17:40:05] <awjr>	 sumanah the last couple of betas have been announced over a variety of mailing lists strictly for functional testing, plus we've pushed out something more akin to a release candidate that actually uploads to commons.
[17:40:12] <awjr>	 i haven't seen an anouncement come out about it yet
[17:40:22] <awjr>	 but i suspect phil will be anouncing it today internally and to the WLM folks
[17:40:26] <multichill>	 Time for food, bbl
[17:40:49] <tfinc>	 awjr: phil will be sending(if he hasn't already) to the wlm lists
[17:40:57] <awjr>	 sumanah if you have other ideas for testing you should talk to phil - i'm not sure he'll be around consistently today, but send him an email
[17:41:00] <tfinc>	 sumanah: what context are you thinking about here ?
[17:41:03] <awjr>	 tfinc ok yeah, i hadn't seen an email go out yet
[17:41:20] <tfinc>	 awjr: i talked to him yesterday when he was preparing an email to the wlm lists
[17:41:28] <awjr>	 groovy
[17:41:47] <tfinc>	 i'm going to do one for staff today
[17:41:58] <tfinc>	 referencing the photos we took yesterday to get even more involvement
[17:42:09] <tfinc>	 awjr: did we hear back from brion ?
[17:42:14] <tfinc>	 lovely photo by sage http://commons.wikimedia.org/wiki/File:Cathedral_of_Learning_(taken_on_27Aug2012_20hrs34mins37secs).jpg
[17:43:04] <awjr>	 tfinc: in regards to what specifically? he sent out a few emails before this AM and has made a bunch of bugzilla comments - it looks like he's just about done with the two blocking issues we asked him to work on :)
[17:43:24] <sumanah>	 awjr: thanks, I'll do that.  tfinc -- I have a few folks I've groomed who like to test & file bug reports, and have been trying to feed them well-specified "please test foo and bar in this app/feature" requests every so often
[17:43:25] <awjr>	 that is a gorgeous pic
[17:43:27] <tfinc>	 that answers my question. i wanted to know if he could pick up the blocking issues. which is a clear yes
[17:43:34] <tfinc>	 go brion!
[17:43:37] <awjr>	 :)
[17:44:02] <tfinc>	 very interesting discussion with erik on the field testing thread
[17:46:56] <awjr>	 \o/ common data hub fixed the data issues i raised with them (missing iso-3166-2 data for malta, and not including sctoland/wales/england/norther ireland in iso-3166-2 data)
[17:47:19] <jdlrobson>	 awjr: some of the mingle stories are not sized but in ready for development
[17:47:23] <jdlrobson>	 they should be in ready for analysis
[17:47:39] <jdlrobson>	 i'm very confused with the state of mingle right now
[17:47:49] <awjr>	 jdlrobson: yeah, none of the new cards are sized
[17:48:02] <awjr>	 most of them are bugs and should not be estimated anyway
[17:48:07] <jdlrobson>	 yeh bugs are fine
[17:48:15] <jdlrobson>	 but it's all a bit of a mess :)
[17:48:49] <awjr>	 im ambivalent about the enhancements though. phil has prioritized a few fairly high, i do not think we have the time to fully estimate/flush them out if they need to be in the release thursday
[17:48:58] <awjr>	 jdlrobson: what in particular is bugging you?
[17:49:18] <jdlrobson>	 i'm just very lost at what i should do
[17:49:26] <jdlrobson>	 some stuff is done
[17:49:42] <jdlrobson>	 the bug number in the titles would be useful
[17:49:42] <awjr>	 jdlrobson: yeah, people have not been moving their cards
[17:49:55] <jdlrobson>	 as i have to work out what the story is about
[17:50:00] <awjr>	 they should all contain a link to the bug in the card
[17:50:03] <jdlrobson>	 is the order correct?
[17:50:14] <awjr>	 jdlrobson: yes that much is certain :)
[17:50:19] <tfinc>	 awjr: jdlrobson: MaxSem preilly: heads up that we have a very strong candidate in the running for our open front end role. jon talked to him and really liked him. this candidate has already done a loop with another team here so i'm not looking at doing a full long loop. i'm thinking one more with two of us and sue. who wants in? i'm thinking awjr .. anyone else want in? right now i have awjr and a designer
[17:50:21] <awjr>	 phil confirmed with me last night that he'd ordered the cards
[17:50:26] <jdlrobson>	 i'd prefer in ready for analysis as size is helpful
[17:50:46] <awjr>	 tfinc thanks - sangeeta already pinged me about it and scheduled me for a 30 minute chat with him friday morning
[17:51:01] <awjr>	 jdlrobson: we should not be sizing the bugs
[17:51:28] <tfinc>	 jon came back to me and said "hire this guy" which rarely happens :D
[17:51:33] <awjr>	 awesome :)
[17:51:36] <jdlrobson>	 well i mean right now I'm looking for a 1-3 sized card for before lunch
[17:51:47] <jdlrobson>	 the bugs are adding noise
[17:51:59] <jdlrobson>	 (i'm now actually resorting to bugzilla)
[17:52:18] <MaxSem>	 tfinc, I'm not sure if I can torture a frontend candidate properly:P
[17:52:19] <jdlrobson>	 i mean.. the show my current location thing should probably be sized
[17:52:37] <jdlrobson>	 MaxSem: it sounds like he's been pretty well tortured so far
[17:52:52] <MaxSem>	 heh
[17:53:10] <tfinc>	 MaxSem: then dont worry about it. awjr will do enough. awjr: sync up with jon to make sure you don't overlap on questions
[17:53:11] <jdlrobson>	 tfinc awjr: do we know if we need RTL css support yet?
[17:53:49] <awjr>	 jdlrobson: phil has decided to keep it fairly low priority
[17:53:54] <jdlrobson>	 k
[17:54:13] <jdlrobson>	 awjr: shall i just move stuff to in development/in analysis even if other people have done it?
[17:54:55] <awjr>	 jdlrobson: do not move anything into in analysis; if you know for sure someone is working on a card, feel free to move it to 'in development' and assign it to them - but also ping them to let them know you did that
[17:55:03] <jdlrobson>	 k
[17:55:35] <awjr>	 like i know that brion is for sure working on #190
[17:55:58] <jdlrobson>	 i can't set owner
[17:56:03] <jdlrobson>	 https://mingle.corp.wikimedia.org/projects/wlm_android_app/cards/193/edit?coming_from_version=9 is brion
[17:56:18] <jdlrobson>	 likewise with 190
[17:56:25] <awjr>	 ok im updating the owner
[17:56:50] <jdlrobson>	 https://mingle.corp.wikimedia.org/projects/wlm_android_app/cards/206 < is not clear awjr
[17:57:03] <jdlrobson>	 it makes no sense
[17:57:06] <awjr>	 no it isn't :(
[17:57:08] <jdlrobson>	 can i move that back to analysis
[17:57:31] <awjr>	 yes
[17:57:33] <jdlrobson>	 (plus any other's that are poorly defined)
[17:57:50] <awjr>	 phil added that after i last checked last night
[17:58:47] <MaxSem>	 awjr & jdlrobson, regarding https://mingle.corp.wikimedia.org/projects/wlm_android_app/cards/200 : what this card asks for may result in tree containing two languages. is it a sane thing to do?
[17:59:07] <awjr>	 MaxSem: i thought that was how we spec'd it out?
[17:59:51] <awjr>	 that we'd show admin levels in the user's language if possible, and any that we couldn't show in the user's language show in the default lang?
[17:59:53] <jdlrobson>	 194 has been moved back
[18:00:01] <MaxSem>	 due to brain meltdown thinking about laguages, I often have parse errors
[18:00:08] <tfinc>	 lolz
[18:00:10] <awjr>	 hehehehe totally understandable :p
[18:00:42] <jdlrobson>	 where we use the default language should we put a star next to them?
[18:00:50] <jdlrobson>	 with a translation saying localized name not known
[18:01:21] <awjr>	 jdlrobson: i think for now we should just display the place names; if it's an issue moving forward we can add disclaimers like that
[18:02:01] <awjr>	 jdlrobson: are any of the other stories too unclear to keep in ready for dev?
[18:02:29] <jdlrobson>	 loads
[18:02:33] <jdlrobson>	 i'm moving now as i go through
[18:02:38] <jdlrobson>	 with comments
[18:04:01] <awjr>	 jdlrobson: re #195, we will not be fixing that data. but the functionality requested is very vague
[18:04:31] <jdlrobson>	 yes but it would be good to be clear about what action to take - this is an example of a bug where solutions have been suggested but it's not clear how to act
[18:04:39] <jdlrobson>	 i'd expect stories to make a call on that
[18:04:45] <awjr>	 jdlrobson: agreed, the functionality requested is very vague :)
[18:04:50] <jdlrobson>	 :/
[18:10:09] <awjr>	 jdlrobson: when you're done sifting, lmk - i'll go through and answer anything i can otherwise punt back to phil. we can use tomorrow's meeting to finalize any review necesary and get the cards back into dev ready
[18:17:23] <awjr>	 MaxSem: still want the error reporting stuff reviewed?
[18:20:00] <jdlrobson>	 MaxSem: https://mingle.corp.wikimedia.org/projects/wlm_android_app/cards/142 < this story is misinformed
[18:20:15] <awjr>	 jdlrobson: isn't that story done?
[18:20:17] <jdlrobson>	 https://bugzilla.wikimedia.org/show_bug.cgi?id=39715
[18:20:35] <jdlrobson>	 it seems to be in ready for development
[18:20:42] <jdlrobson>	 "On the app side, arbitrary search seems broken. Nothing happens when the Go button on the keyboard is pressed."
[18:20:49] <jdlrobson>	 i think that got added and it moved back
[18:21:08] <jdlrobson>	 it should be in ready for development not in development?
[18:21:10] <awjr>	 jdlrobson: i know, phil put it in there but i sent him a recent apk from master and asked him to test since my last tests showed it complete
[18:21:22] <awjr>	 jdlrobson: but i guess he hasn't done it yet
[18:21:32] <jdlrobson>	 awjr: Skype i'll explain
[18:21:38] <awjr>	 jdlrobson: k
[18:23:06] <jdlrobson>	 awjr: https://bugzilla.wikimedia.org/show_bug.cgi?id=39715
[18:36:19] <MaxSem>	 awjr, yes please
[18:36:29] <awjr>	 MaxSem: which revs again?
[18:36:49] <MaxSem>	 https://gerrit.wikimedia.org/r/21748 + https://gerrit.wikimedia.org/r/21753
[18:36:59] <awjr>	 MaxSem: cool i'll take a look
[18:50:09] <awjr>	 MaxSem: at quick glance those are OK but i want to poke a little deeper due to the core change. i'll look more closely after lunch
[19:02:14] * tfinc  ponders food

[19:06:19] <tfinc>	 yelp is seriously failing today
[19:08:29] <tfinc>	 jdlrobson: i'm thinking of heading to japa curry food cart. you in ?
[19:08:38] <jdlrobson>	 YES
[19:08:44] <yuvipanda>	 goddamn people in the first world. tch tch
[19:08:49] <tfinc>	 howard and 1st for anyone else wanting to join
[19:08:59] <tfinc>	 :D
[19:22:56] * awjr_lunch  highfives yuvipanda

[19:29:28] <multichill>	 jdlrobson: Did you see this one? Small tweak in the output. Now it's "[[user:<username>]]", could you change this to "[[user:<username>|<username>]]"?
[19:58:24] <tfinc>	 jdlrobson: if your both a star trek and octocat (github) fan preilly brought back some awesome stickers yesterday. come grab one
[19:58:26] <jdlrobson>	 multichill: ? not sure what you are referring to
[19:58:34] <tfinc>	 yuvipanda: come by so that you can steal one ;)
[20:00:55] <multichill>	 jdlrobson: https://bugzilla.wikimedia.org/show_bug.cgi?id=39743
[20:18:57] <tfinc>	 awjr: i'm going to take a pass https://mingle.corp.wikimedia.org/projects/wlm_android_app/cards/194 and define it a bit better
[20:19:06] <tfinc>	 as i'm eager to see that one get done
[20:19:20] <awjr>	 tfinc thanks!
[20:19:34] <awjr>	 tfinc note jdlrobson's comment on the card
[20:20:06] <tfinc>	 awjr: yeah, we talked about it at lunch
[20:20:11] <tfinc>	 i can shape this card up
[20:20:12] <awjr>	 great
[20:29:04] <preilly>	 jdlrobson: pm
[21:03:06] <MaxSem>	 someone please review this when you have time: https://gerrit.wikimedia.org/r/21830
[21:03:20] <jdlrobson>	 awjr: in need of some code review in absence of brion
[21:03:40] <awjr>	 MaxSem: jdlrobson: okidoke
[21:03:52] <awjr>	 MaxSem: i'll look shortly
[21:03:57] <awjr>	 jdlrobson: should i just look through pull reqs?
[21:04:05] <jdlrobson>	 please
[21:05:57] <awjr>	 argh my office is plagued with an angry swarm of mosquitos >:[
[21:06:41] <MaxSem>	 shouldn't heat kill them?
[21:07:07] <awjr>	 i suppose it might outside, but it's prime mosquito temp in my house, ~78-80F
[21:07:32] <awjr>	 i can't figure out where they're coming from - we've gotten rid of anything that might contain standing water in our house but they just wont go away
[21:08:25] <awjr>	 this is a weird time of year here because we get a lot of rain (at least, relative to none :p ) but it's still super hot outside so the bugs really come out
[21:16:05] <awjr>	 MaxSem: re r908 in the API - i cannot find any other magic quotes check
[21:16:57] <awjr>	 from the comment to the commit it seemed like there should still be at least one check somewhere
[21:17:03] <MaxSem>	 ahaha
[21:17:16] <MaxSem>	 grep fail - I thought it was in ApiMain
[21:17:29] <awjr>	 that would be a logical place
[21:17:41] <awjr>	 or even in api.php
[21:27:07] <awjr>	 MaxSem: im seeing smoething weird with r909
[21:27:31] <awjr>	 i get different admin levels back for http://192.168.7.128/p_erfgoed/api/api.php?action=adminlevels&admtree=ca&uselang=fr compared to http://192.168.7.128/p_erfgoed/api/api.php?action=adminlevels&admtree=ca&uselang=en
[21:27:54] <awjr>	 i realize you won't be able to cilck those, just wanted to give you the urls for reference
[21:27:56] <awjr>	 let me pastebin output
[21:28:46] <awjr>	 MaxSem: http://dpaste.org/eqQ6J/
[21:38:51] <MaxSem>	 awjr, that's because different admin trees are available in different languages
[21:40:21] <awjr>	 eh?
[21:42:02] <MaxSem>	 awjr, recall our discussions about not matching sets of monuments in different languages
[21:43:02] <awjr>	 oh
[21:43:04] <awjr>	 yeah, i do
[21:43:23] <awjr>	 blech sorry, the language stuff is hard to keep in my head.
[21:44:14] <awjr>	 MaxSem: we should probably write out the display logic for admin levels/monuments in an easily understandable way because i suspect we're going to get a lot of questions/feedback about it
[21:46:00] <MaxSem>	 easily understandable, ha-ha
[21:46:13] <awjr>	 :|
[21:46:13] <awjr>	 yeah
[21:46:15] <awjr>	 heh
[21:53:19] <tfinc>	 new fav octocat http://octodex.github.com/droidtocat/
[21:54:35] * tfinc  gets back to working on hiring packet

[21:57:05] <preilly>	 tfinc: hiring packet?
[21:57:32] <tfinc>	 let me pm you about it. i mentioned it in channel a couple hours ago
[22:01:59] <wknight_>	 Hi Tomasz, this is Will from OpenPath.
[22:02:05] <wknight_>	 Are you online?
[22:02:33] <awjr>	 tfinc ^
[22:06:34] <GitHub19>	 [WLMMobile] awjrichards pushed 2 new commits to master: http://git.io/wZi2Dg
[22:06:34] <GitHub19>	 [WLMMobile/master] correct context of call to getInBoundingBox (bug 39715) - jdlrobson
[22:06:34] <GitHub19>	 [WLMMobile/master] Merge pull request #196 from jdlrobson/39715 - Arthur Richards
[22:06:52] <mw-jenkinsbot>	 Project WLMMobile - Nightly builds build #134: SUCCESS in 11 sec: https://integration.mediawiki.org/ci/job/WLMMobile%20-%20Nightly%20builds/134/
[22:06:53] <mw-jenkinsbot>	 jdlrobson: correct context of call to getInBoundingBox (bug 39715)
[22:10:15] <GitHub150>	 [WLMMobile] awjrichards pushed 2 new commits to master: http://git.io/2RU7QQ
[22:10:15] <GitHub150>	 [WLMMobile/master] hide preamble text for error handler when a clearer message is available (bug 39638) - jdlrobson
[22:10:15] <GitHub150>	 [WLMMobile/master] Merge pull request #197 from jdlrobson/39638Pass - Arthur Richards
[22:10:22] <mw-jenkinsbot>	 Project WLMMobile - Nightly builds build #135: SUCCESS in 6.4 sec: https://integration.mediawiki.org/ci/job/WLMMobile%20-%20Nightly%20builds/135/
[22:10:22] <mw-jenkinsbot>	 jdlrobson: hide preamble text for error handler when a clearer message is available (bug 39638)
[22:11:46] <awjr>	 jdlrobson: this is ready for review, right? https://mingle.corp.wikimedia.org/projects/wlm_android_app/cards/197
[22:11:55] * jdlrobson  looks

[22:12:03] <jdlrobson>	 no
[22:12:05] <awjr>	 oh
[22:12:08] <awjr>	 it's not related to https://github.com/wikimedia/WLMMobile/pull/198?
[22:12:13] <jdlrobson>	 i had a stab at him but i'm not convinced i've fixed it
[22:12:18] <jdlrobson>	 it might be
[22:12:23] <awjr>	 lol ok
[22:12:27] <jdlrobson>	 a lot of that ended up being refactoring
[22:12:32] <awjr>	 roger
[22:12:51] <jdlrobson>	 i will look again when the repository is in a more stable state
[22:14:37] <awjr>	 jdlrobson: k
[22:14:39] <awjr>	 jdlrobson: https://github.com/jdlrobson/WLMMobile/commit/ce00b678695d195516214e68377f3c5c640513cb
[22:14:46] <awjr>	 is data["0"] no longer an issue?
[22:14:58] <awjr>	 (line 552)
[22:15:46] <jdlrobson>	 awjr:  i might be wrong but i think https://github.com/jdlrobson/WLMMobile/commit/41a832d3e44545945d02ca8e868ade8b9f762a62 fixes that
[22:15:47] <jdlrobson>	 i couldn't replicate
[22:16:02] <jdlrobson>	 either way it was a hack
[22:16:10] <awjr>	 jdlrobson: what was the case before when you'd get data["0"]?
[22:16:26] <awjr>	 an abort?
[22:16:43] <jdlrobson>	 https://github.com/wikimedia/WLMMobile/commit/aec8b1db00f24848c3e57ff8d9bcc6ad13f36bb9 < annoyingly i didn't annotate my commit well enough :(
[22:17:01] <jdlrobson>	 but the commit is wrong - i discovered it wasn't an issue with what the api returned
[22:17:08] <jdlrobson>	 but something to do with the reject function
[22:17:35] <awjr>	 ohfun
[22:18:32] <jdlrobson>	 to be honest i'd rather break it again and fix it properly ;-)
[22:18:39] <jdlrobson>	 i can't even find the bug i was fixing though :(
[22:18:41] <awjr>	 hehehe i know the feeling
[22:25:43] <awjr>	 jdlrobson: so it looks like the fix mostly addresses 39690 but does not totally resolve 38317 is that right? what i just experienced in testing was: if i hit cancel during 'prearing for launch', the uploads all get cancelled. if i hit cancel after 'launching photo to internet', the photo will still get uploaded, but all remaining photos will not (however the photo remains in my 'incomplete' list)
[22:26:00] <jdlrobson>	 that's a different bug
[22:26:07] <jdlrobson>	 38317
[22:26:15] <jdlrobson>	 so yeh I think it's fixed
[22:26:18] <jdlrobson>	 i might be wrong though
[22:26:20] <jdlrobson>	 i wasn't confident
[22:26:25] <awjr>	 jdlrobson:  you marked 39690 a duplicate of 38317
[22:26:28] <jdlrobson>	 38317 is to fixed
[22:26:42] <jdlrobson>	 so I did :)
[22:27:30] <awjr>	 ok, so 36960 is complete thanks to that fix; 38317 is still open?
[22:28:43] <awjr>	 jdlrobson:  ^
[22:29:44] <jdlrobson>	 yes
[22:29:51] <awjr>	 cool
[22:29:52] <awjr>	 thanks :)
[22:30:20] <GitHub39>	 [WLMMobile] awjrichards pushed 6 new commits to master: http://git.io/Dla7jQ
[22:30:20] <GitHub39>	 [WLMMobile/master] more explicit error handlers - jdlrobson
[22:30:21] <GitHub39>	 [WLMMobile/master] refactor generic uploadErrorHandler - jdlrobson
[22:30:21] <GitHub39>	 [WLMMobile/master] route batch upload failure through the generic error handler - jdlrobson
[22:30:27] <mw-jenkinsbot>	 Project WLMMobile - Nightly builds build #136: SUCCESS in 6.3 sec: https://integration.mediawiki.org/ci/job/WLMMobile%20-%20Nightly%20builds/136/
[22:30:28] <mw-jenkinsbot>	 * jdlrobson: more explicit error handlers
[22:30:28] <mw-jenkinsbot>	 * jdlrobson: refactor generic uploadErrorHandler
[22:30:29] <mw-jenkinsbot>	 * jdlrobson: route batch upload failure through the generic error handler
[22:30:29] <mw-jenkinsbot>	 * jdlrobson: provide better error message where file type wrong (bug 39749)
[22:30:30] <mw-jenkinsbot>	 * jdlrobson: remove unused variables
[22:31:54] <jdlrobson>	 brb coffee
[22:39:04] <awjr>	 jdlrobson: see comment https://github.com/wikimedia/WLMMobile/pull/199
[22:39:33] <awjr>	 jdlrobson: also, https://mingle.corp.wikimedia.org/projects/wlm_android_app/cards/174 is still missing this change: "Monument details screen – underneath monument name, “Country:”"
[22:40:35] <awjr>	 jdlrobson: i put the card back in dev ready
[22:46:00] <GitHub98>	 [WLMMobile] awjrichards pushed 2 new commits to master: http://git.io/FikkhA
[22:46:00] <GitHub98>	 [WLMMobile/master] correct filename on upload screen (bug 39624) - jdlrobson
[22:46:00] <GitHub98>	 [WLMMobile/master] Merge pull request #184 from jdlrobson/39624 - Arthur Richards
[22:46:07] <mw-jenkinsbot>	 Project WLMMobile - Nightly builds build #137: SUCCESS in 6.4 sec: https://integration.mediawiki.org/ci/job/WLMMobile%20-%20Nightly%20builds/137/
[22:46:08] <mw-jenkinsbot>	 jdlrobson: correct filename on upload screen (bug 39624)
[22:48:25] <jdlrobson>	 awjr: bad coffee from xtra today
[22:48:31] <awjr>	 boooo
[22:48:33] <awjr>	 what'd you get?
[22:48:36] <jdlrobson>	 awjr: 174 is fixed
[22:49:01] <jdlrobson>	 https://github.com/wikimedia/WLMMobile/pull/199/files < check detail-country
[22:49:08] <jdlrobson>	 i got a cafe au lait
[22:49:12] <jdlrobson>	 but can't taste the coffee at all
[22:49:14] <jdlrobson>	 tastes like foam
[22:49:23] <jdlrobson>	 not sure what went wrong
[22:49:27] <awjr>	 :(
[22:49:32] <awjr>	 someone new?
[22:49:34] <jdlrobson>	 i'm actually resorting to the nespresso machine now
[22:49:45] <awjr>	 they're usually pretty consistent
[22:49:52] <awjr>	 the nespresso machine?
[22:50:54] <jdlrobson>	 i know
[22:51:00] <jdlrobson>	 i think it's just a blip
[22:51:10] <jdlrobson>	 i would have corrected it had i not walked too far back to the office
[22:51:18] <jdlrobson>	 shit happens
[22:51:41] <awjr>	 hehehe what's the nespresso machine? that weird espresso machine with the 'coffee cartrdiges'?
[22:55:49] <GitHub49>	 [WLMMobile] awjrichards pushed 2 new commits to master: http://git.io/n1GutQ
[22:55:49] <GitHub49>	 [WLMMobile/master] consistent capitalization and other copy text changes - jdlrobson
[22:55:49] <GitHub49>	 [WLMMobile/master] Merge pull request #200 from jdlrobson/story175 - Arthur Richards
[22:55:55] <mw-jenkinsbot>	 Project WLMMobile - Nightly builds build #138: SUCCESS in 6.2 sec: https://integration.mediawiki.org/ci/job/WLMMobile%20-%20Nightly%20builds/138/
[22:55:56] <mw-jenkinsbot>	 jdlrobson: consistent capitalization and other copy text changes
[22:57:32] <awjr>	 jdlrobson: missed one in https://mingle.corp.wikimedia.org/projects/wlm_android_app/cards/175
[22:57:38] <awjr>	 see my comment - im putting it back to ready for dev
[22:58:13] <preilly>	 jdlrobson: seriously Jon I expect more from you
[22:58:25] * preilly  tisk tisk

[22:58:43] <jdlrobson>	 sigh awjr - story didn't mention that
[22:58:51] * preilly  or is that tsk tsk

[22:58:57] <awjr>	 jdlrobson: it does
[22:59:00] <jdlrobson>	 where?
[22:59:18] <jdlrobson>	 grep "Your Upload" nothing
[22:59:54] <awjr>	 oh you're right, i confused with Your Photo
[23:00:14] <awjr>	 ok, i'll move it to ready for signoff
[23:03:29] <awjr>	 jdlrobson: per https://mingle.corp.wikimedia.org/projects/wlm_android_app/cards/174 i still see "Campaign:" on the monument detail screen
[23:03:50] <jdlrobson>	 really?
[23:03:54] <awjr>	 yeah
[23:03:55] <jdlrobson>	 have you merged both commits?
[23:03:59] <jdlrobson>	 any merge issues?
[23:04:21] <awjr>	 i just checked out your branh (jdlrobson:174) and built from there
[23:04:29] <awjr>	 *branch
[23:04:47] <jdlrobson>	 what do you see for detail-country in messages-en ?
[23:04:57] <jdlrobson>	 https://github.com/jdlrobson/WLMMobile/commit/9b072f32dfb663362f90734e1ea2b9e86d89ed65
[23:04:59] <jdlrobson>	 is the commit
[23:05:04] <jdlrobson>	 do you see that in git log awjr ?
[23:05:39] <awjr>	 i see the change in the message file, yes
[23:06:27] <awjr>	 but on the monument detail screen, i still see "Campaign:"
[23:06:41] <awjr>	 which i presume is a different message than detail-country
[23:06:43] <awjr>	 ?
[23:06:44] <jdlrobson>	 mm
[23:06:56] <jdlrobson>	 i don't understand
[23:07:01] <jdlrobson>	 detail-country=Country is what it should say
[23:07:03] <jdlrobson>	 skype?
[23:07:18] <awjr>	 the message itself looks fine, but i think what im talking about is a different msg
[23:07:31] <awjr>	 monument-country
[23:07:41] <awjr>	 is the one i'm referring to
[23:08:48] <awjr>	 plus there's another minor issue in that pull request (missing colon)
[23:08:56] <awjr>	 and it looks like it needs to be rebased again
[23:09:15] <jdlrobson>	 mm
[23:09:19] <jdlrobson>	 ok i'll take a look
[23:16:09] <GitHub12>	 [WLMMobile] awjrichards pushed 2 new commits to master: http://git.io/hmjnZw
[23:16:09] <GitHub12>	 [WLMMobile/master] tweak header css - jdlrobson
[23:16:09] <GitHub12>	 [WLMMobile/master] Merge pull request #201 from jdlrobson/headertweaks - Arthur Richards
[23:16:16] <mw-jenkinsbot>	 Project WLMMobile - Nightly builds build #139: SUCCESS in 6.4 sec: https://integration.mediawiki.org/ci/job/WLMMobile%20-%20Nightly%20builds/139/
[23:16:17] <mw-jenkinsbot>	 jdlrobson: tweak header css
[23:19:17] <GitHub16>	 [WLMMobile] awjrichards pushed 2 new commits to master: http://git.io/VtBjLA
[23:19:17] <GitHub16>	 [WLMMobile/master] make the buttons bigger (bug 39713) - jdlrobson
[23:19:17] <GitHub16>	 [WLMMobile/master] Merge pull request #202 from jdlrobson/biggerbuttons39713 - Arthur Richards
[23:19:22] <mw-jenkinsbot>	 Project WLMMobile - Nightly builds build #140: SUCCESS in 6.3 sec: https://integration.mediawiki.org/ci/job/WLMMobile%20-%20Nightly%20builds/140/
[23:19:23] <mw-jenkinsbot>	 jdlrobson: make the buttons bigger (bug 39713)
[23:20:45] <GitHub121>	 [WLMMobile] awjrichards pushed 2 new commits to master: http://git.io/JnGOpQ
[23:20:45] <GitHub121>	 [WLMMobile/master] ensure if marking a list as incomplete it is not empty - jdlrobson
[23:20:45] <GitHub121>	 [WLMMobile/master] Merge pull request #203 from jdlrobson/39720 - Arthur Richards
[23:20:51] <mw-jenkinsbot>	 Project WLMMobile - Nightly builds build #141: SUCCESS in 6.3 sec: https://integration.mediawiki.org/ci/job/WLMMobile%20-%20Nightly%20builds/141/
[23:20:52] <mw-jenkinsbot>	 jdlrobson: ensure if marking a list as incomplete it is not empty
[23:25:25] <GitHub22>	 [WLMMobile] awjrichards pushed 2 new commits to master: http://git.io/sPue4g
[23:25:25] <GitHub22>	 [WLMMobile/master] change upload confirmation page to link to upload again - jdlrobson
[23:25:25] <GitHub22>	 [WLMMobile/master] Merge pull request #204 from jdlrobson/39706 - Arthur Richards
[23:25:32] <mw-jenkinsbot>	 Project WLMMobile - Nightly builds build #142: SUCCESS in 6.2 sec: https://integration.mediawiki.org/ci/job/WLMMobile%20-%20Nightly%20builds/142/
[23:25:33] <mw-jenkinsbot>	 jdlrobson: change upload confirmation page to link to upload again
[23:26:08] <preilly>	 awjr, jdlrobson, MaxSem: https://www.youtube.com/watch?v=dYBjVTMUQY0
[23:26:27] <awjr>	 hahahaha spooning
[23:26:42] <preilly>	 awjr: did you watch this video?
[23:26:46] <awjr>	 watching now
[23:27:28] <awjr>	 ahahahaha
[23:27:56] <awjr>	 #2 is so true
[23:28:18] <awjr>	 pull request!
[23:28:37] <awjr>	 awesome.
[23:28:45] <preilly>	 awjr: it's important to TAKE TURNS
[23:29:10] <awjr>	 hahaha their facial expressions are amazing.
[23:29:54] <tfinc>	 awjr: ready when you are
[23:29:56] <GitHub78>	 [WLMMobile] preillyme pushed 2 new commits to master: http://git.io/1BO-mg
[23:29:56] <GitHub78>	 [WLMMobile/master] show user friendly username (bug 39743) - jdlrobson
[23:29:56] <GitHub78>	 [WLMMobile/master] Merge pull request #205 from jdlrobson/39743 - Patrick Reilly
[23:30:03] <mw-jenkinsbot>	 Project WLMMobile - Nightly builds build #143: SUCCESS in 6.2 sec: https://integration.mediawiki.org/ci/job/WLMMobile%20-%20Nightly%20builds/143/
[23:30:03] <mw-jenkinsbot>	 jdlrobson: show user friendly username (bug 39743)
[23:30:49] <awjr>	 tfinc cool one sec
[23:38:25] <preilly>	 https://github.com/praekelt/vumi-wikipedia/issues/16 in case anyone cares to read about some USSD and SMS plans
[23:53:01] <jdlrobson>	 belarus seems to have disappeared...
[23:53:17] <jdlrobson>	 it's back again.. wtf!