[00:14:28] yo yo [00:14:43] brion! [00:15:01] how go things? [00:15:26] pretty good, crankin through bugs [00:15:35] nice [00:15:39] heh "Your Mingle license key will expire in 30 days. Please contact your ThoughtWorks Studios account executive or email studios@thoughtworks.com to obtain a new license" [00:15:45] doh [00:16:17] spent the day at the zoo with my bro & nephew. good times [00:16:29] nice dude [00:16:36] i'll be free tomorrow so feel free to assign me goodies [00:16:54] brion ok will do - will you join us for the mtg at 11? [00:17:03] im sure we can dig up a few things for you to work on before then [00:17:05] that'll be….. 1pm my time. can do [00:17:09] ok great [00:17:11] excellent [00:17:14] thanks man [00:17:20] glad to help :) [00:17:44] brion i have a feeling this would be good for you to work on: https://mingle.corp.wikimedia.org/projects/wlm_android_app/cards/203 [00:18:06] and possibly this: https://mingle.corp.wikimedia.org/projects/wlm_android_app/cards/197 [00:18:06] i'll see if i can reproduce it [00:18:10] kk [00:18:26] yeah i can take that one i think [00:18:29] if you work on either of those just be sure to drag them into 'in dev' so someone else doesn't start hacking on it [00:18:35] *nod* [00:20:31] brion also if you find yourself twiddling thumbs, pull requests could use some love [00:20:40] i'm looking over those now :) [00:20:45] huzzah! [00:21:47] [WLMMobile] brion pushed 3 new commits to master: http://git.io/8b72NQ [00:21:47] [WLMMobile/master] change heading / search placeholder depending on whether region or country - jdlrobson [00:21:47] [WLMMobile/master] minor tweak to campaign page - jdlrobson [00:21:47] [WLMMobile/master] Merge pull request #199 from jdlrobson/174 - Brion Vibber [00:21:54] Project WLMMobile - Nightly builds build #144: SUCCESS in 6.2 sec: https://integration.mediawiki.org/ci/job/WLMMobile%20-%20Nightly%20builds/144/ [00:21:54] * jdlrobson: change heading / search placeholder depending on whether region or country [00:21:55] * jdlrobson: minor tweak to campaign page [00:22:19] awjr: when i merge should i move the card to 'in review' or completed review, or wait for others to confirm it's working and do that? [00:22:55] brion if the code you merge satisifies a card, go ahead and put it in 'ready for signoff' [00:23:04] ok [00:23:32] ok make sure https://mingle.corp.wikimedia.org/projects/wlm_android_app/cards/174 looks like it's in the right state, if so i'll do that for others in future [00:24:41] brion looks good [00:24:53] excellent [00:26:16] [WLMMobile] brion pushed 2 new commits to master: http://git.io/dOyAVQ [00:26:16] [WLMMobile/master] fix bad refactor in ce00b678695d195516214e68377f3c5c640513cb - jdlrobson [00:26:16] [WLMMobile/master] Merge pull request #207 from jdlrobson/fixup - Brion Vibber [00:26:23] Project WLMMobile - Nightly builds build #145: SUCCESS in 6.6 sec: https://integration.mediawiki.org/ci/job/WLMMobile%20-%20Nightly%20builds/145/ [00:26:23] jdlrobson: fix bad refactor in ce00b678695d195516214e68377f3c5c640513cb [00:28:37] [WLMMobile] brion pushed 2 new commits to master: http://git.io/aa1b3Q [00:28:37] [WLMMobile/master] clean up ajax loader icon on monument detail page (bug 39692) - jdlrobson [00:28:37] [WLMMobile/master] Merge pull request #206 from jdlrobson/39692 - Brion Vibber [00:28:43] Project WLMMobile - Nightly builds build #146: SUCCESS in 6.1 sec: https://integration.mediawiki.org/ci/job/WLMMobile%20-%20Nightly%20builds/146/ [00:28:43] jdlrobson: clean up ajax loader icon on monument detail page (bug 39692) [00:28:58] tfinc: using sept 10 for retro/planning won't work - you guys are all gonna be at the cooper u mobile design workshop :( [00:29:38] tfinc which basically leaves us with two options: 9/4 or delay the planning til after the all-staff [12:54:49] what does one have to do to get hold of Jarry1250 around these parts? [12:54:50] sigh [16:19:01] MaxSem: how do i get the names of all pages in a given category via api.. can't figure it out myself : [16:21:21] MaxSem: got it [16:44:49] awjr, better now? https://gerrit.wikimedia.org/r/21748 [16:54:21] yes :) [16:54:34] MaxSem: merged [16:55:04] whee [17:09:16] MaxSem: another api question for you.. [17:09:23] sure [17:09:24] given a file page how do I extract the url for the image on it? [17:09:35] so for example given File:Armory_Park_Historic_Residential_District_(taken_on_27Aug2012_16hrs13mins54secs).jpg [17:09:41] how do I get http://upload.wikimedia.org/wikipedia/commons/thumb/2/20/Armory_Park_Historic_Residential_District_%28taken_on_27Aug2012_16hrs13mins54secs%29.jpg/640px-Armory_Park_Historic_Residential_District_%28taken_on_27Aug2012_16hrs13mins54secs%29.jpg [17:10:57] hey that's my house [17:11:18] \o/ [17:11:23] jdlrobson, prop=imageinfo [17:11:32] it's a nice house awjr i want to visit [17:11:38] so MaxSem I have to make another request? :( [17:11:38] jdlrobson: you should! [17:12:03] another request after what? [17:12:57] http://commons.wikimedia.org/w/api.php?action=query&list=categorymembers&format=json&cmtitle=Category%3AMobile_upload&cmlimit=100 [17:13:03] can I use prop on that query? [17:14:04] yes, use it as a generatorr [17:14:24] what would that url look like? sorry to be a pain i just hacked something cool i want to show off and this is the last piece of the puzzle [17:16:19] use teh sandbox, Luke! [17:16:20] https://commons.wikimedia.org/wiki/Special:ApiSandbox#action=query&prop=imageinfo&format=json&iiprop=timestamp%7Cuser%7Cuserid%7Ccomment%7Cparsedcomment%7Curl%7Csize%7Cdimensions%7Csha1%7Cmime%7Cthumbmime%7Cmediatype%7Cmetadata%7Carchivename%7Cbitdepth&iilimit=10&generator=categorymembers&gcmtitle=Category%3AMobile%20upload&gcmlimit=10 [17:17:28] MaxSem: I am… i'm just finding it hard to work out what parameters mean what [17:17:33] there's too much going on :) [17:19:09] btw MaxSem that link breaks [17:19:13] bug in api sandbox [17:19:31] oh noes [17:19:46] (in chrome) [17:19:57] what is the request url? [17:20:30] luckily, you can just s/iki\/Special:ApiSandbox#/\/api.php?/ [17:20:41] grr http://commons.wikimedia.org/w/api.php?action=query&cmtitle=Category%3AMobile_upload&generator=categorymembers&format=json&prop=imageinfo&iiprop=url [17:20:46] One of the parameters cmtitle, cmpageid is required [17:20:52] but i'm providing cmtitle! [17:21:25] ahhh gcmtitle [17:21:26] typo! [17:21:29] you should prefix the generator parameters with g, e.g. gcmtitle [17:22:16] (I personally grokked this stuff only when I had to add support for it to APISB) [17:27:21] greetings all [17:27:51] awjr: bummer on 9/10 [17:28:53] tfinc yeah :( [17:29:29] awjr: have you mailed anyone about the "Your Mingle license key will expire in 30 days." message that we started to see yesterday? [17:29:51] tfinc: i intended to and then forgot [17:30:13] awjr: im mailing erik and james now [17:30:25] i know james alexander was the one who was maintaining mingle previously, but im not sure who is responsible now [17:30:26] ok [17:31:52] philinje: what kind of response have you heard from the WLM folks about the commons version of the app beta? any new bugs/issues raised we should discuss? [17:32:17] i was going to send it out today, sorry [17:32:39] oh [17:33:51] seeing some serious bugs to do with search [17:35:16] philinje: i thought we talked about sending out the apk to wlm on monday? [17:35:32] what reasonable feedback will we be able to get in a day as we launch tomorrow [17:36:27] sorry, it was midnight and i still hadn't tested all the countries [17:37:16] philinje: wouldn't it just be better to point them at the final tomorrow ? [17:37:34] yeah, probably [17:37:38] ruhroh - brion discovered a vuln in the app: https://bugzilla.wikimedia.org/show_bug.cgi?id=39735 [17:38:25] ahaha [17:38:41] philinje: did we make any progress on ** Mobile Article Feedback feature definition [Phil], ** Minor Editing [Phil] from the roadmap ? [17:38:46] it was listed for august [17:54:35] awjr: this manager meeting is going to run right up until 11 in r31 [17:54:55] tfinc ok does that mean we'll need to start a few minutes late? [17:56:53] lets plan for 11:05 [18:00:14] ok [18:00:25] MaxSem, tfinc when you're ready: https://plus.google.com/hangouts/_/e732317b443bd13af518bf9e087a8cbd769c8842?authuser=1&hl=en-US [18:07:01] awjr: hangout link? [18:07:09] brion: https://plus.google.com/hangouts/_/e732317b443bd13af518bf9e087a8cbd769c8842?authuser=1&hl=en-US [18:07:11] tx [18:11:18] [WLMMobile] jdlrobson pushed 1 new commit to master: http://git.io/z66_og [18:11:18] [WLMMobile/master] Bug 39571: truncate long filenames - Brion Vibber [18:11:23] \o/ [18:11:33] Project WLMMobile - Nightly builds build #147: SUCCESS in 10 sec: https://integration.mediawiki.org/ci/job/WLMMobile%20-%20Nightly%20builds/147/ [18:11:34] Brion VIBBER: Bug 39571: truncate long filenames [18:28:16] brion: we lost your audio [18:29:02] this hotel has some flaky wifi [18:39:44] philinje: https://mingle.corp.wikimedia.org/projects/wlm_android_app/cards/138 [18:45:34] I think dodgy wifi is mandatory in hotels. :-/ [18:58:43] awesome work powering through that huge list of bugs everyone :D [18:58:56] \o/ [19:06:37] started https://commons.wikimedia.org/wiki/Template:Uploaded_with_WLM_Mobile [19:07:37] MaxSem: can you please move the related card into 'in development'? [19:08:36] dun [19:08:42] yay! [19:10:44] tfinc: Signpost 1.0 is ready, but me, Jarry1250 and notnarayan decided to delay it a week so that it can hog the limelight after WLM Mobile is done hogging the limelight :) It also means we get to finish Push notifications in time. FYI :) [19:17:24] philinje, I'm ready to talk about the template [19:28:21] ok, i updated the card slightly, let me know if you need more info [19:29:07] awjr: noticing that UK still shows Scotland only, which is not a campaign [19:29:52] philinje i suspect that's because my changes have not yet been merged. note the card is still in 'ready for review' [19:30:08] ah [19:30:09] philinje: i can double check though in a bit [19:35:02] app version, platform, OS version, user-agent - anything else? [19:42:06] philinje, see my comment at https://mingle.corp.wikimedia.org/projects/wlm_android_app/cards/206 [19:42:13] ok [19:42:24] awjr, jdlrobson - who'll handle it? ^^ [19:42:37] just found a serious bug with admin levels, will file a new bug shortly [19:43:14] MaxSem so all we need to do is populate the template and upload it with the photo? [19:43:20] yes [19:43:37] jdlrobson: if you are looking for something to do, please go for it. otherwise i can take a look at it after i get back from the dentist this afternoon [19:43:44] poke me if you need to change anything [19:43:59] MaxSem: I can as long as you code review me [19:44:27] MaxSem: do the parameters need to be the ones you mentioned? [19:44:42] any problems with it? [19:46:25] there are two non-changing categories, Mobile uploads, Uploaded with Android WLM App [19:47:33] then we generate a shortened UA which includes all the info you have as parameters [19:48:08] what's a "shortened UA"? [19:48:26] here is an example: UA: Android 4.1.1; en-us; Nexus S Build/JRO03E [19:49:02] just a format Arthur came up with to reduce the bulk of the user agent string [19:50:30] would be much better to split this info to different parameters as much as possible [19:50:48] would each parameter be a category? [19:50:52] more parametrers = more flexibility in categorisation [19:51:03] so MaxSem what do I need to do here? [19:51:09] no, we can do different stuff with parameters [19:52:13] ok, but will the parameters be written out as a category such as OS + device? [19:52:16] jdlrobson, add this template to description page. at the end of description parameter of {{information}} [19:52:59] philinje, this can be decided/changed at any time - that's the whole point of using a template [19:53:09] so "{{information}}" string constant? [19:53:29] I dunno how it's organised in code base [19:53:43] * jdlrobson tries an upload [19:54:03] "{{information}}" is a tewmplate transclusion [19:54:54] http://test.wikipedia.org/wiki/File:Second_and_Howard_Streets_District_2012-07-29_12-54-04.jpg [19:54:56] did that work? [19:55:35] did you just add [[Category:{{information}}]] at the bottom? [19:56:32] jdlrobson, that's what I mean: http://test.wikipedia.org/w/index.php?title=File:Second_and_Howard_Streets_District_2012-07-29_12-54-04.jpg&diff=141681&oldid=141680 [19:57:09] mm [19:57:24] jdlrobson, or even more precise: http://test.wikipedia.org/w/index.php?title=File%3ASecond_and_Howard_Streets_District_2012-07-29_12-54-04.jpg&diff=141682&oldid=141680 [19:59:32] * jdlrobson now really confused (sorry Max) - so you want me to kill all the categories and add the information field? [19:59:58] all these categories should be added by templates [20:00:28] jdlrobson, you need to learn wikispeak, I have problems understanding you:P [20:01:30] :) sorry i misunderstood the task [20:01:35] i thought it was just a one line change [20:01:44] i'll take care of that after the location marker [20:01:46] not exactly one line [20:01:57] MaxSem: let me call you on Skype [20:02:02] sure [20:02:10] one sec [20:02:54] its beginning to really feel like wlm with http://jonrobson.me.uk/wlm/ up on the big screen in the office https://twitter.com/flyingclimber/status/240902272454901760 [20:03:09] awjr_lunch: i have it running off of the chrome box right now [20:03:10] :) [20:03:12] hahaha awesome [20:03:12] wah [20:03:30] nice [20:03:33] i suggest dedicating a screen to the photos feed once we kick off :) [20:03:42] jdlrobson hacked it up and i got it running on the big screen [20:03:47] shall be grand [20:04:04] wow [20:04:09] \o/ [20:04:12] :D [20:04:40] yuvipanda: how are your signpost release candidates coming along? [20:05:12] tfinc: so, 1.0 is done [20:05:15] tfinc: and ready to release [20:05:30] tfinc: but I talked to Jarry and we're delaying it by a week for two reasons [20:05:37] did anybody have a chance to test the signpost app on galaxy tab? i haven't been able to text the latest fix since i left my tablets at home [20:05:38] 1. To not clash with WLMMobile release and [20:05:45] 2. We could get Push notifications in! [20:05:49] ooooh [20:05:52] (1) more so than (2) [20:05:57] and I've 50% of push notifications done [20:06:49] Push notification won't work on Kindle (or any non-google devices), since it will use Google Cloud Messaging. [20:07:29] yuvipanda: i think it's most recent uploads…provided this returns the newest http://commons.wikimedia.org/w/api.php?iiurlwidth=320px&action=query&gcmlimit=500&gcmtitle=Category%3AMobile_upload&generator=categorymembers&callback=?&format=json&prop=imageinfo&iiprop=url [20:07:42] yup [20:07:47] ah, jsonp [20:07:58] why are you asking for 500 of them? [20:08:23] mm i should probably eat [20:08:32] and IIRC it does not quite return the newest, but I could possibly be wrong [20:08:55] Barack Obama is doing a AMA on Reddit?! [20:09:03] yuvipanda: because i'm expecting 500 uploads every 10 minutes (the polling time) [20:09:09] ahahhh i forgot to eat [20:09:09] brb [20:09:22] :D [20:16:31] using the real values: http://test.wikipedia.org/w/index.php?title=File%3ASecond_and_Howard_Streets_District_2012-07-29_12-54-04.jpg&diff=141683&oldid=141680 [20:25:13] card 206 has been updated after discussion with Max [20:26:49] im off to the dentist, i should be back by 330pdt [20:46:43] tfinc: what was the name of the screen capture utility? [21:07:50] brion: hi, u there? [21:08:00] hey philinje [21:08:31] check this out: https://bugzilla.wikimedia.org/show_bug.cgi?id=39774 [21:09:14] interesting [21:09:19] i think i've seen something like that before [21:10:06] jon will know better how that bit of the code works i think [21:10:14] the other bug I filed earlier may be related [21:10:24] sounds like it's getting confused about which level it's on and is showing the upper levels in the list [21:11:20] so the previous card about showing the drill-down path in incomplete uploads is fine, but what I saw today was all the entries in one admin level [21:11:27] the opposite of this bug [21:12:14] hm [21:12:55] i'll add this new bug as a story too [21:14:00] brion, jdlrobson - so should I fix the API to return nulls instead of zeros? my point was that the app needs to special-case for points w/o coordinates anyway, not that API doesn't need to be changed [21:14:39] MaxSem: i don't really care whether it returns 0s or nulls, as long as we handle it [21:14:44] yes but i think the absence of latitude and longitude in the api result is a more reliable way of saying 'we don't know where this is' [21:14:52] i'm mainly confused about the card saying that address should be used for map placement [21:14:56] absence or nulls? [21:15:14] absence would be preferred [21:15:29] * jdlrobson almost done with geolocation stuff [21:15:29] np [21:15:38] \o/ ok let's go with that [21:16:37] * jdlrobson needs to go test the location stuff [21:31:12] jdlrobson, done and deployed [21:40:05] do we want this confirmation dialog on https://mingle.corp.wikimedia.org/projects/wlm_android_app/cards/197 ? [21:40:05] you can find the photos that were uploaded by going to the completed uploads list, no need to go to commons...? [21:41:02] brion: i think not [21:41:10] it should just cancel [21:41:17] it's kind of obvious the effect [21:41:21] the card also mentions two distinct bugs, one of which doesn't look like it's about batch upload specifically [21:41:27] yeh [21:41:33] i got a bit confused with it yesterday [21:41:35] philinje: can ou take a peek at https://mingle.corp.wikimedia.org/projects/wlm_android_app/cards/197 ? [21:41:44] basically i'm not convinced uploads can be canceled in the posting to internet phase [21:41:54] and that might be causing batch uploads to fail [21:42:07] *cancellijng batch uploads to fail [21:43:41] well, it seems to stop the rest of the batch. [21:44:02] try uploading 1 successfully [21:44:09] then canceling the 2nd whilst its posting to internet [21:44:25] this was causing upload issues for me but i couldn't work out if i fixed them or not [21:47:23] worst case seems to be that one photo ends up getting uploaded, but not marked as uploaded in the app [21:49:32] that seems to be what later comments on https://bugzilla.wikimedia.org/show_bug.cgi?id=38317 are about [21:51:07] looks like the actual 'keeps uploading more photos' is fixed on https://bugzilla.wikimedia.org/show_bug.cgi?id=39690 [21:51:18] bbiab [22:32:25] jdlrobson: heads up that alolita so/so for GOA post hackathon [22:32:32] i'm sure she'll come by to talk to you about it [22:32:46] jdlrobson: i'm debating about http://en.wikipedia.org/wiki/Port_Blair [22:35:48] so/so ? [22:36:05] as in it might not happen? [22:36:37] andaman sea is lovely though [22:37:00] http://www.flickr.com/photos/jdlrobson/4361810847/in/photostream/ [22:37:05] (thailand side) [22:40:57] [WLMMobile] jdlrobson pushed 2 new commits to master: http://git.io/8nN3nw [22:40:57] [WLMMobile/master] Fudge around the border sizes on the progress bar to make the border sizes even on hdpi devices - Brion Vibber [22:40:58] [WLMMobile/master] Merge pull request #210 from brion/bug38507 - Jon Robson [22:41:06] Project WLMMobile - Nightly builds build #148: SUCCESS in 8 sec: https://integration.mediawiki.org/ci/job/WLMMobile%20-%20Nightly%20builds/148/ [22:41:07] Brion VIBBER: Fudge around the border sizes on the progress bar to make the border sizes even on hdpi devices [22:42:08] awjr_dentist: hi, are you back? [22:42:46] [WLMMobile] jdlrobson pushed 2 new commits to master: http://git.io/UpNnhQ [22:42:46] [WLMMobile/master] Tweak ImageFetcher to reject the deferred if we are given a thumb URL but cannot load it - Brion Vibber [22:42:47] [WLMMobile/master] Merge pull request #209 from brion/imagefetch-error - Jon Robson [22:42:52] Project WLMMobile - Nightly builds build #149: SUCCESS in 6.1 sec: https://integration.mediawiki.org/ci/job/WLMMobile%20-%20Nightly%20builds/149/ [22:42:53] Brion VIBBER: Tweak ImageFetcher to reject the deferred if we are given a thumb URL but cannot load it [22:43:43] awjr_dentist: you still at dentist? [22:44:17] philinje: jdlrobson "I'm not sure when I'll be back online but hopefully by 430pdt - Arthur " [22:44:24] sent to mobile-tech 40min ago [22:44:39] k [22:44:45] jdlrobson: as in she didn't think it was a good time go [22:44:48] got my email turned off at moment for less distractions :) [22:44:58] yes, but he seems to be on Mingle, maybe that was his laptop staying open [22:45:35] i'm sure he left plenty of tabs open. we can call him after 4:30 if he doens't show [22:45:44] jdlrobson: yeah, i'm eager to go island hoping again [22:46:31] "If it's urgent you should have someone else do it. I probably won't be home for 45 mins or so." - Arthur [22:56:45] meh, can't get ops to review the cron script [22:59:29] MaxSem: no one around for it ? [22:59:39] i see daniel zash in the office [22:59:42] zahn* [23:01:03] I tried on #-ops several times, no response [23:35:21] im back [23:35:39] tfinc, jdlrobson, philinje ^ [23:35:41] gah phone [23:37:29] awjr: i'm not convinced having a mayorship at the dentist is such a good thing ;) [23:38:34] hehehe [23:39:36] philinje, tfinc: what's the current status of the build for the store, do i need to do anything? [23:39:59] i am just about to upload the version from Monday [23:40:03] great. [23:40:25] it is essentially the same as what's currently in the store, but it will actually allow people to do uploads [23:40:52] jdlrobson: did you need something from me? [23:41:08] awjr: do both versions have the same version code ? [23:41:15] awjr: i forget [23:41:25] tfinc likely [23:41:45] let me double check [23:42:08] tfinc: no [23:43:34] tfinc, philinje be sure to use WLM-v1.1beta3-commons-2.apk; it has additional campaigns and an updated version code [23:43:45] yes [23:44:40] awjr: instead of depending on version numbers in these converstaions we should compare md5sums [23:44:48] whenever i see n-x-n-x i cringe ;) [23:45:00] you'd rather see an md5sum?! [23:45:34] 90eb6125ff80a9ba3ae617feeda71b80 bin/WLM-v1.1beta3-commons-2.apk [23:45:38] tfinc you must be a robot [23:46:00] i trust md5sums a lot more then filenams for these things [23:46:12] beta3 - blah - 2 .. come on ;) [23:46:13] haha [23:46:17] lol [23:46:24] md5sum is certainly more reliable [23:46:42] in those cases i simply over write the old one as the original is always useless [23:46:44] i did make the mistake of sending out to builds with the same name that were different last week [23:46:50] tsk tsk [23:46:52] s/to/two [23:46:57] bad release manager [23:46:58] ;) [23:47:03] im learning! [23:47:06] by doing! [23:47:09] we'll get you there [23:47:16] i've certinaly screwed it up many times [23:47:21] :D