[18:08:01] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/22840 [18:28:35] brion: there is a problem with the app in master [18:28:59] when i browse by country, click 'united states' i get no admin levels back - it just takes me straight to a list of monuments [18:29:14] jdlrobson: ^ [18:29:33] mm [18:29:37] hm [18:30:48] mm i'm seeing the same [18:31:01] did someone break the api? [18:31:26] http://wlm.wikimedia.org/api/api.php?action=adminlevels&format=json&uselang=en&admtree=us [18:31:36] compare to france: http://wlm.wikimedia.org/api/api.php?action=adminlevels&format=json&uselang=en&admtree=fr [18:31:58] ruhroh [18:32:05] MaxSem: ^^ [18:33:04] http://wlm.wikimedia.org/api/api.php?action=adminlevels&format=json&admtree=us [18:33:13] {"errors":["Invalid language code ''!"]} [18:33:14] eek [18:33:37] MaxSem: and even with language code, no admin levels come back :( [18:33:43] im seeing the same thing for andorra [18:33:56] did some change get introduced to the api that's causing this? [18:34:05] big breaking change whatever it was [18:34:26] no code changes deployments last week [18:34:35] i smell data changes [18:34:40] MaxSem: data update? [18:35:29] due to a TS breakdown, today's update has failed, however I immediately reverted to yesteerday's data [18:36:47] hmm [18:37:28] both tables look normal ATM [18:37:58] yeah im poking the db now and US monuments all have admin levels assigned [18:38:01] so… wtf [18:39:43] owchie [18:39:46] MaxSem: i thought the api had previously supported not including a uselang? [18:39:54] fixed with rm -f /var/wlm/cache/countries.ser [18:40:23] MaxSem: yeah looks better. so… bad data cache? [18:40:50] awjr, yeah - I forgot to purge language cache when manually reverting the data [18:41:05] MaxSem: phew, glad it was simple :) [18:53:34] jdlrobson, fixed [19:08:25] awjr, lunch? [19:37:29] MaxSem: sorry, had to step out to make some phone calls and picked up a sandwich while i was out [19:38:16] awjr, talked to Asher - there will be no deployment, wheeee [19:38:24] MaxSem: what happened? [19:49:31] New review: awjrichards; "According to Asher, this implementation will cause too much cache fragmentation due to the banner di..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -2; - https://gerrit.wikimedia.org/r/22853 [20:07:35] brion can you merge this real quick? https://github.com/wikimedia/WLMMobile/pull/252 [20:08:13] looking [20:08:38] merged [20:08:46] [WLMMobile] brion pushed 2 new commits to master: http://git.io/lCAqpQ [20:08:46] [WLMMobile/master] Bump version numbers/name for 1.2.3 release - awjrichards [20:08:46] [WLMMobile/master] Merge pull request #252 from awjrichards/1.2.3 - Brion Vibber [20:08:48] huzzah! thanks :D [20:08:56] Project WLMMobile - Nightly builds build #225: SUCCESS in 8.3 sec: https://integration.mediawiki.org/ci/job/WLMMobile%20-%20Nightly%20builds/225/ [20:08:56] awjrichards: Bump version numbers/name for 1.2.3 release [20:10:03] [WLMMobile] awjrichards pushed 1 new commit to commons-upload: http://git.io/u8gl3A [20:10:03] [WLMMobile/commons-upload] Merge branch 'master' into commons-upload - awjrichards [20:10:10] Project WLMMobile - Nightly builds build #226: SUCCESS in 6.4 sec: https://integration.mediawiki.org/ci/job/WLMMobile%20-%20Nightly%20builds/226/ [20:10:10] * s.mazeland: Localisation updates from http://translatewiki.net. [20:10:11] * awjrichards: Bump version numbers/name for 1.2.3 release [20:36:47] MaxSem: things going ok with the deployment so far? [20:37:00] git submodule update [20:37:08] sssslowwwwww [20:37:49] yeahhhh [21:18:27] New patchset: Jdlrobson; "use localstorage instead of cookies for dismissing banners where supported" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/23372 [21:18:28] New patchset: Jdlrobson; "refactor banner code to be generic" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/22853 [21:23:29] New patchset: Jdlrobson; "hide banners targetted for android only" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/23014 [21:24:15] awjr: T^ [22:31:10] New patchset: MaxSem; "Increment cache version after 75a31dd340d35fcd2bff86166af60a30b3b0d683" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/23376 [22:32:44] awjr, please review^^ [22:33:38] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/23376 [22:34:31] thanks [22:35:45] np