[18:43:05] [2012-09-12 19:42:54 - org.wikipedia.wlm.WikiLovesMonuments] /org.wikipedia.wlm.WikiLovesMonuments/gen already exists but is not a source folder. Convert to a source folder or rename it. [18:43:09] ^ Anyone any ideas? [18:53:38] Seems the WLM project has various files not committed... [18:53:39] https://github.com/wikimedia/WLMMobile/pull/253 [18:53:58] Added .gitignore, .project and .classpath [18:55:19] ^ I can actually build and run WLM from eclipse now ;) [18:56:29] "We just broke something we shouldn't have" [18:56:35] ^ You broke the box wifi!? [19:01:12] brion: https://github.com/wikimedia/WLMMobile/pull/253 Can you merge that pull reques tto fixup the WLM project in eclipse? Thanks! [19:01:26] looking [19:03:11] ok that overwrites the .classpath and .project files i already have, lemme make sure they don't explode :D [19:03:33] heh [19:03:40] I'm guessing someone forgot to git add it or something [19:05:11] [WLMMobile] brion pushed 2 new commits to master: http://git.io/06bJ0w [19:05:11] [WLMMobile/master] Add .gitignore with bin and gen - Sam Reed [19:05:11] [WLMMobile/master] Merge pull request #253 from reedy/fixupproject - Brion Vibber [19:05:23] Project WLMMobile - Nightly builds build #227: SUCCESS in 8.5 sec: https://integration.mediawiki.org/ci/job/WLMMobile%20-%20Nightly%20builds/227/ [19:08:33] thanks! [19:29:59] New patchset: Jdlrobson; "hack to limit cookie fallback to only zero rated banners" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/23540 [19:30:00] New patchset: Jdlrobson; "refactor banner code to be generic" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/22853 [19:30:00] New patchset: Jdlrobson; "use localstorage instead of cookies for dismissing banners where supported" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/23372 [19:30:00] New patchset: Jdlrobson; "hide banners targetted for android only" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/23014 [19:34:27] [WikipediaMobile] brion pushed 1 new commit to master: http://git.io/aIvZdg [19:34:27] [WikipediaMobile/master] Escalation path URL for Windows Store stuff - Brion Vibber [19:34:33] Project WikipediaMobile - Nightly builds build #386: FAILURE in 2.5 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/386/ [19:59:38] New patchset: Matthias Mullie; "Refactored some of the code to add CSS/JS to a mobile page. OutputPage has these great methods that use ->mModules to load what's being added. From what I understood, a lot of that _can not_ be loaded in mobile view. The solution was to build an array for" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/23576 [20:06:47] New patchset: MaxSem; "These selectors aren't needed anymore as we don't screen-scrape" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/23578 [20:16:52] [WLMMobile] awjrichards pushed 2 new commits to master: http://git.io/Str9Eg [20:16:52] [WLMMobile/master] Switch from hardcoded message to on-Commons template for the 'upload more' link - Brion Vibber [20:16:52] [WLMMobile/master] Merge pull request #254 from brion/upload-template - Arthur Richards [20:16:59] \o/ [20:16:59] Project WLMMobile - Nightly builds build #228: SUCCESS in 6.3 sec: https://integration.mediawiki.org/ci/job/WLMMobile%20-%20Nightly%20builds/228/ [20:18:23] New review: awjrichards; "looks OK to me with https://gerrit.wikimedia.org/r/#/c/23014/" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/23372 [20:26:23] New review: awjrichards; "Looks OK with https://gerrit.wikimedia.org/r/#/c/23014/" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/23014 [20:46:54] [WLMMobile] brion pushed 2 new commits to master: http://git.io/GsIa5g [20:46:54] [WLMMobile/master] Bumping version numbers for minor release - awjrichards [20:46:54] [WLMMobile/master] Merge pull request #255 from awjrichards/1.2.3-1 - Brion Vibber [20:47:02] Project WLMMobile - Nightly builds build #229: SUCCESS in 7.4 sec: https://integration.mediawiki.org/ci/job/WLMMobile%20-%20Nightly%20builds/229/ [20:55:39] [WLMMobile] awjrichards pushed 1 new commit to commons-upload: http://git.io/UMXlVQ [20:55:39] [WLMMobile/commons-upload] Merge branch 'master' of https://github.com/wikimedia/WLMMobile into commons-upload - awjrichards [20:55:47] Project WLMMobile - Nightly builds build #230: SUCCESS in 7.2 sec: https://integration.mediawiki.org/ci/job/WLMMobile%20-%20Nightly%20builds/230/ [20:56:04] Project WLMMobile - Nightly builds build #231: SUCCESS in 6.8 sec: https://integration.mediawiki.org/ci/job/WLMMobile%20-%20Nightly%20builds/231/ [21:28:47] New patchset: Matthias Mullie; "Refactored some of the code to add CSS/JS to a mobile page. OutputPage has these great methods that use ->mModules to load what's being added. From what I understood, a lot of that _can not_ be loaded in mobile view. The solution was to build an array for" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/23576 [21:38:15] brion, I added a note about having Upload-more-photos-of-this-monument be a mediawiki message instead of a template [21:39:00] Platonides: hm, how so? [21:39:05] it'd be the same result, but I think it fits the semantics better [21:39:17] replace {{Upload-more-photos-of-this-monument}} with [21:39:17] {{int:upload-more-photos-of-this-monument}} ) [21:39:33] in the text provided by the app [21:39:46] the template would have to be moved to mediawiki ns, of course [21:40:04] Platonides: any particular benefit? is this consistent with how things are done on commons? [21:41:09] well, messages are already used at another parts, such as: {{int:filedesc}} [21:41:13] or {{int:license}} [21:41:24] and this is a message, unless I'm missing something [21:41:55] there could be the argument of being able to translate it in translatewiki, although I guess we would start doing it locally, so I'm not sure if that's relevant [21:45:02] Platonides: well i've got no particular opinion. either would work, and if we adopt the message later the template can be changed to use it [21:45:24] since it's not defined in the software you wouldn't get it in translatewiki afaik? [21:46:01] yes, that's why I mentioned that it may not be too relevant right now [21:46:20] hm.. maybe I could add it to Wiki Loves Monuments extension [21:46:33] hmm, could do [21:46:38] it's a mixture of "things useful for WLM" [21:46:57] although I don't know how hard would it be to deploy to commons for getting the msg [21:47:12] easiesr: put it in WikimediaMessages ext [21:47:19] that's already deployed so it'd just need an update :) [21:47:44] that's less in topic, but would work as well [21:49:01] so we go with mediawiki message then? [21:49:30] feel free to swap the template, we've already built a release [21:49:40] we can update for the next one if we're happy with the {{int:}} usage [21:50:03] New patchset: MaxSem; "ohai, Asher!" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/23592 [21:51:40] it'd be better to do it that well from the beginning, before having a bunch of old users adding the deprecated form :P [21:52:23] if you can convince awjr to build another release that's fine, i just don't want to add work for him :) [21:54:15] phone rebooted spontaneously [21:54:25] back on the venue wifi with my fingers crossed [21:54:41] * awjr reads backscroll [22:01:02] is it hard to make a release, awjr? [22:01:35] Platonides: it's not super hard, it's just a pain when you've already finished it and got it ready to go ;) [22:01:43] Platonides: im going to hold off on doing another release now. it's not hard, but it is time consuming [22:02:01] plus making many updates to the app store just creates a lot of churn. [22:02:09] we can have a bot go through and fix all the old items if/when we change (as well as adding the link to earlier photos that don't have it at all) [22:02:13] so no rush to make this change [22:02:25] Platonides: we can plan another app release sometime next week to pick up any other minor bug fixes/changes [22:03:04] ah, it's already at the app store? [22:03:34] the change to wikimedia-messages is at https://gerrit.wikimedia.org/r/#/c/23599/ [22:03:56] Platonides: aye, it went up about an hour ago [22:04:41] New patchset: MaxSem; "Rm old Application_Version: header hack" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/23600 [22:05:04] I was late noticing it :) [22:14:00] New review: awjrichards; "Cookie issues resolved elsewhere (https://gerrit.wikimedia.org/r/#/c/23540/ and associated commits)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/22853 [22:14:09] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/23372 [22:14:10] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/23014 [22:14:10] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/23540 [22:14:11] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/22853 [22:16:06] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/23592 [22:17:29] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/23600 [22:17:53] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/23578 [23:14:20] New patchset: Jdlrobson; "enable dynamic sections" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/23618 [23:15:02] https://gerrit.wikimedia.org/r/23618 [23:15:04] brion ^ [23:16:41] New patchset: Jdlrobson; "enable dynamic sections" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/23618 [23:23:43] New review: Jdlrobson; "Should also disable the sections code from running for special pages and home page" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/23618 [23:50:14] Fatal error: Call to undefined method ExtMobileFrontend::getNotice() in /usr/local/apache/common-local/php-1.20wmf11/extensions/MobileFrontend/skins/SkinMobileBase.php on line 50 [23:58:06] New patchset: Brion VIBBER; "Remove content blocks for all but first section when using beta mode" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/23626 [23:58:59] jdlrobson: ^ [23:59:05] \o/ [23:59:39] i'd rather that we do the header transform within the DOM document, we'll figure out how to do that later :) [23:59:50] or else just make the effing parser give us
s :)