[13:19:53] Awwww, mostly no mobile team [13:19:54] http://lifehacker.com/5947790/goodbrews-tracks-the-beer-you-like-suggests-brews-youd-love [13:23:28] Reedy: who were you looking for? [13:23:40] Tomas/Arthur [13:23:48] I know, faaar too early [13:24:16] yup. Normal folks with normal day schedules [16:18:18] preilly: Do you have a moment to talk about setting up a labs instance to test vumi metrics? [16:19:13] jerith: sure via IRC? [16:19:18] I was thinking we could set it up to use the gtalk transports. [16:19:27] IRC works. [16:19:53] okay that makes sense [16:20:36] Would it be easier to throw away the current labs machine and set up a new one or rebuild the current one? [16:20:50] Also, what should I do about configs? [16:21:28] I've been using the current vumi instance for other stuff [16:21:34] so please don't destroy it [16:21:47] I think that it's easiest to just create a new one [16:21:58] That would also work. [16:22:47] I'm not sure if I have the right permissions to create or destroy labs instances. I certainly don't know how to do it even if I do. :-) [16:24:34] Here's the PR that adds the metrics collection in case you want to forward it to whoever's in charge of such things: https://github.com/praekelt/vumi-wikipedia/pull/19 [16:27:27] jerith: Created instance i-0000047a with image a84558b0-ffaa-4dcd-a020-281b45a87af5 and hostname i-0000047a.pmtpa.wmflabs. [16:27:56] jerith: it's called vumi-metrics and should be live in a few minutes [16:28:03] jerith: you've got root access to it [16:28:14] preilly: Cool. I'm not going to really do anything with it before tomorrow, though. [16:28:45] Where do I edit puppet configs and such for it? [16:30:16] jerith: you can create a local puppet repo on the box [16:31:05] jerith: see https://labsconsole.wikimedia.org/wiki/Help:Self-hosted_puppetmaster for guidance [16:34:06] jerith: so does that make sense to you? [16:34:56] greetings all [16:35:04] preilly: I haven't looked at it in great detail yet, but a quick scan looks reasonable. [16:35:11] i'm offsite today so i'll have haphazard availability [16:36:24] preilly: Has creating that instance set up vumi on it? [16:37:42] preilly: http://www.mediawiki.org/wiki/Wikipedia_over_SMS_%26_USSD/status needs an update. i put in a stub but you'll have more [16:38:10] jerith: no it doesn't have vumi on it yet [16:38:18] jerith: but you could install it via puppet [16:38:27] jerith: we've got the puppet classes for it now [16:38:30] preilly: Cool, thanks. [16:38:34] tfinc: okay [16:54:33] * awjr waves [16:55:23] awjr: let me know if the group has any av issues with the standup. i'm offsite today per my email. [16:55:30] thanks tfinc [17:00:38] hi jdlrobson [17:00:43] jdlrobson: can you help set up for standup? [17:01:08] MaxSem, jdlrobson https://plus.google.com/hangouts/_/76d3b29a25034f77c9f01e94e69384a697c74be7?pqs=1&authuser=1&hl=en [17:02:40] preilly, standup time:) [17:08:31] MaxSem: sit down time! [17:11:38] jdlrobson: can you estimate the login card and put it in 'ready for development'? [17:11:49] yes was planning to grab brion and do that today [17:12:01] as long as brion shows up .. :) [17:12:03] excellent [17:13:25] https://mail.google.com/mail/u/0/#inbox/1365e2ba86216bbe < awjr MaxSem any thoughts on this bug …. personally i want to WONTFIX it but worried I'll cause a s**t storm [17:14:00] I can't read your inbox [17:14:00] jdlrobson: that is a gmail link [17:14:03] haha [17:14:14] feck [17:14:19] https://bugzilla.wikimedia.org/show_bug.cgi?id=34325 [17:14:21] fail [17:16:38] time to apply that tech days talk?:P [17:17:13] well.. the thing that annoys me, is that we've solved the problem MediaWiki:Common.css addresses - in that we have allowed admins to add css to mobile [17:17:51] I don't think MediaWiki:Common.css has mobile in mind so I'd much rather use MediaWiki:Mobile.css until that mindset of 'this css is for desktop' has switched [17:18:19] I also dislike bugs that sit there for ages [17:18:34] (this will) [17:19:37] jdlrobson: yeah there are a few options [17:19:55] 1) mark as fixed using your explanation, making it clear the common.css is not fit for use on mobile devices [17:20:02] i just don't want to have to continuously monitor/battle MediaWiki:Common.css when new changes come in [17:20:06] 2) mark as resolved/later [17:20:13] and carry on the conversation [17:20:17] actually, Common.css can be added with a configuration change now [17:20:20] 3) resolves as wontfix and leave it at that [17:20:51] MaxSem: please elaborate.. although to be clear if that's the case I do not want us to introduce that to the cluster :) [17:21:03] so I'd say that wontfix it and tell the projects who want it to be enabled for them to create requests [17:24:27] MaxSem: what steps are needed to add Common.css ? [17:24:31] is there a link I can point to? [17:25:24] $wgMobileSiteResourceLoaderModule['MediaWiki:Common.css'] = array( 'type' => 'style' ); [17:27:29] thanks :) [17:27:33] MaxSem jdlrobson: https://gerrit.wikimedia.org/r/#/c/25596/ [17:33:00] awjr MaxSem: replied :) [17:33:08] * jdlrobson waits for s**tstorm [17:34:34] my friend, what's so bad about that word that you're censoring it? especially since it's very appropriate in this context [17:34:45] lol [17:36:06] awjr, I left a comment [17:36:41] i don't know .. i'm too british ;-) [17:37:23] you escaped that bloody hell now, lad [17:40:09] * yuvipanda is in a shitty network [17:40:15] but, https://dl.dropbox.com/u/8768784/Wikipedia-v1.3.apk is a 1.3 APK i just built [17:43:56] MaxSem: what is resourceLoaderGetConfigVars()? [17:44:00] i do not see it in MF [17:44:26] https://www.mediawiki.org/wiki/Manual:Hooks/ResourceLoaderGetConfigVars [17:44:35] (sorry, stalkword triggered :) ) [17:44:39] O RLY? https://gerrit.wikimedia.org/r/#/c/25596/4/includes/MobileFrontend.body.php [17:45:02] oops case sensitive search [17:47:24] MaxSem: im not sure we can do it there - unless that hook gets run when a user is in the mobile view? [17:47:48] do you need this variable anywhere else? [17:48:46] MaxSem: it's needed in the mobile view for when a user clicks the desktop view link, and it's needed on the desktop view when the user clicks the mobile view link [17:50:19] I don't see $wgMFStopRedirectCookieHost outside of that function [17:50:42] New review: Jdlrobson; "Please rename unset_stopmobileredierct.js to unset_stopmobileredirect.js" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/25596 [17:50:59] that might be an oversight [17:51:01] lemme see [17:51:17] damn my dyslexic typing [17:52:07] MaxSem: it should be getting used on line 84 or SkinMobile.php although currently it is not [17:55:03] MaxSem: another approach which i think might be more sensible would be to add a method to fetch the cookie host and have SkinMobile and resourceLoaderGetConfigVars() retrieve the correct domain from there [17:59:59] mm still no brion [18:00:57] jdlrobson: i think his # is on the contact list on office wiki if you need him [18:24:27] no one ever got back to me on whether mobile-feeds needs to stay or go [18:24:32] it's been down for a couple months [18:38:44] New patchset: awjrichards; "Addresses bug #38009" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/25596 [18:39:24] jdlrobson, MaxSem ^ [18:40:49] Ryan_Lane: we've not been using mobile-feeds recently due to working on WLM - we'll need a labs instance more now we are back working on the mobile site - although we only need one instance - if not mobile-feeds, some other box… (not sure what we currently have.. i forget) [18:45:03] if it's broken, let it die [18:46:11] jdlrobson, our usual instance is called mobile-testing [18:46:40] ^ Ryan_Lane sounds like it can go [18:46:54] (unless it's used for some other purpose I don't know of) [18:47:32] awjr & preilly ^^ [18:48:21] i dont think i've ever used mobile-feeds, i dont know anything about i [18:48:22] t [18:48:27] ok [18:51:39] New patchset: awjrichards; "Addresses bug #38009" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/25596 [18:51:42] jdlrobson, MaxSem: i've addressed the issues and just added a test for the new method. can you please take a look? ^ [18:53:28] awjr, I wonder if there's a JS-free method [18:53:38] MaxSem: special page [18:53:41] doesn't exist [18:53:42] yet [18:54:42] i.e. link to this page on current wiki, it manipulates the cookies and redirects to the mobile site... [18:55:28] yeah - i like the js approach better but we should have a better non-js fallback. [19:02:03] agreed [19:36:54] jdlrobson, MaxSem: can you merge this if it's ok? i'd like to get it out today: https://gerrit.wikimedia.org/r/#/c/25596/6 [19:38:45] yup [19:38:54] i keep plus 1in it ;-) [19:39:08] heh yeah sorry i added another test right after you did the last itme [19:40:04] awjr: but what if $wgMobileFrontendStopMobileRedirectHostBecauseItIsMondayAfternoonAndILikeKittensAGoodDeal is not set? [19:40:54] then $wgMobileFrontendStopMobileRedirectILikeLongVariableNamesPerhapsBecauseOfMyGermanHeritage will have no effect [19:42:20] ha ha ha [19:43:17] preilly: you've now put that like a boss song in my head [19:43:51] okay, since there are no objections, I'm merging... [19:43:59] jdlrobson: you're welcome [19:44:03] Change merged: MaxSem; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/25596 [19:44:05] MaxSem: any thoughts on https://bugzilla.wikimedia.org/show_bug.cgi?id=40343#c2 ? [19:44:40] thanks MaxSem [19:45:55] mmm, this topic is a neverending source of butthurt [19:47:02] everyone has their own opinion on this [19:47:18] awjr, jdlrobson, MaxSem: http://i.imgur.com/4rA7X.png [19:48:07] that is silly. it already is possible 'to allow individual wiki administartors to specify which classes to remove'... [19:48:38] preilly: lmao [19:48:45] MaxSem: awjr team mobile should either say WONTFIX or fix it [19:48:50] rofl [19:48:53] the bug list is sacred [19:48:58] jdlrobson: i dont understand what's 'broken' [19:49:28] my opinion is that we should be looking at reducing this list and killing it eventually [19:49:53] MaxSem: do you not think there are uses for it? [19:50:23] wgMFRemovableClasses and Mobile.css are not mutually exclusive [19:50:59] I think we could kill wgMFRemovableClasses and just put 'display:none;' on all those elements in Mobile.css [19:51:00] i'll comment and close as invalid [19:51:13] there are, but most of stuff currently present in this is just a workaround for particular WP-related issues [19:51:19] although my gut says it's useful to have wgMFRemovableClasses [19:51:26] just in case we need to strip something urgently [19:51:38] wgMFRemovableClasses is still useful, there may be other css on some other wiki that we can't easily manage in Mobile.css [19:51:56] it's perhaps a bit brute force, but it is still useful [19:52:11] … especially if some javascript runs only when that html is present [19:52:27] yeah [19:52:36] maybe we should add documentation and be done with it [19:53:34] i'm not even sure what 'wmgMFRemovableClasses' is actually removing [19:53:38] and if it is still necessary [19:53:47] grabbing food [20:20:18] derp [20:21:54] blech bad parser behavior [20:22:03] https://www.mediawiki.org/wiki/Extension:MobileFrontend/Deployments/2012-10-01 [20:22:15] the parser seems to think that ' jdlrobson, MaxSem do you guys have any suggestions of a small-ish wiki to enable the new cookie handling code on? [20:41:10] awjr, it's a bug, then [20:41:23] needs to be reported/whatever [20:41:33] MaxSem: already done https://bugzilla.wikimedia.org/show_bug.cgi?id=40670 [20:56:10] MaxSem: https://gerrit.wikimedia.org/r/#/c/25947/1 [20:56:27] jdlrobson, MaxSem: are there any other configuraiton changes needed for today's deployment? [20:56:34] MaxSem: hold off on that change, i need to ammend [20:56:39] none on my part [20:57:23] awjr, WAIT! YOU CAN'T DEPLOY THIS WITHOUT BRION!!1ONEONE [20:57:29] :P [20:57:33] MaxSem: https://gerrit.wikimedia.org/r/#/c/25947/2 [20:57:34] heh [20:57:49] awjr: not that I know of.. [20:57:55] okidoke [20:58:02] is this to wikipedia.org? [20:58:15] jdlrobson: eh? [20:59:01] the deployment? [20:59:10] or to somewhere else? [20:59:24] er well if things look ok on testwiki we'll deploy to the cluster [20:59:30] which includes wikipedia.org [20:59:33] ah ok (confused whether this is just a deployment for cookies or not) [20:59:48] ah sorry, deployement for everything outstanding in MF master [20:59:57] jdlrobson: https://www.mediawiki.org/wiki/Extension:MobileFrontend/Deployments/2012-10-01 [21:00:13] sweet [21:00:16] sorry for confusion [21:00:20] ignore the strikethroughs... [21:00:25] parser bug [21:06:39] New patchset: Jdlrobson; "address the fixme" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/25948 [21:26:16] awjr: https://www.facebook.com/photo.php?fbid=10151272098678623&set=a.10151272098658623.534737.507178622&type=1&theater [21:26:31] yes! [21:30:08] hmmm the base QB Robot Package from anybots only costs $9700 [21:30:20] +$500 for shipping [21:30:43] awjr: it's called fundraising my friend [21:30:59] we could put it on banners [21:32:47] awjr: definitely [21:33:03] awjr: kids could come visit the office just to meet it [21:33:08] hahaha [21:33:14] awjr: just think of all the possibilities [21:33:42] awjr: did you already do the deployment today? [21:34:00] preilly: not yet, everything's ready to go though. i'll start at 3 [21:34:08] awjr: okay sounds good [21:34:26] awjr: it's just php-1.20wmf12 right now right? [21:34:49] preilly: i think 1.21wmf1 also [21:35:12] yah test and mediawiki.org are on 1.21wmf1 but everything else should still be on 1.20wmf12 [21:35:22] yes, 1.21: http://noc.wikimedia.org/conf/highlight.php?file=wikiversions.dat [21:36:13] preilly: i think the anybot would look classier holding a cocktail and smoking a pipe [21:36:48] awjr: ha ha ha [21:40:25] Maryana: is https://mingle.corp.wikimedia.org/projects/mobile/cards/138 ready to go? we should push it into ready for dev if it is [21:41:37] yeah, from a product standpoint. i think the issues that are still unanswered will only be resolved by playing around/prototyping [21:41:39] awjr: can you do me a quick favor? [21:41:47] preilly: sure [21:41:55] awjr: I'd like you to visit http://en.zero.wikipedia.org/?Change-Id:=I7f44ed227f4672f566ba8906ec4529448803b984 and take a screenshot of what you see. [21:42:10] preilly: ok from desktop or should i use a mobile device? [21:42:20] awjr: from desktop is fine [21:43:35] awjr: update- still haven't heard from brion - guess he's on leave today? will try grab him 2mo [21:43:40] [21:44:07] jdlrobson: yeah i dont know what's up with him, i sent him an email this am and still no word. [21:44:28] preilly: sent the screenshot via email [21:46:28] awjr: that will be fixed with your scap [21:46:48] groovy [21:48:37] jdlrobson: you down on 3? [21:49:03] Maryana: yup but i'm coming up to 5 for my massage I'm late! [21:49:15] awjr: you are going to scap right? [21:49:23] preilly: yeah, we have message changes [21:49:35] jdlrobson, heh, ok - lemme know when you guys are in the process of deploying things [21:49:41] so i can test all the things [21:49:45] Maryana: gonna get started in a few minutes [21:49:48] and reject them! >:) [21:49:54] ok, cool beans [21:49:54] noo! [21:50:13] it'll be too late to reject:P [21:50:30] * awjr hands Maryana a rubber stamp [21:50:45] eeeexcellent [22:00:52] awjr: can you try that screenshot again in a few minutes? [22:01:05] preilly: sure [22:01:05] awjr: I'm running sync-l10nupdate-1 1.20wmf12 [22:01:18] preilly: what does that do? i haven't seen that before [22:01:26] does it just refresh the i18n caches? [22:02:26] awjr: yeah you basically do mwscript rebuildLocalisationCache.php --wiki=testwiki --outdir=/home/wikipedia/common/php-1.20wmf12/cache/l10n first then that [22:02:33] oh fancy [22:02:53] preilly: is there any reason not to sync-dir and then do that rather than run scap? [22:02:57] where in this case --wiki=enwiki because it's still running 1.20wmf12 [22:03:15] awjr: scap does a bit of other magic too [22:05:16] * Maryana obsessively refreshes her ios and (stolen) android device... [22:06:47] it's coming - just sorting out some deployment issues with the platform folks [22:11:02] Maryana, jdlrobson, MaxSem ok code should be live on testwiki [22:12:51] hope this is unrelated to the fact that my iphone refuses to redirect me to the beta site just now... [22:13:21] ah, there we go. nm [22:13:52] once you guys give me the goahead, i'll push out the changes to production [22:14:23] awjr: can you take another screenshot for me now? [22:14:34] so, when you say testwiki, do you mean a labs instance…? or..? [22:14:34] preilly: sure - same url? [22:14:39] awjr ^ [22:14:41] Maryana: no, i mean test.wikipedia.org [22:14:54] awjr: basically yes same url but add something else random at the end [22:15:05] k, gotcha [22:15:56] mmm, I don't like how it looks in Opera/desktop [22:16:11] preilly: screenshot sent [22:16:39] awjr: cool thanks, did it show the right IP address for you? [22:17:45] preilly: yep [22:18:18] eh, so that "Ennglish" button is supposed to always hang on the top of every page? [22:19:25] awjr: cool [22:19:33] awjr: can you do one more thing quickly [22:19:41] awjr: can you search for the word India [22:19:47] awjr: and go to that page [22:20:32] want a screenshot? [22:20:53] awjr: yes please [22:21:13] preilly: sent [22:21:54] err, wasn't the "featured" button supposed to become "home"? [22:23:08] jdlrobson: on non-beta - is there supposed to be a button that says 'english' just hanging out at the top of the page? [22:23:52] actually that's happening in beta also [22:24:13] it's on the settings page, too, but grayed out! exciting. [22:24:18] hmm footer is not expanding for me in chrome in beta [22:24:44] ditto safari [22:25:42] and native android browser (4.1) [22:25:47] jdlrobson: ^ [22:32:56] sticky cookies fix seems to work on testwiki \o/ [22:33:21] jdlrobson, Maryana are you guys sorting stuff out IRL? [22:33:36] can't find jdlrobson :( [22:33:44] i think he may be getting a massage [22:33:48] .. [22:34:14] i'm just testing & making a list of bugs. hopefully he'll be done soon... [22:34:14] * awjr slaps jdlrobson [22:34:21] hehe [22:35:17] i can't tell if the lead collapse function is working or not -- all these testwiki "articles" are missing leads [22:35:25] that, or it's definitely not working :-P [22:36:08] it might take an hour to laod but the san francisco article is on testwiki i think [22:36:39] ah, finally got one! [[trang chinh]] [22:36:53] looks good [22:38:58] wtf is up with the 'english' button :( [22:39:42] it's really crazy - i mean, it works… sort of. it does show the different languages that the article is available in if you click on it [22:39:54] but it feels like you're selecting english when you click on it [22:40:03] yeah it is no bueno [22:40:24] it is also showing up in non-beta [22:40:47] preilly: there's a good chance i won't be running scap today, there are a number of issues that we need to fix before pushing to prod. is that going to cause problems for you? [22:41:03] awjr: nope [22:41:14] awjr: I did the l10n update manually [22:41:19] jdlrobson: footer is not expanding on the main page [22:41:27] preilly: ok cool that's what i figured, just wanted to make sure [22:42:13] awjr: I love the html comment around that english button, "" [22:42:20] doh [22:42:29] awjr: it isn't? [22:43:05] awjr: i explained the english button previously - it's until the ribbon is implemented [22:43:20] it's just a placeholder [22:43:25] jdlrobson: it's showing up on non-beta though [22:43:36] that doesn't make any sense.. [22:43:45] on test or live? [22:43:51] test [22:44:19] * jdlrobson looks.. this smells funny [22:44:37] jdlrobson: you down on 3? [22:44:42] yup i am now [22:44:57] k, i am coming down to murder… errr, *talk!* to you [22:44:59] :D [22:45:13] erggg how did that button get into non-bets [22:46:46] grrr im not seeing beta on main page on test, i must be getting a cached non-beta main page [22:47:10] awjr: i'm sending a fix now [22:47:39] so jdlrobson on main page on testwiki, footer does not expand and i do not see the logo, but it seems ok on other pages [22:47:52] ok awjr one at a time - i'll fix the language button first [22:47:56] k [22:48:26] i'm down here w/mr. robson now. will try not to assault him w/fix requests [22:48:51] i have a list of them ready, tho :) [22:50:02] New patchset: Jdlrobson; "only show language button in non-beta" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/25966 [22:50:12] ok awjr that's that one sorted ^ [22:50:31] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/25966 [22:51:54] ok awjr know what's causing the footer problem.. fix on way [22:53:08] cool - the button fix should now be live on testwiki [22:56:08] i don't suppose there are any testwiki pages w/cleanup templates on them... [22:56:16] New patchset: Jdlrobson; "don't break when there are no h1's on a page" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/25968 [22:56:20] awjr: ^ fix for the footer [22:56:57] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/25968 [22:58:28] jdlrobson: ok both fixes should now be live on testwiki [22:59:17] awjr: something very strange going on here.. [22:59:25] show button showing on http://test.m.wikipedia.org/w/index.php?title=Special:MobileOptions&returnto=Main%20Page :-S [22:59:43] eh? [22:59:53] * jdlrobson wishes there was a server running the latest dev version at all time to avoid these sort of problems [23:00:12] To the left of 'Mobile site settings' i see a show button.. do you? [23:00:20] jdlrobson: i am pushing to get betalabs set up to support MobileFrontend which should help :) [23:00:25] it seems some patch I sent for some reason didn't get merge [23:00:29] i do not [23:00:37] awjr: are you on beta? [23:00:53] oh whoops wrong browser [23:00:56] i do see the show button [23:01:36] awjr: i'm looking now.. there's a patch somewhere on my local machine which hasn't got merged for some reason [23:01:43] k [23:01:46] maybe forgot to submit it since i had so many open pull requests at one point [23:04:03] mm awjr might need your help with this.. [23:04:07] what is up? [23:04:30] ohh wait i'm being stupid [23:04:31] one second [23:04:43] im not sure i can help you with that [23:05:22] zing [23:05:30] tehe [23:05:56] Maryana: how are things looking on your end? [23:06:43] i'm ready to accept cards 137 (pending disappearance of that weird "show" button) & 159 [23:07:05] and i have one more bug report: language selector return language is weird [23:07:19] cool how about #113? [23:07:54] I think I might force jdlrobson to drive one of these http://i.imgur.com/BTPC2.jpg [23:07:54] New patchset: Jdlrobson; "add additional check to prevent h1's without .section_heading looking collapsible" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/25970 [23:07:55] New patchset: Jdlrobson; "hide language button on special pages" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/25971 [23:07:56] awjr: a few more fixes ^ [23:08:16] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/25970 [23:08:32] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/25971 [23:10:02] jdlrobson: ok, those fixes should now be on test [23:11:14] i'm all out of bugs. awjr, maxsem? [23:12:09] ehm, we've got a weird language sorting [23:12:15] i still haven't tested watchlist [23:12:38] en: first, then vep:, then the usual sequence, starting with af: [23:13:43] watchlist behaivor seems a little weird [23:13:52] and it appears that my watchlist is not actually updating [23:14:18] oh wait yes it is [23:14:28] the page just hadnt changed in forever [23:15:09] jdlrobson: on android, after i load a page, the search bar in the nav says 'search wikipedia' with the watchlist star [23:15:09] awjr: is this https://gerrit.wikimedia.org/r/#/c/25948/1/javascripts/mf-watchlist.js going to be merged? [23:15:33] jdlrobson: ^^ [23:15:39] preilly: o i hadn't seen that [23:15:44] it could be… no big deal if it isn't [23:15:50] just means people can't watch the home page [23:16:01] awjr: what's the search bar issue? [23:16:06] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/25948 [23:16:15] watchlist! i forgot all about that. how do i log in on this janky thing? [23:16:19] the watchlist star is only in the search box until we have the ribbon [23:16:26] jdlrobson: ah ok [23:16:59] Maryana: log in to test.wikipedia.org [23:17:09] you can also do test.m.wikipedia.org/wiki/Special:UserLogin [23:17:16] doing... [23:18:22] watchlist functionality looks good on android 4.1 and ios [23:18:26] oh ios6 [23:18:34] is there a way i can make my ios simulator use older verisons of ios? [23:19:21] awjr: yes [23:19:28] hardware menu [23:19:35] version [23:19:44] yeah, it only shows ios6 [23:19:46] :( [23:19:48] awjr: i wouldn't worry too much about watch list since it's not super visible at the moment [23:19:56] i'm testing on 5.1 and it works fine [23:20:01] great [23:20:11] and awjr watch icon will move with ribbon design anyway [23:20:27] jdlrobson: for sure, but i want to close out the story if it's done [23:20:40] i see [23:21:40] I've created https://bugzilla.wikimedia.org/40678 - how can it make its way to Mingle? [23:22:03] MaxSem: you can create a card in mingle [23:22:27] MaxSem: better yet, talk to Maryana to explain the issue and she can create a card in the backlog [23:22:36] * Maryana is reading the bug [23:22:55] i'll throw this into mingle, maxsem :) [23:23:04] thanks! [23:23:43] Maryana: i imported the duel masters article and associated templates [23:23:47] http://test.wikipedia.org/wiki/Duel_Masters [23:24:27] ah, sweet, thanks awjr! [23:24:34] ok, are there any issues blocking these changes from going out to production? [23:25:13] production to beta? [23:25:17] i think it's fine [23:25:37] can we start calling it prodbeta vs. prodprod or something? [23:25:38] we should test non-beta too [23:26:13] awjr: testing non-beta is very important [23:26:13] i've been testing non-beta on test, but it would be good if you guys can do a quick run through to make sure nothing's broken [23:26:14] did we do anything for that other than sticky cookies? [23:26:20] preilly: hella. [23:27:28] Maryana, lots of changes by Jon [23:29:36] Maryana: some small stuff; but it's always possible other changes (eg changes supposed to only be in beta) broke smoething on non-beta (eg the language selector button showing up on non-beta earlier) [23:30:58] gotcha. checking now, but i'm not 100% sure what to look for. i think i need to get better about trying to clarify what's going into beta vs. nonbeta in mingle [23:34:05] jdlrobson: do you get the emails sent to 'feedbacktest@wikimedia.org'? [23:35:13] i just checked that out - seems to work [23:35:19] it includes it in the body of the email [23:35:29] so you don't even have to send it out to see if it's working properly [23:35:53] good point :) [23:37:30] im not finding any issues in non-beta [23:37:49] yeah, everything seems groovy [23:37:56] jon is talking to heather about the home icon [23:38:03] jdlrobson, MaxSem, Maryana, preilly: any issues, or shall i push to prod? [23:38:06] eh? icon? [23:38:31] in the left nav - it says "wikipedia" instead of "home," cos the only icon jon could find was the big W [23:38:38] oh [23:38:40] roger thar [23:38:43] derp [23:38:44] roger that [23:38:45] awjr, interwiki sort looks weird but it's a minor issue that we could fix tomorrow [23:39:56] MaxSem: in beta or non-beta too? [23:40:11] yeah, there are some minor language changes (in the lang. selector and cleanup template back functionality) that i'd like to see made, but they're not huge issues [23:40:51] Maryana: ok, if they're not blocking and not bugs, just capture them in story cards [23:41:02] kk, will do [23:41:19] yeah language sort is totally whack. [23:41:20] awjr, non-beta. beta looks broken completely :( [23:42:08] really? it seemed ok for me, but i couldn't find many interwiki'ed articles on test [23:42:12] and I still see the button even though I tried busting cache [23:42:17] use the san francisco article [23:42:33] i do [23:42:42] MaxSem: the button is supposed to appear in beta, but not non-beta; works for me [23:43:05] clear your cache? [23:43:06] :) [23:43:08] the language sort looks the same to meon the SF article in both beta and non-beta [23:43:08] oh, it's normal? ewww [23:43:13] temporarily [23:44:10] Maryana: shall i do it? [23:44:13] yeah - "beta looks broken completely" was a mistake [23:45:29] language sort looks fine to me on both beta and non-beta [23:45:32] for the SF article, anyway [23:46:02] Maryana, it's incorrect - starts with en:, vep:, af: [23:46:39] ohh, i see. sorry, scrolled too fast [23:47:06] it makes sense to have en at the top, though, if that's the language the user was originally on [23:47:33] of course. but vep: is out of the oerder [23:48:08] yeah, weird [23:48:48] should i add that to a new story/task card? [23:49:17] yeah [23:49:20] do we need cards for bugfixes? [23:49:37] I thought we agreed earlier that it's not needed [23:49:45] we should create story cards for new functionality, but not for things that are bugs [23:50:00] which of those would language sort order fall under? [23:50:08] afaik the language list was never spec'd for a particular order, so i think it would be new [23:50:18] k [23:50:34] Maryana: we're running out of time for the deployment, i should either do it now or we should wait til tomorrow [23:50:52] awjr: I vote that you do it now [23:50:53] are you just going to push the stuff that's in the accepted column? [23:51:01] i'd be fine w/that [23:51:19] Maryana: im pushing MobileFrontend in the state that it currently exists on testwiki [23:51:34] ah, ok. yeah, that's fine [23:51:34] which includes the stuff in the accepted and ready for signoff columns [23:51:39] cool doing it now. [23:52:31] hoping somebody tested the WLM deployment fix, cos i don't have an android phone… (i did for a second, but then steven wanted it back. jerk.) [23:53:52] ok, scap is now running [23:54:01] Maryana, we have a cache of Android phones [23:54:06] last time i ran scap it took nearly 30 mins to finish [23:54:14] hopefully it will be faster today. [23:54:21] awjr, for me it was something like 45mins [23:54:26] ugh. [23:55:12] awjr: hopefully it should be faster [23:55:30] * awjr fingers crossed [23:56:03] im going afk for 10mins, if something explodes while im gone gimme a call [23:57:29] nah, everything's cool