[00:10:35] back [00:10:40] scap still going [00:11:44] if i just want to request a minor language change on something, is that a bug or a story/task? [00:12:07] story [00:12:15] or task if it's part of a bigger story [00:12:18] got it [00:15:26] well, the good news is we have LOTS of stories in the next iteration now [00:16:40] whee [00:22:13] maxsem, this work for you? https://mingle.corp.wikimedia.org/projects/mobile/cards/198 [00:22:29] cool [00:22:46] otlichno :) [00:27:04] * awjr slaps scap [00:27:05] go faster [00:27:49] i think we'll need to do clear the varnish cache to pick up the layout changes for beta [00:31:10] you're very slappy today, awjr [00:31:20] well, it's monday [00:31:25] :) [00:31:27] :p [00:40:42] this is nuts, i can't believe scap is still running [00:40:44] it's been nearly an hour [00:41:14] warned ya [00:41:24] sigh. [00:41:33] we need git-deploy [00:41:39] ? [00:58:36] OMG IT'S STILL RUNNING [01:01:25] ok finally done [01:02:57] Maryana, MaxSem if you guys are still alive can you please test in produciton? [01:03:24] sure thing [01:04:31] hmm, today's featured article appears to have been auto-added to my watchlist? [01:05:52] nope. watchlist star's just borked [01:06:27] boo [01:06:39] Maryana: it might've been a caching issue, possibly [01:06:46] i told you guys to test before the varnish caches were cleared [01:06:51] can you replicate the problem now? [01:07:02] the good news is sticky cookies appear to be working right on simple.wikimedia.org! [01:08:08] wow i just looked at the SF weather and it is apparently only 7 degrees cooler there than in tucson... [01:08:19] yeah, i can't get the watchlist start to work at all. lemme check if i'm logged in [01:09:35] nope. no watchlisting [01:09:43] and the star was showing up for me as logged-out [01:10:21] that is no bueno [01:10:39] Maryana: can you file a bugzilla bug and email jon about it? if he can get it fixed we can push it out tomorrow [01:10:50] i do not think it is a big enough deal to roll back the dpeloyment tho [01:11:05] yeah, will do [01:11:26] Maryana: it actually appears to be working for me tho [01:11:40] what? no fair! [01:11:46] when you check your watchlist, are you only looking at reent changes, or all things that are in your watchlist? [01:12:07] oh, i meant it's not adding stuff at all. it just clears my searchbar [01:12:26] on safari ios [01:12:31] oh bummer what device are yo using? it's working for me on android 4.1 [01:12:35] lemme test with ios [01:12:54] k, i gotta run, but i'll be around online later [01:13:31] Maryana: it is working for me in ios6 [01:13:36] wut? hmmm [01:13:45] meh [01:13:45] are my fingers really that bad at punching buttons? [01:13:48] heh [01:13:56] i think things are fine in prod at the moment [01:14:00] bring it up with jon tomorrow am [01:14:02] i'll try some more, but i need food stat [01:14:07] no worries [01:14:28] im gonna go afk but keep paying passive attn to irc/email for the next hour in case there's an explosion and we need to roll back [01:14:38] but things look good to me. [01:14:42] sounds good. me too. catch you later tonight/tomorrow [01:15:03] peace out, d00derz [04:35:12] New patchset: Jdlrobson; "make brandon harris the face of cleanup templates" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/25991 [04:40:40] New patchset: Jdlrobson; "based on feedback from heather w" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/25992 [05:34:25] New patchset: Jdlrobson; "introduce mw-mf-ready event to fire when modules have loaded" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/25994 [05:34:26] New patchset: Jdlrobson; "allow back button escape search menu (bug 39083)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/25995 [12:51:07] yuvipanda: hello, what is up? [12:51:44] wip - http://commons.wikimedia.org/wiki/File:Commons_app_signin_page.png [12:54:35] Commons Logo i s{{CopyrightByWikimedia}} [13:00:08] notnarayan: ^ [13:00:28] I'm unsure what exactly to do in this case, however [13:00:37] so am I [13:00:50] *shrug* move on with a placeholder for now? [13:00:56] Platonides: can we/can't we use the logo? [13:01:05] notnarayan: not without permission, no. [13:01:16] :| [13:01:22] as I said, let's just put in a placeholder there and move on. it's not important for now [13:01:27] i'm sure something can be figured out :) [13:02:22] yes [13:04:45] ill place a placeholder all over the app for now [13:04:54] even in the internal pages [13:05:05] notnarayan: yup [13:05:20] yuvipanda: on the camera share option, if we want to allow for share of commons, well need to use the icon [13:05:31] placeholder now :P [13:05:36] again [13:05:37] it's not [13:05:39] important [13:06:56] [WLMMobile] siebrand pushed 1 new commit to master: http://git.io/C18m1w [13:06:56] [WLMMobile/master] Localisation updates from http://translatewiki.net. - Siebrand Mazeland [13:07:10] Project WLMMobile - Nightly builds build #242: SUCCESS in 12 sec: https://integration.mediawiki.org/ci/job/WLMMobile%20-%20Nightly%20builds/242/ [13:07:11] s.mazeland: Localisation updates from http://translatewiki.net. [13:07:32] Yippie, build fixed! [13:07:32] Project WiktionaryMobile - Nightly builds build #102: FIXED in 8.3 sec: https://integration.mediawiki.org/ci/job/WiktionaryMobile%20-%20Nightly%20builds/102/ [13:07:48] yuvipanda: edited. [13:08:36] [WikipediaMobile] siebrand pushed 1 new commit to master: http://git.io/OVxByQ [13:08:36] [WikipediaMobile/master] Localisation updates from http://translatewiki.net. - Siebrand Mazeland [13:08:57] Project WikipediaMobile - Nightly builds build #393: SUCCESS in 11 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/393/ [17:10:11] New patchset: Jdlrobson; "use table.ambox as the selector" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/26334 [17:11:16] jdlrobson: mornin [17:11:26] you're gonna have to get product (Maryana) to sign off on this one: https://gerrit.wikimedia.org/r/#/c/25991/1 [17:11:28] morning [17:11:36] awjr: sure :) [17:11:42] :) [17:11:49] and probably get brandon to say he's ok with it too :p [17:11:52] also need to check brandon is ok with it [17:11:53] oh dear god no [17:11:56] lol [17:12:06] Maryana: it's the best image ever!! [17:12:08] please let's not stroke brandon's ego any more than we already have [17:12:16] Maryana: are you most concerned about brandon's ego? [17:12:18] oh [17:12:19] yes [17:12:21] yes you are. [17:12:27] Maryana: we can use you if you make a stern face [17:12:38] i want to inject some humor into wikipedia [17:12:42] well, that and what if brandon quits tomorrow or gets run over by a bus or something? [17:12:46] i think there is a maryana pic floating around somewhere from fundraising last year [17:12:49] i don't like the idea of tying stuff like this to one person [17:12:52] heeey! [17:13:30] just put trollface on there [17:14:15] New review: awjrichards; "What is this supposed to do/address, exactly? Please update commit message." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/25992 [17:15:45] New patchset: Jdlrobson; "shrink the size of the toggle arrow to the right of the heading" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/25992 [17:16:43] New review: awjrichards; "______ " [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -2; - https://gerrit.wikimedia.org/r/25991 [17:17:33] awww my cowsay got mangled :( [17:17:35] on a serious note though - i think we should be doing a lot more to make wikipedia mobile hipster/fun [17:17:40] cowsay does not copy/paste very well [17:17:55] if not brandon's face i think we should have something like a first world problem face [17:18:18] jdlrobson: are you suggesting wikipedia grow a mustache and start drinking tallboys of PBR? [17:18:31] as much as i like mobile hipster fun, you gotta remember that not all our readers are white males between the ages of 15-25 [17:18:38] our editors are [17:18:42] but not our readers [17:18:44] Maryana: just the ones that matter [17:18:46] oh [17:18:46] nm [17:18:49] hehehe [17:19:38] jdlrobson: can you give me an example to test this on? https://gerrit.wikimedia.org/r/#/c/25994/ [17:19:58] awjr: the follow up commit [17:20:10] jdlrobson: what followup commit? [17:20:21] https://gerrit.wikimedia.org/r/#/c/25995/ [17:20:41] ahha [17:20:51] oh i see, the dependencies section was closed so i just assumed there were none [17:20:54] hurrrrr? [17:21:40] jorm, stop making our devs have man-crushes on you [17:21:56] don't tell me how to feel about jorm! [17:22:06] i cannot help my manliness. [17:22:16] and we cannot help our mancrushes [17:22:22] and neither, apparently, can the mobile devs. [17:22:53] is it getting weird in here yet? [17:23:14] i just woke up, so there's that. [17:23:22] also, i'm on an island. [17:23:35] but where'd the rum go? [17:25:13] in mah belly. [17:25:32] i'm waiting for stacey to get out of the shower so that i can take one and then we'll go get breakfast. [17:25:51] then some shopping, then i am doing an interview about sopa, and then water. [17:31:32] grrr, so when searching for the edit comments in the database, i can only find ~2400 uploads via the WLM app [17:31:38] where are the other 600? [17:34:02] MaxSem: ^ [17:35:00] https://commons.wikimedia.org/wiki/Category:Uploaded_with_Android_WLM_App [17:35:11] upload summary is localisable [17:35:21] why, BTW? [17:35:52] getting some stats on the people who used the app [17:36:52] was hoping i wouldn't have to resort to the category table & could just use the revision table. guess not :-? [17:36:59] :-/ [17:38:35] Are you guys happy with the number of Mobile uploads? [17:40:18] no [17:40:41] i'm more interested in seeing what kinds of people were using it - new-to-commons, experienced editors from other wikis, etc. [17:42:52] hmm [18:08:30] hi multichill [18:08:36] we were hoping for a lot more [18:08:41] uploads, i mean [18:09:06] but i think it's still a pretty big accomplishment :) [18:17:05] awjr: https://mingle.corp.wikimedia.org/projects/mobile/cards/199 needs estimating by a suitable person [18:19:15] jdlrobson: that should be turned into task and associated with the login story card [18:19:22] it is not a separate a story [18:20:04] the work to complete that task should be accounted for in the estimation of the login card [18:20:17] well it is impossible for me to estimate that awjr [18:20:29] yeah you should not be estimating it on your own :) [18:20:36] the frontend piece alone is an 8 [18:20:49] i don't really like tasks to be honest [18:21:01] at least how they work in mingle [18:21:09] talk to MaxSem [18:21:21] jdlrobson: i cant reallly chat about that right now - we can either talk about it later or during the retrospective [18:22:12] "Unanswered questions [18:22:18] How do we deal with throttling from trolls?" [18:23:02] --There's a shitload of code in Special:Userlogin, and all this is for a reason [18:27:50] yeah, iirc we had talked about relying on the same login infrastructure that MW already provides, which will give us a lot of stuff for free [18:30:21] so, are we still totally blocked on design for login? [18:30:25] or just partially? [18:30:36] i thought brandon sent designs for login? [18:30:42] i thought so, too..? [18:31:00] i think the question is how to cope with the backend work necessary for implementing the login featuer [18:31:01] he did [18:31:02] but i can't remember seeing anything that showed the logged out -> logged in workflow [18:31:32] i did see the login form, but not how someone would get to it, or how the site would look differently upon login [18:31:35] the idea was to put a login link in the nav [18:31:41] and i think that was all. [18:31:42] for now [18:31:44] ah, ok [18:31:47] that works [18:31:59] the card may need to be updated to reflect that [18:32:18] sorry, im juggling a bunch of stuff right now and can't focus O_O [18:32:24] i can take a closer look at those things after lunch [18:32:39] sorry! go do yr stuff [18:32:45] i'll figure it out :) [18:32:52] Maryana: login is not blocked! [18:32:54] it's all there [18:33:02] sweet, ok [18:33:10] http://www.mediawiki.org/wiki/Mobile_design/Sign_in [18:33:13] linked from the story [18:34:11] gotcha. hadn't seen that yet [18:34:13] thx [18:39:57] ok, i updated the mingle card for login frontend: https://mingle.corp.wikimedia.org/projects/mobile/cards/136 [18:56:55] jdlrobson, take a look at includes/templates/Userlogin.php [19:37:55] Project WikipediaMobile - Nightly builds build #394: SUCCESS in 7.5 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/394/ [20:02:08] jdlrobson: yt? [20:02:19] yes with ori-l [20:02:35] when you've got a sec, im ready to chat more about login so we can get moving on it [20:03:42] awjr: fwiw i can't see us fitting that into this iteration now - i'm pretty swamped with responsive images and ribbon discussions [20:04:48] jdlrobson: ok; regardless, we should get the story into shape so it's actionable [20:14:08] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/25994 [20:14:25] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/25995 [20:16:41] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/26334 [20:26:22] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/25992 [20:32:06] [WikipediaMobile] brion pushed 2 new commits to master: http://git.io/Kyn5Mw [20:32:06] [WikipediaMobile/master] Win8: Load the featured picture of the day larger - Brion Vibber [20:32:06] [WikipediaMobile/master] Merge branch 'master' of https://github.com/wikimedia/WikipediaMobile - Brion Vibber [20:32:36] Project WikipediaMobile - Nightly builds build #395: SUCCESS in 7.6 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/395/ [20:35:21] [WikipediaMobile] brion pushed 1 new commit to master: http://git.io/QpdaKA [20:35:22] [WikipediaMobile/master] Win8: load higher-resolution images for featured articles - Brion Vibber [20:35:30] Project WikipediaMobile - Nightly builds build #396: SUCCESS in 7.8 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/396/ [20:42:30] New patchset: Jdlrobson; "use e3 logger to capture javascript 'events'" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/26400 [20:57:46] awjr: https://gerrit.wikimedia.org/r/26402 <-- for login functionality [20:57:59] MaxSem: sweet, i'll take a look shortly [21:19:15] please tell me you guys aren't blocked on design for mobile login? [21:19:23] jorm we aren't [21:19:33] okay good. [21:20:01] jorm: are you officially on vacation or are you working from there? [21:20:14] i am working a couple hours per week. [21:20:27] i am gone for 4 weeks but i have 3 weeks vacation time banked. [21:20:35] ah ok [21:20:37] roger that [21:20:57] jrom: http://xkcd.kajakklubben.org/ [21:24:39] ohman. i've already spent way too much time goofing around on that thing. [21:24:49] heh [21:24:54] it's way more awesome when you can move the dude [21:25:14] i was asking whether or not you guys were blocked so that i know how much time i should devote to mobile login this week. [21:25:34] i think we're all set on login man, i wouldn't sweat it [21:25:47] good good. [21:25:50] we'll ping you if we get stuck, but we've got a good handle. [21:26:22] today, so far, i have eaten a big ass breakfast that wasn't very good, bought a pair of sandals that don't suck, and swam in the ocean. [21:26:29] now i'm on my first beer. [21:26:45] rough life [21:27:06] seriously. [21:27:12] where are you exactly? [21:27:42] a place called Kihei Kai (all the condo places have names) which is at the north tip of Kihei, Maui, Hawaii. [21:27:54] i am the mayor already. [21:27:59] hahahaha [21:28:12] that's like tucson - check in anywhere twice and you own the palce. [21:29:09] yeah. [21:29:09] judging from the satellite imagery, it's hard for me to imagine how you'd have a good time there. [21:30:33] out there in the middle of the pacific, on a little island made up of forest reserves and like 6 roads [21:30:35] looks horrible. [21:34:08] yeah. we're right on the beach. [21:34:11] it's awesome. [21:53:48] MaxSem: im not sure the hook you added for SpecialUserLogin.php is going to give enough flexibility [21:53:54] can't we just use the UserLoginForm hook? [21:54:57] at this point, the template is already initialized by the special page [21:55:20] so were you thinking of hijacking the template object so you could reinstatiate it with some other template? [21:55:47] yes. you can't replace it with a different one at UserLoginForm without losing the data or messing with guts [21:55:55] ok that makes sense [21:55:57] at least, this is my opinion [21:57:01] in principle, $newTemplate->data = $template->data; $template = $newTemplate; [21:57:07] ...is possible [21:57:18] but it looks kind of wrond [21:57:54] i think i agree [21:58:06] i haven't looked at the login code before, so im just trying to wrap my head around this [21:58:16] what you're proposing i think makes sense [21:58:32] take your time,no haste in merging this [22:00:37] awjr: do i need to chat to you about login stuff? [22:02:06] jdlrobson: yeah - i just wanted to make sure what's needed and the story ownership are clear, since we never really dove into the story when we were planning for this iteration [22:03:44] jorm: are you there? [22:03:57] yes, but i'm on the phone. [22:04:58] ok.. when you get a chance jorm could you take a look at http://en.m.wikipedia.org/?mobileaction=beta - click the left nav icon and tell me what the first link (currently saying Wikipedia should say and what the icon should be) - there are discussions about it being 'Home' with a home icon for example [22:05:07] awjr: want to Skype now? [22:05:20] jdlrobson: sure [22:44:30] New patchset: Jdlrobson; "warning triangle icon for cleanup templates" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/26411 [23:05:24] Maryana: got a sec? [23:07:44] [WikipediaMobile] brion pushed 1 new commit to master: http://git.io/zRUxcA [23:07:44] [WikipediaMobile/master] Win8: high-resolution screenshots for store, promo use - Brion Vibber [23:07:56] Project WikipediaMobile - Nightly builds build #397: SUCCESS in 11 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/397/ [23:08:37] hey awjr, what's up? [23:08:50] Maryana: actually, i started writing an email instead - lemme finish and then we can discuss [23:09:31] ok, sure thing [23:14:57] Maryana: mail sent [23:15:13] * Maryana reads [23:18:41] yeah, let's sync up sometime tomorrow, awjr [23:19:14] Maryana: sounds good. i'm relatively free, perhaps we could do it in the morning before lunchtime so we have the afternoon to finish up any card analysis etc [23:20:05] k - i have stats tomorrow morning, but i'll be back in the office by 11 [23:20:40] cool shall we shoot for 11 then? [23:20:48] yeah, let's do it [23:20:54] imma resolve this watchlist card thing right now [23:21:00] bitchin thanks :) [23:21:11] everything else in that email seem reasonable? [23:21:25] and want me to reserve a room for tomorrow? [23:22:23] yeah, it all looks good to me [23:22:41] it's hard to know how to prioritize all these small fixes vis-a-vis each other, but it'll feel really good to get them all out of the way [23:23:15] agreed - i think i have a good enough handle on the stuff to help prioritize it sanely [23:23:16] i think. [23:24:59] word. grab a room if you're already in gcal; otherwise i can make an invite after i add this new watchlist card to mingle [23:26:24] done and done [23:26:34] sweet [23:26:38] be back in a bit gotta go run a quick errand [23:27:01] np, i gotta go check in w/ori now [23:27:01] wheee [23:45:38] [WikipediaMobile] brion pushed 1 new commit to master: http://git.io/3uXBhQ [23:45:38] [WikipediaMobile/master] Win8: scalable SVG remasters of store promotional images - Brion Vibber [23:45:47] Project WikipediaMobile - Nightly builds build #398: SUCCESS in 8.3 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/398/ [23:50:41] Errrrrrr [23:51:04] MobileFrontend/includes/HtmlFormatter.php is creating a lot of PHP warnings in the apache logs [23:51:13] MaxSem: awjr_afk ^ [23:51:52] remind me where these logs are? [23:52:03] PHP Warning: DOMDocument::createElement() [domdocument.createelement]: unterminated entity reference [23:52:24] on fenari they are still at /home/wikipedia/syslog/apache.log [23:52:31] They might be on fluourine too... [23:52:42] fatalmonitor will show you lots of them ;) [23:53:51] at least 61/1000 log lines [23:55:04] dang [23:57:41] wtf [23:57:46] unterminated entity reference y-P_y & z-P_z\\ u_x & u_y & u_z \\ v_x & v_y & v_z\end{vmatrix}=0 => A x +B y +C z + D =0] [23:58:01] where is it unterminated? [23:58:02] yeah that's weird [23:58:35] Looks like it's on math pages.. [23:58:35] quick search shows that people recommend to htmlspecialchars() it, but it's already escaped [23:59:00] not only: Wildwater Kingdom Logo.svg]