[00:00:48] i wonder if it's related to the image replacement [00:00:54] see comments: https://gerrit.wikimedia.org/r/#/c/23648/ [00:02:36] ehm, does it barf at "]"? [00:03:07] i wonder if it's something in the alt text [00:10:11] Reedy: is there any way to determine the originating page of these warnings? [00:12:58] I'm not sure if we surface warnings anywhere else [00:13:30] it would be hard to re-trigger a warning from a mobile page as they are cached [00:13:50] unless we can get our hands on something that is causing the warnings im not sure how to debug [00:14:08] Lets see [00:14:09] but it seems likely that it's related to https://gerrit.wikimedia.org/r/#/c/23648/3 [00:14:10] I see the string [00:14:10] W Magnum hunting load with 500 gr. SP bullet by Hornady. [00:14:13] https://en.wikipedia.org/wiki/.500_S%26W_Magnum [00:14:48] [[Image:500SWHornady01.png|thumb|right|alt=500 S&W Magnum hunting load with 500 gr. SP bullet by Hornady.|500 S&W Magnum hunting load with 500 gr. SP bullet by Hornady.]] [00:15:08] \omega^2 x \\#012F_{g,y} &= - m \omega^2 y.#012\end{align}#012 [00:15:10] ah very nice [00:15:12] dark grey)in the European Union(green) [Legend]] [00:17:45] the smith and wesson article definitely has that image [00:18:00] although it is not appearing in the beta with images off, probably because something broke [00:19:32] is there a bug open for this yet? [00:19:36] Reedy ^ [00:19:41] MaxSem: ^ [00:19:50] I haven't opened one yet [00:20:04] ok i can open one [00:20:33] I do love our error logs [00:20:34] PHP Warning: unlink(/mnt/upload6/wikipedia/commons/1/1a/Errected_Penis.JPG) [function.unlink]: No such file or directory in /usr/local/apache/common-local/php-1.20wmf12 [00:20:35] /includes/filebackend/FSFileBackend.php on line 217 [00:22:32] [WikipediaMobile] brion pushed 1 new commit to master: http://git.io/JHhObw [00:22:32] [WikipediaMobile/master] Win8 store screenshots: swap hub image with "sexier" one with a color image as the featured - Brion Vibber [00:22:44] Project WikipediaMobile - Nightly builds build #399: SUCCESS in 11 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/399/ [00:23:11] jdlrobson: it needs to be the "W" and the "Wikipedia" text *for now*. Who is saying otherwise? [00:23:26] (The reason is we have *zero* branding anywhere in the site. We need to have *some* [00:26:26] New patchset: Jdlrobson; "remove override api hack (bug 39227)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/26431 [00:26:44] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/26431 [00:26:49] Reedy, MaxSem, jdlrobson: https://bugzilla.wikimedia.org/show_bug.cgi?id=40734 [00:28:10] New patchset: Jdlrobson; "remove override parameter from query string" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/26432 [00:29:45] awjr: https://bugzilla.wikimedia.org/show_bug.cgi?id=40734 is because of the & [00:30:17] awjr: "unterminated entity reference" warning happen if the supplied value contains an ampersand [00:30:25] New review: MaxSem; "Having a special title for returning a token is an uber hack. We should move to action=tokens." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -2; - https://gerrit.wikimedia.org/r/26432 [00:30:30] :( [00:30:58] preilly, even if the ampersand is escaped to & ? [00:31:14] awjr: you just need to str_replace("&", "&", $blah); [00:31:29] MaxSem: not in that case [00:31:38] ah php [00:32:19] or htmlspecialchars [00:32:33] preilly, there's no unescaped ampersand in "\Omega \dfrac{dy}{dt} \sin(\varphi)\\#012F_{c,y} &= - 2 m \Omega \dfrac{dx}{dt} \sin(\varphi)#012\end{align}#012" [00:32:57] MaxSem: it might've broken just before that [00:33:15] MaxSem: it sure looks like it to me [00:33:16] #012 & [00:33:32] in this example: Oct 3 00:14:28 10.0.11.55 apache2[9646]: PHP Warning: [00:33:32] DOMDocument::createElement() [ href='domdocument.createelement'>domdocument.createelement]: unterminated [00:33:32] entity reference W Magnum hunting load with 500 gr. SP bullet by Hornady.] in [00:33:34] it is url encoding the error message [00:33:44] there is a 'S&' in front of the 'W Magnum' in the actual alt text for the image [00:34:16] yeah this is a really simple fix [00:34:31] just str_replace("&", "&", $blah); it [00:35:40] htmlentities should do it too [00:36:30] well I'd prefer preg_replace('/&(?!\w+;)/', '&', $value); [00:36:38] no reason to over encode [00:37:19] also worth noting this is all covered in PHP Bug #36795 Inappropriate "unterminated entity reference" in DOMElement->setAttribute [00:37:22] htmlentities should be faster, no? [00:38:09] htmlspecialchars would be [00:38:43] and it has double_encode support too [00:39:03] e.g., when double_encode is turned off PHP will not encode existing html entities, the default is to convert everything... [00:40:17] we don't need full entity translation, just certain characters have special significance in HTML, and should be represented by HTML entities if they are to preserve their meanings. [00:41:16] awjr: are you going to code and push a fix? [00:41:24] no [00:41:28] at least not right now, im in the middle of something else [00:41:53] MaxSem: can you code a fix for this issue as we don't want to log spam with PHP Warning messages [00:42:41] i have to take off in a few minutes as well - i think pushing a fix is going to have to wait until tomorrow [00:42:55] too late for me, sorry [00:43:26] MaxSem: can you tackle it when you start your day tomorrow? [00:43:37] sure [00:43:42] awjr: I'll just do it [00:43:46] good night [00:43:47] MaxSem: don't worry about it [00:43:47] thanks preilly [00:47:43] New patchset: preilly; "fix for inappropriate "unterminated entity reference" in DOMElement" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/26436 [00:47:43] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/26436 [00:48:19] i gotta run -thanks for taking care of that fix preilly [00:49:27] awjr: np [00:59:06] jdlrobson: can you check out en.wiki [00:59:14] jdlrobson: I just pushed the changes [01:00:14] sure [01:00:20] jdlrobson: thanks [01:01:00] jdlrobson: everything looks fine to me and the bug is now fixed in the logs [01:02:12] preilly: wfm [01:06:37] jdlrobson: okay cool [01:06:42] jdlrobson: thanks for confirming for me [07:55:50] yuvipanda: you up for running some WLM stats for me ? [08:13:08] * tfinc yawns [08:17:13] MaxSem: whats the best way of finding out how many http://commons.wikimedia.org/wiki/Category:Uploaded_with_Android_WLM_App are from new accounts ? i'm looking through the api but nothing is jumping out at me [08:21:48] what's the criteria of newness? [08:24:02] 1) account doesn't exist [08:24:08] 2) account created at wlm start [08:31:04] tfinc: yo [08:32:11] My mandatory daily hours of power blackout about to start now, and I won't have power for about 2 hours from now. [08:32:41] but I'm guessing we can use use user_registration field on user to figure this one out [08:32:52] shouldn't be too complex - I can do it later if MaxSem doesn't want to take it on [08:33:01] tfinc: ^ [08:33:15] Im' writing a SQL query [08:33:28] sweete then :) [08:34:20] select distinct(user_name) from categorylinks, page, image, user where cl_to='Uploaded_with_Android_WLM_App' and cl_from=page_id and page_title=img_name and img_user=user_id and user_registration>'20120900000000'; [08:34:34] 408 rows in set [08:34:55] tfinc, ^^ [08:35:42] amazingly, the total number of uploaders is 552 - so most of them are new [08:43:01] ok. next stat. out of the mobile images how many have been added to articles [16:23:58] greetings [16:24:15] MaxSem: did you manage to run my second stats question ? " out of the mobile images how many have been added to articles" [16:24:53] you disappeared [16:24:58] lemme look it up [16:25:25] yeah, i was exhausted and passed out [16:26:16] i'm putting my notes for it here http://etherpad.wikimedia.org/OctoberMetricsAgenda [16:30:47] select count(*) from categorylinks left join page on cl_from=page_id left join globalimagelinks on page_title=gil_to where cl_to='Uploaded_with_Android_WLM_App'; [16:30:53] 3619 [16:31:18] brr, wrong [16:32:23] that can't be right. that's more images then we have in total [16:33:02] select count(distinct(cl_from)) from categorylinks left join page on cl_from=page_id left join globalimagelinks on page_title=gil_to where cl_to='Uploaded_with_Android_WLM_App' and gil_to is not null; [16:33:07] 902 [16:33:33] more believable:) [16:33:40] thats surprisingly high and quick [16:33:52] pass me a couple of pages that are using our images [16:34:09] from that 902 can we find out how many are new articles ? [16:34:23] i think its also very telling that we use sql rather then the api for this [16:34:29] mmm, not with pure SQL [16:36:15] fail: https://commons.wikimedia.org/wiki/File:Water_Tower_Place_mall.jpg [16:36:30] used on a registry page:P [16:36:49] which page is it on? [16:37:02] https://en.wikipedia.org/wiki/Wikipedia:WikiProject_National_Register_of_Historic_Places/Images_without_refnum hmm [16:37:29] can we refine the 902 to *just* articles ? [16:37:33] 708 if count only mainspace usage [16:37:45] select count(distinct(cl_from)) from categorylinks left join page on cl_from=page_id left join globalimagelinks on page_title=gil_to where cl_to='Uploaded_with_Android_WLM_App' and gil_to is not null and gil_page_namespace_id=0; [16:37:47] pass me couple of those [16:37:56] and thanks for running these for me [16:38:02] i'll be using some of them for the metrics talk tomorrow [16:38:42] ayeeee https://en.wikipedia.org/wiki/National_Register_of_Historic_Places_listings_in_Pima_County,_Arizona [16:39:33] hmm ok [16:39:45] and https://nl.wikipedia.org/wiki/Lijst_van_rijksmonumenten_in_Bunnik_(plaats) [16:39:54] we're losing this battle:P [16:40:04] * PowerlessPanda looks around [16:40:44] okay, first real article usage: https://commons.wikimedia.org/wiki/File:Harney_Peak_Hotel_(taken_on_30Aug2012_14hrs15mins48secs).jpg [16:40:46] yeah, it'd be fun to have a handful of articles and not just collections for our images [16:41:01] https://en.wikipedia.org/wiki/Hill_City,_South_Dakota .. nice [16:41:23] https://commons.wikimedia.org/wiki/File:Elizabeth_Cady_Stanton_House_2012-07-31_15-43-27.jpg [16:42:24] https://commons.wikimedia.org/wiki/File:Dyrhøj_Bakker_2012-09-05_12-48-16.jpg [16:43:49] last one is another list [16:43:56] https://commons.wikimedia.org/wiki/File:Resaca_De_La_Palma_Battlefield_2012-09-04_11-05-42.jpg is nice, but not used in a real article [16:44:55] yes. it may be too early but out of the gate were mostly in national historic listings [16:45:04] but is fun but i like articles better [16:45:09] main space articles that is [16:45:59] https://commons.wikimedia.org/wiki/File:Vesterhus_2012-09-04_13-45-33.jpg [16:47:00] https://commons.wikimedia.org/wiki/File:De_Witt_Park_Historic_District_2012-09-02_18-13-33.jpg [16:47:32] thats enough for me to work off of [16:47:43] tfinc: WIP mocks for the commons app https://minus.com/mbnLPhuSAou2lO [16:48:34] PowerlessPanda: shoot me an email with the link. i'm already juggling two things that require my active attention [16:48:42] better yet mail it to mobile-l [16:48:58] yup will do tomorrow when it's done. [16:57:23] does somebody need to set up the hangout on our end? [16:57:32] brion: good morning [16:57:34] yes please :) [16:57:40] brion are you feeling better? [16:57:54] much, thanks [16:58:47] brion, MaxSem: https://plus.google.com/hangouts/_/58014f6a15d7315af150305ac7109f7c9967337a?pqs=1&authuser=1&hl=en [17:08:27] MaxSem: how would we do a geographic breakdown of the images? I'm eager to see if there are targeted areas where we have lots of use [17:08:51] overall i'm thinking more and about how to be more tactical about reaching 1000 uploads a month [17:09:27] PowerlessPanda: i may use some of your mockups during tomorrows metrics meeting [17:09:36] hi, i was tryng to configure pt.wikinews mainpage for the mobile, but adding
to a section, it didn't worked, i simpy got redirected to pt.m.pt.m.wikinews.org (yes, two times pt.m).. What am i doing wrong? diff: http://pt.wikinews.org/w/index.php?title=P%C3%A1gina_principal&diff=prev&oldid=162794 [17:11:33] hey guys sorry [17:14:13] tfinc, definitely not sqlable [17:14:27] how could we find it out then ? [17:14:34] hi jdlrobson [17:14:35] we have the WLM campaign info within the article [17:14:36] no worries, it happens [17:17:03] hmm [17:29:17] tfinc: could you please check? ^ [17:32:09] tfinc: sweeet :) [17:32:33] tfinc: narayan might give me slightly better mocks tomorrow, i'll email you if I get any [17:32:46] hey Alchimista [17:32:52] tfinc: these aren't on commons because, as Platonides mentioned, the commons logo is copyrighted and hence they'll probably be a copyright violation :D [17:33:04] Alchimista: i can't take a look now but perhaps awjr, jdlrobson , or PowerlessPanda could take a look for you [17:33:11] PowerlessPanda: the name is Shankar. Hi :) [17:33:22] thanks PowerlessPanda [17:33:24] hey notnarayan [17:33:39] oh hai notnarayan [17:33:46] Alchimista: what's the issue? I missed the original conversation [17:33:48] I didn't notice you :P [17:34:26] hi jdlrobson, i'm tryng to set up the mobile front page. check the diff: http://pt.wikinews.org/w/index.php?title=P%C3%A1gina_principal&diff=prev&oldid=162794 [17:34:38] ahh this thing :) [17:35:15] i've added that div like the info page says, but then when i got on pt.m...., i was redirected to pt.m.pt.m... with a blanked page :s [17:35:24] brion: reason for tables not scrolling is line 730 of app.css [17:35:32] whee [17:35:44] it's explicitly disabled with a comment from jdlrobson [17:35:46] i believe it should be
[17:35:57] i'm not sure it will like the ú character [17:36:18] notnarayan: are you working on the mocks? tfinc says he might use them in the WMF-wide Metrics meeting tomorrow! [17:37:06] actually Alchimista it might just be the ú character [17:37:10] replace it with a u [17:37:17] it should indeed have the mf- prefix [17:37:50] i'm checking it.. [17:38:17] nops -> pt.m.wikinews.org [17:39:23] New patchset: Jdlrobson; "pull e3 logging into mobile to log to an endpoint" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/26484 [17:39:23] New patchset: Jdlrobson; "start logging to an array to capture javascript 'events'" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/26400 [17:39:36] Alchimista: best place to start is wrap the entire thing with it [17:40:22] jdlrobson: what will happen with those changes if the event logging system is not in place? [17:40:31] awjr: one second [17:40:47] brion: I'm on the changes in the mail. Pull requests in a sec [17:40:54] excellent [17:40:59] Alchimista: mp-ultimas should be mf-ultimas sorry for confusion [17:41:14] heatherw: you about? wanted to check something on icon assets for the left menu [17:41:19] Alchimista: also it's in a table [17:41:26] so actually the table needs this class [17:41:36] * so actually the table needs this id [17:42:21] dear someone, the computer told me you wrote something but my eyes are dilated and i can't read it so i hope it's not important [17:42:42] id = mp-ultimas ? or do i need to change the css? [17:42:50] awjr: https://gerrit.wikimedia.org/r/26400 is harmless - it just logs to the console giving us a way to measure performance manually [17:43:18] the id should be mf-ultimas [17:43:25] on the class [17:43:36] but [17:43:43] it should be applied to class="MainPageBG" [17:44:01] i'd suggest replacing class="MainPageBG" with class="MainPageBG" id="mf-home" [17:44:31] heatherw: i'll ask later when your eyes can see :) [17:44:34] Alchimista: that will get you rendering something on mobile we can then optimize it [17:45:30] awjr: merging https://gerrit.wikimedia.org/r/26484 needs the event logging system - i'm not sure what will happen if not in place would have to ask ori-l [17:45:40] Now it's showing all the table, but not the links on last news ({{Últimas notícias}}) [17:45:40] i'm guessing 404s maybe [17:45:45] Alchimista: this is good [17:46:17] never mind, i left the div. i've removed and it now shows [17:46:51] so i'm not sure why Últimas notícias is empty - MaxSem any ideas? [17:47:19] ok Alchimista - is that how you want your home page? [17:47:25] just refresh the page, i've removed the div and it worked [17:47:28] perfect [17:47:43] well, for now it's better, but how can i remove some sections? [17:47:51] So Alchimista to do that add the class nomobile [17:47:55] jdlrobson: looking over the code it looks like it would probably be OK, there would jsut be no backend for tracking the data [17:47:56] (i think that's the right one) [17:48:34] class="nomobile" [17:48:51] jdlrobson: the image that gets loaded from bits exists, so i do not think it would cause any problems [17:49:22] jdlrobson: on the sections i don't want to be shown? [17:50:01] jdlrobson: yeah i think it'll just give a 404 and not track anything if the endpoint isn't in place [17:50:18] whee [17:50:41] please please please make this disableable and disabled by default [17:51:06] it is in the beta mode only, but beta mode can be enabled on non-wmf sites as well [17:51:10] so it would be nice to have a config switch [17:51:20] Alchimista: correct add 'nomobile' on the sections you don't want to show [17:51:31] brion: feel free to add - i'm never sure how to do these things [17:51:37] i'll take a peek [17:51:46] * jdlrobson does far too much php [17:52:34] jdlrobson: thanks for the help [17:53:37] hm… https://gerrit.wikimedia.org/r/#/c/26484/ loads up the event logger interface but i don't see it actually logging anything. what pushes into the event log that it uses? is that a separate changeset? [17:56:41] brion: https://gerrit.wikimedia.org/r/#/c/26400/2 [17:57:30] perfect time to not detect my device, os x. perfect timing [17:57:36] no problem Alchimista [17:57:38] awjr: we found it thx :D [18:00:30] awjr - i'm going to very quickly give my standup item to the e3 team, & then we can skype? [18:00:40] brion: since you're picking up login; take a look at this: https://gerrit.wikimedia.org/r/#/c/26402/ i should be available later this afternoon to help out [18:00:43] Maryana: sounds good [18:00:53] Maryana: im gonna make some coffee then, ping me when you're ready [18:00:53] excellent [18:00:55] sweet - should only take 5 min max [18:00:57] kk [18:07:40] New patchset: Brion VIBBER; "start logging to an array to capture javascript 'events'" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/26400 [18:07:40] New patchset: Brion VIBBER; "pull e3 logging into mobile to log to an endpoint" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/26484 [18:09:13] ok, awjr, ready(ish)? [18:09:19] what's your skype handle? [18:10:51] Maryana: see pm [18:12:41] jdlrobson: https://gerrit.wikimedia.org/r/#/c/26484/ <- modified with a quick config switch [18:14:49] New patchset: Jdlrobson; "add login to left menu and login page styling" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/26492 [18:15:01] https://gerrit.wikimedia.org/r/26492 < brion [18:28:38] brion: https://github.com/wikimedia/WikipediaMobile/pull/285 [18:30:14] PowerlessPanda: i think you can take out the {{Identical|Normal}} bits [18:30:16] from the qqqs [18:31:24] yeah I'm unsure why they were put in in the first place [18:31:43] i think because the old descriptions were all the same and it annoyed the translatewiki guys :) [18:31:48] ah :D [18:31:59] brion: +1 to getting rid of the 'smaller' size? [18:32:06] agreed [18:32:12] nobody wants the text smaller than it already is [18:32:16] unless… they're crazy [18:32:47] or.. they have a really small device? [18:33:50] like a wristwatch android? [18:34:35] brion: like http://www.flipkart.com/samsung-galaxy-y-s5360-mobile-phone/p/itmd2pz2rpcg5smz [18:34:38] 320x240 [18:34:40] very popular here [18:34:53] similar specs to my earlier phone :) [18:36:17] yeah, though the ldpi setting should make the base font smaller in pixels to begin with [18:36:26] how's the app look on your old phone these days anyway? [18:36:27] ah, right [18:36:39] it kicked the bucket about 2 months ago. [18:36:48] aww [18:38:13] what is the exchange rate, like 50 rupees to the dollar? reminds me i gotta be ready for that trip next month [18:39:40] brion: it's reasonably fluctuating, but that's an easy-to-remember benchmark [18:39:48] 52 right now [18:39:55] was 55 a couple weeks back [18:40:03] was 45 a few months back [18:42:08] jdlrobson: ok modified https://gerrit.wikimedia.org/r/#/c/24115/ per your notes [18:42:30] brion broken tests1 [18:42:40] say waaaaaaaat [18:42:52] i think gerrit just faield [18:43:03] but it's claiming do not submit [18:43:04] 'Automatic merge failed; fix conflicts and then commit the result.' [18:43:11] bah i'll rebase and merge [18:45:28] jdlrobson: do you have a minute to help me with an issue [18:47:49] hey notnarayan_ [18:48:04] yes PowerlessPanda [18:48:26] preilly: i have 10 mins [18:49:02] notnarayan_: how're the mocks? [18:49:21] should be in your inbox by now :) [18:49:57] * PowerlessPanda peeks [18:50:33] notnarayan_: move the autocomplete dropdown so that it is exactly under the cursor, and the cursor is exactly next to the last typed word and i think we're mostly good :) [18:52:45] PowerlessPanda: the drop is under the cursor ' | ' or under the latter 't' [18:53:03] over the letter 't' [18:54:51] notnarayan: under | [18:55:59] https://gerrit.wikimedia.org/r/#/c/24115/ build successfully \o/ [18:56:02] notnarayan: exactly like how gmail app does it [18:56:05] you really need a phone :P [18:56:27] PowerlessPanda: will get one in november [18:56:54] notnarayan: sweet [18:57:40] jdlrobson: looking at https://gerrit.wikimedia.org/r/#/c/26492/ … this is meant to be an overlay that's on every page and only switched in when we need it? or will we go to the special page and override its display? [18:59:04] preilly: Language::factory( $code ) [19:06:22] [WikipediaMobile] brion pushed 3 new commits to master: http://git.io/nDwozw [19:06:22] [WikipediaMobile/master] Added more font size choices - YuviPanda [19:06:22] [WikipediaMobile/master] Remove Font Size labels - YuviPanda [19:06:22] [WikipediaMobile/master] Merge pull request #285 from yuvipanda/more-font-sizes - Brion Vibber [19:06:32] Project WikipediaMobile - Nightly builds build #400: SUCCESS in 8.7 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/400/ [19:06:43] one down! [19:06:47] debugging the other [19:11:52] jdlrobson, you around? [19:11:58] ^^ [19:14:32] ^^ [19:14:41] heeey [19:14:45] you got your e3 in my mobile [19:15:51] New patchset: preilly; "add font-family for ZeroRatedMobileAccess banner" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/26497 [19:16:10] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/26497 [19:23:20] tfinc, my query timed out when I tried to collect geographical information:P [19:46:48] MaxSem: client side or server side timeout [19:46:49] ? [19:47:28] server, I assume [19:47:34] even with slow sql turned on? [19:47:56] sql server [19:48:18] after *one hour* %) [19:48:22] tfinc: I just wanted to make sure that if you're talking to Howie / Maryana / Design cabal about mobile uploads, you keep the work me and notnarayan are doing in Mind. We want it to be the official uploader, not just 'this thing that volunteers built' [19:49:05] * Maryana keeps it in mind  [19:49:10] :D [19:49:38] Maryana: but you haven't even seen the mocks! [19:50:14] are they onwiki somewhere? [19:50:54] Maryana: https://minus.com/mbaEUFkymuRlWU I'm hesitant about putting them in commons since they contain copyrighted material (the Commons logo :P) [19:51:38] Maryana: mediawiki.org/wiki/Commons_Mobile_upload_app has the use case we're building the first release for [19:52:09] you can just blur out the logo in photoshop or add the appropriate tag (i think it's something like {{wikipedia|logo=yes}}) [19:52:26] anyway, cool, thanks for the heads up :) [19:52:49] Maryana: ah, i'll check out the tag [19:52:55] mucho thanks :) [19:56:04] {{CopyrightByWikimedia}} [19:56:36] MaxSem: thanks! [19:58:57] awjr, you wanted to talk about login? [19:59:13] MaxSem: yep [19:59:41] MaxSem: what are the other backend-related steps that need to be taken to support login? [20:00:29] write a mobile-specific template and insert it instead of the normal template [20:01:19] MaxSem: ok cool - is there anything else? [20:01:35] at a glance, no [20:01:41] gerat, thanks [20:04:55] now, jon started on https://gerrit.wikimedia.org/r/#/c/26492/ which appears to start adding a login screen overlay, not sure if we want to go in that direction or using the special page? [20:05:47] I remember overlay based logins having some sort of security issue when they were discussed for the desktop about a year or so back? [20:06:29] well, one issue is that any site JS can do stuff like listen for your password [20:06:41] how would that overlay login interact with other login hooks? [20:06:43] another is simply that the form isn't on SSL if you're on non-SSL [20:07:39] brion my feeling is that we should not do an overlay login right now; it would be nice to be able to support login for non-js off the bat [20:07:53] *nod* [20:08:15] down the line though it could be really sweet [20:08:22] are we going to support post-login activities for non-js? [20:08:39] i dont see why not [20:09:00] you mean like logging you everywhere? [20:09:12] I think that would be the expected behavior [20:09:14] if we want to support watch list on non-js we'll need to change how we do it [20:09:21] but i think for performance we'd want to make some changes anyway [20:09:34] currently we make a lot of api calls to the server [20:09:57] there are other watchlist-related activities we could do that won't might not require js, like viewing diffs, reverting, etc [20:10:40] we can show the watch list and let you click on diffs without js probably [20:10:51] yeah [20:10:55] though it'll probably not be fully as fancy [20:11:21] true that; i dunno brion what are your thoughts about overlay login? [20:12:50] i don't like overlay login; it can also have trouble with browsers' 'save password' settings in that they don't always trigger on them [20:12:57] one of my peeves about gerrit ;) [20:13:27] that makes sense [20:13:58] yeah - plus the designs we have from brandon are non-overlay and i imagine implementation will be easier than getting overlay right across devices [20:15:22] ^ +1 [20:16:45] jdlrobson: any thoughts? I think you're at lunch or something :) [20:16:55] while we are talking about login screens, was something ever done with the "centralauth login hole"? [20:17:05] hole doesn't sound good [20:17:09] facebooks sez mr. robson was out late karaoke-ing [20:17:11] ! [20:17:14] this is why you don't add your coworkers on fb [20:17:21] >:) [20:17:25] Maryana: i think he might've been with coworkers though :p [20:17:33] hehe [20:17:40] we're a crack team of professionals here [20:18:01] as long as we're not smoking crack [20:18:06] stay out of the tenderloin! [20:18:20] Platonides: what was this hole? [20:18:21] hey brion, can i get you to look at a mingle card for me & maybe jot down some story details? [20:18:26] sure [20:18:27] (also, yes, crack is whack) [20:18:33] https://mingle.corp.wikimedia.org/projects/mobile/cards/195 [20:19:01] brion, this is a logged channel [20:19:03] I explain in PM [20:19:10] ok [20:20:05] that big a hole? [20:20:18] Maryana: generically i'd say something like… "As a user, I can download the latest version of the app, so that it works" but it might be nice to call out some of the improvements by name there. I forget what all is different at this point [20:20:57] ok [20:21:03] jdlrobson yt? [20:21:08] if you can think of any technical dependencies, lemme know or drop em in the card [20:21:13] brion: note that whatever I said applies to Android only [20:21:16] munaf: no, not yet... [20:21:20] brb [20:21:35] brion: also, i did the 'merge branch, write changelog, sign' bit and mailed out a version to mobile-tech :) [20:26:23] New review: awjrichards; "Wait... that's no triangle!" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/26411 [20:27:44] hehe "Personally I still think Brandon Harris with his arms crossed seems like a [20:27:44] better way of saying an article needs work. ;-)" [20:28:22] ok i've got to eat some lunches [20:28:25] i shall return [20:41:13] sorry just catching up [20:42:04] Maryana: brion ^ [20:42:40] i was catching up with some old friends visiting from France [20:43:38] yo dawg. couple of things for you to check in on - munaf is writing up some design specs for the visual changes he proposed for next iteration [20:44:16] which i assume he will deliver to you via some shared interweb medium, as he's working remotely this week [20:44:27] New patchset: Jdlrobson; "exclamation icon for cleanup templates" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/26411 [20:44:51] jdlrobson ^ [20:45:05] also, i merged your opera mini story card w/ this one: https://mingle.corp.wikimedia.org/projects/mobile/cards/119 [20:45:14] lmk if that works [20:45:56] ok Maryana not sure what 'visual changes' you are referring to but ok. [20:46:46] munaf will be able to explain better than me [20:47:02] Maryana: that card looks fine.. [20:47:08] typeface, color, sizing, spacing [20:47:19] putting it all in an etherpad now jdlrobson [20:47:32] jdlrobson: sweet [20:50:16] ehm, what should I fill in my Indian visa application? visa type: conference, I guess? [20:50:33] New patchset: Jdlrobson; "start logging to an array to capture javascript 'events'" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/26400 [20:50:33] New patchset: Jdlrobson; "pull e3 logging into mobile to log to an endpoint" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/26484 [20:53:17] New review: Jdlrobson; "seem to have committed something weird... a" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/26400 [20:55:41] anyone? [20:55:41] New patchset: Jdlrobson; "start logging to an array to capture javascript 'events'" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/26400 [20:57:53] I have no idea, MaxSem [20:58:07] Platonides, are you coming? [20:58:12] no [21:03:36] [WikipediaMobile] preillyme pushed 2 new commits to master: http://git.io/kq1MoQ [21:03:36] [WikipediaMobile/master] bug 40256: make app run natively on iPhone 5 4" screen - Brion Vibber [21:03:36] [WikipediaMobile/master] Merge pull request #283 from brion/iphone5 - Patrick Reilly [21:03:46] Project WikipediaMobile - Nightly builds build #401: SUCCESS in 7.9 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/401/ [21:03:46] Brion VIBBER: bug 40256: make app run natively on iPhone 5 4" screen [21:14:11] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/26411 [21:17:04] hey brion. The v1.3-Android branch has a CHANGELOG [21:17:08] yay [21:17:21] the biggest change is 'dynamic sections' [21:17:26] load lead first, then load everything else [21:17:43] brion: the branch is on my repo [21:18:04] other than that everything else is *very* minor [21:18:18] IIRC I floated the idea of doing this upgrade in Wikimania itself :P [21:20:47] New review: Brion VIBBER; "Still needs subsequent commit (where'd it go?) to make the event logging optional..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 2; - https://gerrit.wikimedia.org/r/26400 [21:20:47] Change merged: Brion VIBBER; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/26400 [21:21:08] there was a follow-up, where'd it get to... [21:21:55] aha https://gerrit.wikimedia.org/r/#/c/26484/ [21:22:03] urhg gonna have to rebase [21:22:52] New patchset: Reedy; "pull e3 logging into mobile to log to an endpoint" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/26484 [21:23:03] button ftw ;) [21:23:31] but… it's missing some bits [21:23:49] jdlrobson: we lost some pieces from https://gerrit.wikimedia.org/r/#/c/26484/ ? [21:23:55] did those get moved somewhere else? [21:24:02] for making the data collection optional [21:24:13] patch 2 has 16 more lines... [21:24:45] ergg [21:24:52] must have pushed it along with my fixes to the other one [21:24:52] sorry [21:25:01] patch set 2 looks like the one we want [21:25:24] and wait [21:25:25] that's no good [21:25:28] hmm [21:26:49] coming over [21:29:20] ok we're gonna fix it :) [21:36:02] New patchset: Brion VIBBER; "pull e3 logging into mobile to log to an endpoint" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/26484 [21:36:11] jdlrobson: what do you think of that? [21:38:31] looks good to me brion [21:38:36] whee [21:38:42] just a note it doesn't need jquery [21:39:06] what does 'use strict'; do? [21:39:07] :P [21:39:24] MaxSem: https://developer.mozilla.org/en-US/docs/JavaScript/Reference/Functions_and_function_scope/Strict_mode [21:40:15] Change merged: Brion VIBBER; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/26484 [21:40:31] New patchset: Jdlrobson; "add generic scrollTo function" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/26548 [21:40:39] thanks [21:41:31] "Sixth, strict mode forbids octal syntax." waaaah no more octal numeric literals! [21:41:59] that sounds like a tongue twister [21:42:25] heh [21:43:05] "Sixth, strict mode secludes sextal syntax" [21:43:08] better [21:43:21] though I'm unaware of any languages supporting sextal numbers [21:44:23] programmers would be too distracted by the 'sex' part [21:44:45] ghosh, I never noticed that! [21:47:42] awjr, brion, jdlrobson - what did you write on the second page of your Indian visa application? [21:48:09] MaxSem: was there a particular question you're stuck on? [21:48:31] Organizer/Invitee, Reference Name in India [21:48:45] i had info from alolita when i filled mine out [21:48:50] one sec lemme open it up - redhat something or other [21:48:52] is the organiser the same as venue? [21:50:26] re: overlay login: go and talk to ryan lane about why that's not possible to do. [21:50:36] MaxSem: still trying to find it- it's not on the second page for me [21:50:37] one sec [21:51:01] MaxSem: oh, i currently have old contact information filled out from a previous india visa [21:51:08] MaxSem: contact rachel about that [21:51:13] she should have the details [21:51:20] ok, thanks [21:51:30] you haven't filled your application yet? [21:51:54] i have, but i just used old details since i didn't have the new ones yet. [21:51:58] i haven't submitted it yet [21:52:06] any final changes to make for https://gerrit.wikimedia.org/r/#/c/24115/ & https://gerrit.wikimedia.org/r/#/c/24147/ ? would love for someone to merge 'em :) [21:52:15] as im still waiting on the letters from redhat and the wmf [21:54:05] MaxSem: are you applying for a business or tourist visa? [21:54:46] there's a conference visa, I was going to select it [21:54:47] jorm, heatherw: while I'm thinking of retina/hi-dpi stuff, do we have vector assets for the left nav menu? i'd love to retinize it with 1.5x and 2.0x icons [21:55:30] why always me? :) [21:55:42] MaxSem: im not sure if it's the same for you, but i think most of us are applying for a business visa - however the process is more complicated [21:56:05] ewwwwww [21:56:12] MaxSem: you should sync up with Rachel about that too; she can probably tell you what is the best approach [21:56:36] jorm: I don't like telling people no either ;) [22:00:51] brion: sure :) [22:01:00] whee [22:01:23] it's probably wise to check some of those original files into source control somewhere, too [22:01:43] just let me know what you want and where [22:02:15] can you commit directly or just stick the files somewhere i can grab em? [22:02:18] (latter is fine ) [22:03:54] arrrgh it's a sprite right now [22:04:08] i hate sprites. :P [22:04:59] boo [22:05:01] but i can work with that for now [22:05:15] heatherw: if I could get icons_main_menu.png at 36px wide and 48px wide that'd be super [22:05:24] we just hav the 24px wide right now [22:06:05] no problem [22:06:09] thanks! [22:06:54] * brion dreams of a magic world where all icons are embedded data uris and we never use sprites :) [22:08:00] brion: couldn't resource loader do that? [22:08:06] jdlrobson: why yes… yes it could :) [22:08:28] our fancy checkboxes look like they're all CSS roundy boxes, so no need to adjust those for retina... [22:10:36] and the hide/reveal arrows are already high-res. excellent.... [22:12:22] im putting together a card to spike supporting other extensions… what are some of the specific questions we should be answering in the spike? [22:13:56] * how can extensions load specific javascript and stylesheets (or RL modules?) on specific pages, and have that come through for mobile views? [22:13:59] a) for all page views [22:14:20] b) for specific pages (e.g. something added via a parser plugin like the special video player handling) [22:19:26] thanks brion [22:19:43] \o/ [22:20:04] brion do you think it would be worthwhile to explicitly explore getting full RL support as well? [22:20:19] i think so yes [22:20:32] the main thing is that we probably don't want to load every module in the universe [22:20:53] i don't know if that means we need a second (partial?) registry or if we just need to limit what gets loaded more carefully [22:21:01] it would be easier if MF were in core [22:21:08] but …. we have ways [22:21:25] most likely we'll need to make some affordances in core for MobileFrontend to plug in to [22:21:46] such that things can easily say if ( $wgOut->isMobile() { blah blah } else { blah blah } ) [22:22:35] yeah - you know, i started doing something like that a long time ago [22:22:47] i think it got abandoned but i started adding support for something like that [22:22:50] lemme see... [22:23:58] oh looks like the devicedetection class got merged to core: https://gerrit.wikimedia.org/r/#/c/7115/ [22:27:27] er and i think this is part of something i was goofing around with for getting core more context aware: https://gerrit.wikimedia.org/r/#/c/10206/ [22:28:52] ooooh nice [22:31:13] i think i had accidentally merged it htough and later reverted it [22:31:18] but it was a proof of concept [22:33:03] i like the idea of providing some mobile awareness in core - we don't need to fully implement MF in core to get a lot of benefit of having things like device detection and context awareness. that may be worth pursuing. [22:33:06] i'll note it in the spike [22:33:34] gnite folks. brion respond with how the testing goes :) [22:33:34] *nod* [22:33:44] will do :) [22:43:27] filed some bugs about MF on windows phone 7.5 since i had the test phone in front of me :) [22:43:34] will poke em later, no rush [23:00:01] New patchset: Jdlrobson; "add a css reset to get more consistent styling across devices" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/26557 [23:11:33] heatherw: https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/MobileFrontend.git;a=blob_plain;f=stylesheets/images/icons_main_menu.png;hb=HEAD [23:11:44] if it appears as white-on-white, it's cause it's white-on-transparent :P [23:11:49] :) [23:11:58] thanks! [23:14:45] brion: i think i've wrapped up my planning duties - is there anything i can help out with in regards to login? [23:15:17] awjr: i think we're ready to go, had a chat with jon about the partial work he did and where to go from there [23:15:24] radical [23:23:06] anyone got an iphone with ios5 or ios6? [23:23:59] awjr: i've got an iPod touch with ios6 [23:24:02] what you need? [23:24:28] brion can you test sticky cookies on simple.wikipedia.org? [23:24:54] mobile view -> desktop, then desktop -> mobile, then try to go to simple.wikipedia.org and see if you get redirected to the .m [23:25:05] ok [23:26:13] awjr: works for me [23:26:23] huzza! [23:27:02] if anyone's got a device with ios5 it would be good to test as well [23:28:42] got an original iPad running 5.1 at home, but it's not here. [23:30:00] no worries, i'll keep digging around [23:33:34] i… might [23:35:39] oh, nm, mine's 4 [23:37:14] Maryana: that is ok [23:37:18] would you mind testing as well? [23:37:31] sure [23:37:47] beta or regular site? [23:39:44] doesnt matter - just simple.wikipedia.org [23:40:17] yep, redirected to .m [23:40:38] yay! [23:40:47] sticky cookies win [23:41:05] sticky cookies have been plaguing me since i joined the team [23:41:21] yeah, they've been all wonky for me, too, forever [23:41:27] nice to see that fixed [23:41:30] :D [23:41:35] high five, i like [23:41:44] Maryana: you upstairs? [23:41:52] yep [23:41:53] what's up? [23:41:54] want to come down here and talk nav stuff? [23:41:58] sure [23:42:00] have heather here [23:42:04] k, one sec [23:57:26] Re: WLM app "It asked me for a registration, which is OK, and I submitted it, and it said it would let me know when my application was approved, which is the last I ever heard from it. It would be nice to see either (a) automated account processing, or (b) someone to answer the mail." [23:57:32] ^ It's just a commons account, right? [23:57:46] noticed a response to the engineering blog https://blog.wikimedia.org/2012/10/03/engineering-september-2012-report/ [23:57:57] Reedy: yeah it is just a commons acct