[00:29:17] * awjr is waiting to watch everyone fall off the network [00:35:44] this internet outage was clearly a ruse [00:36:07] designed to get us all out of the office so the c-levels could have a rager [00:36:24] hahaha [00:36:28] that… would be very entertaining [00:36:37] i'm not falling for it! [00:53:21] New patchset: Jdlrobson; "refactor css using variables to make margins consistent" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/27490 [00:53:21] New patchset: Jdlrobson; "use .border-radius mix-in" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/27491 [00:58:35] New patchset: Jdlrobson; "generate mf-toggle.css via the Makefile" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/27493 [00:58:36] New patchset: Jdlrobson; "generate new mf-toggle.css" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/27494 [00:58:36] New patchset: Jdlrobson; "remove summary screen flash" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/27495 [03:24:50] New patchset: Jdlrobson; "refactor css using variables to make margins consistent" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/27490 [14:56:36] Warning: parse_url(/w/index.php?title=ASmkhaledG://Www.Com.*123*0577777777&amp;renderZeroRatedBanner=true&amp;renderwarning=yes&amp;returnto=http%3 [14:56:36] A%2F%2Far.m.wikipedia.org%2F) [function.parse-url]: Unable to parse URL in /usr/local/apache/common-local/php-1.21wmf1/extensions/ZeroR [14:56:37] atedMobileAccess/ZeroRatedMobileAccess.body.php on line 246 [16:01:55] The "WikiLoves Monuments Mobile" product in Bugzilla: Is that only for the app itself, or also about backends on the server? [16:02:09] asking as the naming is inconsistent compared to "Wikipedia App"/"Wiktionary App" products [16:24:23] andre__, server side is "Monuments database" [16:24:52] MaxSem, ah, thanks for clarifying [16:28:26] and you have a wrong cloak, andre__ :P [16:29:14] MaxSem, once my cloak request to WMF is processed I might do better :P [16:29:31] it's not wrong though, it's just "also true" :) [17:03:27] jerith: vumi-metrics should be building now [17:30:39] Maryana: what is the current status around https://mingle.corp.wikimedia.org/projects/mobile/cards/202 ? [17:32:12] Maryana: also, https://mingle.corp.wikimedia.org/projects/mobile/cards/183 still has very unclear acceptance criteria - how is it in ready for dev? [17:33:25] brion are you currently working on one of the story cards? [17:33:48] awjr: cleaning up a bug in the responsive images card [17:33:57] brion groovy [17:34:45] awjr: not sure what you're looking for on the visual changes [17:35:06] i can have munaf list them out in the a.c. in the card, but it seems pretty redundant, given that he links to them [17:36:34] Maryana: oh i see; what i dont see in that specification though is 'color of chrome' [17:36:43] ah [17:36:45] gotcha [17:36:51] talking w/munaf now [17:38:09] good catch - that's still being discussed by design, so it should get cut from the card [17:41:16] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/27490 [17:41:58] awjr: better? https://mingle.corp.wikimedia.org/projects/mobile/cards/183 [17:42:23] Maryana: yeah thanks :) [17:42:39] awjr: Are you still updating the api? [17:42:51] I cleaned up a lot of Poland, but I don't see it show up [17:44:23] multichill: no, we have not been [17:44:33] Isn't that automatic? [17:44:55] awjr: we talked about the logged in instructional notifications on tuesday and decided on provisionally going with an overlay in the first iteration [17:44:56] well i suppose that depends on what exactly you're referring to [17:45:01] just made that clear in the a.c. [17:45:09] multichill: ^^ [17:45:15] Maryana: ok will take a look shortly [17:45:25] http://toolserver.org/~erfgoed/api/api.php?action=adminlevels&format=json&admtree=pl and http://wlm.wikimedia.org/api/api.php?action=adminlevels&format=json&admtree=pl [17:45:27] multichill: are you talking about db updates for the monuments? [17:45:38] yeah, the db updates were never made automatic [17:46:11] we were trying to but could not get signoff from operations on any of our approaches [17:46:26] You can do a manual update? [17:46:42] it is possible, yes [17:47:23] multichill: are you asking us to update the db on our api server? [17:47:48] I'm not sure when the last update was, but I'm pretty sure things have improved ;-) [17:49:44] MaxSem: when you have the chance can you update the wlm db on the api server? [17:50:40] awjr, I received a killed query notification today - is the TS copy alright at all? [17:50:54] multichill: ^ [17:51:59] anyone free to help me with some login related stuff - i need to detect error states [17:52:04] bit too much php for me [17:52:06] MaxSem: Hmm, yes, something went wrong, https://commons.wikimedia.org/w/index.php?title=Commons:Monuments_database/Statistics&action=history didn't get updated [17:52:07] jdlrobson: sure [17:52:18] jdlrobson: whatchoo need? [17:52:24] Maybe better to wait adn see if tomorrow completes [17:52:30] so I'm rendering the login [17:52:37] and I'm detecting a post via $wasPosted = $request->wasPosted(); [17:52:46] I want to detect if an error occurred [17:52:51] e.g. username and password was incorrect [17:53:13] can i see your code so far? [17:53:25] i assume you're not using the api, correct? [17:53:55] sure let me send it to gerrit [17:53:56] 1s [17:54:35] New patchset: Jdlrobson; "TODO: add login to left menu and style existing login page" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/26492 [17:54:39] awjr: ^ [17:54:53] in particular = https://gerrit.wikimedia.org/r/#/c/26492/4/includes/MobileFrontend.body.php [17:55:52] New review: Jdlrobson; "not finished" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/26492 [17:57:31] jdlrobson, I thought we all agreed that we should build upon the existing login page, not discard it [17:57:43] jdlrobson: we had discussed using the existing login functionality in mw [17:57:46] oh [17:57:48] jinx MaxSem [17:58:14] to be fair that is entirely unclear in the story [17:58:23] awjr: MaxSem this was how brion started it [17:58:41] oh actually it is in the story [17:58:44] well, renderLogin() was there before him [17:58:48] my current focus is on the css [17:59:01] it was already there yeah [17:59:02] if someone wants to reorganize it that's fine [17:59:08] we can reorg it into a proper template etc [17:59:19] ok [17:59:26] yeah - there's the hook in SpecialUserLogin that allows us to hijack the template [17:59:30] if I finish off what I've done here can I pass that to someone more suitable? [17:59:38] jdlrobson: yeah i can take that [17:59:45] ok perfect - let me just do the translation stuff [18:00:02] and I'll send it with TODO notes in the places that need attention [18:00:20] sounds good :) [18:01:50] ok responsive images now merges and passes test cases: https://gerrit.wikimedia.org/r/#/c/24115/ [18:02:01] brion awesome!!!!! [18:02:03] i'll take a look [18:02:18] whee [18:02:30] i wish there was an easy way to diff patchsets [18:02:33] in gerrit [18:04:16] here's the diff: https://gist.github.com/3874361 [18:04:26] had to special-case the 'frame' case [18:04:58] watching usertesting.com tests of ribbon nav/lang. selector. it's brutal, you guys. [18:05:03] oh fancy, thanx brion [18:05:11] this lady went all the way to wiktionary to try to find the article in a different language [18:05:14] * Maryana headdesks [18:05:17] Maryana: brutal bad? [18:05:20] … yeah [18:05:23] nm you just answered that [18:05:27] no bueno [18:05:45] doesn't help that there's a bug that freezes the tab up top, so it doesn't follow the user down the page [18:06:14] Maryana: i hadn't noticed that behavior - what os? [18:06:43] android 2.3 and iphone [18:07:23] Maryana, can we see these? [18:08:00] yeah, you totally should! it's very eye-opening [18:08:09] does the team have usertesting.com access? [18:08:13] awjr? [18:08:24] good question [18:08:31] tfinc would know [18:08:37] i think i have an account from fundraising [18:09:48] hmm or not [18:09:57] if you email rachel farrand, she should be able to add you to the mobile team [18:10:12] seriously, we should all get together and watch these on a big screen [18:11:01] Maryana: do you need an account to watch the videos? [18:11:31] yeah, although we've been asking all our testers if they're comfy having these published on the web, and they seem fine w/it [18:12:06] i haven't used usertesting before, but it looks like there's also a "highlights reel" feature that lets you put together a bunch of clips [18:12:15] it'll be like america's saddest home videos [18:13:43] aww [18:13:55] i just sent an email to tomasz and rachel about accounts [18:14:40] sweet [18:16:05] the good news is, left nav is super discoverable! [18:16:17] damn you, facebook [18:16:27] you're in everybody's head [18:20:20] yay [18:20:44] https://mingle.corp.wikimedia.org/projects/mobile/cards/183 seems a little unclear to me. comments mention color changes but there's no color changes in the jsfiddle link [18:20:57] also acceptance criteria say 'everything specified in ems' which…. strikes me as odd [18:21:06] and is at odds with the jsfiddle link where everything's defined in points [18:24:26] Maryana: ^ [18:24:54] im having a weird problem running unit tests [18:25:01] awjrichards@ubuntu:/mnt/hgfs/testing/core/tests/phpunit$ make phpunit [18:25:01] php phpunit.php --configuration /mnt/hgfs/testing/core/tests/phpunit/suite.xml [18:25:01] PHP Parse error: syntax error, unexpected '*' in /mnt/hgfs/testing/core/maintenance/Maintenance.php on line 1304 [18:25:01] make: *** [phpunit] Error 255 [18:25:08] that is from master [18:25:17] New patchset: Jdlrobson; "add login to left menu and style existing login page" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/26492 [18:25:20] brion: on it. will clarify. [18:25:22] awjr: done ^ i've left relevant TODO notes [18:25:25] thx Maryana [18:25:34] jdlrobson: awesome [18:26:03] also can someone merge w [18:26:06] https://gerrit.ikimedia.org/r/#/c/27493/ [18:26:23] actually https://gerrit.wikimedia.org/r/#/c/27495/ [18:26:27] (the others are dependencies [18:26:52] gerrit is down? [18:26:55] also bit confused what is going on here - https://gerrit.wikimedia.org/r/#/c/27491/ [18:27:00] gerrit works for me [18:27:24] now it works [18:27:49] jdlrobson: needs a rebase [18:28:02] it depends on the first patchset of the other commit, not the second [18:28:17] brion: better? https://mingle.corp.wikimedia.org/projects/mobile/cards/183 [18:28:25] i'll rebase then [18:28:43] Maryana: what should use ems, exactly? [18:28:46] design backpedaled on the full specs :-/ [18:28:50] :) [18:28:59] i'm guessing jdlrobson added that [18:29:19] * brion eyes jdlrobson suspiciously [18:29:21] New patchset: Jdlrobson; "use .border-radius mix-in" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/27491 [18:29:22] jdlrobson: points vs. ems, care to comment? [18:29:42] * awjr slaps phpunit [18:30:02] Maryana: points are absolute, ems are relative [18:30:19] we are currently using ems throughout site to support better zooming and browser font size support [18:30:40] so we want to… keep doing that? [18:30:43] yes [18:30:44] or change it? [18:30:45] ok [18:30:50] got it [18:30:51] we can make it look the same [18:30:59] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/27491 [18:31:02] it's just a calculation based on the default front size [18:31:19] * Maryana copies and pastes this into the mingle card [18:31:46] brion im having trouble running phpunit tests - it keeps giving me syntax errors on lines of files that don't exist [18:31:47] is someone working on that story? [18:31:48] eg awjrichards@ubuntu:/mnt/hgfs/testing/core/tests/phpunit$ make phpunit [18:31:48] php phpunit.php --configuration /mnt/hgfs/testing/core/tests/phpunit/suite.xml [18:31:48] PHP Warning: Unterminated comment starting line 308 in /mnt/hgfs/testing/core/includes/Defines.php on line 308 [18:31:48] PHP Parse error: syntax error, unexpected '*' in /mnt/hgfs/testing/core/includes/Defines.php on line 309 [18:31:48] make: *** [phpunit] Error 255 [18:31:51] I was going to grab munaf [18:31:56] brion do you have any ideas? [18:32:00] preilly: Thanks. [18:32:02] whafu [18:32:21] * jerith will be home soonish. [18:32:24] he's up here on 6 if you want to chat [18:32:36] yup i'll head up.. provided no one else is working on it! [18:32:36] that is from a checkout of https://gerrit.wikimedia.org/r/#/c/24115/16 but i also experience something similar in master, though the syntax error is in Maintenance.php [18:32:40] on a nonexistent line [18:33:37] that's weird… i don't seem to get that [18:33:47] maybe my phpunit is borked :/ [18:33:57] though i do get lots of test fails and some notices about obsolete hooks [18:34:14] at least you get legitimate output :) [18:38:13] New review: Jdlrobson; "see TODO notes in commit message" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/26492 [18:47:38] brion: this makes even less sense to me [18:47:39] awjrichards@ubuntu:/mnt/hgfs/testing/core/tests/phpunit$ php -l ../../maintenance/Maintenance.php [18:47:39] PHP Parse error: syntax error, unexpected '*' in ../../maintenance/Maintenance.php on line 1304 [18:47:39] Errors parsing ../../maintenance/Maintenance.php [18:48:00] yeah that seems… messed up [18:48:08] sure there's no merge conflict errors or anything in those files? [18:51:34] New patchset: Jdlrobson; "ensure left nav always takes up full screen" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/27557 [18:53:03] New patchset: Brion VIBBER; "Changing font styles/sizes to match Munaf's recommendation, but using ems instead of pts" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/27558 [18:54:00] i'm not satisfied with the font thing though [18:54:07] the larger body font seems too big [19:01:21] Change merged: Brion VIBBER; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/27557 [19:04:53] huh my phpunit problems seem to be related to running phpunit in a VM with the files on a remote share form the host os. running the tests on a checkout natively in the VM seems fine. super weird. [19:05:08] funky [19:17:54] brion with https://gerrit.wikimedia.org/r/#/c/24115/16 im getting a lot of failed tests. 23, actually and it looks like 21 of them are parsertests, eg http://pastebin.com/KVM3Zxyj [19:24:04] jerith: are you able to access vumi-metrics okay now? [19:25:54] preilly: Haven't looked yet. Just eating supper and watching an old PyCon talk about parsing wikitext. [19:26:42] jerith: okay well let me know if you have any issues accessing it I mean it's not like it's 9:26pm Thursday (SAST) for you or anything [19:28:46] jerith@vumi-metrics:~$ [19:28:47] \o/ [19:28:55] jerith: sweet [19:29:05] jerith: thanks for confirming that you can access it [19:29:20] preilly: This is probably going to be a weekend project for me. :-/ [19:29:29] jerith: okay cool [19:29:37] jerith: let me know if you need anything at all [19:29:42] Will do. [19:29:47] Thanks for your help. [19:30:06] jerith: no problem [19:37:30] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/27493 [19:37:50] Change merged: Brion VIBBER; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/27495 [19:37:50] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/27494 [19:41:24] awjr: weird… jenkins claims tests passed... [19:41:32] jenkins! [19:41:40] maybe jenkins doesnt run parser tests? [19:42:04] or i have something improperly configured [19:42:27] it…. should i think :P [19:42:43] yeah, i would think so too [19:43:17] are they all passing for you locally? [19:44:05] trying unit tests with some extensions disabled... [19:44:08] lots of mystery Es [19:44:28] won't know what they are for a few more minutes [19:44:29] :P [19:45:20] all parser tests pass on tests/parserTests.php [19:45:51] hmm [19:47:40] lots of whinging about runLegacyHooks [19:48:43] no parser test fails i see [19:50:33] i wonder if something is borked in my configuration, but from the code it looks like the only thing that i should need for the link transofmration is $wgResponsiveImages [19:50:53] hang on, im running tests again, i'll send you output [19:51:57] i think sometimes i've seen weird things get stuck in memcached…. dunno [19:52:10] ah i do have memchaced enabled locally [19:53:59] brion: even with memcached disabled in my localsettings im still getting the errors [19:55:30] brion: http://pastebin.com/REbmH62g [19:56:42] awjr: to double-check: is imagemagick or php-gd enabled? [19:56:55] ah probably not [19:56:57] it looks like it might be falling back to no-scaling [19:57:12] though i've turned scaling on in the tests now, it might fail if it doesn't detect a scaler [19:57:16] is that something i need to enable in MW or is having the php lib enough? [19:57:26] it should auto detect gd if it's present in the php config [19:57:37] awjr: we've got a prioritization meeting i a couple mins right? [19:57:44] brion yeah [19:57:48] spiff [19:57:54] ok install gd [19:58:41] looks like tests are passing :) [19:58:58] \o/ yayyyy [19:59:03] ok that's one mystery solved [19:59:06] yep, all passed :D [19:59:07] thansk [19:59:08] er [19:59:09] thanks [20:00:02] ok im gonna do it! [20:00:12] * brion holds breath [20:00:52] awjr: i'm working from home office so i'll need the hangout link when you're ready [20:00:56] Maryana, brion: there's no hangout link in the invite, so https://plus.google.com/hangouts/_/14b5fac3cbb9328447594c97ffd6d05973bd2cbe?pqs=1&authuser=0&hl=en [20:01:13] \o/ awjrichards: Verified; Looks good to me, approved [20:01:23] kk [20:01:36] brion: please, start to breath properly, we need you [20:01:41] heh [20:01:59] argh camera not working brb [20:04:13] er brion: hangout link? [20:04:53] ah nm found it [20:06:39] whee https://gerrit.wikimedia.org/r/27610 [20:10:09] awesome [20:25:35] New patchset: Jdlrobson; "move ribbon related variables to mf-variables.less" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/27613 [20:25:36] New patchset: Jdlrobson; "add escapeOverlay class to back button on search and navigation" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/27614 [20:25:36] New patchset: Jdlrobson; "make mf-mixins.less inherit mf-variables.less" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/27615 [20:25:36] New patchset: Jdlrobson; "refactor mf-header.css for beta into mf-search.css" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/27616 [20:35:26] awjr: forwarded you a mail [20:35:29] (for login story) [20:43:12] jdlrobson [20:43:18] i heard you stopped by? [20:44:51] hey Munaf yeh I'll be up in a bit if you are free [20:45:00] i am for about 15 mins [20:46:37] jdlrobson: im not seeing the email [20:46:57] jdlrobson: what is the subjecT? [20:47:31] whoops awjr forwarded it to your gmail by accident [20:47:37] ahha! [20:47:38] no worirdes [20:47:45] or worries, for that matter [20:48:07] jdlrobson: yeah found it [20:48:27] runnin out for a sammich, back soon [21:14:30] hi tfinc [21:14:41] aharoni: hey amir [21:15:04] i see that somebody already tried to make some mobile work on the Urdu WP main page [21:15:08] but it was wrong :) [21:15:39] aharoni: yup.i failed [21:15:42] and need your help [21:15:46] Oh :) [21:15:48] urdu is not my specialty [21:16:10] ah, and you have permissions. I don't. [21:21:31] meh. Urdu fonts are so broken on Ubuntu. At least the default ones. [21:24:41] and it doesn't get better after installing the language pack :( [21:30:51] aharoni: do you have NafeesWeb.ttf installed? [21:31:02] yes [21:31:20] configured it manually as my Arabic font in Firefox, and it's a bit more readable. [21:31:56] New review: Jdlrobson; "Global things such as font sizes should be set in mf-variables.less" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/27558 [21:31:56] you might also want asunaskh.ttf [21:32:21] Reading Urdu for me is a bit like reading Hungarian for you: I know the letters, and some words look kinda familiar, because they are Arabic, but mostly it's meaningless. [21:32:33] I'm trying to understand where's the featured article template. [21:33:24] brion: mind if I take over https://gerrit.wikimedia.org/r/#/c/27558/1 - I wanted to talk to munaf anyway around the use of less anyway and he's upstairs [21:33:30] jdlrobson: go for it [21:33:40] i'm diving into resource loader :) [21:33:48] sweet [21:33:49] there be dragons here [21:41:48] tfinc, here's the featured article template: https://ur.wikipedia.org/wiki/%D8%B3%D8%A7%D9%86%DA%86%DB%81:%D8%A7%D9%88%D9%84%D8%B1%D9%86%DA%AF-%D8%B3%D9%88%D9%85 [21:43:51] can you try editing it and adding the needed id there? [21:44:03] I don't have the permission. [21:48:26] hmm .. i'll try after i finish this call [21:48:55] Maryana: im looking at the user testing videos - one dude figured out the language selector! but he's not happy about it. [21:48:59] tfinc, ok, ask me for help if i'm still online [21:53:32] awjr: he's edited wikipedia before, too [21:53:36] so he's not a typical reader [21:53:56] ahha [21:54:05] he struggled with finding it [21:54:13] but found it pretty quick [21:54:30] everyone looked for it at the bottom of the article [21:54:36] trouble finding the ribbon or trouble finding the language icon once it was open? [21:54:42] interesting [21:54:42] ribbon [21:54:57] but even once it was open he wasn't sure about the button [21:56:10] one thing i don't like about the ribbon is there's no place for labels, and you can't do tooltips on touch [21:56:15] so the icons have to stand alone [21:56:36] totally [21:57:00] i understand the logical separation of the nav from the ribbon, but folks also consistently looked in the nav for language seletion [21:58:12] yep. i think we're going to have to work on the language selection thing. i'm adding a card to the backlog on putting it in the footer, where everybody seems to want to find it [21:58:33] that's where interwiki links would be in desktop, roughly speaking [21:58:40] i wonder if putting a '<' on the ribbon (rather than ':') would make it more obvious [21:58:46] maybe... [21:59:31] i dunno, UI is so not my thing. if i had my way everything would be black with green text [21:59:57] or we could have a similar menu on the right for 'content' actions and go back to sticky nav to keep the navs always accessible [22:00:58] preilly: is .mwm-notice used anywhere in mobile? Also I'm assuming h3#sopa-notice is no longer necessary (context = cleaning up common css file) [22:01:00] brion: that sounds like a really good idea [22:01:27] jdlrobson: I'm not 100% sure about .mwm-notice [22:01:34] k [22:01:34] brion: yeah, munaf mocked up something like that [22:01:42] i might remove it from beta to see if there is any damage [22:01:44] in general, i think the search bar is the main navigation element that people notice [22:01:55] jdlrobson: extensions/MobileFrontend/includes/specials/SpecialMobileFeedback.php:261: $out->addHtml( "
[22:02:27] Maryana: what browser [22:02:32] this is crucial [22:02:38] was it sticky nav or non-sticky nav [22:02:46] ios & android [22:02:52] yeh but what version [22:02:54] i wonder also if we could stick more icons in there, have a search icon that expands into a search bar… but small icons leaves us back to the ribbon can't tell what these icons are problem :) [22:02:56] this is crucial information [22:02:59] android 2.3 [22:03:03] iphone 6 [22:03:04] android 2.3 = no sticky nav [22:03:08] iPhone 6 = sticky nav [22:03:15] did iPhone 6 user do better than android 2.3? [22:03:27] he was the guy who found the ribbon [22:03:29] so yeah :) [22:03:32] heh [22:04:04] there we go [22:04:07] +1 for sticky navigation [22:04:13] but i'd take these user tests with a pinch of salt [22:04:24] i don't think they are useful - but that's a story for another time [22:04:39] when we get ori-l 's logging in place we can get more useful ideas [22:04:42] have you watched them? [22:04:47] not these ones [22:04:51] but i've watched ones in the past [22:04:58] i don't think they encapsulate the average user [22:05:11] also the average user doesn't have a script [22:05:12] jdlrobson: iPhone 6?!? [22:05:17] for these 2 reasons i dislike them [22:05:25] preilly: just copying Maryana ;-) [22:05:26] iOS 6 :) [22:05:30] watch these ones. i wrote the script, so they're better :) [22:05:41] yeah, sorry, that's what i meant [22:05:45] but Maryana my issue is with the existence of the script [22:05:49] seekrit new release iphone! [22:06:03] jdlrobson: sure, they're bad at testing for user interest [22:06:06] Maryana: I thought maybe I missed a new product release it's been a couple of weeks [22:06:18] For example you can give me a script to change language - but I never use language variants so you wouldn't gain useful information [22:06:24] but the fact that people can't find or use features that they're specifically instructed to find and use..? not so good [22:06:31] If I am used to switching language variants I am more likely to be aware of certain patterns [22:06:38] but i do know that if you were to use it, you wouldn't know how :) [22:06:56] anyway.. this rant is for another time - i need to do some work [22:07:03] but please take it with a pinch of salt :) [22:07:05] it's cool, i share some of your concerns [22:07:17] pinch or grain? [22:07:28] rock salt [22:09:30] jdlrobson: when will you be back to work post-india? [22:09:42] * jdlrobson looks at calendar [22:09:53] * preilly shakes magic eight ball [22:09:58] did i add it to the calendar? [22:10:02] hahaha [22:10:28] jdlrobson: if you did i cant find it [22:10:34] * preilly Ask again later…. [22:10:51] it's in jrobson@wikimedia.org [22:10:52] reply hazy. [22:10:55] 27th is day i'm back [22:11:01] but i'm not in till 28th [22:11:11] i'll probably work on the plane though [22:11:17] brion: ha ha ha [22:11:29] jdlrobson: famous last wods [22:11:41] preilly awjr: please can you merge my outstanding back-tidy branch [22:11:46] wow i'm gonna be holding down the fort for a while, i come home much earlier :) [22:11:53] it will help untangling my head [22:12:16] awjr: I expect i'll be on email a fair bit [22:12:27] and possibly hack with rob and yuvi if the occasion arises [22:12:34] jdlrobson: for sure but im curious more about when to expect you around regularly [22:12:41] sure i guessed as much [22:12:44] :) [22:13:18] biron you're flying back on the 12th, right? when are you back in the office? [22:13:34] actually, i'll just send an email. [22:13:37] i am back in the office on the 14th, when i'm supposed to start training juliusz [22:17:04] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/27613 [22:17:39] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/27614 [22:18:07] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/27615 [22:29:54] jdlrobson: can you please change https://gerrit.wikimedia.org/r/#/c/26548/1 to not implicitly use 0 and 1 [22:31:10] jdlrobson: https://gerrit.wikimedia.org/r/#/c/27616/1/stylesheets/less/modules/mf-search.less weird whitespace detected [22:37:29] gerrit bot where are you [22:37:38] jdlrobson: a few small issues here: https://gerrit.wikimedia.org/r/#/c/27616/1 [22:38:59] oh awjr I've got one more commit for responsive images: https://gerrit.wikimedia.org/r/#/c/24147/ <- the MobileFrontend portion of it, loads the JS code [22:40:53] brion: merged [22:41:08] yay thx :D [22:41:18] * brion wanders back to ResourceLoader, never to be seen again [22:42:05] and thats the last we ever heard of brion ... [22:42:22] * preilly says to brion, "There Be Dragons..." [22:42:29] if you don't hear from me in 72 hours, send in roan and trevor for my bones [22:42:41] brion: ha ha ha ha ah [22:42:45] and one more ha [22:42:56] jdlrobson: did you take over https://mingle.corp.wikimedia.org/projects/mobile/cards/183? if so can you update ownership? [22:49:26] in case anybody hasn't seen the ribbon/language selector user tests and is curious about them, i wrote up some notes here: http://www.mediawiki.org/wiki/Talk:Mobile_design/Ribbon_navigation#Notes_from_user_testing [22:50:07] my favorite part is when they go to wiktionary to try to find a different language [22:50:17] and by favorite, i mean :*( [22:52:21] New patchset: Jdlrobson; "add sup and sub css rules" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/27642 [22:52:34] awjr: yes but i can't update ownership - another great feature of mingle [22:53:01] preilly: yep implicit use of 0 or 1 is on my todo list [22:53:20] hmm the permissioning is really weird [22:53:22] jdlrobson: okay cool [22:53:41] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/27642 [23:00:06] New patchset: Jdlrobson; "refactor mf-header.css for beta into mf-search.css" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/27616 [23:00:07] preilly: awjr fixed ^ [23:00:57] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/27616 [23:01:05] jdlrobson: thanks [23:02:10] brion: https://gerrit.wikimedia.org/r/#/c/24147/ Your change could not be merged due to a path conflict. [23:02:38] oops the mw logo is busted in non-beta; looks like location moved [23:05:22] New patchset: awjrichards; "Fix path to default logo (mw.png)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/27645 [23:05:45] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/27645 [23:22:59] MaxSem: still awake? [23:23:10] yup [23:23:58] i need to tell the mobile formatter to not strip 'form' elements for login - but i totally forget how to do that [23:24:39] aaaat last! [23:24:47] ?? [23:25:15] I wanted it for so long [23:25:18] $defaultItemsToRemove [23:27:33] interesting [23:27:37] MaxSem: ha ha ha ha [23:27:59] ok so it looks like i need to provide a way to alter that list and allow 'form' on Special:UserLogin? [23:28:01] awjr, see more potential victims?:D [23:28:42] MaxSem: ?!?! [23:29:07] ...for removal from the removals list [23:29:21] ahha [23:29:55] is 'form' in there only because of login? is it safe to just pull it out of the list? [23:30:29] awjr, ask preilly [23:30:39] preilly ^^ [23:30:53] awjr: that should be safe [23:30:59] I think a lot of forms look uglily wide on mobile [23:31:14] preilly cool thnx [23:31:15] but we'll have to allow forms at some point [23:31:22] i mean [23:31:23] awjr: np [23:31:38] the other alternative is to just remove 'form' for that list in the event that the user is on Special:UserLogin [23:31:56] which… may be a safer approach [23:32:09] awjr: that works too [23:32:56] well, you can disable transformations completely for some pages [23:33:17] which I introduced specifically for special pages [23:33:41] $context->setContentTransformations( false ); [23:35:50] ahha [23:36:18] ah but that completely disables transofmrations [23:36:36] which i think is overkill [23:36:55] this assumes that the page is mobile-aware [23:37:14] what do you mean? [23:37:14] which we will have for our specially-crafted mobile login [23:40:18] i do not like how chrome has changed their dev tools such that when you have them open it squishes the page you're looking at all the way to the left and prevents you from being able to scroll all the way to the bottom of it [23:44:39] New patchset: Jdlrobson; "typography changes" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/27647