[00:14:43] New patchset: Jdlrobson; "typography changes" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/27647 [00:16:00] yaay, georgia font! [00:17:15] New patchset: Jdlrobson; "typography changes" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/27647 [00:21:18] Change abandoned: Jdlrobson; "I forget why I was doing this. Doesn't seem useful." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/26548 [01:41:15] maryana? [01:41:37] or, jdlrobson, or tfinc, i suppose. [01:43:45] So, with the ribbon navigation. [01:44:00] Am I correct in understanding that the vertical structure of the ribbon was never built *or* tested? [01:44:30] This was a design that was developed by the entire design team. So I'm a bit curious as to why it would have been thrown away. [16:30:39] thanks MaxSem for merging the PG patch [16:30:49] np:) [16:31:32] :) [16:47:32] New patchset: Brion VIBBER; "Support for MediaWiki experimental feature $wgResponsiveImages in MobileFrontend" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/24147 [16:47:56] New review: Brion VIBBER; "Rebased / resolved alleged merge conflict (git rebase was fine....)" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/24147 [16:51:10] awjr: can you join the hangout early. i'd like to test the audio of the chrome box again [16:51:18] tfinc sure - now? [16:51:23] awjr: yes [16:52:54] tfinc :( [16:52:58] awjr: well thats super annoying [16:53:08] it worked perfectly fine when max joined the hangout yesterday [16:53:28] that is a bummer [17:19:09] brion just realized your comment "The headings look nice but the body text seems much too large and uncomfortable to read. Makes infoboxes too big to fit onscreen." was about the old gerrit commit - assuming this still applies to the new patch though? [17:19:56] link me the new one? [17:21:46] nvm found it [17:22:34] testing... [17:24:03] Lens (optics) looks good. gonna test San Francisco... [17:24:06] brion: these ios6 saved pages issues is killing us [17:24:17] what is the issue? [17:24:30] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/24147 [17:24:42] tfinc: want me to raise priority on iOS release and work on that instead of the RL enhancements for now? [17:24:44] ios6 users can't load previously saved pages and can't save new pages [17:24:51] oh good [17:25:16] are there any other stories in this sprint about our apps ? [17:25:30] tfinc: no [17:25:33] just the android beta -> refresh [17:25:36] or was that next sprint [17:25:36] right [17:25:43] that one isn't as high priority [17:25:56] awjr: need me to talk to howie about bumping this priority ? [17:26:16] the only one we have is android app from beta to stable [17:26:20] tfinc that would be good [17:26:49] awjr: i don't actually see it in this iteration [17:27:02] tfinc card #195 [17:27:13] it's in ready for developmen [17:27:15] t [17:27:15] awjr: no thats the beta->prod promotion [17:27:23] i'm talking about iOS 6 issues [17:27:45] tfinc: http://www.mediawiki.org/wiki/Mobile/Testing_process#Beta [17:27:45] but we may have issues on both Android and iOS [17:27:48] oh, i was responding to "are there any other stories in this sprint about our apps ?" [17:27:52] jdlrobson: ok it's not so bad as i thought, the info box that was showing too wide already shows too wide on the existing skin. :) so i withdraw my objections for now [17:28:37] tfinc: awjr https://bugzilla.wikimedia.org/show_bug.cgi?id=40013 [17:28:41] jdlrobson: and did you move the ones you removed to production testing ? [17:29:13] tfinc: no I had assumed that production testing would be mutually exclusive - am i wrong [17:29:25] Production (Beta inclusive) [17:30:16] jdlrobson: --^ [17:30:50] now the production list looks like we don't care about s40 [17:31:26] awjr: do we need mon/tues windows for next week ? [17:31:33] tfinc yes [17:31:35] k [17:31:51] brion: i merged the responsive images in MF [17:31:56] thanks! [17:32:06] * brion does the happy dance [17:33:19] brion: so before we jump into any app story. i'd like to asses saved page issues on iOS and Android [17:33:34] specifically iOS6 (any device) and Android (Samsung Galaxy S3) [17:33:38] i can at least repro problems on ios6 [17:33:45] thats what were seeing from our feedback lists [17:35:00] tfinc: if you're going to be putting together a story/stories for this, you might grab mcihelle to help [17:35:24] awjr: i will with my zero time today for it ;) right now i'm giving howie a heads up [17:35:33] roger that [17:35:57] awjr: i think next step for michelle will be to do main triage for feedback lists [17:35:59] for bugs [17:36:30] tfinc 'feedback lists'? [17:36:52] mobile-feedback feedbacktest etc [17:36:56] ah yeah [17:37:05] i already have a story in mingle about killing feedback test [17:37:24] without phil i think we've gotten behind on responding/triaging to feedback emails [17:37:33] tfinc: does she have access to those lists? [17:38:09] awjr: just a matter of adding her to the mailman lists or prodding IT [17:38:11] nothing too scary [17:38:33] k [17:38:33] awjr: but i'd love to kill feedback test before we add her to limit the amount of new lists she's on [17:38:40] when is the current sprint over ? [17:39:14] 10/23 [17:40:02] https://mingle.corp.wikimedia.org/projects/mobile/cards/130 [17:40:29] awjr: thanks. i see the end date tehre [17:41:50] fancy. verizon now wants to feature the wikipedia app . were getting popular these days [18:30:21] did brion say he was coming in ? [18:32:59] i want to triage iOS saved pages with him [18:38:44] i didn't hear him mention [18:39:43] awjr: should we hook up https://bugzilla.wikimedia.org/buglist.cgi?list_id=151901&field0-0-0=bug_severity&resolution=---&resolution=LATER&resolution=DUPLICATE&query_based_on=MFE&query_format=advanced&bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&type0-0-0=notequals&value0-0-0=enhancement&component=MobileFrontend&product=MediaWiki%20extensions&known_name=MFE to the rss irc bot? [18:40:07] i'm happy to take that on now awjr [18:40:12] jdlrobson: i've been playing with the bot a bit actually to do exactly that [18:40:13] awjr: can you / know of anyone who can help me setup CentralNotice for the India devcamp? [18:40:16] perfect [18:40:20] i'll leave you too it then [18:40:34] jdlrobson: but im running into some roadblocks; just emailed petr and the list [18:40:48] srikanthlogic: kaldari is your best bet [18:41:22] srikanthlogic: he's hanging out in #wikimedia-dev right now [18:41:28] awjr: thanks! [18:41:32] np [18:41:57] jdlrobson: im not convinced it's totally working yet [18:42:41] and i can't find the latest source code; although i think it's written in c# [18:51:43] brion: ! [18:51:44] tfinc: yo [18:51:56] so i was able to repo the ios6 saved issues every time i tried it [18:52:12] i talked with howie and he's fine to de-prioritize resource loader work [18:52:15] * brion shakes angry fist at ios6 [18:52:16] ok [18:52:29] only issue is that we don't have a card in this iteration about this [18:52:33] awjr: how do you feel about this? [18:53:04] brion: i think the issue is pretty clear on our end. saved pages don't work at all on ios6 [18:53:12] tfinc: this is a bug, right? we're not introducing a new feature? [18:53:20] bugses [18:53:23] awjr: correct [18:53:32] if it's a bug it doesnt get a story card [18:53:41] woot. then i'm not skirting process too much then [18:53:47] nope [18:54:10] as long as everyone understands the cost of the context switch from RL work -> fixing the bug, it's no big deal [18:54:11] awesome sauce. i've been adding to the bug https://bugzilla.wikimedia.org/show_bug.cgi?id=40013 [18:54:29] does brions resource loader work block any other card ? [18:54:44] it shouldn't block anything on the current list no [18:54:46] my take is that it does not and that its simply for third part mobile dev [18:54:49] tfinc id ont think so [18:54:50] and/or per [18:55:00] at least that's what i told howie to make him agree to this :D [18:55:04] heh [18:55:36] i've been getting a lot of 503 errors from gerrit lately :( [18:55:45] brion: do you need anything else from me to move on the iOS6 issue ? [18:56:06] tfinc: it looks like i'll have to upgrade us to the latest cordova [18:56:14] as long as i'm clear to do that, i can go ahead [18:56:17] awjr: keep me honest with these cases if i cause you too much turbulence. i think in this cause though it made it easier. howie asked the right questions about RL [18:56:29] brion: do it [18:56:37] \o/ [18:56:54] s/cause/case [18:57:25] tfinc in this case it's fine, it's a serious bug. as long as product is aware of the severity of the issue and understands the cost [18:57:29] awjr: since this won't be a story it'll be fought to visualize it during the stand ups [18:57:34] since we won't see it in mingle [18:58:01] tfinc yeah for WLM app i had been trying to use defect cards in mingle, but it never seemed to take [18:58:17] yeah thats why i'm making it very visible that i'm doing this so that we can see if the process makes it easier/harder [18:58:33] at the moment, you have to switch to different views in mingle for tasks and defect cards, which makes it tough to visualize all in on place, hence why i think they havent really been seen as useful [18:58:33] awjr: jdlrobson had commend that we might want to have the bug list open during stand ups [18:58:42] awjr: fail [18:59:14] tfinc i dont know if i'd call it a fail; the 'template' we're using in mingle conceives of different work flows for stories/tasks/defects [18:59:20] which is why they cant be presented in the same view [18:59:32] awjr: fail that we can't have one view of all the work [18:59:49] it's possible for us to tweak it so that they can [19:00:10] but, im not sure there will be an easy visual way to tell the difference between the types of cards [19:01:12] hmmm [19:01:21] i might be able to sneak in just the patch, in which case this gets a lot easier [19:02:24] ohhhhhh I ninja'd it man. it looks like it's working :) [19:03:10] small patch to the cordova JS lets it override the native FileReader with the cordova one [19:03:29] lemme make sure it still works on iOS 5 sim [19:04:41] awjr: what lessons were learnt from the last deployment and touching resources? Has this been added to the instructions? [19:05:47] lesson learned: there's a bug in RL where if you remove a resource from an RL module but make no other changes to it, RL will not register that there's been a change to the module, resulting in the old version of the module potentially being stuck in the RL cache. [19:06:03] to fix: touch a resource for the module in question on fenari and sync-file it to the cluster [19:06:18] which instructions were you referring to, the how to deploy code instrux? [19:08:51] [WikipediaMobile] brion pushed 1 new commit to master: http://git.io/99iwaw [19:08:51] [WikipediaMobile/master] iOS 6 fix for loading saved pages - Brion Vibber [19:09:14] Project WikipediaMobile - Nightly builds build #407: SUCCESS in 14 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/407/ [19:09:14] Brion VIBBER: iOS 6 fix for loading saved pages [19:11:53] tfinc: i've reached out to Hai and other mingle people with the teams concerns around stories vs tasks vs defects and how to display them in one place. hopefully they will have some good insights. personally i do not think it makes sense to have them all on the same wall (way too much clutter, and things like task cards do not make sense to organize in the same way as stories), but what i think would be good is a view that displays all three wa [19:15:38] * yuvipanda looks around [19:16:38] * brion looks suspiciously at yuvipanda  [19:18:12] * tfinc wonders if its the real YuviPanda or if its just BlackRectangle in disguise  [19:18:20] awjr: great [19:18:31] brion: I DIDN'T DO IT! [19:18:36] :) [19:18:39] tfinc: had a chance to look at the app? [19:18:42] err, uploader? [19:18:46] YuviPanda: nope [19:18:48] i suck [19:18:49] also, updates on the Google play stuff? [19:18:51] maybe this weekend [19:18:59] Verizon wants to feature our app now [19:19:00] :D [19:19:03] saw that :D [19:19:23] let's please push beta before that! And the fixes for the defects that google pointed out to us. [19:19:26] [WikipediaMobile] brion pushed 2 new commits to master: http://git.io/Ic5oQA [19:19:26] [WikipediaMobile/master] Fix Twitter detection on iOS 6; fix share dialog cancel button on iOS 4 - Brion Vibber [19:19:26] [WikipediaMobile/master] Merge pull request #275 from brion/bug38226 - Brion Vibber [19:19:30] is there some time scheduled for that? [19:19:30] YuviPanda: i'll be able to think about that after i pickup lunch. [19:19:34] Project WikipediaMobile - Nightly builds build #408: SUCCESS in 8.2 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/408/ [19:19:35] Brion VIBBER: Fix Twitter detection on iOS 6; fix share dialog cancel button on iOS 4 [19:19:37] ah, indeed :) [19:19:39] YuviPanda: we have bugs being reported in beta but not prod [19:19:45] so i need to asses it better [19:20:04] YuviPanda: first step was to fix iOS which you see brion doing ---^ [19:20:10] tfinc: the 9 bug. [19:20:13] YuviPanda: yes [19:20:29] brion: I assume that if we're doing an iOS release, it'll branch off last known iOS stable release, rather than master? [19:20:29] heads up that i just talked with diedrik about our analytics backlog [19:20:36] they have a new awesome contractor in place [19:20:45] wooo! [19:20:47] i'd rather just do master [19:20:50] it seems to work :) [19:20:59] but working with wiki stats is tough as its not even in git .. so their having to do some basic vcs work before they get to the real mobile stats [19:21:20] * tfinc looks around for michelle [19:21:28] YuviPanda: have you met Michelle yet? [19:21:39] YuviPanda: she joined us this week as Mobile QA [19:21:45] brion: while the major change in master (dynamic sections) has gotten plenty of usage on android, it doesn't have much testing on iOS (beyond when I wrote/tested it) [19:21:57] tfinc: blackrectangle was around yesterday for the hangout, so I saw her :) [19:22:01] but haven't 'met' her yet, no [19:22:15] she won't be in india but i'm sure you guys will run into each other soon'ish [19:22:24] YuviPanda: bigger point. we finally have someone we like working on QA [19:22:39] +1 [19:22:43] + [19:22:44] yuvipanda: want to release some betas before we submit to app store? [19:22:55] I'm looking to send her to this http://mobiletestsummit.com/ [19:22:59] or possibly after, since it'll take days/weeks anyway :P :) [19:23:03] brion: we could do that, but would the iOS6 issue warrant a new release? [19:23:07] like, a 'bugfix' release? [19:23:14] this is a bug fix [19:23:27] un breaking ios6 should not be a feature [19:23:32] brion: so I think it's best we push out with a cherry-pick and then do a set of betas [19:23:43] betas for testing are fine [19:23:47] but this isn't a major point release [19:24:13] (set of betas for master, that is) [19:24:23] tfinc: there were earlier bigger changes on master since last iOS release, if i understand correctly [19:24:35] YuviPanda: hows broadcasting the Signpost app going ? [19:24:54] brion: if there are other changes then that changes the conversation. i'm only referring to the saved pages issue [19:24:57] tfinc: Jarry wasn't too keen on doing any extra visibility for the app on the signpost page. [19:24:59] i prefer a small release so that we can get it out [19:25:02] rather a big feature release [19:25:04] +1 to tfinc [19:25:10] YuviPanda: lame [19:25:13] hella lame [19:25:35] ok lemme see what it'll look like to cherry-pick the fixes [19:25:38] tfinc: I think I'll talk to Ed in a bit and see if it bites. [19:25:40] *he [19:25:45] is Ed another editor ? [19:25:54] tfinc: Ed is the Editor in Chief [19:26:08] * brion goes "yay" at existence of https://www.mediawiki.org/wiki/Mobile/Release_history [19:26:09] YuviPanda: its lack of publicity like that that wouldn't make me want to do an iOS version [19:26:14] their just shooting themselves in the foot [19:26:40] however i don't see tags in the repo for ios v3.2.0 [19:26:45] YuviPanda: --^ [19:27:06] brion: I see a branch [19:27:14] v3.1.2-iOS [19:27:14] * tfinc goes to pickup food [19:27:15] err [19:27:18] v3.2-iOS [19:27:20] yuvipanda: yes i see them now [19:27:23] excellent [19:27:48] brion: branches instead of tags since sometimes I've had to do fixes on top of branches that weren't needed in master. [19:29:13] brion: question - if the commons app moves into wikimedia repos, would you be able to CR Java code as well? Note that this would happen at best a few months from now... [19:29:16] (just asking) [19:29:28] yuvipanda: yes [19:29:46] brion: awesome! [19:35:17] ok… fixing a merge glitch here [19:36:35] yuvipanda: can you take a quick look over these and confirm it all looks good? [19:37:06] https://github.com/wikimedia/WikipediaMobile/pull/286 [19:39:20] agh [19:39:28] it wants master? wrong destination, lemme fix [19:40:19] ok https://github.com/wikimedia/WikipediaMobile/pull/287 [19:40:39] brion: looking [19:42:08] brion: looks good except for one unrelated spacing change [19:42:13] heh whoops [19:42:14] brion: tested on all variants? [19:42:29] tested on iOS 6 and 5.1 simulators, all i have on me right now [19:44:19] brion: no 4.x? [19:44:30] 4.x has a tendency to break on things that are otherwise innocous [19:44:43] no more 4.x sim in this version of Xcode >:( [19:45:00] and my device is in the office [19:45:35] brion: looks good to merge, but I hope someone can test it on 4.x before puhsing it out [19:45:38] *pushing [19:46:30] *nod* [19:46:51] though i'd be happy to drop 4.x soon enough anyway ;) [19:47:13] brion: perhaps with the next major push? :) [19:47:24] yeah that'd be a good time to do it [19:47:32] new cordova, updated ui [19:47:38] and dropkick 4.x :D [19:49:46] yup! [19:49:57] brion: we should update cordova throughout, fix the '9' bug in beta [19:50:17] brion: tfinc before the google play / verizon feature. possibly schedule some time for it? [19:54:45] you know what would be hilarious? [19:54:55] brion: ? [19:55:03] if they come out with an 'iPad mini' but it's *not* 1024x768 resolution and we have to push out another fucking update for the screen size [19:55:09] :D [19:55:22] That's highly possible, of course :) [19:55:39] with a new connector too [19:56:05] brion: what would really rock is if they 'reinvented' the 3.5mm jack :P [19:56:26] with something thinner, of course [19:56:33] and totally iProprietary :D [19:58:16] duh [19:58:31] possibly with a chip in the cables to provide 'protection' [19:58:39] but I gueess that's asking them to shoot themselves in the foot a bit too much [19:59:09] psh! there'd be people lining around the block for new iHeadphones [19:59:22] * brion quietly checks the shipping tracking on his new iPod Touch [19:59:28] :P [19:59:38] it's a new aspect ratio, i have to test it i swear ;) [19:59:59] * preilly says ha ha ha ha [20:03:09] woot … afternoon just lost a bunch of meetings I'm already feeling less under water [20:03:18] YuviPanda: so Android beta/prod [20:03:32] * tfinc reads back scroll before saying anything else [20:06:49] YuviPanda: still awake? [20:07:23] tfinc: yup [20:07:29] does a YuviPanda ever truly sleep ? [20:07:32] ;) [20:07:39] it does, at 5AM localtime :) [20:07:48] yuvipanda: oh and should i put those updates into a v3.2.1-iOS branch rather than pulling into v3.2-iOS? [20:07:54] or if a YuviPanda is in class [20:07:54] brion: yup! [20:07:58] excellent [20:08:04] YuviPanda: our cut off for the verizon feature is 10/15 [20:08:10] tfinc: that too, yes. Went to college today, had pretty deep sleep for about 6. [20:08:20] tfinc: That's tuesday? [20:08:25] correct [20:08:31] but here is the thing [20:08:35] this is a marketing push [20:09:14] [WikipediaMobile] brion created v3.2.1-iOS (+3 new commits): http://git.io/8O2HmA [20:09:14] [WikipediaMobile/v3.2.1-iOS] bug 40256: make app run natively on iPhone 5 4" screen - Brion Vibber [20:09:14] [WikipediaMobile/v3.2.1-iOS] iOS 6 fix for loading saved pages - Brion Vibber [20:09:14] [WikipediaMobile/v3.2.1-iOS] Fix Twitter detection on iOS 6; fix share dialog cancel button on iOS 4 - Brion Vibber [20:09:26] Project WikipediaMobile - Nightly builds build #409: SUCCESS in 10 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/409/ [20:09:34] true, but we should have people use the best app we have. And because of dynamic sections I think the beta is loads better than the stable one. [20:09:42] so it can run indepdantly of our app update [20:10:00] if we don't get our assets in by 10/15 then we lose our window [20:10:14] there's no change in visibility, and assets doesn't block this, right? [20:10:27] infact there's zero work involved in 'promoting' - I even built an apk. [20:10:35] and have a CHANGELOG [20:10:46] s/in visibility/in the visible interface/ [20:11:10] correct. assets don't block release [20:11:17] their hoping to launch this campaign in the next 30 days [20:11:23] so i say we get the assets out regardless [20:11:36] assuming heatherw doesn't kill me/verzion for this timeline [20:11:45] :) [20:13:06] tfinc: sure, but what exactly is blocking the beta->stable promotion? [20:13:09] I can't think of anything [20:14:30] * tfinc pulls up bug list [20:14:31] [WikipediaMobile] brion pushed 1 new commit to v3.2.1-iOS: http://git.io/NIwG4Q [20:14:31] [WikipediaMobile/v3.2.1-iOS] Update iOS version to 3.2.1 - Brion Vibber [20:14:36] of course we don't *have* marketing assets, so that bit is funny ;) [20:14:39] Project WikipediaMobile - Nightly builds build #410: SUCCESS in 7.8 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/410/ [20:14:40] Brion VIBBER: Update iOS version to 3.2.1 [20:15:05] tfinc: The only one I can now think of is the '9' issue - we fixed that for the WLM app, so I can easily cherrypick that. [20:15:09] geez. 170 bugs for the apps. that blows [20:15:17] YuviPanda: do it [20:16:08] YuviPanda: https://bugzilla.wikimedia.org/show_bug.cgi?id=40334 [20:17:10] YuviPanda: https://bugzilla.wikimedia.org/show_bug.cgi?id=39269 [20:17:42] YuviPanda: https://bugzilla.wikimedia.org/show_bug.cgi?id=38984 <--- which i already mentioned [20:17:59] https://bugzilla.wikimedia.org/show_bug.cgi?id=38298 [20:19:55] so the '9' bug basically needs a Cordova update [20:20:18] which is mostly held up by uncertainty about updating the plugins we use [20:20:19] yup, and other than the bug MaxSem filed it all looks like weird phone issues [20:20:24] https://bugzilla.wikimedia.org/show_bug.cgi?id=35944 [20:20:25] brion: didn't we cherrypick a fix? [20:20:42] yuvipanda: no i don't think we could track it down to any one fix annoyingly enough [20:20:51] brion: want to close this https://bugzilla.wikimedia.org/show_bug.cgi?id=35838? [20:21:28] https://bugzilla.wikimedia.org/show_bug.cgi?id=35251 [20:22:08] tfinc: I don't see night mode happening now :P [20:22:23] tfinc: can you confirm it's fixed? (slow startup time we think improved by changes in 3.2?) [20:22:23] YuviPanda: whats stopping you from creating one ? [20:22:38] tfinc: night mode? [20:22:44] brion: if we didn't fix it do we really care right now? [20:22:50] YuviPanda: yes [20:22:51] tfinc: inline styles. [20:22:52] not much :) [20:22:56] :P [20:22:59] damn those inane styles [20:23:07] :D [20:23:11] inline styles also have colors, so we'd need to invert / transform those too [20:24:07] * tfinc finishes looking through bug list [20:24:10] well [20:24:11] nothing too major in there [20:24:25] one way is to just override everything with !important and say "too bad you get no color in night mode" [20:28:33] tfinc: I can repro only https://bugzilla.wikimedia.org/show_bug.cgi?id=39269 [20:28:36] working on a fix now [20:31:30] k [20:35:52] tfinc: brion https://github.com/wikimedia/WikipediaMobile/pull/288 [20:36:33] and how convent isn't it that its 20% day to review such things YuviPanda :) [20:37:11] oooh, sweet :) [20:37:36] YuviPanda: was i ever able to get you fully setup to do iOS market releases ? [20:37:43] tfinc: nope [20:38:01] hrm [20:38:06] i think we ran into signing problems again and again at multiple levels. [20:38:08] for some reason pages don't finish loading [20:38:16] better clean the build [20:38:54] then its going to be even more fun for me on this new laptop [20:39:38] tfinc: iTunes Connect is synonymous with 'fun' [20:39:43] brion: android or iOS? [20:39:49] ios [20:40:03] brion: weird. [20:40:05] for some reason it just broke on me in master …. i'm not sure what's wrong [20:40:38] maybe the submodule stuff [20:40:44] YuviPanda: i despise all things apple store [20:41:18] ok must have gotten the submodule confused while i was working not he other branch [20:41:18] I was already not a fan of apple considering how they completely pretend that we as a country of 1 billion people do not exist [20:42:28] [WikipediaMobile] brion pushed 2 new commits to master: http://git.io/DPSDhA [20:42:28] [WikipediaMobile/master] (bug 39269)Fix references being populated twice - YuviPanda [20:42:28] [WikipediaMobile/master] Merge pull request #288 from yuvipanda/genocide-on-half-the-reference-population - Brion Vibber [20:42:39] Project WikipediaMobile - Nightly builds build #411: SUCCESS in 10 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/411/ [20:42:40] yuvipanda: (bug 39269)Fix references being populated twice [20:42:52] sweet [20:43:42] lemme cherry-pick that into 3.2.1... [20:43:46] brion: wait, this is present in 3.2.1? [20:43:53] aaah, of course. nevermind [20:43:56] yes [20:44:18] this was in the stable version of the android app too, then. Just realized this wasn't caused by dynamic sections, but the prior API switch [20:44:32] [WikipediaMobile] brion pushed 1 new commit to v3.2.1-iOS: http://git.io/8oEPug [20:44:32] [WikipediaMobile/v3.2.1-iOS] (bug 39269)Fix references being populated twice - YuviPanda [20:44:42] Project WikipediaMobile - Nightly builds build #412: SUCCESS in 10 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/412/ [20:44:43] Brion VIBBER: (bug 39269)Fix references being populated twice [20:48:24] brion: do you remember if it was 1.9.x or 2.0 cordova that fixed the '9' bug? [20:48:36] http://taskumuro.com/artikkelit/the-story-of-nokia-meego [20:48:48] 2.0 final worked i think [20:48:54] * yuvipanda wonders if he's in the mood for a sad story. [20:49:03] brion: hmm, 2.0 will need plugin updates, I think. ugh. [20:49:09] yup :( [20:49:15] that's why i hadn't been in a hurry to do it :P [20:49:26] luckily 4.1 fixes the bug on the android side iirc [20:49:41] so we can at least say to 4.0 users "well it's your provider's failt for not upgrading you" ;)) [20:50:18] brion: I think that's always something valid to tell Android users :) [20:50:28] :) [20:50:33] it's android's response to iOS' 'You are holding it wrong' :) [20:51:06] hahaha [20:51:13] New patchset: Jdlrobson; "Remove content blocks for all but first section when using beta mode" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/27773 [20:51:13] New patchset: Jdlrobson; "enable dynamic sections" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/27774 [20:51:36] Change abandoned: Jdlrobson; "Sent a new patch" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/23618 [20:52:02] wooo [20:52:38] sweeet! [20:53:21] brion: I'll update the Android plugins tomorrow and upgrade to latest Cordova. [20:53:31] yuvipanda: awesome :D [20:53:33] brion: but that shouldn't block the iOS bugfix release. [20:53:37] yeah [20:54:04] * brion looks at tfinc, holder of the magic apple keys [20:54:16] * tfinc hates being holder of the magical keys [20:54:23] :) [20:54:30] brion: need me to build a beta release? [20:55:01] if you want to release it to beta testers as well as waiting for the store, then… probably [20:55:21] i don't recall whether you had to be owner to build ad-hoc distributions or not... [20:55:34] bah i'm so spoiled by android being simpler [20:56:08] tfinc: http://memegenerator.net/instance/28257839 [20:56:41] heh [20:57:41] can someone abandon https://gerrit.wikimedia.org/r/#/c/27558/ < brion awjr ? [20:57:56] YuviPanda: ROFL [20:57:59] i'm printing that out [20:58:12] Change abandoned: Brion VIBBER; "jon's redoing this" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/27558 [20:58:15] it only it was better for print size [20:58:34] awjr, yes it worth it - the code's already there [20:59:01] brion: which branch am i building off of [20:59:05] MaxSem: re merging sphinx support? [20:59:08] tfinc: v3.2.1-iOS [20:59:09] and my Solr commit depends on all these changes anyway:P [20:59:12] does anyone in the room have any new udid's that i need to add before i build it ? [20:59:30] not until next week [20:59:31] yeah i saw that [20:59:38] preilly: want yer iPhone 5 in the beta group? [20:59:53] MaxSem: can you walk me through how to test all that stuff? i'd like to get it merged then [21:00:04] solr? [21:00:10] err sphinx? [21:00:10] MaxSem: sphinx first [21:00:15] Your branch is behind 'origin/master' by 78 commits, and can be fast-forwarded. .. weee [21:02:33] tfinc: if you're building for iOS bugfix release, remember to build from the branch brion is working off of, rather than master [21:02:53] and make sure to git submodule update [21:03:45] install sphinx, copy sphinx.conf.db.sample on the top of /etc/sphinxsearch/sphinx.conf replacing all placeholders [21:04:24] then indexer --all -rotate [21:04:37] err, indexer --all --rotate [21:06:08] MaxSem: is it enough to apt-get install sphinxsearch on ubuntu? [21:06:12] yup [21:06:21] also, $wgGeoDataUseSphinx = true; [21:06:42] ok cool im gonna try to get this set up so i can better review your changes [21:06:56] ggg, setting up GeoData with Sphinx is actually harder:P [21:07:03] o [21:07:22] ...than with Solr [21:07:50] MaxSem: wait, do i need to do anything else to get sphinx working with GeoData or is that it [21:08:25] YuviPanda: yes i know but i wanted to sync up all my branches [21:08:34] ah, new machines :) [21:09:13] awjr, mobile-testing is actually running Sphinx ATM [21:09:23] oh that's probably just easier [21:09:34] tfinc: on another note I'm gunning for your '10s from photo to upload' thing for Commons uploader, and it's getting there :) I'll mail you a link to an updated apk shortly. [21:09:53] challenge accepted then :D [21:10:22] very much! [21:10:41] * tfinc fires up Xcode. prepares to swear like a sailor [21:10:53] I just figured out and fixed uploading in the background, so you can set title / desc, hit upload and forget about it - no need to wait for the upload to complete :) [21:12:30] awesome [21:16:56] ld: warning: directory not found for option '-F/Users/Shared/Cordova/Frameworks' [21:17:12] i only see that warning when i build on device. it doesn't happen inside the emulator [21:17:16] jebus mobile-test is slow [21:18:47] that doesn't sound encouraging :( [21:18:53] * jebus touches mobile-test, turns it into wine [21:18:57] try reinstalling cordova 1.7? [21:19:06] lol YuviPanda [21:19:27] that's how we get this party started [21:20:20] MaxSem: any idea why mysql is not running on mobile-test" [21:20:20] ? [21:20:24] it will not start [21:20:40] it did when I looked at it last time [21:20:48] ...which was looong time ago [21:20:51] I guess unlike brion, mysql doesn't run on wine :P [21:20:56] lemme look at it.. [21:21:16] mysql logs are conveniently empty [21:21:23] YuviPanda: running mysql on wine would be silly, there's a native linux version [21:21:37] maxsem@mobile-testing:~$ mysqld [21:21:37] 121012 21:21:12 [Warning] Can't create test file /mnt/store/db/i-00000271.lower-test [21:21:37] 121012 21:21:12 [Warning] Can't create test file /mnt/store/db/i-00000271.lower-test [21:21:37] mysqld: Can't change dir to '/mnt/store/db/' (Errcode: 13) [21:22:04] brion: specifically 1.7? [21:22:08] not 2.1 ? [21:22:24] tfinc: yes, this build is still on 1.7 [21:22:30] MaxSem: ... [21:22:46] i made minimal changes for the iOS 6 workaround in the JS side of cordova 1.7 [21:23:02] ok [21:23:02] MaxSem: /mnt/store/db is owned and wriable for mysql user [21:26:02] new error but i think i can fix this one [21:26:40] ld: file is universal (3 slices) but does not contain a(n) armv7s slice: /Users/Shared/Cordova/Frameworks/Cordova.framework/Cordova for architecture armv7s [21:27:00] whafu [21:28:11] i specially need to build this for arm7s [21:28:12] hmm [21:29:07] tfinc: looks like you can also disable arm7s build for the app [21:29:19] brion: yes but wouldn't i need that to work on the 4s ? [21:29:36] a plain arm7 build should still work on iPhone 4s and 5 [21:30:15] k, we will need an arm6 build thought [21:30:18] so I'm adding that [21:30:19] once we update to cordova 2 the source of the library gets imported into your project (sorta) and we can do full arm7s builds if we care [21:30:20] yeah [21:30:23] New patchset: Jdlrobson; "enable dynamic sections" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/27774 [21:30:34] app loaded! [21:30:38] ZOMG this is easier now [21:30:39] \o/ [21:30:41] YuviPanda: --^ [21:30:41] whee [21:31:06] tfinc: 'easier'? [21:31:30] Organizer took care of everything cert related [21:31:39] then i just needed to tweak the arch settings to build on deivce [21:31:42] device* [21:31:53] quick saved page test shows that it works! [21:32:02] nice! [21:32:02] success! [21:32:13] i'm going to archive and verify then i'll build a beta [21:32:38] tfinc: make sure to push the updated project file into the branch [21:32:46] yup [21:32:49] excellent [21:33:26] brion: i need a user friendly change log [21:33:42] 3-5 line at most [21:34:36] "Change build settings to get Cordova 1.7 working on iOS 6 device build" [21:34:50] no no [21:34:53] "Had to disable armv7s since Cordova 1.7 ships as a static library without that arch" [21:34:55] for 3.2.1 [21:34:55] ooh [21:34:57] durrrr [21:35:00] for the hu-mans [21:35:07] i can come up with a change log for the build change :) [21:35:09] lemme ether pad it up [21:35:15] but i need one from you guys for 3.1.2 [21:35:24] for the humans [21:35:26] MaxSem: are you working on mobile-test right now? i'd like to reboot it [21:35:37] no I'm not [21:35:53] http://etherpad.wikimedia.org/iOS-ChangeLog [21:36:29] sold [21:36:51] excellent [21:37:38] brion do we have a 1024x1024 version of our iOS icon? [21:37:43] apple wants one for this version [21:38:27] lemme check [21:38:30] if not i can scale one up quick [21:38:53] brion: awesome [21:39:28] once i have that then i can validate [21:39:32] and then we can cut a beta [21:39:56] heatherw: do you have a vector original for the logo? i've got a 512x512 version but we need 1024x1024 now :P :) [21:40:05] if not i can make a quick scale-up [21:40:58] MaxSem: got mysql restarted, but did the root mysql password change? [21:41:33] don't see it in https://www.dropbox.com/home/WMF%20Design/Icons [21:41:40] it shouldn't have [21:42:08] unfortunately, we've neglected that instance for too long [21:44:43] brion: even a scaled up version could work for now as it'll unblock me from being able to validate the build [21:44:47] i'm sure we can change it later [21:45:56] one hopes :) [21:47:35] [WikipediaMobile] brion pushed 1 new commit to master: http://git.io/8ripmQ [21:47:35] [WikipediaMobile/master] Temporary 1024x1024 icon for iTunes - Brion Vibber [21:47:44] Project WikipediaMobile - Nightly builds build #413: SUCCESS in 10 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/413/ [21:47:45] Brion VIBBER: Temporary 1024x1024 icon for iTunes [21:47:48] tfinc: https://raw.github.com/wikimedia/WikipediaMobile/master/scratch/logo-1024.png [21:47:56] that'll do [21:48:27] great. i'll trace a quick SVG so we can generate a sharper one [21:49:02] yes brion [21:49:02] Hi there :) The last time I was here, the iOS client was Cocoa, but now it seems you've moved on to PhoneGap? [21:49:08] ah good [21:49:13] that'll save me a trace :D [21:49:25] ArturoVM: yes we have [21:50:44] Oh :/ I was hoping I could contribute, I have an iOS fork from that time, with a couple of fixes for memory leaks and so on. 'Fraid I'm not good with PhoneGap. [21:51:23] ah :) well thanks for that anyway :D we appreciate it [21:52:43] ArturoVM: if you're still looking to contribute, and want to write objective-C, I believe a mediawiki API client in ObjC would be very useful [21:52:47] iirc there isn't one [21:53:30] brion: sure! :) [21:53:33] that'd also be handy if we have to add some native components like search integration… if they ever open it up for plugins :D [21:53:37] YuviPanda: Great, I [21:53:45] I'll try my hand at that. [21:54:53] grrr … the validator is being a bitch [21:54:58] and definitely would be handy for a commons uploader app for iOS, should YuviPanda decide to take on some obj-c after doing the android one :) [21:55:10] Are there any sort of API docs I can read? [21:55:37] ArturoVM: https://www.mediawiki.org/wiki/API:Main_page [21:55:52] also it has some self-documentation system, e.g. at http://en.wikipedia.org/w/api.php [21:56:11] ok. signing error fixed. now i just have to fix the armv6 issue. i have it as a build architecture yet the validator says i don't [21:56:14] brion: thanks! I'll start poking around :) [21:56:30] ArturoVM: http://en.wikipedia.org/wiki/Special:ApiSandbox is a much easier self-documenting system [21:56:34] brion: point people to that instead :) [21:56:43] ah yes :D [21:56:46] we should integrate those better [21:57:21] ArturoVM: I also just wrote java and python client libraries, so you might find them useful http://github.com/yuvipanda/java-mwapi https://github.com/yuvipanda/python-mwapi [21:57:36] ArturoVM: and feel free to poke me with questions! [21:58:04] ArturoVM: a obj-c client lib would be immensely useful - as brion pointed out, we might have (other) native apps in the future [21:59:00] preilly have you by chance reset the mysql root password on mobile-testing? [21:59:09] YuviPanda: Great, thanks once again. If I have any doubts I'll let you know :) I'll start digging around. [21:59:37] ArturoVM: awesome :) [22:00:46] my pack of Horlicks Gold actually contained Chocolate Horlicks, and now I can't eat it *shakes fist* [22:02:32] man, if icons keep getting bigger at this rate, soon we'll need to shoot quad-HD video icons :P [22:03:01] they should just SVG everything [22:03:29] seriously [22:12:26] [WikipediaMobile] brion pushed 1 new commit to master: http://git.io/ZbqNoQ [22:12:26] [WikipediaMobile/master] Better scaled version of 1024x1024 icon - Brion Vibber [22:12:34] Project WikipediaMobile - Nightly builds build #414: SUCCESS in 8.1 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/414/ [22:12:34] Brion VIBBER: Better scaled version of 1024x1024 icon [22:13:07] tfinc: https://raw.github.com/wikimedia/WikipediaMobile/master/scratch/logo-1024.png <- cleaner version of 1024px logo [22:19:01] bah mobile-testing is all f'd up [22:19:08] preilly yt? [22:19:38] * awjr goes back to setting up sphinx locally [22:24:17] tfinc: updated apk sent. [22:24:23] * YuviPanda goes to prep for his talk tomorrow [22:26:57] thanks YuviPanda [22:27:35] tfinc: http://stackoverflow.com/questions/12486549/strange-errors-when-archiving-iphone-app [22:31:11] hmm [22:32:15] http://stackoverflow.com/questions/6517822/do-i-need-to-add-armv6-support-when-limiting-apps-to-ios-4-0 [22:32:26] if we're targeting 4.3 and up then we can kill armv6 :P [22:32:42] otherwise… might have to build with Xcode 4.4? [22:33:06] oh apple, your backwards-compatibility is…. middling [22:39:03] Quick question, do I have to implement all return formats in the API client lib? [22:39:21] ArturoVM: simplest is to just use json, i suspect [22:39:32] most of the others aren't used much, except xml [22:39:45] Indeed. It's a bit daunting to think about implementing all those formats :S [22:39:57] So options for XML and JSON it is? [22:40:57] Also, what's the policy on third-party libs? Am I looking for a particular type of license? (I'm honestly not planing on writing my own JSON parser :P) [22:41:13] ArturoVM: you don't need to support them all! [22:41:20] ArturoVM: just pick one, as fits the language/platform [22:41:38] ArturoVM: my python one stuck to json, while the java one stuck to XML [22:42:01] ArturoVM: and there's no license restrictions - it's your work so you're free to license it as you see fit :) [22:42:17] (though usually it's some BSD / Apache type license that allows free reuse wherever) [22:42:33] ArturoVM: all the formats provide the same data, so pick one! [22:43:19] YuviPanda: Yep, the license thing is not so much about my code, but about other-party code I might use (for example, a JSON parser). [22:43:43] ArturoVM: if you use any GPL libraries, you'll have to license yours as GPL too. [22:43:53] but I'm guessing there're enough BSD ones around [22:44:00] (since you can't put GPL code in iOS apps :P) [22:45:02] Nopes :) Thank you. Back to reading the docs >:P <-- concentrated face. [22:45:12] :D [23:14:20] New patchset: Jdlrobson; "add live class to body for non-beta" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/27838 [23:14:20] New patchset: Jdlrobson; "target blackberry specific rules to live site, add a beta specific one" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/27839 [23:14:21] New patchset: Jdlrobson; "remove unncessary css rules" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/27840 [23:16:55] Maryana: what time are you leaving today? [23:26:44] in a meeting, but i'll be around till 5ish [23:31:19] ok done with meetins [23:31:20] s [23:31:28] back to making ipas [23:31:33] sigh … if only that meant beer [23:31:36] awjr: --^ [23:31:48] heh [23:32:03] thery're even better to drink [23:32:51] ugh our iOS build instructions suck [23:33:18] YuviPanda: where is our Facebook credentials script? [23:33:22] it's no in the build docs [23:33:37] not* [23:35:31] add-keys.bash [23:37:02] preilly: "Wikipedia" has passed validation :) [23:37:19] now i just need to cleanup my build env, submit change, and then cut the beta [23:37:53] tfinc: SWEET [23:45:29] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/27838 [23:47:10] New patchset: Jdlrobson; "add heading at bottom of page with additional languages" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/27847 [23:47:10] New patchset: Jdlrobson; "put lead paragraph in language section and use the same message in overlay" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/27848 [23:48:24] [WikipediaMobile] flyingclimber pushed 1 new commit to v3.2.1-iOS: http://git.io/eVOFxw [23:48:24] [WikipediaMobile/v3.2.1-iOS] Updating build settings for iOS6 - Tomasz Finc [23:48:35] Project WikipediaMobile - Nightly builds build #415: SUCCESS in 10 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/415/ [23:48:36] tomasz: Updating build settings for iOS6 [23:53:55] who's around to test the new ipa ? [23:54:18] curses brion and yuvi are gone [23:58:21] What do you test it with? TestFlight? [23:59:21] ArturoVM: manually through email lists right now [23:59:40] test flight is cool though