[00:05:37] New patchset: Jdlrobson; "restrict cleanup templates to only those that appear in summary" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/28471 [00:09:31] jdlrobson: trying to get the less compiler going locally; installed npm, did npm install less [00:09:38] what do i need to do to get lessc? [00:09:45] did you add to your path? [00:09:59] add what to my path? [00:10:03] less [00:10:05] mine is in /Users/jrobson/.npm/less/1.3.0/package/bin/ [00:10:28] so append export PATH=/Users/jrobson/.npm/less/1.3.0/package/bin/.$PATH to your .profile [00:10:30] where jrobson is your username [00:10:34] ah ok thnx [00:11:10] i'll update the README [00:11:54] oh [00:11:58] i should have read the README :p [00:16:15] New patchset: Jdlrobson; "update README to reflect LESS usage" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/28472 [00:17:09] jdlrobson: did you see MaxSem's comments https://gerrit.wikimedia.org/r/#/c/28470/1 [00:24:27] MaxSem: do you ever sleep ? [00:24:40] mmm [00:24:58] indeed, after SF i'm going to bed closer to 5am [00:25:24] 1 hour's difference is not that much:) [00:25:43] MaxSem: good so since it's 4:25am Thursday (MSK) - Time in Moscow, Russia we can keep you for a little bit longer — sweet [00:29:01] apt-get install node-less [00:30:04] New patchset: Jdlrobson; "provide fallback for left menu for users who do not support jQuery / javascript" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/28470 [00:30:10] preilly: done [00:30:39] MaxSem: can you glance at https://gerrit.wikimedia.org/r/#/c/28470/2 again [00:30:47] I'm looking at it now [00:31:43] jdlrobson: please fix https://gerrit.wikimedia.org/r/#/c/28470/2/stylesheets/less/common/mf-navigation.less [00:31:50] jdlrobson: line 78 [00:32:18] damn you ping why did you kill MaxSem [00:32:20] arggg [00:33:17] New patchset: Jdlrobson; "provide fallback for left menu for users who do not support jQuery / javascript" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/28470 [00:33:23] ^ preilly [00:33:40] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/28470 [00:33:47] jdlrobson: thanks Jon [00:34:52] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/28322 [00:34:52] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/28321 [00:35:30] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/28386 [00:35:30] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/28385 [00:35:30] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/28323 [00:35:51] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/28472 [00:36:23] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/28471 [00:36:27] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/28324 [00:36:44] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/28453 [00:36:56] [bugs] NEW [Bug 41140] Contact us from doesn't reference project (priority: Unprioritized severity: normal) https://bugzilla.wikimedia.org/show_bug.cgi?id=41140 [00:37:24] jdlrobson: what's the status with https://gerrit.wikimedia.org/r/#/c/26492/ [00:38:00] preilly: awjr is looking into it [00:38:49] that patcshet should probably be abandoned [00:39:09] Change abandoned: preilly; "(no reason)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/26492 [00:39:18] awjr: okay sounds good [00:40:33] awjr: so is https://gerrit.wikimedia.org/r/#/c/28434/ just waiting on this https://gerrit.wikimedia.org/r/#/c/28433/ core change? [00:41:12] preilly: i believe so [00:41:30] awjr: okay cool just making sure [00:42:17] fo sho [00:42:23] New review: preilly; "Requires core changes: https://gerrit.wikimedia.org/r/28433" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 0; - https://gerrit.wikimedia.org/r/28434 [00:48:33] jdlrobson: do you know why i might not be getting url expansion for background-images define in mf-navigation.css? [00:48:47] huh? [00:48:56] doing something like: [00:48:56] #mw-mf-login .error { [00:48:56] border: solid @overlayBorderWidth @overlayAlertErrorColor; [00:48:56] background-image: url( images/fail.png ); [00:48:56] } [00:49:31] for some reason MW is not finding the image [00:49:51] it's looking in the wrong place. [00:49:51] tfinc: should we save that guy from Terry? [00:50:09] lolz. how long has it been since he got a word in ? [00:50:13] tfinc: he is going on 50:13 [00:50:21] your timing him aren't you ? [00:50:26] tfinc: yes [00:51:20] tfinc: http://www.online-stopwatch.com/ [00:53:26] awjr: is the image in the less folder ? [00:53:39] it should be in stylesheets/specials/images [00:53:44] as it is relative to the generated stylesheet [00:53:56] tfinc: preilly haha [00:54:10] yeah that's what i thought; the image is in stylesheets/common/images/W.png [00:54:16] that's the wrong place [00:54:38] but the stylesheet is in stylesheets/common/mf-navigation.css [00:54:39] so… isn't that the right place? [00:55:07] i'm getting confused [00:55:21] background-image: url( images/fail.png ); is in mf-login.less no? [00:55:40] which is in stylesheets/less/specials/ [00:56:04] no, in this case it's in stylesheets/less/common/mf-navigation.less [00:56:18] ok what is the exact line? [00:56:20] background-image: url( images/fail.png ); ? [00:56:33] #mw-mf-login .error { [00:56:33] border: solid @overlayBorderWidth @overlayAlertErrorColor; [00:56:33] background-image: url( images/fail.png ); [00:56:33] } [00:56:38] ok [00:56:41] so stylesheets/common/images/fail.png exists? [00:57:01] yes [00:57:10] can you share the code? [00:57:22] sure do you want the less code? [00:57:24] New patchset: Jdlrobson; "move mf-cleanuptemplates.css to less file" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/28474 [00:57:24] New patchset: Jdlrobson; "change font color of cleanup templates" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/28475 [00:57:24] New patchset: Jdlrobson; "cleanup less file" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/28476 [00:57:30] awjr: the whole thing [00:57:31] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/28434 [00:57:35] can you git review it? [00:57:48] er i guess so; it's not really in a clean state to push to gerrit [00:57:56] awjr: I got Tim and Reedy to review https://gerrit.wikimedia.org/r/#/c/28434/ [00:58:02] awjr: it's now merged [00:58:05] nice preilly [00:59:56] [bugs] NEW [Bug 41141] Meta-Wiki mobile site has errant trademark symbol (™) in footer (priority: Unprioritized severity: normal) https://bugzilla.wikimedia.org/show_bug.cgi?id=41141 [01:01:55] jdlrobson: are the paths correct in https://gerrit.wikimedia.org/r/#/c/28474/1/stylesheets/less/modules/mf-cleanuptemplates.less ? [01:02:11] New patchset: awjrichards; "initial stab at login error handling" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/28477 [01:02:18] jdlrobson: ^ [01:02:19] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/28476 [01:02:20] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/28475 [01:02:20] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/28474 [01:02:23] preilly: yup [01:02:27] jdlrobson: thanks [01:02:50] New review: awjrichards; "just pushing this initial changeset for jon to review; not ready for merge." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -2; - https://gerrit.wikimedia.org/r/28477 [01:03:03] awjr: is 23 in https://gerrit.wikimedia.org/r/#/c/28477/1/MobileFrontend.i18n.php and empty line? [01:03:15] awjr: and 158 ? [01:03:29] preilly: yeah; btw i −2'd that changeset [01:03:31] awjr: white space on https://gerrit.wikimedia.org/r/#/c/28477/1/includes/skins/UserLoginMobileTemplate.php line 28 [01:04:02] thanks [01:04:35] awjr: if you are just pushing this initial changeset for jdlrobson to review; not ready for merge — shouldn't you be using an experimental branch and not master? [01:04:49] tfinc: 1 hour 4 minutes and 49 seconds [01:04:50] probably [01:05:01] tfinc: stop watch stopped [01:05:14] preilly: yeah good point, i didnt really think about it [01:06:50] preilly: do we have a leader board of who's had the longest direct talk with terry [01:06:51] ? [01:07:19] tfinc: no but we should [01:07:26] awjr: okay no worries [01:07:40] awjr: it would just avoid an accidental merge to master [01:07:51] preilly: yeah you're right; next time :) [01:07:52] awjr: is it more like the gist approach in gerrit land [01:08:01] yeah [01:10:09] awjr: you could also maybe commit the images in another commit [01:10:26] awjr: to at least get those merged and available for caching reasons, etc [01:10:54] jdlrobson: i've got to go in a minute but will pick this back up tomorrow afternoon. [01:11:03] awjr: yeh i'm not working out what's wrong so far [01:11:15] is it working for you locally? [01:11:38] or do you mean in terms of just looking at the code jdlrobson? [01:13:20] awjr: ahh [01:13:24] it's because you have whitespace [01:13:36] background-image: url(images/W.png); [01:13:57] i guess ResourceLoader chokes on that [01:14:07] yeah 354 » background-image: url( images/W.png ); [01:14:11] fail [01:14:25] * awjr facepalm [01:14:32] spaceiness [01:14:38] thanks :p [01:15:16] awjr: it's always the simple stuff that kills us [01:15:20] true story [01:15:31] * preilly citation needed [01:17:20] ok im out [01:17:22] see you guys tomorrow [01:17:28] thanks again jdlrobson, preilly [01:20:08] i love how simple they have it http://codeascraft.etsy.com/2011/02/15/measure-anything-measure-everything/ [01:21:15] jdlrobson: RequestHeader set X-CARRIER "Saudi Telecom" [01:21:57] tfinc: ah are you a tithing member of the Church of Graphs ? [01:22:36] preilly: i was talking about measuring the next set of changes to prod with howie and this came up [01:22:55] tfinc: nice [01:24:24] preilly: do I have to set a query string as well? this is not showing me a banner :( [01:24:39] jdlrobson: add $wgEnableZeroRatedMobileAccessTesting = true; to your LocalSettings too [01:25:07] jdlrobson: also add RequestHeader set X-SUBDOMAIN "ZERO" to your .htaccess [01:27:38] thanks preilly that did the trick! [01:27:44] anyway to switch between different banners? [01:37:49] jdlrobson: change the text in the .htaccess file [01:38:03] ah perfect thanks :) [01:38:05] jdlrobson: for X-CARRIER [01:38:47] jdlrobson: carriers and options are located on http://en.wikipedia.org/wiki/MediaWiki:Zero-rated-mobile-access-carrier-options [01:39:10] preilly: some background - i want to remove the zero specific styling code from mobile frontend - i want to make it more generic [01:39:25] jdlrobson: that's fine too [02:09:31] tfinc: i see you're up [02:09:41] or at least was, 15 minutes ago [02:10:20] YuviPanda: i'll be in the office for around 30 more min [02:10:57] you're still in the office? wah, ok. [02:12:51] * tfinc knods [02:12:57] its almost like i really like what i do [02:13:13] :D [02:14:03] tfinc: tested the commons app? [02:15:09] YuviPanda: already filed an issue and responded to you [02:15:15] check your email [02:15:29] yeah, but I take it that the auth + upload process worked [02:15:32] s/but/so/ [02:15:44] YuviPanda: worked like a charm [02:15:59] i like the time savings by using the native account framework [02:16:04] sweeeet! [02:16:19] you met my challenge very well [02:16:30] it's more than time savings - it means any app can use your commons account (with permission, of course) and they won't have to know your password! [02:16:37] it's almost like we've client side OAuth :) [02:16:55] YuviPanda: what would we have to do in order for the Wikipedia App to have access to it? [02:17:10] tfinc: indeed! So not counting auth we're very well inside our 10s limit :) [02:17:25] tfinc: reasonably simple. I wrote it to be generic to any mediawiki instance [02:17:47] of course, we'll need to figure out what we're gonna do *after* we log in on the wikipedia app :) [02:17:52] YuviPanda: as soon as i saw the account page it made crazy having a images uploaded interface [02:18:21] YuviPanda: watch lists are launching on mobile web shortly [02:18:51] indeed, that's the next step - but I wanted to sketch out use cases for images uploaded, and related functionality first before going in [02:19:07] plus I still have polish work to do - error handling, adding categories, and geo tagging [02:19:25] tfinc: we also need to figure out if we're going to do 'one app that does everything' or a 'collection of small apps that do one thing well' [02:19:32] what's nice about uploaded images is that the use case doesn't matter. start off with a dead simple this is what you uploaded [02:19:42] then later add a this is where this image is used [02:19:47] i'd love to see that about my uplaods [02:19:53] but in a non shitty inteface [02:20:01] s/uplaods/uploads [02:20:09] thanks preilly spelling bot [02:20:11] s/inteface/interface [02:20:22] tfinc: one more and I'll force you to go home [02:20:30] your always there for me when i need it [02:20:30] indeed, but I'll have to build an interface that shows 'list of images' [02:20:30] :D [02:20:44] it's not even friday! [02:20:44] s/your/you're [02:20:51] my 16GB nexus 7 - I'll get my hands on it today [02:20:53] just wait until i forget a " ' " and yuvi gets pissed off at me [02:21:02] and with that note its time for me to go home ... [02:21:03] tfinc: you just did [02:21:06] :P [02:21:34] YuviPanda: when would your first day be with us ? [02:21:41] half time work that is [02:21:45] still 1/2013 ? [02:21:46] or sooner [02:21:58] tfinc: I've exams till 18 Dec [02:22:09] so I guess still 1/2013 [05:56:58] New patchset: Jdlrobson; "remove special casing for ZeroRatedBanner" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/28483 [05:56:58] New patchset: Jdlrobson; "cleanup alias" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/28484 [05:56:59] New patchset: Jdlrobson; "replace wikipedia zero css with generic css" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/28485 [06:00:26] [bugs] NEW [Bug 40987] Clicking jump back a section doesn't work on WP7 (priority: Unprioritized severity: normal) https://bugzilla.wikimedia.org/show_bug.cgi?id=40987 [08:33:17] MaxSem, Lvova has some comments about Special:MobileFeedback. [08:33:31] https://twitter.com/intent/tweet?in_reply_to_status_id=258846328174559233&source=webclient&text= [08:33:31] cool [08:34:27] yeah, we know that it sucks [08:34:49] the empty emails? [08:35:01] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/28483 [08:35:23] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/28484 [08:36:48] MaxSem: you around? [08:36:55] yup [08:37:06] MaxSem: can you do me a quick favor? [08:37:12] MaxSem: rebase https://gerrit.wikimedia.org/r/#/c/28485/ for me [08:37:31] MaxSem: I'm on a plane right now with so so connectivity [08:39:00] SFO — JFK Altitude = 36,966 feet Speed = 589 mph [08:40:01] New patchset: MaxSem; "replace wikipedia zero css with generic css" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/28485 [08:40:15] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/28485 [08:40:23] MaxSem: thanks so much [08:40:34] welcome:) [15:02:53] preilly, are you around? [17:09:41] MaxSem: yes [17:13:35] New patchset: Jdlrobson; "add heading back to non-beta" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/28529 [17:13:57] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/28529 [17:24:36] * yuvipanda pokes jdlrobson  [17:32:22] hey yuvipanda [17:36:28] New patchset: Jdlrobson; "limit navigateToPage history api to beta" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/28533 [17:37:15] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/28533 [17:45:21] tfinc: i will be in after lunch to try out the hammock :D [17:45:57] jdlrobson: did the stand come in? [17:46:05] :D [17:46:20] awesome [17:46:23] * tfinc wonders how much trouble this will get him into :) [17:46:27] * tfinc is eager to find out [17:46:30] :D [17:46:35] heh heh [17:49:22] awjr: You have been un-subscribed from the following groups: CiviCRM .. end of an era for me [17:49:28] awjr: i do love how your on their site [17:53:08] tfinc im on their site?! [17:54:09] awjr: load http://civicrm.org/ [17:54:22] they randomize the photos but you'll see yourself in the top banner [17:54:32] it even quotes you [17:55:32] oh hey! [17:55:33] sweet [17:56:31] brion: beat you to that response by 3min ! [17:56:47] * brion shakes fist of asynchronous communication rage [17:56:56] mwhahah! [17:59:41] aww microsoft surface rt pre-orders are backed up [17:59:54] pity… i want the intel version though, the arm's too locked down [18:00:14] and that ain't coming out for a couple more months [18:05:29] New patchset: Jdlrobson; "fix references when using dynamic sections (bug 41118)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/28539 [18:05:29] New patchset: Jdlrobson; "styling fixes" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/28540 [18:05:29] New patchset: Jdlrobson; "remove references specific code using a trigger" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/28541 [18:05:53] jdlrobson: whitespace https://gerrit.wikimedia.org/r/#/c/28539/1/javascripts/modules/mf-references.js [18:05:59] jdlrobson: line 155 [18:06:13] bahhh [18:06:16] yuvipanda: you about? wanted to check on status of android app stuff [18:06:27] (but impressive response time - is that preilly bot?!) [18:07:11] New patchset: Jdlrobson; "remove references specific code using a trigger" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/28541 [18:07:11] New patchset: Jdlrobson; "styling fixes" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/28540 [18:07:11] New patchset: Jdlrobson; "fix references when using dynamic sections (bug 41118)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/28539 [18:08:28] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/28539 [18:08:52] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/28541 [18:08:53] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/28540 [18:10:41] preilly: any objection to this wording change? https://gerrit.wikimedia.org/r/#/c/28000/ [18:10:46] for zero [18:11:58] brion: merged and approved [18:12:03] \o/ [18:24:41] fuck it. you know i can't not order this surface thing. damn you microsofffffffttttttt [18:24:54] damn you [18:53:39] brion: yesterday you said that you were able to get saved pages to work across upgrades on the Wikipedia iOS app [18:53:44] is that still the case? [18:55:00] tfinc: i wasn't able to, because the current market version of the app doesn't appear to actually save data across invocations [18:55:00] so there was nothing to load up in the new version [18:58:21] brion: what happens when you save with 3.1.2 and upgrade to 3.2 and then 3.2.1 [18:58:22] do you still see them? [18:58:55] hmm, lemme test if i can [18:59:20] * tfinc gets back to his desk for the first time today and notes that he is the only member of the mobile team in the office [18:59:40] anyone seen preilly ? [18:59:55] i don't see a 3.1.2 branch or tag in the repo…. i'll try the .ipa on my older ipod [19:00:20] brion: lola http://www.mediawiki.org/w/index.php?title=Mobile%2FRelease_history&diff=593587&oldid=590650 "§=== Wikipedia ===" [19:00:25] i'm not even sure how to make that cahracter [19:00:28] lolz [19:01:13] option+6 [19:01:22] §§§§§§§§§ [19:01:36] not sure how it got in there though :D [19:02:19] §§§§ [19:02:20] nice [19:02:27] ¡™£¢∞§¶•ªº [19:04:06] brion: is this iOS6? [19:04:23] yuvipanda: yeah [19:04:38] sigh, I think we had the same issue when iOS 5.1 hit [19:05:04] (or it might have been 4.x after we made some changes for 5.1) [19:08:51] * brion waits for itunes to sync… wheee [19:09:29] arm chrome book, oooh! http://arstechnica.com/gadgets/2012/10/google-wants-new-249-arm-based-chromebook-to-be-your-second-computer/ [19:15:58] for some reason it keeps syncing 3.2 to my iPod :( [19:16:13] delete and try again... [19:17:12] grrr still giving me 3.2 [19:19:14] there, got 3.1.2 installed [19:20:33] aaaand 3.1.2 doesn't fully save under iOS 6 [19:20:33] i think short of downgrading to iOS 5 i can't test this [19:22:00] and… it sounds like that takes a jailbreak. wtf? [19:23:14] ah looks like i can downgrade… let's try this [19:25:01] whyyyyy is iTunes the management tool for iDevices? it's like managing a unix config with a blunt spade [19:31:52] downgrading [19:35:42] aggh it won't downgrade [19:37:53] tfinc: Any plans for a WLM mobile app evaluation meeting? [19:39:29] * brion stabs iTunes -- it won't let me downgrade even if i put the iPod in recovery mode [19:41:46] preilly: i forget what it's called - but those black plastic things for the hammock that were on my desk - did you take one? [19:41:51] i've lost one and need it for the hammock! [19:42:37] the stand is huge [19:43:43] jdlrobson: no [19:43:56] jdlrobson: why in the world would you think I took it? [19:44:23] tfinc: I've seen preilly [19:46:03] preilly: i just remember us messing around with them and wondered if they moved to another desk [19:46:08] did we break one? [19:46:18] I don't think so [19:53:25] awjr: ping [19:53:27] preilly: pong [19:54:08] awjr: may I send you a pm [19:54:13] preilly: sure [20:00:18] mtg, anyone? [20:01:16] awjr: ping [20:01:32] pong [20:01:43] awjr: are we having a meeting now or is my calendar incorrect? [20:02:30] hey MaxSem just getting setup [20:03:32] whee [20:03:32] Maryana, ^^ [20:55:14] jdlrobson you there? [20:55:38] hey Munaf yup [20:55:39] downstairs [20:56:54] preilly, do you still need mobile-feeds on Labs? it's already broken and I wonder if we should just go ahead and delete it [20:57:26] This was how I spent my morning — http://imgur.com/RLVrU [20:57:38] MaxSem: you can delete it [20:57:52] thanks [21:06:22] jdlrobson, come up to 6 and hang out when you get the chance [21:06:22] whole lotta designing going on up here [21:33:00] bug alert: level 3 & 4 section headers aren't being recognized in beta and show up as plaintext [21:35:16] link? [21:37:11] platonides: https://en.m.wikipedia.org/wiki/Barack_obama#section_2 [21:37:16] w/beta enabled, of course [21:44:17] oh, I thought you meant wmflabs [21:45:58] heh [21:46:13] no, mobile site. carry on :) [22:18:44] New patchset: Jdlrobson; "shrink heading size based on feedback" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/28619 [22:26:37] New patchset: Jdlrobson; "correctly place headings in h3,h4,h5 in dynamically loaded content (bug 41192)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/28620 [22:37:33] Hi, could somebody please explain to me what the Version ".5" for "Wikimedia Mobile" in Bugzilla refers to? [22:43:27] andre__: 'Wikimedia Mobile' component is kinda obsolete [22:43:55] generally, report bugs either against 'Wikipedia app' for the apps, or 'MediaWiki extensions' -> 'MobileFrontend' for the mobile website [22:45:00] brion, Hmm, is that consensus among the mobile hackers? Because in that case I'd move the remaining tickets and close it for new entries. [22:45:21] i think some entries are still relevant ….. it's confusing :) [22:45:47] Yeah, and I'd like it to be not confusing. :) [22:47:18] brion: so before stepping on somebody's toes I should probably drop a line on mobile-l@ mailing list and propose that I clean up Bugzilla? [22:47:26] sounds wise [22:47:32] k. thanks! [22:50:02] andre__: its a left over from the ruby gateway [22:50:06] id remove it if bugzilla let me [22:50:13] andre__: kill it! [22:50:36] i tried to delete it but it wouldn't let me [22:50:41] andre__: just kill the version [22:50:58] hehe, yeah, because you cannot delete a product if it still has bug reports [22:51:10] andre__: correct [22:51:16] I will kill it once I've arrived there in my evergrowing todo list [22:51:39] \o/ [22:51:39] on a related note (assuming that mobile can tell me): What's the story behind the "Web browser" and "Mobile platform" fields in Bugzilla? [22:51:47] and are they really used by the mobile team for querying? [22:51:55] andre__: we asked the former bug master to add them [22:51:59] it took forever to get them [22:52:15] but why? :P [22:52:22] * andre__ playing evil cop [22:52:22] the current os list only had desktop os [22:52:30] so their irrelevant [22:52:44] I agree. I just wonder why nobody edited that list then :P [22:52:53] * andre__ considers to simply merge Mobile Platform into Platform to get rid of this one additional field [22:53:56] andre__: we don't want *any* desktop os in the platform [22:54:03] their useless to us [22:54:20] can we get rid of them for just mobile ? [22:54:47] I don't think so, no [22:55:10] still I wonder if it's a big disadvantage to merge these two lists into one. (It will have more entries, sure.) [22:55:46] andre__: thats why we did a separate field [22:55:50] andre__: it'll be pure noise to have the desktop os list [22:56:36] heh, I've heard people saying that the "Mobile Platform" field is pure UI clutter :) [22:56:40] but I get your point, yeah [22:57:06] andre__: then only show it for mobile [22:57:32] tfinc: that's kind of possible in current Bugzilla, and totally possible after upgrading it. [22:57:43] andre__: then everyone wins [22:57:43] :D [22:57:43] whee [22:57:51] we all get trophies? [22:57:52] kind of means: I can only define one single condition, like if product=foo then show it [22:58:07] so as you use several products that won't work (yet). [22:58:18] anybody volunteering to upgrade Bugzilla to 4.2? ;) [22:58:36] anyway, that's my questions for now. Thanks to you two for listening & answering! [22:59:45] andre__: don't you guys own bugzilla? shouldlnt we ask you to upgrade it ;) [23:01:22] The plural should probably be a singular, and while I administrate it now it doesn't mean that I enjoy hacking on it. ;) [23:01:35] New patchset: awjrichards; "Adds styled login error handling and login info box" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/28629 [23:03:47] New patchset: awjrichards; "Adds styled login error handling and login info box" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/28629 [23:05:00] andre__: fair enough. give that its front and center for all of us [23:05:04] we need someone to lead it [23:06:09] Yeah, I'll discuss it... [23:06:44] New patchset: Jdlrobson; "switch to lighter chrome to be consistent with vector" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/28630 [23:07:24] jdlrobson: there may be some stuff in https://gerrit.wikimedia.org/r/#/c/26492/5 that you want in MF that i might not be picking up in the login work; it's hard for me to know exactly what is what in the css (particularly with the overlay-specific stuff), but i am taking the stuff that seems pertinent to login [23:09:57] awjr: do not follow.. [23:10:33] jdlrobson: there is a lot of css and some js in your original commit that i am not using for login, since you were initially building the login as an overlay [23:10:49] you haven't built it as an overlay? [23:11:07] there is a chance that there are some things in the css/js that you might be expecting to show up in MF that i may not pick up in the login work, so i just wanted to give you a heads up [23:11:14] no, it is not supposed to be an overlay [23:11:22] it is… brandon told me so [23:11:35] or has that changed? [23:11:55] oh [23:11:55] wells hit [23:12:09] the word 'overlay' appears nowhere in the card nor in the design spec [23:12:37] http://www.mediawiki.org/wiki/File:Mobile-Login---Login-Screen.png < it's meant to look like that [23:12:38] which is attached on the card [23:12:54] which is a picture of an overlay [23:12:58] right.. but how am i supposed to know that that is an overlay? [23:13:22] ok, perhaps i am displaying my design ignorance here [23:13:42] well let's back up a minute [23:13:51] does the login form look like that? [23:13:57] ie. does it look like an overlay [23:14:07] (since we have overlays already which look like that) [23:14:27] it should just be a case of adding an overlay class to the html [23:14:34] like my original patchset [23:14:48] i'd have to catch up with what you've been doing before I can be of more use [23:14:52] i've not taken a look at the code [23:14:57] the login form that i have been working on currently does not look like that; but i did not realize that that image represented an overlay [23:15:02] like i said, displaying my ignorance [23:15:17] ignore the code i've checked in, i need to redo some things now [23:15:46] it's ok though, this makes it easier as i should be able to just use the code you committed rather than cherry pick form it [23:15:47] s/form/from [23:16:44] Change abandoned: awjrichards; "took an incorrect approach here." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/28629 [23:18:11] perfect awjr [23:19:29] New patchset: Jdlrobson; "add 2px padding to left of search box" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/28632 [23:19:29] New patchset: Jdlrobson; "shrink margins for smaller displays" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/28633 [23:19:29] New patchset: Jdlrobson; "throw away navigation related media queries" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/28634 [23:28:17] New patchset: awjrichards; "Update gitignore to ignore node_modules/" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/28638 [23:29:17] okay, mobile-testing is now set up with Solr, a script is currently populating the DB [23:34:37] New patchset: awjrichards; "Adds unstyled login error message handling and login info box" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/28639 [23:35:35] jdlrobson, vibha revisited the language selector design & has some comps for you [23:35:47] should she attach them to the mingle card? do you just wanna take a look?