[00:06:22] New patchset: MarkAHershberger; "Fix syntax error" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/28964 [03:00:13] New review: Jdlrobson; "Looks like a bad merge /rebase - feedback should be wrapped.in an if.statement" [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/28964 [13:37:44] yuvipanda: are you still contracting? [14:01:09] New patchset: MarkAHershberger; "Fix syntax error introduced in Ifc89d8a503efb79f0febf371ff9d345811014895" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/28964 [14:41:43] what do I need in local.properties for "target" [14:42:38] putting "target=android-10" gives me "Unable to resolve project target 'android-10'" [14:47:10] hexmode: do you have level 10 installed in the Android SDK manager ? [14:48:00] thedj: not sure how to test that, let me check [14:48:56] thedj: ah, api level [14:49:37] * hexmode installs [14:50:09] common problem :D and the tooling isn't too communicative about possible/likely causes. [14:50:47] * hexmode thinks the wiki page needs an FAQ for this ;) [15:11:40] thedj: worked, thanks! [15:42:43] New patchset: Jdlrobson; "return if statement removed in 95b54bcdbb99e4783ad36e896e092adaded8117c" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29329 [15:45:19] New patchset: Jdlrobson; "run make less" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29330 [15:50:49] New patchset: Jdlrobson; "reflect login changes for what should be in beta" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29331 [16:47:47] awjr, hi [16:47:55] hi OuKB [16:47:55] how's it going [16:47:55] ? [16:47:58] how's your sed-fu? [16:48:25] definitely not ninja-strength [16:48:37] what do you need? [16:49:06] figure out why doesn't it work: [16:49:08] sed -i 's/\/\/g' solr.xml [16:50:03] I tried w/o escaping < and > too [16:50:52] hmm [16:50:59] can you send me solr.xml or some portion of it? [16:53:54] [16:54:30] OuKB: sorry one sec, i just need to finish writing an email and i'll take a closer look [16:54:51] np [17:10:21] preilly: will you be on for regular PDT hours today ? [17:10:28] tfinc: yes [17:10:33] preilly: thanks [17:10:44] tfinc: I've looped in Asher on the stats issue [17:11:10] tfinc: It seems that some of the stats aren't getting reported or collected correctly [17:12:20] preilly: respond on the thread so that howie knows what's available and what's in flux [17:12:27] OuKB: looking at your sed expression… i think sed doesn't support the non-greedy quantifier [17:12:34] OuKB: try this instead: [17:12:40] 's///g' [17:12:41] subject: Mobile analytics 10/19 [17:12:44] tfinc: okay I'll respond [17:12:48] oh shi~~~ [17:12:52] thanks Arthur [17:13:07] er actually you might want [17:13:16] 's/]*>//g' [17:16:05] FWIW awjr i'm not too comfortable with us pushing changes out to live wiki today [17:16:19] the fact my stuff got merged so late last week doesn't instill me with confidence [17:16:23] jdlrobson: ok; coordinate with max as he's managing the deployment [17:17:14] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/28964 [17:17:29] jdlrobson: https://gerrit.wikimedia.org/r/#/c/28964/ was indeed a bad rebase [17:18:10] jdlrobson, ok. you have a couple of hours to change your mind [17:18:25] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29329 [17:18:30] GitHub users: http://prose.io/about.html "Prose is a web-based interface for managing text-based content in your GitHub repositories. Use it to create, edit, and delete files, and save your changes directly to GitHub." [17:19:07] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29330 [17:19:38] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29331 [17:19:53] okay cool https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/MobileFrontend,n,z [17:20:09] awjr: what is the cut off time for changes before the deployment today? [17:21:39] mmm my phone can't get any sort of data network at the moment [17:21:41] that's sucky [17:22:46] jdlrobson: does wifi work? [17:23:31] yup [17:23:42] preilly: ask MaxSem [17:24:11] preilly, FWIW awjr i'm not too comfortable with us pushing changes out to live wiki today [17:26:24] MaxSem: preilly awjr I'm comfortable with pushing to test wiki though [17:27:13] ok. preilly the cutoff will be 1 hour before the deployment [17:27:22] heading into the office, catch y'all in a bit [17:29:02] MaxSem: is it just wmf/1.21wmf1 right now? [17:29:38] wmf2 [17:29:56] MaxSem: both 1 and 2 or just 2? [17:30:27] if we suddenly decide to deploy everywhere I'll deploy to wmf1 too - otherwise wmf2 which is what testwiki is running [17:30:53] note enwiki will be running wmf2 in half an hour or so [17:31:25] Reedy: okay thanks for reminding us [17:31:45] MaxSem: basically I want to make sure that zero gets updated too [17:32:12] preilly, can we test zero on testwiki? [17:32:28] MaxSem: yes it's possible [17:32:41] MaxSem: let me figure out the best way to do it [17:37:21] Tpt: hi Thomas. [17:37:53] notnarayan: Hi ! [17:38:23] notnarayan: I've just added your new icon to the app: https://github.com/Tpt/WikisourceMobile/commit/1ca27cdec96d475dce866f79cd8140bd09362770 [17:38:32] Thanks a lot ! [17:39:13] Tpt: iv updated the icons [17:39:13] Tpt: heres the search icon http://commons.wikimedia.org/wiki/File:Wikisource_Search_icon_80_80px.png [17:40:03] Tpt: thats wonderful. When does this app launch? [17:41:32] notnarayan: When the WM staff agree to publish it. [17:41:46] Tpt: :) [17:42:15] The integration to TranslateWiki is not done and have to be done before deployment. [17:48:11] New patchset: Jdlrobson; "change selector" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29347 [17:50:44] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29347 [17:50:58] did brion say he was coming into the office ? [17:51:11] tfinc: yes [17:51:15] thanks [17:51:18] tfinc: he is on his way in right now [17:52:01] tfinc: You have returned from away. [17:52:02] [12:43pm] ***: Buffer Playback... brion: heading into the office, catch y'all in a bit [17:52:03] [1:27pm] brion left the chat room. (Quit: awayyyy) ***: Playback Complete. [17:59:55] Reedy: not currently, no [18:00:00] k, ta [18:00:02] hexmode: around? [18:00:17] hexmode: what android versions do you have installed? via the sdk? [18:00:42] yuvipanda: sorry should have followed up [18:00:52] thedj helped me fix it [18:00:56] :) [18:01:01] seems like an FAQ [18:01:25] hexmode: ah, okay. Should add to build instructions [18:07:29] yuvipanda: yeah, especially for those of us who have never built an android app [18:08:12] hexmode: I see you have a fork :) [18:10:32] yuvipanda: yeah, I'll probably build my own toy app there :) [18:13:40] hexmode: wonderful :) [18:16:25] yuvipanda: howdy [18:16:30] tfinc: hello [18:16:37] yuvipanda: do you still have a device with iOS5.x ? [18:16:40] tfinc: I do! [18:16:44] but I'm currently in a bus. [18:16:52] iPod Touch running 5.1 [18:16:58] yuvipanda: why am i not surprised :) [18:17:05] tfinc: want me to test something? [18:17:19] yeah, sitting in one room in one city doesn't quite work for me :) [18:17:34] doing a wiki hackathon next week at a different city too :) [18:19:07] yuvipanda: yes. i want to test wether saving within the Wikipedia app (vers 3.2.1) on iOS6.x works if you starts with WP App (vera 3.1.2) on iOS5 [18:19:13] vers* [18:19:30] hmm, so it's an upgrade test? [18:19:30] yes [18:19:35] this would mean I won't have an iOS 5.x device anymore. Is that ok? [18:19:37] [the reason we have to start on iOS 5 is that 3.2/3.1.2 don't actually save on iOS 6 :P ] [18:20:04] what i'm trying to find out is if it'll bring back the saved pages from people who started on iOS5 [18:20:12] ah, okay [18:20:35] any iOS5 users can upgrade to iOS6 [18:20:46] so, 1. Save pages on 5.1, 2. upgrade phone to 6 3. Check if previously saved pages exist 4. Upgrade app to master(?) 5. Check if previouslsy saved pages exist [18:22:43] we'll have to choose one of these [18:22:51] 1) upgrade to 3.2.0 (see that they don't work) then upgrade to master [18:22:51] 2) upgrade directly to master [18:23:07] * yuvipanda notes that he is on a bus, connectivity may go down anytime [18:23:30] preilly: do we have a song for yuvipanda titled "i'm on a bus" yet ? [18:23:50] tfinc: no but we really should get working on that [18:24:02] tfinc: we can shoot the music video at the DevCamp [18:24:31] :D [18:26:13] * yuvipanda spent yesterday working on building a game of 'unbeatable pong'. Has since lived up to its name :) [18:26:39] yuvipanda: i saw that. what made you write it in py ? [18:26:43] tfinc: I shall try out the tests tomorrow [18:26:53] tfinc: oh, I can write it in py and deploy to Android! [18:26:55] yuvipanda: tomorrow your time or tomorrow our time ? [18:27:06] tfinc: and it gives me easy access to OpenGL stuff, and is pretty fast [18:27:09] tfinc: tomorrow my time [18:27:12] its the only thing blocking releasing this to the market [18:27:34] will mail out before you guys come on [18:28:06] tfinc: did you get any responses to the 'commons admins wanted for devcamp!' email you sent? [18:28:18] yuvipanda: not a peep from the local community [18:28:20] yuvipanda: who can we find? [18:29:13] tfinc: poke srikanthlogic [18:29:15] he should have a wmf email id [18:29:49] did I miss anything? [18:29:58] yuvipanda: no [18:30:01] tfinc: he should be able to find you people [18:30:09] k [18:47:41] jdlrobson: will dynamic sections be going today as well ? [18:48:34] can someone take a look at https://gerrit.wikimedia.org/r/#/c/28863/ please? not urgent, but I'd like a couple of extra eye sockets weigh in [18:50:29] I'm off to lunch [18:51:37] tfinc: Hi ! [18:51:38] I've finish my work in order to make a first version of Wikisource app working. [18:51:40] The next step is to begin translation work using Translatewiki but I believe that the app might be in GitHub Wikimedia repositories in order to make it work. [18:51:45] Do Wikimedia team agree to publish a Wikisource app. If yes it's time, I think, to move it to Wikimedia's repository. [18:51:55] Tpt: hey there. i've been folioing your wiki source work. great job! [18:52:43] any here object to moving it to github wikimedia repot ? [18:55:01] brion: preilly yuvipanda MaxSem ? [18:55:16] go for it [18:55:35] yup [18:57:51] +1 [18:59:54] Tpt: sounds like we have consensus then :D [19:00:44] tfinc: Very good news ! Thanks ! :-D [19:03:09] New patchset: Jdlrobson; "remove legacy css" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29424 [19:03:10] New patchset: Jdlrobson; "update mixin to provide -o-background-size support" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29425 [19:03:10] New patchset: Jdlrobson; "move initialisation of MFE to script tag in head" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29426 [19:03:11] New patchset: Jdlrobson; "add 3rd event listener parameter" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29427 [19:03:11] New patchset: Jdlrobson; "revert to non-javascript mode on really slow connections" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29428 [19:04:15] New patchset: Jdlrobson; "revert to non-javascript mode on really slow connections" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29428 [19:04:38] Tpt: you'll have to create all the media/text for the google play market but i'm happy to help to put it up on the sotre [19:04:54] Tpt: let me know when your read to a) move the repot b) have all the assets and text [19:04:58] * tfinc ponders lunch [19:08:27] tfinc: We need to setup translation system before publication : there are a lot of strings that are ever with "Wikipedia" instead of "Wikisource". [19:09:24] hrm. not a fan of the light chrome on the new beeta. [19:09:26] beta, even. [19:09:38] Tpt: k [19:16:50] What I've to do in order to add Wikisource app to translatewiki ? Ask to siebrand ? [19:19:17] Tpt, yes [19:19:53] MaxSem: Ok. Thanks ! [19:56:05] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29424 [19:57:31] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29425 [20:00:10] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29426 [20:00:32] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29427 [20:06:16] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29428 [20:09:08] preilly did you test https://gerrit.wikimedia.org/r/#/c/28654/4 ? i am getting a syntax error from that changeset [20:14:06] meh appears to have been fixed elsewhere [20:25:16] awjr: are you having any issues loading the hangout ? [20:25:27] tfinc havent tried yet [20:25:30] tfinc one sec [20:25:33] took foreer [20:25:36] there we go [20:25:48] hmm "We're sorry, we seem to be taking too long processing your request." [20:25:55] New patchset: Jdlrobson; "add -moz vendor prefix for background size mix-in" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29435 [20:27:31] awjr: heads up that i'm having zero luck joining the hangout [20:28:38] tfinc same. try this: https://plus.google.com/hangouts/_/fda4278e531be9612bff1ef1cee42467f6b1bf2e?pqs=1&authuser=0&hl=en [20:28:51] i started a new one without a problem though [20:29:58] jcmish, MaxSem: the hangoug link in the calendar invite for the retro appears to not be working - use this instead: https://plus.google.com/hangouts/_/fda4278e531be9612bff1ef1cee42467f6b1bf2e?pqs=1&authuser=0&hl=en [20:29:58] so everyone should go to the new one? [20:30:05] MaxSem: yes [20:30:41] but the etherpad link in the invite is fine [20:31:11] etherpad: http://etherpad.wikimedia.org/mobilenav-sprint2-retro [20:31:33] jcmish, brion, tfinc, jdlrobson [20:31:45] whee [20:32:09] awjr: http://etherpad.wmflabs.org/pad/p/Testing <-- ether pad lite [20:33:48] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29435 [20:58:10] awjr: is the sprint kick off meeting happening ? [20:58:40] tfinc: yes [20:58:56] seeya in 2min [20:59:02] lets use the same hangout [20:59:22] tfinc fine by me - jcmish, MaxSem ^^ [21:01:33] brion: come on back [21:02:32] jcmish: we're getting started with the kickoff [21:05:44] dangit [21:05:53] I was just sitting there waiting coming [21:11:09] I'm stepping away for a few [21:11:12] text me if you need me [21:14:02] preilly: k [21:23:52] okay, in case someone din't get it: [21:24:12] CODE FREEZE!!1ONEONE [21:24:48] merge stuff only if it fixes something serious in what wer're going to deploy today [21:25:05] \o/ [21:25:10] freeeeeeeeze [21:28:56] MaxSem: could have really done with the hour lost during that meeting :( [21:29:02] MaxSem: did DeviceDetection.php move to core? [21:29:07] It doesn't seem to have any effect on my local machine [21:29:38] yes it had been [21:29:45] (I just wiped the contents of DeviceDetection.php and my MFE still works [21:29:59] MaxSem: do you know where it's new home is? I need to make some changes to it [21:30:06] I guess we'll have to back it off cause we're not working on it any more [21:30:19] don't change the core IMHO [21:30:55] waitasec... [21:30:55] firefox mobile will just have to get the shit mobile site for bit longer [21:31:17] jdlrobson: DeviceDetection.php is not actually used to redirect devices to the mobile site [21:31:31] jdlrobson, o rly? I though it involves Varnish [21:31:40] what Max said. [21:31:53] actually i htink the rules are defined for squid [21:32:40] oh no i take that back, varnish looks right [21:33:33] kekeke, our infrastructure is insane in some places:P [21:34:02] also jdlrobson don't worry about firefox os right now, that work is slated for next iteration [21:34:02] https://mingle.corp.wikimedia.org/projects/mobile/cards/214 [21:35:15] New patchset: MaxSem; "Back out the preference for core classes" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29441 [21:35:50] awjr: MaxSem there is some black magic at work - on my local machine I don't have varnish so it should fall back to DeviceDetection.php but changing that seems to have no effect now like it used to - It means I can't test new features on Fennec [21:36:13] ^^^ [21:36:21] i dont think that ever worked... [21:37:04] with the commit above, you will be able to make changes to DeviceDetection that work [21:37:30] jdlrobson: dont worry about it right now; fennec isn't on the list for testing anyways [21:37:58] awjr: yeh I'm just trying to save myself work whilst I have every browser in front of me but never mind [21:41:02] mm so I've broken search on Nokia's [21:41:09] is that a big deal? [21:42:22] ideally, it should be [21:42:45] yeah so the problem is we need a submit button [21:42:57] there is no enter key on this nokia's keyboard [21:43:08] so it can't fire off a full text search [21:57:14] what we're deploying today: https://www.mediawiki.org/wiki/Extension:MobileFrontend/Deployments/2012-10-23 [22:00:26] +1 MaxSem [22:00:31] New patchset: Jdlrobson; "add search button fallback" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29444 [22:00:41] ^ i fixed the nokia issue - it's your call if you want to merge this now/tomorrow/later [22:01:10] I'm prettyh sure that we'll have to fix more stuff today:) [22:02:28] MaxSem: i think you are probably right.. :) [22:02:35] mmm, no preilly around for Zero [22:05:15] thanks MaxSem, the list totally helps [22:07:09] here we go, http://test.m.wikipedia.org/wiki/Main_Page [22:07:18] jdlrobson, awjr1, jcmish ^^^ [22:07:31] kay MaxSem [22:08:39] jcmish: can you link to the tests you came up with? [22:08:50] [bugs] NEW [Bug 41282] MobileFrontend overrides Special:Userlogin template on desktop view (priority: Unprioritized severity: blocker) https://bugzilla.wikimedia.org/show_bug.cgi?id=41282 [22:08:50] yup one sec [22:08:59] awjr, jdlrobson: bug with login page https://bugzilla.wikimedia.org/show_bug.cgi?id=41282 [22:09:22] :-S [22:09:24] haha oops [22:09:44] i can take a quick look, probably quick fix [22:09:48] wheee [22:09:55] it's probably just missing one call yeah [22:10:17] http://www.mediawiki.org/wiki/Mobile_Browser_Regression_Tests. [22:10:17] needs a if ( MobileContext::singleton()->shouldDisplayMobileView() ) { or something [22:12:50] brion or awjr, can you take a look at https://gerrit.wikimedia.org/r/29444 ? [22:13:10] New patchset: awjrichards; "Display mobile login *only* in mobile view" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29445 [22:13:26] Hmm i'm not seeing the "more" icon [22:13:27] hmm, so far I see unstyled checkboxes in mobile prefs on Opera Mini [22:13:28] at the bottom [22:13:40] I cleared my cache [22:14:01] brion, MaxSem, jdlrobson: https://gerrit.wikimedia.org/r/29445 [22:14:06] but I can close it out hard just thought I'd ask if you guys are seeing this [22:14:21] MaxSem: that's expected from opera mini [22:14:42] jcmish: at first i thought i wasn't seeing it, but if i scroll down a smidge it's there (it doesn't appear to be showing up at the end of the content anymore) [22:14:54] AHHH thanks awjr [22:15:06] jdlrobson: is that expected ^? [22:15:09] New review: Brion VIBBER; "Looks good; confirmed works in iOS simulator with JS off, and button is hidden with JS on." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 2; - https://gerrit.wikimedia.org/r/29444 [22:15:09] Change merged: Brion VIBBER; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29444 [22:15:20] awjr: yes > jdlrobson: MaxSem: that's expected from opera mini [22:15:28] javascript is needed for sexy buttons [22:15:36] we don't serve javascript to opera mini [22:15:40] (currently) [22:15:49] jdlrobson, I see more breakage on Mini: search bar placeholder doesn't disappear once the input receives focus [22:15:57] jdlrobson: ok, i was asking about needing to scroll down to see the footer [22:16:18] MaxSem: which version of opera mini? [22:16:40] 7.5. the placeholder should be added in JS, not HTML [22:16:58] MaxSem: That's an opera mini bug [22:17:12] it's not respecting the placeholder attribute [22:17:33] New review: Brion VIBBER; "does what it says on the tin" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 2; - https://gerrit.wikimedia.org/r/29445 [22:17:33] Change merged: Brion VIBBER; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29445 [22:18:07] i've lost javascript sexy buttons on Special:MobileOptions in iOS [22:18:13] somewhere along the line... [22:18:27] doh brion - i suspect https://gerrit.wikimedia.org/r/#/c/29444/ did it [22:18:34] in stock browser on android 4.1, the footer behavior is a little weird - on an article with content that does not take up the full page, the footer (collapsed) appears just above the bottom of the touch area. but when i expand the footer, the footer disappears from view (it is now below the touch area) [22:18:34] (although not sure why) [22:18:38] hmm [22:18:49] so it appears that the footer completely disappered, rather than just moved below the fold [22:19:04] awjr: ? [22:19:08] jdlrobson: no it's doing that before that one merged [22:19:22] brion: is js disabled? [22:19:38] * brion slaps self silly [22:19:42] yes sir [22:19:48] :) [22:19:51] that's expected then heeh [22:19:52] ok MYSTERY SOLVED [22:20:19] jdlrobson: the point is; sometimes it's not obvious the footer is present; in some cases it appears just below the the screen so i need to scroll just to see it, even on short articles that do not take up a full page [22:20:47] were citations supposed to lose [square brackets]? [22:20:54] should we have white-on-light-gray for overlay titles? it's hard to read [22:21:07] yeah is is very hard to read [22:21:19] shall I deploy re cent merges? [22:22:21] the footer behavior seems completely new (if it's on purpose) - is that supposed to be showing up in non-beta? [22:23:14] it seems fine for articles with lots of content, but very short articles make the footer behave weirdly [22:24:49] it appears fine in iOS but not in Android 4.1 [22:26:24] aw awjr I was just gonna post that [22:26:31] too slow I guess.. back I go [22:26:38] :p [22:28:26] similar bad behavior in desktop chrome and chrome on android 4.1 [22:28:37] good article to see the behavior: Wombat [22:28:45] New patchset: Jdlrobson; "improving styling of settings page submit button in non-javascript mode" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29455 [22:29:35] New patchset: Jdlrobson; "run make less" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29456 [22:29:37] awjr: is this on test wiki [22:29:43] jdlyes [22:29:49] er [22:29:49] jdlrobson: yes [22:29:51] in non-beta [22:30:04] also brion "should we have white-on-light-gray for overlay titles? it's hard to read" < which overlay? [22:30:11] MaxSem: were citations supposed to lose [square brackets]? < no [22:30:13] jdlrobson: login for example [22:30:39] `make less` sounds pessimistic:P [22:31:19] logout message is not updated on test wiki btw [22:31:23] or login [22:31:36] but brion - yeh not sure what's happened to that heading [22:31:44] :( [22:32:27] MaxSem: can you run sync-common on srv193? there are new assets that are missing (Eg on the login form) [22:38:59] brr, got disconnected [22:39:15] last masg was awjr, done [22:39:28] MaxSem: cool thanks, yeah i saw the images appear :) [22:39:47] awjr do I need to test "simple" [22:39:47] ? [22:39:53] eh? [22:40:04] jcmish: what do you mean? [22:40:20] sorry simple.wikimedia.org [22:40:32] does that get updated along with this? [22:40:33] New patchset: Jdlrobson; "tweaks to make login readable" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29460 [22:40:48] MaxSem: which references were you referring to? [22:41:01] jcmish: no, simple will get a code update when the code is pushed to production [22:41:01] just like the other wikis [22:41:07] right now the code is only live on test.wikipedia.org [22:41:07] okay gotcha sorry [22:41:10] no worries [22:41:15] I still get confused [22:41:19] jcmish: me tooo [22:41:30] jdlrobson, This is a fact^[1] [22:41:37] MaxSem: what article? [22:41:38] hehe [22:42:02] http://test.m.wikipedia.org/wiki/San_Francisco#_ [22:42:16] mm that's weird [22:42:38] i'm guessing this is related to the lazy loading? [22:43:09] the [ and ] don't seem to be in the html markup [22:43:35] not sure why they wouldn't be.. did the Cite extension change? [22:43:45] not my doing anyhow ;-) [22:45:08] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29460 [22:46:46] is Michelle on irc? [22:47:10] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29455 [22:47:34] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29456 [22:48:07] jdlrobson: yes, she is jcmish [22:48:53] aahh jcmish: how you doing with the qunit stuff? [22:49:25] btw in case people didn't realize - running make tests from the Mobilefrontend extension directory should run all the tests [22:52:02] okay so other than issues shown here my tests are work [22:52:06] *** I've deployed the latest changes *** [22:52:16] *working [22:52:40] do any of these issues keep us from move to prod? [22:55:16] did we start doing something clever like ajax-loading the new article page in after searching? [22:56:05] i see some differences between view of article after selecting it from search and directly loading it. [22:56:18] e.g., the hidpi code doesn't run, main page shows 'Main Page' title [23:03:15] * tfinc rests after translating Polish -> English Talk page discussion about US laws and Commons [23:03:26] my brain hurts now [23:04:52] hahahah [23:04:55] now see that's awesome [23:05:02] can I translate piglatin? [23:05:13]