[00:00:18] Maryana: lets keep the jokes to the side till the deployment is done. were already busy enough triaging issues [00:00:26] Maryana: but reports on the other hand are much appreciated [00:00:27] Reedy: ok that's funky because it's a special page, but it's an action=mobileview again. [00:00:38] Yeah [00:01:00] Maryana: what screenshots did you grab for the post? [00:01:14] wow secret service will be here tomorrow .fun [00:01:24] and by tomorrow i mean thur [00:01:53] tfinc: i'm waiting to get an en.n.wp screenshot [00:02:19] *en.m.wp [00:02:34] woot [00:10:55] oo looks like scap just finished [00:11:10] \o/ [00:11:16] okay, the fix is live on testwiki - please test [00:12:32] ok i still see bad styles on en.m.wikipedia.org [00:12:39] do we need to clear the varnish cache or something? [00:13:06] i'm still getting old versions of the site [00:13:11] main page of enwiki looks broken to me [00:13:24] all pages are broken to me [00:13:30] it's either varnish cache or RL not picking up module changes, or both [00:13:45] lemme touch a few files... [00:13:59] RL changes may take up to 5 minutes to appear (i htink that's still the ttl) [00:14:18] iirc styles don't update *every* time we do a mobile deploy. unless we've fixed that problem i imagine it's still present? [00:14:45] they should update if any files for a module were updated, except when files are deleted from a module [00:15:06] RL doesn't know to update when files are removed [00:15:25] looks good to me. did the changes go through now? [00:15:26] we're not fully using RL yet, our core styles are loaded through RL's low-level loader but without using the dependency & update graph [00:16:13] I'm pushing the fixes [00:16:26] http://en.m.wikipedia.org/wiki/Saint_Joseph_of_Cupertino_Parish?debug=true shows correct thing for me http://en.m.wikipedia.org/wiki/Saint_Joseph_of_Cupertino_Parish is broken [00:16:39] Maryana: if you need screenshots just append debug=true to the end of the url [00:16:52] rather ?debug=true / &debug=true [00:17:35] the only weird thing i'm seeing is that the arrows don't appear next to sections, though they seem to open just fine when tapped [00:17:51] Maryana: append debug=true and it should work as expected [00:17:55] ah, ok, gotcha [00:18:50] ok something just fixed it [00:19:03] it's not working as expected for me [00:19:18] although some pages still show the old design [00:20:36] newly rendered pages look good to me... [00:20:48] …previously-rendered pages are stuck with no styles. wtf? [00:21:07] yeah, all good. language selector, design, chrome - check [00:21:24] I'm gonna call for a complete overhaul of our deployment procedures [00:21:32] mmm if there were html changes it probably needs a varnish cache flush [00:21:32] agreed [00:21:38] awjr: *nod* [00:21:57] MaxSem: +1 [00:22:11] I've deployed the fix [00:23:13] not getting old rendering anymore! w00t [00:23:53] MaxSem +1 this takes too long - https://twitter.com/WenHan333/status/260897035622948864 < if someone can tweet a screenshot in the time it takes to deploy we need to improve [00:24:46] :( [00:24:53] the new rendering looks awesome, tho [00:24:54] \o/ [00:25:09] enwiki main page is still busted for me [00:25:22] Canada is broken for me [00:25:23] I've asked ops to do a flush [00:25:30] and Kyote [00:25:37] *Kyoto [00:25:37] excellent [00:25:37] thanks MaxSem [00:28:19] ok, quick poll: which article should we feature in the screencap for the blog? [00:28:56] http://etherpad.wikimedia.org/MobileDeploymentPainPoints <- please everybody add to this as necessary [00:29:01] varnish cache was flushed; main page looks OK to me now [00:29:17] awjr: confirmed on my end too :D [00:29:21] http://en.wikipedia.org/wiki/Miss_Piggy < Maryana [00:29:31] woohoo! [00:29:46] non-beta now with more sexy! [00:29:50] yayyyyyyyy [00:29:50] haha - if it didn't have the cleanup template thingy on it, that would be perfect [00:30:45] http://en.m.wikipedia.org/wiki/Mobile_device [00:30:50] email sent [00:30:52] dynamic sections are f**king awesome. That's all I have to say [00:31:15] it's too bad the pic of the galaxy s iii displays the non-mobile site :( [00:31:15] i miss summary collapsion too much so to me the current site is dead [00:31:17] long live the beta! [00:31:32] awjr: fix it. [00:31:33] :) [00:31:36] :p [00:31:44] mebe i will [00:31:51] if only we had image uploads from mobile.. [00:31:52] i need another device to take a picture of my device tho... [00:32:12] the designers are very pleased [00:33:00] awjr: up for a hangout test? [00:33:33] tfinc sure - gimme a sec to get off the couch [00:33:41] belay that [00:34:22] some other languages still show broken styles to me… hopefully that's an isolated issue and it's just my weird caching [00:34:25] awjr: i needed to give up the room [00:34:36] awjr: two new yeti mic showed up today :) [00:34:53] so i no longer need to move gear for r31 [00:34:58] tfinc no worries [00:34:59] oo [00:35:00] yay [00:35:05] tfinc: wh00t [00:35:13] http://zh.m.wikipedia.org/ shows bad for me :( [00:35:34] http://es.m.wikipedia.org/ and others too... [00:35:40] did we only cache-clear for en.m.wikipedia.org? [00:35:52] awjr: robla also tell me that the mic pickup in the hd webcam is pretty good [00:36:06] i'll test that too if i can get back into the room [00:36:17] brion, Unhandled Error: Cannot convert 'mw.loader' to object [00:36:37] hmm [00:36:50] brion, all purges apply to all wikis [00:37:14] wtf... [00:37:56] eek is there a difference in ResourceLoader for those? [00:38:12] I thought ResourceLoader changes were only meant to apply to beta? [00:38:44] so.. [00:38:45] http://es.m.wikipedia.org/wiki/Wikipedia:Portada?debug=true [00:38:47] fixes the problem [00:38:54] it looks like the mw { loader { state: function () {} } } hack is gone [00:38:55] no errors [00:39:31] zh.m seems to throw an issue with ResourceLoaderDynamicStyles [00:39:42] the error comes from mw.loader.state(.., 'ready'); from the load.php call. [00:39:42] Krinkle, that hack was supposed to appear only on 1.19 wich doesn't support raw modules [00:40:07] it seems things were not properly flushed for es and zh; RL issue or varnish? [00:40:09] MaxSem: well, then the problem is that the code isn't using raw [00:40:23] [00:41:17] Oh, interesting. It isn't mw.loader.state(.., 'ready') [00:41:17] its mw.loader.state({"mobile.head":"missing"}); [00:41:31] suspicious [00:42:01] something about hardcoding timestamps and 30-day cached content with incompatible changes. [00:42:05] eswiki is showing old timestamps [00:42:58] preilly: you around? [00:42:58] yeah, maybe it's stuck in cache from before the sync completed? [00:43:06] but how do we clear it out then if what we already did didn't do it? [00:43:27] jdlrobson: debug working doesn't mean anything in this case [00:43:32] jdlrobson: I'm in a meeting with Erik [00:43:42] debug=true and only=scripts means there is no mw.loader.state call [00:43:58] because those are only supposed to be used internally with the callback from resourceloader itself. [00:44:30] but since the current mf is hardcoding its own load.php requests, it happens to work in debug mode [00:44:46] https://bits.wikimedia.org/es.wikipedia.org/load.php?debug=true&lang=es&modules=mobile.head&only=scripts&skin=mobile&version=1351033821&* [00:44:47] brion we can touch a file for one of the out-of-date modules on fenari and re-sync, which should take care of it [00:44:54] Krinkle: good news is moving to proper use of RL should resolve that. bad news is we haven't done it yet :P [00:45:02] awjr: *nod* sounds good [00:45:03] with debug=true set wgPageContentLanguage is complaining about being undefined [00:45:12] on french wikipedia [00:45:17] MaxSem: are you still around to help take care of that? [00:45:47] jdlrobson: hmm, i don't see that in firefox [00:45:58] or chrome [00:46:07] http://fr.m.wikipedia.org/wiki/Atmosph%C3%A8re%20(unit%C3%A9)?debug=true [00:46:54] no err in console for me on that page... [00:46:56] awjr, eww - I touched all files in wmf2 but apparently forgot to do so in wmf1 [00:47:05] just the event logging that should be there [00:47:11] MaxSem: isn't everything running wmf2 now? [00:47:22] http://noc.wikimedia.org/conf/wikiversions.dat [00:47:57] oh i see [00:48:20] aha! [00:48:29] well that explains it :p [00:48:43] all the ones i found broken stuff on are indeed in wmf1 [00:49:06] MaxSem: did you do wmf1 as well? [00:49:12] i wrongly thought when enwiki went to wmf2 everything else does too [00:49:33] is that causing the non en language bug? [00:49:37] now touched and deploying to wmf1 [00:49:53] Maryana: yep. [00:49:53] thx MaxSem ! [00:49:53] mystery solved! [00:49:58] yayyyy [00:51:16] New patchset: Jdlrobson; "add missing image for beta" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29735 [00:52:10] ok let me do the quick profile check on the new en.m ... [00:52:21] "Wikipedia just spruced up the CSS on their mobile site and added a little Facebook-style drawer menu jammie." [00:52:25] https://twitter.com/robertgorell/status/260906057168211969 [00:52:31] \o/ [00:52:50] can we call it the "Facebook-style drawer menu jammie" from now on? [00:52:59] hahaha [00:53:34] lolz [00:55:01] so i'm still getting "Uncaught ReferenceError: wgPageContentLanguage is not defined " [00:55:02] on various sites [00:55:16] jdlrobson: which in particular? [00:55:17] http://fr.m.wikipedia.org/wiki/Wikip%C3%A9dia:Accueil%20principal?title=Wikip%C3%A9dia:Accueil_principal&mobileaction=toggle_view_mobile [00:55:32] all seem ResourceLoader related [00:55:39] and exactly why i was worried about introducing it to the mix [00:55:40] http://pt.m.wikipedia.org/wiki/Wikip%C3%A9dia:Accueil%20principal?title=Wikip%C3%A9dia:Accueil_principal&mobileaction=toggle_view_mobile [00:55:45] Uncaught TypeError: Cannot call method 'substr' of null [00:55:50] jdlrobson: clear local cache, wfm [00:55:52] mw.loader::execute> Exception thrown by ext.gadget.geonotice: Geo is not defined [00:56:06] awjr: makes no difference [00:56:14] i'm running debug=true as well [00:56:33] we've opened pandora's box [00:56:38] jdlrobson: are you in beta? [00:57:03] hmm svaing settings (at least in desktop browser) sends me back to desktop site... [00:57:16] jdlrobson: i only get those errors in beta [00:57:23] ahh yes i am - hadn't realized if i opted into beta on english i opted in on every other language site [00:57:28] fyi: the wgPageContentLanguage is due to OutputPage's mw.config stack being surpressed by mf [00:57:29] ok that worries me less [00:57:43] phew [00:58:13] good thing we added ResourceLoader just to beta then! :) [00:59:11] good job team [00:59:13] i'll raise some issues [00:59:19] i'm really enjoying playing with the new release [00:59:26] [bugs] NEW [Bug 41339] Saving settings form desktop browser sends me to desktop site (priority: Unprioritized severity: normal) https://bugzilla.wikimedia.org/show_bug.cgi?id=41339 [00:59:27] [bugs] NEW [Bug 41333] MobileFrontend extension loads JavaScript twice, has weird errors when database error occurs in job queue (priority: Unprioritized severity: normal) https://bugzilla.wikimedia.org/show_bug.cgi?id=41333 [00:59:33] ddid we keep an active ether pad for issues or just irc ? [01:00:11] i'm really eager to see dynamic sections go out next. /me needs to talk to howie about it [01:00:26] tfinc just irc afaik [01:00:29] preilly: did we have the live beta opt in graph ? [01:00:31] awjr: k [01:00:34] wheeeeeeee [01:01:10] probably wmf1 didn't get the update to ResourceLoader for the 'target' system [01:01:25] in which case it'll be reporting a fuller list of modules and may be trying to load some of them [01:01:53] that is probably true [01:02:24] tfinc: we have it but no doesn't seem to have data [01:04:07] ok are we happy enough with the current state or do we need additional emergency fixes? [01:05:35] ok sounds like we are good for now :D [01:05:39] good luck and good night [01:12:30] awjr: yeti mics are now in r31, r37, and stand up area . we'll test them tomorrow [01:12:40] still waiting on additional camera stands [01:12:40] sweet [01:12:42] and usb hubs [01:12:59] central computer probably has plenty of those [01:13:04] awjr: tomorrow we'll test camera as mic .. i'm curious to see how well it does [01:13:08] chip already ordered one [01:13:11] ok .. time to head to jays [01:13:11] groovy [11:44:30] [WikipediaMobile] yuvipanda pushed 1 new commit to master: http://git.io/UtldOQ [11:44:30] [WikipediaMobile/master] Remove of old ressources that were used by google map based "near me" feature - tpt [11:44:50] Project WikipediaMobile - Nightly builds build #419: SUCCESS in 15 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/419/ [11:44:50] yuvipanda: Remove of old ressources that were used by google map based "near me" feature [12:02:25] [WikipediaMobile] yuvipanda pushed 1 new commit to master: http://git.io/GG423g [12:02:25] [WikipediaMobile/master] Add of a python script that create res/values files from app i18n in order to have proper i18n for java side of the Android app - Tpt [12:02:35] Project WikipediaMobile - Nightly builds build #420: SUCCESS in 8.4 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/420/ [12:02:35] yuvipanda: Add of a python script that create res/values files from app i18n in order to have proper i18n for java side of the Android app [15:15:12] [bugs] NEW [Bug 22660] Display the categories on the mobile site (priority: Normal severity: enhancement) https://bugzilla.wikimedia.org/show_bug.cgi?id=22660 [16:27:28] yuvipanda: "Wikipedia mobile changed its fonts & my left ankle still hurts" < best new design feedback ever ;-) [16:27:35] we should have healed the left ankle... [16:44:58] jdlrobson: where is this feedback going to? [16:45:02] why am I not on it? :( [16:45:08] oh this is just twitter yuvipanda [16:45:20] i can sign you up to email digests if you want [16:45:26] i do! [16:45:29] yuvipanda@gmail.com [16:45:32] k [16:45:41] also, jdlrobson big huge hi5 from thet otherside of the world :) [16:46:19] :) [16:46:26] you should wait and see what i've been hacking on this morning [16:47:31] ok please verify you got digest mails [16:47:49] jdlrobson: what have you beeN? [16:48:04] yup i did [16:48:04] you should have got the spam digest [16:48:12] it sometimes contains things that incorrectly get marked as spam [16:48:48] i think it did well this time round [16:49:02] :D [16:53:07] It turns out https://www.ohloh.net/p/wikimedia-mobile already exists [16:53:21] I have added it to the Wikimedia org umbrella and will add repos [16:53:23] sweet! [16:54:41] Should I take http://www.mediawiki.org/wiki/Wikimedia_Mobile_engineering as a reference for the projects to add? (but why is the PhoneGap app missing there? Or is it?) [16:58:01] qgil that is fairly accurate; although there are some things missing (eg recently completed projects is totally empty, the mobile apps (Wikipedia, WLM) are missing [which is what i presume you meant by 'PhoneGap app'?]) [16:58:23] qgil ping tomasz about it as i believe he is the one who has been maintaining that page [17:00:38] MaxSem, jdlrobson: mornin - standup? [17:00:44] yup [17:00:47] is tfinc there yet? [17:00:52] i'm hanging out today for the standup [17:01:02] i got carried away with some coding so was running late :) [17:01:12] no worries [17:01:12] :) [17:02:31] jdlrobson: https://plus.google.com/hangouts/_/8bc98160cdf0396821e2ba381099b56fde42cb0c [17:05:05] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29735 [17:16:23] MaxSem: let's get the mtg scheduled - do you want to keep the conversation limited to the team for now so we can sort out our processes before discussing tools, etc (which would probably require roping in people from the platform team) [17:18:01] awjr, I don't think that deployment tools need to be discussed - my concern is 99% our chaotic process [17:18:08] MaxSem: there is surprisingly one hour where everyone from the team is free tomorrow (michelle, jon, brion, you, tomasz, howie, maryana) [17:18:22] :D [17:18:27] MaxSem: that makes sense; and like i said yesterday that's the easiest thing for us to directly affect in the short term [17:18:51] let's grab that hour while we can:D [17:19:37] Maryana: thanks for the blog post [17:19:42] tfinc is there a projector in r32? [17:19:43] Maryana: we now have two competing beta pages http://www.mediawiki.org/wiki/Mobile_Beta and http://meta.wikimedia.org/wiki/Mobile_projects/Beta [17:19:49] awjr: there is not [17:19:50] d'oh [17:19:56] i didn't know about the mediawiki one [17:20:05] oh, wait, yes that one [17:20:07] hmm then there is no suitable room during the one hour everyone is available tomorrow [17:20:48] awjr: yeah, the fundraisers have all come back to town & commandeered r66 [17:20:53] awjr: then lest just do it from one of the collar areas over hang out [17:20:53] makes booking big rooms that much harder [17:21:00] collab* [17:21:15] tfinc ok which collab area is 'benjamin franklin'? [17:21:22] stand up area. its too small [17:21:22] that is the only one available at 11 [17:21:58] oh, there's a separate 'collab' section in the room booking sections - what is 'Collab - 3Floor'? [17:23:18] awjr: i'm guessing thats the one by hr. ask rachel/praveena and they can let you know [17:23:31] oh hey, first comment & it's positive: http://blog.wikimedia.org/2012/10/24/wikipedia-mobile-gets-a-new-look/#comments [17:23:34] :) [17:23:47] tfinc im booking it and just sent pravena an email about possibly rearranging (r31 is booked for a 3-person meeting, for instance) [17:23:47] woot! [17:23:52] k [17:23:58] tfinc is rachel back? [17:24:06] awjr: not yet but should be today [17:24:12] k [17:24:12] she mailed and said she'd be back post nap [17:24:19] cool [17:25:38] Maryana: retweet or post the blog through @WikimediaMobile [17:26:27] tfinc: pm me w/ the login deets? [17:26:39] Maryana: their all on office wiki [17:26:49] ah, gotcha [17:26:49] let me pull up the link [17:27:03] matthew's gonna tweet/fb via the official wikipedia accounts, too [17:27:17] MaxSem: I just updated the deployment [17:27:34] Maryana: https://office.wikimedia.org/wiki/Registrations [17:27:41] thx! [17:27:47] MaxSem: meeting is scheduled [17:28:00] awjr, cool, thanks [17:28:33] np, it is an important one :) [17:29:21] preilly, ?? [17:29:43] jdlrobson: can you test http://en.m.wikipedia.org/ now [17:29:59] sure preilly anything i should be testing for? [17:30:09] jdlrobson: just a quick scan [17:30:56] MaxSem: I was looking at fenari and the files in /home/wikipedia/common/php-1.21wmf1 didn't look correct [17:31:08] MaxSem: so I updated and redeployed [17:31:56] preilly: the image issue i mentioned on email yesterday looks fixed [17:32:18] jdlrobson: okay great that's what I was going for too [17:32:37] just checking the indent issue [17:33:08] still seeing this strange indent issue but so far only on my android [17:35:22] jdlrobson: did you commit a fix for it? [17:35:41] jdlrobson: can you replicate it on your development environment? [17:35:43] preilly: nope not been able to replicate the issue [17:35:55] it seems to effect sections without an image [17:37:17] jdlrobson: hmm [17:37:25] jdlrobson: will you be coming to the office today? [17:37:33] brion: will you be coming to the office today? [17:38:59] [bugs] NEW [Bug 41356] [[de:Barack Obama]] article shows test instead of real nav (priority: Unprioritized severity: normal) https://bugzilla.wikimedia.org/show_bug.cgi?id=41356 [17:38:59] preilly: yep [17:39:03] preilly: i'll be in at lunch [17:39:13] i got carried away with some experiments [17:39:28] jdlrobson: http://bug-attachment.wikimedia.org/attachment.cgi?id=11232 :( [17:39:42] looks like we've got a design meeting at 1, i'll come in for that [17:39:42] tfinc: that looks like a caching issue [17:39:42] those are hard over hangout [17:39:46] Ryan_Lane, I saw you worked on gitdeploy - what are the chances to see it on main cluster in the foreseeable future? [17:39:52] tfinc: that happened during deployment but shouldn't still be happening [17:40:16] also tfinc works for me [17:40:25] MaxSem: good [17:40:30] o_0 [17:40:31] MaxSem: I just need time to work on it [17:40:34] i just took that screenshot [17:40:46] tfinc: i just viewed the page and it looks fine [17:40:54] and now reloading it doesn't show [17:40:55] seeing as that I'm about to go on vacation for two weeks, I'd expect it some time after that [17:41:13] the issue [17:41:16] tfinc: try opening an incognito window.. same problem? [17:41:18] jdlrobson: your right it could be caching [17:41:23] ok cool [17:41:23] tfinc: that page shows ok for me in firefox, but bad in iOS simulator with cookies cleared [17:41:38] is it just first load then ? [17:41:44] on reload it shows better [17:42:21] yeh tfinc this is related to the issues we have during deployment [17:42:46] brion: i just cleared my simulator cache and it worked just fine [17:42:52] yay [17:43:07] Ryan_Lane: is it just https://github.com/mislav/git-deploy ? [17:43:12] Ryan_Lane: or something custom that you built? [17:43:13] tfinc: https://twitter.com/WenHan333/status/260897035622948864 [17:43:27] same issue during deployment [17:43:50] http://news.softpedia.com/news/Wikipedia-s-New-App-Like-Mobile-Website-Goes-Live-for-All-301969.shtml?utm_source=twitterfeed&utm_medium=twitter [17:43:59] preilly: it isn't that one [17:44:24] preilly: it's this one: https://github.com/git-deploy/git-deploy [17:44:33] new "app like website" [17:44:47] all that one really does is lock the repo, add a tag, and run a script [17:44:51] is Pheeghissima la nuova Wikipedia mobile! a compliment? [17:45:02] I guess that's Fighissima [17:45:08] then I'm using saltstack to run remote commands to pull from the repo [17:45:16] mostly positive feedback - only a couple of moans I've seen so far [17:45:37] I thought I pushed all my work into gerrit, but it's split between two repos, and one is out of date [17:45:49] my favorite tfinc https://twitter.com/_0p_/status/261117716746874881 [17:46:27] [bugs] NEW [Bug 41357] MobileFrontend options save button too small for German text (priority: Unprioritized severity: normal) https://bugzilla.wikimedia.org/show_bug.cgi?id=41357 [17:47:09] preilly: before I forget -- is the Firefox OS version of the app in a git fork or branch that I can look at? [17:47:25] brion: it's on the vumi vm [17:48:06] yeah, but is it in source control? [17:48:06] I'll push in everything today. in fact, I may try to push it out to eqiad today as well [17:48:11] brion: in /mnt/p/mortar/builds/WikipediaMobile/www [17:48:24] brion: I can put it on github [17:48:30] brion: give me a minute [17:48:37] preilly: that'd be awesome, thanks [17:48:52] will be easier for me to clone & poke at it [17:54:11] brion: take a look at https://github.com/preillyme/WikipediaMobileFirefoxOS [17:54:25] excellent thanks :D [17:54:39] brion: hows our payload and load time post deployment ? [17:54:46] brion: np [17:54:57] tfinc: http://etherpad.wikimedia.org/MobilePageLoadStats [17:55:08] slight increase in payload which is expected [17:55:13] speed seems within variance [17:56:09] preilly: --^ [17:56:39] tfinc: thanks [17:59:40] preilly: does it have to run from root directory or anything special like that? i'm getting mysterious "script error"s in require.js [18:00:03] awjr: one sec as there was no room reserved for our 1:1 [18:00:12] awjr: ok found one [18:00:42] tfinc whoops i probably forgot to assign a room when i rescheulded [18:01:08] brion: should run from root [18:01:08] awjr: it doesn't have a hangout either [18:01:28] tfinc: it does now [18:01:31] i'll stick it in my linux vm, that should work :) [18:01:41] i'm in [18:14:06] tfinc: Hi ! [18:14:07] Can you move Wikisource app to Wikimedia repo in order to help the setup of the translation system ? [18:17:33] hey Tpt [18:17:51] I merged your pull reqs :) [18:18:22] preilly: ah i see, js/lib/MobileFrontend is a symlink instead of a git submodule so i'm missing some files [18:18:49] brion: I'll fix that right now [18:18:55] thanks [18:19:20] yuvipanda: I've seen it. Thanks a lot ! [18:19:33] ok i'm gonna grab some grub and head into the office [18:19:36] catch ya later [18:21:57] Tpt: thanks for the patches :) [18:22:17] brion: https://github.com/preillyme/WikipediaMobileFirefoxOS/tree/master/js/lib [18:33:49] awjr: i lied [18:33:53] up for a hangout test? [18:34:02] with the new hardware [18:34:03] sure [18:35:39] lets use the same 1:1 hangout [18:40:04] yuvipanda: you around? [18:40:17] yuvipanda: does https://github.com/wikimedia/WikipediaMobile/tree/master/assets/www work with MobileFrontend master? [18:56:10] * tfinc is feeling meh today [18:56:12] lets see how long i last [18:56:25] preilly: haven't tried, actually! [18:56:40] it's been pinned since the last release, and I won't be surprised if it doesn't work [18:58:22] brion yuvipanda : any other blockers for iOS 3.2.1 going for app review ? [19:00:07] MaxSem: https://gerrit.wikimedia.org/r/#/c/27035/ passed security review and i pinged ops to please merge the changes [19:01:14] MaxSem: the redirector rules still need updating to reflect what's defined in the story card [19:01:14] yeah [19:01:59] MaxSem: i moved the story card to iteration 3 and put it in 'ready for dev' for when you get to it [19:02:00] cool, thanks [19:03:36] tfinc: none that I know of [19:03:53] tfinc: but I didn't test it extensively (only checked the specific case) [19:04:19] k [19:04:47] preilly: what's our analytics status? [19:12:50] \o/ http://thenextweb.com/apps/2012/10/24/wikipedia-rolls-out-a-completely-redesigned-mobile-site-with-an-emphasis-type-and-readability/?utm_source=Twitter&awesm=tnw.to_a6QV&utm_campaign=social%20media&utm_medium=Spreadus [19:14:10] "The desktop version of the website has not had a update at the moment but one is surely due within the next few months, I think" [19:14:13] haha [19:17:20] tfinc: Hi ! [19:17:22] Can you move Wikisource app to Wikimedia repo in order to help the setup of the translation system ? [19:17:52] preilly: can you take Tpt 's request. i'm about to step out for lunch [19:18:03] if not i'll get someone to do it later today [19:20:54] https://twitter.com/theDeriv/status/261185088430153728 [19:20:55] haha [19:26:18] ROFL [19:26:56] * tfinc spins up tweet deck [19:29:29] hmm no brion [19:33:42] jdlrobson: eager to see what he says in response to you https://twitter.com/peter_weis/status/261182965177008128 [19:39:07] tfinc: we only have about half of those statistics available [19:39:12] preilly: send them over [19:40:23] tfinc: do you know the current repo for the Wikisource app? [19:41:07] preilly: https://github.com/Tpt/WikisourceMobile [19:41:36] tfinc: okay thanks https://github.com/wikimedia/WikisourceMobile is created now [19:42:29] awjr: https://bugzilla.wikimedia.org/show_bug.cgi?id=38799 [19:42:35] chatter about it again [19:42:43] on wikitech this time [19:42:58] tfinc thanks for the heads up; will look after lunch [19:44:13] ... and Wikimedia Mobile is the 6th project now in commit count :) https://www.ohloh.net/orgs/wikimedia/projects [19:44:29] qgil: we can do better then that ;) [19:44:54] icons! [19:45:41] qgil: just sent you a badge/icon to use [19:46:54] tfinc, check: https://www.ohloh.net/p/WiktionaryMobile [19:47:08] much better [19:47:35] tfinc, we have to decide whether we want to keep some mobile projects on their own or we can just mark them as duplicate pointing people to the Wikimedia Mobile umbrella: [19:48:03] qgil: i'd want to remove the ruby project from our list [19:48:21] tfinc, wait [19:48:22] I mean [19:49:07] https://www.ohloh.net/p/WiktionaryMobile https://www.ohloh.net/p/WikipediaMobile https://www.ohloh.net/p/WLMMobile https://www.ohloh.net/p/WikipediaMobileJ2ME https://www.ohloh.net/p/wikimedias_wikipedia-iphone [19:49:52] (I believe it is good to keep the ruby repo, as part of the history of Wikimedia Mobile. Since it's not actoive is not influencing any of the current stats) [19:50:43] Maryana: the internet noticed your blog post and likes it ;) [19:51:01] i know! craaazy [19:51:14] seems like overwhelmingly positive reception for all the changes [19:51:16] Maryana: this is exactly why i do blog posts for every big release [19:51:27] they give us excellent visibility [19:51:39] have you seen this one? http://thenextweb.com/apps/2012/10/24/wikipedia-rolls-out-a-completely-redesigned-mobile-site-with-an-emphasis-type-and-readability/?utm_source=Twitter&awesm=tnw.to_a6QV&utm_campaign=social+media&utm_medium=Spreadus [19:51:42] great before/after shot [19:52:05] [bugs] NEW [Bug 35215] Mobile redirect strips https (priority: High severity: normal) https://bugzilla.wikimedia.org/show_bug.cgi?id=35215 [19:52:48] once again, i say that i dislike the lighter colored chrome. [19:53:19] jorm: why ? [19:54:41] because i (still) believe strongly that we need to create an obvious heirarchy between various kinds of actions (site/page/user) and the color of the site action bar being the same as the page is problematic. [19:55:05] plus it's close to the same color as the browser chrome in ios5 safari, and the same intensity as that of ios6 safari. [19:55:28] i don't think the rationale for the change is very strong. [19:56:50] tfinc, can I merge https://www.ohloh.net/p/wikimedias_wikipedia-iphone into https://www.ohloh.net/p/WikipediaMobile ? It makes total sense to have an own project for the Wikipedia mobile app [19:57:37] their different apps from the code perspective [19:58:35] tfinc just responded to the thread [19:59:30] ok, also you said you added a couple of important repos. Where did you add them? [19:59:30] do we have a hangout for this meeting? [19:59:33] tfinc ^ [20:02:15] what advantage do we get from moving it? [20:10:06] i'm getting timeouts trying to join this thing now. [20:10:54] * yuvipand1 pokes brion to look at https://github.com/wikimedia/WikipediaMobile/pull/291 when he can [20:11:01] jorm: same here. howie invited you to a stand alone hangout [20:11:03] that one is working fine [20:11:18] yuvipand1: i'll check it out after this meeting [20:11:24] thanks for doing the update work on that! [20:11:30] jdlrobson, we're in R31 for the design meeting [20:11:45] i haven't gotten the invite. [20:12:01] unless it's the one listed in the calendar invite, which is what is timing out for me. [20:12:05] brion: :) [20:12:18] brion: only android, however - iOS upgrade path looked complicated so left it for now [20:12:43] yeah i saw [20:12:52] iOS is a bit trickier, needs the Xcode project to be rebuilt [20:13:21] http://etherpad.wikimedia.org/MobileUX [20:13:27] ^ etherpad agenda [20:18:37] eek, pattern=^http://((?:species|meta|incubator|outreach|strategy|wikimania2012)(?!\.wikimedia)|\w+(?!\.wikimedia))\.(wikimedia|wikipedia|wiktionary|wikinews|wikisource|wikiquote|wikibooks|wikiversity)\.org[:\d]*/wiki/(.*) [20:25:16] I hope, everyone sees the mistake in the above regex? :P [20:29:11] MaxSem: ha ha [20:32:29] missing for https? [20:32:39] no [20:33:11] the right one is ^http://((?:species|meta|incubator|outreach|strategy|wikimania2012)(?=\.wikimedia)|\w+(?!\.wikimedia))\.(wikimedia|wikipedia|wiktionary|wikinews|wikisource|wikiquote|wikibooks|wikiversity)\.org[:\d]*/wiki/(.*) [20:36:49] ?= instead of ?!. I'm lost. Unsure what capture params they are. [20:36:52] * yuvipand1 goes to look [21:05:27] yuvipand1: looks ok under android…. something off on iOS though, lemme see if i can track it down [21:05:44] "Error: executing module function 'setInfo' in module 'cordova/plugin/ios/device'. Have you included the iOS version of the cordova-1.7.0.js file?" [21:08:01] that's odd, 090e20218c4cf491ae93b9451de6d0454a23bc99 should hav fixed that [21:08:37] brion: i think cordova.js never changed? [21:08:47] at least, I saw that git status told me that it was a rename from 1.7.0 to 2.1.0 when i added it [21:08:52] so I *assumed* it [21:08:53] yuvipand1: my merge somehow missed out that second commit [21:08:56] trying with :) [21:08:58] aah [21:09:00] ok :) [21:09:36] looks better :D [21:09:41] sweet! [21:09:49] fixes the '9' problem :) [21:10:25] which was, I believe, the last open bug blocking a 1.3 [21:10:25] :D [21:10:27] yay [21:11:10] [WikipediaMobile] brion pushed 3 new commits to master: http://git.io/7qyVhQ [21:11:10] [WikipediaMobile/master] Migrate Android to PhoneGap 2.1 - YuviPanda [21:11:10] [WikipediaMobile/master] Simple rename to keep iOS at Cordova 1.7 - YuviPanda [21:11:10] [WikipediaMobile/master] Merge pull request #291 from yuvipanda/cordova-2.1-android - Brion Vibber [21:11:21] Project WikipediaMobile - Nightly builds build #421: SUCCESS in 9.5 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/421/ [21:11:21] * yuvipanda: Migrate Android to PhoneGap 2.1 [21:11:22] * yuvipanda: Simple rename to keep iOS at Cordova 1.7 [21:11:31] oh that reminds me [21:11:45] someone merged an i18n change that generates the strings.xml files [21:11:54] this is nice but our build process must be changed to run that makefile now [21:12:13] brion: that was me. [21:12:15] excellent :D [21:12:19] so i'm wondering if we should keep the generated files in tree [21:12:22] should make sure the release documentation is updated if it's not already [21:12:27] like we do with the JSON file [21:12:28] for sitematrix [21:12:42] or if we should build only before release [21:12:51] i'm in favor of keeping them in tree [21:12:51] yeah… i kinda hate having build artifacts in-tree though [21:13:05] well, they hardly change... [21:13:06] we already have to do the 'git submodule' thing for grabbing MobileFrontend [21:13:13] hopefully yes :) [21:13:26] same with sitematrix.json [21:13:29] the list of wikipedias hardly changes :) [21:13:47] :) [21:13:55] if you go ahead and add them back in i won't complain [21:15:13] pull request coming [21:15:41] awjr, could you review new test cases from https://gerrit.wikimedia.org/r/27035 ? [21:15:53] sure in a few mins [21:17:22] New review: awjrichards; "This looks ok, but there appears to still be a stray in HTML output" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/29726 [21:17:38] brion: https://github.com/wikimedia/WikipediaMobile/pull/292 [21:18:05] MaxSem: is there a conf i can use somewhere? [21:18:30] awjr, https://gerrit.wikimedia.org/r/29883 [21:18:41] cool ty [21:19:05] [WikipediaMobile] brion pushed 2 new commits to master: http://git.io/89nX2Q [21:19:05] [WikipediaMobile/master] Add back generated values- files - YuviPanda [21:19:05] [WikipediaMobile/master] Merge pull request #292 from yuvipanda/in-tree-localization - Brion Vibber [21:19:14] Project WikipediaMobile - Nightly builds build #422: SUCCESS in 8.7 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/422/ [21:19:14] yuvipanda: Add back generated values- files [21:22:10] app doesn't seem to explode on my 4.1 or 2.3 phones, yay :) [21:22:25] sweet! [21:22:31] I should make a 1.3 build [21:22:40] yeah, send out a beta maybe [21:24:09] brion: i think i'll push out a beta - from master [21:24:12] (for Android) [21:24:16] yay [21:24:38] yuvipand1: hmm what's status on https://github.com/wikimedia/WikipediaMobile/pull/287 ? i thought we'd already merged these; app runs in full-screen on iPhone 5 sim [21:25:39] MaxSem: can you add tests for wikiquote, wikibooks, wikiversity, meta, and mediawiki.org (mediawiki.org should also be supported in the regex)? [21:26:17] brion: weird, I see those commits in maste [21:27:00] MaxSem: that way we can use the tests to verify those domains are covered [21:27:12] aha [21:28:38] yuvipand1: i'll close it out i guess… it's in https://github.com/wikimedia/WikipediaMobile/commits/v3.2.1-iOS too [21:30:02] feel free to! [21:30:09] preilly: http://www.macrumors.com/2012/10/23/some-apple-retail-stores-offering-30-day-window-to-exchange-ipads-for-new-model/ [21:31:02] yuvipand1: brion before i push the iOS build i want to confirm the branch. i have it on v3.2.1-iOS [21:31:18] that should be the one yeah [21:31:57] thanks [21:31:59] i'll do it later today then [21:32:02] whee [21:32:04] brion: tfinc remember to increment the version number if it already hasn't been! [21:32:12] ooh good point [21:32:13] you need to do it in two places :) [21:32:26] brion: do you want to make a commit doing the 'bump'ing? [21:32:31] ios/platform.js needs it too [21:32:44] IIRC this was documented somewhere [21:32:58] now if we could document where we document our documents... [21:33:40] getAboutVersionString is updated to 3.2.1 in platform.js already [21:33:40] yuvipand1: change it on the branch for me please [21:33:42] was there a manifest bit too? [21:33:56] ok manifest looks updated too [21:34:08] yes, there was one in xcode [21:34:08] sas version 3.2.1, build 3.2.1 [21:34:10] *says [21:34:17] sweet [21:34:38] brion's always one step ahead :) [21:34:53] tfinc, yuvipand1: we should update the build target to 4.3 probably [21:35:07] since i'm not sure we can actually make a 4.2-compatible build (the armv6 stuff) [21:35:37] brion: i though i already changed that [21:35:51] might not have committed it back [21:36:11] or else i haven't updated :) [21:36:20] brion: https://github.com/wikimedia/WikipediaMobile/commit/66bd481fcfb9e4839eec27719060f9eb774b55d5 [21:36:20] authored 12 days ago [21:36:34] - IPHONEOS_DEPLOYMENT_TARGET = 4.2; [21:36:34] 643 [21:36:35] + IPHONEOS_DEPLOYMENT_TARGET = 5.0; [21:36:44] tfinc: ok that says deploy target 5.0 … do we want to drop 4.3 too? [21:37:26] preilly and i set it this way as it refused to validate with 4.2 … i cant' remember if 4.3 worked either but can test it [21:37:32] and yes, confirmed those updates are there, i hadn't done a pull :) [21:37:34] assuming all the other changes are in [21:37:48] 4.3 *should* work. minimum software requirement on that is iPhone 3gs which is armv7 [21:38:04] so do i need to pull any new changes? [21:38:09] I think we can drop 4.x for the next release (3.3) [21:38:32] yeah i'll be happy to kill 4.x entirely, just don't want it to be a surprise in a bug fix release :) [21:38:47] tfinc: I'm doing a Wikipedia Hackathon on Friday night at Hyderabad. I'll see if I can pull in someone to work on mobile stuff :) [21:38:51] yuvipand1: awesome [21:39:01] let us know how we can help [21:39:07] tfinc: no new changes unless you want to flip that target back to 4.3 [21:39:15] but i ain't gonna complain loud if you leave it at 5 :) [21:39:58] will a target of 5 not work on 4.3 devices ? [21:40:06] when preilly passed that to me he said they would not be affeted [21:40:18] and i'd prefer not to make any more changes before submitting for testing [21:40:42] well let's try a build with it at 5 a see what happens :D [21:40:57] lolz [21:42:25] ugh, Xcode won't install to my 4.3 phone cause i don't have the right keys installed. fuckin' apple [21:42:27] it validates just fine with 4.3 [21:42:31] yay [21:42:55] let me see if i can find preilly to find out if building against 4.3 will cause any issues [21:44:51] tfinc: it's a friday and night so I'm hoping people would be online. Past hackathons usually are on saturdays or sunday, so IRC is deserted. Let's see how this turns out! [21:45:37] fun [21:57:32] awjr: i grabbed a copy of http://www.amazon.com/Team-Geek-Software-Developers-Working/dp/1449302440 to read through. will buy more if it continues to be as good as the first chapter i read online [21:59:49] tfinc sweet! looks very intriguing [21:59:59] awjr: its very good so far [22:01:37] by 'buy more' do you mean for the foundation? [22:02:37] what are the rules about sharing ebooks purchased form amazon? [22:02:54] i just bought my own kindle copy, i'm a sucker [22:02:56] :) [22:04:03] oh i see they have a concept of 'lending' which is not enabled for the book [22:04:20] it's surprising they can charge almost as much as the paperback edition but you can't even 'lend' it... [22:04:34] http://www.pcmag.com/article2/0,2817,2411374,00.asp?kc=PCRSS03069TX1K0001121&utm_source=dlvr.it&utm_medium=twitter < -- pcmag [22:04:37] jdlrobson: --^ [22:04:53] oh jeez and even if lending is enabled, books can only be loaned ONCE! [22:05:02] evil evil evil [22:05:16] awjr: i would just buy us paper copies [22:05:31] the other option is to buy them direct from orielly and "share" the pdf [22:05:35] :) [22:05:53] tfinc: http://www.youtube.com/watch?v=K3zkqjpQF8U [22:05:54] heh [22:06:16] lolz [22:11:49] * brion wanders over to the iOS provisioning portal and, hopefully, gets his certs worked out [22:24:22] brion: i added vibha's mockup of the watchlist drill-down view minus diff to card 231: https://mingle.corp.wikimedia.org/projects/mobile/cards/231 [22:25:03] Maryana: awesome thanks [22:30:54] * tfinc puts his old laptop to use by showing https://gdash.wikimedia.org/dashboards/reqmobile/ [22:33:39] awesome [22:42:46] next level in your regex-fu: what's wrong with ^http://(?:www(?=\.mediawiki))?((?:species|meta|incubator|outreach|strategy|wikimania2012)(?=\.wikimedia)|\w+(?!\.wikimedia|\.mediawiki)|(?=\.mediawiki))\.(wikimedia|wikipedia|wiktionary|wikinews|wikisource|wikiquote|wikibooks|wikiversity)\.org[:\d]*/wiki/(.*) ? :gigi: [22:43:16] derp [22:43:23] hehe [22:43:43] luckily, I like regexes [22:44:05] i too have a soft spot in my heart for regexes but they still drive me batty :p [22:46:03] brion: commit 38949db705ebeca2e8333f2a2099f9cd1f1d9ddc [22:48:16] y'all know the xkcd for that, yes? https://xkcd.com/208/ [22:48:53] hehehe [22:51:59] preilly: https://github.com/preillyme/WikipediaMobileFirefoxOS/pull/2 [22:52:40] hmm, http://hh.ru/employer-logo/592962.png [22:52:47] yuvipand1, ^^ [23:11:08] preilly when you a minute can you take a look at https://bugzilla.wikimedia.org/show_bug.cgi?id=35215 and provide any direction if you can? [23:12:46] preilly: a couple more tweaks get the basic app working for me: https://github.com/preillyme/WikipediaMobileFirefoxOS/pulls [23:13:23] course now my b2g profile's busted. :P [23:15:52] brion: merged [23:15:57] thx [23:16:31] ok now to work on that scrolling bug :P :D [23:17:58] New patchset: awjrichards; "Ensure redirect from settings page after success keeps you on mobile site" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29893 [23:18:25] [bugs] NEW [Bug 41339] Saving settings form desktop browser sends me to desktop site (priority: Unprioritized severity: normal) https://bugzilla.wikimedia.org/show_bug.cgi?id=41339 [23:19:47] Maryana: this card says 'NOT NEEDED' in the title https://mingle.corp.wikimedia.org/projects/mobile/cards/196 [23:19:54] does that mean we can just get rid of it for this iteration? [23:20:16] yeah, howie added that to denote stuff that we should put on the backburner [23:20:29] Maryana: should we just move it to the backlog then? [23:20:52] or at the very least, update the priority order of the cards [23:20:52] sounds good. at some point, we might wanna revisit that UI, but not soon [23:21:00] backlog it :) [23:21:07] Maryana: ok, i'll move it to the backlog [23:21:12] sweet. thanks! [23:33:40] brion, jdlrobson, MaxSem, Maryana - i have to take off around 5pm and wanted to make sure you guys aren't waiting on me for anything since i'll be out tomorrow and friday [23:33:55] awjr: i'm good [23:34:24] i think we're set. does this mean you're missing the mobile strategy meeting we have scheduled? [23:34:38] maybe we should reschedule for when you're not cripplingly injured? [23:34:43] Maryana: er… meeting? [23:34:52] friday at 1 [23:35:01] i dont see anything on my calendar [23:35:06] oh, i guess you're not in there [23:35:10] but yes, i will not be available at all on friday [23:35:13] ok, nm, i guess this is more a tomasz/howie sync up [23:35:20] phew [23:35:23] sorry, false alarm! [23:38:26] New patchset: Jdlrobson; "remove bad rule" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29896 [23:39:09] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29896 [23:39:27] jdlrobson: are you in the office? [23:39:38] preilly: yup in mushroom kindgom [23:39:51] jdlrobson: oh okay thanks [23:42:38] preilly: scroll fix :D https://github.com/preillyme/WikipediaMobileFirefoxOS/pull/5 [23:43:40] brion: wh00t css/wikiapp.css | 10 ++++------ 1 files changed, 4 insertions(+), 6 deletions(-) [23:43:46] yayyyy [23:43:49] one mystery solved [23:48:14] New patchset: Jdlrobson; "remove ribbon" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29909 [23:48:14] New patchset: Jdlrobson; "move watchlist icon to right of search box" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29910 [23:49:12] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29909 [23:49:34] jdlrobson: line 62 https://gerrit.wikimedia.org/r/#/c/29910/1/javascripts/common/mf-navigation.js has whitespace issue [23:49:41] thanks preilly [23:50:24] New patchset: Jdlrobson; "move watchlist icon to right of search box" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29910 [23:51:37] brion: preilly said 4.3 is fine so i'm going to push the app for review built against 4.3 [23:51:39] yuvipand1: --^ [23:51:49] ok [23:51:49] cool [23:54:27] all right app has been submitted [23:54:27] woot