[00:00:08] <brion>	 yay
[00:06:45] <tfinc>	 jdlrobson: https://twitter.com/hcatlin/status/261255005712023552 :)
[00:20:03] <preilly>	 jdlrobson: ping
[00:22:10] <jdlrobson>	 preilly: pong
[00:22:50] <preilly>	 jdlrobson: I was just going to talk to you about https://gerrit.wikimedia.org/r/#/c/29910/ but you beat me to it
[00:23:10] <jdlrobson>	 i did?
[00:27:51] <preilly>	 jdlrobson: patch set two
[00:29:57] <tfinc>	 good thing i checked our review status. they didn't bother to message me that we needed all new iPhone 5 screenshots
[00:39:34] <gerrit-wm>	 New patchset: Jdlrobson; "remove conditional ifs" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29914
[00:41:21] <gerrit-wm>	 Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29914
[00:46:08] <gerrit-wm>	 Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29910
[00:46:30] <preilly>	 jdlrobson: this is the one that I wanted you to look at https://gerrit.wikimedia.org/r/#/c/29893/
[00:47:06] <jdlrobson>	 so preilly how do i use my +2
[00:48:51] <gerrit-wm>	 New review: preilly; "Based on Jon looking at it as well I'll +2 it." [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/29893
[00:48:51] <gerrit-wm>	 Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29893
[00:50:07] <preilly>	 jdlrobson: do you see the stray div in https://gerrit.wikimedia.org/r/#/c/29726/1
[01:00:44] <preilly>	 tfinc: the updated squid mobile redirector has been deployed
[08:22:33] <wikipedia-github>	 [WikipediaMobile] yuvipanda force-pushed beta from 8bca905 to c3b8631: http://git.io/UAGDHg
[08:22:33] <wikipedia-github>	 [WikipediaMobile/beta] Add app_name_beta to the list of localized Java strings - YuviPanda
[08:22:33] <wikipedia-github>	 [WikipediaMobile/beta] Apply transformations to make the app into 'Beta' - YuviPanda
[08:22:46] <mw-jenkinsbot>	 Project WikipediaMobile - Nightly builds build #423: SUCCESS in 11 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/423/
[08:22:46] <mw-jenkinsbot>	 * Brion VIBBER: Update Windows 8 app from RC to final RTM version
[08:22:47] <mw-jenkinsbot>	 * s.mazeland: Localisation updates from http://translatewiki.net.
[08:22:47] <mw-jenkinsbot>	 * Brion VIBBER: Fix Twitter detection on iOS 6; fix share dialog cancel button on iOS 4
[08:22:48] <mw-jenkinsbot>	 * s.mazeland: Localisation updates from http://translatewiki.net.
[08:22:48] <mw-jenkinsbot>	 * s.mazeland: Localisation updates from http://translatewiki.net.
[08:22:49] <mw-jenkinsbot>	 * Brion VIBBER: New SVG master for Windows 8 app tiles, scaled versions for different screen densities
[08:22:49] <mw-jenkinsbot>	 * Brion VIBBER: Add .gitignore for Windows 8 project user settings and build directories
[08:22:50] <mw-jenkinsbot>	 * s.mazeland: Localisation updates from http://translatewiki.net.
[08:22:50] <mw-jenkinsbot>	 * Brion VIBBER: Bug 39812 - Windows 8 app: back button should use native WinJS button with stock icon
[08:22:51] <mw-jenkinsbot>	 * Brion VIBBER: Bug 39810: bump resolution for Win8 secondary tile / generic bg
[08:22:51] <mw-jenkinsbot>	 * Brion VIBBER: Bug 39850: show Windows 8 search pane on keyboard input
[08:22:52] <mw-jenkinsbot>	 * Brion VIBBER: Bug 37366, bug 39914: fix Windows 8 activation bugs
[08:22:52] <mw-jenkinsbot>	 * Brion VIBBER: Multiple resolutions for Win8 splash screen
[08:22:53] <mw-jenkinsbot>	 * Brion VIBBER: Win8: RTL layout for content text when showing RTL languages
[08:22:53] <mw-jenkinsbot>	 * Brion VIBBER: Quick initial stab at find-in-page feature
[08:22:54] <mw-jenkinsbot>	 * Brion VIBBER: Win8: More or less workable find bar
[08:22:58] <mw-jenkinsbot>	 * Brion VIBBER: Add a README.md for the Windows 8/Windows RT Metro-style app subunit.
[08:23:06] <mw-jenkinsbot>	 * yuvipanda: Added more font size choices
[08:23:06] <mw-jenkinsbot>	 * yuvipanda: Remove Font Size labels
[08:23:07] <mw-jenkinsbot>	 * s.mazeland: Localisation updates from http://translatewiki.net.
[08:23:07] <mw-jenkinsbot>	 * Brion VIBBER: Win8: square off images in hub tiles, except for today's picture which we show at approx 3:2 or 2:3 to break up the visuals
[08:23:08] <mw-jenkinsbot>	 * Brion VIBBER: Win8: if text is selected when we share, share the selected text instead of page link
[08:23:12] <mw-jenkinsbot>	 * Brion VIBBER: Win8: keyboard focus, keyboard shortcut for find
[08:23:12] <mw-jenkinsbot>	 * Brion VIBBER: Win8: fix locale initialization
[08:23:12] <mw-jenkinsbot>	 * Brion VIBBER: iOS 6 fix for loading saved pages
[08:23:12] <mw-jenkinsbot>	 * yuvipanda: (bug 39269)Fix references being populated twice
[08:23:12] <mw-jenkinsbot>	 * Brion VIBBER: Temporary 1024x1024 icon for iTunes
[08:23:12] <mw-jenkinsbot>	 * Brion VIBBER: Better scaled version of 1024x1024 icon
[08:23:12] <mw-jenkinsbot>	 * Brion VIBBER: Update win8 build version number to 1.0.0.28
[08:23:12] <mw-jenkinsbot>	 * s.mazeland: Localisation updates from http://translatewiki.net.
[08:23:12] <mw-jenkinsbot>	 * s.mazeland: Localisation updates from http://translatewiki.net.
[08:23:13] <mw-jenkinsbot>	 * yuvipanda: Migrate Android to PhoneGap 2.1
[08:23:13] <mw-jenkinsbot>	 * yuvipanda: Simple rename to keep iOS at Cordova 1.7
[08:23:14] <mw-jenkinsbot>	 * yuvipanda: Remove of old ressources that were used by google map based "near me" feature
[08:23:14] <mw-jenkinsbot>	 * yuvipanda: Add of a python script that create res/values files from app i18n in order to have proper i18n for java side of the Android app
[09:00:54] <yuvipanda>	 some spam, tha
[09:58:50] <wikipedia-github>	 [WikipediaMobile] yuvipanda force-pushed beta from c3b8631 to 816cebc: http://git.io/UAGDHg
[09:58:50] <wikipedia-github>	 [WikipediaMobile/beta] Bumped version and updated CHANGELOG - YuviPanda
[09:58:50] <wikipedia-github>	 [WikipediaMobile/beta] Apply transformations to make the app into 'Beta' - YuviPanda
[09:58:59] <mw-jenkinsbot>	 Project WikipediaMobile - Nightly builds build #424: SUCCESS in 8.6 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/424/
[09:59:00] <mw-jenkinsbot>	 * yuvipanda: Bumped version and updated CHANGELOG
[09:59:00] <mw-jenkinsbot>	 * yuvipanda: Apply transformations to make the app into 'Beta'
[10:27:00] <wikipedia-github>	 [WikipediaMobile] yuvipanda force-pushed beta from 816cebc to a02fa2d: http://git.io/UAGDHg
[10:27:00] <wikipedia-github>	 [WikipediaMobile/beta] Generate English version of Android strings too - YuviPanda
[10:27:00] <wikipedia-github>	 [WikipediaMobile/beta] Apply transformations to make the app into 'Beta' - YuviPanda
[10:27:08] <mw-jenkinsbot>	 Project WikipediaMobile - Nightly builds build #425: SUCCESS in 8.5 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/425/
[10:27:13] <mw-jenkinsbot>	 * yuvipanda: Generate English version of Android strings too
[10:27:13] <mw-jenkinsbot>	 * yuvipanda: Apply transformations to make the app into 'Beta'
[15:36:17] <thedj[work]>	 How about a X in front of that "close this section" ?
[15:50:07] <gerrit-wm>	 New patchset: TheDJ; "Remove printonly and geo classes from MF" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29974
[15:59:51] <mw-jenkinsbot>	 Project WikipediaMobile - Nightly builds build #426: SUCCESS in 28 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/426/
[17:03:49] <gerrit-wm>	 New patchset: Jdlrobson; "make Special:MobileMenu take up full screen on tablets" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29982
[17:09:34] <preilly>	 jdlrobson: can you review https://gerrit.wikimedia.org/r/#/c/29974/
[17:09:49] <jdlrobson>	 yep don't worry it's on my todo list
[17:09:49] <gerrit-wm>	 Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29982
[17:13:52] <gerrit-wm>	 New patchset: Jdlrobson; "don't close navigation on larger screens when clicking search" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29985
[17:13:52] <gerrit-wm>	 New patchset: Jdlrobson; "fix horizontal scroll issue when navigation open on chrome" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29986
[17:16:08] <gerrit-wm>	 Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29974
[17:16:59] <preilly>	 jdlrobson: please fix the whitespace in https://gerrit.wikimedia.org/r/#/c/29985/1/stylesheets/less/common/mf-navigation.less
[17:41:40] <qgil>	 Hi, I was surprised about how good our contribs stats look like and I was suspicious about the role of translators (as opposed to pure coders)
[17:41:55] <qgil>	 but it seems that all translations are handled by a single TranslateWiki bot? e.g. https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/ArticleFeedbackv5.git;a=search;h=refs/changes/35/29835/1;s=Translation+updater+bot;st=author
[17:42:08] <qgil>	 If this is true then it's very good news
[17:42:45] <chrismcmahon>	 qgil: siebrand is the expert on the translate bot I think
[17:43:26] <yuvipanda>	 qgil: siebrand or nikerabbit
[17:44:22] <chrismcmahon>	 qgil: I will say it's frustrating when the translate bot does a drive-by update of a whole repo just before one tries to commit a change :)
[17:45:00] <qgil>	 chrismcmahon, the type of problem many would like to have in their projects  chrismcmahon
[17:45:14] <gerrit-wm>	 New patchset: Jdlrobson; "don't close navigation on larger screens when clicking search" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29985
[17:46:11] <qgil>	 after looking through the repos of a couple of project it does seem that all commits related to translations come from Translation updater bot <l10n-bot@translatewiki.net>
[17:46:18] <chrismcmahon>	 qgil: ha!  point taken :)
[17:46:29] <gerrit-wm>	 Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29985
[17:46:52] <qgil>	 I can't think about other non-coder profiles sending commits to our repos (excluding those filled with generated data)
[17:47:53] <qgil>	 So maybe those impressive stats showing a huge contributors growth are true?
[17:48:05] <qgil>	 Skeptical /me must keep digging
[17:52:01] <wm-bot>	 [bugs] NEW [Bug 41397] Pinch zoom on Opera (priority: Unprioritized severity: enhancement) https://bugzilla.wikimedia.org/show_bug.cgi?id=41397
[17:59:10] <MaxSem>	 so no meeting today?
[17:59:25] <brion>	 good question...
[17:59:28] <brion>	 no tfinc or awjr
[17:59:47] * yuvipanda  pokes brion with https://github.com/wikimedia/WikipediaMobile/pull/293

[18:00:34] <brion>	 yuvipanda: nice
[18:00:48] <wikipedia-github>	 [WikipediaMobile] brion pushed 1 new commit to master: http://git.io/a1nj-w
[18:00:48] <wikipedia-github>	 [WikipediaMobile/master] Merge pull request #293 from yuvipanda/english-generated - Brion Vibber
[18:01:01] <mw-jenkinsbot>	 Project WikipediaMobile - Nightly builds build #427: SUCCESS in 10 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/427/
[18:01:01] <mw-jenkinsbot>	 * yuvipanda: Add app_name_beta to the list of localized Java strings
[18:01:01] <mw-jenkinsbot>	 * yuvipanda: Bumped version and updated CHANGELOG
[18:01:01] <mw-jenkinsbot>	 * yuvipanda: Generate English version of Android strings too
[18:01:50] <brion>	 sounds like it's being moved to tomorrow
[18:02:06] <yuvipanda>	 brion: I also pushed out the beta to Google Play and sent out an announce.
[18:02:13] <brion>	 i saw the update in my google play and the announce, yay :D
[18:02:31] <yuvipanda>	 sweet!
[18:02:32] <gerrit-wm>	 New patchset: Jdlrobson; "move mf-banner into less file" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29991
[18:02:37] <gerrit-wm>	 New patchset: Jdlrobson; "correct buttons in zero banners" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29992
[18:02:38] <yuvipanda>	 hope that can go directly to 'stable' soon :)
[18:05:51] <gerrit-wm>	 New patchset: Jdlrobson; "move summary collapse arrow to bottom of heading" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29993
[18:11:05] <gerrit-wm>	 Change merged: Brion VIBBER; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29993
[18:21:52] <qgil>	 No engineering hangout now? I'm in SF anyway. Anybody willing to open me the door / have lunch?  :)
[18:22:12] <qgil>	 I was hoping to meet aklapper sumanah but they seem to be missing, hum... (suspicious)  :)
[18:23:19] <jdlrobson>	 preilly: actually it seems to be gadget related.. works fine on my local machine
[18:25:24] <gerrit-wm>	 Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29992
[18:25:24] <gerrit-wm>	 Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29991
[18:25:57] <preilly>	 jdlrobson: can you please rebase https://gerrit.wikimedia.org/r/#/c/29986/
[18:28:28] <gerrit-wm>	 New patchset: Jdlrobson; "fix horizontal scroll issue when navigation open on chrome" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29986
[18:30:16] <gerrit-wm>	 Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29986
[18:36:29] <preilly>	 jdlrobson: please take a quick look at the site
[18:37:16] <jdlrobson>	 preilly: sure thing
[18:37:45] <preilly>	 jdlrobson: thanks
[18:38:01] <jdlrobson>	 looks good to me!
[18:38:26] <preilly>	 jdlrobson: okay great
[18:38:30] <preilly>	 jdlrobson: thanks for all the fixes and all of your hard work
[18:38:33] <preilly>	 jdlrobson: you rock!
[18:38:43] <jdlrobson>	 :)
[18:38:48] <jdlrobson>	 no brion ? :(
[18:42:48] <jdlrobson>	 Maryana: any chance of grabbing a designer up there?
[18:43:15] <Maryana>	 lemme see if munaf is busy
[18:43:21] <jorm>	 what do you need, jon?
[18:43:48] <jorm>	 jdlrobson: ^
[18:44:06] <jdlrobson>	 i'm just working on language selection
[18:44:20] <jdlrobson>	 and wanted to bring back some code we wrote ages ago that i'm really missing - but it doesn't feature in the current design
[18:45:05] <Maryana>	 c'mon up to 6 if you want to get some feedback from munaf
[18:45:52] <Maryana>	 hey, we're not serving fundraising banners on the beta, are we?
[18:46:22] <jdlrobson>	 Maryana: ?
[18:46:37] <Maryana>	 this guy says he's having a hard time hiding a fundraising banner: https://meta.wikimedia.org/wiki/Talk:Mobile_projects/Beta#on_iPhone_hard_to_hide_banner
[18:46:45] <Maryana>	 is he just confused?
[18:46:48] <jdlrobson>	 wtf?
[18:47:01] <jdlrobson>	 probably talking about desktop site?
[18:47:17] <Maryana>	 yeah
[18:47:24] <jdlrobson>	 we have enabled ResourceLoader on beta
[18:47:32] <jdlrobson>	 it's possible some gadget is adding a banner now to some project
[18:47:35] <jdlrobson>	 unfortunately..
[18:47:38] <Maryana>	 eek
[18:47:50] <jorm>	 he's on the desktop site, i'm guessing.
[18:48:05] <Maryana>	 yeah, i'm 95% sure that's the problem
[18:48:15] <Maryana>	 i will investigate
[18:48:18] <jdlrobson>	 probably worth asking the project name and language
[18:48:34] <jdlrobson>	 we do have banners
[18:48:40] <jdlrobson>	 but they are a configuration thing
[18:48:45] <jorm>	 so, right now, i'm wanting to make sure that i've seen any new changes to chrome and such not on the mobile site, if possible.
[18:48:59] <jorm>	 there's a lot of stuff that's been going on and i don't know that there's a cohesive plan.
[18:51:06] <jorm>	 esp. given yesterday's bit about removing page headers.
[18:52:49] <Maryana>	 well, all the devs are going to be out for the month of november. so we're going to have a lot of free time to catch up/plan
[18:52:49] <Maryana>	 heh
[18:56:33] <Maryana>	 one more question from the beta talk page: does the mobile site load en:MediaWiki:Mobile.css?
[18:57:12] <jorm>	 Right.  Well, there's stuff that's being "rushed in" before november that I'm not sure I'm aware of.  It's things like that.
[18:57:47] <Maryana>	 we have one more major deployment before nov., which is watchlist stuff
[18:58:02] <Maryana>	 that's pretty much it
[19:01:21] <Maryana>	 jdlrobson, did you get your lang. selector issue sorted out?
[19:02:03] <Maryana>	 btw, i kinda agree w/your email about the placement, but i also feel like the more we move it around, the more we'll confuse regular users like that guy
[19:06:28] <jdlrobson>	 https://twitter.com/nubero/status/261542697511309313 < hahahahaa
[19:06:53] <jdlrobson>	 hurray for bad ui!
[19:06:56] <gerrit-wm>	 New patchset: Jdlrobson; "bring back language filter code" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30002
[19:06:56] <gerrit-wm>	 New patchset: Jdlrobson; "jslint / whitespace fixes" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30003
[19:08:27] <Maryana>	 awww
[19:08:31] <Maryana>	 that makes me haz a sad
[19:14:57] <preilly>	 jdlrobson: what is the status with: https://gerrit.wikimedia.org/r/#/c/28766/
[19:15:32] <preilly>	 jdlrobson: as well as: https://gerrit.wikimedia.org/r/#/c/29621/
[19:15:46] <jdlrobson>	 the first was a brion experiment - https://gerrit.wikimedia.org/r/#/c/29621/ i'm about to review
[19:19:36] <preilly>	 jdlrobson: okay cool
[19:19:40] <preilly>	 jdlrobson: thanks for the update
[19:22:25] <jdlrobson>	 Maryana: we should be including MediaWiki:Mobile.css yes
[19:22:32] <jdlrobson>	 best to check with MaxSem
[19:23:24] <Maryana>	 thx - just trying to answer some of the feedback on meta
[19:23:27] <MaxSem>	 it used to - lemme check how it works after recent RL changes
[19:23:42] <Maryana>	 ok, thanks, maxsem :)
[19:26:17] <MaxSem>	 brion, I'm seeing gadgets getting loaded in mobile view - is that expected?
[19:26:43] <MaxSem>	 (loading and failing)
[19:28:23] <MaxSem>	 oh, no brion
[19:31:28] <MaxSem>	 Maryana, yes - I see it
[19:31:38] <MaxSem>	 both beta and non-beta
[19:32:08] <Maryana>	 k, thanks! somebody had a question about navboxes on beta
[19:32:23] <Maryana>	 they said they don't seem to be applying the hlist class anymore?
[19:32:54] <wm-bot>	 [bugs] NEW [Bug 41401] Wide margins on some webkit browsers (priority: Unprioritized severity: normal) https://bugzilla.wikimedia.org/show_bug.cgi?id=41401
[19:34:11] <wm-bot>	 [bugs] NEW [Bug 41402] MF loads lots of non-mobile modules like gadgets (priority: Unprioritized severity: major) https://bugzilla.wikimedia.org/show_bug.cgi?id=41402
[19:35:29] <gerrit-wm>	 New review: Jdlrobson; "Please also add stylesheets/less/specials/watchlist.less and update Makefile" [mediawiki/extensions/MobileFrontend] (master) C: -1;  - https://gerrit.wikimedia.org/r/29621
[20:19:14] <gerrit-wm>	 New patchset: Jdlrobson; "ensure content takes up full width (bug 41401)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30059
[20:25:28] <wm-bot>	 [bugs] NEW [Bug 40318] Special:UserLogin broken in MobileFrontend (priority: Unprioritized severity: normal) https://bugzilla.wikimedia.org/show_bug.cgi?id=40318
[20:27:00] <wm-bot>	 [bugs] NEW [Bug 37281] Special:Search doesn't properly redirect on mobile devices (priority: Unprioritized severity: normal) https://bugzilla.wikimedia.org/show_bug.cgi?id=37281
[20:29:41] <gerrit-wm>	 New patchset: Jdlrobson; "use min-width instead of width for save settings button (bug 41357)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30063
[20:30:09] <wm-bot>	 [bugs] NEW [Bug 41357] MobileFrontend options save button too small for German text (priority: Unprioritized severity: normal) https://bugzilla.wikimedia.org/show_bug.cgi?id=41357
[20:31:44] <wm-bot>	 [bugs] NEW [Bug 40987] Clicking jump back a section doesn't work on WP7 (priority: Unprioritized severity: enhancement) https://bugzilla.wikimedia.org/show_bug.cgi?id=40987
[20:38:13] <wm-bot>	 [bugs] NEW [Bug 41141] Meta-Wiki mobile site has errant trademark symbol (™) in footer (priority: Unprioritized severity: enhancement) https://bugzilla.wikimedia.org/show_bug.cgi?id=41141
[20:50:16] <brion>	 MaxSem, jdlrobson: any objection to disabling the MF resource loader integration in beta for now since it"s broken on the wmf1 wikis?
[20:50:44] <jdlrobson>	 brion: i would like that
[20:50:55] <jdlrobson>	 i would like that a lot
[20:50:57] <MaxSem>	 brion, I see gadgets on wmf2 too
[20:51:10] <brion>	 hmmmm
[20:51:14] <brion>	 then we should def turn it off until it's better tested
[20:51:15] <jdlrobson>	 MaxSem: brion yeh i noticed on en.wiki
[20:51:26] <jdlrobson>	 is it a config change?
[20:51:28] <brion>	 yeah $wgMFEnableResourceLoader = false;
[20:52:05] <brion>	 MaxSem: can you add that into CommonSettings? i probably can in theory but i haven't deployed anything yet on the new system and i don't want to break it in case my account is broken in some way :)
[20:52:28] <Krinkle>	 brion: jdlrobson: for future reference though, be careful fast-forwarding extensions in old wmf-branches. Small breaking changes in rapidly developing projects aren't that rare, always important to keep the HEADs in sync.
[20:52:45] <Krinkle>	 and not fast-forward the latest master of an extension on an old wmf-branch.
[20:52:47] <brion>	 *nod*
[20:52:59] <brion>	 Krinkle: next time we'll use feature detection as well :)
[20:52:59] <Krinkle>	 anyway, it is limited to the beta, right?
[20:53:03] <brion>	 yeah
[20:53:05] <Krinkle>	 definitelely
[20:53:05] <MaxSem>	 brion, then it would be beneficial for you to have some experience for the deployment discussion :D:D:D
[20:53:15] <brion>	 :D
[20:53:15] <Krinkle>	 definitely*
[20:53:55] <MaxSem>	 but if you're still unsure, I've no problems deploying it myself
[20:54:03] <brion>	 lemme give it a try
[20:54:42] <brion>	 hmm, wait
[20:54:50] <brion>	 do we have source control on the config?
[20:54:56] <MaxSem>	 operations/mediawiki-config
[20:55:06] <brion>	 excellent
[20:56:19] <MaxSem>	 brion, have you read http://wikitech.wikimedia.org/view/How_to_deploy_code ?
[20:56:29] <brion>	 looking at it now
[21:00:31] <brion>	 MaxSem: look ok? https://gerrit.wikimedia.org/r/30070
[21:01:41] <MaxSem>	 brion, yes
[21:02:07] <MaxSem>	 I can merge it when we're ready to deploy
[21:02:23] <brion>	 great :D
[21:19:29] * yuvipanda  pokes andre__ 

[21:19:32] <yuvipanda>	 (better spot here, I think)
[21:20:02] <gerrit-wm>	 New patchset: Brion VIBBER; "bug 41141: don't output TM or (R) next to the sitename by default." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30077
[21:20:30] <preilly>	 jdlrobson: where is the .css file for this https://gerrit.wikimedia.org/r/#/c/30063/
[21:20:36] <andre__>	 yuvipanda, eh?
[21:20:48] <jdlrobson>	 preilly: whoops ;-)
[21:21:01] <gerrit-wm>	 Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30077
[21:21:05] <yuvipanda>	 andre__: -mobile.
[21:21:27] <yuvipanda>	 andre__: I was going to ask you if I could move github.com/yuvipanda/commons/issues to bugzilla
[21:21:48] <yuvipanda>	 andre__: or rather, at what point exactly something could get a bugzilla product / component
[21:22:19] <gerrit-wm>	 New patchset: Jdlrobson; "use min-width instead of width for save settings button (bug 41357)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30063
[21:22:20] <yuvipanda>	 andre__: and if we start adding a fair amount of apps, if having a product called 'apps' with individual 'components'? makes sense? (like mediawiki extensions)
[21:22:44] <yuvipanda>	 andre__: nothing urgent, ofcourse. Just wanted to throw those things out there - I'm pretty sure having bugs on bugzilla will improve visibility a lot.
[21:22:54] <yuvipanda>	 (WikipediaMobile stuff is on github, but bugs on bz)
[21:24:13] <gerrit-wm>	 New review: Brion VIBBER; "Confirmed can read the entire button in German now. :)" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 2;  - https://gerrit.wikimedia.org/r/30063
[21:24:13] <gerrit-wm>	 Change merged: Brion VIBBER; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30063
[21:24:38] <brion>	 jdlrobson: i'm seeing another oddity with the save settings button -- on iOS while it's being pressed, it reverts to a different style
[21:25:03] <jdlrobson>	 brion: that's expected
[21:25:10] <jdlrobson>	 it's the push style
[21:25:43] <brion>	 well it goes from a roundrect to a rectangle with full half-circles on the end, and the spacing and size change
[21:25:49] <brion>	 it looks wrong to me
[21:25:58] <brion>	 as well as the color changing
[21:29:20] <MaxSem>	 brion, problems with deploment? I can deploy myself
[21:29:44] <preilly>	 brion: can you review https://gerrit.wikimedia.org/r/#/c/30059/
[21:29:53] <preilly>	 and https://gerrit.wikimedia.org/r/#/c/30003/
[21:29:53] <brion>	 MaxSem: i haven't touched it past submitting to gerrit :)
[21:30:05] <preilly>	 and https://gerrit.wikimedia.org/r/#/c/30002/
[21:30:14] <brion>	 looking...
[21:30:25] <preilly>	 brion: thanks!
[21:30:36] * preilly  thinks brion rocks!

[21:30:38] <gerrit-wm>	 New patchset: Jdlrobson; "bring basic editing to mobile" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30079
[21:30:39] <gerrit-wm>	 New patchset: Jdlrobson; "add edit link to pages in beta mode" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30080
[21:30:39] <gerrit-wm>	 New patchset: Jdlrobson; "add javascript to split large edit area into several edit boxes" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30081
[21:30:39] <gerrit-wm>	 New patchset: Jdlrobson; "enable toggling on edit page" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30082
[21:30:40] <jdlrobson>	 BOOM
[21:30:56] <brion>	 whee
[21:31:00] <MaxSem>	 you mean SPAM?
[21:31:40] <MaxSem>	 brion, ok - I'll deploy myself
[21:31:44] <brion>	 tx
[21:32:02] <gerrit-wm>	 Change merged: Brion VIBBER; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30059
[21:32:57] <jdlrobson>	 mm preilly I'm seeing "undefined variable: zeroRatedLinkHref in /Users/jrobson/Sites/w/extensions/ZeroRatedMobileAccess line 482 on certain pages
[21:34:03] <jdlrobson>	 brion wait
[21:34:04] <jdlrobson>	 https://gerrit.wikimedia.org/r/#/c/30077/
[21:34:14] <jdlrobson>	 there was a legal reason that was there
[21:34:14] <jdlrobson>	 I forget what
[21:34:17] <jdlrobson>	 DO NOT DEPLOY THIS
[21:34:21] <gerrit-wm>	 Change merged: Brion VIBBER; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30003
[21:34:21] <gerrit-wm>	 Change merged: Brion VIBBER; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30002
[21:35:01] <preilly>	 jdlrobson: it's fine to deploy
[21:35:02] <brion>	 jdlrobson: if it's for legal reasons, then we really don't want to be outputting "™" on things that aren't trademarks like "Meta"
[21:35:15] <jdlrobson>	 sure
[21:35:15] <jdlrobson>	 but make sure Wikipedia has it
[21:35:24] <brion>	 wikipedia's got the magic pretty icon with a ® in it
[21:35:30] <jdlrobson>	 this should really be checked with legal
[21:35:30] <preilly>	 jdlrobson: we just need to add Wikipedia check
[21:36:39] <jdlrobson>	 it's slightly more complicated preilly
[21:37:03] <jdlrobson>	 I was told English Wikipedia should show ® whilst Wikipedia in another language should show ™ - please ensure this remains the same on the Wikipedia.org site.
[21:37:03] <preilly>	 jdlrobson: okay I'll believe you
[21:37:50] <brion>	 are all our site name variants actually trademarked?
[21:38:06] <jdlrobson>	 brion: you should run this through legal before deploying
[21:38:14] <jdlrobson>	 Phil told me to do it urgently when I did it
[21:38:22] <jdlrobson>	 hence the rushed job
[21:38:22] <jdlrobson>	 I forget the reason why though
[21:38:27] <brion>	 sure, i'll send a note out
[21:38:31] <jdlrobson>	 thanks
[21:38:38] <jdlrobson>	 sorry for the CAPSLOCK :D
[21:39:01] <brion>	 WHAT NO PROBLEM
[21:39:09] <jdlrobson>	 so preilly Notice: Undefined variable: zeroRatedLinkHref in /Users/jrobson/Sites/w/extensions/ZeroRatedMobileAccess/ZeroRatedMobileAccess.body.php on line 482 < why is that only showing on certain pages for me?
[21:40:41] <andre__>	 YuviPanda|Prep, let me come back to that later, meeting right now
[21:40:49] <preilly>	 jdlrobson: $zeroRatedExternalLinkHref = $zeroRatedExternalLink->getAttribute( 'href' ); should probably have a default
[21:41:03] <jdlrobson>	 it's strange - it only shows on one article on my wiki! :)
[21:41:14] <jdlrobson>	 "Free JDLR from Wikimedia" ! :D
[21:41:15] <jdlrobson>	 still makes me chuckle
[21:41:17] <jdlrobson>	 (content of banner)
[21:41:24] <jdlrobson>	 (where JDLR is my name)?
[21:52:54] <YuviPanda|Prep>	 andre__: okay :)
[22:10:18] <jdlrobson>	 \o/ indian visa
[22:11:05] <jdlrobson>	 Maryana|brb: - knew i forgot something… i need a design showing what drop down notice looks like
[22:11:36] <MaxSem>	 jdlrobson, 5 year business one?
[22:11:42] <jdlrobson>	 no only 6 months for some reason
[22:11:44] <jdlrobson>	 they didn't explain hwy
[22:12:53] <MaxSem>	 other way around for me: I applied for a single entry visa, got dual-entry 6 months
[22:13:14] <Maryana|brb>	 jdlrobson, ah, yes - will ask vibha bout that since it was her idea
[22:13:25] <brion>	 they must love me for some reason, they gave me the five year
[22:13:46] <jdlrobson>	 Maryana|brb: i'm still not convinced we need one
[22:14:10] <jdlrobson>	 good news is i now have only 8 pages to kill in my passport
[22:16:14] <Maryana>	 talked to vibha - she said it would be good to have a one-time msg, just a small tooltip. she's working on a quick sketch
[22:16:30] <Maryana>	 since there are so many different kinds of star/saving actions all over the internet these days
[22:50:52] <gerrit-wm>	 New patchset: Jdlrobson; "move watchlist.css into less file" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30093
[22:50:52] <gerrit-wm>	 New patchset: Jdlrobson; "move watch article css from mf-navigation to mf-watchlist" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30094
[22:50:52] <gerrit-wm>	 New patchset: Jdlrobson; "change watch list icon to black star" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30095
[23:00:45] <gerrit-wm>	 New patchset: Jdlrobson; "1px tweak to menu items" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30098
[23:16:16] * jdlrobson  resisting urge to reply to someone who starts his email with "Hello genius designers" with "Dear person who doesn't know anything about web development"

[23:22:18] <jdlrobson>	 Maryana: i'm pushing back https://mingle.corp.wikimedia.org/projects/mobile/cards/197 to ready for analysis - it's very confusing - the designs show an orange icon but the icon you've given me is black -it also talks about article issues on a section level and i thought we were just focusing on general article issues - it also assumes you can style the existing cleanup templates which you cannot - can you get these sorted?
[23:29:23] <gerrit-wm>	 New review: Jdlrobson; "Also every time I click watchlist in menu or a filter it redirects me to the desktop version" [mediawiki/extensions/MobileFrontend] (master) C: -1;  - https://gerrit.wikimedia.org/r/29621