[04:04:05] [WikipediaMobile] preillyme pushed 2 new commits to master: http://git.io/d8s8SA [04:04:05] WikipediaMobile/master b59c61e YuviPanda: Upgraded to jQuery 1.8.2 [04:04:05] WikipediaMobile/master ffe2323 Patrick Reilly: Merge pull request #302 from yuvipanda/jquery-1.8.2-update... [04:04:19] [WikipediaMobile] preillyme pushed 2 new commits to master: http://git.io/s2Vb-w [04:04:19] WikipediaMobile/master 4b93ee3 YuviPanda: Upgrade to leaflet 4.5.... [04:04:19] WikipediaMobile/master 29b7e6c Patrick Reilly: Merge pull request #301 from yuvipanda/leaflet-upgrade-v4.5... [04:04:19] Project WikipediaMobile - Nightly builds build #430: SUCCESS in 12 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/430/ [04:04:19] yuvipanda: Upgraded to jQuery 1.8.2 [04:04:34] Project WikipediaMobile - Nightly builds build #431: SUCCESS in 9.6 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/431/ [04:04:35] yuvipanda: Upgrade to leaflet 4.5. [04:04:52] [WikipediaMobile] preillyme pushed 2 new commits to master: http://git.io/REp2wA [04:04:52] WikipediaMobile/master 058c232 YuviPanda: Do not display title on the main page [04:04:52] WikipediaMobile/master 7554530 Patrick Reilly: Merge pull request #305 from yuvipanda/mainpage-no-title... [04:04:58] [WikipediaMobile] preillyme pushed 2 new commits to master: http://git.io/yDB0gw [04:04:58] WikipediaMobile/master 229b460 YuviPanda: Remove useless 'redirects' parameter being sent to API... [04:04:58] WikipediaMobile/master 7370df4 Patrick Reilly: Merge pull request #304 from yuvipanda/remove-useless-api-param... [04:05:06] Project WikipediaMobile - Nightly builds build #432: SUCCESS in 9.7 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/432/ [04:05:06] * yuvipanda: Remove useless 'redirects' parameter being sent to API [04:05:06] * yuvipanda: Do not display title on the main page [04:05:22] [WikipediaMobile] preillyme pushed 2 new commits to master: http://git.io/nQWx3g [04:05:22] WikipediaMobile/master 03eea23 YuviPanda: (Bug 33881) Autohide the search bar... [04:05:22] WikipediaMobile/master 913efd4 Patrick Reilly: Merge pull request #303 from yuvipanda/auto-hide-searchbar... [04:05:37] Project WikipediaMobile - Nightly builds build #433: SUCCESS in 12 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/433/ [04:05:37] yuvipanda: (Bug 33881) Autohide the search bar [04:06:00] [WikipediaMobile] preillyme pushed 2 new commits to master: http://git.io/Zf4N9Q [04:06:00] WikipediaMobile/master e94da29 YuviPanda: (Bug 38912) Fix directionality for text in map bubbles [04:06:00] WikipediaMobile/master f2b997e Patrick Reilly: Merge pull request #300 from yuvipanda/leaflet-bubble-direction... [04:06:10] Project WikipediaMobile - Nightly builds build #434: SUCCESS in 9.6 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/434/ [04:06:10] yuvipanda: (Bug 38912) Fix directionality for text in map bubbles [04:06:44] [WikipediaMobile] preillyme pushed 2 new commits to master: http://git.io/rd8dtQ [04:06:44] WikipediaMobile/master 163a2ac YuviPanda: (Bug 39048) Make page language dir not affect footer direction [04:06:44] WikipediaMobile/master 2a73011 Patrick Reilly: Merge pull request #298 from yuvipanda/footer-direction... [04:06:57] [WikipediaMobile] preillyme pushed 2 new commits to master: http://git.io/m0HDiA [04:06:57] WikipediaMobile/master 6e9cc6b YuviPanda: (Bug 38001) Remove limit of 50 saved pages from Wikipedia app [04:06:57] WikipediaMobile/master a2fb4da Patrick Reilly: Merge pull request #297 from yuvipanda/no-saved-pages-limit... [04:06:57] Project WikipediaMobile - Nightly builds build #435: SUCCESS in 9.5 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/435/ [04:06:57] * yuvipanda: (Bug 38001) Remove limit of 50 saved pages from Wikipedia app [04:06:57] * yuvipanda: (Bug 39048) Make page language dir not affect footer direction [04:06:59] [WikipediaMobile] preillyme pushed 2 new commits to master: http://git.io/WJWD8w [04:06:59] WikipediaMobile/master 408534d YuviPanda: Add appropriate classes to the body, as with MobileFrontent... [04:06:59] WikipediaMobile/master 98e285f Patrick Reilly: Merge pull request #296 from yuvipanda/mf-production-classes... [04:07:12] Project WikipediaMobile - Nightly builds build #436: SUCCESS in 9.6 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/436/ [04:07:12] yuvipanda: Add appropriate classes to the body, as with MobileFrontent [04:07:12] [WikipediaMobile] preillyme pushed 2 new commits to master: http://git.io/qBfKpA [04:07:12] WikipediaMobile/master 4583601 YuviPanda: Load site-specific mobile CSS [04:07:12] WikipediaMobile/master 8203eab Patrick Reilly: Merge pull request #295 from yuvipanda/add-site-css... [04:07:28] Project WikipediaMobile - Nightly builds build #437: SUCCESS in 9.6 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/437/ [04:07:28] yuvipanda: Load site-specific mobile CSS [08:23:41] [bugs] NEW [Bug 40458] preference for "near by" default location (priority: Unprioritized severity: enhancement) https://bugzilla.wikimedia.org/show_bug.cgi?id=40458 [09:16:03] [bugs] NEW [Bug 28515] Dynamic fonts support in mobile gateway (priority: Normal severity: enhancement) https://bugzilla.wikimedia.org/show_bug.cgi?id=28515 [12:46:31] [bugs] NEW [Bug 35251] Add a 'Night Mode' to the Wikipedia Mobile app (priority: Normal severity: enhancement) https://bugzilla.wikimedia.org/show_bug.cgi?id=35251 [13:04:32] [bugs] NEW [Bug 38225] Wikipedia App history view does not support titles/URLs that contain UTF-8 (priority: Unprioritized severity: normal) https://bugzilla.wikimedia.org/show_bug.cgi?id=38225 [13:31:32] [bugs] NEW [Bug 37222] Table borders are always shown (priority: Normal severity: enhancement) https://bugzilla.wikimedia.org/show_bug.cgi?id=37222 [16:48:52] thedj: hi? [16:49:07] thedj: can you look at https://bugzilla.wikimedia.org/show_bug.cgi?id=38225 when you can? thanks! :) [16:57:48] greetings all [16:57:59] y [16:58:01] awjr: you alive after your dentist ordeal ? [16:58:14] tfinc more or less [17:00:59] awjr: is the standup happening today? [17:01:13] tfinc: Well no one is here yet [17:01:16] yessssssssssssssss [17:01:26] tfinc: Jon won't be here Brion isn't here [17:01:56] tfinc: and Michelle isn't around yet either [17:01:59] tfinc: i was planning on it, but if no one else is around perhaps not [17:02:11] * preilly — votes that we delay it a bit [17:02:19] awjr: this is your shot call [17:03:02] tfinc, MaxSem, preilly let's try again at 1015 [17:03:10] awjr: okay [17:03:26] k [17:15:03] michelle just got in [17:15:48] second attempt? [17:15:59] yeah let's do it [17:21:38] * yuvipanda looks around [17:34:15] hey yuvipanda [17:34:26] we'll be seeing you soon [17:34:29] tfinc: indeed :) [17:34:56] tfinc: also, since you won't be around do you want to chat about mobile i18n before pune sometime? [17:35:11] yuvipanda: brion will be doing that with you [17:35:12] New review: awjrichards; "Can you recommend a way to test this?" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/30187 [17:35:13] i've already talked to him about it [17:35:26] whee [17:36:02] tfinc: ah, sweet [17:36:13] tfinc: also, we have night mode now :) [17:36:26] yuvipanda: great. when can we start testing ? [17:36:31] tfinc: as soon as the pull req is merged. [17:36:31] :) [17:36:56] tfinc: also, mind if I push out 1.3beta2 into 1.3 production? It's been tested long enough... [17:37:15] wouldn't need much of the team's time, I can stay up, comb through stuff on my own [17:37:35] yuvipanda: shoot mobile-tech an email so that everyone knows the timeline [17:37:46] tfinc: alright, shooting and upgrading! [17:37:58] yuvipanda: but i'm fine with you owning that. awjr do you want to account for it anywhere ? [17:38:27] * awjr reads backscroll [17:38:33] awjr: yuvipanda isn't a dedicated resource so i'm thinking we should keep this light weight and not bothering [17:38:45] tfinc what is this for? [17:38:49] awjr: android app release [17:38:56] promoting beta -> prod [17:38:56] oh roger that [17:39:27] tfinc: awjr sweet! [17:39:29] yuvipanda: feel free to rope in michelle to watch any app testing you do [17:39:42] i dont think so; i guess just on the app release page and any email anouncement/blog post/etc [17:39:49] tfinc ^ [17:39:58] yuvipanda: exciting stuff :) [17:40:05] yuvipanda: apps are priority number #2 so it won't be our primary focus. mobile web be. but its good for her to follow it [17:40:27] I understand [17:40:41] In a way perhaps it helps to think of it as competition :) [17:40:46] yuvipanda: bring it on [17:40:51] indeed [17:41:02] jon is already beating the app in terms of experience [17:41:03] ;) [17:41:25] up to you and brion to respond to the challenge [17:41:27] true, and I've to catch up. [17:41:40] we shall app away [17:41:41] i like competition like this [17:42:01] ok nexus 10 is built by samsung. 2560x1600 display. hell yes [17:42:23] I just bought a Nexus 7 for 317$, 16GB and wifi-only #FML [17:42:52] you cannot win dude [17:42:55] now there's a 3g nexus 7 too [17:42:57] indeed, but it was like 2 weeks ago [17:43:07] so it hurrtttss [17:43:22] brion: also, look at https://github.com/wikimedia/WikipediaMobile/pull/306? [17:43:39] brion: I'm also thinking of spending some time to port the thing to a native actionbar [17:43:51] yesssssssss me like [17:43:54] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30185 [17:43:59] what, night mode or native? [17:47:24] yuvipanda: https://github.com/yuvipanda/WikipediaMobile/commit/7dd0e7ae63a3ec138c537a31be937159ad206083 theme names should probably be localizable [17:48:19] brion: hmmm. How exactly would 'solarized dark' translate? [17:48:19] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30186 [17:48:33] brion: also, I'm unsure - the idea was for people to be able to create as many themes as they want... [17:48:40] and I dunno if that should be in twn [17:48:53] yuvipanda: like some sort of theme import system? hmm [17:48:57] that gets complicated :D [17:49:22] brion: the idea is eventually that once I get login, I can have an app variant of common.css :P [17:49:24] anyway i dunno about 'solarized' but 'light' and 'dark' are nicely translatable :) [17:50:01] are theme names translated in mediawiki? [17:50:10] I think, if yes, we should translate these too. Else not. [17:51:07] yuvipanda: yes they are [17:51:23] though in japanese they mostly look like transliterations :) [17:51:30] クラシック - classic :) [17:51:34] brion: also, did you see the list of changes that were merged yesterday? Search bar autohide, Mediawiki:mobile.css support, support for the latest Typography stuff and some misc fixes [17:51:38] ah, sweet. [17:51:44] ベクター - vector :) [17:51:44] i'll add them then [17:51:52] sweet. i'll check it out [17:52:13] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30288 [17:54:44] yuvipanda: any way you can make the section arrows light-on-dark in the dark theme? [17:54:55] oh, i missed that graphic [17:54:58] brion: I'll do that too [17:55:33] sweet [17:55:59] brion: there are a few problems with inline styles, butt I think it's preferable to leave them be and fix them in the content [17:56:08] yeah [17:56:08] this color scheme makes the problems a lot more obvious [17:56:09] than the default one [17:56:53] yeah. i see some issues with titles in info boxes and things [17:57:30] brion: essentially, anything that specifies a background-color but no color, or vice versa [17:58:29] hmmm. fedex claims my surface tablet is delivered… let's see where it's hiding :) [17:59:32] whoa where did article section editing come from in MF? [18:00:56] awjr: from the magic of jon [18:01:07] fancy [18:01:23] oh but the footer is broken in beta :( [18:02:06] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30298 [18:04:43] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30299 [18:09:59] [bugs] NEW [Bug 28515] Dynamic fonts support in mobile frontend extension (priority: Normal severity: enhancement) https://bugzilla.wikimedia.org/show_bug.cgi?id=28515 [18:10:00] [bugs] NEW [Bug 41412] Android section issues ( 2.2.2 2.3.4 and 2.3.5) (priority: High severity: major) https://bugzilla.wikimedia.org/show_bug.cgi?id=41412 [18:10:59] mornin jdlrobson [18:11:22] jdlrobson: i've been reviewing changesets and noticed that the footer is broken (no longer collapsible) in beta [18:11:33] morning [18:11:44] various android users are complaining about the new design [18:12:01] telling me i should revert back to the ugly one that works so guess I'll look into that today [18:12:08] but yes footer in beta is no longer collapsible [18:12:19] oh is that by design? [18:12:44] it's meant to be that way awjr https://mingle.corp.wikimedia.org/projects/mobile/cards/248 [18:13:09] unless i've misunderstood the poorly written story :) [18:13:51] i guess that's a question for Maryana, but i read that as just to remove the 'more'/'less' text but keep the carrot [18:14:00] i also notice the most common issue we have on the site is section toggling being broken [18:14:15] so it might be a good idea to leave it open since there are important links in there to desktop site [18:14:45] awjr: your interpretation also makes sens [18:14:46] "doesn’t need both the carrot and the more/less handle" i read as in doesn't need both those objects [18:14:59] ambiguous statement [18:15:02] yeah [18:15:07] Maryana: can you confirm ^? [18:15:21] sorry - no "more" but keep the carrot [18:15:45] it doesn't need both of those things, so let's just stick w/the arrow [18:16:28] brion: updated. [18:16:52] Maryana, jdlrobson: that is a good example of where writing out the steps of how to test the acceptance criteria is useful [18:17:17] erggh [18:17:44] my indian visa has been 'pending approval of the government of india' since 10/18 :( [18:18:00] awjr: :-S [18:18:06] can you ring [18:18:17] i am gonna try at lunch but i do not expect much to come of it [18:19:01] even when you're not there india has a way of keeping you on your toes [18:19:30] :) [18:24:33] awjr: can you push that story back to ready for development then? [18:24:46] i don't have permission [18:25:01] jdlrobson: done [18:27:02] awjr: can i also have permission to move stuff back [18:27:21] i have several stories in in development that i want to move back to in analysis [18:27:21] i used to be able to do this [18:27:50] i haven't changed the transitions for the stories, so i dont know why that would've changed [18:28:05] :/ [18:28:09] "Sorry, you cannot drag this card to lane Ready for Development. Please ensure there is a transition to allow this action and this card satisfies the requirements." [18:28:09] jdlrobson: for now can you ping product to move the stories? that way the change is also on their radar [18:28:35] awjr: it's just a lot easier if i can do it - i'll forget if i can't do it the moment i want to [18:28:49] i usually send an email but it doesn't get moved back [18:28:56] at moment I'm resorting to writing BLOCKED in title [18:28:57] jdlrobson: for now just tell product and i'll look into the transitions later [18:29:03] my Surface RT tablet arrived :D wikipedia app runs as expected so far [18:29:22] which card do you want to move, jdlrobson? [18:29:25] meanwhile windows phone 8 sdk comes out tomorrow [18:29:42] Maryana: can you please move stories 197 [18:29:43] 232 [18:30:19] are you blocked on design? we should be able to unblock you after today's design/eng meeting [18:30:52] yes Maryana [18:30:57] but can you move them back to in analyiss [18:31:03] ok [18:31:06] so we don't lose track of the fact that they are not in development currently [18:31:17] thanks Maryana [18:31:32] heh, well, don't speak too soon - let's see if mingle lets me [18:31:42] ah, there we go [18:31:55] cool i can finally replicate https://bugzilla.wikimedia.org/show_bug.cgi?id=41412 [18:32:30] if you go to a card and scroll to that tan-colored area, you should be able to change the status from there [18:32:39] i've had bad luck trying to drag things [18:47:23] jdlrobson: im looking at https://gerrit.wikimedia.org/r/#/c/30303/1 - cleanup templates in subsections do not appear to be reformatted like if they are in the main section; is that expected behavior? [18:48:43] jdlrobson: also took a quick look at transitions and added ones for in dev -> ready for dev and ready for dev -> ready for analysis; i thought i had added those a while ago but i guess not. [18:49:04] awjr: this is why it needs more analysis [18:49:11] the story was very confusing [18:49:32] oh sorry i misunderstood [18:49:49] i can't' think about that now [18:49:56] i'm in the middle of debugging these android issues [18:50:00] i want a fix by tomorrow [18:50:10] k no worries [18:50:13] just mark it -1 awjr if it looks strange [18:50:56] New review: awjrichards; "Cleanup templates in subsections are not getting reformatted as buttons (like a cleanup template in ..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/30303 [18:52:04] New patchset: Brion VIBBER; "First layer of mobile-friendly watchlist display." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29621 [18:52:32] [bugs] NEW [Bug 37281] Special:Search doesn't properly redirect on mobile devices (priority: Unprioritized severity: normal) https://bugzilla.wikimedia.org/show_bug.cgi?id=37281 [18:53:01] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30308 [18:53:38] ok card 150 is in 'ready for testing', and the initial watch list stuff is in a gerrit review waiting to be judged [18:56:55] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30351 [18:58:02] [bugs] NEW [Bug 41141] Meta-Wiki mobile site has errant trademark symbol (™) in footer (priority: Unprioritized severity: enhancement) https://bugzilla.wikimedia.org/show_bug.cgi?id=41141 [19:03:12] im on a surface tablet wheee [19:09:26] tfinc, awjr_lunch, MaxSem, jdlrobson, brion: http://staging.wmflabs.org/index.php/Main_Page [19:09:40] preilly: \o/ [19:09:41] free staging. hehe [19:09:45] :) [19:10:01] how close is staging to test. ? [19:10:04] do we want to get watch list in there or wait until next week? [19:10:19] preilly, what's the difference between this and mobile-testing? [19:10:23] tfinc: I'm installing varnish on it now [19:10:38] MaxSem: mobile-testing is dead [19:11:14] eh? [19:11:38] MaxSem: it was a victim of labs migration [19:12:22] MaxSem: I'm in the process of importing enwiki-20121001-pages-articles.xml into the new staging instance [19:12:36] preilly, sehr gut [19:13:12] but it worked last week, wtf [19:13:12] that will take some time :) [19:13:32] MaxSem: labs is a mess [19:13:46] brion: yeah [19:13:47] brion, it will start crawling much earlier [19:14:05] brion: but at least it has some test data already [19:14:15] preilly, on gluster? [19:14:44] MaxSem: yeah, I saved the project data [19:15:04] MaxSem: but MySQL isn't running off GlusterFS [19:15:28] yeah, I had to switch it to local storage cuz gluster was only pretending to work [19:15:42] hm [19:15:59] "Read this article?" [Try again] [Yes] "Intellectual growth should commence at birth and cease only at death" Albert Einstein [19:16:33] i'm not sure what my choices of "Try again" and "Yes" mean :) [19:17:31] ok so… either this is a weird error message, or random page has been changed to return a page title and einstein quote instead of loading the page [19:17:41] "try again" appears to give me another random page title [19:17:51] and "yes" actually loads the article... [19:18:18] what's the purpose of this? [19:20:42] [bugs] NEW [Bug 41502] Blank messages via Mobile Feedback should not be sent (priority: Unprioritized severity: normal) https://bugzilla.wikimedia.org/show_bug.cgi?id=41502 [19:22:10] filed as https://bugzilla.wikimedia.org/show_bug.cgi?id=41503 [19:23:36] MaxSem: everything is located in staging:/mnt/p [19:24:29] MaxSem: I've created a script in staging:/mnt/p/core/extensions named update-local-extensions.sh to update core and the installed extensions [19:25:02] aha [19:25:34] MaxSem: also these are symlinks: extensions -> /mnt/p/extensions, LocalSettings.php -> /mnt/p/LocalSettings.php, .htaccess -> /mnt/p/.htaccess [19:57:10] i am ready for this meeting anytime. just send me the hangout link. [19:59:55] be up there in a few [20:09:09] http://etherpad.wikimedia.org/MobileUX [20:09:14] etherpad ^ [20:09:30] brion: I'd want you to merge https://github.com/wikimedia/WikipediaMobile/pull/307 once your meeting is done :) [20:09:39] ok ping me then [20:09:42] brion: will do! [20:13:47] can we have some sort of discussion about reducing !important in MF and removing some of the overridden markup, now that we have Mobile.css ? [20:14:15] not now per se, but at some point, in coordination with the css gurus of en.wp or something. [20:18:54] perhaps move all 'site specific overrides' into a separate css module, and only load that if MediaWiki:Mobile.css == empty or something ? [20:20:04] thedj: that makes sense to me [20:20:11] thedj: you should talk to jdlrobson [20:20:26] New review: awjrichards; "Some whitespace issues and various PHP warnings/errors. Also, should we be consistent about generati..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/29621 [20:20:40] jdlrobson: ^^ that :D [20:20:43] thedj: i'd love the remove !important [20:22:10] thedj: the !importants are there due to inline styles [20:22:28] not all of them... [20:24:01] anyway, i just want to set up a strategy of some sort to tackle the mbox, navbox, infobox styling basically [20:26:33] https://mingle.corp.wikimedia.org/attachments/6fe669d5d4bfe7cc6790d84bd75ba672/152/Chrome-01.png [20:29:51] heh. the graphics on the board and the graphics in teh mingle cards do not match up. [20:29:54] hence my confusion. [20:30:29] thedj: +1. I just added a dark theme to the wiki app, and that makes the inline style problems a lot more obvious [20:32:43] there is a lot we can do there, even before adding 'page' specific css as discussed. [20:33:11] just adding a few classes that could be reused for general / very common styling would go a big way [20:33:47] tfinc: what is Michelle's nick on IRC? [20:33:52] jcmish --^ [20:34:10] yuvipanda: some lists if problematic issues would also go a long way btw. [20:34:32] tfinc: thanks [20:34:36] thedj: looking at where !important is being used would be a good start, I think [20:34:51] now it's all hidden. perhaps we can add a temp flag to exclude all the overrides, so that is is easier to figure out where we need to fix things [20:35:01] jcmish: you can now use http://staging.wmflabs.org/wiki/A_Clockwork_Orange for testing [20:36:13] yuvipanda: yeah but all the importants on 'table' for instance are all there for very low level overrides, yet blocking proper styling of some high level tables now.... [20:36:14] jcmish: it is still importing data but is basically useable at this point [20:36:19] sort of a chicken egg problem :D [20:36:27] thed: heh. [20:36:44] thedj: should be simple enough - we just have to exclude mf-hacks.css [20:37:18] I could make a one-off version of the app that does it, and can work on this. Unusre if/when jdlrobson can get to this? [20:38:40] i would not have a problem with sorting out some of the site vs. en.wp styling overrides into seperate files, but i don't really understand the stylesheets dir anymore of MF [20:38:44] there is so much there. [20:39:32] is /devices still used for instance ? [20:39:35] heh [20:39:51] and less vs. common.... [20:41:12] heh, I think jdlrobson will have to answer you on that thedj [20:43:27] table.gallery ? [20:43:37] those are divs these days :D [20:45:01] hey what's up [20:45:46] thedj: basically if there are any rules in mf-common.css and mf-hacks.css that could be done in Mobile.css, write them in Mobile.css and raise a bug for them to be removed [20:46:02] What about Mobile.css for other wikis theN? [20:46:15] yuvipanda: this is why I'm not a big fan of Mobile.css [20:46:53] could we imagine making Mobile.css for all projects pulling from a gerrit repository [20:47:25] 'pulling from a gerrit repo'? i'm confused [20:49:03] well my main issues with Mobile.css are 1) it encourages cargo cult programming 2) projects have their own one despite using the same templates so you get inconsistencies in styling between projects 3) mediawiki currently doesn't have a git blame type feature so you cannot query the reasons certain css rules got introduced 4) being able to edit on a wiki encourages bad testing 5) there is no code review step - changes go live straight away an [20:49:03] certain css rules can cause serious performance problems on certain browsers [20:49:38] so if you had a gerrit or git project which had Mobile.css in it you could manage all the above [20:50:03] you could have an automatic deployment to the wiki page say every Monday [20:50:22] the problem is that we have no such thing as 'wikipedia' skins that all wikipedia's use [20:51:12] there has been talk of moving some parts of at least infobox into core. but navbox for instance is rather 'wikipedia' specific [20:51:26] brion: please poke me when the meeting is over :) Thanks! [20:51:43] yuvipanda: gimme a few minutes to go over some feedback from awjr on this patch then i'll look :) [20:51:50] brion: thanks! [20:52:11] [bugs] RESOLVED [Bug 31675] Port MobileFrontend to use ResourceLoader for JS and CSS (priority: Unprioritized severity: enhancement) https://bugzilla.wikimedia.org/show_bug.cgi?id=31675 [20:53:03] jdlrobson, "despite using the same templates" [20:53:09] naive boy:D [20:53:29] hah [20:53:55] hehe [20:54:08] I wonder if the site specific cargo cult CSS / Template copy pasting is a genie that can not be put back... [20:55:02] and who says that every wiki wants the same styling? [20:55:05] well it can to some degree, but it will be INCREDIBLY slow. it's like saying "Linux, just pick a windowmanager already" [20:55:18] "community: agree on some templates" [20:55:30] they don't need to [20:55:52] jdlrobson: if you want to, should be possible to build a dashboard of sorts that brings you latest changes to Mobile.css across projects :D [20:56:00] when I look at French or Italian WPs, my eyes are hurt from all these colors [20:56:06] but that's their choice [20:56:14] and we can engage in some sort of svn-style post-commit review [20:56:20] you can't force everyone to do what you say [20:57:12] New review: Brion VIBBER; "various little things fixed in patchset 2." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/29621 [20:57:26] [bugs] NEW [Bug 41509] mf-common has table.gallery, but gallery is a div these days. (priority: Unprioritized severity: normal) https://bugzilla.wikimedia.org/show_bug.cgi?id=41509 [20:57:49] MaxSem: yuvipanda thedj : sorry i really can't have this conversation right this minute but I really believe we have a larger problem here which is editors have to resort to Mobile.css and inline styles to style project specific content. Both of which are terrible ways of doing it as they don't involve any review step. I would welcome any system which 1) makes these changes more transparent 2) allows more discussion around changes and 3) dri [20:57:50] style consistency between pages (due to inline styles there are not even consistencies across wikipedia for example) [20:58:28] it's a wiki, no reviews are possible nor needed [20:59:05] you'll have to get used to users being allowed to do insane things, it's by design [20:59:26] yuvipanda: ok what am i looking at? [21:00:24] okay, 1 hour before deployment - how are we looking [21:00:25] ? [21:00:42] tfinc: are we going to do a triage list for devcamp similar to http://etherpad.wikimedia.org/wmbangalore-bugs [21:01:02] ? [21:01:19] yuvipanda_: sure. i haven't had the time to build it. feel free to add mobile bugs to that [21:02:02] brion: at https://github.com/wikimedia/WikipediaMobile/pull/307 [21:02:45] brion: found (yet another!) saved pages bug when doing testing, and turned out to be another bug caused by a (seemingly innocuous) PhoneGap code change. Fix is a hack to cordova.js [21:02:52] funnn [21:02:58] brion: might also fix the 'saved pages do not show up intermittently!' bug [21:03:34] brion: Next thing I'm going to do once I release 1.3 is to rewrite entire saved pages to be all Java. I don't think we've done one release where a single saved pages related bug did not crop up [21:03:39] heh '+ throw "You upgraded cordova but forgot to add back / fix the websql shim!";' [21:04:00] brion: indeed, it's a hack to remind us that there is a hack :) [21:04:01] yuvipanda: does this need fixing upstream? [21:04:30] brion: I'm unsure. The problem was that PhoneGap < 1.4 was less specific about when it used the shim, while later versions were more specific [21:04:41] so the newer code is technically more 'correct', but of course incompatible [21:04:51] bleah [21:05:19] so I don't really know a clean solution to this that does not involve us doing hacky stuff [21:05:41] will forcing use of the shim break stuff for people who were getting the webkit version before? [21:06:03] brion: the only people who were getting that were 1.3 beta users - and I think it's okay for stuff for them to break [21:06:32] ok [21:07:00] brion: but yes, it is possible - I think. But in my testing (2.3 emu, 4.1 devices) that seems to be not the case (1.4 always uses shim, 1.4+ mostly uses webkit except when it doesn't) [21:07:14] the difference in code was how they were detecting when to use shim vs webkiot [21:07:34] <1.4 they were simply checking if an exception was thrown at one point. Later they started checking for an error code in the exception too. More specific. [21:08:01] * brion files note for later: "never use websql, it will explode someway, somehow" [21:08:40] brion: any opposition to me moving Saved Pages to full native code? (for next release, of course!) [21:09:14] can someone still tell me the diff between less and common btw ? [21:09:26] I have waaay too many branches that begin with 'saved-pages' or 'fix-saved-pages' [21:09:43] yuvipanda: please do [21:09:59] brion: thank you! Now it would be awesome if you could merge that :) [21:10:07] :) [21:10:22] thedj: I think the .less files generate the .css files [21:10:43] oh crap. [21:11:06] then i just edited all the wrong files :D [21:11:15] you did! [21:11:22] we should put a warning there somewhere, unsure where [21:12:28] we might consider putting the .less files in the same dirs as the .css files [21:12:37] rather than a separate tree [21:13:07] perhaps a DONOTEDIT.txt file in the css folders? :) [21:14:00] the thing probably has an option to add a header automatically [21:16:43] oh great, more package managers [21:19:29] [WikipediaMobile] brion pushed 2 new commits to master: http://git.io/h7QYuQ [21:19:29] WikipediaMobile/master 11ba8aa YuviPanda: Fix Saved Pages *again*... [21:19:29] WikipediaMobile/master 05c411c Brion Vibber: Merge pull request #307 from yuvipanda/fix-saved-pages-for-the-goddamn-nth-time-again... [21:19:37] Project WikipediaMobile - Nightly builds build #438: SUCCESS in 9.7 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/438/ [21:19:37] yuvipanda: Fix Saved Pages *again* [21:20:57] brion: thamls! [21:20:57]