[00:55:17] preilly, around? [00:56:35] preilly, 1) image permissions issue: try visiting a random page [00:56:54] 2) with InstantCommons, import will take forever [01:35:51] Description Resource Path Location Type [01:35:51] error: Error: No resource found that matches the given name (at 'resource' with value '@xml/searchable_location'). AndroidManifest.xml /Wikipedia/bin line 48 Android AAPT Problem [01:50:45] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30718 [07:57:18] [WikipediaMobile] yuvipanda created v1.3-Android (+3 new commits): http://git.io/H8euZA [07:57:18] WikipediaMobile/v1.3-Android 178a722 YuviPanda: Bumped Android version number [07:57:18] WikipediaMobile/v1.3-Android cb4ec5a YuviPanda: Fix Saved Pages *again*... [07:57:18] WikipediaMobile/v1.3-Android c7bd8ab YuviPanda: Update CHANGELOG [07:57:29] Project WikipediaMobile - Nightly builds build #441: SUCCESS in 10 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/441/ [08:02:25] [WikipediaMobile] yuvipanda pushed 1 new commit to master: http://git.io/O_kemw [08:02:25] WikipediaMobile/master 02742c8 YuviPanda: Bumped version number and updated CHANGELOG [08:02:36] Project WikipediaMobile - Nightly builds build #442: SUCCESS in 9.9 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/442/ [08:02:36] yuvipanda: Bumped version number and updated CHANGELOG [08:04:29] [WikipediaMobile] yuvipanda force-pushed beta from a02fa2d to b7f117f: http://git.io/UAGDHg [08:04:29] WikipediaMobile/beta b7f117f YuviPanda: Apply transformations to make the app into 'Beta'... [08:04:37] Project WikipediaMobile - Nightly builds build #443: SUCCESS in 10 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/443/ [08:04:37] * s.mazeland: Localisation updates from http://translatewiki.net. [08:04:38] * yuvipanda: Upgraded to support latest master from MobileFrontend [08:04:38] * yuvipanda: Load site-specific mobile CSS [08:04:39] * yuvipanda: Add appropriate classes to the body, as with MobileFrontent [08:04:43] * yuvipanda: (Bug 38001) Remove limit of 50 saved pages from Wikipedia app [08:04:43] * yuvipanda: (Bug 39048) Make page language dir not affect footer direction [08:04:43] * yuvipanda: (Bug 38912) Fix directionality for text in map bubbles [08:04:43] * yuvipanda: Upgrade to leaflet 4.5. [08:04:43] * yuvipanda: Upgraded to jQuery 1.8.2 [08:04:43] * yuvipanda: (Bug 33881) Autohide the search bar [08:04:43] * yuvipanda: Remove useless 'redirects' parameter being sent to API [08:04:43] * yuvipanda: Do not display title on the main page [08:04:43] * yuvipanda: Add support for multiple content themes [08:04:44] * yuvipanda: Added a Theme based on Solarized Dark [08:04:44] * yuvipanda: Update reference reveal to support dark theme [08:04:45] * yuvipanda: Make Theme names translateable [08:04:46] * yuvipanda: Added dark-theme assets for expand/collapse buttons [11:44:05] [bugs] NEW [Bug 41539] Show more results doesn't actually show more results (priority: Unprioritized severity: normal) https://bugzilla.wikimedia.org/show_bug.cgi?id=41539 [12:42:58] [bugs] NEW [Bug 41543] Missing indentation for lists (priority: Unprioritized severity: normal) https://bugzilla.wikimedia.org/show_bug.cgi?id=41543 [13:43:08] [bugs] NEW [Bug 41546] api of mobile view outputs section headers with HTML differently then normal view (priority: Unprioritized severity: normal) https://bugzilla.wikimedia.org/show_bug.cgi?id=41546 [14:01:38] [bugs] NEW [Bug 41547] Unable to input Japanese text (priority: Unprioritized severity: normal) https://bugzilla.wikimedia.org/show_bug.cgi?id=41547 [14:03:47] [bugs] NEW [Bug 34201] Words in place names in an RTL script appear in the wrong order on the maps (priority: Low severity: normal) https://bugzilla.wikimedia.org/show_bug.cgi?id=34201 [14:31:28] New patchset: TheDJ; "(bug 34878) Don't override columncount with auto, instead set width" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30782 [14:36:51] New review: Jdlrobson; "do not remove any !important statements. these are written to deal with inline styles. This particu..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/30782 [14:41:31] New review: TheDJ; "Like I said, the behavior of column-width takes precedence over that of column count. And since the ..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/30782 [15:41:45] [bugs] NEW [Bug 41554] Language links in "Read in other language" miss lang attribute (priority: Unprioritized severity: normal) https://bugzilla.wikimedia.org/show_bug.cgi?id=41554 [16:22:57] [bugs] NEW [Bug 41547] Unable to input Japanese text (priority: Unprioritized severity: normal) https://bugzilla.wikimedia.org/show_bug.cgi?id=41547 [16:49:29] MaxSem: the permissions are fixed on /mnt/p/core/images [16:49:42] cool, thanks [17:30:00] no jdlrobson today? [17:36:23] MaxSem: he may be hiding out or in a mtg [17:36:30] he's usually pretty good about emailing if he's late or out [17:38:32] New review: Jdlrobson; "Sorry I reviewed this on the bus." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/30782 [17:39:07] ^ lol [17:40:32] New patchset: Jdlrobson; "update comment on mf-hacks.less/css now we have mf-enwp.css" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30805 [17:47:10] greetings all [17:47:32] yuvipanda: how is the android app rollout looking ? [17:47:39] tfinc: pretty good! [17:47:54] positive reviews from everyone except for some people with a specific japanese keyboard [17:48:09] mobile-feedback-l has had some traffic too, which I've responded to [17:48:13] does the text not enter at all or does it not trigger search events? [17:48:33] brion: I'm unable to say from the google translate provided translations [17:48:38] bah [17:48:38] but I think they mean the text doesn't enter at all [17:48:42] hate it when we can't repro [17:48:52] however, I also have reviewers saying 'no problems with entering japanese' [17:48:52] New patchset: Jdlrobson; "only run getToken ajax request if user authenticated" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30806 [17:49:08] yuvipanda: what phone/build are they showing up on? [17:49:10] play market has all those [17:49:23] tfinc: yeah, nothing consistent there either [17:49:43] i see a GNexus, a S2, a S3, a SE, an XPeria, a SHARP phone... [17:49:50] yuvipanda: http://www.mediawiki.org/wiki/Mobile/Release_history is still not up to date [17:50:19] was trying out different keyboards, will do now [17:50:26] apologies about the slip! [17:51:32] done [17:51:32] yuvipanda: the longer we wait to update it the harder it is to remember what happened for the next release manager [17:52:00] ooh, i wasn't logged in. let me do it again [17:52:07] tfinc: why should it be, actually? CHANGELOG is preetty well maintained [17:52:16] this just duplicates that. [17:52:29] MaxSem: can we fix the use of wfSetupSession in MobileContext [17:52:53] I understand the md5 and download links and release dates, but I don't think CHANGELOG belongs here [17:52:59] MaxSem: and getSessionData as well [17:53:51] preilly, that's what I wanted to see jdlrobsobn for - in principle, as we don't show these links in the footer any more, we should be able to forget about these tokens at all [17:54:21] yuvipanda: i bet i added that as WLM app didn't have a change log [17:54:41] tfinc: heh. I linked to the CHANGELOG from the page for wikipedia [17:55:12] tfinc: did you try out the beta? [17:55:19] not yet [17:55:34] Reviews have started coming on faster now that the US has woken up. It's either 5 stars or a complaint about tables or zoom. [17:55:43] tfinc: also, do you know that we can reply to reviews? [17:55:57] MaxSem: Okay well let's remove them [17:56:12] yuvipanda: yes. i worked with Erik to get that added [17:56:18] ah, wonderful! [17:56:19] thanks! [17:56:43] brion: do you write japanese? Can you tell me how exactly I can ask them 'what keyboard are you using'? [17:56:45] yuvipanda: but i couldn't figure out if its just responding on the reviews page or if it actually messages the user [17:56:57] tfinc: it says it does both [17:57:02] i know a few words but not well enough to translate or ask :D [17:57:12] ah, okay [17:57:27] i could maybe just ask in English - or wait for someone to send a japanese email to mobile-feedback-l [17:58:18] yuvipanda: google translate tells me "あなたは、キーボードの種類を使用していますか?" which actually makes sense to me in japanese [17:58:44] tfinc: wah, you know Japanese? [17:59:05] ときどき [17:59:15] * yuvipanda feels culturally poor [17:59:44] i studied japanese in high school (for fun) and academically in university for two years [18:00:00] tfinc: i'm testing with a friend to see what exactly responding to a review does [18:00:00] yuvipanda: its a fun language. reading is pretty easy. i couldn't remember the grammar to save my life [18:00:29] heh [18:00:44] I sadly did not pay much attention to any non-programming languages, including my mother tongue [18:00:45] oh well [18:01:13] yuvipanda: do you have interest in others? [18:01:48] well, I'd first want to learn my own mothertongue properly. And then Hindi. Outside of that I've been wanting to learn German ever since Berlin [18:02:30] yuvipanda: that'll keep you busy for a while [18:02:33] tfinc: how many do you know? [18:02:48] i keep english, polish, spanish, and japanese in my head [18:02:54] true, but currently it is only Java. [18:03:01] the latter two mix with each other pretty badly [18:03:09] hah [18:03:32] so i can understand some basics but don't ask me to speak them as it'll sound like a combination of the two [18:03:40] :D [18:04:13] tfinc: so, 'replying' on reviews actually sends people an email [18:04:22] tfinc: I just got access to one, forwarded that to you [18:04:28] a potentially bad thing would be that it tells people to contact *you* :P [18:04:37] and gives your @wikimedia.org address [18:05:06] tfinc: do you want me to change that to mobile-feedback-list? [18:05:13] yes pleas [18:05:13] e [18:06:54] MaxSem: is it possible to disable Mobile.css I'm getting worried by some of the changes going in there [18:07:09] jdlrobson: you realize you could edit Mobile.css too, right? [18:07:19] I can't [18:07:19] it's admin only [18:07:20] ask for the staff flag [18:07:24] then you can [18:07:35] who do I ask for that from? [18:07:40] i'm unsure, tfinc? [18:07:56] Philippe [18:08:04] Philippe [18:08:07] however, you should be very tactful when doing something from your staff account [18:08:50] avoid even remote possibility of "OMG the foundation is forcing their crap upon us" reaction [18:09:35] jdlrobson, am I right that we can remove all the vestiges of mobile token stuff now? [18:10:16] MaxSem: I'm okay with changes - I just don't like changes added which are not discussed [18:10:25] that's why I like a code review system like gerrit [18:11:02] yuvipanda: play just pushed me the app udpate [18:11:24] tfinc: beta or stable? [18:11:31] stable [18:11:36] ah, sweet [18:11:50] try out beta also. It has a dark mode! [18:11:53] jdlrobson, just bear in mind that it's not _your_ site [18:12:13] and beta just came in. trying it now [18:12:14] except it's based off the 'solarized' color scheme, which is… okay. [18:12:32] tfinc: also the search bar autohides [18:12:34] jdlrobson, so what about mobile tokens? [18:12:36] tfinc: also new typography :) [18:13:11] yuvipanda: we'll need a new icon/color for the arrow as i can't see anything in solarized view [18:13:25] tfinc: yup, bug. [18:13:31] tfinc: plus you'll run into tables that are unreadable fast. [18:13:41] (inline styles) [18:13:41] yup [18:13:57] MaxSem: I'm not saying its _my_ site I'm saying that Mobile.css is a stupid thing as it has no review system - you change things there and it goes live automatically. [18:14:00] it's fucking dumb [18:14:02] this makes it *much* more obvious than the the normal theme. [18:14:11] jdlrobson: that's pretty much all of wikipedia :) [18:14:25] MaxSem: talk to preilly about the mobile tokens stuff I forget why it's there [18:14:25] jdlrobson, it's a https://en.wikipedia.org/wiki/Wiki [18:14:29] yuvipanda: no but edits to wikipedia articles are different [18:14:34] this is code [18:14:43] jdlrobson: common.css and common.js is code too. [18:14:55] yes and those are equally fucked mechanism [18:14:55] jdlrobson: it's there for CSRF protection [18:15:20] no, they are ways not to depend on us developers which is fucking great [18:15:25] better than code waiting for review for ages, no? [18:15:39] MaxSem: yuvipanda well that's an issue with code review isn't it [18:16:23] jdlrobson: it will always be an issue with code review. There'll always be less number of devs than admins, and devs will always have more Important(™) stuff to do than CR a color change [18:17:24] if a change to Mobile.css breaks the site, we/someone fixes it. {{SOFIXIT}} :) [18:17:26] yuvipanda: are we finding versions under https://bugzilla.wikimedia.org/enter_bug.cgi?product=Wikipedia%20App useful ? because if so i need to add new ones [18:17:38] jdlrobson: please avoid cursing in a public channel [18:17:42] tfinc: i'm not, really. Getting rid of them would be completely fine by me [18:18:43] arrrrrr [18:19:09] windows phone 8 sdk is 64-bit only, but my win8 virtual machine is 32-bit [18:19:10] brion: IIRC it also requires you to have Hyper-V capable machine to run it? [18:19:24] yeah i'm not sure whether the emu will work in the virt [18:19:40] CAN NOT GO DEEPER? :) [18:19:42] WINCEPTION [18:19:55] WINception sounds like a good thing.. [18:20:10] ok i'll…. try it on this other tablet that's running 64-bit before i go reinstalling my VMs [18:20:50] tfinc: I changed it to mobile-feedback-l. [18:20:56] [bugs] NEW [Bug 41562] Can't see expand arrow in night mode using Wikipedia Beta 1.4beta1 (priority: Unprioritized severity: normal) https://bugzilla.wikimedia.org/show_bug.cgi?id=41562 [18:26:23] New patchset: Jdlrobson; "introduce styling for code pre tags" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30811 [18:28:27] tfinc: do we have a Galaxy S / SII in the house? [18:28:28] bbiab [18:28:33] yuvipanda: we do [18:28:39] S or SII? [18:28:42] SII [18:28:45] and SIII [18:28:48] can you test out the Samsung Keyboard when you have the time? [18:28:53] on all of them? [18:29:23] also, can you bring the SIII to DevCamp? The camera would be incredible to put stuff on Commons with the app :D [18:29:55] yuvipanda: sure. shoot me an email of the phones you want me to bring [18:30:07] tfinc: where is the list of phones we have? [18:30:21] yuvipanda: the same place its always been. on office wiki [18:30:28] hmm, let me go dig up my password [18:30:36] i'll shoot you an email [18:30:43] tfinc: do you think you can test out those keyboards for me sometime today? [18:30:58] works fine on all the devices I have + the emulator [18:31:06] i'm charging the SII now [18:31:09] awesome [18:31:15] yuvipanda: this would be far easier if you were in the office [18:31:35] i wish. Soon enough, I hope :) [18:31:51] am i testing production or beta? [18:31:54] production [18:32:59] use the default samsung keyboard [18:35:29] k, its charging now [18:35:36] super [18:36:04] New patchset: MaxSem; "Kill most of the mobile token stuff" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30812 [18:36:15] jdlrobson, preilly ^^^ [18:36:23] tfinc: I also have a friend coming to devcamp - he's one of the maintainers of PulseAudio, works for Collabra. He wants to help us integrate an encoder into the Comomons app, so we can upload ogg video / audio :D should be fun! [18:36:36] yuvipanda: fun [18:37:03] also another couple of android hackers coming in from the local hacker scene. [18:37:08] very much looking forward to it! [18:39:03] MaxSem: looks good if jdlrobson adds a +1 to the javascript I'll +2 it [18:40:57] preilly: done [18:40:59] * yuvipanda notes that there's also a storm coming this way, so if I go offline... [18:41:41] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30812 [18:45:24] yuvipanda: can your friend help me get pulse audio and projectm set up on my macbook? [18:45:26] MaxSem: ^^ [18:45:38] whee, thanks [18:45:50] i tried one evening and failed miserably :( [18:47:06] jdlrobson: http://www.mediawiki.org/wiki/Mobile/Release_history needs an update since i know editing is going out today [18:47:17] preilly, there's another session-related change waiting for review: https://gerrit.wikimedia.org/r/#/c/30806/ [18:47:35] tfinc: I thought jcmish was doing an ether pad (jon getting confused) [18:47:52] jcmish: why duplicate what we already have ? [18:48:00] it's there tfinc under editing first pass [18:48:15] jdlrobson: it has no date attached [18:48:20] awjr: he definitely can :) [18:48:21] yes because it hasn't gone live yet tfinc :) [18:48:35] but anything TBC can be read as next deployment [18:48:47] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30806 [18:48:49] jdlrobson: then put in a note about TBC [18:49:02] sure [18:49:02] that'll make it really easy [18:49:02] awjr: he's currently working on getting pulseaudio to android - and if he can do android, I'm pretty sure he can do OS X :) [18:49:03] MaxSem: merged [18:49:35] great, now I actually feel like I can deploy today:) [18:50:24] yuvipanda: sweet! [18:50:25] Why do you want PulseAudio? [18:50:44] preilly: to play nicely with projectM [18:51:06] yuvipanda: are you good on your Delhi flight? [18:51:14] awjr: you want a pretty visualizer? [18:51:31] jdlrobson: just booking. earliest I get is 6AM the next day, sadly. But that's okay. [18:51:43] preilly: yes; i've used it on linux boxes for years but would like to run it on os x as well [18:52:00] awjr: are you not happy with the iTunes visualizer? [18:52:01] yuvipanda: no issue typing in english on the default keyboard on the SII [18:52:26] awjr: actually, one of the other 'local android hackers' I mentioned uses projectM on his macbook, so I think he should be able to help too (I'll confirm in a bit) [18:52:35] sweet [18:52:40] thanks yuvipanda :) [18:52:54] preilly: http://i.imgur.com/Z8FEh.jpg :) [18:52:55] awjr: tech support from India, eh? :P [18:53:01] preilly: no, i almost never use iTunes and i want to be able to visualize arbitrary audio playback [18:53:10] yuvipanda: hehe yes, but this time i'll be there too :p [18:53:18] yuvipanda: you going to sleep at the airport, not sleep or grab a room for the night? [18:53:23] as long as i get my visa... [18:53:28] jdlrobson: pretty much, yeah. [18:53:37] awjr: http://revoloco.com/wp-content/uploads/2012/09/562022_10151137570345818_428981050_n.jpg [18:53:47] well, or I might just head to the Wiki India offices and see how things are and crash there too [18:53:52] which option yuvipanda ? [18:53:53] good plan :) [18:53:59] jdlrobson: lol [18:54:01] jdlrobson: sleep at airport mostly, if I can't get to wiki india offfices [18:54:15] jdlrobson: I hate early morning flights, since I most definitely can't wake up that early. [18:54:20] hmm, maybe i could just get a later one [18:54:24] and have an extra day in Delhi [18:54:24] awjr: did you try https://github.com/togi/projectm-standalone-osx [18:54:52] preilly: i did; i couldn't get it to work for some reason (maybe i had too many gin and tonics…) [18:55:44] yuvipanda: i hear you [18:55:53] [bugs] NEW [Bug 41333] MobileFrontend extension loads JavaScript twice, has weird errors when database error occurs in job queue (priority: Unprioritized severity: normal) https://bugzilla.wikimedia.org/show_bug.cgi?id=41333 [18:55:53] oh preilly iirc it didn't play nice with lion [18:56:29] jdlrobson: that moustache thing goes both ways. Remember the picture of me with a moustache in my ID card? [18:58:48] yuvipanda: please grow it back [18:59:30] jdlrobson: would you like to grab some food before the tech brown bag? [18:59:46] tfinc: ough. Do we have any HTC One's? [19:00:03] yuvipanda: why don't you check our device list to find out [19:00:04] * yuvipanda hates unreproducible bugs [19:00:13] ah, right. [19:00:44] preilly: love to [19:00:57] jdlrobson: okay the meeting starts at 12:30 [19:01:05] jdlrobson: let's head out now'ish [19:02:10] tfinc: are you sure that's complete? https://office.wikimedia.org/wiki/Engineering/Mobile/Testing_Devices doesn't list any SIIIs [19:02:16] but no, I see no HTCs, sadly. [19:02:39] added [19:02:53] jdlrobson: add the new phone we got yesterday to the list [19:04:11] we got an HTC Wildfire S A510e in yesterday [19:04:17] and we'll have an HTC Explorer A310E arriving later this week [19:04:48] yuvipanda: --^ [19:05:04] ah, sweet. [19:05:47] the devices this appears in seems very weird. Just got a report of it in a GNote [19:07:16] jcmish: http://www.specialtys.com/ [19:07:20] tfinc: I'm sending the japanese you gave me to the people giving reviews in japanese. [19:07:34] yuvipanda: lets see how badly we insult them :) [19:07:47] yuvipanda: you can also reach out to kul for help with this [19:08:21] ah, right [19:08:22] let me email him [19:11:38] [bugs] NEW [Bug 34293] Android app should allow pinch and zoom (priority: High severity: enhancement) https://bugzilla.wikimedia.org/show_bug.cgi?id=34293 [19:35:15] Maryana: [19:35:16] https://mingle.corp.wikimedia.org/projects/mobile/cards/grid?color_by=type&filters%5B%5D=%5BType%5D%5Bis%5D%5BStory%5D&filters%5B%5D=%5BType%5D%5Bis%5D%5BTask%5D&filters%5B%5D=%5BType%5D%5Bis%5D%5BBug%5D&filters%5B%5D=%5BIteration%5D%5Bis%5D%5B%28Current+Iteration%29%5D&group_by%5Blane%5D=status&lanes=Ready+for+Analysis%2CIn+Analysis%2CReady+for+Development%2CIn+Development%2CReady+for+Testing%2CIn+Testing%2CReady+for+Signoff%2CAccepted&tab=S [19:35:17] +Wall doesn't seem up to date.. [19:35:47] jdlrobson: ? [19:36:04] 232 and 197 are ready for development no? [19:36:43] although https://mingle.corp.wikimedia.org/projects/mobile/cards/232 needs the graphic attached showing the overlay [19:36:43] which I know exists [19:37:00] (by overlay i mean the references style popup) [19:37:00] yes! [19:37:06] i thought i added that in. maybe i attached it to a different card [19:37:10] 1 sec... [19:37:37] yuvipanda: https://mingle.corp.wikimedia.org/projects/mobile/cards/195 is done yes? [19:38:15] also Maryana https://mingle.corp.wikimedia.org/projects/mobile/cards/235 [19:39:33] move 235 or add design assets? or both? :) [19:39:54] just moved watchlist (w/added overlay images) and cleanup templates into ready for dev [19:45:39] 235 both :) [19:45:46] perfect [19:46:23] jdlrobson / preilly: https://github.com/atdt/gerrit-stream [19:47:14] cheers ori-l_ will take a look in 20% [19:47:18] could be a good way to highlight code review better? [19:47:48] just pushed a fix [19:47:54] 15 seconds after initial commit, a record even for me [19:49:20] jdlrobson - just added a bunch of vibha's stuff to #235 - let me know if anything's still not clear [19:49:51] New patchset: TheDJ; "(bug 34878) Don't override columncount with auto, instead set width" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30782 [19:50:51] awjr_lunch: i just realized I'm double booked for 1-2 [19:50:53] i can't cancel the other meeting [19:54:27] tfinc: ok - i think it's probably ok if you're not in th deployment process discussion unless you really want to be [19:55:45] New patchset: Jdlrobson; "(bug 34878) Don't override columncount with auto, instead set width" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30782 [19:56:54] Change merged: preilly; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30805 [19:58:00] New review: Jdlrobson; "Could you rebase TheDJ ?" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/30782 [19:58:31] i guess this means i'm projecting the hangout :) [20:02:37] jcmish: https://plus.google.com/hangouts/_/41fc0a74cbdcd9562cba5f68159f815c7d9ae1ca [20:02:41] oh wait… you're in sf [20:03:13] i have to log out/in, camera's broke again :P [20:03:45] jdlrobson: yes, it has been done [20:04:27] jdlrobson: nice hat [20:04:43] jdlrobson: deployment meeting! [20:06:00] jdlrobson, preilly - you guys wanna join us in r31 for a meeting to talk about deployment? [20:06:21] preilly: looks like you were not on the calendar invite, but welcome to join ify ou like [20:07:09] Maryana: i'm in the tech talk at the moment [20:07:12] didn't realize they overlapped [20:07:21] on 6 [20:09:23] Maryana: awjr you desperately need me there now or is ok if i turn up a little later? [20:10:21] jdlrobson: the tech talk is being recorded. if you have any input in deployment process, you should be in this meeting. [20:12:35] ok i'll come along in 5… just enjoying the conversations here [20:58:23] ahhh... a quiet hour in this channel:) [20:59:45] :P [20:59:57] I think maybe everyone is recovering from the hangout meeting? [21:01:10] mmm, hangover meeting:) [21:01:21] oh, you wrote hangout [21:01:25] how boring [21:07:07] New patchset: saper; "(bug 34878) Don't override columncount with auto, instead set width" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30782 [21:07:20] any shell script gurus around? [21:08:02] so I can do if grep -xqe ... ; then ... [21:08:31] but how do I do if not grep -xqe ... ; then [21:08:54] other than if ... ; then ; else ... [21:08:54] grep -v will do negative matching [21:09:19] if that's what you're looking for, MaxSem ^ [21:10:03] (by negative matching i mean it will select lines that do not match the pattern you give it) [21:12:30] no, I need to invert the condition, not check if there are lines without that expression [21:14:23] wouldn't something like if ( !grep -xqe ) be the same as if ( grep -xqev )? [21:15:07] i think in bash you can do if [ ! ] [21:15:47] MaxSem: http://tldp.org/LDP/Bash-Beginners-Guide/html/sect_07_01.html [21:16:29] yeah, but test (for which [] is a shortcut) doesn't understand [ ! grep ... ] [21:17:13] MaxSem: what are you trying to do? [21:17:40] check if a file doesn't contain a line [21:18:30] grep -L will output files that match your expression [21:18:47] er wait i got it backwards [21:18:47] * awjr checks man [21:19:20] grep -l prints files that contain matching lines grep -L prints names of files that do not have matches [21:21:27] point being you could make a list of matching or non-matching files and wrap it in a for statement [21:23:57] MaxSem: also just noticed in the man file for grep, grep retunrs exit status of 0 if there are matches, and 1 otherwise, so you could also easily test exit status [21:24:13] I'm already testing it [21:24:35] lol, the solution was to do it without the [] [21:25:03] Visual Basic is actually nice if compared to this [21:25:36] heh yeah i find bash scripting can be a quagmire... [21:33:46] lol, I've discovered that our puppet does not support the feature I rely on [21:55:33] today's changes: https://www.mediawiki.org/wiki/Extension:MobileFrontend/Deployments/2012-10-31 [21:58:26] isn't today 10-30? [21:58:29] oh right you're in the future [22:01:15] New patchset: Jdlrobson; "turn all special pages into 'overlays'" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30905 [22:01:15] New patchset: Jdlrobson; "align overlay heading into center" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30906 [22:01:41] yuvipanda: https://mingle.corp.wikimedia.org/projects/mobile/cards/195 < is that completed? [22:01:44] ^ tfinc [22:01:50] jdlrobson: yup [22:02:01] * jdlrobson changes mingle status [22:02:27] thanks jdlrobson [22:02:30] np [22:02:37] a clean mingle is a happy mingle [22:03:35] jdlrobson: hmmm ? [22:03:38] tfinc: yuvipanda took care of it [22:03:49] k [22:05:05] New patchset: Jdlrobson; "add full stop to comment" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30907 [22:05:13] okay, we're live on https://test.m.wikipedia.org - please test [22:05:38] whee, after 5 seconds of testing: take a look on interwikis on the main page:P [22:05:48] hmm... [22:05:49] This article is available in 1 language [22:05:49] English [22:05:49] English [22:06:00] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30907 [22:07:57] MaxSem: i'm confused - why is it still saying ShowRead in another language [22:09:41] * jdlrobson sent a fix for this yesterday [22:09:53] also confused with why there are two English's - is that a language variant eg. simple wiki? [22:10:18] also seeing things like <mobile-frontend-ajax-random-quote> [22:10:37] it may be two interwikis to en:, such as [[en:Main Page]], [[en:Main Page]] [22:10:59] was that fix merged? [22:11:27] it doesn't look like it MaxSem [22:11:35] trying to work out what happened [22:11:42] i'm sure brion merged it yesterday.. [22:11:45] Platonides, nope - one of them is a self-link [22:13:00] arggg [22:13:00] https://gerrit.wikimedia.org/r/#/c/30715/ [22:13:01] I see the [[en:Main Page]] in Main Page, but I don't see where's the other [22:13:02] apparently not [22:13:23] sigh [22:13:38] jdlrobson: are there other things expected to be merged for deployment today? [22:13:44] that haven't been yet, i mean? [22:13:46] i'm looking now awjr [22:14:05] https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/MobileFrontend,n,z [22:14:19] the only major one is 30715 [22:14:23] the others can wait [22:14:42] is there a way to tag things in gerrit? [22:14:42] 30715 looks ok to me but not sure how to test [22:15:01] not that i can tell [22:15:01] awjr: create an interwiki link on the main page [22:15:30] the fact there are two english languages is probably related to https://gerrit.wikimedia.org/r/#/c/30716/ [22:15:30] i don't have interwiki stuff set up on my local - is it set up on labs? [22:15:33] MaxSem: ^^ [22:17:13] I don't think so [22:17:13] hmm [22:17:13] I think patch set 1 was actually what we wanted [22:17:13] this is a little whacky but we could cherrypick the change onto test and if it looks ok merge [22:17:13] what do you think MaxSem ^ for https://gerrit.wikimedia.org/r/#/c/30715/ [22:17:13] https://gerrit.wikimedia.org/r/#/c/30716/ < actually effects production so we should probably revert that change [22:17:44] jdlrobson: i believe you have the power of +2! [22:17:48] yes i do awjr [22:18:01] not sure how it is useful here though :) [22:18:17] ahh the revert change button [22:18:38] actually that button might exist even for non-+2's [22:18:43] New patchset: Jdlrobson; "Revert "reveal simple wikipedia language link again (bug 41458)"" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30911 [22:19:12] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30911 [22:19:34] [bugs] REOPENED [Bug 41458] List of languages incomplete (priority: Unprioritized severity: normal) https://bugzilla.wikimedia.org/show_bug.cgi?id=41458 [22:19:55] MaxSem: are you comfortable cherry-picking https://gerrit.wikimedia.org/r/#/c/30715 onto test.w.o so we can test it before merging? [22:21:03] awjr, done [22:21:36] looks fixed [22:22:00] aye [22:22:08] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30715 [22:22:55] jdlrobson, I still see that yesterday's "wikitext is not defined" error [22:24:33] Mhttps://gerrit.wikimedia.org/r/#/c/30728/ [22:24:37] looks like that didn't get merged either MaxSem [22:24:54] * jdlrobson laments the code review situation yet again [22:25:13] jdlrobson: in the future if the merge is urgent, perhaps best to email the team about it [22:26:03] awjr: to be honest i think that's doing it wrong [22:26:12] we should all be keeping an eye on the code review [22:26:22] jcmish 's email mentioned the bugs that were found yesterday they should have been ticked off against pull requests [22:27:10] just finished testing non beta version and now that the language thing was reverted it looks fine. On to beta [22:27:35] awjr: i'm going to do some work with gerrit on Friday to surface code review better [22:27:35] even if it's just an atom feed [22:29:54] so jdlrobson what bug is 30728 associated with? [22:30:39] awjr: to my knowledge a bug wasn't raised [22:31:02] jdlrobson: so how was anyone supposed to know that that changeset was urgent? [22:31:13] holy fsck - I'm seeing a desktop version in Opera [22:31:17] well how am i to know it is urgent? [22:31:38] jdlrobson: well, doesn't it address an issue that was found during testing yesterday? [22:32:02] regardless; what is the issue it addresses and how do i test it so we can get it merged? [22:32:02] someone reported it during deployment yesterday. I fixed it _during_ the deployment window [22:32:18] no one gave it the attention during the deployment so it sat there till today [22:32:47] jdlrobson: what is the issue it addresses and how do i test? [22:33:05] MaxSem: jdlrobson, I still see that yesterday's "wikitext is not defined" error < whether that is urgent or not i don't know [22:33:27] i do not know what that means; when/where does that happen? [22:33:38] It's a bug in Firebug / Opera in the console that Max reported [22:33:46] MaxSem would be the best person to test it [22:33:53] by checking if the error goes away when he merges that change [22:34:05] it should be tested before the change is merged [22:35:05] awjr: http://mhcatlin2400.en.wikipedia.org.moovapp.com/wiki/Main_Page <-- moustachpedia [22:35:33] MaxSem: could you test https://gerrit.wikimedia.org/r/#/c/30728/ since you reported it? [22:35:41] (and +1 / merge ) [22:35:48] New review: MaxSem; "Fixes the bug for me" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/30728 [22:35:49] Change merged: MaxSem; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30728 [22:36:04] thanks MaxSem [22:36:15] ok hopefully that is everything [22:36:30] if there was another bug that didn't get fixed/merged it's off my radar [22:36:44] jdlrobson small thing when I'm in beta and I search after I go to the article the search pain doesn't clear [22:36:58] jcmish: does everything raised yesterday seem addressed? [22:37:04] awjr yup [22:37:08] w00t! [22:37:22] the only thing I see is that :) I'm walking through my little list :D [22:38:17] tfinc: needs more moustaches :p [22:39:43] New patchset: TheDJ; "(bug 41509) Fix styling of galleries on mobile" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30915 [22:39:52] im not seeing anything scary in beta or non-beta [22:40:05] Maryana: see any deployment blockers? [22:40:45] [bugs] NEW [Bug 41509] mf-common has table.gallery, but gallery is a div these days. (priority: Unprioritized severity: normal) https://bugzilla.wikimedia.org/show_bug.cgi?id=41509 [22:40:50] k looks like it's a feature the search not clearing [22:40:50] i'm seeing all sorts of weirdness on test.wiki, but maybe it's just due to test wiki [22:41:01] like what? [22:41:01] I'll update my test cases [22:41:16] no watchlist star after logging in, when i hit random more than once, the buttons stack up on top of each other [22:41:42] double arrow in footer [22:41:49] the random issues has been logged [22:41:59] it's still open from yesterday [22:42:02] MaxSem can you sync-common on srv193? [22:42:11] that shoudl fix the star issue, i think [22:42:24] Maryana: i am not seeing the double arrow in the footer [22:42:48] oh wait [22:42:53] i just did [22:42:54] on the unicorn article [22:43:29] it appears to happen when action=edit# [22:43:35] is that the language selector section collapsed into the footer? cos i'm also not seeing that >_< [22:43:53] oh, am i in editing mode? [22:43:54] hmm [22:44:05] done [22:45:26] hmm yeah still not seeing the watchlist icon [22:45:26] so i think the double arrow/no lang selector happens when you try to edit something and then back out of editing mode [22:46:56] HA awjr and Maryana I didn't clear my cache :D so I was still seeing the watchlist [22:47:22] it's still not showing up for me - the resource is 404'ing due to an old timestamp [22:47:34] New review: Jdlrobson; "Just a few suggestions but end goal looks good ! :)" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/30915 [22:47:34] i touched the file on fenari and just ran sync-common on srv193 [22:47:40] and now it appears [22:47:41] huzzah [22:48:03] nice [22:48:19] \o/ [22:48:31] damn it but the watched icon is not [22:48:31] sheesh [22:48:53] ha [22:49:01] i'm still seeing message errors [22:49:02] give fenari a few minutes to grind its rusty gears [22:49:05] it showed for a brief second [22:49:06] wtf is going on with our deployment scripts? [22:49:13] then I tried to click on it and it went away [22:49:15] i think it's a reousrce loader issue [22:49:18] i gues [22:49:19] i dont know [22:49:47] ok now it works [22:49:51] awjr: seems to work in landscape mode on iphone [22:49:58] looks like some kind of glitch [22:50:11] the search shouldn't be taking up the full width either [22:50:27] jdlrobson: i touched/sync'd the file again on test and it is now OK [22:50:40] yup I see it [22:50:47] and it's letting me select it [22:50:59] jdlrobson: the same thing happened yesterday. it took awhile for the star to appear, and then for the search to shrink so it would fit next to it [22:51:08] sorry to steal your thunder MaxSem but figured i'd just do it rather than ask you to :p [22:51:42] the star seems to incorrectly overlap search on webkit :( i'll file a bug for that [22:52:52] interesting - in non-beta i cannot collapse the main section on this article:http://test.m.wikipedia.org/wiki/Bug%2018463 [22:53:26] woo, star is correctly position now! [22:53:32] *positioned [22:54:06] oh it's because i was getting mixed assets for beta/non-beta on that page... [22:54:33] test.wikipedia.org makes me sad [22:54:43] ^ [22:54:43] +1 [22:54:51] hehe [22:54:58] gets me every time [22:55:20] awjr: https://bugzilla.wikimedia.org/show_bug.cgi?id=41406 [22:55:57] weird [22:55:59] oh well [22:56:38] Maryana, jcmish: good to go? [22:57:05] yeah, looks generally good to me [22:57:10] I think so too [22:57:48] MaxSem ^^ [23:00:01] WTF? how did that hack with second HtmlFormatter get merged?! [23:00:32] ? [23:01:28] https://gerrit.wikimedia.org/r/#/c/27773/1/includes/MobileFormatter.php [23:01:41] * MaxSem bites brion and preilly [23:01:54] MaxSem: that has been there for like 4 weeks [23:02:05] well 2 i exaggerate [23:02:06] Oct 13, 2012 3:00 PM [23:03:03] it had always been intended as a POC, no? [23:03:16] man i have tried to call the indian consulate multiple times about my visa app, but they have yet to answer and they apparently do not have an answering machine... [23:03:31] You think they'd have a call centre... [23:03:49] the [23:03:51] er [23:03:52] tehe [23:04:15] jdlrobson, the original commit by Brion was -2'd for a reason [23:05:15] we should really start using remote branches for POCs/experimental stuff so accidental merges to master dont happen [23:05:53] awjr, the original change was -2 and abandoned: https://gerrit.wikimedia.org/r/#/c/23626/ [23:06:06] oh… how'd it get back in there? [23:06:20] Jon simply recommitted it as a separate rev [23:06:35] nice hack:P [23:06:49] i don't know what to say - it's been there for a while and got +2ed by brion and preilly [23:07:03] this is why i review the commit logs [23:08:08] MaxSem on another note, did you see jcmish and Maryana ok'd deployment? [23:08:31] [bugs] NEW [Bug 41562] Can't see expand arrow in night mode using Wikipedia Beta 1.4beta1 (priority: Unprioritized severity: normal) https://bugzilla.wikimedia.org/show_bug.cgi?id=41562 [23:08:47] [bugs] NEW [Bug 41569] Stop parsing HTML twice (priority: Unprioritized severity: major) https://bugzilla.wikimedia.org/show_bug.cgi?id=41569 [23:08:53] ^^^ [23:09:05] test is working strangely for me now .. sections cannot be collapsed [23:09:07] awjr, will do shortly [23:09:08] cannot replicate in localhost [23:09:21] jdlrobson: clear cache/porn mode? [23:09:38] can you quickly check for me on an android/iphone emulator? [23:09:46] jdlrobson: i sometimes get mixed beta/non-beta if i forget [23:09:46] yes [23:09:46] jdlrobson, it had never been +2'd by Brion [23:09:46] i'm not seeing arrow heads on sections [23:10:34] jdlrobson: beta/non-eta? [23:10:37] awjr: beta [23:12:19] awjr: seems to be related to loading sub pages [23:12:33] jdlrobson: wfm on ics [23:12:45] awjr: try searching for Barack Obama in beta [23:12:45] and loading that page [23:13:10] jdlrobson: yeah that looks fine to me [23:13:20] mm strange [23:13:27] * awjr tries ios [23:13:36] hahaha, I'm getting a certificate warning on test [23:13:41] >_< [23:13:56] guess i've just got a weird phone [23:14:12] jdlrobson: i am seeing what you are describing in my ios simulator [23:14:17] mm [23:14:24] sections are not expanding [23:14:28] and no toggle arrow [23:14:40] on test? works ok on my iphone [23:14:47] Maryana: what version of ios? [23:14:56] my simulator is using ios 6 [23:15:02] i have 6 on my phone [23:15:04] forks fine on my local machine though [23:15:04] trying it now [23:15:12] *works [23:15:29] oh, refreshing the page looks fine in the simulator... [23:15:37] may just have been old cached whatever [23:15:43] i suspect that's what's going on [23:15:45] collapsible sections don't work for me in beta [23:15:53] MaxSem: that's what we are talking about [23:15:59] MaxSem: clear cache and try again? [23:16:21] i've got 6.. i think. that's the latest update, right? [23:17:02] yup that latest Maryana [23:17:16] should be 6 [23:17:16] thx :) [23:17:21] you bet :D [23:17:38] also why oh why am i seeing bad translations still [23:17:49] <mobile-frontend-ajax-random-quote> [23:17:53] <mobile-frontend-ajax-random-question> [23:18:08] it's because l10n cache hasn't been updated yet [23:18:20] taht's just how it goes on test [23:18:40] are we good to scap, or those newly discovered isuues are still there? [23:19:08] awjr I checked on my phone and it looks good [23:19:11] are you still seeing issues? [23:19:16] yeah, once i refershed the page it was fine [23:19:17] http://test.m.wikipedia.org/wiki/San%20Francisco?debug=true i don't see issues [23:19:32] definitely something ResourceLoader related awjr [23:19:40] sigh [23:20:13] MaxSem: sounds like we're good to go but be aware we might need to deal with RL issues after scap [23:20:32] awjr: MaxSem i also need to leave in 40 mins [23:21:15] hey tfinc, was this you in disguise? http://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Is_there_a_iPhone_App_to_upload_pictures_and_video_to_Wikipedia.3F [23:21:18] :) [23:21:28] haha [23:21:57] * jdlrobson reads entire conversation replacing '155.201.35.58' for tfinc [23:21:57] * Maryana geochecks the IP [23:22:26] jdlrobson: ok no worries [23:22:28] st. petersburg florida! :-0 [23:22:31] it's jimbo [23:22:33] JIMMY [23:22:41] hahaha [23:22:41] * yuvipanda throws www.mediawiki.org/wiki/Commons_Mobile_upload_app at Maryana  [23:22:48] not for iPhone, but still... [23:23:28] yuvi, reply on VPT! [23:24:47] New review: awjrichards; "Apparently this change had previously been -2'd in another commit (https://gerrit.wikimedia.org/r/#/..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/27773 [23:25:51] :) [23:26:07] i was replying when my connection went out [23:26:08] doing again [23:29:02] scapping! [23:29:06] w00t [23:29:09] awjr: we on for 4:30 [23:29:14] ? [23:29:18] tfinc yeppo [23:29:34] this time, I touched all files in both branches [23:32:16] tfinc: ready when you are [23:32:24] i'm already on hangout [23:32:45] just waiting for you to join [23:32:51] awjr: --^ [23:32:51] oh fancy i was waiting for skype [23:34:25] MaxSem: the SSL warnings should be gone now. did it manually to not wait for puppet too long. sorry, something went wrong when this cert was ordered and we should have checked twice for the .m. [23:34:36] Maryana: replied, and updated status on commons app page too :) [23:34:39] (we still have the new one on non-mobile) [23:34:59] sweet :) [23:35:13] tfinc: could you test the s3 when you can? thanks :) [23:35:20] yuvipanda: in a meeting [23:35:27] yeah, just a reminder [23:35:41] gnite everyone :) [23:38:05] mutante, thanks [23:43:08] * tfinc wonders where his hangout connection went [23:43:12] :( [23:49:46] i've got to head out soon.. any thing before i go? [23:53:15] not from this corner - looks like we're still waiting for scap to finish [23:54:11] thanks awjr [23:54:18] np take it easy [23:57:48] see ya all