[00:13:00] friggin scap [00:22:07] jebus [00:22:19] MaxSem: when did you start scap? [00:22:53] answer: 53 minutes ago and it's still not done [00:22:53] this is insane [00:22:54] at 4:30, restarted at 4:39 due to localisation weirdness [00:23:00] oh ok [00:23:16] we're going to need to move our deployment windows earlier... [00:31:05] looks like it just finished [00:40:40] MaxSem, Maryana: things are generally looking OK to me in production, but i am not seeig the 'edit' link in the beta [00:41:00] actually i think im getting old js/css [00:41:07] i didn't realize the changes went through -- there's no edit and no new random thingy [00:41:15] yeah, same [00:41:23] Maryana: yeah, scap just finished a few minutes ago :( [00:41:39] im not sure if it's a js/css issue or a varnish cache issue [00:41:40] or both [00:41:48] old watchlist star icon, too [00:42:09] MaxSem: ^ [00:43:01] "document.getElementById("results") is null" [00:43:48] in Special:Userlogin [00:44:12] how do people program without jQuery? [00:44:27] MaxSem: i am not seeing that error [00:44:47] MaxSem: but i am seeing what i think is old js/css [00:46:39] yeah debug=true reveals the new stuff [00:48:30] heh, mandatory "omgvarnish" [00:48:37] check [x] [00:49:13] hehe is it varnish or RL? [00:49:56] i think this is RL, the timestamps in the req urls are old [00:50:10] ha. ha. ha [00:50:17] oh wait, i think it just updated [00:50:38] not for me :( [00:51:02] I specifically ran find -type f -exec touch {} \; in order to make RL pick these changes [00:51:07] well, just the star and the footer [00:51:07] not editing or the new random [00:51:36] le sigh [00:52:04] this is maddening [00:52:13] how about taking a desktop approach and let it update itself with time? [00:57:46] edit button!! [00:58:00] maxsem, awjr ^ [00:58:29] what about it? [00:58:29] i just touched/sync'd [00:58:34] it's live :) [00:58:38] and now i see it :) [00:58:52] i hate resource loader [00:59:00] i dont understand why this is a chronic problem. [00:59:06] "tokenQuery[tokenType].done is not a function" [00:59:20] where are you seeing that MaxSem? [00:59:28] enwiki [00:59:50] tokenQuery[ tokenType ].done( callback ); [01:00:02] MaxSem: im not seeing that - beta/non-beta? logged in? article? [01:00:30] beta, logged in, User talk:Albert Garney, CPO [01:01:17] editing-related [01:03:04] [bugs] NEW [Bug 41570] tokenQuery[tokenType].done is not a function (priority: Unprioritized severity: normal) https://bugzilla.wikimedia.org/show_bug.cgi?id=41570 [01:04:01] just made an edit, too: http://en.wikipedia.org/w/index.php?title=Robert_Tryon&diff=520676984&oldid=493562301 [01:04:07] the diff shows up weird [01:04:29] lol yeah it does... [01:04:33] i didn't actually add a section; i just changed the second Tryon to "He" [01:04:43] i dont know how jon implemented it but section level editing is probably wonky via the api [01:04:43] * MaxSem blocks Maryana for extra newlines [01:04:44] hehehe [01:04:50] :( [01:05:13] it's ok; i created the article [01:05:17] nobody's gonna be mad :) [01:05:28] de.m.wikipedia.org is still showing old js/css.. [01:09:33] the random feature jon implemented works weirdly when you're already on a special page [01:09:45] and by that i mean it doesnt really work [01:10:42] it also bugs out if you're in edit mode and use it [01:10:58] it takes you to another article but still semi thinks you're in edit mode [01:11:01] beta! woo! [01:11:03] :) [01:11:04] hehehe [01:12:51] beta shouldn't equal to broken [01:13:21] ok, i'm out of here. off to make more spurilous edits from my mobile device >:-) [01:14:31] MaxSem: i agree but i think it's ok to expect occasional weirdness in beta [01:14:45] "weirdness" [01:19:28] awjr, did that touch help? [01:19:43] MaxSem: er which touch? [01:19:59] !log awjrichards synchronized php-1.21wmf3/extensions/MobileFrontend/javascripts/actions/mf-edit.js 'touch file' [01:20:25] oh, I assumed it was later [01:20:43] the first one i did on wmf2 helped so i did the one on wmf3 was just for good measure, i havent checked yet [01:21:52] actually it doesn't look like it :| [01:22:05] oh just kidding yes it does [01:22:19] but what the hell - I touched everything before scapping [01:23:13] MaxSem: im not sure your find trick worked; i ls -laF'd in MobileFrontend on fenari and there are some ancient timestamps [01:23:43] ancient is maybe an exageration... [01:23:44] but [01:23:44] drwxrwxr-x 2 reedy wikidev 4096 2012-10-15 14:34 scripts/ [01:24:23] I touched files [01:24:24] http://dpaste.org/aJW8Y/ [01:25:33] hmm [01:26:17] yeah that should work [01:26:21] i dunno man [01:26:57] and that would explain why scripts/ wasn't updated since you did fine -type f [01:27:23] hmmm but: -rw-rw-r-- 1 preilly wikidev 1658 2012-10-31 01:26 eventlog.js [01:27:45] oh wait im dumb [01:28:00] i read that as 2012-10-30 not 31 [01:28:28] i dunno, maybe we should harass the RL guys [01:28:35] or the scap people [01:28:36] or both [01:28:44] but… tomorrow. [02:14:55] [bugs] REOPENED [Bug 41502] Blank messages via Mobile Feedback should not be sent (priority: Unprioritized severity: normal) https://bugzilla.wikimedia.org/show_bug.cgi?id=41502 [06:20:57] New patchset: Jdlrobson; "add authenticated flag to fixtures so tests run" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30942 [06:20:57] New patchset: Jdlrobson; "update tests to trigger toggling on mousedown" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30943 [06:21:27] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30942 [06:22:05] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30943 [11:20:30] New patchset: TheDJ; "(bug 41554) Add language attributes to "in other languages"" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30959 [15:18:54] New patchset: Jdlrobson; "add basic tests for mf-edit.js module" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31005 [15:18:54] New patchset: Jdlrobson; "fix broken experimental editing" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31006 [15:30:02] whee tests! [15:40:39] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30782 [17:00:37] * MaxSem looks around [17:00:56] just us chickens [17:01:50] #gogiants === #slowasscommute [17:02:13] heh [17:04:48] no standup until enough of us are actually here [17:05:48] ok [17:06:55] bah [17:10:21] hey tfinc [17:10:32] YuviPanda|Storm: hows the storm? [17:10:49] tfinc: since i'm near the beach, no rain but extremely strong winds [17:11:04] i tried to go out for food but couldn't exactly walk where I wanted to [17:11:25] there's low voltage power (enough to run the router!), so I can be up until my computer runs out [17:12:36] YuviPanda|Storm: will this storm still be going when we arrive ? [17:12:51] tfinc: it's not hitting any part of where you'll be [17:12:57] well, except bangalore a little bit, maybe. It's only the coastal south [17:13:13] * ori-l thinks YuviPanda is going to imprison tfinc in a dungeon [17:13:32] "tfinc: it's not hitting any part of where you'll be " [17:13:34] ori-l: stop giving me ideas :P [17:14:02] tfinc: but it might very posssibly rain, so pack at least a little rain gear [17:14:18] lolz [17:14:32] YuviPanda|Storm: packing rain gear for india just confuses me [17:14:57] there are two seasons - when it rains and when it is too hot [17:15:02] nothing in between [17:15:06] * awjr waves [17:15:18] I still don't ever recall being anywhere that could be called 'autumn' [17:15:47] hey awjr [17:16:26] * tfinc thinks he should have gotten an extra dinosaur for his Wash (Firefly) costume [17:16:38] ! [17:16:45] :D [17:16:47] that is the perfect costume for you! [17:16:52] hm so i should bring an umbrella to pune, looks like scattered showers [17:16:52] Maryana: its gets better [17:16:57] Maryana: tina dressed up as ZOe [17:17:00] Zoe* [17:17:06] i was just gonna say [17:17:06] :D [17:17:15] :) [17:17:20] tfinc: i presume there's a giant shard of machine shrapnel coming out of your chest [17:17:22] [17:17:29] he is a leaf on the wind [17:17:29] pix plz. i'm wfh to avoid getting stuck on BART w/giants fans, but i want to see this [17:17:43] tfinc: you're dressed that way *now* [17:18:03] ? [17:18:32] is someone brought a camera ... [17:18:34] YuviPanda|Storm: correct [17:18:46] what fun is a costume if you can't wear it all day [17:19:21] wait, does that make erik mal? [17:20:40] lolz [17:20:42] if only he would do it [17:21:37] * SadPanda|Storm wonders who is Summer [17:22:19] tfinc: how's the S3? [17:22:28] SadPanda|Storm: its sitting in the cabinet waiting to be charged [17:22:37] SadPanda|Storm: what do you need me to test? [17:22:48] tfinc: see if you can search [17:22:52] in english [17:23:20] and then japanese :P [17:23:21] Change merged: Brion VIBBER; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31005 [17:23:23] i might have a fix [17:23:31] Change merged: Brion VIBBER; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31006 [17:24:33] SadPanda|Storm: whats the issue with only being able to type one char? [17:25:05] tfinc: that's what I want you to test [17:25:16] SadPanda|Storm: assuming you are getting the feedback mails? [17:25:18] tfinc: it's been reported across a variety of handsets, but i've been unable to confirm it so far [17:25:40] jdlrobson: i am, jon. I'm unable to repro it anywhere. tfinc is now going to check it on one of the phones in the office [17:25:56] ahh phone development [17:25:57] the new ie6 [17:26:23] sadJdlrobson: I've started androidifying things. Should make fundamental stuff break a lot less [17:26:28] brion: iOS app has gone from "Waiting for review" to "In Review" [17:26:38] \o/ [17:26:38] I want to be adding features, not fixing underlying bugs [17:27:22] SadPanda|Storm: i'm going to be stepping into meetings so you may want someone else to look at it. possibly michelle when she gets in [17:27:35] ah, okay [17:34:18] * yuvipanda_ wonders if he could steal brion [17:34:21] brion: are you in the office? [17:34:35] i'm working from home today what's up yuvipanda [17:35:03] oh :( The SIII test. [17:35:16] darn [17:35:18] the device is in the office, and I don't think you have an SIII in your vast array of electronic displays [17:35:44] yeah i can test on my galaxy nexus but if it's samsung-specific i don't have the samsung goodies on the nexus [17:35:59] it works on most places [17:36:15] including galaxy nexus, nexus s, nexus 7, and equivalent emulators [17:37:03] d'oh [17:38:09] * SadPanda|Storm pokes sadJdlrobson [17:38:54] hey [17:39:03] hey sadJdlrobson [17:39:10] can I steal you for a bit? [17:40:00] sure [17:40:27] sadJdlrobson: awesome! Can you pick up the SIII from the great box of wonderful electronics? [17:40:42] the SIII ? [17:41:00] the galaxy? [17:41:58] sadJdlrobson: its the large blue phone in the cabinet [17:42:00] sadJdlrobson: yes [17:42:08] the galaxy siii [17:42:23] one of the people who mailed us yesterday was able to repro it. I took a shot in the dark and sent him an apk which apparently fixes the issue [17:43:10] so can you please 1. install prod app on it 2. see if you can enter full words? [17:43:57] just btw, I ran across a couple of new mobile test tools just today, thought y'all might be interested http://my.opera.com/ODIN/blog/2012/10/30/opera-mobile-emulator-12-1-is-out http://starkravingfinkle.org/blog/2012/10/firefox-for-android-remote-web-console-is-here/ [17:44:36] remote web console for firefox … awesome! [17:45:48] tfinc: since jellybean I've been able to get weinre working. It's been awesome help! [17:46:26] yuvipanda: i can type... [17:46:29] sadJdlrobson: :'( [17:46:35] sadJdlrobson: which keyboard? [17:46:40] and is it running ICS? [17:46:47] * sadJdlrobson checks [17:47:00] ah whoops i have the wrong phone [17:47:01] 1 [17:47:02] 1s [17:47:37] ah [17:48:40] 4.0.4 GT-I9300 [17:48:43] is that the correct one? [17:48:55] * SadPanda|Storm checks [17:49:34] ok i can replicate [17:49:36] sadJdlrobson: looks like it [17:49:38] whee super [17:49:39] last version worked fine [17:49:44] updated [17:49:44] works [17:49:44] *rather doesn't work [17:49:52] sadJdlrobson: https://dl.dropbox.com/u/8768784/Wikipedia-keyboard.apk [17:49:54] try that [17:52:36] sadJdlrobson: any luck? [17:55:39] Maryana: mobile editing fixed and deployed thanks to preilly [17:55:45] (and brion for merging)( [17:55:53] sweet! thanks all [17:55:53] just checked it and it worked as expected [17:56:00] please verify some more! [17:56:07] does that mean you're no longer a sadjdlrobson? :) [17:57:10] * BasicPanda|Storm pokes NeutralJdlrobson [17:57:19] yo BasicPanda|Storm [17:57:38] NeutralJdlrobson: did you get the apk link i sent? [17:57:47] * BasicPanda|Storm is on a flaky connection in the middle of a storm [17:57:47] no [17:58:02] NeutralJdlrobson: https://dl.dropbox.com/u/8768784/Wikipedia-keyboard.apk [17:58:05] can you try that on the siii? [17:58:07] *should* fix it [17:58:15] k 1s [17:58:18] need to bit ly that [17:58:21] you'll have to uninstall prev version [18:00:25] yuvipanda: wfm [18:00:26] well done [18:00:42] * BasicPanda|Storm kicks webkit where it hurts [18:00:47] let me go submit a patch [18:00:54] NeutralJdlrobson: oh, another thing. Try entering japanese text [18:00:59] you might have to install the japanese keyboard [18:01:06] BasicPanda|Storm: i'll try that later [18:01:11] okay! [18:01:34] NeutralJdlrobson: Thanks! [18:02:08] hmm. editing boxes are showing up out of order for some reason [18:06:10] awjr, what to do with the Solr card - the development is over, but it's mostly not reviewed and won't go live for testing reasonably soon; does it belong to "ready for testing"? [18:06:41] MaxSem: looks like we have 1/3 reviews done [18:06:52] yup [18:06:55] * BasicPanda|Storm pokes brion with https://github.com/wikimedia/WikipediaMobile/pull/310 [18:06:58] MaxSem: yes, i think so. sync up with jcmish about how to test and let me know if you need help prodding for reviews, etc [18:07:12] hey jcmish [18:07:31] BasicPanda|Storm: aww, we lose that weird overlay fix [18:07:38] hate when these fixes cause new problems :( [18:07:53] [WikipediaMobile] brion pushed 2 new commits to master: http://git.io/Bc3ULA [18:07:53] WikipediaMobile/master 73b0e82 YuviPanda: Fix for people being unable to type full words in search bar [18:07:53] WikipediaMobile/master 7b95109 Brion Vibber: Merge pull request #310 from yuvipanda/samsung-s3-fix... [18:07:53] merged [18:07:55] jcmish: are you in the office yet? I'm hoping you could do a little test for me? Should only be a few mins.. [18:08:01] brion: thanks [18:08:07] Project WikipediaMobile - Nightly builds build #444: SUCCESS in 12 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/444/ [18:08:08] yuvipanda: Fix for people being unable to type full words in search bar [18:08:57] BasicPanda|Storm: jcmish just got in [18:08:57] New patchset: Jdlrobson; "when enhanced edit area make sure you hide it so it doesn't appear twice" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31032 [18:13:50] * yuvipanda pokes jcmish [18:15:46] yuvipanda: i just gave jcmish as introduction as to who you are [18:16:04] yuvipanda: she was curious about this 'panda' character ;) [18:16:18] aaaah [18:16:50] weird guy on IRC going aroudn poking people :D [18:17:39] hehe [18:17:46] I thought you made it up to sound cool ;-) [18:17:50] also, a BLACK RECTANGLE! [18:18:13] It made me feel insecure [18:18:15] :D [18:18:15] yuvipanda is a myth [18:18:17] and question my own naming convention [18:18:20] brought to life because we believe in him [18:18:45] inded, and manifests as a Black Rectangle or a view of bangalore out of an autorikshaw during standups [18:18:48] *indeed [18:19:26] jcmish: can you help me out with one bit of testing? I'm all ready to push an update to the store once that is done... [18:21:21] you bet [18:21:35] I can definitely help [18:21:55] jcmish: okay! [18:22:18] jcmish: can you pick up the SIII from NeutralJdlrobson and install the japanese keyboard from the google play store? [18:22:25] yup [18:22:32] and then just check if you can enter japanese characters into the search bar in the wikipedia app he has installed [18:22:53] k trying it now [18:23:20] * chrismcmahon loves the smell of mojibake in the morning [18:25:20] * yuvipanda googles mojibake [18:25:38] aaah :D [18:26:16] haha http://en.wikipedia.org/wiki/File:Letter_to_Russia_with_krokozyabry.jpg [18:27:27] brion: I hope it doesn't get deleted :D [18:27:40] oh no stray (c) [18:29:01] Yuvi it worked [18:29:15] yayy [18:29:35] jcmish: sweet! Just to confirm, can you install play.google.com/store/apps/details?id=org.wikipedia.beta and confirm that it *doesn't* work in that? [18:29:41] searching for 'wikipedia beta' in the play store should get you that [18:29:54] will do [18:33:03] Maryana: are you still having issues with editing or is that fixed now? [18:33:15] * Maryana tries again [18:34:14] success! [18:34:19] awesome [18:34:21] New patchset: Jdlrobson; "when enhanced edit area make sure you hide it so it doesn't appear twice" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31032 [18:34:24] and no added newlines or removed content [18:34:28] win [18:34:41] https://gerrit.wikimedia.org/r/#/c/31032/ < Maryana that should remove need for the hack [18:34:47] hurray [18:34:50] New patchset: Brion VIBBER; "Partial revert of change Change I1f5fab58 (bug 41141), add config setting for previous behavior." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31039 [18:34:52] w00t [18:35:00] let's not give it too much attention though just in case there are any more lingering bugs [18:35:09] kk [18:35:20] should i revert the change to mediawiki i made or leave it? [18:36:58] New patchset: MaxSem; "Deadbeef removal" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31042 [18:37:00] Yuvi you're correct in the beta app [18:37:11] sweeeeet! [18:37:12] thanks a lot jcmish [18:37:12] the japanese characters don't show up [18:37:21] i bet english doesn't show up either [18:37:29] well let me check [18:37:37] correct [18:37:40] they don't either [18:38:21] wonderful [18:38:23] thanks a lot jcmish [18:38:43] let me push this out to market and then reply to everyone who has commented about the problem [18:39:35] no problem [18:41:37] Project WikipediaMobile - Nightly builds build #445: SUCCESS in 10 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/445/ [18:44:57] [bugs] NEW [Bug 41141] Meta-Wiki mobile site has errant trademark symbol (™) in footer (priority: Unprioritized severity: enhancement) https://bugzilla.wikimedia.org/show_bug.cgi?id=41141 [18:45:47] jcmish: final check before I push to market: https://dl.dropbox.com/u/8768784/Wikipedia-v1.3.1.apk in the device? [18:46:41] will do [18:51:25] ok i gotta work on my india presentation and take care of remaining travel stuff, i'll be off irc to reduce distractions. :) text me if needed [18:51:34] [bugs] NEW [Bug 41543] Missing indentation for lists (priority: Unprioritized severity: normal) https://bugzilla.wikimedia.org/show_bug.cgi?id=41543 [18:52:05] sorry Yuvi i'm slow getting used to the S3 :D I have an iphone so I'm device challenged :D [18:53:07] jcmish: heh :D [18:53:28] meh, fruit elitism again [18:53:29] jcmish: i'm unsure what the plans for our iOS app are - it has a lot of unreleased/untested code sitting there too. [18:53:59] * yuvipanda is not a fan of the fruit, at least since they pulled out JIT from all webkit-based apps and give no public reason [18:54:25] haha I hear ya [18:59:54] jcmish: i've my hands hovering over a 'save' button. Poke me when you could confirm that it doesn't blow up :) [18:59:56] thanks a lot! [19:03:20] tfinc: ready when you are [19:04:28] yuvi make it so :D [19:04:30] worked [19:05:04] * yuvipanda hits save [19:05:07] jcmish: thanks a lot! [19:05:12] NeutralJdlrobson: thanks for the testing :) [19:05:19] you bet [19:05:23] sorry so slow again :D [19:06:01] :D Now I'll wait for a few hours to have Google Play propogate the update, then email all the folks who mailed in to report [19:06:10] (assuming the storm doesn't knock out power until then) [19:06:21] * yuvipanda goes on a victory junk-food-binge [19:07:23] yuvi do you need an excuse for a junk food binge? [19:07:29] awjr: just got back from grabbing lunch [19:07:29] I thought those were always okay [19:07:31] * tfinc moves to a conf room [19:08:36] jcmish: heh :D it's all I got for now - it's 12:30 AM, and more importantly, the city was just hit by a storm :D [19:08:51] be safe [19:09:12] plus I'm a little tired of the variety of junk food - or the lack thereof. Not touching street food during rain cuts my options significantly [19:09:25] jcmish: thanks! [19:09:56] jdlrobson, how can I help you with diagnosing https://bugzilla.wikimedia.org/show_bug.cgi?id=41570 ? [19:10:22] the repro is "Open Firebug, go to the aforementioned page, see the error message" [19:10:46] yes but i don't have that MaxSem so there is something special in what you are doing [19:10:50] what url are you on [19:10:56] are you clicking on anything or just putting it in the address bar [19:11:04] the one in the bug [19:11:07] what phone are you using [19:11:13] it's on page load [19:11:18] what version of firefox.. all this stuff matters [19:11:23] desktop FF [19:11:46] the latest one, they don't really allow you to use anything older:) [19:13:17] ok it seems Firefox only [19:13:30] we don't test beta currently on firefox so that doesn't surprise me [19:13:55] nope, I see it in Opera too [19:14:14] ok replicated now in Firefox [19:14:37] You also have to be logged in [19:14:40] what I see: tokenType = 'watch', tokenQuery contains only 'edit' [19:15:05] being logged in is mentioned in my report [19:19:03] WTF, how the hell response with code 301 and Location: header set does not result in redirection? [19:19:36] preilly, do you have any idea? ^^^ [19:29:14] preilly, to be precise - why doesn't this: http://dpaste.org/EiBRg/ redirect? [19:30:09] this seems Varnish - related, as on dev wikis redirects work just fine [19:30:11] New patchset: Jdlrobson; "use hasOwnProperty when checking cache in getToken (bug 41570)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31068 [19:31:10] MaxSem: fixed ^ [19:31:20] whee, thanks! [19:37:28] New patchset: TheDJ; "(bug 41509) Fix styling of galleries on mobile" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30915 [19:38:15] New patchset: TheDJ; "(bug 41509) Fix styling of galleries on mobile" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30915 [19:39:19] New patchset: TheDJ; "(bug 41509) Fix styling of galleries on mobile" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30915 [19:40:37] blargh - how do i browse code in gerrit (not in code-review form, but the actual existing code) [19:40:38] ? [19:40:55] i know it's possible, i've done it before, but i'm not figuring out how to do this thorugh the interface.. [19:41:49] awjr: i usually take https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/ShortUrl.git;a=tree and modify the path in the URL [19:42:03] aHA! [19:42:03] thanks yuvipanda [19:42:10] why is that utterly invisible in the UI? [19:42:12] :) [19:42:16] * awjr slaps gerrit [19:43:18] awjr: yeah, i also have often wondered why that is so hidden away. [19:43:31] silly gerrit [19:43:50] it is visible in the interface *somewhere* [19:43:54] though i've no idea where [19:45:41] ok, my laptop's power about to run out [19:45:44] brb storm [19:46:10] Admin --> Projects --> pick one --> Branches --> gitweb [19:46:25] it's so obvious;) [19:47:58] Maryana: great we already got feedback about editing feature :) [19:47:58] a win for the beta! [19:48:27] happyjdlrobson? :) [19:48:35] almost [19:49:08] * Maryana gives jdlrobson a cookie [19:49:50] errg Maryana i closed that Village pump article before watching it [19:49:52] what was the url? [19:50:21] this? https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Notice:_editing_enabled_on_mobile_Beta_site [19:50:50]