[00:00:07] <tfinc>	 yuvipanda: will we get a app to track your bot ?
[00:00:24] <yuvipanda>	 it'll update to yuvi.in/where.html
[00:00:32] <yuvipanda>	 that page has been awfully constant for the last few months
[00:00:43] <jcmish>	 awjr it's the mustache isn't it?
[00:00:45] <yuvipanda>	 i'm vacating this place tomorrow(?) and I'll be a happy to get back on the road
[00:01:26] <awjr>	 jcmish: hehe yes
[00:01:58] <jcmish>	 :)
[00:04:58] <yuvipanda>	 tfinc: i've replied to everyone complaining about the typing bug
[00:05:21] <yuvipanda>	 tfinc: thanks a lot (to erik too!) for getting us the reply feature
[00:05:21] <tfinc>	 yuvipanda: did 1.3.1 fix it?
[00:05:28] <yuvipanda>	 tfinc: oh yes, it did. Update's been rolling out for a few hours now.
[00:05:36] <tfinc>	 yuvipanda: i don't see it here http://www.mediawiki.org/wiki/Mobile/Release_history
[00:05:55] <yuvipanda>	 let me do that now
[00:05:57] <tfinc>	 i also don't see an update in the master change log
[00:05:59] <tfinc>	 bad yuvipanda
[00:06:07] <yuvipanda>	 tfinc: what, I updated
[00:06:11] <yuvipanda>	 look before 1.4beta1
[00:06:18] <yuvipanda>	 it's in proper order
[00:06:24] <yuvipanda>	 tfinc: also, move https://dl.dropbox.com/u/8768784/Wikipedia-v1.3.1.apk to dumps?
[00:06:45] <awjr>	 OuKB, preilly: any idea what mobile-testing appears down?
[00:07:05] <OuKB>	 it's no more
[00:07:13] <awjr>	 oh
[00:07:14] <awjr>	 well that's a good reason
[00:07:19] <awjr>	 OuKB: do we have smoething else instead now?
[00:07:22] <OuKB>	 preilly has set up staging instead of it
[00:07:27] <tfinc>	 http://dumps.wikimedia.org/android/Wikipedia-v1.3.1.apk
[00:08:05] <tfinc>	 yuvipanda: ---^
[00:08:11] <yuvipanda>	 thanks
[00:08:50] <awjr>	 OuKB: whats the hostname?
[00:08:56] <OuKB>	 staging
[00:09:12] <yuvipanda>	 done
[00:09:21] <awjr>	 oic
[00:09:24] <awjr>	 thanks OuKB
[00:10:32] <awjr>	 jcmish: are you using staging right now? there's a change i'd like to test real quickly there
[00:11:13] <jcmish>	 nope go for it
[00:11:19] <jcmish>	 I'm actually testing on the s3
[00:13:20] <awjr>	 k
[00:13:46] <awjr>	 jcmish: have you checked changes out on staging before? it looks like i do not have permissions nor do i have sudo
[00:14:01] <awjr>	 looks like everything is owned by preilly atm
[00:15:55] <jcmish>	 I have not!
[00:16:04] <jcmish>	 today I just got access to it :D
[00:17:17] <awjr>	 preilly: can you get staging to let us checkout code?
[00:18:42] <gerrit-wm>	 New patchset: Jdlrobson; "rename to generic mobile.production-jquery" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31157
[00:25:56] <yuvipanda>	 tfinc: a *lot* of reviews changed from 1star to 5 :D
[00:28:32] <OuKB>	 awjr, I have sudo on it - how can I help?
[00:29:03] <awjr>	 OuKB: trying to test https://gerrit.wikimedia.org/r/#/c/30187/2
[00:29:08] <awjr>	 can you checkout that changeset?
[00:29:29] <gerrit-wm>	 New patchset: Jdlrobson; "kill animated options code with fire" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31161
[00:29:29] <gerrit-wm>	 New patchset: Jdlrobson; "code cleanup" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31162
[00:29:29] <gerrit-wm>	 New patchset: Jdlrobson; "remove unreachable reference code" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31163
[00:29:29] <gerrit-wm>	 New patchset: Jdlrobson; "refactor reference code to provide generic popup" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31164
[00:30:34] <OuKB>	 awjr, done
[00:30:42] <awjr>	 thanks OuKB
[00:31:09] <preilly>	 awjr: you can as root
[00:33:32] <OuKB>	 awjr, what's wrong with your sudo? from labsconsole, it seems that you should have it
[00:34:13] <awjr>	 lol
[00:34:15] <awjr>	 OuKB: wrong password :p
[00:34:16] <awjr>	 it works fine
[00:34:41] <OuKB>	 jcmish, do you already have a Labs/Gerrit account?
[00:34:45] <awjr>	 it would be nice if it were set up so we didnt need sudo for that
[00:34:54] <jcmish>	 yup
[00:35:09] <OuKB>	 jcmish, what's your account name?
[00:35:11] <jcmish>	 mgrover
[00:36:20] <OuKB>	 oh, I see you're already on access list
[00:36:20] <OuKB>	 cool
[00:36:24] <jcmish>	 woohoo
[00:41:38] <preilly>	 awjr: you are a member of the svn group right
[00:41:53] <preilly>	 just change the permissions to sticky group svn with write access
[00:43:23] <jcmish>	 OuKB I just sudo using my password yes?
[00:43:28] <OuKB>	 yup
[00:43:58] <OuKB>	 eh, *svn*?
[00:44:16] <preilly>	 OuKB: that is how labs is set-up
[00:44:29] <preilly>	 OuKB: everybody is part of the svn group for legacy reasons
[00:44:59] <jcmish>	 k I get permission denied public key when I sudo
[00:45:39] <OuKB>	 on staging or bastion?
[00:45:43] <jcmish>	 staging
[00:46:53] <OuKB>	 Ryan_Lane, ^^^
[00:47:30] <OuKB>	 hehe, I scared him
[00:47:31] <preilly>	 jcmish: give me a second
[00:47:40] <jcmish>	 preilly no prob
[00:47:55] <preilly>	 OuKB: why are you pinging Ryan Lane?
[00:48:06] <OuKB>	 PK issues
[00:48:42] <preilly>	 OuKB: this is what I'm doing right now
[00:48:43] <preilly>	 [1]-  Running                 sudo chown -R root:svn p &
[00:48:44] <preilly>	 [2]+  Running                 sudo chmod -R g+rwx p &
[00:49:24] <awjr>	 thanks preilly
[00:49:37] <preilly>	 OuKB: and sudo chmod -R g+s p
[00:49:43] <awjr>	 jcmish: you are getting pubkey issues when you try to checkout from gerrit?
[00:50:20] <OuKB>	 grrrr, time to sleep for me
[00:50:57] <jcmish>	 awjr just did a quick git pull
[00:51:03] <preilly>	 jcmish: try to run staging:/mnt/p/core/extensions/update-local-extensions.sh
[00:51:03] <jcmish>	 to see if it would blow up
[00:51:32] <awjr>	 jcmish: alternatively do an anonymous checkout
[00:51:46] <jcmish>	 gotcha
[00:52:28] <awjr>	 gah you guys are messing up my testing
[00:53:04] <jcmish>	 hahahha
[00:53:23] <jcmish>	 awjr that's "enhancing" your testing
[00:53:30] <awjr>	 chaos monkey!
[00:53:38] <jcmish>	 yup
[00:58:59] <gerrit-wm>	 New review: awjrichards; "This particular changeset looks ok, but the formatting of the message seems off to me - Jon, I'll se..." [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/30187
[00:58:59] <gerrit-wm>	 Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30187
[01:00:37] * tfinc  wonders why jcmish isn't with us on 6

[01:01:04] <jcmish>	 tfinc
[01:01:05] <jcmish>	 I didn't realize it was going on
[01:01:14] <jcmish>	 then I was going to sneak out
[01:01:19] <jcmish>	 :D but now you know
[01:01:33] <tfinc>	 jcmish: do you have a keycard to come up?
[01:01:39] <jcmish>	 i left it at the hotel :D
[01:01:56] <tfinc>	 i'll come grab you
[01:02:02] <jcmish>	 k
[01:05:20] <gerrit-wm>	 New review: awjrichards; "Actually, just filed a bug: https://bugzilla.wikimedia.org/show_bug.cgi?id=41613" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30187
[01:22:38] <wikipedia-github>	 [WikipediaMobile] yuvipanda pushed 3 new commits to master: http://git.io/0M0Z9A
[01:22:38] <wikipedia-github>	 WikipediaMobile/master 412f946 YuviPanda: Updated CHANGELOG
[01:22:38] <wikipedia-github>	 WikipediaMobile/master 3a953c0 YuviPanda: Give CHANGELOG appropriate markdown formatting :)
[01:22:38] <wikipedia-github>	 WikipediaMobile/master a7b9877 YuviPanda: Merge branch 'master' of github.com:wikimedia/WikipediaMobile
[01:22:52] <mw-jenkinsbot>	 Project WikipediaMobile - Nightly builds build #447: SUCCESS in 9.9 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/447/
[01:22:52] <mw-jenkinsbot>	 * yuvipanda: Updated CHANGELOG
[01:22:52] <mw-jenkinsbot>	 * yuvipanda: Give CHANGELOG appropriate markdown formatting :)
[01:23:35] <yuvipanda>	 aah, much better formatting for the changelog
[09:09:02] <gerrit-wm>	 New patchset: MaxSem; "Secure links to Meta" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31195
[11:59:42] <wm-bot>	 [bugs] NEW [Bug 41629] the message mobile-frontend-on (and -off) is recycled and causes incorrect translations (priority: Unprioritized severity: normal) https://bugzilla.wikimedia.org/show_bug.cgi?id=41629
[12:11:18] <wm-bot>	 [bugs] NEW [Bug 41569] Stop parsing HTML twice (priority: Unprioritized severity: major) https://bugzilla.wikimedia.org/show_bug.cgi?id=41569
[14:39:26] <wm-bot>	 [bugs] UNCONFIRMED [Bug 41636] Nearby only waits 10 seconds (priority: Unprioritized severity: critical) https://bugzilla.wikimedia.org/show_bug.cgi?id=41636
[16:45:38] <preilly>	 MaxSem: do you have a fix for https://gerrit.wikimedia.org/r/#/c/27773/
[16:48:29] <MaxSem>	 preilly, I worked for some time on creation of a system that would share code and cache between normal and API views, but found it not quite doable. guess I need to try to do it in a less ambitious way soon
[16:49:51] <MaxSem>	 not doing it today cause it's my research time
[17:06:44] <MaxSem>	 hey jdlrobson - I'm working on presentational tags cleanup in core in my research time
[17:06:53] <jdlrobson>	 \o/ MaxSem
[17:06:56] <MaxSem>	 I have questions
[17:06:58] <jdlrobson>	 that will be awesome :)
[17:07:35] <jdlrobson>	 http://www.w3.org/TR/html5-diff/#obsolete-elements < MaxSem assume that will help
[17:08:05] <MaxSem>	 <font size="12"> obviously translates to <span style="font-size: 12;'>
[17:08:29] <MaxSem>	 but what about <font size="+1">?
[17:09:04] <jdlrobson>	 so MaxSem personally I'd prefer we scrubbed these all together.. or at the very least replaced them with a class and put these styles through resourceloader
[17:09:52] <Krinkle|detached>	 I thought that feature partially in core already, and nominated for removal?
[17:10:30] <MaxSem>	 jdlrobson, that would not be accepted for core in the foreseeable future, so let's set achievable targets;)
[17:10:52] <MaxSem>	 Krinkle, details?
[17:11:44] <Krinkle>	 MaxSem: The feature caused too many troubles (impossible to convert them to non-obsolete tags without changing the looks somewhat, or breaking css selectors, or requiring changing all children of an element (such as align=center))
[17:12:03] <Krinkle>	 MaxSem: afaik the discussion ended with: OK, not worth changing, they work fine in browsers anyway, no need to follow the spec, what is the gain in doing this?
[17:12:45] <MaxSem>	 then why do we have fixDeprecatedAttributes()?
[17:20:01] <MaxSem>	 Krinkle, ^^
[17:20:24] <Krinkle>	 There is an open bug to remove the configuration var and the code it toggles.
[17:20:24] <Krinkle>	 milestoned 1.20
[17:20:29] <Krinkle>	 because it is a 1.20 regression
[17:21:07] <Krinkle>	 https://bugzilla.wikimedia.org/show_bug.cgi?id=40329
[17:21:08] <Krinkle>	 https://bugzilla.wikimedia.org/show_bug.cgi?id=40632
[17:44:04] <MaxSem>	 hmm, would it still be helpful to do transformations that have no chance of breakage, e.g. <tt> --> <code>?
[17:47:33] <Krinkle>	 Maybe, but I'd recommend discussing that first. And of course in core, not from MobileFrontend.
[17:47:47] <Krinkle>	 tt>core seems reasonable, though there is a difference
[17:48:13] <Krinkle>	 <code> is usually used for small citations of actual code (wrapped in a shaded inline block)
[17:48:23] <Krinkle>	 <tt> only sets the font.
[17:48:40] <Krinkle>	 and it means css/javascript selectors of course.
[17:48:55] <Krinkle>	 and what is the gain of doing that exactly? Why this sudden urge :)
[17:52:04] <MaxSem>	 Krinkle, cuz jdlrobson has a sudden urge of filtering this stuff in MF - I;d rather see it done properly
[17:52:18] <MaxSem>	 well, as proper as possible;)
[17:52:32] <Krinkle>	 Mobile browsers can't handle <tt>?
[17:52:51] <Krinkle>	 If any browser, I'd expect mobile to keep supporting those. As all others.
[17:53:16] <Krinkle>	 oh, nice new doxygen pages: https://svn.wikimedia.org/doc/classTestFileIterator.html
[17:54:26] <MaxSem>	 mmm, too much blue for my liking:P
[17:55:54] <Krinkle>	 yeah, the header is pretty tall too.
[17:56:00] <Krinkle>	 But better then the old one I suppose.
[17:56:07] <Krinkle>	 at least we have permalinks and no frames.
[18:05:25] <preilly>	 jdlrobson: ping
[18:05:34] <jdlrobson>	 preilly: pong
[18:05:41] <preilly>	 jdlrobson: pm
[18:06:39] <preilly>	 rmoen: ping
[18:07:11] <rmoen>	 preilly: sup ?
[18:07:17] <preilly>	 rmoen: pm
[18:07:21] <brion>	 tfinc: we are in position. let the package go when ready
[18:11:16] <tfinc>	 brion: excellent
[18:11:21] <tfinc>	 brion: are you at the metrics meeting ?
[18:11:29] <brion>	 i'm at my desk watching it on youtube
[18:11:33] <tfinc>	 lolz
[18:11:43] <brion>	 3rd floor's nice and quiet except for construction noise :)
[18:11:59] <yuvipanda>	 +1 for technology
[18:12:02] <yuvipanda>	 (and laziness)
[18:12:11] * yuvipanda  waves at brion 

[18:12:26] * brion  waves yuvipanda 

[18:13:04] <yuvipanda>	 brion: do look at https://github.com/wikimedia/WikipediaMobile/pull/311 when you've the time. Starting to pseudo-scrub some inline styles :)
[18:13:11] <brion>	 ooh
[18:13:47] <tfinc>	 brion: has there been any change to the apply icon format. suddenly our icon is showing in iTunes connect with a black background
[18:13:58] <brion>	 hmmmm
[18:14:08] <brion>	 tfinc: we had to provide a larger icon iirc
[18:14:11] <brion>	 perhaps it's changed somehow
[18:14:32] <yuvipanda>	 apple changing things without telling people? I bet that never happens
[18:14:41] <Platonides>	 maybe iTunes doesn't support transparency on the icon?
[18:14:46] <tfinc>	 its weird as when i look at the detail (max version) of the icon it looks ok
[18:15:27] <brion>	 tfinc: can you replace that icon with resubmitting everything?
[18:15:36] <brion>	 worst case we can flatten it on a white bg
[18:15:36] <tfinc>	 brion: checking ...
[18:16:36] <tfinc>	 i can update screenshots but the icon looks fixed now that we've uploaded. i'll spend another minute on it but if we can't change it then i'm not going to sweat it
[18:16:48] <tfinc>	 s/fixed/un changable/
[18:17:08] <brion>	 yeah we can push a fix for that later
[18:17:18] <brion>	 the iOS 6 fixes are more important than the icon looking pretty
[18:17:23] <brion>	 hopefully it'll look fine though
[18:17:31] <brion>	 might just be in connect that it's weird
[18:18:07] <preilly>	 brion: new version of iOS is out
[18:18:17] <brion>	 fuck. 6.0.1?
[18:18:27] <tfinc>	 i can't find an option to update it
[18:19:11] <tfinc>	 is there any reason why i shouldn't release it ?
[18:19:25] <brion>	 speak now or forever hold your peac
[18:19:28] <tfinc>	 :)
[18:19:47] <preilly>	 no reason that I can see
[18:19:54] <brion>	 pull ze trigger
[18:19:54] <brion>	 push zee button
[18:19:57] <tfinc>	 then i'm releasing
[18:20:00] <brion>	 \o/
[18:20:01] <tfinc>	 brion: go ahead and tweet about it
[18:21:40] <MaxSem>	 mmm, mobile edits don't seem to be really coming: https://en.wikipedia.org/w/index.php?title=Special:RecentChanges&tagfilter=mobile+edit
[18:23:31] <MaxSem>	 jdlrobson, might that ^^^ be caused by https://bugzilla.wikimedia.org/show_bug.cgi?id=41570 ?
[18:24:04] <jdlrobson>	 MaxSem: no.. I think it's just because it's been kept low key
[18:24:13] <jdlrobson>	 it will be interesting to watch
[18:27:02] <brion>	 tfinc: i dropped a tweet from my account; i'll do one from @WikimediaMobile when i see the update in itunes
[18:27:08] <tfinc>	 brion: thanks
[18:27:19] * tfinc  hates releasing to the iTunes market

[18:27:36] <brion>	 yeah it's a fun game of waiting
[18:27:46] <tfinc>	 i hate releasing a build that has to be specially created for the store that *no* one else can test
[18:27:54] <tfinc>	 i hate not being able to roll forward or backwards as needed
[18:28:00] <tfinc>	 i hate how long everything takes
[18:28:09] <tfinc>	 i pretty much hate everything from the developer perspective
[18:28:15] <tfinc>	 its great from the user though
[18:28:16] <gerrit-wm>	 New patchset: Jdlrobson; "when watch an article notify the user what happened" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31293
[18:28:17] <gerrit-wm>	 New patchset: Jdlrobson; "rename mf-references to mf-notification" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31294
[18:28:17] <gerrit-wm>	 New patchset: Jdlrobson; "lift and shift css from mf-references to mf-navigation" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31295
[18:28:17] <gerrit-wm>	 New patchset: Jdlrobson; "rearrange notification css to make better use of less" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31296
[18:28:17] <tfinc>	 new pretty shiny
[18:28:17] <gerrit-wm>	 New patchset: Jdlrobson; "remove transitions from references" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31297
[18:28:28] <brion>	 it's only great for the user when fixes get out on time :P
[18:28:58] <tfinc>	 "The following app has been approved. The status has changed to Ready for Sale."
[18:29:50] <yuvipanda>	 jdlrobson: are you moving css for the references from mf-references to mf-navigation?
[18:29:56] * yuvipanda  looks at patchset

[18:31:02] <yuvipanda>	 looks like :(
[18:33:02] <jdlrobson>	 yuvipanda: yup
[18:33:02] <jdlrobson>	 it's becoming more generic
[18:33:17] <jdlrobson>	 watching articles now needs to make use of notifications
[18:33:21] <yuvipanda>	 okay!
[18:33:24] <yuvipanda>	 makes sense
[18:33:30] <Maryana>	 query: the work in this card is already done, right? https://mingle.corp.wikimedia.org/projects/mobile/cards/248
[18:33:31] <jdlrobson>	 and the references code has been refactored to make it more reusable
[18:33:36] <tfinc>	 brion: iPad Mini http://www.fedex.com/Tracking?action=track&language=english&cntry_code=us&initial=x&tracknumbers=485106425234 :)
[18:33:47] <jdlrobson>	 Maryana: don't think so
[18:33:59] <brion>	 awesome
[18:33:59] <Maryana>	 i don't see the "more"
[18:34:03] <jdlrobson>	 mm
[18:34:03] <brion>	 just in time for me to not see it before i fly out :)
[18:34:03] <yuvipanda>	 jdlrobson: can you poke me if you make major changes to refs or toggle in the future? I'll watch gerrit too, but still..
[18:34:05] <Maryana>	 not sure about the margin change
[18:34:08] * jdlrobson  looks

[18:34:28] <jdlrobson>	 it looks done yesterday
[18:34:33] <jdlrobson>	 *it looks done yes
[18:34:37] <jdlrobson>	 i did the margin
[18:34:42] <Maryana>	 sweet
[18:34:44] <jdlrobson>	 the footer seems to have been fixed and the story not updated
[18:34:44] <jdlrobson>	 grre
[18:34:48] <Maryana>	 heh
[18:35:00] * Maryana  will fix that

[18:35:40] <jdlrobson>	 ahh wait a minute Maryana
[18:35:58] <jdlrobson>	 the more and less text is still there just hidden for some reason
[18:36:00] <jdlrobson>	 haha
[18:36:08] <Maryana>	 lol wut
[18:36:10] <jdlrobson>	 let me just remove that
[18:36:22] <Maryana>	 ok, thanks :)
[18:38:50] <brion>	 "Note that it may take up to 24 hours before your app is live on the App Store. This delay is dependent upon any app availability issues." urrrgggh
[18:39:19] <gerrit-wm>	 New patchset: Jdlrobson; "remove more/less from footer" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31298
[18:39:20] <jdlrobson>	 Maryana: now it's done ^
[18:39:41] <brion>	 https://itunes.apple.com/us/app/wikipedia-mobile/id324715238 <- ok i see it updated now
[18:39:53] <Maryana>	 sweet. thanks, jdlrobson
[18:39:53] <brion>	 and yes we have a black background, it looks kinda icky. meh we'll worry about it later.
[18:40:02] <jdlrobson>	 Maryana: can you move back into ready for testing and attach https://gerrit.wikimedia.org/r/31298
[18:40:47] <Maryana>	 ok, will do
[18:44:23] <brion>	 ok posted https://twitter.com/WikimediaMobile/status/264075311740747776
[18:45:10] <MaxSem>	 awjr, hey - how are you?
[18:45:13] <brion>	 the black bg shows in app store on phone too: http://imgur.com/V1ec5
[18:45:23] <brion>	 but once installed the icon is fixed
[18:45:40] <awjr>	 hi MaxSem, i'm OK but i have to go back again tomorrow :(
[18:46:54] <tfinc>	 brion: send heatherw a request for a bigger icon
[18:47:06] <brion>	 k
[18:47:16] <heatherw>	 which? :)
[18:48:00] <heatherw>	 brion I should also give you the vector file
[18:48:13] <brion>	 ooh that'd be handy
[18:48:31] <brion>	 heatherw: the large iTunes icons, as it turns out, doesn't like transparency very much
[18:48:42] <brion>	 https://itunes.apple.com/us/app/wikipedia-mobile/id324715238 <- shadow turns into a big black border
[18:48:56] <heatherw>	 interesting
[18:49:05] <brion>	 we need to either flatten it on a white background or make a bg that's just flat white i guess
[18:49:38] <Maryana>	 psst, speaking of icons, does anybody know where to find the desktop watchlist icon?
[18:49:39] <heatherw>	 the shading inside the icon works….
[18:49:57] <heatherw>	 i gave stars to jon
[18:50:14] <Maryana>	 ok, cool
[18:50:25] <jdlrobson>	 yeyyy stars
[18:50:30] <heatherw>	 if we need different coloring i can do that
[18:50:32] <preilly>	 heatherw: I need some icons from you — is that possible?
[18:50:32] <heatherw>	 ;P
[18:50:52] <heatherw>	 preilly: that kind of depends on what they are :D
[18:50:57] <heatherw>	 (yes)
[18:51:22] <preilly>	 I need 16, 48 and 128 pixel icons for the Wikipedia Firefox OS application
[18:51:39] <preilly>	 preferably in PNG format
[18:52:07] <preilly>	 heatherw: ^^ they can just be the same as the other apps icons
[18:52:27] <heatherw>	 launch icon?
[18:52:48] <heatherw>	 no problem, i should already have that
[18:53:02] <preilly>	 heatherw: okay great
[18:53:17] <preilly>	 heatherw: can you email them to me at preilly@wikimedia.org
[18:53:19] <preilly>	 heatherw: thanks, so much
[18:53:36] <heatherw>	 yes preilly, no problem
[19:05:23] <gerrit-wm>	 Change merged: MaxSem; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31068
[19:07:16] <MaxSem>	 preilly, are you still running the import on staging?
[19:20:38] <wikipedia-github>	 [WikipediaMobile] brion pushed 4 new commits to master: http://git.io/t8qMLg
[19:20:38] <wikipedia-github>	 WikipediaMobile/master 60131bb YuviPanda: Update to work with latest MobileFrontend
[19:20:38] <wikipedia-github>	 WikipediaMobile/master 36c76d6 YuviPanda: Make initContentHandler take a jQuery element, not a selector
[19:20:38] <wikipedia-github>	 WikipediaMobile/master 1e7a677 YuviPanda: Pseudo-scrub inline styles for tables...
[19:20:47] <yuvipanda>	 woohoo
[19:21:03] <mw-jenkinsbot>	 Project WikipediaMobile - Nightly builds build #448: SUCCESS in 14 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/448/
[19:21:04] <mw-jenkinsbot>	 * yuvipanda: Update to work with latest MobileFrontend
[19:21:04] <mw-jenkinsbot>	 * yuvipanda: Make initContentHandler take a jQuery element, not a selector
[19:21:05] <mw-jenkinsbot>	 * yuvipanda: Pseudo-scrub inline styles for tables
[19:21:10] <yuvipanda>	 brion: also https://github.com/wikimedia/WikipediaMobile/pull/309
[19:21:16] <yuvipanda>	 ?
[19:21:54] <brion>	 hmm
[19:21:58] <brion>	 does… that work?
[19:22:07] <brion>	 dynamically changing <base href> sounds like trouble
[19:44:46] <yuvipanda>	 brion: it does
[19:44:46] <yuvipanda>	 work
[19:45:05] <yuvipanda>	 brion: that's the only way I could see to make the css load images from the proper path
[19:45:18] <yuvipanda>	 brion: plus we change it dynamically every time we switch language :P
[19:45:37] <brion>	 images from css are supposed to be based against the CSS location, why does the <base href> matter?
[19:45:58] <yuvipanda>	 brion: because we're loading the css as html inside a <style>
[19:46:04] <brion>	 ahh
[19:46:27] <brion>	 but shouldn't it switch the images back once we've changed the base href again?
[19:46:31] <yuvipanda>	 brion: ah, no it doesn't!
[19:46:41] <brion>	 well… that sounds like a browser engine bug
[19:46:58] <brion>	 any reason not to use a <link rel=stylesheet> here?
[19:47:54] <yuvipanda>	 hmm, I was just reusing the code from mobile site css
[19:48:08] <yuvipanda>	 also I'm not sure if removing the stylesheet would rid it of it's effects
[19:48:14] <yuvipanda>	 though that seems something more dependable than base URL munging
[19:48:40] <tfinc>	 jdlrobson: http://www.youtube.com/watch?v=44kbjnoTe28&feature=youtu.be is hilarious
[19:49:08] <jdlrobson>	 :)
[19:49:23] <jdlrobson>	 ensure you have sound
[19:49:27] <jdlrobson>	 it just looks weird otherwise
[19:49:27] <brion>	 and that's why we don't drop acid before the meeting
[19:49:33] <yuvipanda>	 it's almost as awesome as his karaoke videos
[19:49:52] <yuvipanda>	 okay, more awesome
[19:50:10] <awjr_lunch>	 aaaand that is definitely going on the bash page
[19:53:32] <MaxSem>	 aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
[19:53:41] <MaxSem>	 this is soooooooooo psychedelic!
[19:54:24] <awjr_lunch>	 incidentally, that video starts right about when i got back from the dentist and started watching the metrics meeting. for a second i thought it was the medication
[19:54:40] <MaxSem>	 make it publicly visible, and let it become a meme;)
[19:54:47] <jdlrobson>	 haha awjr_lunch
[19:54:47] <yuvipanda>	 +1
[19:55:19] <jdlrobson>	 i started tripping when they did the videos
[19:55:24] <jdlrobson>	 and then it stopped during sue's talk
[19:55:34] <jdlrobson>	 i'm not sure what was in my english breakfast tea
[19:57:01] <brion>	 :)
[19:58:47] <gerrit-wm>	 New patchset: Jdlrobson; "update qqq code" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31306
[19:58:47] <gerrit-wm>	 New patchset: Jdlrobson; "remove mobile-frontend-toggle-images key" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31307
[20:10:14] <gerrit-wm>	 New review: MaxSem; "In general, repurposing messages like this could result in some translations being updated and some ..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/31306
[20:11:34] <gerrit-wm>	 New patchset: Jdlrobson; "add margin for nested lists (bug 41543)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31313
[20:12:08] <wm-bot>	 [bugs] NEW [Bug 41543] Missing indentation for lists (priority: Unprioritized severity: normal) https://bugzilla.wikimedia.org/show_bug.cgi?id=41543
[20:18:43] <wm-bot>	 [bugs] NEW [Bug 40318] Special:UserLogin broken in MobileFrontend (priority: Unprioritized severity: normal) https://bugzilla.wikimedia.org/show_bug.cgi?id=40318
[20:19:25] <jdlrobson>	 tfinc: MaxSem what's the state of https://bugzilla.wikimedia.org/show_bug.cgi?id=37281 ?
[20:19:48] <MaxSem>	 jdlrobson, I'd like a small discussion
[20:20:00] <tfinc>	 i put everything i knew into the bug
[20:20:46] <MaxSem>	 I can vaguely see the point of limiting redirection to /wiki/ - as it's not needed fro stuff like favicon
[20:21:07] <MaxSem>	 maybe redirect /wiki/ and /w/index.php A?
[20:21:13] <MaxSem>	 s/A//
[20:21:19] <awjr_lunch>	 MaxSem: i would double check with asher
[20:21:49] <awjr_lunch>	 iirc there is a legitimate reason for it, but i cannot remember what it is
[20:23:58] <wm-bot>	 [bugs] ASSIGNED [Bug 33958] Random button in app (priority: Unprioritized severity: enhancement) https://bugzilla.wikimedia.org/show_bug.cgi?id=33958
[20:24:18] <jdlrobson>	 I think we either need to close the bug as WONTFIX or do the redirection. I'm not bothered either way
[20:24:41] <jdlrobson>	 tfinc: were we getting lots of mobile traffic to that page?
[20:25:00] <MaxSem>	 Asher's not around, unfortunately
[20:25:02] <tfinc>	 jdlrobson: i don't know. we'd need to ask ops about that
[20:25:15] <tfinc>	 why is asher the only person we can ask?
[20:25:46] <tfinc>	 ask mark/faidon/daniel/ct etc
[20:25:47] <awjr_lunch>	 MaxSem: actually i think i might be confusing the issue with something else relating to index.php and/or main page rediection
[20:29:00] <awjr_lunch>	 tfinc the reason im suggesting asher is because he was the one who explained all of that to me back when i joined the mobile team. a lot of the mobile-specific configuraiton for this stuff seemed rather peculiar/specialized for mobile and im unsure of other folks' level of knowledge around it.  preilly would be my next guess of someone knowledgeable about it, but would otherwise ping ops in the hopes that someone else understands how it a
[20:29:56] <awjr_lunch>	 hopefully someone else knows!
[20:30:25] <tfinc>	 awjr_lunch: got it. thats a huge single point of failure for us then. scary
[20:30:40] <MaxSem>	 yeah, Asher is the main POC for mobile/Varnish voodoo
[20:30:53] <awjr_lunch>	 tfinc yeah, i mean it might not actually be a single point of failure but im just not sure who else is familiar with that stuff
[20:31:36] <awjr_lunch>	 LeslieCarr and mutante have often helped out with other mobile/varnish related stuff but i do not think their knowledge about the setup is very deep
[20:37:52] <gerrit-wm>	 New patchset: Jdlrobson; "avoid printing empty lists (bug 41458)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31315
[20:38:05] <wm-bot>	 [bugs] REOPENED [Bug 41458] List of languages incomplete (priority: Unprioritized severity: normal) https://bugzilla.wikimedia.org/show_bug.cgi?id=41458
[20:46:12] <gerrit-wm>	 New patchset: Jdlrobson; "add the word beta to the search placeholder" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31316
[20:53:49] <mw-jenkinsbot>	 Project WikipediaMobile - Nightly builds build #449: SUCCESS in 9.9 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/449/
[20:53:49] <mw-jenkinsbot>	 Brion VIBBER: Replace 1024px version of tranparent icon with flattened version for iTunes App Store
[20:53:52] <brion>	 tfinc: ok use this image: https://raw.github.com/wikimedia/WikipediaMobile/master/scratch/logo-itunes.png
[20:55:15] <brion>	 i'll make a 3.2.2 branch
[20:57:14] <tfinc>	 k
[20:57:46] <wikipedia-github>	 [WikipediaMobile] brion created v3.2.2-iOS (+1 new commit): http://git.io/-eq2mw
[20:57:46] <wikipedia-github>	 WikipediaMobile/v3.2.2-iOS 73568b9 Brion Vibber: Bump to v3.2.2 for iOS
[20:57:50] <brion>	 tfinc: ok v3.2.2-iOS branch pushed with the build number updated and no other changes
[20:57:57] <mw-jenkinsbot>	 Project WikipediaMobile - Nightly builds build #450: SUCCESS in 10 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/450/
[20:58:12] <tfinc>	 brion: k
[21:00:20] <tfinc>	 i'll build the new ipa in the afternoon
[21:00:33] <brion>	 whee
[21:00:52] <preilly>	 heatherw: ping
[21:01:04] <heatherw>	 preilly: yes?
[21:01:44] <heatherw>	 (coming up)
[21:02:22] <preilly>	 heatherw: just checking on icons
[21:02:41] <heatherw>	 k
[21:07:50] <brion>	 gonna grab some lunch, brb
[21:14:48] <jdlrobson>	 tfinc: did MaxSem show you https://en.wikipedia.org/w/index.php?title=Special:RecentChanges&tagfilter=mobile+edit ? pretty cool we can filter now.
[21:15:16] <jdlrobson>	 Finding the 2 edits very interesting as they show us micro edits are indeed the norm so far
[21:16:10] <tfinc>	 jdlrobson: i hadn't seen this yet. this is great MaxSem
[21:16:43] <MaxSem>	 jdlrobson, this is an interim hack while we're developing a more proper solution. let me know if you change the [Via Mobile] tag - it is used for tagging
[21:17:34] <jdlrobson>	 MaxSem: sure - I'm unlikely to change [Via Mobile] and currently there is no i18n
[21:17:40] <jdlrobson>	 (on purpose)
[21:18:04] <jdlrobson>	 MaxSem: is this en wikipedia only
[21:18:11] <jdlrobson>	 is there a way to see across languages/projects
[21:18:30] <MaxSem>	 yes, no:P
[21:18:43] <jdlrobson>	 :)
[21:19:06] <MaxSem>	 ideally, we should conococt something in MF for logging
[21:22:24] <jdlrobson>	 MaxSem: +1
[21:24:48] <wm-bot>	 [bugs] NEW [Bug 41662] Break the site (Chrome Desktop) (priority: Unprioritized severity: normal) https://bugzilla.wikimedia.org/show_bug.cgi?id=41662
[21:26:06] <jdlrobson>	 Maryana: I'm confused by the existence of https://mingle.corp.wikimedia.org/projects/mobile/cards/249
[21:26:58] <heatherw>	 jdlrobson: do you need new watchlist stars or are you good with what you have?
[21:27:04] <jdlrobson>	 not that i know of heatherw
[21:27:06] <jdlrobson>	 i think i'm good..
[21:27:12] <heatherw>	 cool
[21:27:12] <jdlrobson>	 unless Maryana disagrees?
[21:27:21] <Maryana>	 design felt that the icon for the watchlist should look and feel like the one on the desktop, so i added that card so that we could attach watchlist star assets to it
[21:27:48] <Maryana>	 jdlrobson ^
[21:28:15] <jdlrobson>	 Maryana: I'd rather this got parked for a future iteration
[21:28:24] <jdlrobson>	 I feel like this needs more discussion
[21:28:27] <heatherw>	 jdlrobson: Maryana it won't have the same shaded light blue when made solid, so if you want another flat color let me know.
[21:28:28] <jdlrobson>	 I have issues with existing desktop icons
[21:28:38] <jdlrobson>	 heatherw: it's now pure black
[21:28:40] <jdlrobson>	 or just an outline
[21:28:41] <jdlrobson>	 	
[21:28:45] <heatherw>	 hmm black :)
[21:28:56] <jdlrobson>	 http://staging.wmflabs.org/wiki/Main%20Page
[21:29:06] <Maryana>	 ok, yeah, it sounds like we're all on different pages w/this one
[21:29:06] <jdlrobson>	 (you'll need to login and opt into beta)
[21:29:20] <jdlrobson>	 Maryana: throw it out of the iteration! Avoid the confusion! :D
[21:29:28] <Maryana>	 np
[21:29:57] <Maryana>	 moved to backlog
[21:30:47] <jdlrobson>	 thanks :)
[21:31:09] <jdlrobson>	 ps. I really really really want a heart for watching articles.. I know wikilove makes this difficult but I really think it is the right thing
[21:31:44] <jdlrobson>	 Maryana: can you poke vihba to ask for assets for https://mingle.corp.wikimedia.org/projects/mobile/cards/197
[21:31:53] <jdlrobson>	 I need the speech bubble in blue and gray
[21:32:30] <Maryana>	 yep
[21:32:32] <Maryana>	 will do
[21:34:59] <jdlrobson>	 sooner the better as I've started working on it.. :)
[21:38:59] <heatherw>	 jdlrobson: i gave you a star before, a less pokey one than i am currently seeing… but we are tabling a change for now, yes?
[21:40:07] <jdlrobson>	 heatherw: i'm not sure.. i'm confused. I got given another star for some reason
[21:40:11] <Maryana>	 jdlrobson: check yr emailz
[21:40:35] <Maryana>	 jdlrobson, yeah sorry, we've been flooding you with stars
[21:40:49] <heatherw>	 STARFLOOD
[21:45:07] <jdlrobson>	 Maryana: can you get vibha on irc - might make this easier
[21:45:21] <jdlrobson>	 icon she sent me was different to one I was expecting
[21:46:21] <Maryana>	 we're gonna come down in a sec
[21:47:14] <jdlrobson>	 cough https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/MobileFrontend,n,z
[21:47:31] <jdlrobson>	 in particular I could do with some review on https://gerrit.wikimedia.org/r/#/c/30905/  and https://gerrit.wikimedia.org/r/#/c/30906/ < awjr brion MaxSem
[21:47:43] <awjr>	 jdlrobson: happy to take a look shortly
[21:48:12] * yuvipanda  gives jdlrobson an Alpha Centauri 

[21:48:19] <jdlrobson>	 yuvipanda: you too
[21:48:26] <jdlrobson>	 you can +1 :P
[21:48:26] <heatherw>	 brion: are you here
[21:48:30] <brion>	 heatherw: yo
[21:48:59] <heatherw>	 do you need the icon with no shadow? png? what resolution (or SVG)
[21:49:19] <brion>	 heatherw: i've got a flattened version that'll work for now
[21:49:37] <heatherw>	 so you don't need another one
[21:49:38] <brion>	 right
[21:49:39] <brion>	 thanks :D
[21:49:40] <heatherw>	 :)
[21:50:33] <yuvipanda>	 jdlrobson: I sadly lack enough context for pretty much any MF change, so will stay away from that CR for now :(
[21:50:48] <yuvipanda>	 I'm polishing the Commons app so we can take pictures during the events + trips and have them instantly go to commons
[21:51:11] <brion>	 awesome
[21:51:23] * brion  will be using that :)

[21:52:54] <MaxSem>	 jdlrobson, in https://gerrit.wikimedia.org/r/#/c/30905/ there are 2. less files changed, but only 1 .css - is that ok?
[21:53:03] <gerrit-wm>	 New review: Brion VIBBER; "Looks good!" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 2;  - https://gerrit.wikimedia.org/r/30905
[21:53:03] <gerrit-wm>	 Change merged: Brion VIBBER; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30905
[21:53:24] <yuvipanda>	 brion: I'm doing the final piece of auth (revalidating tokens when they expire (MaxSem helped with that!)) and once done, I'll add categories. Aaand then we'll be good to go!
[21:53:25] <awjr>	 hahaha MaxSem, brion we are all simultaneously reviewing the same stuff, it seems
[21:53:29] <brion>	 :)
[21:53:39] <MaxSem>	 jdlrobson, altough it's merged I've left a comment
[21:53:41] <jdlrobson>	 MaxSem: that is correct - if you look at https://gerrit.wikimedia.org/r/#/c/30905/1/stylesheets/less/common/mf-typography.less I'm just switching a fixed value to a  variable - output remains same
[21:53:45] <brion>	 MaxSem: mf-typography.less is included in the building, it doesn't make a .css iirc
[21:53:56] <brion>	 oh or that'll do
[21:53:57] <brion>	 yay
[21:54:22] <heatherw>	 brion where would you like me to put an SVG.. commons? mingle?
[21:55:03] <brion>	 heatherw: commons would be awesome :)
[21:55:17] <brion>	 i can import it into source from there but then we can also just use it in pages :D
[21:55:42] <gerrit-wm>	 Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30906
[21:59:56] <heatherw>	 brion: http://commons.wikimedia.org/wiki/File:WP_mobile_launch_icon.svg
[22:00:11] <heatherw>	 (finally)
[22:00:39] <brion>	 awesome thanks :D
[22:02:33] <gerrit-wm>	 Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30178
[22:04:14] <gerrit-wm>	 New patchset: Jdlrobson; "make sure cleanup templates are re-initialised on a dynamic page load" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30289
[22:04:57] <wikipedia-github>	 [WikipediaMobile] brion pushed 1 new commit to master: http://git.io/Q4ABHw
[22:04:57] <wikipedia-github>	 WikipediaMobile/master b477449 Brion Vibber: Add SVG version of logo by Heather Walls (yay)
[22:05:06] <mw-jenkinsbot>	 Project WikipediaMobile - Nightly builds build #451: SUCCESS in 11 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/451/
[22:05:07] <mw-jenkinsbot>	 Brion VIBBER: Add SVG version of logo by Heather Walls (yay)
[22:10:58] <awjr>	 jdlrobson: can you give me a ltitle more context about https://gerrit.wikimedia.org/r/#/c/31032/2 ? i'm not quite clear on what exactly i should be looking for
[22:11:01] * jdlrobson  looks

[22:11:21] <jdlrobson>	 So go to the edit page in beta
[22:11:27] <jdlrobson>	 any page
[22:11:27] <jdlrobson>	 you'll see the same text twice
[22:11:41] <awjr>	 oh yeah, ok i see
[22:11:41] <awjr>	 thanks :)
[22:11:47] <jdlrobson>	 glaringly obvious.. not sure how i sneaked that in
[22:11:49] <jdlrobson>	 thanks
[22:11:55] <jdlrobson>	 gonna speak to Maryananow
[22:14:08] <gerrit-wm>	 Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31032
[22:18:40] <gerrit-wm>	 Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31042
[22:26:04] <yuvipanda>	 wow, the Android doc is a load of lies
[22:26:05] <yuvipanda>	 at least for one method
[22:26:09] <yuvipanda>	 at least it has readable source code
[22:29:30] <gerrit-wm>	 Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31144
[22:38:13] <gerrit-wm>	 New patchset: Jdlrobson; "cleanup ui of cleanup templates" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31339
[22:38:13] <gerrit-wm>	 New patchset: Jdlrobson; "use find rather than children" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31340
[22:43:15] <yuvipanda>	 captchas suck majorly on mobile
[22:43:16] <yuvipanda>	 grrr
[22:43:27] <yuvipanda>	 now i can't test for a while because i don't have captcha handling
[22:44:42] <awjr>	 yuvipanda: true story :(
[22:45:00] <awjr>	 i tent to htink they suck in general, but especially on mobile
[22:45:09] * awjr  needs typing lessons

[22:45:20] <awjr>	 s/tent to htink/tend to think
[22:49:55] <gerrit-wm>	 Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31155
[23:03:39] <gerrit-wm>	 New review: Jdlrobson; "Discovered an unrelated bug in process https://bugzilla.wikimedia.org/show_bug.cgi?id=41666" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 1;  - https://gerrit.wikimedia.org/r/31195
[23:09:19] <preilly>	 tfinc: you should reach out to http://www.linkedin.com/in/steventroughtonsmith
[23:10:14] <jdlrobson>	 ori-l: want to grab coffee?
[23:10:42] <ori-l>	 5 mins?
[23:10:51] <ori-l>	 in 5 mins, rather.
[23:10:56] <ori-l>	 ^ jdlrobson
[23:11:10] <gerrit-wm>	 Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31157
[23:14:05] <jdlrobson>	 yes ori-l
[23:14:14] <jdlrobson>	 poke e when you are ready to go downstairs
[23:24:26] <ori-l>	 someone tell jdlr i'm on my way
[23:24:26] <ori-l>	 heh
[23:24:31] <ori-l>	 <ori-l> someone tell jdlr i'm on my way
[23:37:23] <tfinc>	 preilly: k
[23:39:44] <MaxSem>	 awjr, you've got a potentially unset variable in UserLoginMobileTemplate::execute() if $messageType != 'error'
[23:39:58] <awjr>	 :(
[23:41:26] <MaxSem>	 (I'm not sure what class it should have by default, so not fixing myself)
[23:41:47] <awjr>	 MaxSem: i will investigate shortly
[23:47:24] <gerrit-wm>	 New patchset: MaxSem; "Minor stuff" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31352
[23:49:14] <preilly>	 tfinc: would you like to see the mobile version of wikipedia on ATV2?
[23:49:24] <tfinc>	 sure
[23:50:23] <awjr>	 MaxSem: those vars will always be set by LoginForm::mainLoginForm()
[23:50:54] <MaxSem>	 so what if it's not 'error'?
[23:51:20] <awjr>	 then we dont care :)
[23:52:27] <brion>	 tfinc: checking that about page thing now
[23:52:41] <brion>	 got delayed by a relief bus driver going awol :P
[23:52:41] <MaxSem>	 cause if it's not, Ree/dy will run into this channel and tell us:P
[23:53:23] <brion>	 tfinc: hmm, shows 3.2.2 for me
[23:53:28] <brion>	 you're on v3.2.2-iOS branch right?
[23:54:08] <awjr>	 MaxSem: message type is in the function signature for mainLoginForm, so it will always be to *something*. at the moment, we only care and special case if it's == error
[23:54:55] <MaxSem>	 awjr, if ( $message ) {
[23:54:56] <MaxSem>	 ....
[23:55:04] <MaxSem>	 if ( $messageType == 'error' ) {
[23:55:09] <MaxSem>	 $class = 'error alert';
[23:55:17] <MaxSem>	 }
[23:55:18] <MaxSem>	 $msgBox .= Html::openElement( 'div', array( 'class' => $class ) );
[23:55:46] <MaxSem>	 what happens if $messageType != 'error'
[23:56:00] <awjr>	 oh you're talking about $class not necessarily getting set
[23:56:23] <awjr>	 i guess $heading is problematic too
[23:56:35] <awjr>	 oh no it's not, it gets set
[23:57:11] <awjr>	 ok i see what you mean, sorry i thought you were saying $messageType might not get set
[23:57:17] <awjr>	 good catch, i'llf ix it