[00:09:50] <wm-bot>	 [bugs] NEW [Bug 41669] document.getElementById("results") is null (priority: Unprioritized severity: normal) https://bugzilla.wikimedia.org/show_bug.cgi?id=41669
[00:10:00] <MaxSem>	 jdlrobson, ^^^
[00:11:09] <gerrit-wm>	 New patchset: awjrichards; "Ensure that there is no potential for $class to be an unset var" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31355
[00:11:26] <awjr>	 MaxSem: ^
[00:12:16] <gerrit-wm>	 Change merged: MaxSem; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31355
[00:24:34] <gerrit-wm>	 New review: awjrichards; "Why not do that check along with " [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/31315
[00:28:27] <gerrit-wm>	 Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31316
[00:54:01] <gerrit-wm>	 Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31195
[00:59:07] <gerrit-wm>	 Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31352
[15:42:47] <gerrit-wm>	 New patchset: Jdlrobson; "remove left padding on overlay list items" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31388
[16:43:24] <yuvipanda>	 MaxSem: is there any way for me to invalidate a user token without changing my password?
[16:43:29] <yuvipanda>	 (or logging out)
[16:44:13] <MaxSem>	 log in;)
[16:45:57] <jdlrobson>	 mmm since when did DeviceDetection get moved to core?
[16:46:17] <jdlrobson>	 well why rather.. Ic7bbeba746ea37a92c1df5dbaa1fb4fd08da130c
[16:47:37] <yuvipanda>	 MaxSem: nothing I can do on another session?
[16:47:40] <MaxSem>	 jdlrobson, we had plans of merging MF with core
[16:47:52] <yuvipanda>	 hmm, I could change the password and changing it back!
[16:48:04] <jdlrobson>	 just left me very confused as i couldn't work out why my changes to DeviceDetection.php were having no effect
[16:48:10] <jdlrobson>	 guess DeviceDetection.php should be removed now?
[16:48:11] <MaxSem>	 yuvipanda, I don't think there's a function to change session ID around
[16:48:21] <jdlrobson>	 (from MobileFrontend)
[16:48:25] <yuvipanda>	 MaxSem: it'll invalidate it if I change my password, right/
[16:48:27] <yuvipanda>	 ?
[16:49:10] <MaxSem>	 jdlrobson, nope - the migration has been stashed to say the least. our local copy now takes precendence
[16:49:11] <jdlrobson>	 doesn't for me..
[16:49:15] <jdlrobson>	 :(
[16:49:49] <jdlrobson>	 can we remove from core? As the existence of two is very very confusing
[16:50:01] <jdlrobson>	 and the one in core is out of date
[16:50:43] <MaxSem>	 aieeee
[16:50:54] <MaxSem>	 the override shouldn't work indeed
[16:52:02] <MaxSem>	 jdlrobson, I agree with this - let's discuss this with Arthur and move on
[16:52:08] <jdlrobson>	 ok is arthur around at all today?
[16:52:59] <MaxSem>	 yuvipanda, just log off/on
[16:53:07] <jdlrobson>	 This explains why certain browsers are getting crappy versions of the site~
[16:56:13] <yuvipanda>	 MaxSem: mm, I'll try it out
[16:56:14] <yuvipanda>	 !
[17:00:59] <jdlrobson>	 MaxSem: do you know the hangout url?
[17:01:09] <MaxSem>	 https://plus.google.com/hangouts/_/8bc98160cdf0396821e2ba381099b56fde42cb0c#
[17:01:24] <MaxSem>	 isn't it on your calendar?
[17:02:48] <MaxSem>	 oh, Tomasz is gonna miss it
[17:04:09] <MaxSem>	 okay, evderyone missed the standup except for me
[17:04:18] * MaxSem  reports to himself

[17:06:34] <jdlrobson>	 tfinc: standup?
[17:06:42] <jdlrobson>	 : https://plus.google.com/hangouts/_/8bc98160cdf0396821e2ba381099b56fde42cb0c#
[17:07:37] * yuvipanda  notes the natural progression of ori-l 

[17:14:57] <yuvipanda>	 tfinc: subway shut down due to medical emergency? Sounds like the beginning of a zombie apocalypse.
[17:23:17] <MaxSem>	 yuvipanda, in Russia that usually means that someone jumped under the train
[17:24:04] <tfinc>	 yuvipanda: agreed
[17:25:27] <ori-l>	 MaxSem: in SF, train jumps under you.
[17:26:07] <ori-l>	 </offensive></lame></cheesy> ok! my job is done here. bye
[17:34:55] <tfinc>	 MaxSem: do we need our monday/tuesday windows ?
[17:41:24] <tfinc>	 MaxSem: besides niklas is there anyone else that can review the changes that you have for GeoData ?
[17:46:32] <MaxSem>	 tfinc, so far we need both windows. if we get better at preparing bug-free code for deployments, we could give away one of them
[17:46:44] <tfinc>	 MaxSem: k
[17:50:44] <MaxSem>	 tfinc, the problem with it is that nobody here appears to have experience with large-scale Solr installations. in theory, Peter is our search engineer so I've added him as a reviewer to operations commits
[17:51:25] <tfinc>	 MaxSem: ok. that makes sense. worst case we get Brion and yuvipanda to corner niklas at the language summit
[17:52:27] <MaxSem>	 bad thing that no op will be around, to discuss more practical aspects of deployment:)
[17:52:58] <tfinc>	 yes. we'll have to do the leg work on that
[17:53:35] <MaxSem>	 tfinc, in principle, Niklas has +1'd the remaining puppet change, but he didn't sound confident
[17:55:58] <yuvipanda>	 hey tfinc
[17:56:01] <yuvipanda>	 I don't have push rights on https://github.com/wikimedia/commons
[17:56:15] <tfinc>	 yuvipanda: let me fix that for you
[17:56:21] <yuvipanda>	 tfinc: thanks :)
[17:56:33] <tfinc>	 yuvipanda: fixed
[17:56:35] <yuvipanda>	 tfinc: also can you make the github IRC bot push updates to here?
[17:56:44] <yuvipanda>	 commit notifications
[17:58:39] <tfinc>	 yuvipanda: done
[17:59:11] * yuvipanda  pushes and waits for it

[17:59:11] <wikipedia-github>	 [commons] yuvipanda pushed 1 new commit to master: http://git.io/TX34qw
[17:59:11] <wikipedia-github>	 commons/master 11685e5 YuviPanda: (Bug 41703) Validate user tokens & re-login if necessary...
[17:59:14] <yuvipanda>	 woohoo
[17:59:18] <yuvipanda>	 thanks tfinc
[18:06:12] * yuvipanda  wonders what the phrase 'old college try' refers to

[18:06:48] <Maryana>	 haha
[18:07:03] <Maryana>	 i'm actually not sure myself. i just know people used to use it, back in the 1950s
[18:07:15] <Maryana>	 if only there were a repository of human knowledge available freely somewhere...
[18:07:16] <yuvipanda>	 google tells me it is the name of a band
[18:07:31] <yuvipanda>	 Maryana: yup, that'd be Urban Dictionary :P
[18:07:47] <yuvipanda>	 tells me it is 'best shot', which I guess is what you meant
[18:07:47] <Maryana>	 wiktionary: http://en.wiktionary.org/wiki/old_college_try
[18:07:52] <Maryana>	 but that doesn't have the origin
[18:08:04] <yuvipanda>	 UD also says 'To gather your friends, buy some cheap beer, order a pizza, and forget about tomorrow.'
[18:08:43] <Maryana>	 ahaha
[18:09:08] <Maryana>	 yes, i'd much rather do that than create a JSON file :-P
[18:10:18] <yuvipanda>	 :D
[19:17:07] <preilly>	 tfinc: this is what is left open on the Firefox OS app https://github.com/preillyme/WikipediaMobileFirefoxOS/issues?state=open
[19:20:45] <mutante>	 tfinc: fyi, the display issues i had with the wp app on that Sony tablet, they were gone after upgrading to latest version, so no bug necessary:) (i created "Tablet PC" as a hardware type already anyways:)
[19:22:23] <yuvipanda>	 mutante: what did you run into?
[19:23:37] <mutante>	 yuvipanda: on a Sony Tablet S, with an ancient version of the wp app, it just showed content on like the upper 20% of the display
[19:23:42] <yuvipanda>	 ah
[19:23:53] <mutante>	 but dont worry about it, i did not realize i was still on 1.0 there :o
[19:23:53] <yuvipanda>	 wah
[19:23:55] <yuvipanda>	 that even worked?
[19:23:58] <mutante>	 it did
[19:24:19] <mutante>	 and now it is just fine, using full screen
[19:24:26] <yuvipanda>	 :)
[19:24:43] <yuvipanda>	 I should check in the change to make tablet users not get the mobile version
[19:24:46] <mutante>	 its actually amazing on a tablet screen you can actually read articles
[19:24:51] * yuvipanda  notes to do that soon

[19:25:00] <mutante>	 :)
[19:25:01] <yuvipanda>	 mutante: I know! I got the nexus 7, and things have never been the same since!
[19:25:21] <yuvipanda>	 mutante: you should try the beta version - it has *much* better typography, and even an (experimental) dark mode
[19:25:35] <mutante>	 likes the Sony Tablet but no idea how exotic it actuallzy is, i got it a while ago in Europe
[19:25:40] <yuvipanda>	 and gets much faster updates too
[19:25:57] <yuvipanda>	 play.google.com/store/apps/details?id=org.wikipedia.beta (search for wikipedia beta on play store)
[19:26:04] <yuvipanda>	 </plug>
[19:26:06] <yuvipanda>	 mutante: you're the first person I'm encountering with one
[19:26:07] <mutante>	 cool, i once installed Beta on my phone but not on the tablet yet
[19:26:21] <yuvipanda>	 usually samsung or nexus is what i hear
[19:26:27] <yuvipanda>	 or the local ones (Micromax is incredibly popular here)
[19:26:40] <mutante>	 http://en.wikipedia.org/wiki/Sony_Tablet_S#Hardware
[19:27:14] <mutante>	 heh, the article actually shows it displaying WP :)
[19:27:22] <yuvipanda>	 :D
[19:27:32] <yuvipanda>	 it should show it displaying WP's article on itself
[19:27:47] <mutante>	 it does:)
[19:27:47] <yuvipanda>	 ah, very old mobile wiki
[19:27:52] <yuvipanda>	 ah, just loaded (slow conn)
[19:28:20] <mutante>	 but it does not show the picture of itself in the picture of itself :p
[19:28:53] <yuvipanda>	 mutante: you have the power to fix that
[19:29:09] <mutante>	 i do, but wikidata is addictive already and took all my time, hehe
[19:29:41] * yuvipanda  plots to make mobile addictive

[19:29:58] <mutante>	 mobile app to enter wikidata?:)
[19:30:31] <yuvipanda>	 mutante: mobile app to do uploads?
[19:30:39] <yuvipanda>	 and make uploadcampaigns that you can upload to and 'follow'?
[19:30:47] <mutante>	 sure, that is WLM minus the branding?
[19:31:04] <yuvipanda>	 mutante: nope, that's play.google.com/store/apps/details?id=org.wikipedia.beta
[19:31:04] <yuvipanda>	 err
[19:31:06] <yuvipanda>	 https://www.mediawiki.org/wiki/Commons_Mobile_upload_app
[19:31:20] <yuvipanda>	 native
[19:31:24] <mutante>	 ah, its in beta, gotcha:)
[19:31:36] <mutante>	 ah, ok
[19:31:36] <yuvipanda>	 it's not even in beta, but soon enough!
[19:31:57] <yuvipanda>	 mutante: a bunch of us are going through Inida for a trip soon, and we'll be uploading directly to commons from our phones. Should be fun!
[19:32:11] <mutante>	 awesome!
[19:32:27] <yuvipanda>	 i know! :D
[19:32:46] <mutante>	 do we have a world map with little flashing dots whereever somebody uploads an image?
[19:32:59] <yuvipanda>	 mutante: not yet...
[19:33:00] <yuvipanda>	 we will
[19:33:15] <mutante>	 yay!
[19:33:31] <yuvipanda>	 imagine uploadcampaigns like #sfriots
[19:33:34] <yuvipanda>	 or #wmfHalloween
[19:33:48] <yuvipanda>	 or #hurricaneSomething
[19:33:48] <mutante>	 #sfriots lol, i can contribute to that right away
[19:33:52] <yuvipanda>	 :P
[19:34:04] <mutante>	 i was on Polk St. when the Giants won :o
[19:34:04] <yuvipanda>	 aaaah
[19:34:05] <mutante>	 and have some video
[19:34:09] <yuvipanda>	 it was confusing for us in India
[19:34:13] <mutante>	 of the riot police stepping in
[19:34:23] <yuvipanda>	 usually when the team loses, people pelt the Captain's house with eggs
[19:34:38] <yuvipanda>	 mutante: ah, uploaded?
[19:34:43] <mutante>	 not yet, they are in my personal queue
[19:34:46] <yuvipanda>	 but yeah, uploading video is a mess, with encoding issues
[19:34:55] * yuvipanda  will fix that too

[19:34:55] <mutante>	 i use fireogg
[19:34:58] <mutante>	 worksforme
[19:35:28] <yuvipanda>	 there's a gstreamer hacker friend of mine who's coming to devcamp to embed gstreamer into the app
[19:35:31] <yuvipanda>	 so we can do encoding on the phone
[19:35:44] <yuvipanda>	 it'll kill your battery and be doggone slow, of course :D
[19:36:02] <mutante>	 :)
[19:36:24] <mutante>	 it should be distributed computing using BOINC :)
[19:36:34] <yuvipanda>	 :D
[19:36:39] <mutante>	 so users can contribute CPU time and others can have the cloud encode the videos for them
[19:37:06] <yuvipanda>	 ah, but a phone/tablet is a very inefficient device for doing encoding
[19:37:30] <yuvipanda>	 in terms of power or time.
[19:37:40] <yuvipanda>	 mmm, the year of working on GNOME might finally be useful!
[19:38:28] <yuvipanda>	 mutante: https://etherpad.mozilla.org/E7LtPApUuE
[19:38:33] <yuvipanda>	 Open Knowledge Foundation's version of 'Ping me Maybe'
[19:38:46] <yuvipanda>	 tfinc: preilly ^
[19:38:48] <mutante>	 lol, a git poem?
[19:39:11] <yuvipanda>	 looks like :P
[19:39:34] <yuvipanda>	 Your feature was holding
[19:39:34] <yuvipanda>	 Forked branch, patches showing
[19:39:34] <yuvipanda>	 Pull request, start reviewing
[19:39:34] <yuvipanda>	 Ping timeout, you goin' baby?
[19:39:34] <yuvipanda>	 m
[19:39:39] <yuvipanda>	 favorite set :P
[19:39:44] <yuvipanda>	 they're recording a version now :P
[19:42:21] <mutante>	 http://www.encodingcluster.com/trac/
[19:42:59] <yuvipanda>	 mutante: ah, sweet!
[19:43:13] <yuvipanda>	 mutante: of course, we can sidestep all this by having server-side transcoding :P
[19:43:30] <mutante>	 http://sourceforge.net/projects/mythgrid/
[19:43:53] <mutante>	 <- this is actually using BOINC :)
[19:44:05] <mutante>	 alright, gotta get on DNS zone file editing..hrmm
[20:40:25] <wm-bot>	 [bugs] REOPENED [Bug 41502] Blank messages via Mobile Feedback should not be sent (priority: Unprioritized severity: normal) https://bugzilla.wikimedia.org/show_bug.cgi?id=41502
[21:06:48] <tfinc>	 awjr: how are you feeling?
[21:07:17] <awjr>	 tfinc: better each day
[21:08:18] <awjr>	 tfinc doc says it will likely be weeks before it is fully healed, but should stop being painful within the next couple. he is going to give me a bunch of stuff to help cope while traveling when i go back to see him on monday
[21:08:40] <tfinc>	 i just hope this drama can stop for you
[21:09:15] <awjr>	 thank you, me too. the oral surgeon my dentist referred me to is… a lot better than my dentist has been and has put me way more at ease about the whole thing
[21:10:27] <awjr>	 having to go to the dentist/oral surgeon every day is getting very old...
[21:20:30] <awjr>	 MaxSem, jdlrobson do i need to do something special locally to make references in articles render locally the same way they do in production?
[21:20:52] <MaxSem>	 what's the difference?
[21:21:30] <MaxSem>	 there's a gadget on enwiki, RefPopup or something, that dispalys reference text in popups
[21:21:39] <awjr>	 maybe it's just from my import of some articles, but instead of seeing references in the article, i see things like: <ref name="TravelandTourism"/>
[21:21:46] <Platonides>	 awjr, install Cite extension
[21:21:55] <awjr>	 Platonides: ahha thanks!
[21:22:05] <Platonides>	 :)
[21:23:13] <MaxSem>	 I didn't guess the most obvious:)
[21:39:17] <jcmish>	 I'm off to apple to get my MacBook
[21:41:02] <tfinc>	 k
[21:41:10] <tfinc>	 yuvipanda: you all set for the language summit ?
[21:41:26] <tfinc>	 we'll have an iPad mini for testing in India :)
[21:41:35] <tfinc>	 ours came in today
[21:41:38] <yuvipanda>	 mostly. I need to convert my paper slides to screen slides :)
[21:41:42] <yuvipanda>	 otherwise alll good :)
[21:42:38] <yuvipanda>	 tfinc: I'm working to make sure I've Commons App usable right from day 1
[21:43:04] <tfinc>	 yuvipanda: i'm eager to see you demo it for us
[21:43:26] <yuvipanda>	 tfinc: I'm trying to figure out what should be the 'first photo uploaded'
[21:43:26] <yuvipanda>	 to commons
[21:49:31] <preilly>	 tfinc: did you read https://etherpad.mozilla.org/E7LtPApUuE
[21:54:11] <preilly>	 jdlrobson: hmm that's funny — https://github.com/preillyme/WikipediaMobileFirefoxOS/pulls is still at 0
[21:54:43] <gerrit-wm>	 Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31161
[21:56:21] <gerrit-wm>	 Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31162
[21:58:09] <gerrit-wm>	 Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31163
[21:58:33] <preilly>	 ha ha ha — http://i.imgur.com/wAKZH.png
[22:11:39] <brion>	 hey All, landed in Newark on my way to india
[22:11:57] <Platonides>	 :)
[22:12:22] <brion>	 what's going on at the office this weekend? are they moving stuff?
[22:12:37] * Platonides  realises that Newark is a bit ambiguous: http://en.wikipedia.org/wiki/Newark

[22:14:25] <brion>	 :) http://en.m.wikipedia.org/wiki/Newark_Liberty_International_Airport
[22:15:17] <brion>	 hey bharris are they moving stuff in the office this weekend or not until later?
[22:17:21] <brion>	 I'm sitting on a runway waiting for a gate to open up. wheeee
[22:17:46] <brion>	 but thanks to modern wizardry I'm still on irc
[22:20:53] <gerrit-wm>	 Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31164
[22:24:20] <jdlrobson>	 preilly: anything else you want me to look at?
[22:24:23] <jdlrobson>	 ori-l: upstairs?
[22:24:55] <wikipedia-github>	 [commons] yuvipanda pushed 2 new commits to master: http://git.io/7tc6Ag
[22:24:55] <wikipedia-github>	 commons/master 3857a18 YuviPanda: Keep state about currently selected account in application
[22:24:55] <wikipedia-github>	 commons/master b939ec2 YuviPanda: Actually add updated java-mwapi
[22:25:21] <preilly>	 jdlrobson: is everything closed
[22:25:25] <jdlrobson>	 it should be
[22:25:29] <jdlrobson>	 needs your verification though
[22:32:15] <preilly>	 jdlrobson:  [Break On This Error] 	
[22:32:16] <preilly>	 bb = b.getElementsByTagName( 'button' )[0], i, s, e, closed, reset = [];
[22:39:02] <wikipedia-github>	 [commons] yuvipanda pushed 2 new commits to master: http://git.io/5iME0w
[22:39:02] <wikipedia-github>	 commons/master f8c9dba YuviPanda: Always flip the first character of username to be uppercase
[22:39:02] <wikipedia-github>	 commons/master b3f8bf8 YuviPanda: Add appropriate info and licensing templates
[22:39:43] * yuvipanda  heads to sleep

[22:59:09] <gerrit-wm>	 New review: awjrichards; "groovy :)" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/31293
[22:59:10] <gerrit-wm>	 Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31293
[23:04:39] <gerrit-wm>	 New patchset: Jdlrobson; "update tests to highlight bugs" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31581
[23:04:50] <wm-bot>	 [bugs] NEW [Bug 40919] Wikipedia sends desktop site to Boot2Gecko (Firefox OS) (priority: Unprioritized severity: enhancement) https://bugzilla.wikimedia.org/show_bug.cgi?id=40919
[23:05:05] <wm-bot>	 [bugs] NEW [Bug 40513] Blackberry 10 SDK dev device doesn't redirect to mobile site (priority: Unprioritized severity: enhancement) https://bugzilla.wikimedia.org/show_bug.cgi?id=40513
[23:06:04] <wm-bot>	 [bugs] NEW [Bug 41517] Windows 8/RT Internet Explorer 10 given non-JS version of mobile site (priority: Unprioritized severity: normal) https://bugzilla.wikimedia.org/show_bug.cgi?id=41517
[23:09:35] <preilly>	 jdlrobson: https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/MobileFrontend,n,z you're on fire
[23:18:15] <gerrit-wm>	 Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31294
[23:22:15] <gerrit-wm>	 Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31295
[23:26:15] <gerrit-wm>	 Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31296
[23:28:09] <jdlrobson>	 preilly:  :)
[23:28:09] <gerrit-wm>	 Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31297
[23:30:42] <awjr>	 jdlrobson: what was the problem this addresses? https://gerrit.wikimedia.org/r/#/c/30289/2 more specifically, what should i be looking for when i test?
[23:31:01] <jdlrobson>	 awjr: on beta click a link to a page which has cleanup templates
[23:31:10] <jdlrobson>	 check that cleanup templates are collapsed
[23:31:25] <awjr>	 ok - cleanup templates within sections as well as those at the top of the page?
[23:33:28] <jdlrobson>	 no
[23:33:30] <jdlrobson>	 those are left
[23:33:41] <awjr>	 jdlrobson: ok cool thanks
[23:37:38] <gerrit-wm>	 Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30289
[23:48:10] <gerrit-wm>	 New review: awjrichards; "See previous comment - I didn't look super closely at this but it seems like you should be able to d..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1;  - https://gerrit.wikimedia.org/r/31315
[23:50:07] <gerrit-wm>	 Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31388
[23:50:54] <gerrit-wm>	 New review: awjrichards; "Please fix broken tests." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1;  - https://gerrit.wikimedia.org/r/31581
[23:51:51] <awjr>	 BAM. i've finished rviewing all open change sets for MF
[23:51:54] <awjr>	 jdlrobson: ^
[23:51:58] <gerrit-wm>	 New patchset: Jdlrobson; "only initialise search module when on ui (bug 41669)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31586
[23:52:05] <jdlrobson>	 awjr: one more for you ^
[23:52:14] * awjr  shakes his fist at jdlrobson

[23:52:20] <wm-bot>	 [bugs] NEW [Bug 41669] document.getElementById("results") is null (priority: Unprioritized severity: normal) https://bugzilla.wikimedia.org/show_bug.cgi?id=41669
[23:54:48] <gerrit-wm>	 New patchset: Jdlrobson; "remove more/less from footer" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31298
[23:55:24] <gerrit-wm>	 Change abandoned: Jdlrobson; "Not actually needed after talking to Maryana - only collapse summary templates." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30303
[23:55:38] <jdlrobson>	 awjr: please look at https://gerrit.wikimedia.org/r/#/c/31313/ again
[23:55:50] <awjr>	 jdlrobson: k will do
[23:57:16] <jdlrobson>	 also awjr not sure I get what you are saying in https://gerrit.wikimedia.org/r/#/c/31315/
[23:57:47] <jdlrobson>	 an article's languages might include the current language twice in case of simple wiki
[23:58:03] <jdlrobson>	 'en' for simplewiki 'en' for en.wiki
[23:59:02] <awjr>	 jdlrobson: how does that patchset account for that?
[23:59:32] <jdlrobson>	 awjr: maybe i'm misunderstanding
[23:59:32] <jdlrobson>	 but more importantly.. whilst I remember
[23:59:32] <jdlrobson>	 https://gerrit.wikimedia.org/r/#/c/31581/
[23:59:35] <jdlrobson>	 so DeviceDetection.php is in core
[23:59:38] <jdlrobson>	 and the core version is out of date
[23:59:49] <jdlrobson>	 and it is still in MobileFrontend/includes
[23:59:53] <jdlrobson>	 thus I'm very confused