[00:00:05] (on my local machine it uses the core DeviceDetection.php) [00:00:18] im just suggesting that you check whether or not you have languages to print earlier on, so you dont wind up doing a bunch of unnecessary processing [00:00:33] awjr: I understand but I don't understand how the if statement you posted is the same as what I'm doing [00:00:34] ok, i didnt actually look at what broke [00:00:56] we either need to remove DeviceDetection class from core OR update core to have the latest version of MobileFrontend device detection and remove the one in MobileFrontend [00:01:03] before I can fix [00:01:03] it's not, but im suggesting you do the checking within that same if statement for an early return [00:01:10] @_@ [00:01:13] ok [00:01:33] lemme take a look at the other stuff first [00:01:48] New review: Jdlrobson; "jdlrobson: so DeviceDetection.php is in core" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/31581 [00:02:17] awjr: got a second to try out a hang out? [00:02:24] tfinc sure [00:02:41] New patchset: Jdlrobson; "log when a section is opened on beta" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31588 [00:02:42] New patchset: Jdlrobson; "send hostname with logged events" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31589 [00:02:47] New patchset: Jdlrobson; "update Makefile to pull e3 logger from elsewhere" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31590 [00:03:06] invite sent [00:04:04] awjr: did you get the invite? [00:04:16] i'm trying out the new iPad min's hangout support [00:04:17] tfinc er not sure [00:04:21] tfinc: via email? [00:04:31] you would see an invite in you gmail client [00:04:46] granted i bet this is tied to my @gmail accoun [00:04:51] tfinc no [00:05:02] awjr: so it make have gone to your personal gmal [00:05:03] tfinc but i also don't use the gmail client for gchat, if that makes any difference.. [00:05:06] ah [00:05:33] mm not seeing anything [00:05:33] ahha! [00:05:41] there it is [00:08:48] New patchset: Jdlrobson; "cleanup ui of cleanup templates" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31339 [00:11:55] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31586 [00:15:03] New review: Jdlrobson; "The if statement you've suggested does not do the same thing and would not address the original bug." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/31315 [00:18:45] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31298 [00:20:52] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31339 [00:21:37] * awjr falls over from too much code review [00:29:51] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31315 [00:44:21] tfinc: tracking shows my passport was picked up and scheduled for delivery monday afternoon :) [00:50:51] awjr, congratulations! [00:53:56] \o/ [00:54:25] i still won't believe it til it's in my hands [00:54:42] but things are looking good [00:54:47] im out - have a great weekend everyone [01:05:07] Change abandoned: Jdlrobson; "(no reason)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/28766 [09:26:24] [bugs] NEW [Bug 31956] Android app nearby me should offer a list view (priority: Normal severity: enhancement) https://bugzilla.wikimedia.org/show_bug.cgi?id=31956 [09:26:39] [bugs] NEW [Bug 34100] add the option to have favorite languages in the app (priority: Unprioritized severity: enhancement) https://bugzilla.wikimedia.org/show_bug.cgi?id=34100 [09:26:40] [bugs] NEW [Bug 33528] Use language selection to override default locale for i18n (priority: Normal severity: normal) https://bugzilla.wikimedia.org/show_bug.cgi?id=33528 [09:26:41] [bugs] NEW [Bug 32918] Search box and main page button cannot be keyboard-navigated to (priority: Normal severity: normal) https://bugzilla.wikimedia.org/show_bug.cgi?id=32918 [09:27:01] [bugs] NEW [Bug 33881] (optionally) hide the search bar, as it is done in browser (priority: Unprioritized severity: enhancement) https://bugzilla.wikimedia.org/show_bug.cgi?id=33881 [09:27:27] [bugs] NEW [Bug 31979] Photo upload in mobile app using PhoneGap's Camera interface (priority: Normal severity: enhancement) https://bugzilla.wikimedia.org/show_bug.cgi?id=31979 [09:27:43] [bugs] NEW [Bug 33690] Language selector stays open after closing on Honeycomb (Galaxytab 10.1) (priority: Low severity: normal) https://bugzilla.wikimedia.org/show_bug.cgi?id=33690 [09:28:05] [bugs] NEW [Bug 33859] Commons uploader (priority: Unprioritized severity: enhancement) https://bugzilla.wikimedia.org/show_bug.cgi?id=33859 [09:28:06] [bugs] NEW [Bug 32908] Android app language list should be filterable/searchable to make it more manageable (priority: Unprioritized severity: enhancement) https://bugzilla.wikimedia.org/show_bug.cgi?id=32908 [09:28:07] [bugs] NEW [Bug 33805] a page with the same title in different languages appears identically in the list (priority: Low severity: normal) https://bugzilla.wikimedia.org/show_bug.cgi?id=33805 [09:28:08] [bugs] NEW [Bug 30772] mobile wikipedia commonly uses non-canonical urls that don't get squid/varnish/whatever cache purged (priority: High severity: normal) https://bugzilla.wikimedia.org/show_bug.cgi?id=30772 [09:55:51] [commons] yuvipanda pushed 1 new commit to master: http://git.io/ZRWjbQ [09:55:51] commons/master 88cb714 YuviPanda: Add date for {{Information}} template according to EXIF data [15:51:56] Change abandoned: Jdlrobson; "Max is looking into this" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/28658 [18:00:50] * yuvipanda looks around