[01:09:16] Project WiktionaryMobile - Nightly builds build #107: SUCCESS in 11 sec: https://integration.mediawiki.org/ci/job/WiktionaryMobile%20-%20Nightly%20builds/107/ [01:09:16] reedy: Add missing contact-page-label [05:38:44] [bugs] NEW [Bug 40513] Blackberry 10 SDK dev device doesn't redirect to mobile site (priority: Unprioritized severity: enhancement) https://bugzilla.wikimedia.org/show_bug.cgi?id=40513 [06:06:00] [bugs] NEW [Bug 41517] Windows 8/RT Internet Explorer 10 given non-JS version of mobile site (priority: Unprioritized severity: normal) https://bugzilla.wikimedia.org/show_bug.cgi?id=41517 [14:45:47] [commons] yuvipanda pushed 1 new commit to master: http://git.io/_MFNEA [14:45:47] commons/master f4fe37c YuviPanda: Added missing authenticator XML file [14:49:14] [commons] yuvipanda pushed 1 new commit to master: http://git.io/wouXgw [14:49:14] commons/master 6d105f4 YuviPanda: Added ActionBarSherlock library compatiblity support [14:52:15] [commons] yuvipanda pushed 2 new commits to master: http://git.io/ZFbbyg [14:52:15] commons/master 482b05d YuviPanda: Add ticker text for notifications [14:52:15] commons/master f1ef106 YuviPanda: Remove actionbar from share dialog [16:02:56] yuvipanda: why are you hiding here? >_> [16:03:04] i'm not! [16:03:12] you're also not in -en :P [16:03:18] ah [16:03:20] autojoin problems [16:03:31] anyway, … I think something needs to be updated, either the software or the docs [16:03:45] wctaiwan: oh? [16:04:02] translatewiki says translations should be on github in 24 hours ( https://translatewiki.net/wiki/Translating:WikipediaMobile ) [16:04:04] you said a week [16:04:22] judging from the source the last push was a month ago? :s [16:04:58] wctaiwan: yeah, it's the docs that need updating :) [16:05:09] alright [18:06:32] any if anyone needs the travel schedule just check lauras mail which had it [18:07:05] awjr: you, janice, and i are one the same FRA->BLR flight [18:07:22] tfinc: yeah i saw that :) [18:07:26] does anyone know Jon's current cell number? [18:07:38] that's handy, it'll make getting to the hotel easier [18:07:46] MaxSem: is it not on the office contact list? [18:07:55] i can pm it to you if not [18:08:14] no it's not [18:08:51] I know only his UK number [18:09:06] hello tfinc [18:09:06] MaxSem: just pm'd it to you [18:09:07] * yuvipanda throws https://test.wikipedia.org/wiki/File:Cat_about_to_die.jpeg at tfinc [18:09:56] * yuvipanda also throws https://test.wikipedia.org/wiki/Special:Contributions/Yuvipanda, https://test.wikipedia.org/wiki/Special:Contributions/Logicwiki and https://test.wikipedia.org/wiki/Special:Contributions/Pginer at tfinc  [18:10:12] mine were all done with the s3 [18:10:16] yuvipanda: i can see you've been having fun [18:10:28] tfinc: field testing :D [18:10:45] we identified a few issues with the UX, and Pginer also gave a few nice suggestions [18:11:01] yuvipanda: i'm eager to see you demo it [18:11:08] tfinc: soon enough! [18:11:27] i'll probably add the last piece for full on 'reliability' tomorrow (retries on network failure) [18:11:43] yuvipanda: plan for a demo of it the first day so that we can showcase it and then pick on what to hack [18:11:50] tfinc: I can get you an apk now too, really. It's pretty solid [18:11:54] sure [18:11:56] you can but i won't be able to test it [18:12:06] its my last day before travel [18:12:06] yeah, i figured [18:12:11] the s3 has a wonderful camera. [18:12:30] we also found some bugs with large panoramas uploading [18:14:06] yuvipanda: have you started thinking about image triage on the s3 ? [18:14:21] tfinc: not yet, i've been busy with this for now. [18:17:03] tfinc: i'm also not sure if we could concentrate on both together [18:22:36] [bugs] REOPENED [Bug 41502] Blank messages via Mobile Feedback should not be sent (priority: Unprioritized severity: normal) https://bugzilla.wikimedia.org/show_bug.cgi?id=41502 [18:34:48] anyone knows how to diagnose why a package is in a half-configured state? [18:35:49] MaxSem: what kind of package ? [18:35:54] maybe there was some conflict... [18:36:05] tfinc, Debian package [18:36:11] diganosing why it ended up half-configured is usually not so hard [18:36:14] MaxSem: ask faidon. he's a debian dev [18:36:15] fixing it sometimes is [18:36:33] I think you fix it by running something like [18:36:34] dpkg-configure -a [18:36:58] Platonides, no conflict- just numerous reinstalls [18:37:18] it died from torture ^_^ [18:38:24] with other package managers it is possible to force it to forecefully uninstall a package even if requisites would otherwise block it [18:46:15] awjr: are we still doing the retro @ 2 ? [18:52:39] tfinc we should probably just cancel it since half the team is out [18:52:46] awjr: do iot [18:52:53] awjr: feel free to do it over email [18:53:34] [bugs] NEW [Bug 41791] Landscape mode no longer works in latest version (priority: Unprioritized severity: normal) https://bugzilla.wikimedia.org/show_bug.cgi?id=41791 [18:53:34] time has not changed here, but the fact that it's changed in CA is srsly confusing me [18:55:37] awjr: here in California were really enjoying out extra hour. you should try it. [18:56:17] if it wasn't for you guys, i'd be pleasently enjoying my lack of temporal shift [18:57:09] awjr: your about to travel to india. get used to a temporal shift [18:57:13] :) [18:57:16] hahaha [18:57:23] touche [18:57:25] awjr: MaxSem : need me to bring anything for the two of you to India ? [18:57:31] tfinc: whiskey [18:57:40] testing device/ office schwag/ sour beer ? [18:57:44] and/or beer [18:57:48] oh wait .. i already did the latter [18:57:55] awjr: its your turn now ;) [18:57:55] ! [18:57:55] :D [18:58:00] awjr: remember the sour that we had on top of the hotel roof [18:58:04] awjr, lol - yuvi have already ordered some vodka:) [18:58:05] i do, that was magical [18:58:21] and it was properly served in belgian glasses [18:58:29] * tfinc ponders what media to bring [18:58:29] i will definitely pick a few things up at duty free in frankfurt [18:58:32] we watched a lot of archer last time [18:58:45] awjr: way there or way back ? [18:58:46] way there [18:59:02] excellent because as you know the'll be very little for us to drink there [18:59:18] the friend im visiting in hyderabad requested tequila, so i'll be servicing her needs and picking some stuff up for us [18:59:34] this is an extension of being a scrum master right ? [18:59:39] lol [18:59:41] unblocking blockers [19:01:45] MaxSem: did those CR's from Niklas come in? [19:02:08] yes, I've already responded/committed a followup [19:03:24] MaxSem: so the only blocker that i knew we have left is the hardware correct ? [19:04:54] tfinc, there are also some previous GD revisions not yet approved. I was going to discuss their merge with awjr as a lot of stuff in them has already been rewritten [19:05:11] o_O [19:05:19] ...in later revisions [19:06:08] yeah, due to length some of them were unmerged, attempting to alter any of them will ruin the cardboard house:) [19:07:47] MaxSem: i wont be able to review them today [19:07:56] yeah, India:) [19:07:56] i might be able to get things set up so i can take a look while traveling though [19:08:04] :) [19:14:31] tfinc: i still haven't put up pics of that [19:14:36] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31340 [19:15:43] tfinc: MaxSem has also graciously accepted to buy us some vodka from russia! [19:15:54] would be a nice change from the one I'm having right now with siebrand :P [19:16:09] that scared him [19:16:26] Hmm, India. [19:16:26] haha, DrunkenPanda [19:16:29] I need to pack tomorrow. [19:17:05] MaxSem: the best Panda :P [19:18:14] MaxSem: I still owe you a beer or something from your API work. :-) [19:18:30] :) [19:24:06] awjr: don't forget you hate the coffee in india [19:24:10] tfinc: i have prepared [19:24:48] in spite of my hatred for starbucks, i picked up a bunch of these: http://www.starbucks.com/coffee/via [19:25:12] where did you guys get your coffee? [19:25:18] it'll be worth it. those are the ones i was suggesting last year [19:25:28] yep :) [19:38:45] * jerith drinks masala tea in India. [19:38:56] jerith: welcome to india [19:38:59] And I eat dosas for breakfast. [19:39:02] i'll see you there in a couple of days [19:39:12] tfinc: I'm not there just yet. [19:39:20] I arrive Thursday morning. [19:40:34] same as me then. my party (arthur and janice) will arrive 2am thur [19:41:29] I get in just before 8am. [19:41:58] About half an hour before yuvipanda and company. [19:42:17] i'm excited about this event. it's been a while since we've had all of us together [19:42:22] When does Dan arrive? He's not on the list I have. (And neither am I.) [19:42:29] many dosas shall be had [19:42:34] no idea. dan just booked his travel last week [19:42:52] Me too. [19:43:19] Hopefully none of the airlines I'm flying will go out of business. [19:43:42] That's already happened to me once this week. [19:44:08] which airline ? [19:44:08] king fisher ? [19:44:31] One of the South African low cost airlines. [19:45:04] time to get food … bbl [19:45:05] Our entire company was on a bus heading from the mountains to the airport when we saw the news on the internet. [19:45:39] Only about ten of us were flying, but there was still a lot of rebooking and stuff that had to happen before we could all get home. [19:46:01] lol [19:46:03] ... or "lol" [19:46:23] I was rather pleased about how it all turned out, actually. [19:47:24] I ended up flying at a very reasonable time on Sunday night instead of way too early on Monday morning. [19:48:15] Mmmm. Springbok steaks for supper tonight. [20:00:56] * tfinc has never had a Springbok [20:01:54] There's a local steakhouse that does springbok shank in the same style as Greek lamb. [20:01:57] It's awesome. [20:02:42] Kudu and gemsbok are nicer as steaks, though. A little more tender. [20:05:51] those are all animals i need to try sometime [20:06:02] * tfinc wonders how he can justify visiting jerith in his homeland [20:07:14] tfinc: http://scaleconf.org/ is looking for speakers. :-) [20:08:07] jerith: i love http://scaleconf.org/report-2012 as a write up [20:09:10] Yup. [20:10:11] It was the second best conference I've ever been to, and I'm somewhat biased about http://za.pycon.org/ because we organised it. :-) [20:11:22] ScaleConf had better lunch, PyConZA had better wifi. They were both really good. [20:12:12] Anyway, you should totally come speak at the conference and organise a hackathon just afterwards. [20:12:39] jerith: Isn't 'Sprinbgok' a… sports team? [20:13:03] yuvipanda: Yes, but it's named after some of the more delicious local wildlife. :-) [20:13:38] "Spring" means "jump" in Afrikaans, and that's their distinctive feature as an animal. [20:14:51] do they sponsor a sporst team? [20:15:23] They mostly roam around in herds and get eaten by lions or something. [20:15:39] (Disclaimer: I am not a zoologist.) ;-) [20:20:53] *omnomnom* ROAR! *omnomnom* [20:26:40] :P [20:29:44] yuvipanda: do you need me to bring any other iOS devices besides the Mini ? [20:30:19] tfinc: I think me and brion talked and figured we'd drop iOS4 support on next release, so I think that's fine [20:30:31] k [20:30:53] yuvipanda: users are still breaking down our doors for a random app feature [20:31:39] tfinc: add a slightly bigger lock :P [20:31:46] MaxSem: will yttrium work for GeoData ? [20:31:47] but yes, we should merge that branch with the small fixes it needs [20:32:04] yuvipanda: i respond to at least 5-10 mails a week about it [20:32:18] tfinc, yes - but we will need to discuss our plans for growth [20:32:30] tfinc: we should also figure out a schedule for updating the iOS app - lots of code is sitting waiting for a beta cycle [20:32:45] I simply proposed yttrium as an initial machine [20:33:01] MaxSem: lets us it so that we can get unblocked. we scan always change the hardware later [20:33:18] yuvipanda: what's stopping us from doing a beta ? [20:33:22] yuvipanda: hows your time over the next two months ? [20:33:34] juliusz stars on 11/19 which will free up brion [20:33:41] this will let us build the app team of you and brion [20:36:05] tfinc: wonderful [20:36:08] tfinc: I am with jon until 27 [20:36:20] i've exams until dec 17 [20:36:25] found the HTC wildfire [20:36:39] tfinc: I've already set brion on things - He's been studying the Android Commons app's source and discussing best way to do things on iOS [20:36:54] so yes, that'd be a *wonderful* team [20:37:12] tfinc: nothing's stopping us - we just need someone to build ipas, send out messages, and more importantly - *poke* people into testing [20:37:30] i'm going to start a thread on mobile-tech about the team switch. it'll finally give us the right kind of focus on apps [20:37:37] regardless of wether their native or html5 [20:37:44] \o/ [20:38:39] tfinc: i'm hoping michelle can help with the beta process for iOS [20:38:51] yuvipanda: just ask her [20:39:08] she's usually telling us that were not giving her enough to work on [20:39:24] I can help fix that [20:39:41] i'm prepping for my talk tomorrow, I'll email her right after that [20:39:43] (after the talk, that is) [20:45:04] tfinc: passport + visa just arrived! [20:45:24] awjr: woot! [20:45:48] this is why we escalate to laura and rachel. they get shit like this done well [20:46:07] treat your admins well as they are awesome [20:46:47] tfinc: Both of my previous trips to India involved me getting my passport and visa back fewer than 12 hours before my flight left. [20:47:30] This time I had everything ready *well* in advance. [20:48:24] jerith: i have my fiver year business visa now [20:48:29] it makes all of this super simple [20:48:31] i'm good till 2017 [20:48:38] it's sortof crazy that I've a 10 year visa to the US [20:48:51] I have a one year business visa. [20:48:58] yuvipanda: then why aren't you here yet ? [20:49:02] move already so that you can just work with us in the same office [20:49:05] I also have a 10 year US visa. [20:49:17] tfinc: But India's awesome. [20:49:28] tfinc: I don't believe my visa lets me 'work' there :) [20:49:36] yuvipanda: i can fix that with an H1B [20:49:50] indeed, and that requires a 4 year degree [20:50:14] Really? [20:50:29] it's a lot more complicated if not [20:50:44] especially with the per-country quota system and the tons of employees from Indian IT companies [20:50:48] Ah. [20:51:16] * jerith might be arranging a Facebook interview at some point, so can come and visit again. [20:51:53] jerith: position at Facebook ? [20:52:29] tfinc: Production Engineer. [20:53:00] I'm pretty sure I don't want to work there, but I'm happy to come to California and let them try to convince me. :-) [20:53:15] :D [20:53:18] California is wonderful [20:53:21] except for the cold [20:53:44] yuvipanda, you gotta see Russia then [20:53:52] yuvipanda: talk to be about all the wikipedia app is off line feedback were getting. what's going on ? [20:53:52] or visit Nikerabbit [20:54:49] yuvipanda, did you wear the same coat in SF as in Berlin? [20:54:51] tfinc: good question. I've no idea. I tried reproing it (on the new devices as well) and failed. Will reach out to them when talk stuff is done [20:54:58] MaxSem: yup [20:54:59] only one I could find in Chennai [20:55:12] Winter shopping in Chennai is like buying a Surface RT in an Apple Store [20:55:58] whoa, you guys no liek alpine skiing? [20:56:41] MaxSem: I *did* go all around SF with a pair of skiing gloves [20:57:04] lemme guess: and Roan wore just a tshirt? [20:57:26] everyone who was not me pretty much wore just a T shirt [21:00:38] awjr: we should do something nice for the admins the next time that you visit [21:00:47] tfinc srsly [21:00:53] +1 [21:01:28] ok, time to sleep. talky talky tomo [21:01:37] oh here's jcmish [21:01:37] hey jcmish [21:01:37] yuvipanda: before you go [21:01:45] yuvipanda: we need to triage this offline issues. too many people are seeing it [21:01:47] yuvi! [21:01:52] let me know what you need from me to figure out what's going on [21:01:57] get jcmish involved if you need [21:02:01] we need to find out whats breaking it [21:02:20] uhoh which issue is this? [21:02:29] app users reporting that they can't access pages. the app is in a permanent offline mode [21:02:41] jcmish: some app users are reporting that they are permanently in offline mode [21:02:49] oh holy cow [21:02:53] jcmish: you've access to the dev dashboard, right? [21:03:04] yup [21:03:06] going there now [21:04:06] jcmish: tfinc Galaxy S seems to be the most popular phone with that particular problem [21:04:10] any idea if we could get access to one? [21:04:33] I have an HTC One X that I'll be bringing along. [21:04:48] You can't keep it, though. It's mine! :-) [21:05:07] darn I don't have a galaxy... I need to hurry and buy a note [21:05:20] jcmish: it works fine on galaxy sii, siii, note, note 2, nexus [21:05:21] yuvipanda: if its not on the office list then its too late to get it for the trip [21:05:23] just galaxy s [21:05:33] tfinc: I don't want it for the trip [21:05:39] oh that truly sucks [21:05:40] I just want jcmish to check if she can repro it [21:06:21] also, 'Galaxy Fit', 'Samsung Europa', 'HTC Desire', 'Motorola Defy' [21:07:24] 'Motorola Atrix', 'HTC Aria', 'Galaxy Mini', 'Galaxy Ace', 'HTC Legend', 'Motorolla Droid II' [21:07:34] jcmish: you can check the reviews, and see the newest 1 star reviews [21:07:47] yup looking [21:07:47] and see if you could find someone in the office with such a phone, and see if you can repro it [21:08:32] jcmish: tfinc i found one from a Galaxy Tab user, and we have a Galaxy Tab in the office [21:08:35] jcmish: can you try with that? [21:08:51] sorry yuvi, I'm back home in Denver [21:09:01] so I don't have access to it [21:09:01] awww [21:09:01] damn [21:09:05] I know! [21:09:23] jcmish: yuvipanda : try it on perfecto [21:09:48] oh cool how do I use that? [21:10:17] jcmish: thanks, can you repro it on that and see if it works / doesn't? [21:10:24] tfinc, awjr: I have concerns about our PE task, it's too vague/complex so we're getting 100% failure rate - we can discuss it in India, however should we continue issuing it meanwhile? [21:10:34] MaxSem: change it [21:10:38] Yup I will [21:10:50] jcmish: wonderful, thanks! [21:11:01] jcmish: do shoot me an email with where you got :) [21:11:22] will do [21:11:31] jcmish: also, I want to talk about doing a beta cycle for iOS app. Do you think you could handle it? I'll be around to start it, and brion will be available once I'm out [21:12:05] yeah I think that's fine [21:12:08] sweet [21:12:15] I can handle it [21:12:15] I'll shoot an email tomorrow! [21:12:29] tfinc: how do I get access to perfecto to check this out? [21:12:44] yuvi awesome I'll keep an eye out for it [21:12:49] thanks! [21:13:48] jcmish: let me send you the login info [21:13:59] thanks [21:14:12] tfinc: also, are her keys added to iTunes connect, to let her sign IPAs? [21:14:56] yuvipanda: they are not [21:15:04] yuvipanda: brion is an admin now so just get him to add her [21:15:12] ahh, sweet [21:15:13] i'll do that tomorrow [21:15:14] i'm trying to remove myself from the process wherever i can [21:15:20] best manager ever :D [21:15:27] yuvipanda: how was the language summit ? [21:15:29] yuvipanda: aww .. thank you [21:15:33] tfinc: it starts tomorrow [21:15:42] yesterday was the community meetup [21:16:00] it was good, and we might have another micro-app brewing from the cross-polination that happened [21:16:02] let's see :D [21:16:06] yuvipanda: make sure you and brion come up with a coherent roadmap for mobile that doesn't go over three months (jan-march) [21:16:20] for language related work [21:17:05] yes sir! [21:17:12] jcmish: https://office.wikimedia.org/wiki/Registrations#General_Web_Services under perfecto [21:17:21] alright i'm off before siebrand kicks me out [21:17:26] gnite everyone [21:17:26] yuvipanda: Do you want to play with a Desire? [21:17:27] tfinc: see you in India soon! [21:17:28] tfinc thanks [21:17:30] jerith: bring one if you have it [21:17:34] not a Desire S [21:17:36] an original Desire [21:17:56] jcmish: heads up that its not the most reliable interface to use [21:17:57] yuvipanda: Cool. I'll see if I can convince my girlfriend to give it back to me for a bit. [21:18:14] It's running 2.2.something, if that makes a difference. [21:18:15] yuvipanda: so i'm brining the two htc devices, nexus7, and iPad mini [21:18:18] tfinc no worries and I know it's slow [21:20:25] Yup, I have permission to borrow my old Desire for the trip. [21:20:30] nice [21:22:02] I'll also give me a handset I can stick a local SIM into for testing SMS and USSD stuff, assuming I can get my hands on a local SIM. [21:22:29] tfinc: Is someone organising some SIMs for us? [21:25:51] jerith: nope [21:26:12] last time i got the admins to do it on site [21:26:42] tfinc: Ah well. I can always send Dan off to mug someone for their phone or something. :-P [21:26:56] yup. delegate as needed there [21:26:56] i fully approve that [21:27:43] The poor guy has to share a room with me, so he might be desperately looking for somewhere else to be in the middle of the night. [21:36:54] wow, 'Random article' during testing gave me 'Aircraft hijacking'... [21:40:33] jcmish: i'm sending the jp otrs team to you to answer a bug reporting question [21:42:18] tfinc kayo [21:43:57] it shall be responded to after deployment this evening [21:44:53] k [21:53:26] jcmish: i am seeing a problem on staging (and in master, generally) - the suggested search terms are no longer appearing (on beta or non-beta) [21:53:26] uhoh [21:53:31] let me look was working on translating [21:53:41] the git logs [21:53:56] i suspect it's a regression introduced by javascript changes [21:55:41] ah yes seeing it as well [21:55:56] which change do you think caused it [21:56:10] not sure yet [21:56:35] * awjr dusts off git bisecet [21:56:49] hahha [21:56:58] you can do it! [21:58:09] [bugs] NEW [Bug 41798] Users report that Wikipedia App moves into permanent offline mode (priority: Unprioritized severity: normal) https://bugzilla.wikimedia.org/show_bug.cgi?id=41798 [22:01:27] found it: https://gerrit.wikimedia.org/r/#/c/31586/ [22:03:51] can we back it out? [22:03:57] or is it easier to fix? [22:04:02] i think i might see the problem, gonna try a quick fix [22:05:05] k let me know [22:05:15] and then I'll try it out [22:19:11] i think ive fixed it but im having problems repeating the initial problem, so im not sure i've actually fixed it :p [22:19:24] uhoh [22:19:26] MaxSem: im trying to repro this: https://bugzilla.wikimedia.org/show_bug.cgi?id=41669 [22:19:48] i've tried in latest desktop firefox on os x and am not seeing the problem [22:20:01] also tried on mobile device in chrome browser with remote debugging, no dice [22:21:18] let me go and clear my cache and walk through it again [22:21:20] give me one sec [22:21:47] jcmish: note that staging is in a funny state [22:22:02] jcmish: let me fix it real quick [22:22:17] *holding horses* :D [22:22:37] jcmish: ok, staging is back to master with the broken commit [22:22:47] awjr, still 100% reproduceable for me - just enter Special:MobileOptions [22:23:02] MaxSem: yeah i have done that :( [22:23:08] on master? [22:23:46] MaxSem: in theory it should be fixed on master [22:24:06] MaxSem: im looking at the revision before https://gerrit.wikimedia.org/r/#/c/31586/ [22:25:48] right, I was on a different branch [22:26:23] MaxSem: ok, how can i reproduce it then? [22:27:08] git checkout 26cfcd457796f9c5511c0c8ddd5614a70ccf062 [22:27:08] k thanks awjr [22:27:48] awjr, enable debug mode to ensure that you're not struggling with cache [22:28:17] MaxSem: still not happening [22:28:36] I can show you in a screencast:P [22:29:02] MaxSem actually what would be better is if you can test a change for me [22:29:49] MaxSem: can you check this out: https://gerrit.wikimedia.org/r/#/c/31586/1 and s/&&/|| on line 248 [22:31:34] that might not actually be the right fix [22:32:35] awjr, that changes nothing for me - in both cases the exception is gone [22:32:58] good - do you see search suggestions? [22:33:33] I see no search at all [22:33:42] go back to a regular page and try searching [22:34:06] yes I see [22:34:49] MaxSem: one more - can you change line 248 to read: document.getElementById( 'results' ) && document.getElementById( 'mw-mf-search' ) [22:34:59] and a) make sure the exception is gone b) make sure you get search suggestions when you're supposed to [22:35:49] awjr, "mw.mobileFrontend is undefined" [22:35:53] ! [22:36:23] MaxSem: try a cache clear? [22:36:52] I always do it when testing JS [22:37:35] MaxSem can you show me the contents of the init() function? [22:38:10] if ( document.addEventListener ) { [22:38:11] document.addEventListener( 'DOMContentLoaded', function() { [22:38:11] domLoaded = true; [22:38:11] _mwLogEvent( 'DOMContentLoaded' ); [22:38:11] mw.mobileFrontend.init(); [22:38:11] }, false ); [22:39:06] ah ok sorry, wrong checkout [22:39:36] one sec, lemme just commit a change. [22:40:13] awjr, what are your concerns with that change? [22:40:40] https://gerrit.wikimedia.org/r/#/c/31586/1 breaks search suggestions [22:44:38] New patchset: awjrichards; "Followup to 8b14d999607ffd8f221fc9261dbcc0d527e983ec to unbreak search suggestions" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31964 [22:44:44] MaxSem: ^ [22:47:02] Change merged: MaxSem; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31964 [22:47:11] jcmish: ^ [22:47:31] see it [22:48:43] should I pull an update on staging [22:49:27] jcmish: yeah that would be great [22:49:45] kayo doing it now [22:51:02] awjr, are we deploying? [22:51:30] MaxSem that is the plan [23:01:26] k awjr update done [23:01:29] but I have a question [23:02:01] can I revert? ZeroRated [23:02:16] jcmish: not sure i understand what you mean [23:02:36] did references ever work right on staging? [23:02:46] Aborting Updating ZeroRatedMobileAccess remote: Counting objects: 8, done remote: Finding sources: 100% (6/6) remote: Total 6 (delta 4), reused 6 (delta 4) Unpacking objects: 100% (6/6), done. From ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ZeroRatedMobileAccess 6cb94bc..63194dc master -> origin/master Updating a3f3697..63194dc error: Your local changes to the following files would be overwritten by merg [23:03:06] o_O [23:03:22] I can check with Patrick [23:03:44] preilly, ^^ [23:03:46] we've just been stashing for now [23:03:57] jcmish: looksl ike hte unstaged changes are file permission changes [23:04:57] jcmish: i think you can reset those [23:06:31] k I won't worry about it for now [23:06:41] the other gerrit code is there [23:06:42] so staging is good to go [23:06:47] it's not [23:06:56] for some reason references are not working on staging [23:07:26] however they are working for me locally [23:07:56] hmmm [23:08:36] omg im an idiot [23:08:49] they are indeed working on staging [23:09:00] oh whew [23:09:12] I was totally getting bummed [23:09:14] hehe me too [23:09:22] k back I go to testing [23:10:17] jcmish: let me know when you're ready for me to put stuff on test.wikipedia.org. i have a hard-stop at 5pm pacific, which means we should be running scap no later than 4pm pacific [23:10:59] k I should be finished in about 5 mins [23:11:06] I was pretty close [23:11:28] I'll have to change getting the high level stuff done a bit sooner going forward [23:12:03] it's ok, we're ironing it all out :) [23:14:02] hehe I know [23:17:46] awjr [23:17:47] ? [23:17:47] go for it [23:18:01] okidoke [23:18:03] sorry meant that on one line [23:18:16] how long for scap? [23:19:31] scap has been taking nearly an hour :? [23:19:32] er [23:19:33] :/ [23:19:49] ah [23:19:51] but let me get this up on test.w.o so we can do a quick sanity check before i do that [23:20:03] sounds good [23:27:18] buhh having some git troubles, this is gonna take a minute to clean up [23:27:56] k [23:27:56] bummer [23:28:11] right now I can see MaxSem smiling :D [23:28:42] * MaxSem smiles hellishly [23:30:43] im having to reclone core and extensions because things are breaking on the pagetriage extension for some reason [23:30:48] recloning this stuff takes forever :| [23:40:24] jcmish, Maryana, MaxSem: ok changes are live on test [23:40:33] sweet [23:40:37] let's take a quick sanity check and then we can push to production [23:40:38] YAY [23:42:34] oh, did we push the blue lang. selector button to non-beta? [23:43:04] err, or am i getting caching issues? [23:43:12] survey says, the latter [23:43:20] false alarm [23:44:11] jcmish: where did you wind up recording the high-level changes? [23:45:06] no where near done [23:45:12] got sidetracked with testing [23:45:15] oh ok no worries [23:45:23] I'll have to finish it later sorry about that [23:45:57] awjr Maryana: Non Beta testing looks good [23:46:07] moving on to Beta now [23:46:23] kk [23:46:28] Maryana: im not seeing blue lang selector button in non-beta - jcmish am i supposed to? [23:46:43] no, i just got stuck in beta even after turning it off [23:46:45] nope [23:46:52] oh ok phew [23:47:07] test.wiki sticky pref issues, nothing to panic about :) [23:58:00] Non log in on beta looks good [23:58:04] on to logged in on beta