[04:12:54] New patchset: awjrichards; "Moves viewport-scalable handling to support ESI" [mediawiki/extensions/MobileFrontend] (esisupport) - https://gerrit.wikimedia.org/r/32853 [04:17:57] New patchset: Jdlrobson; "easy photo uploads for articles without images in the summary section" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/32683 [04:21:13] Change merged: MaxSem; [mediawiki/extensions/MobileFrontend] (esisupport) - https://gerrit.wikimedia.org/r/32853 [04:25:15] New patchset: Debarshiban; "Adding ESI support" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/32854 [04:30:35] awjr, https://office.wikimedia.org/wiki/Engineering_Recruitment_Projects#Task_13 [04:41:35] New patchset: MaxSem; "Cleanup" [mediawiki/extensions/MobileFrontend] (esisupport) - https://gerrit.wikimedia.org/r/32857 [04:47:05] https://github.com/jdlrobson/WikipediaMobileHomePage < keya [04:50:11] awjr: MaxSem do we need our deployment windows for the upcoming week ? [04:50:16] i'm pretty sure we dont [04:50:17] as were traveling [04:50:21] yup [04:50:26] tfinc_ there is a deployment scheduled for Tuesday [04:50:35] tinfc_ but i don't think we'll need Monday [04:51:25] so do you need tuesday then ? [04:51:44] correct [04:58:10] New patchset: MaxSem; "Cleanup" [mediawiki/extensions/MobileFrontend] (esisupport) - https://gerrit.wikimedia.org/r/32857 [05:15:53] MaxSem: do i file a bug? [05:16:02] or do I convince someone to make a Mingle Card for me? [05:22:19] yuvipanda, make a bug [05:22:45] Mingle is inappropriate as it's not a mobile team's area [05:22:50] New patchset: Brion VIBBER; "Mobile replacement for Special:Watchlist, initial version." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29621 [05:25:30] New patchset: awjrichards; "Remove X-Device vary header by default, rename method to delivering vary headers" [mediawiki/extensions/MobileFrontend] (esisupport) - https://gerrit.wikimedia.org/r/32860 [05:25:42] New review: Brion VIBBER; "Couple of issues in patchset 4:" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/29621 [05:28:43] awjr: https://gerrit.wikimedia.org/r/#/c/31588/1 [05:29:13] reporting for duty [05:29:19] jdlrobson: groovage, looking now [05:29:42] awjr: https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/MobileFrontend+branch:master+topic:ohnonotmorelogging,n,z [05:29:50] those are the ones [05:33:17] how do you guys want the data, btw? [05:33:31] plain suitcase, unmarked bills? [05:35:30] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31590 [05:35:30] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31589 [05:35:30] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/31588 [05:35:58] ori-l: ^ [05:36:02] ori-l bitcoin works too [05:36:02] yeeeyy awjr ! :D [05:36:16] awjr: a gentleman and a scholar, you are [05:36:32] :D [05:36:41] i think you guys need to flip a config var too, i can submit a patch [05:37:08] ori-l cool im in the middle of other stuff so that would be great - lmk when the patch is in and i'll take al ook [05:37:19] okay [05:42:33] New patchset: awjrichards; "Remove X-Device vary header by default" [mediawiki/extensions/MobileFrontend] (esisupport) - https://gerrit.wikimedia.org/r/32860 [05:43:01] MaxSem: ^ [05:43:51] 21:42 New patchset: Ori.livneh; "Enable event logging for mobile beta" [operations/mediawiki-config] (master) - https://gerrit.wikimedia.org/r/32864 [05:44:15] ^ jdlrobson: should this not be merged until the other changes are deployed? [05:51:13] awjr: can we deploy this? [05:51:48] ori-l: I suspect someone from ops needs to merge this [05:51:56] once merged it should get deployed pretty quickly in my experience [05:51:58] jdlrobson: naw [05:52:05] jdlrobson, ori-l one sec [05:53:29] awjr, I can do this [05:53:34] \o/ [05:53:40] it's a unix system, i know this [05:53:42] sweet. [05:53:45] thanks MaxSem [05:53:53] http://www.youtube.com/watch?v=dFUlAQZB9Ng [05:55:00] MaxSem: were you planning to deploy now or wait until our deployment on Tues? [05:58:53] oril-l, this logging infrastructure already used in production? [05:59:18] ori-l, ^^ [05:59:28] yes [05:59:42] go to the community portal on enwiki and click on one of the links in the task table [06:00:09] New patchset: awjrichards; "Vary based on WAP-ness since we are no longer varying on X-Device" [mediawiki/extensions/MobileFrontend] (esisupport) - https://gerrit.wikimedia.org/r/32867 [06:00:42] New review: awjrichards; "Related change: https://gerrit.wikimedia.org/r/#/c/32866/1" [mediawiki/extensions/MobileFrontend] (esisupport); V: 0 C: 0; - https://gerrit.wikimedia.org/r/32867 [06:00:56] MaxSem ^ [06:02:01] ori-l, is it the cause of the bug where I have to click on these links for the second time to get them loaded? [06:02:14] ??? [06:02:36] latest Opera, go to https://en.wikipedia.org/wiki/Wikipedia:Community_portal [06:02:47] i'll check [06:02:54] click on High Court of New Zealand [06:03:03] anyhow, the piece that's intercepting link clicks isn't related [06:03:04] for the first time,nothing happens [06:04:28] i'm checking [06:04:40] again, tho, it's not related [06:05:00] New review: MaxSem; "You're not outputting X-WAP" [mediawiki/extensions/MobileFrontend] (esisupport); V: 0 C: -1; - https://gerrit.wikimedia.org/r/32867 [06:06:37] MaxSem, but, yup -- $.fn.stall is wacky in opera. good catch. i'm fixing. [06:14:21] awjr: why did you just add req.http.X-WAP ? [06:14:55] preilly: when we stop varyin on X-Device, we still need to vary the cache on whether are displaying regular mobile view or if we are dsipalying wap [06:15:10] awjr: okay so this is post X-Device going away [06:15:15] preilly: correct [06:15:27] awjr: okay that makes much more sense [06:15:38] :) [06:15:52] awjr: Patch Set 1: Looks good to me, but someone else must approve [06:19:55] awjr: can I pm? [06:20:02] preilly: sure [06:22:36] New patchset: awjrichards; "Vary based on WAP-ness since we are no longer varying on X-Device" [mediawiki/extensions/MobileFrontend] (esisupport) - https://gerrit.wikimedia.org/r/32867 [06:25:20] preilly: is there anyway that we can see varnish health and in particular to visualize cache fragmentation? [06:25:40] awjr: not easily right now [06:25:50] awjr: I can try to put something together for you soon'ish [06:25:58] preilly: lemme come by irl [06:26:09] or when you're done harassing jon [06:28:37] awjr: have you looked at http://ganglia.wikimedia.org/latest/?r=hour&cs=&ce=&m=apache_report&s=ascending [06:29:23] awjr: I mean http://ganglia.wikimedia.org/latest/?r=hour&cs=&ce=&s=ascending&c=Mobile%2520caches%2520eqiad&tab=m&vn= [06:30:36] preilly: no looking now [06:32:29] preilly: im not sure how to determine fragmentation from those graphs? [06:32:54] preilly: im trying to think of how we can demonstrate the work that we've been doing to implement ESI so we have something to show when we present [06:34:18] preilly: since we're not implementing anything user-facing, im not sure what we can show off, so I was thinking we could discuss existing cache fragementation/utilization and discuss the impacts we think the work we're doing will have. do you have any ideas? [06:37:07] MaxSem: yt? [06:39:24] ori-l, I'm there [06:40:17] i hope you're not waiting on me to debug onclick handler behavior in opera, because it isn't related to this change. was there anything else i could answer? [06:40:54] awjr: you could use http://ganglia.wikimedia.org/latest/?c=Mobile%20caches%20eqiad&h=cp1042.eqiad.wmnet& [06:41:28] awjr: with something like http://ganglia.wikimedia.org/latest/graph_all_periods.php?c=Mobile%20caches%20eqiad&h=cp1042.eqiad.wmnet&v=789281946&m=frontend.backend_req&r=hour&z=default&jr=&js=&st=1352615986&vl=N&ti=Backend%20requests%20made&z=large [06:42:41] ^ MaxSem [06:43:23] yuvipanda: did you talk to brion about the android 2.2.2 offline issue ? [06:43:44] tfinc_: I did, and he suggested we blast the code with tracing console.logs [06:43:56] caveman debugging [06:44:04] indeed [06:45:32] ori-l if you'll be available now, I can deploy. Jon is ready too [06:46:15] yup. [06:46:45] to confirm: it seems best to first deploy the changes, then the config change [06:48:51] http://ur.wikipedia.org/w/index.php?title=%D8%B3%D8%A7%D9%86%DA%86%DB%81:%D9%85%D8%B9%D9%84%D9%88%D9%85_%DB%81%DB%92%D8%9F [06:50:15] what change ori-l? [06:50:44] do we still have undeployed changes in MF related to that? [06:53:51] MaxSem: 21:29 awjr: https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/MobileFrontend+branch:master+topic:ohnonotmorelogging,n,z [06:54:14] ori-l: we can't really do a MFE deployment today [06:54:16] maybe tuesday [06:54:41] ori-l, I just discussed it with Jon - we can't deploy these without QA [06:54:42] منصوبہ:منتخب مضمون [06:54:48] imdad, ?? [06:54:55] jdlrobson: ah, okay, that makes sense [06:55:16] :D thats for revamping urdu mobile page .. [06:55:56] jdlrobson: without these changes, enabling mobile logging will log perf + section edits, but w/o the hostname, correct? [06:56:15] Eloquence: https://meta.wikimedia.org/wiki/Mobile_Projects/Mobile_Gateway#Mobile_homepage [06:57:00] MaxSem: OK. if you are waiting until tuesday with the MFE changes, let's put this on hold [06:57:24] i'm going to -2 it so it doesn't get submitted by accident beforehand. [06:57:57] done. [06:58:15] i'm stepping out w/the dog -- if you want me to be around if/when you deploy stuff on tues, let me know [06:59:36] oops, I've -2'd it too [07:00:08] that's OK [07:00:23] it'll be like a nuclear sub -- both of us will have to turn the key at the right time to launch the nuke. [07:00:56] ori-l: nice work on the https://github.com/wikimedia/wmf-vagrant project [07:01:07] ori-l: I just tested it and it works really well [07:01:16] ori-l: I just made mine 64 bit instead [07:01:53] preilly: thanks! was debating 64 vs 32. 64 obviously matches production more closely, but possibly at the cost of compatibility/performance? not sure how well 32-bit hosts virtualize 64-bit guests. [07:02:27] ori-l: it would be nice to have it be a flag option or something [07:03:27] Change merged: MaxSem; [mediawiki/extensions/MobileFrontend] (esisupport) - https://gerrit.wikimedia.org/r/32860 [07:03:55] yeah, i think a setup script is in order. the other wart is the fact that the mediawiki submodule uses HTTP (again for compatibility reasons). it takes ages to fetch. probably better to just curl a tarball as part of the setup. [07:04:57] ori-l: yeah publish a nightly [07:05:07] ori-l: and rsync it down or something [07:05:20] brion: https://www.mediawiki.org/wiki/File:Commons_media_discovery_app.png [07:05:30] thx :D [07:05:59] back in a bit. [07:06:04] notnarayan_: that looks nice [07:06:25] brion: https://upload.wikimedia.org/wikipedia/commons/c/c6/Commons_media_discovery_app.png looks really cool [07:06:33] it does, we gotta make the thing now ;) [07:06:42] brion: ha ha ha [07:10:02] MaxSem: https://www.varnish-software.com/static/book/ [07:12:24] MaxSem: https://www.varnish-software.com/static/pdfs/varnish-book.pdfhttps://www.varnish-software.com/static/pdfs/varnish-book.pdfhttps://www.varnish-software.com/static/pdfs/varnish-book.pdfhttps://www.varnish-software.com/static/pdfs/varnish-book.pdfhttps://www.varnish-software.com/static/pdfs/varnish-book.pdf [07:12:29] ! [07:12:41] MaxSem: https://www.varnish-software.com/static/pdfs/varnish-book.pdf [07:20:40] New patchset: MaxSem; "Vary based on WAP-ness since we are no longer varying on X-Device" [mediawiki/extensions/MobileFrontend] (esisupport) - https://gerrit.wikimedia.org/r/32867 [07:21:10] New patchset: awjrichards; "Remove unused template var 'supports_jquery'" [mediawiki/extensions/MobileFrontend] (esisupport) - https://gerrit.wikimedia.org/r/32878 [07:25:24] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (esisupport) - https://gerrit.wikimedia.org/r/32867 [07:32:32] yuvipanda: http://www.mediawiki.org/wiki/Commons_Mobile_upload_app#App_Developement has been updated :) [07:32:48] we'll show brion when he gets back [08:09:01] preilly: thanks a lot :) [08:39:28] notnarayan: no problem [08:42:38] Change merged: MaxSem; [mediawiki/extensions/MobileFrontend] (esisupport) - https://gerrit.wikimedia.org/r/32878 [08:56:53] ahh preilly likefest [08:57:31] jdlrobson: and a share [09:26:30] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (esisupport) - https://gerrit.wikimedia.org/r/32857 [09:28:54] var unique=a.filter(function(itm,i,a){ return i==a.indexOf(itm); }); [09:29:03] Change abandoned: awjrichards; "wrong branch; changes merged toe esisupport branch in a different rev" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/32854 [09:29:56] Change abandoned: awjrichards; "(no reason)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/32716 [09:30:27] Eloquence: http://www.mediawiki.org/wiki/Commons_Mobile_upload_app has a new design for discover and triage [09:33:27] shiny :) [09:50:53] New patchset: Jdlrobson; "photo uploads for articles without images in the summary section" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/32683 [09:53:22] jdlrobson: are we going to talk with erik about en wiki uploads ? [09:53:30] yup [09:56:51] preilly: re https://gerrit.wikimedia.org/r/#/c/32866/ do i also need to do set beresp.http.X-WAP = req.http.X-WAP; in vcl_fetch()? [10:02:40] New patchset: Debarshiban; "ESI support for footer" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/32887 [10:06:02] awjr: fix the whitespace in https://gerrit.wikimedia.org/r/#/c/32887/1/includes/skins/SkinMobile.php [10:07:02] New patchset: Jdlrobson; "restrict photo uploads from articles to smaller subset of users" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/32888 [10:10:00] jdlrobson, so CORS itself is enabled for the cluster and *.wikipedia.org enabled as a CORS origin domain. what else is needed? [10:10:21] it is? mm.. let me investigate this more [10:10:32] 'wmgUseCORS' => array( [10:10:32] 'default' => true, [10:10:33] 'private' => false, [10:10:33] ), [10:10:52] see also $wgCrossSiteAJAXdomains in https://noc.wikimedia.org/conf/CommonSettings.php.txt [10:12:28] enabled in september: https://gerrit.wikimedia.org/r/#/c/22740/ [10:29:00] New patchset: MaxSem; "Warn old iPhone app users about API deprecation" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/32892 [10:29:12] jdlrobson: you need $wgCrossSiteAJAXdomains[] = '*.wikipedia.org'; [10:50:19] Change abandoned: awjrichards; "needs to be submitted to 'esisupport' remote branch" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/32887 [12:06:50] New patchset: awjrichards; "Combine viewportScalable and preambleScripts for ESI" [mediawiki/extensions/MobileFrontend] (esisupport) - https://gerrit.wikimedia.org/r/32894 [12:06:59] MaxSem: ^^ [12:09:02] New patchset: awjrichards; "Combine viewportScalable and preambleScripts for ESI" [mediawiki/extensions/MobileFrontend] (esisupport) - https://gerrit.wikimedia.org/r/32894 [12:09:27] MaxSem fixed ws ^ [12:27:17] New patchset: MaxSem; "log when a section is opened on beta" [mediawiki/extensions/MobileFrontend] (esisupport) - https://gerrit.wikimedia.org/r/32896 [12:27:17] New patchset: MaxSem; "send hostname with logged events" [mediawiki/extensions/MobileFrontend] (esisupport) - https://gerrit.wikimedia.org/r/32897 [12:27:18] New patchset: MaxSem; "update Makefile to pull e3 logger from elsewhere" [mediawiki/extensions/MobileFrontend] (esisupport) - https://gerrit.wikimedia.org/r/32898 [12:27:18] New patchset: MaxSem; "Collapsible sections now behave properly w/o JS" [mediawiki/extensions/MobileFrontend] (esisupport) - https://gerrit.wikimedia.org/r/32899 [12:28:25] Change abandoned: MaxSem; "(no reason)" [mediawiki/extensions/MobileFrontend] (esisupport) - https://gerrit.wikimedia.org/r/32896 [12:30:35] Change abandoned: MaxSem; "(no reason)" [mediawiki/extensions/MobileFrontend] (esisupport) - https://gerrit.wikimedia.org/r/32897 [13:26:59] New patchset: Jdlrobson; "add cors support" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/32904 [13:26:59] New patchset: Jdlrobson; "deal with duplicate photo uploads" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/32905 [13:26:59] New patchset: Jdlrobson; "photo uploads for articles without images in the summary section" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/32683