[10:38:37] New patchset: Jdlrobson; "IMPORTANT: fix display of Special:MobileMenu page" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/34054 [10:39:48] New patchset: Jdlrobson; "cleanup how messages are generated in mwMobileFrontendConfig" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/34055 [10:39:48] New patchset: Jdlrobson; "cleanup remaining message keys" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/34056 [10:39:48] New patchset: Jdlrobson; "address todo comment" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/34057 [10:40:38] New patchset: Jdlrobson; "move the jquery shim defined in application.js" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/34058 [10:40:38] New patchset: Jdlrobson; "rename utilities to u" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/34059 [10:40:38] New patchset: Jdlrobson; "use u rather than jQuery" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/34060 [10:40:39] New patchset: Jdlrobson; "only initialise when jQuery is present" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/34061 [10:56:37] New review: MaxSem; "Upon further investigation, variants have to be included in cache key, otherwise people will start r..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/32718 [11:05:21] New patchset: Jdlrobson; "improve styling of search results page" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/34064 [11:09:11] New patchset: Jdlrobson; "center the heading relative to the back arrow" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/34065 [13:01:02] Change merged: MaxSem; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/34054 [14:56:06] Change merged: MaxSem; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/34056 [14:56:07] Change merged: MaxSem; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/34055 [15:18:08] New review: TheDJ; "replies inline" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/30915 [15:19:40] not to step on anyone's toes, but either fix the system, or accept how stuff works now and the reasons why. [15:20:27] don't work around in hopes that the mobile project will magically turn out different than any of the other stuff we have done so far. [15:39:25] thedj[work], he's not there [15:50:19] who ? [15:50:40] oh jon. it wasn't meant specifically for him. more general [15:51:58] i've seen too many 'skins' over the past 7 years that set off to 'change things' only to end up with a gigantic ammount of 'non-standard' unmaintained css and no fundemental change. [16:08:44] hey Jcmish - any idea whom else we can expect today? [16:12:48] No sir [16:12:54] was going to ask you the same thing :) [16:13:53] I was just digging through my email to see who is around [16:56:54] * awjr waves [16:56:56] good morning everyone [16:59:08] yo [16:59:30] how's it going MaxSem? [17:00:05] without you? lots of unreviewed stuff, hehe [17:00:30] lol [17:00:32] oh goody [17:00:50] im still trying to crawl out from under a mountain of email [17:39:59] MaxSem? [17:40:47] greetings all! [17:40:53] who's wants a tour of the new 3rd floor layout [17:40:53] ? [17:41:05] * awjr does [17:41:07] awjr: MaxSem ? [17:41:12] tfinc yp [17:41:29] awjr: stand up today? [17:41:34] tfinc yah [17:41:52] tfinc: did you just get back last night? [17:41:59] awjr: i did [17:42:03] this is surreal on many levels [17:42:03] tfinc hardcore [17:42:16] juliusz should be here shortly [17:42:17] tfinc i got back around 1130pm on saturday and i still feel totally disoriented [17:42:24] awesome! [17:42:28] tfinc do we get a virtual tour? [17:42:54] awjr: join the hangout [17:44:14] Jcmish: i think tfinc is gonna do it from the standup hangout if you want to join [17:44:51] awjr cool coming [17:56:03] MaxSem: https://gerrit.wikimedia.org/r/#/c/34105/ [18:08:24] MaxSem: so the deployment window right now is for 23:00-1:00 UTC; what would work better for you? [18:08:30] (http://wikitech.wikimedia.org/view/Deployments) [18:10:58] awjr, it's 3-5am my time [18:11:09] yeah that sucks [18:11:16] before it was 2-4 which was a bit more tolerable [18:11:36] but moving it ebven earlier would be awesome [18:12:12] MaxSem: ok let's try 2100 − 2300 [18:12:59] it's unpractical on Monday as it's preceded by the platform window and stuff can happen this time [18:13:43] MaxSem: i changed the time just for tomorrow, if it works out better for everyone we can adjust the time for our usual monday deployment [18:14:12] MaxSem: so i changed the time to 2100-2300UTC (1-3pm PST) tomorrow [18:14:23] cool, thank you [18:21:19] Maryana, hi - we need a tiny bit of design at https://gerrit.wikimedia.org/r/#/c/34057/1/MobileFrontend.i18n.php to formulate the message better [18:22:01] so far i'm pretty happy with the space change [18:22:13] maxsem, is that just the back button on the language selection overlay? [18:22:19] yup [18:22:55] Maryana: howdy! [18:23:09] hey awjr :) happy to have y'all back [18:23:14] glad to be back :) [18:23:24] Maryana: should https://mingle.corp.wikimedia.org/projects/mobile/cards/251 be for both beta and non-beta? [18:24:21] both [18:24:29] i think they're both directing to the same page, no? [18:24:50] it's just we removed the big prominent contact us link from the left nav in non-beta, but it's still there in the footer [18:25:06] they are - however we could still make certain elements on the page display conditionally. [18:25:14] but i think given the bug it makes sense to do this on both [18:25:22] maxsem: that should be covered under the chrome standardization in card 235: https://mingle.corp.wikimedia.org/projects/mobile/cards/235 [18:25:41] so there should be a back arrow in the lefthand corner, and the title should be "language selection" [18:26:00] awjr: agreed [18:26:40] also, you have no mustache now. does that mean you've abdicated your powers? [18:27:24] yeah - change your userpic in G+ at least [18:27:36] Maryana: try to think of the moustache as non-corporeal; it is something bigger than all of us. it lives on in all of our hearts and minds [18:27:54] ...and memories [18:28:07] hehehe [18:28:13] :) [18:29:22] I shaved my beard this year, but was so scared to look into the mirror that I started growing it back immediately! [18:30:13] hahaha [18:34:52] awjr: what prompted getting rid of it? [18:35:05] tfinc: my face just needed to come up for some air [18:35:08] just needed a change [18:35:25] awjr: i hear that. i feel the same way about the office space [18:35:37] tfinc are you liking the new layout so far? [18:35:41] awjr: i am [18:36:50] still no word from brion [18:37:30] that is disconcerting [18:37:36] awjr: any big changes getting deployed this week ? [18:38:33] tfinc michelle will know better than i at the moment, but it looks like we'll have logged in wathclist viewing for beta plus the updates that OTRS has been wanting for contact us so they stop getting hella spammed [18:38:44] ok [18:38:44] and whatever else was scheduled for last week [18:38:46] yay! [18:40:42] ok i gotta run out for a bit, back in ~1 hr [18:46:39] the contact us change just went live [18:48:51] Jcmish, can you sign of https://mingle.corp.wikimedia.org/projects/mobile/cards/212 ? [19:18:52] Hi! I have a question about your jQuery development. Are you strictly using Model View Controller or some templating frameworks? I would like to learn something about the best practice in the mobile team. [19:32:55] netAction, hi! no, we don't use MVC - take a look yourself: https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/MobileFrontend.git;a=tree;h=HEAD;hb=HEAD [19:33:57] MaxSem: Thanks! [19:34:04] netAction, ;) [19:34:39] The internationalization framework on github is yours, right? [19:36:29] in PHP, we use MediaWiki's localisation functions. in JS, they're partially homemade because MW's JS l10n requires jQuery which is not always available for mobile devices [19:37:37] What's wrong with jQuery? [19:38:20] s60 [19:38:41] ...and other feature phones which explode from itXD [19:39:48] Oh didn't know you test those old phones. [19:42:08] And Y U not always use MediaWiki's functions? Are there pure JS pages? It might be bad for search engines if there is no translated HTML. [19:43:02] JS enhances HTML [19:43:16] not generates it from scratch [19:44:44] Sorry MaxSem had to get my son lunch [19:44:55] let me test 212 now and sign off [19:49:27] brion, yo [19:51:30] whee, I scared him [20:01:42] yo yo [20:06:38] howdy brion [20:07:47] brion is in making his desk work mode [20:08:01] heh [20:08:18] new desk…. routine…. disturbed... [20:10:10] these monitors aren't [20:10:22] aren't what? [20:10:58] even [20:11:05] i'm going ocd here ;) [20:11:10] haha [20:11:32] brions screens have been disturbed … be afraid of the brion when this happens [20:11:52] tfinc, how could you let this happen to brion! [20:12:07] and my rolling drawer with phones and adapters is missing. they think they packed it in with the stuff from the big phone drawer, we'll see [20:12:45] so far i like the room and hate my desk. we'll see :) [20:13:14] brion: respond on the thread/wiki page when you've used it for long enough [20:13:19] will do [20:17:11] New patchset: awjrichards; "Removes support for all contact page elements other than techcnical feedback" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/34160 [20:17:28] i hate these monitor arms, i can't lower them [20:19:37] New review: MaxSem; "Can we make these links disableable via configuration?" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/34160 [20:20:34] awjr, can I ask you to review a couple of revs for tomorrow's deployment? [20:20:43] MaxSem: sure thing [20:20:57] https://gerrit.wikimedia.org/r/#/c/33786/ https://gerrit.wikimedia.org/r/#/c/32892/ [20:22:25] New review: awjrichards; "Corresponding configuration change: https://gerrit.wikimedia.org/r/#/c/34183/" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/34160 [20:23:17] New review: awjrichards; "Shouldn't the text be localized/localizable?" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/32892 [20:25:09] New review: MaxSem; "As comment says, we know for sure that this API is used on enwiki only." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/32892 [20:33:03] New review: awjrichards; " sorry, misread the comment! looks fine then." [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/32892 [20:33:03] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/32892 [21:18:11] tfinc: is mobile-tech a list or an alias? [21:18:18] just checking how to add juliusz to it :D [21:18:27] brion: it is a google group and i'll add him now [21:18:32] excellent thx [21:18:43] looks like we got him into google apps \o/ [21:19:23] I can create him a Gerrit account [21:19:55] just need to know his preferred credentials [21:20:44] brion: he's added now. i've sent him our intro email as well [21:21:14] brion: just make sure to give me his bio before you tour him around [21:21:28] MaxSem: we'll go with 'jgonera' as username. need a ssh key? [21:21:31] or pass? [21:21:57] brion, wiki username, email, shell account name [21:22:24] JGonera, jgonera@wikimedia.org, jgonera [21:22:24] MaxSem: see my comment? https://gerrit.wikimedia.org/r/#/c/34160/ [21:23:13] awjr, I was simply thinking that we could need some of this code/mssages in the future [21:23:22] tfinc: can you make me an admin on the github group? looks like i'm just a regular member [21:23:24] https://github.com/wikimedia?tab=members [21:24:08] awjr, I have no problems with your approach [21:24:15] just wanted to be sure [21:24:58] MaxSem: fair enough; i can put in a simple conditional and config param to turn on/off the offending parts of the page instead until we're sure we want to get rid of it. that way we don't give the i18n folks more work than necessary [21:25:48] brion: sure. will do [21:26:29] tx [21:26:31] brion: done [21:27:01] brion, he should receive an email from labsconsole now [21:27:17] thx MaxSem [21:27:18] why he's not on this channel yet?:P [21:30:50] getting him online :) [21:32:13] woohoo [21:32:24] New patchset: MaxSem; "Fix error reporting in action=mobileview" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/34218 [21:32:44] * MaxSem waves at jgonera [21:33:11] * jgonera waves back [21:33:42] New patchset: awjrichards; "A configurable approach to hiding feedback fields other than 'technical feedback'" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/34219 [21:33:43] hi jgonera! [21:33:47] MaxSem: ^^ [21:33:58] ok i think he's added to the github project now [21:34:51] New patchset: awjrichards; "A configurable approach to hiding feedback fields other than 'technical feedback'" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/34219 [21:35:01] fixes WS ^ [21:35:19] closed wrong window :P [21:42:03] New review: Brion VIBBER; "Fun... I'll take a peek at this. Parser cache should already include variant in its key, but if we'r..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/32718 [21:45:11] New review: MaxSem; "Note that parser cache is already included in our cache key in some but not all cases (madness sweet..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/32718 [21:49:18] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/34218 [21:58:44] Jcmish: sent you a new apk with extra error logging [22:00:12] sweet [22:00:13] thanks [22:00:24] I'll get it loaded up after I finish 212 [22:09:56] okay, since we'll deploy our latest MF tomorrow, we can use our today's window for other stuff - how about Wikivoyage testing? [22:10:48] im OK with that - perhaps we should dbl check with Reedy that this shouldn't cause any problems? [22:11:02] it's still our window [22:11:26] Monday 3 p.m. - 5 p.m. MobileFrontend updates [Patrick / Arthur / Max] [22:11:43] i know, i just want to dbl check that everything else is set with Wikivoyage that the change won't cause any problems [22:11:56] got it [22:12:28] Reedy: any reason why we shouldn't deploy this in 45 minutes? https://gerrit.wikimedia.org/r/#/c/34220/1 [22:12:55] Have we got the load balancers setup? [22:13:13] as the links to Mobile view were useless and that's the reason we disabled it for now [22:13:25] * awjr shrugs [22:13:36] what do the links to mobile view have to do with load balancers? [22:13:43] Reedy, the mobile domains are now created [22:14:15] from comments, it seems that the cause was in them [22:14:44] but the redirector wouldn't have redirected to .m. unless we told it:) [22:14:53] yeah, unless there was additional configuration done, enabling MF on a site without .m domains set up would cause the links to not work [22:23:05] Change merged: MaxSem; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/34219 [22:24:06] Change abandoned: MaxSem; "Solved differently in https://gerrit.wikimedia.org/r/#/c/34219/" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/34160 [22:35:09] is this the best bug for the iOS landscape issue https://bugzilla.wikimedia.org/show_bug.cgi?id=41791 ? [22:41:36] maxsem: ori has a small change to enable eventlogging (code's already deployed, as far as i understand, just needs the on switch flipped) - is that slotted for tomorrow's deployment? [22:41:47] yes [22:41:57] sweet. thx! [22:42:05] I'd not call it small though as it requires some testing [22:42:43] ok, good to know. happy to help w/that [22:42:58] on the data validation front, anyway :) [22:43:43] MaxSem: awjr If that stuff is sorted, please feel free to re-enable it [22:51:53] MaxSem: hey [22:52:19] ori-l, hey [22:52:34] I plan to deploy logging tomorrow [22:52:44] i'm available throughout the day tomorrow and can clear my schedule to make myself available for testing and verification [22:53:01] cool! :) [22:54:12] MaxSem: is there anything you want me to do ahead of time? [22:54:40] ori-l, anything I should be afraid of?:) [22:55:29] so, thinking out loud, the kind of problems this change could introduce are: [22:55:47] 1) plain stupid javascript errors in the logging code. [22:56:35] i don't have access to a lot of mobile devices, so it's possible that something will break on a weird browser combination [22:57:04] this patch isn't any different than any other bit of javascript code you guys deploy, though [22:57:43] 2) accidentally generating an order of magnitude more events than we were expecting [22:58:16] it would have to be several orders of magnitude, probably. we've logged several million events before in a 24/h period and couldn't even make the servers sweat [22:58:31] and this change would only go out to the mobile beta [22:59:11] what i could do fairly easily is expose the live stream of incoming events on a page that is accessible to you [22:59:58] so we could do what jon and i did a couple of weeks ago, which just load the page on a dev instance, interact with it, and confirm that the events that are generating match (in quantity and kind) what we're producing. [23:01:22] okay boys and girls, our window [23:02:07] finally, i don't want to be cavalier about this, but it is good to know that rolling this back is as simple as toggling a bool config var. [23:02:22] but i don't want to distract you from your deployment -- so feel free to ping me and let me know what you think / what your preferences are whenever you have time. [23:02:55] ori-l it would probably be good then if you can keep an eye on things during/after our deployment tmrw - the window starts at 1pm pacific [23:03:14] MaxSem: are you pushing out the change for wikivoyage or shall i? [23:03:17] wait, did the time change? [23:03:35] didn't it used to be from 3-5 pst? [23:03:37] awjr, I;m already in process:) [23:03:41] Maryana: it did for tomorrow, i emailed out about it this morning [23:03:49] MaxSem: far out [23:04:33] awjr: OK, i'll be on the channel and available from noon to 16:00 pst (so an hour before to an hour after deployment) at the very minimum [23:04:43] ori-l: sweet thanks :) [23:05:01] thanks -- i'm off, good luck with your deployment today. [23:05:54] * Maryana didn't get the deployment email :( [23:06:03] oh well, at least i know now! [23:06:17] and i'm happy to hang out w/ori and sanity check the data we're getting [23:06:19] gahhh damn it i didn't cc you guys [23:06:28] i wonder if we should just add you to mobile-tech, i always forget [23:08:46] nexus 10 pretty awesome looking so far :) [23:09:55] okay, here we go: https://en.m.wikivoyage.org/wiki/Dar_es_Salaam [23:11:55] cert error [23:12:42] non-ssl looks ok [23:13:36] home page needs to be marked up [23:16:25] aside from the SSL error looks good :p [23:24:10] I've set up a main page [23:27:21] w00t! [23:29:12] I was also thinking about deploying but not enabing Ext:Solarium to avoid scapping later [23:34:33] MaxSem: ! [23:34:46] it will be used by Translate soon and GeoData later [23:35:21] any objections? [23:35:24] cool - is that going to be part of the deployment tomrorow? will anything be using it once it's live? [23:36:36] I wanted to do it today to avoid distractions tomorrow / not right now [23:38:28] makes sense [23:42:15] we have a hefty cr back log [23:42:37] awjr: MaxSem brion : how is your time to get it back in order ? [23:43:08] tfinc i've already started working on it [23:43:24] it's mostly out of my domain, I'm trying to do what I can with it [23:45:02] i'm testing that iPad and iPhone rotation issue, will continue on CR after [23:47:41] some of it may require some input from jon (the photo upload stuff from the devcamp) [23:48:02] it probably would've been better to do that work in a remote branch [23:49:41] awjr: i thought we were going to do all beta work on branches ? [23:50:12] tfinc not necessarily beta work, but experimental work should be done in remote branches [23:50:18] brion: Wikipedia 3.2.2 (iOS) has been approved [23:50:35] awjr: lets make that a rule rather then a suggestion [23:50:41] yay [23:50:45] brion: we need to pick a time to release it [23:50:50] its just our minor bug fix release [23:50:59] it's a minor fix, push it anytime i guess [23:51:08] k, i'll hit the switch now if you can monitor [23:52:02] ok [23:52:46] released [23:53:42] tfinc aye - i believe that is what we discussed when we were having conversations around deployment issues, but im not seeing it in the notes [23:54:16] so perhaps we just talked around it. i'll bring it up again [23:59:57] New patchset: awjrichards; "nest table rules" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/32546