[00:14:15] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/32546 [00:14:47] New patchset: awjrichards; "nest table rules 2" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/32547 [00:15:20] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/32547 [00:16:28] grr, trying to update iOS to cordova 2.2 but having troubles. something's not completing loading [00:26:32] MaxSem or awjr: All of a sudden on staging I'm getting this [00:26:52] Welcome to Ubuntu 12.04.1 LTS (GNU/Linux 3.2.0-32-virtual x86_64) System information disabled due to load higher than 1.0 13 packages can be updated. 0 updates are security updates. The last Puppet run was at Tue Nov 20 00:09:59 UTC 2012 (13 minutes ago). Get cloud support with Ubuntu Advantage Cloud Guest http://www.ubuntu.com/business/services/cloud *** /dev/vdb will be checked for errors at next reboot *** *** Sy [00:27:12] Is that a preilly thing? [00:27:21] or do we have access to reboot? [00:28:09] we have access to reboot, but is it necessary? [00:28:14] sudo reboot [00:28:20] but it won't help:0 [00:28:24] :( [00:29:00] bummer so do i just have to wait it out until the load normalizes? [00:29:30] are you unable to do stuff? [00:29:40] I wanted to do another update of code [00:29:44] and run through some more testing [00:29:48] but I can sit it out :) [00:30:05] wait im confused - is it not letting you update code? [00:30:44] the machine is pretty slow these days [00:31:17] MaxSem was right [00:31:18] it was just really slow [00:31:29] oh gotcha - were you waiting for a prompt or something? [00:31:29] the prompt just returned [00:31:32] yupper [00:31:35] I've stopped a background import, might be a bit faster [00:31:45] I started creating new swear words :D [00:31:53] lol [00:31:53] so the time wasn't wasted ;-) [00:32:01] welcome to labs! [00:32:05] hahahah [00:32:15] I know huh, sorry for the false alarm guys [00:32:31] brion [00:32:44] I need to get the boys dinner started [00:32:48] no prob [00:32:52] but I'll get the logs for you in a bit [00:33:02] ping me when you get em :) [00:33:05] you bet [00:33:15] and I can't get to googledocs [00:33:20] :( [00:33:23] with my wikimedia log in for some reason [00:33:33] can you not download the .apk from there? [00:33:42] no sir :( [00:33:49] i'll stick it on dropbox instead, that seems more reliable for sharing files [00:33:57] sweet [00:34:04] I was gonna say dropbox has worked with me and Yuvi [00:35:05] durrrr i set the settings wrong [00:35:08] Jcmish: try it again [00:35:13] k trying [00:35:44] i forgot to actually share the file ;) [00:35:58] i see an anonymous user :D [00:36:11] brion success! [00:36:12] haha [00:36:18] \o/ woohoo [00:36:25] I so know the feeling :D [00:36:32] I'll get it going right after dinner thanks [00:36:57] New review: awjrichards; "Have you run this approach by product yet?" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/32552 [00:37:53] New patchset: awjrichards; "nest specific table rules / throw away strange rules" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/32548 [00:38:07] New patchset: awjrichards; "nest tbody under table" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/32549 [00:38:11] New patchset: awjrichards; "table styling cleanup" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/32551 [00:40:18] New review: awjrichards; "have you run this by product yet?" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/32548 [00:43:24] * tfinc is starting to lose the battle against jet lag [00:43:43] * tfinc goes on a coffee run before meeting with google [00:54:28] greetings notnarayan [01:05:15] ok im outta here, see you all tomorrow [01:10:17] tfinc: greetings and salutations ! [01:10:41] tfinc: hope you had a good tour of India [01:18:07] getting back to my morning practice session. [02:14:42] the wireframes for the Commons app has been updated https://www.mediawiki.org/wiki/File:Commons_app_wireframe.pdf [02:20:56] New review: Jdlrobson; "Why would I.. this commit is refactoring the css into less syntax and throwing away redundant ones.." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/32548 [02:22:45] New review: Jdlrobson; "Nope.. but in my opinion the current experience is completely broken (it's a bug) and we should expe..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/32552 [17:14:47] no brion :( [17:16:40] New review: Jdlrobson; "This is pretty important and first got uploaded at the end of October. Please get this deployed it's..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/30309 [17:17:59] yuvipanda: is alive :) [17:18:11] notnarayan: sortof [17:18:24] yuvipanda: which city ? [17:18:29] aurangabad [17:18:45] ah! did you see the caves yet? [17:19:03] notnarayan: we saw one [17:19:13] notnarayan: rmoen is with me here, along with jdlrobson [17:19:18] notnarayan: we're going to the other ones tomorrow [17:19:22] notnarayan: hi shankur :) [17:19:37] shankar.. my mistake [17:19:44] rmoen: :) [17:19:52] New review: Jdlrobson; "Why is this not merged yet?" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/30811 [17:19:54] Good to know this is you [17:19:57] notnarayan: https://commons.wikimedia.org/wiki/Special:Contributions/Yuvipanda [17:20:43] the names' notnarayan :) http://shankarnarayan.in/notnarayan/ [17:20:59] notnarayan: you don't like the name shankar? [17:21:13] yuvipanda: i dint have a choice :P [17:21:17] heh [17:21:29] this one is uploaded by commons app :) [17:21:47] notnarayan: i didn't have a choice with my name either... damn parents [17:22:02] rmoen: ha ha ha. true! [17:22:34] notnarayan: https://commons.wikimedia.org/wiki/File:Panorama_of_Outskirts_of_Aurangabad_from_Aurangabad_Caves.jpeg panorama! [17:22:41] rmoen: letting a kid pick a name is a worthwhile experiment methinks. [17:22:54] hello Ford_Prefect [17:22:58] o/ yuvipanda [17:23:07] Ford_Prefect: AUTOJOIN THIS [17:23:29] Hmmm [17:23:31] yuvipanda thats one good picture. [17:23:36] notnarayan: some cultures actually do this me thinks [17:23:44] yuvipanda: :) [17:23:51] tfinc, hi tom ;) [17:23:54] Ford_Prefect: https://commons.wikimedia.org/wiki/File:Recording_of_rickety_sleeper_bus_from_Pune_to_Aurangabad.ogg [17:24:00] audio upload from a bus in the middle of nowhere [17:24:02] i've to hear it now [17:24:18] * rmoen takes the bandaid off pointer finger [17:24:37] * tfinc looks around [17:24:40] Ford_Prefect: okay, that's a very boring upload [17:24:41] tfinc: have you adjusted to sf time ? [17:24:42] rmoen: which culture is this, may there tribe increase. [17:24:45] rmoen: yuvipanda jdlrobson : i see your still alive [17:24:48] thats a good update [17:24:52] * awjr waves [17:24:57] Thankfully so [17:24:57] just about [17:24:59] tfinc: aren't you glad we're on IRC? [17:25:06] hello tfinc [17:25:08] jdlrobson, rmoen, yuvipanda where are you guys? [17:25:09] i sure am [17:25:15] how was the taj ? [17:25:19] yuvipanda: but it's from The App, so it's awesome :p [17:25:25] bit dull [17:25:26] Ford_Prefect: true dat! [17:25:30] caves were better [17:25:36] tfinc: not as big as we expected, really. [17:25:37] Not what we expected [17:25:48] thats why i told you guys to make it a day trip at most [17:25:49] people seemed surprise to see white people [17:25:56] there isn't that much more to do there [17:26:04] what is the next stop ? [17:26:16] Agra is next [17:26:16] is this ajanta or elora? [17:26:25] Aurangabad caves [17:26:42] I think we've a bus to Pune? [17:26:48] grr buses [17:26:53] * yuvipanda <3 buses [17:26:56] jdlrobson: juliusz is eager to see you get back [17:27:02] Ford_Prefect: thoughts on video? [17:27:06] awjr: aurangabad [17:27:17] tfinc: he wants to hit me about my code already? [17:27:22] are you not going to ajanta + elora? [17:27:24] he's only been here 1 day..! [17:27:30] Elora tomorrow notnarayan :) [17:27:34] yuvipanda: good question. I need to figure out some transcoding stuff with upstream, but in the mean time, 2 problems [17:27:41] 1. What formats are okay to upload [17:27:44] We are definitely doing elora tomorrow and maybe ajanta if we dont make the train [17:27:56] rmoen: ah, nice. [17:27:59] 2. How we want to get the user to set resolution, etc. [17:28:08] i'm sure he will in due time. he'll be setting up his envs today [17:28:15] i think he'll enjoy having a desk mate [17:28:21] as you guys are sharing a desk [17:28:28] Ford_Prefect: I think for now, (1) will be good? [17:28:49] glad to see hammock still is intact [17:28:49] Ford_Prefect: and just re-encode into the same bitrate and resolution? [17:28:59] we think a dog just died outside [17:29:04] rmoen: ajanta caves are massive, but so is elora. [17:29:12] yuvipanda: Could be nasty with things doing 1080p recording [17:29:14] jdlrobson: get my photo of it? [17:29:26] we ended up putting it right next to the collab space [17:29:27] yuvipanda: also, transcoding cost for high res is high [17:29:28] fits quite nicely [17:29:29] rmoen: ajanta caves still showcase some good paintings. [17:29:32] yep tfinc [17:29:38] Ford_Prefect: well, it's 'experimental' [17:30:05] Ford_Prefect: but we need to figure out (1) and i'm not sure what's supported now, with TMH on [17:30:12] documentation seems super scarce [17:30:13] hello tfinc, you back home? [17:30:21] notnarayan: i am [17:31:02] yuvipanda: well, the sensible options to serve are really h264+aac+mp4 and vp8+vorbis+webm [17:31:11] Ford_Prefect: hehe 'sensible' [17:31:22] tfinc: i was looking at this https://www.mediawiki.org/wiki/Mobile_design [17:31:30] notnarayan: That's great, part of me wants to do both but I think we have a two night rule to abide by. If the gods keep us here, we will be making a day of each [17:31:45] yuvipanda: :) for reasonable quality and browser support [17:32:20] tfinc: is this still the active version? [17:32:23] jdlrobson: pm [17:32:35] Ford_Prefect: https://en.wikipedia.org/wiki/User:RobLa-WMF/Video_testing [17:32:42] is the samples from the new infrastructure [17:32:54] notnarayan: i was never a big fan of that page as it doesn't give you an easy way to identify whats happening right now [17:33:03] it includes some new and some completed items [17:33:27] oh wait .. this is a different page [17:33:46] notnarayan: yeah, it looks up to date [17:33:59] tfinc: yes, i was looking for a page that shows 1) whats happening 2) whats next so i can do something [17:34:57] yuvipanda: hum, all ogv [17:34:57] tfinc: last night in goa, this happened -> http://instagram.com/p/SLpYG0hx-v/ [17:35:24] rmoen: i would have been happier not to see that [17:35:32] rmoen: ouch! [17:35:41] tfinc, sorry pretty brutal [17:35:43] warning next time [17:35:49] deal [17:35:57] rmoen is a walking disaster [17:36:05] tfinc: whats next? that is after commons [17:36:05] Literally [17:36:22] I cut my finger last night unlocking a bathroom door [17:36:42] apparently they don't sand down the edges of metal in this country [17:37:15] rmoen: we don't waste metal in here [17:37:26] Ford_Prefect: https://www.mediawiki.org/wiki/Extension:TimedMediaHandler is the extension page [17:37:35] Ford_Prefect: i'm not sure who's the best person to talk about that to, though. I'll poke around [17:37:44] Ford_Prefect: but yeah, i'm perfectly happy doing just audio [17:37:52] notnarayan: check http://www.mediawiki.org/wiki/Wikimedia_Engineering/2012-13_Goals#Mobile for the annual roadmap [17:37:57] not forgetting rmoen banging his head on the door [17:38:02] in the taj [17:38:10] "taj" [17:38:15] yuvipanda: it does list webm [17:38:46] Ford_Prefect: also, ffmpeg - no gstreamer :P [17:39:23] yuvipanda: for the server-side transcode? Pretty typical. :) [17:39:31] tfinc: https://commons.wikimedia.org/wiki/File:Panorama_of_Outskirts_of_Aurangabad_from_Aurangabad_Caves.jpeg panorama from here. (No blood) [17:41:00] tfinc: any idea if brion is coming in today? [17:41:27] yuvipanda: this beautiful yuvi. i didn't know your phone could go into the past [17:41:29] "6 January 1970 (according to EXIF data)" [17:41:34] just days after the epoch [17:41:41] heh [17:41:54] yuvipanda: he'll be here today just like yesterday [17:41:59] i expect him in .. in the next hour [17:42:06] cool [17:42:22] tfinc: yup, we can travel to the past now since we're no longer limited by PhoneGap [17:42:36] More importantly, you can travel to the future :p [17:43:30] Ford_Prefect: I think anyone who invents a time travelling machine immediately goes to the future, with no way of coming back. Explains a lot [17:44:00] Ford_Prefect: i'm on 3g and can't re-download the gst sdk. Anything else I could od? [17:44:01] *do? [17:44:06] i mailed him the xml file [17:45:27] yuvipanda: hum, I could probably do a build with a newer SDK [17:46:29] Ford_Prefect: sure [17:46:47] Ford_Prefect: also you need to fix your git config. Still newer comits coming with the collabra id :P [17:46:56] o+O [17:47:11] Not that it matters, but that shouldn't happen [17:48:04] yeah [17:48:06] see your last commit [17:48:09] also i merged it to master [17:48:12] on wikimedia/commons [17:48:49] yuvipanda: I'm going to be talking to howie about our commons app discussion [17:48:56] yuvipanda: any updates that you want me to pass on? [17:49:07] margle: [17:49:18] netAction: ? [17:49:19] ups sorry [17:49:24] np. [17:50:08] tfinc: you're going to talk now? [17:50:29] in about 30 min [17:50:32] tfinc: no, nothing after that. That diagram and our discussion covered it [17:50:36] k [17:50:54] tfinc: do put up an etherpad if you can, I'd like to help shape the discussion from the start [17:50:59] i wasn't awake enough to update the wiki page so i'm just going to walk him through our prelim discussion [17:51:20] i'm sure he's going to wonder why we made certain choices [17:51:21] yeah, cool! [17:51:28] but all of it is clearly experimental right now [17:51:34] and were just tossing out ideas [17:51:34] tfinc: I'll be up for a while more if you want details [17:51:45] k [17:52:33] jdlrobson: i'm eager to see if i can get the CR backlog down to zero before we break for the hoildays [17:52:47] that would make me happy [17:52:52] i don't want to spend the first week rebasing [17:52:52] * tfinc ponders opening up the rest of his moving boxes [17:52:54] ;-) [17:52:57] Ford_Prefect: you know the kaltura guys? [17:53:01] tfinc: can we add maryana and howie to mobile-tech? we keep forgetting to cc them on important emails they should see on mobile-tech [17:53:03] * tfinc dreads opening put he rest of his moving boxes [17:53:10] yuvipanda: nope [17:53:13] awjr: do it [17:53:17] what's juliuz's username ? [17:53:19] tfinc: how? [17:53:20] (on irc) [17:53:31] granted that does mean that we lose the inter team discussion space [17:53:33] are you guys ok with htat? [17:53:36] awjr: --^ [17:53:39] intra* [17:54:00] Ford_Prefect: hmm, they + goog did most of the work on the vid stuff [17:54:04] tfinc i'll send an email to mobile-tech asking that question :) [17:54:17] gawd i wish i had photo uploads from mobilefrontend - have had so many opportunities this trip! [17:54:23] awjr: your a group owner just like i am [17:54:47] tfinc i probably knew that once [17:54:53] jdlrobson: where are you hosting the photo uploads that you were showing me ? [17:55:10] i'm eager to show that to howie as well [17:55:13] jdlrobson: use the app :P [17:55:31] awjr: start the discussion and see where it goes. you already have all the power to change it [17:55:31] yuvipanda: jdlrobson yeah, use the app :) [17:55:37] tfinc yup [17:55:38] thanks [17:55:45] don't like apps! [17:56:53] awjr: what do you and brion have for juliusz to dive into next week ? [17:57:26] tfinc talk to Jcmish as she's been managing our current bug/qa sprint which will go through next week [17:57:37] Jcmish: --^ [17:58:20] inline styles tfinc ? :P [17:58:25] can I just walk through them with him? [17:59:29] yuvipanda: well, they do webm according to the TMH wiki, and that should be a good enough starting point [18:00:12] Ford_Prefect: iirc it's disabled right now [18:00:28] jdlrobson: you realize we're now scrubbing *some* inline styles in the app? :P [18:00:34] Ford_Prefect: also, how does that affect us? [18:01:15] Ford_Prefect: we're just doing uploads no [18:01:19] yuvipanda: I see that mp3 transcode on-server is deferred until the patents expire, which doesn't bode well for doing h.264/aac transcode [18:01:43] yuvipanda: true, we could just as well be doing theora + vorbis + ogg, easy enough to switch over [18:01:46] Ford_Prefect: yeah, is that like, 'forever'? [18:02:14] Don't know. For non-commercial use, h.264 is available till 2015 iirc [18:02:23] available royalty-free, that is [18:02:45] yuvipanda: MaxSem|away won't let me scrub inline styles :-( .. at least not in the php [18:02:48] Ford_Prefect: I think it's still too politicized. I think brion would have a better idea when he's back [18:03:03] jdlrobson: well, I just add an extra class to the ones I wanna scrub and !important the fuck outta them :P [18:03:33] okay, pseudo-scrubbing [18:03:43] $('[style]').removeAttr('style'); [18:03:54] yuvipanda: UX wise, doing unaccelerated video encode on mobile is suicide, imo [18:04:25] It's doable as a toy, and we should do some quick experiments to quantify how bad it is before dismissing it [18:04:47] Ford_Prefect: true, audio was much faster than we thought, no? [18:04:54] It was indeed [18:05:26] Ford_Prefect: or maybe it was just that we were using (literally) top of the line hardware [18:05:40] It was still faster than expected [18:05:48] Hang on, let me get you that debug apk first [18:06:04] And then I'll modify it to do a video transcode [18:07:50] Ford_Prefect: ok [18:16:00] tfinc? [18:18:53] jcmish1: yes? [18:18:59] howdy [18:19:24] so Juliansz… I'll just walk through what we have on the board and see if they are things he can tackle? [18:19:29] does that sound good? [18:20:30] jcmish1: you should walk through the backlog with brion and see whats appropriate for juliusz to handle [18:20:33] brion is on boarding him [18:20:42] sounds good [18:20:52] that way brion knows what he'll have to support [18:21:13] speaking of the brion [18:21:26] heyyyy [18:21:33] brion: are you not coming into the office today? [18:21:49] do we have a jgonera? [18:22:02] brion: he's sitting right across from me [18:22:05] figured i'd be in in a bit [18:22:08] excellent. get him on irc :) [18:23:35] Maryana: desk is mostly clean now [18:23:49] heh. i will wheel over [18:25:40] also heads up tfinc Maryana awjr http://www.mediawiki.org/w/index.php?title=Extension_talk:MobileFrontend&offset=20121117181255&lqt_mustshow=20527#Howto_switch_to_mobile_Version_20527 / https://bugzilla.wikimedia.org/show_bug.cgi?id=36894 < would love to get this prioritized and fixed [18:26:21] * jdlrobson waves at jgonera [18:27:57] i can't figure out if sj is requesting a visible article URL or an &action=edit URL [18:28:12] jdlrobson: yeah that'll be nice to fix. it shouldn't be that hard…. [18:28:25] yuvipanda: new SDK changes one of the gst class names :/ [18:28:38] Caught me by surprise, but oh well [18:28:47] yuvipanda: http://arunraghavan.net/temp/wmf-commons.git-debug.apk [18:30:00] Ford_Prefect: heh [18:30:02] hey Brooke [18:30:03] yuvipanda: hey did you get the contact information of the guy who was working on the objc mwapi library? [18:30:03] err [18:30:04] sorry [18:30:06] brion: [18:30:27] brion: he forked it off of yours [18:30:37] brion: I also got contacted by two folks who want to do the same thing today [18:30:52] ah good should be able to find him them [18:30:54] heh spiffy [18:33:17] yuvipanda: that thing won't crash for you [18:34:55] Ford_Prefect: when doing what? [18:34:59] Ford_Prefect: wav? amr? [18:35:47] yuvipanda: if you recall, it crashed on startup [18:35:52] ooh, virtual box update to install [18:36:09] yuvipanda: while trying to initialised the Android MediaCodec wrapper plugin [18:37:26] yuvipanda: redownload and install the apk please (included the plugin in the build this time) [18:37:39] Ford_Prefect: slloooow connection [18:37:43] redoing it [18:37:49] Sorry, my bad for forgetting the first time [18:39:06] yuvipanda: going to crash now, though [18:39:18] Video encoding will need to wait [18:40:22] heh [18:40:24] good night [18:43:22] o/ [18:57:58] * ori-l 's here, but semi-afk for a few [19:22:08] meh [19:23:12] MaxSem: is anybody working on JS issues right now? [19:23:43] what JS issues? *looks in email* [19:24:38] MaxSem: I was trying to ask is there anybody available to look at a JS bug [19:25:21] I can try [19:25:54] MaxSem: The banner isn't showing on http://en.zero.wikipedia.org/wiki/Special:ZeroRatedMobileAccess?useformat=mobile [19:25:57] oh, but we have jgonera now!:) [19:26:50] MaxSem: you will need to do something like: RequestHeader set X-CARRIER "DTAC" in Firefox to see a banner [19:26:59] MaxSem: but it isn't showing on the landing page [19:28:59] preilly, what FF extension do I need? [19:29:28] Here is the text: …Free preilly Access by DTAC Thailand [19:29:40] MaxSem: Modify Headers extension for FF [19:31:09] jcmish1, how are we looking WRT deployment? [19:31:55] I think we're looking good [19:32:15] cool [19:32:30] MaxSem: https://gerrit.wikimedia.org/r/#/c/32864/ [19:32:37] I just finished looking at 251 [19:32:54] what time we starting deployment today MaxSem? [19:33:04] 1pm PST [19:33:13] k cool thanks [19:33:23] ori-l, I'll deploy it with other changes then [19:33:36] I haven't forgotten about it:) [19:35:39] cool [19:36:59] preilly: what is the problem exactly? [19:37:36] ori-l: we don't see the carrier banner at http://en.zero.wikipedia.org/wiki/Special:ZeroRatedMobileAccess?useformat=mobile [19:37:57] ori-l: something to do with jdlrobson's mw-mf-banner refactor [19:38:26] ori-l: for example in the console if you do a $('.mw-mf-banner').show(); you see it [19:41:14] ori-l: also note that it doesn't render in the correct position [19:43:15] unfortunately, Zero has very low visibility for all of us [19:46:19] MaxSem: well that will need to be fixed or at least addressed moving forward [19:46:39] MaxSem: basically this issue occurred with Jon's mw-mf-banner refactor [19:46:42] preilly, can you repro it locally? [19:46:49] MaxSem: yes [19:46:59] bisect? [19:47:36] MaxSem: Divide into two parts?!? [19:47:45] git bisect:) [19:47:56] MaxSem: делить пополам? [19:48:08] на ноль [19:48:17] it has an inline style setting it to display:hidden, but the js seems to presume it is visible by default: [19:48:22] MaxSem: you want me to search? [19:48:30] if ( zeroRatedBannerVisibility === 'off' ) { banner.style.display = 'none'; } [19:48:48] and zero ha ha [19:52:18] WTF, FireBug doesn't step inside of $( '.mw-mf-banner' ).each( function() { for me [19:52:34] even though $( '.mw-mf-banner' ) is not empty [19:52:38] "you go ahead, i'll stay right here" [19:53:07] * MaxSem tries Dragonfly [19:53:18] ori-l: notice how it works on any other page [19:53:34] ori-l: e.g., http://en.zero.wikipedia.org/wiki/Windsor_Castle?zeropartner=1002&renderZeroRatedBanner=true [19:54:10] ori-l: this code is in gerrit.wikimedia.org:29418/mediawiki/extensions/ZeroRatedMobileAccess.git and gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend.git [19:54:59] haha, Dragonfly rules [19:55:02] preilly: the HTML output (pre-js) doesn't have display:none for the inline style in the windsor castle example [19:55:12] so it's probably in php somewhere, let me check out the repo [19:55:34] ori-l: includes/MobileFrontend.body.php:88: $zeroRatedBanner = $this->zeroRatedBanner ? str_replace( 'display:none;', '', $this->zeroRatedBanner ) : ''; [19:56:17]