[00:00:19] I'm writing a commit message for this hash bug fix [00:34:10] New patchset: JGonera; "(bug 41514) Hash links broken in mobile" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/34680 [00:42:15] jgonera, congrats with your first commit! [00:42:25] (I've just -1'd it:) [00:54:53] MaxSem, hah, sorry I really have to force myself to write spaces after/before parentheses. I never did and I'm not a big fan either ;) [00:55:25] MaxSem, so I just amend the commit and do git review again? [00:55:49] I just had to find some nitpick, otherwise it would have been unpedagogical:) [00:55:51] yes [00:57:04] anyway, good night [00:59:10] good night :) [01:00:27] New patchset: JGonera; "(bug 41514) Hash links broken in mobile" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/34680 [03:56:49] New review: Jdlrobson; "thanks for feedback ori. I agree mostly." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/30309 [04:29:35] New review: Jdlrobson; "Not clear from commit message what this does.... without JavaScript sections will never expand.. Wha..." [mediawiki/extensions/MobileFrontend] (esisupport); V: 0 C: 0; - https://gerrit.wikimedia.org/r/32899 [06:05:29] New review: Jdlrobson; "if watchlist.js is empty let's remove it. its existence will be confusing and we cannot be sure it w..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/29621 [11:02:53] New patchset: Ori.livneh; "Replace setting() with get/setConfig; update title on history change." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30309 [11:06:28] New review: Ori.livneh; "This is untested, unfortunately -- I don't have a MobileFrontend development setup. If a mobile dev..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/30309 [16:02:57] hi MaxSem [16:03:08] hi Shankar [16:03:31] how have you been MaxSem [16:03:49] pretty good [16:04:20] what was the name of that vodka you brought, the taller bottle. [16:05:32] I don't remeber what were their dimensions, the former or latter one? [16:07:19] the latter. [16:07:41] Beluga [16:07:55] MaxSem: fine vodka. [16:08:27] :) [16:09:25] MaxSem: what you working on these days? [16:09:38] MobileFrontend/GeoData [16:54:08] New review: Jdlrobson; "I assume you are referring to the commit " [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/32561 [16:56:38] New patchset: Jdlrobson; "address todo comment" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/34057 [17:16:31] New patchset: Jdlrobson; "adjust random function" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/32560 [19:12:25] mobile-feedback: "I want to make donation to Wikipedia, please add in-app purchase option to this app."