[00:00:16] New patchset: Jdlrobson; "(bug 41509) Fix styling of galleries on mobile" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30915 [00:01:35] New patchset: Jdlrobson; "(bug 41509) Fix styling of galleries on mobile" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30915 [00:01:56] New review: Jdlrobson; "TheDj this looks good to me now. If you're happy please +1 and I'll merge" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/30915 [00:05:03] jdlrobson: i dont follow what you're saying in your comment: https://gerrit.wikimedia.org/r/#/c/35591/1 ? [00:05:53] and btw are you managing to stay awake? [00:26:10] ok …. finally able to sit down [00:26:14] awjr: how did you feel about our HR talks ? [00:27:01] tfinc: i felt good about it, but i couldn't see the audience so i have no idea a) how many people where there b) if people were falling asleep or hanging on to every word [00:27:13] there were about 5-10 people [00:27:17] passive attention [00:27:23] right on [00:27:23] i thought you carried the talk well not being able to see anyone [00:27:37] heh thanks, it was kinda unnerving [00:27:46] but also made it easier in some ways [00:27:50] what'd you thnk? [00:28:03] i want more questions next time [00:28:06] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/35787 [00:28:16] yeah i was surprised by that [00:28:25] were there newbies in the crowd? [00:28:31] lotsa newbies [00:28:48] sweet [00:29:33] New review: JGonera; "See minor things in the inline comment." [mediawiki/extensions/MobileFrontend] (master) C: 0; - https://gerrit.wikimedia.org/r/34058 [00:30:23] yay jgonera and code review! [00:30:25] \o/ [00:30:52] awjr, give me more time, I'm still getting used to gerrit ;) [00:30:58] hahaha jgonera me too :p [00:31:12] plus, I don't want to judge too much while I still don't know the codebase well [00:31:24] (which should also change in a few days) [00:31:33] tfinc: did you think going over the OSI open source definition was too much? i thought about cutting it out, but it felt important [00:32:09] jgonera: totally understand - we'll have you +2'ing in no time :) [00:33:04] New patchset: Jdlrobson; "jshint all the code base" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/35789 [00:34:15] awjr: MaxSem any idea about https://gerrit.wikimedia.org/r/#/c/34058/1/includes/skins/SkinMobile.php ? [00:34:22] ( jgonera 's comment [00:34:32] * awjr looks [00:34:57] awjr: liked it as a dev. not sure how the non devs felt [00:37:24] roger that [00:40:41] jdlrobson: MaxSem should know better; raw is something magical in ResourceLoader and the other params are opaque. it would be nice to have that method documented [00:41:08] raw is nothing magic [00:41:09] awjr: MaxSem preilly : what job title (for the partner engineer) would you respond to : Software Developer, Partner Engineer, something else ? [00:41:35] tfinc: Partnership Engineer [00:41:42] raw simply tells Rl to omit the mw.loader.state() calls [00:41:45] tfinc: software developer or software engineer [00:42:11] tfinc looks like you need a third voter [00:42:21] Partner Engineer is vague and not necessarily sounds like a dev job [00:42:50] http://www.quora.com/Facebook-1/What-is-the-role-of-a-partner-engineer-at-Facebook [00:45:15] and specifically https://www.facebook.com/careers/department?dept=engineering&req=a2KA0000000E5fMMAS [00:45:15] tfinc: when you previously switched the title on the job req did you see more or less applicants? [00:45:36] qualified, or promissing candidates, i should say [00:45:49] no significant difference in high quality candidates [00:46:14] honestly likely more less qualified candidates as it was so generic [00:46:30] preilly: Partnership vs Partner ? [00:47:21] when i talked with RobLa he mentioned that this is a classic Sales Engineer position [00:47:26] but that wouldn't make much sense here [00:49:03] where here = non profit [00:49:15] fs i hate gerrit [00:50:49] jdlrobson: what happened? [00:51:03] I uploaded https://gerrit.wikimedia.org/r/#/c/32683/7 [00:51:22] I then rebased a subsequent change [00:51:31] and it uploaded https://gerrit.wikimedia.org/r/#/c/32683/8 [00:51:47] I want https://gerrit.wikimedia.org/r/#/c/32683/7 to be reviewed not 8 [00:52:03] but I can't seem to send 7 back for review [00:52:08] ! [00:52:17] madness [00:52:54] fs [00:53:28] also MaxSem I feel like you could deal with https://gerrit.wikimedia.org/r/#/c/33568/2 better than me - I'm not sure what you mean in your last comment [00:55:16] basically, I meant that you're using an internal link where it should be external [00:58:16] ah i see [00:58:52] hmm .. this is what google does http://www.google.com/about/jobs/locations/london/engineering/swe/software-engineer-partner-solutions-london.html … thus - Software Developer (Partners) [00:59:25] err .. Software Engineer (Partners) [01:00:05] MaxSem: awjr preilly --^ [01:01:41] you guys want a deployment system, or gluster home directories for labs? [01:02:05] I'm going somewhere with this... [01:02:05] Ryan_Lane: are you making us choose? [01:02:08] yes [01:02:17] which one do you want first? [01:02:20] i would vote deployment system [01:02:33] New patchset: Jdlrobson; "append a default license" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/33568 [01:02:38] Ryan_Lane: whichever one gives us more rainbows and unicorns [01:02:38] sweet. clean up mobile-sms's home directories :) [01:02:49] 1.9G ./mobile-sms [01:03:11] otherwise I need to stop working on the deployment system so that I can move the homedirs to gluster ;) [01:03:50] New patchset: Jdlrobson; "photo uploads for articles without images in the summary section" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/32683 [01:04:01] Ryan_Lane: what instance is that? i dont know who's been working on that... [01:04:31] one of these: https://labsconsole.wikimedia.org/wiki/Nova_Resource:Mobile-sms [01:05:01] sounds like preilly or jerith [01:05:27] MaxSem: how does https://gerrit.wikimedia.org/r/#/c/34058/1/includes/skins/SkinMobile.php look to you? [01:06:16] tfinc: I like Software Engineer (Partners) [01:06:22] k [01:06:29] jdlrobson, ideally once such questions have been risen, we have to look at the output - but it's too late for me [01:06:38] tfinc, preilly i agree [01:06:46] k [01:06:52] I'll take a look at it (as well as other items in CR queue) tomorrowe [01:06:56] k.. np MaxSem - just getting a bit overwhelmed by code backlog. I'm going on a coding strike until all code in backlog is merged [01:07:01] preilly do you know anything about the mobile-sms instances? [01:07:50] preilly: ... [01:07:57] 1.7G ./.bitcoin [01:08:05] ! [01:10:15] perhaps its preilly's part of the fundraiser [01:12:02] Ryan_Lane: you can delete it [01:12:06] Ryan_Lane: or I can [01:12:44] what was it for? [01:13:13] Ryan_Lane: testing for fundraiser [01:13:23] hahaha. seriously? [01:13:41] remove it if you don't mind [01:15:34] thanks [01:15:45] Ryan_Lane: gone now [01:15:55] yep. noticed with df [01:16:20] Ryan_Lane: and you watch'ing df? [01:16:37] I had just happened to do a df [01:17:14] Ryan_Lane: yeah I meant to delete it [01:17:47] no big deal. we'll be switched to glusterfs at some point. I just needed some breathing room until I finish the deployment system stuff [01:26:24] Change abandoned: Jdlrobson; "Abandoning after talking to Juliusz" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/35385 [01:28:44] jdlrobson, one more concern before I go to bed: we've been adding a lot of JS messages, which clutters every page's HTML. ideally, they should be offloaded to RL or just loaded dynamically if possible. this is especially true for photo upload messages which are not used during routine reading [01:28:55] MaxSem: i know. [01:29:01] I've been thinking about this a lot don't worry :) [01:29:15] even without ResourceLoader we could make an ajax request to get this information [01:29:49] could get it from the api [01:29:56] (sorry, stalk work triggered) [01:29:58] no context [01:41:30] New review: Jdlrobson; "Approved by product" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/32683 [01:54:04] New patchset: Jdlrobson; "add jshint to MobileFrontend" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/35788 [02:01:35] New patchset: Jdlrobson; "photo uploads for articles without images in the summary section" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/32683 [02:06:33] New patchset: Jdlrobson; "replace all tables with a link to open table in an overlay" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/32552 [02:08:25] New review: Jdlrobson; "Approved by product. Accidentally resubmitted. Same as patchset 9" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/32683 [02:09:18] New review: Jdlrobson; "See comment. At very least please improve commit message." [mediawiki/extensions/MobileFrontend] (esisupport); V: 0 C: -1; - https://gerrit.wikimedia.org/r/32899 [02:16:28] New patchset: Jdlrobson; "replace all tables with a link to open table in an overlay" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/32552 [02:17:12] New review: Jdlrobson; "it seems I didn't commit mf-table.js " [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/32552 [05:50:42] tfinc: greetings! [17:55:49] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/34059 [17:55:50] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/34060 [17:55:50] Change merged: MaxSem; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/34061 [17:55:50] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/34058 [17:56:00] o_0 [17:57:06] hey jdlrobson [17:57:20] hey MaxSem [18:06:28] aude, around? [18:12:48] New patchset: Jdlrobson; "Mobile replacement for Special:Watchlist, initial version." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29621 [18:16:52] New patchset: Jdlrobson; "Mobile replacement for Special:Watchlist, initial version." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29621 [18:36:38] awjr, yo. how are you? [18:36:53] hi MaxSem. not so hot :( [18:46:46] jdlrobson: ping [18:46:49] pon [18:51:39] MaxSem: ping [18:51:44] pong [18:52:41] hi MaxSem [18:52:58] MaxSem: I sent you a PM [18:53:16] aude, hi. got a minute to talk about OSM? [18:54:04] sure [18:54:25] * aude happy that it's on the radar and can get done [18:56:53] aude, I'm about to be thrown at it and I know you did something in this directio n some time ago. can you tell me what did it end with? [18:57:18] we have puppet stuff for it [18:57:41] nothing beyond labs though, as not sure how to get it into production [18:58:14] https://gerrit.wikimedia.org/r/gitweb?p=labs%2Fmaps.git;a=shortlog;h=refs%2Fheads%2Fmaster [18:59:34] aude, so it's all about running OSM on Wikimedia? I thought the plans were to host a tile cache [19:00:34] what we have would be to run a copy, exactly like osm has [19:00:37] same style, etc. [19:01:23] that's a good start, and then we consider nicer styles and improving stuff [19:01:44] problematic. lots of new software, PG included - and ops are not fond of it and are not experts in administering it [19:01:46] if we also are interested in being a tile cache for openstreetmap.org, that would be awesome [19:02:02] * aude nods [19:02:38] how can new people be brought into help with ops stuff? e.g. volunteers to help with that or to help train staff? [19:03:14] the software isn't that complicated, and there could also be an option of a node.js rendering stack which might be more familiar [19:03:14] so why run a copy locally? [19:03:29] because we'd kill osm.org [19:03:49] that what tile cache is for [19:03:49] it's not meant for people to use the tiles in any significant volume [19:04:10] what tile cache? [19:04:25] MaxSem: we're totally happy running OSM in production [19:04:27] could work but still not the *right* way [19:04:44] we have hardware already purchased and running for it [19:04:54] Ryan_Lane, including Postgres? [19:05:02] yah! :) [19:05:02] does it require PG? [19:05:05] yes [19:05:11] we'll deal with it then [19:05:28] some years ago, osm used mysql but it's not the best for what osm does [19:05:52] PG has hstore and postgis extension for spatial stuff, like what mapnik needs [19:06:06] from what binasher was telling me, he'd like to make our osm servers open to the world as well [19:06:11] not just for our own uses [19:06:17] Ryan_Lane: would be awesome [19:06:38] right now, osm has servers in europe (uk) and caches in sweden i think? germany maybe, australia? [19:06:43] none in north america [19:07:11] either way, we have hardware for this [19:07:14] it would be great to offer a cache for use with osm.org itself, (and then if we want to do custom stuff on top of that, then great) [19:07:26] but starting with same setup as osm.org is best [19:08:00] * aude regrets not having a lot of time to work on it though, and still a little bit confused about operations stuff [19:08:08] * Ryan_Lane nods [19:08:29] once we deploy wikidata on wikipedia, then maybe my weekends will be more free [19:08:34] thanks for the work you've been doing on it so far :) [19:08:35] wikidata client :) [19:09:04] osm is really not complicated and i think a dedicated weekend or two would be enough to get it going [19:11:13] MaxSem: i'd suggest take a look at our puppet stuff [19:11:31] which is what I'm doing right now:) [19:11:47] ok [19:12:12] as we're doing wikidata, i am getting into ops stuff more so maybe can be more useful at the osm stuff too [19:12:54] we'll be running "replication" of the wikidata changes and the clients "wikipedias" using them to do stuff [19:13:17] aude, so am I getting it right that we will kill osm.org even if we act as a caching proxy? [19:13:30] osm is similar, with a feed or repliction of the changes there, get applied to your database and then use it to make the map tiles [19:13:47] MaxSem: i am not sure but it's not really a good solution [19:14:10] it's intended that people use the planet.openstreetmap.org stuff and generate their own [19:14:30] and then we'd cache our own, with the mod_tile stuff or whichever tool we choose [19:15:56] * aude would start with having the postgres replication working [19:16:10] mmm, I need to read on their architecture [19:16:13] or even just setup postgres without the replication [19:16:21] ok [19:16:34] and you can use subsets of the planet for testing [19:16:49] http://www.geofabrik.de/data/download.html <-- for example [19:16:53] also, specs of what we want to achieve would be great [19:16:59] or use the osmosis tool to make your own extract [19:17:02] sure :) [19:17:27] * aude would love to document it more, such as on mediawiki.org, wikitech or wherever [19:18:05] right now, we have http://en.wikivoyage.org/w/index.php?title=Special:MapSources¶ms=0%2C0%2Cscale%3D100000 [19:18:23] hackishly, using the toolserver [19:18:33] to replace that would be a great first step [19:23:43] at first glance, the manifests would require some rewrite for WMF use [19:23:55] sure [19:24:18] i'd suggest the postgres one to start [19:25:06] heh [19:25:17] neither me or apmon are very experienced with puppet :( [19:25:20] ensure => latest [19:25:27] but interested in learning [19:26:11] well, /me is also exactly not a jedi [19:26:18] ok :) [19:27:17] hmm, what's the point of file {"/etc/postgresql/9.1/main/postgresql.conf" and file {"/etc/postgresql/9.1/main/pg_hba.conf" ? [19:27:30] these should be installed by PG [19:28:05] postgresql.conf is like my.cnf [19:28:10] pg_hba is permissions [19:28:19] * aude looks at puppet [19:28:24] yeah, and these files are installed by the package [19:29:16] so, like i see "class generic::mysql::packages::client($version = "5.1") { " [19:29:19] and already owned by postgres:postgres [19:29:21] and then wmf stuff above [19:29:41] we can have generic and then the custom settings [19:30:37] * aude sees stuff like prod.my.cnf.erb as templates for custom stuff, it seems [19:31:10] yeah [19:31:39] and the mysql module doesn't do anything with files it doesn't modify [19:32:02] same stuff for user { "postgres": ensure => present } [19:33:36] instead of exec{ "/bin/su postgres -c \"echo \\\"$sql\\\" | psql $database\"": you can just specify the executing user [19:33:49] um, okay [19:33:59] that's nicer [19:35:34] ok, we have nothing in the review queue because we pushed the initial stuff [19:36:09] polishing up postgresql.pp would be good and get it into operations/puppet ? [19:36:11] cool - I'll look what can be done to port this to WMF [19:36:16] thanks [19:36:19] yup [19:36:33] we could submit it as a patch to operations/puppet and then it could get review comments [19:36:57] one thing at a time i think [19:38:39] * aude hungry.... i'll be back in a bit [19:41:18] New patchset: JGonera; "(bug 41514) Hash links broken in mobile" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/34680 [19:44:03] New review: Jdlrobson; "JENKINS not happy." [mediawiki/extensions/MobileFrontend] (esisupport); V: 0 C: -1; - https://gerrit.wikimedia.org/r/35825 [19:44:50] jdlrobson, what's the point of -1'ing a V- change?:) [19:45:21] from my experience MaxSem things get more attention if they have a -1 next to them [19:45:43] big red X is even more noticeable [19:45:52] you can't merge without it [19:51:00] New review: JGonera; "How do I get back to the article? Back button doesn't seem to do anything. Also, that blue shadow, I..." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/32552 [20:13:43] new android dev tools update, whee [20:14:47] New patchset: Jdlrobson; "add jshint to MobileFrontend" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/35788 [20:18:02] MaxSem: can you look at https://gerrit.wikimedia.org/r/#/c/32899/ ? [20:18:26] * jdlrobson is on coding strike until all the backlog is reviewed and merged [20:19:18] brion: https://gerrit.wikimedia.org/r/#/c/29621/ < can you take a look at this? [20:19:19] what's unclear there? it just serves collapsible sections HTML to every client [20:19:28] looking [20:19:29] MaxSem: but are we not doing that already? [20:19:48] take a look at the code itself [20:20:18] ATM we don't send it to clents we know not to support JS [20:20:27] which just fragments the cache [20:21:09] ahh ok [20:21:24] so we are sending different html to users of old devices [20:21:30] yes [20:21:33] looks good enough for now, let's merge it [20:21:48] MaxSem: let me just put that in the commit message - it gives more context [20:21:50] sorry to be a pain [20:21:54] i'll do that and +1 it :) [20:22:05] New review: Brion VIBBER; "Adjusted version will do well enough for now. Yay!" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 2; - https://gerrit.wikimedia.org/r/29621 [20:22:05] Change merged: Brion VIBBER; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29621 [20:23:07] aude, had any contact been made with ops besides requesting the hardware? [20:24:58] New patchset: Jdlrobson; "Adding config variable for ESI support" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/35946 [20:24:58] New patchset: Jdlrobson; "Special page for outputting ESI chunks" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/35947 [20:24:58] New patchset: Jdlrobson; "Moves viewport-scalable handling to support ESI" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/35948 [20:24:59] New patchset: Jdlrobson; "Remove X-Device vary header by default" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/35949 [20:24:59] New patchset: Jdlrobson; "Vary based on WAP-ness since we are no longer varying on X-Device" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/35950 [20:24:59] New patchset: Jdlrobson; "Remove unused template var 'supports_jquery'" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/35951 [20:24:59] New patchset: Jdlrobson; "Cleanup" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/35952 [20:25:00] New patchset: Jdlrobson; "Collapsible sections now behave properly w/o JS" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/35953 [20:25:19] New review: Siebrand; "qqq missing for one message." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/29621 [20:25:30] eek that submitted more than i expected [20:25:46] feck [20:26:19] * jdlrobson is very confused [20:28:04] New patchset: Jdlrobson; "Collapsible sections now behave properly w/o JS" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/35953 [20:28:23] jdlrobson, you've submitted this to master [20:28:32] MaxSem: i'm totally confused with what just happened [20:28:48] git-review, that's what just happened;) [20:28:54] i'm going to abandon all the esisupport1's though [20:28:59] this thing is a royal PITA [20:29:09] Change abandoned: Jdlrobson; "#fail" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/35952 [20:29:25] Change abandoned: Jdlrobson; "#fail" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/35951 [20:29:48] Change abandoned: Jdlrobson; "#fail" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/35947 [20:29:59] Change abandoned: Jdlrobson; "#fail" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/35946 [20:30:05] Change abandoned: Jdlrobson; "#fail" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/35948 [20:30:14] Change abandoned: Jdlrobson; "#fail" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/35949 [20:30:21] Change abandoned: Jdlrobson; "#fail" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/35950 [20:30:56] New review: Jdlrobson; "See" [mediawiki/extensions/MobileFrontend] (esisupport); V: 0 C: -1; - https://gerrit.wikimedia.org/r/32899 [20:31:10] sigh [20:31:10] ok [20:35:43] MaxSem: can you review https://gerrit.wikimedia.org/r/#/c/35591/ ? [20:37:58] New review: MaxSem; "You can just use the disableImages cookie instead adding yet another JS variable." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/35591 [20:39:29] tfinc, what had been communicated with ops regarding OSM besides ordering the hardware? [20:41:43] MaxSem: hardware was ordered at least a quarter ago and has been sitting waiting for anyone to pick it up [20:41:51] MaxSem: i'm sitting in the tech chat right now so expect some delays [20:42:06] thanks MaxSem [20:44:06] tfinc, okay - so nothing else? then I need to start running this stuff past them. at least new packages [20:45:57] MaxSem: the only other work was by aude and volunteers in labs [20:47:33] tfinc: MaxSem i'm not sure what/who/how to coordinate with ops [20:47:46] a specific contact person would be a big help [20:48:28] New review: Jdlrobson; "Max the cookie doesn't seem to be accessible.." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/35591 [20:48:31] aude: i wasn't around for it so we'll have to do some detective work to find out [20:48:40] Ryan_Lane: do you remember who started on the OSM labs setup ? [20:48:57] tfinc: me and apmon are working on it [20:49:00] MaxSem: are you happy with https://gerrit.wikimedia.org/r/#/c/35953/ ? [20:49:21] brion: welcome back to he world of the living [20:49:26] thedj[work]: https://gerrit.wikimedia.org/r/#/c/30915/ [20:49:27] whee [20:49:28] kolossos and dschwen (authors of the gadgets) are also part of the project [20:49:52] aude: Ryan_Lane if i had to guess Colossus (sp?) was likely involved [20:50:30] yes, he's involved [20:50:44] jdlrobson, yes - thanks [20:50:52] more with database and integration with wikipedia, making it multilingual (better), etc. [20:51:17] multilingual is something we can do to improve on the default osm stuff, and maybe it can be merged back upstream [20:51:51] Change abandoned: Jdlrobson; "See https://gerrit.wikimedia.org/r/#/c/35953/ instead" [mediawiki/extensions/MobileFrontend] (esisupport) - https://gerrit.wikimedia.org/r/32899 [20:51:59] where's the irc channel for the tech chat? [20:52:08] aude: #wikimedia-dev [20:52:09] MaxSem: I'll go ahead and merge then [20:52:36] hrm, nobody there or talking there [20:52:41] but ok [20:53:19] oops, had to scroll [20:54:29] woot talking about mobile testing in the tech chat [20:54:41] :) [20:54:41] brion: MaxSem : listen in [20:55:38] brion: looks like this is going to be heavy on iOS testing. even better for you and yuvi [20:55:51] excellent [20:56:51] * brion watching on the youtubes [20:57:56] * aude is now doing android stuff [20:57:58] New patchset: Jdlrobson; "replace all tables with a link to open table in an overlay" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/32552 [20:58:14] loves my android :) [20:58:53] reminds me i gotta charge some tablets [20:59:06] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/35953 [21:00:42] tfinc: hm [21:00:48] lemme see [21:01:29] tfinc: likely apmon and kolossos [21:01:49] actually, we can tell [21:02:41] https://labsconsole.wikimedia.org/wiki/Nova_Resource:I-00000253 [21:02:45] apmon [21:02:56] instancecreator_username=Apmon [21:03:22] I should really make that a property so that I can query it [21:04:22] New review: JGonera; "Jon, the cookie is prefixed with the name of your wiki, e.g. my_wikidisableImages. Anyway, I thought..." [mediawiki/extensions/MobileFrontend] (master) C: 0; - https://gerrit.wikimedia.org/r/35591 [21:12:05] New patchset: Raimond Spekking; "Revert "Localisation updates from http://translatewiki.net."" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36049 [21:13:48] Change merged: Raimond Spekking; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36049 [21:14:54] New review: Raimond Spekking; "@Siebrand: I had to revert our bot again due to messing up with a change from tonight" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36049 [21:15:37] http://developer.android.com/about/dashboards/index.html < Android 2.1 is only 3.1% ! [21:20:09] brion: --^ [21:20:33] huzzah [21:20:39] now if we can kill 2.2 and 2.3... [21:20:42] android 3.0 distribution % is a pretty big joke too [21:20:52] brion: 2.3 won't be dead for years [21:20:57] 3.x should just die out safely [21:21:00] 2.3…. sigh [21:21:07] and there are still tons of phones being sold for 2.3 [21:21:22] yeah going native android will simplify our life there, we can handle the back-compat issues easier from outside the webview [21:21:31] and won't have to deal with any of the fixed-position or scroll problems at all [21:28:05] New patchset: Krinkle; "jshint all the code base" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/35789 [21:29:16] New patchset: Jdlrobson; "switch h2 to h1 for homepage msg (bug 41666)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36051 [21:33:04] New patchset: Jdlrobson; "allow html in headings (bug 41711)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36054 [21:33:26] New review: JGonera; "I had to change my mind because I'm not sure of the sudo thing." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/35788 [21:35:43] MaxSem: are you happy with https://gerrit.wikimedia.org/r/#/c/33568/ now? [21:37:16] New review: Jdlrobson; "Still whitespace issue. Waiting on dependencies to be merged before fixing to avoid overwriting patc..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/32905 [21:39:15] jdlrobson, NO [21:39:36] use protocol-relative a link [21:40:00] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/34680 [22:17:35] MaxSem: phpunit tests are failing for me due to DeviceDetection [22:17:37] any ideas why? [22:17:49] update core [22:18:11] i have [22:18:35] DeviceDetection.php still in includes/mobile though [22:18:41] O RLY? [22:18:48] then it's a failed update [22:18:57] make sure you're on master [22:19:16] ahh your right [22:19:34] sweet thanks MaxSem [22:19:35] that was confusing me [22:37:47] New patchset: Jdlrobson; "increase font size of edit areas to be 1em" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36096 [22:45:39] brion: will you be in the office tomorrow ? [22:47:00] most probably [22:47:53] New patchset: Jdlrobson; "show progress indicator when watching article" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36098 [22:54:54] New patchset: JGonera; "add jshint to MobileFrontend" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/35788 [22:56:07] jdlrobson: hows the hammock ? [22:56:45] fine but the code review backlog isn't… :P [22:56:52] get jgonera on it [22:57:04] he is [22:57:14] it's backed up like a traffic jam in delhi [22:57:27] tfinc, I just opened IRC since my laptop crashed when I connected the monitor back again :/ [22:57:37] good ol' ubuntu [22:57:43] i could have doubled the coding review backlog today had i not been disciplined. :P [22:57:51] as if [22:57:56] tfinc, hey, it never failed me on non-macs ;) [22:58:26] New review: Jdlrobson; "Merging since no complaints." [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/30915 [22:58:26] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/30915 [22:58:29] its also never failed me in a server env but i don't let that drive me using it on a desktop [22:59:21] MaxSem: brion jdlrobson jgonera Maryana : Story review and estimation will happen in an hour [22:59:32] so I guess Chip saying that Ubuntu works fine on Macbooks was a part of the plan of converting me to Mac OS ;) [22:59:46] gut [23:00:18] jgonera, they're dragging you to the dark side? [23:00:25] it seems so [23:00:59] roger that, tfinc [23:05:35] New review: Jdlrobson; "Max says don't specify protocol e.g. use // for link" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/33568 [23:05:53] can someone review https://gerrit.wikimedia.org/r/#/c/32683/ [23:05:53] * brion plugs in laptop so it's not on battery :P [23:06:00] * brion looks [23:06:06] New review: JGonera; "Browser's back button still doesn't take me back to the article. Is it supposed to be like that?" [mediawiki/extensions/MobileFrontend] (master) C: 0; - https://gerrit.wikimedia.org/r/32552 [23:06:43] Maryana: I need you to confirm that https://mingle.corp.wikimedia.org/projects/mobile/cards/grid?color_by=story+points&filters%5B%5D=%5BType%5D%5Bis%5D%5BStory%5D&group_by%5Blane%5D=iteration&lanes=+%2C131%2C254%2C260%2C261&maximized=true&tab=All (Release 2 - Photo uploads > Sprint) relative priority is correct [23:06:53] jgonera: i'm confused [23:07:05] ahh you been browsers back button [23:07:11] i thought you meant the back button in the overlay [23:07:13] yep [23:07:18] no, this one's fine [23:07:27] let me fix that right up [23:08:10] tfinc: now it is :) [23:08:42] one burning question i've had forever - are both top columns top priority, or is it left column top to bottom, then right column? [23:08:43] Maryana: thanks [23:09:00] * both top rows, rather [23:09:51] Maryana: i read it as left column top to bottom, then middle column, then right column [23:10:20] Maryana: how as arthur done it in the past ? [23:10:27] not sure... [23:10:45] i've always read it as top rows first, but maybe that's wrong :-/ [23:11:07] maybe we can clarify that in the meeting? [23:11:08] jdlrobson: brion MaxSem : how has arthur stacked this in the past ? [23:11:35] i just follow along :) [23:12:20] hmm, I don't remeber double-stacked columns before [23:12:24] Maryana: i see no detail for https://mingle.corp.wikimedia.org/projects/mobile/cards/263 [23:13:35] i love this card https://mingle.corp.wikimedia.org/projects/mobile/cards/230 [23:14:00] ack! [23:15:10] Maryana: https://mingle.corp.wikimedia.org/projects/mobile/cards/264 has no detail [23:15:27] Maryana: https://mingle.corp.wikimedia.org/projects/mobile/cards/265 has no detail [23:15:44] without a proper story we'll have to take them out of the iteration [23:15:58] i don't understand the automatic redirect thing - it's a bug left over from michelle's QA iteration [23:16:16] and we're going to deprioritize talk about an article, so feel free to just remove that [23:16:26] Maryana: is it simply the fact that we should you a useless logged in page instead of anything else ? [23:16:35] s/should/show [23:17:07] oh, that's right - yes [23:17:28] Maryana: where should they be redirected to after ? [23:17:42] to the page they were on previously. lemme fill that out real quick [23:18:09] these are the kinds of issues we don't want to have 45min before the estimation meeting [23:18:13] if you need my help then let me know [23:21:05] sorry tfinc - done now [23:21:58] excellent [23:22:24] Maryana: https://mingle.corp.wikimedia.org/projects/mobile/cards/264 is still empty [23:22:39] i moved it out of the iteration [23:23:07] k [23:23:11] or maybe i didn't…? grr mingle [23:23:16] New review: Brion VIBBER; "From quick testing:" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/32683 [23:23:51] jdlrobson: latest patch set for the uploads doesn't seem to work for me [23:23:54] there, that seems to have don eit [23:23:56] *done it [23:25:18] brion: how so? [23:25:26] are you including all dependencies? [23:25:27] TypeError: M.setting is not a function [23:25:34] aharhrhhgshsfhf [23:25:37] git fetch https://gerrit.wikimedia.org/r/mediawiki/extensions/MobileFrontend refs/changes/83/32683/10 && git checkout FETCH_HEAD [23:25:44] grr fecking fecking rebasing [23:26:06] always test before you push :) [23:26:34] this got merged today brion [23:26:37] i'll fix that now [23:26:51] whee [23:27:02] New patchset: Jdlrobson; "only enable toggling if more than one heading in content (bug 41406)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36112 [23:29:22] brion: MaxSem are we reasonably complete with our mobile resource loader work ? [23:30:00] we need to reenable it on beta [23:30:33] then, we need to start using its localisation features [23:31:53] whee [23:32:34] k, I'm move through http://www.mediawiki.org/wiki/Wikimedia_Engineering/2012-13_Goals#Mobile and marking things that are mostly done or cancelled [23:32:59] how did we do with "Move from DOM parser to core parser hooks" ? [23:33:32] nothing [23:33:46] Change abandoned: Jdlrobson; "remove restriction. silly." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/32888 [23:34:16] what about "Make Mediawiki aware of context (mobile or not)" ? [23:35:33] that\s part of core migration - I thought we decided to put it aside? [23:39:10] k [23:40:02] New review: JGonera; "There are some minor things about JS. addPhotoUploader() seems a bit long. Maybe we should think abo..." [mediawiki/extensions/MobileFrontend] (master) C: -1; - https://gerrit.wikimedia.org/r/32683 [23:41:50] Change abandoned: Jdlrobson; "i'm going to squash this into one mobile image upload commit." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/35800 [23:43:03] Change abandoned: Jdlrobson; "i'm going to squash this into one mobile image upload commit." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/32905 [23:43:34] Change abandoned: Jdlrobson; "i'm going to squash this into one mobile image upload commit." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/32904 [23:44:29] Change abandoned: Jdlrobson; "i'm going to squash this into one mobile image upload commit." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/33568