[00:04:24] New patchset: Jdlrobson; "photo uploads for articles without images in the summary section" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/32683 [00:06:05] New review: Jdlrobson; "Seems to effect languages as well - let's open a bug and address separately." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/32552 [00:06:32] https://mingle.corp.wikimedia.org/projects/mobile/cards/grid?color_by=story+points&filters%5B%5D=%5BType%5D%5Bis%5D%5BStory%5D&group_by%5Blane%5D=iteration&lanes=+%2C131%2C254%2C260%2C261&maximized=true&tab=All [00:37:50] New review: Brion VIBBER; "Doesn't work in Firefox desktop uploading to local wiki. POST fails with:" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/32683 [01:14:49] New review: Jdlrobson; "Firefox is not on the list of devices we test/support for beta so this doesn't surprise me:" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/32683 [01:19:15] New review: Jdlrobson; "Is" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/32683 [01:20:42] wikivoyage should now be mobile enabled [01:20:51] (e.g. the redirector works) [01:21:08] any idea what https://twitter.com/JeffRougvie/status/273889354395553792 is about? [01:21:23] i keep seeing tweets about something being impossible to close… ^ brion tfinc [01:22:10] also https://twitter.com/cawhitworth/status/273544859984470016 [01:22:24] jdlrobson: there was a bug from the fundraising team that came in yesterday [01:22:33] they should have pushed changes to fix that [01:22:38] but what have we got to do with fundraising?! [01:23:02] jdlrobson: they needed access to our ACL list to filter out mobile devices that *had* opted out of the mobile experience [01:23:17] mutante: woot! [01:24:34] tfinc: https://twitter.com/lucasvo/status/273153460696928257 [01:24:42] so it begins [01:27:38] that is a sign of us winning the battle as i always say [01:27:41] brion: ---^ [01:34:02] New patchset: Jdlrobson; "center heading in overlay header" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36139 [01:35:13] jetttlagggg [02:08:12] New patchset: JGonera; "adjust random function" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/32560 [02:09:17] New review: JGonera; "The performance problem seems to be in history.loadPage(), will investigate." [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/32560 [02:58:14] New patchset: JGonera; "Fix adding unnecessary callbacks in mf-cleanuptemplates" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36151 [06:56:32] New review: Jdlrobson; "eeek good catch but I'm pretty sure the mf-navigation.js change is a mistake.." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/36151 [07:43:37] New patchset: Krinkle; "jshint all the code base" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/35789 [16:31:24] New patchset: Jdlrobson; "add jshint to MobileFrontend" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/35788 [16:44:01] New patchset: Jdlrobson; "watch the correct article (bug 42486)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36195 [17:19:27] idle question: do we devote any time to testing/checking Windows Mobile schtuff? [17:19:45] details? [17:29:03] * yuvipanda looks around [17:29:28] it's quiet in here today yuvipanda [17:29:47] chrismcmahon: indeed! Is it a US holiday? [17:29:50] or just too early? [17:29:59] I think it's just early on a Friday [17:30:11] yeah, i guess so [17:30:25] DST ended so i need to re-adjust expectations i guess [17:31:38] * yuvipanda spots a brion  [17:32:38] hullo [17:33:00] brion: any luck on the 'offline' issue? [17:33:53] i sent a fixed error-checking build to jcmish the other day… jcmish you have any luck with the new build? [17:35:38] nope [17:35:43] I emailed it back to you [17:36:05] I can resend it wouldn't load at all and I had the person who helped us [17:36:15] send me the logs [17:36:45] * awjr waves to yuvipanda [17:37:06] * yuvipanda waves at awjr  [17:39:54] yuvipanda and brion do you want me to resend the results to you guys? [17:39:59] jcmish: yes pls :D [17:40:04] you bet [17:40:57] :) [17:41:01] brion did you get my results from testing the iphone app? [17:41:56] jcmish: yes -- only problem you saw was with the section arrows? [17:42:03] yessir [17:42:09] portrait worked etc [17:42:14] i took a quick look to see if the same thing happened on the mobile web and it didn't, we'll spend a little more time on it [17:42:23] did the old version have the same bug or is it new? [17:42:29] right it wasn't on the mobile web [17:42:41] I didn't try the old version :) [17:42:46] got sick but i'll do that now [17:42:55] let me pull this one and check [17:43:18] thanks :D [17:44:09] you bet [17:46:51] any progress on https://bugzilla.wikimedia.org/show_bug.cgi?id=42485 ? [17:47:31] i dont see anything about it on the story wall [17:47:35] jcmish ^^ ? [17:47:58] should i add it as a story? [17:48:00] we should probably prioritize that, it'd be good to fix [17:48:06] nope [17:48:20] i bet jon can fix it easy though [17:48:28] should I create it? [17:48:38] jcmish: yeah go ahead and create a bug card for it and get it on the wall [17:48:44] you got it [17:48:44] let's bring it up during standup [17:49:10] yeah, we talked about it a bit at the end of the meeting yesterday, but it was already after brion and maxsem had dropped off :) [17:49:28] aha! [17:49:32] during my ailment [17:50:00] are you feeling better? you guys both got me sick virtually somehow [17:50:13] Maryana: i was just looking over account creation stuff (https://mingle.corp.wikimedia.org/projects/mobile/cards/140 and https://www.mediawiki.org/wiki/Account_creation_user_experience) - am i reading the card right that it should mimic what's happening with the new account creation stuff? i am concerned about the captcha - but i guess we wont know how much of a problem it is til we try it [17:50:34] Maryana: good enough to work today, still not better. maybe you opened an email form me containing this virus [17:50:58] hmm [17:51:00] ooh, yeah. captcha. good call - i don't recall anyone mentioning it, but it's probably going to be a devil on a mobile screen [17:51:07] yep [17:51:08] jcmish: looks like that had the same errors as the previous attempt. wtf? [17:51:14] lemme rebuild it, sigh [17:51:18] they're bad enough on desktop :p [17:51:30] brion I know [17:51:30] i'm trying to get some e3-mobile synergy going on this, since the e3 team just spent several months refactoring account creation [17:51:34] :( [17:51:52] Maryana: are you doing product stuff for e3 also? [17:52:16] heh, yeah, though steven walling has mostly got the reigns on it now [17:52:23] roger that [17:52:28] oh guys warning: i might have jury duty next week. yay! [17:52:47] brion, in the same case as tfinc? [17:52:52] biron are you and tfinc playing hooky together using the convenient 'jury duty' excuse? [17:52:55] hah that'd be awesome [17:52:56] must be a big 'un :) [17:53:14] trial buddies! [17:53:19] hehehe [17:53:30] i imagine that would make jury duty suck a lot less [17:53:52] Maryana: i'm curious to hear e3's thoughts on the captcha [17:53:59] has anyone done research on captcha alternatives on mobile? [17:54:02] it sux0rs [17:54:09] we thought about honeypot [17:54:15] i dunno if that's a good mobile solution [17:54:20] i looked into it breifly a few months back and didn't really find much but i can dig again [17:54:25] but yeah, the captcha is significantly off-putting to users [17:54:35] im sure someone's thought of some reasonable alternative [17:54:55] i imagine so.. i mean, how big of a problem are spambots on phones? [17:55:11] Maryana: well you don't need a phone to use the mobile site [17:55:15] true dat [17:55:28] damn spambots [17:55:32] ruining everything [17:55:45] in 2010 we found that a lot of the fundraiser fraud was coming from OLD landing pages that weren't as well protected! [17:55:50] they will always find a way [17:55:54] oh man [17:55:56] wee … fire alarm [17:56:01] ! [17:56:15] oh dear [17:59:18] and were back [18:00:20] awjr: joining us ? [18:00:57] brion: standup? [18:00:58] jcmish: ok try https://www.dropbox.com/s/dacujoy82bet0px/WikipediaActivity-errcheck3.apk [18:02:08] thanks brion and I did test the old version of iOS and the arrows are fine there [18:02:14] so it's only in this other build [18:02:18] whee new bugs [18:02:27] :-) we need excitement [18:10:02] awjr: hows the backlog i curated for the next sprint? [18:10:40] tfinc_: i haven't finished reviewing it yet but so far looks good [18:11:27] MaxSem: what i'm curious to find out for OSM is : what has to get done first because it blocks everything and takes a long time, what blocks some things but can wait, and what's open and can be done at a volunteer event feb/march of next year [18:11:30] awjr: god [18:11:34] awjr: good* [18:13:32] awjr: those notes you sent out to me for the estimation meeting were super useful. shall we pos them somewhere ? [18:14:01] MaxSem: https://bugzilla.wikimedia.org/show_bug.cgi?id=41569 needs an update [18:14:19] brion: ---^ [18:14:53] tfinc: that's not a bad idea for the next time - im not sure where would be the most appropriate place to put stuff like that? it would probably be wise to generally keep notes like that for the various mtgs [18:15:19] agreed. you'll have to chat with the other scrum masters to figure out where it goes [18:15:21] Maryana, awjr https://bugzilla.wikimedia.org/show_bug.cgi?id=42485 is in Mingle as ticket number #269 [18:15:26] looking [18:16:01] we'll add more detail once i do the investigation spike :D [18:16:27] tfinc, in principle, there are packages and manifests for OSM. they're said to be in a functioning state [18:17:09] awesome jcmish thanks - brion/jdlrobson/jgonera if you're looking for smoething to do, take a look at the outstanding bug on the story wall [18:17:20] once I rewrite the manifests and integrate them into our main repo, we'll see how it fares [18:17:42] cool beans. jdlrobson, that's the bug that's affecting section toggling data [18:18:15] I'll need a lot of investigation of OSM to have my own opinion how functional it is [18:18:40] Maryana: how does it effect the toggling data? [18:19:01] if the buttons never load then nothing is logged [18:19:14] which is good because you'd expect a user to keep clicking to try and toggle and failing [18:19:29] precisely! that means we're logging sessions with no section toggles [18:19:43] but not because the user chose not to toggle - because he/she couldn't [18:20:20] tfinc: I got access was the resolution [18:20:37] tfinc: access request queue is private that's why you couldn't read it [18:21:23] Maryana: but we are not [18:22:10] actually wait.. we can filter those out though no? [18:22:19] according to this schema, we're logging every session: http://www.mediawiki.org/wiki/Event_logging/Mobile [18:23:14] unless i'm interpreting it wrong, we mark the start of a session as the moment when a user accesses the site and JS begins loading [18:23:34] so the TogglingReady event only runs if toggling is possible [18:23:42] brion: any luck on the offline thing? [18:23:51] so for sessions where you cannot toggle you can filter those out by finding sessions where that event doesn't run [18:24:00] yuvipanda: waiting on results :) [18:24:03] i'd have to check with ori but i'm sure that's the case.. [18:24:05] ah, rih [18:24:05] t [18:24:10] anyway fix on the way now.. [18:24:16] * yuvipanda is reminded of intercontinental debugging with tfinc  [18:25:22] :) [18:25:50] debugging by carrier pigeon [18:25:50] brion: awjr MaxSem do we use phplint in our codebase? [18:25:58] no [18:26:09] preilly: k [18:26:30] but i believe there is a basic php -l lint check [18:27:03] that's syntax chack [18:27:19] oh i figured phplint was like that but on steroids [18:27:23] i dont know anything about it [18:27:29] I guess Jon was asking about something more advanced:) [18:28:21] MaxSem: thats still a bit too nebulous for me but lets check in on monday after you've had a day to tinker with this [18:28:36] i'm eager to know what we can leave for a public event and what we have to get done ourselves [18:28:41] tfinc: i don't think deploying the osm stuff will take that long [18:29:00] i told erik that we would seriously start moving on this in jan so we don't have to have a giant push now [18:29:02] it's just a matter of people having the time (e.g. a weekend or two to polish the puppet stuff) [18:29:07] especially if our product backlog is large [18:29:17] aude, from our yesterday's talk I have an impression that you consider it almost done [18:29:28] the initial setup will be basic though, like what osm.org has [18:29:49] lets get it functional that way we can prove the hardware works [18:29:50] MaxSem: it's only the beginning.... there's a lot of improvement that could be done [18:30:03] like multilingual, but basics initially [18:30:30] MaxSem: awjr so I'm currently getting jshint setup and it's going to run on every commit via a git hook [18:30:36] i figured it would be nice to lint php as well [18:30:38] * aude thinks it'd be really cool to get a map in *your* language, but right now it all gets mixed together in osm's default style [18:30:49] i'm also interested in a git review hook so every time you run git review it runs the test suite [18:30:49] and osm's style isn't very good, to be honest [18:31:04] Maryana: what is the link to that toggling bug? [18:31:05] i can't find it [18:31:19] osm's style works with an older version of mapnik, so it would be nice to update it [18:31:21] https://bugzilla.wikimedia.org/show_bug.cgi?id=42485 [18:31:23] thanks :D [18:31:35] np! [18:33:24] for volunteers, .... improving the style, integrating multilingual stuff (that kolossos is working on), and i'll have to think about what else but there's plenty [18:34:15] New patchset: Jdlrobson; "ensure toggling always enabled on pages (bug 42485)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36218 [18:34:24] tfinc: mobile optimized style [18:34:31] awjr: MaxSem : were looking at next weeks deployments and i see we*only* have tues. is this all we need ? [18:34:57] tfinc yeah we're trying to avoid two-day deployments. our testing has been getting a lot better :) [18:35:01] love it [18:35:11] props to jcmish [18:35:15] w00t! [18:35:56] :) [18:39:09] aude, I see that maps project on labs has a lot of instances [18:40:06] New patchset: Jdlrobson; "Fix adding unnecessary callbacks in mf-cleanuptemplates" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36151 [18:40:14] MaxSem: bunch are for testing, some for kolossos, dschwen, etc. [18:40:32] some might also be corrupt, as i kept getting errors creating instances [18:41:25] * aude deleting the bad ones [18:42:16] tilemill is the node.js stuff [18:46:47] New review: awjrichards; "gahhh looks like merge conflicts. i'll see what i can do." [mediawiki/extensions/MobileFrontend] (esisupport); V: 0 C: 0; - https://gerrit.wikimedia.org/r/35825 [18:47:26] Change merged: Ori.livneh; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/35788 [18:47:51] biab [18:48:32] MaxSem: http://www.mediawiki.org/wiki/GeoData_Storage_%26_API <-- needs an update [18:49:35] jcmish: http://www.mediawiki.org/wiki/Mobile_QA <-- needs an update [18:50:23] tfinc [18:50:43] kayo I'll get right on it after I finish this quick test [18:52:39] thanks [18:53:26] New review: awjrichards; "i dont understand why this is failing, i am not having pull/rebase issues locally against the remote..." [mediawiki/extensions/MobileFrontend] (esisupport); V: 0 C: 0; - https://gerrit.wikimedia.org/r/35825 [18:56:38] tfinc, done [18:56:42] thanks [18:57:02] back later... [18:58:36] New patchset: awjrichards; "Finishes removal of device-specific variance from SkinMobile::prepareTemplate()" [mediawiki/extensions/MobileFrontend] (esisupport) - https://gerrit.wikimedia.org/r/35825 [18:59:50] preilly: brion have you guys had a chance to sync up about zero architecture ? [19:00:01] not yet [19:00:25] what can i do to make sure that it happens ? [19:00:51] keep me from going on a jury next week :P [19:01:34] tfinc: he hasn't been in the office [19:01:35] grrr jenkins is failing in a way i can't reproduce locally >_< [19:01:53] tfinc: we planned on doing it next Thursday last I heard [19:02:07] awjr, poke Hashar? [19:02:17] good idea [19:03:01] preilly: is it impossible to do over hangout? i'm worried that brion may be knocked out all next week by jury duty (like myself) and that you'll have to field any questions [19:04:12] awjr: here will be quieter I guess :-) [19:04:18] yes :) [19:04:26] awjr wrote: im trying to commit to a remote branch, but jenkins is failing due to merge conflicts. i have tried rebasing my changes locally against the remote branch, but i cannot reproduce the merge conflicts locally. any idea what im doing wrong? here's the jenkins failure output: https://integration.mediawiki.org/ci/job/Ext-MobileFrontend/720/console [19:04:42] * yuvipanda puts himself in line after awjr to meet hashar the great [19:04:58] actually hashar the integrator seems to rhyme a bit more [19:05:36] tfinc: we can try over hangout [19:05:37] awjr: are we using ESI ? [19:05:42] hashar not yet! [19:05:49] hashar but hopefully soon for mobile [19:05:54] \O/ [19:06:07] gabriel wicke wrote some ESI code back in 2003 or 2004 I think :-D [19:06:13] yeah... [19:06:14] never got used though [19:06:25] so hm [19:06:31] that https://gerrit.wikimedia.org/r/#/c/35825/ is against the esisupport branch [19:06:35] iirc it was squid-specific? [19:06:43] awjr: yup squid 3 I think [19:07:06] Already on 'master' [19:07:07] grbmblbl [19:07:09] hashar: yeah, it's supposed to be against the esisupport remote branch. [19:07:15] i was curious about that [19:07:29] apparently it cloned / reseted on master [19:07:57] that would certainly explain merge conflicts [19:10:03] New patchset: Jdlrobson; "jshint all the code base" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/35789 [19:10:27] awjr: ahhh looks like the local esisupport branch is not up to date :/ [19:10:31] my build script is at fault [19:10:50] ahha! [19:11:09] New review: awjrichards; "all your codebase are belong to jshint" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/35789 [19:11:44] Switched to branch 'esisupport' [19:11:44] Your branch and 'origin/esisupport' have diverged, [19:11:45] :( [19:13:14] New patchset: Jdlrobson; "jshint all the code base" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/35789 [19:14:15] Brion, yuvipanda success on the latest android build [19:14:25] jshint aaallllllll the code [19:14:31] both of the community folx I engaged said it passed [19:14:32] success -> works or failure reproducible? [19:14:37] works [19:14:37] sweet [19:14:42] brion: what did you do? [19:14:54] one 2.2 the other person is on 2.2.1 [19:14:58] works? darn [19:15:03] that means we have no data :( [19:15:07] yup I did ask for a log [19:15:10] just to be sure [19:15:12] so I'll send that [19:15:25] yuvipanda: so i fixed the errors in my errcheck branch [19:15:36] it just adds some console.log() lines with XHR results [19:16:03] :P "Repository temporarily unavailable." at github [19:16:05] wait, adding debug stuff to it fixed it? [19:16:07] ... [19:16:09] awjr: hmm I got the bug [19:16:14] yeah that…. shouldn't happen :) [19:16:19] awjr: will spam a few retriggering on that change [19:16:26] hashar np [19:16:28] thanks for digging into it [19:16:33] lemme peek at the log [19:16:57] awjr: I might just drop that Jenkins job though :-] [19:17:09] hmm [19:17:16] i don't see any "XHR" lines in the log [19:18:17] brion let me to to perfecto mobile and install it on a device and grab the logs too [19:18:20] if it's working we should see a couple "XHR SUCCESS!" lines [19:18:20] give me one minute [19:21:34] preilly: do you wan the SIM that's in this Nexus S back ? [19:22:39] awjr: might be fixed https://gerrit.wikimedia.org/r/#/c/35825/ https://integration.mediawiki.org/ci/job/Ext-MobileFrontend/725/console [19:22:46] awjr: the branch was not being used on extensions :( [19:23:01] awjr: some place was missing the branch so we ended up checking out master :( [19:25:12] hashar cool thanks! jenkins looks happier [19:31:20] awjr: triggered it again :-) [19:31:21] seems fine [19:31:25] huzzah! [19:34:02] awjr: here is the ant patch https://gerrit.wikimedia.org/r/#/c/36229/1/jobs/_shared/build.xml,unified :-D [19:34:19] awjr: also while we are both online, you opened a request to get mobilefrontend installed on beta [19:34:28] ah yes [19:34:37] awjr: (can't find the bug though) but you will want someone from ops and from your team to work on it [19:34:43] I can guide them to the beta layout [19:34:49] but not going to set it up myself :-] [19:34:59] I guess it is all about adding the extension + some conf [19:35:02] hashar ok awesome, i think jcmish was going to be working on it along with chrismcmahon [19:35:12] but then one will have add the configuration to recognize the .m URL [19:35:18] nice [19:35:34] yeah! plus whatever support we'll need form the team [19:35:35] Chris is pinging me a few times per week so I will get the info [19:35:40] that will be a big win :) [19:36:29] hashar awjr I lack enough knowledge to put MF in place myself, but I surely would like to see it done. [19:36:29] * yuvipanda pokes hashar  [19:37:04] biab [19:37:19] chrismcmahon, jcmish is this something that's still on your roadmaps? im happy to help push along when you're ready to get to it [19:38:16] yuvipanda: when are you uploading the big in aurangabad album? [19:38:26] ohh [19:38:49] awjr: the new triggering system did not have the issue :-] [19:38:52] awjr: https://integration.mediawiki.org/ci/job/mwext-MobileFrontend-testextensions/13/ [19:40:00] jdlrobson: hopefully tomo or sunday. Considering that the recent turn of events has given me a fair amount of free time :P [19:40:04] yuvipanda: listening to you :-) [19:40:10] hashar: ah :) [19:40:22] hashar: so, adding another android project to be built in jenkins [19:40:29] hashar: github.com/wikimedia/commons [19:40:31] New patchset: awjrichards; "adjust random function" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/32560 [19:40:38] yuvipanda: I got openjdk 6 and 7 installed on the host this week :-D [19:41:18] tfinc: can you also fork github.com/yuvipanda/java-mwapi into wikimedia? along with https://github.com/yuvipanda/android-mwlogin? [19:41:22] hashar: ah, sweet! :D [19:41:32] ahh yuvipanda [19:41:35] hey yuvipanda [19:41:46] yuvipanda: though the apps are building with sun jdk iirc [19:41:46] tfinc: they're dependencies for the commons app [19:41:48] yuvipanda: get brion to do it. he has admin rights [19:41:53] ah, right [19:42:27] hashar: well, they're finally sent to be 'dex'ed by the android 'dex'er thing [19:42:45] tfinc: I have been at a PHPConf for the two last days, some people came to me and told me how great it was to have the mobile apps in GitHub :-D no idea if they contributed but at least they found the code! ;-D [19:42:45] but yeah, i remember we ran into some issues with sunjdk vs openjdk [19:43:15] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/32560 [19:43:16] yuvipanda: we could build the apps using sun 5 + openjdk 6 + openjdk 7 and generate .apk for each [19:43:46] hashar: since jquery.ime is in github, i've spent the last two days getting a completely non-technical user to write javascript (keyboard mappings) and also put out a pull request, add more commits as comments came in, and finally get that merged [19:43:54] WITHOUT HAVING TO LEARN GIT AT ALL. IT WAS AWESOME [19:44:02] hashar: how much harder would it be to add a new one? [19:44:24] yuvipanda: I can copy paste another job, then have to update a few puppet manifests. [19:44:41] yuvipanda: will do that right now [19:44:55] hashar: sweet! [19:44:57] hashar: ooooh, wait! [19:45:02] yuvipanda: I was busy writing a PHP class to write Junit test results for brion's good old parserTests.php :-D Guess that can wait hehe [19:45:04] hashar: i just realized, the new app uses the ndk :P [19:45:11] aaaand the gstreamer sdk [19:45:14] new development kit ? [19:45:18] hashar: native [19:45:21] development kit [19:45:23] has C code [19:45:40] how do you install it ? :-] [19:45:52] hashar: https://developer.android.com/tools/sdk/ndk/index.html [19:47:08] whyyyy don't they provide debian packages? :-( [19:47:27] hashar: because they are into pain, suffering and that kinda kinky stuff [19:48:43] tfinc: I don't need the SIM [19:50:02] yuvipanda: https://github.com/wikimedia/commons ? [19:50:08] hashar: yup [19:50:14] but it also needs the gstreamer sdk [19:50:17] * yuvipanda hunts for link [19:50:56] hashar: http://people.collabora.co.uk/~slomo/gstreamer-sdk-android-arm-2012.10.tar.bz2 [19:54:08] jcmish: new logs - does the app work in the device now? [19:55:13] jcmish: Krinkle|detached how can we enable jshint on jenkins ? [19:55:27] yuvipanda: is that the same as http://docs.gstreamer.com/display/GstSDK/Installing+on+Linux ? [19:55:48] yuvipanda: oh no that is for linux hmm [19:55:54] yup, this is the android version [19:55:55] (we now have .jshintrc enabled and should be ready to go) [19:55:56] and is in 'beta' [19:56:19] yessir [19:56:28] yuvipanda it loaded right up [19:56:35] and I did a search on it seems fine [19:56:35] *confused* [19:56:39] which sucks [19:56:46] all brion did was add instrumentation [19:56:49] * yuvipanda friendzones phonegap [19:57:55] hey brion! fork github.com/yuvipanda/java-mwapi and https://github.com/yuvipanda/android-mwlogin into wikimedia/*? [19:57:59] commons app depends on them [19:58:10] whee [19:58:46] jcmish: ok i see the XHR lines in your log, but again it's all success :P so that's working in the sim for you or what? [19:59:11] yuvipanda: there are some packages at : http://docs.gstreamer.com/display/GstSDK/Installing+for+Android+development including a debug variant [19:59:34] yuvipanda it just worked [19:59:34] yuvipanda: behold https://github.com/wikimedia/android-mwlogin [19:59:49] * yuvipanda looks [19:59:59] and https://github.com/wikimedia/java-mwapi [20:00:33] brion: sweet [20:00:44] hashar: yup, the link i got was a mroe recent version [20:00:46] but that sohuld work too [20:00:51] do you want me to verify that first? [20:01:41] yuvipanda: sure :-) [20:01:49] alright, let me do that [20:01:54] * yuvipanda goes looking for a Ford_Prefeet [20:01:57] brion: awesome! [20:02:06] yuvipanda: I am fixing the current jobs, they are using they can't find java anymore :( [20:02:13] :( [20:02:18] hashar: also https://github.com/wikimedia/java-mwapi [20:02:32] java library, used by the android apps. has junit tests, would be nice to be autorun on commit :) [20:08:27] jdlrobson: im trying to fix the conflicts in https://gerrit.wikimedia.org/r/#/c/32561/1 but am running into some problems - got a sec to chat? [20:08:40] Yippie, build fixed! [20:08:40] Project WikipediaMobile - Nightly builds build #459: FIXED in 27 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/459/ [20:08:51] not sure what I fixed but apparently it works [20:08:53] yay [20:08:55] awjr: that can be abandoned now.. the jshinting fixes it [20:08:57] hahaha yay! [20:09:00] jdlrobson: sweet [20:09:05] makes life a lot easier :) [20:09:16] Change abandoned: Jdlrobson; "Covered by https://gerrit.wikimedia.org/r/#/c/35789/" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/32561 [20:10:39] MaxSem: do you have some time today to review my esi changes? [20:10:58] jdlrobson: also got this fixed: https://gerrit.wikimedia.org/r/#/c/35825/ [20:11:54] Project WikimediaCommonsMobile - Nightly builds build #1: FAILURE in 2.4 sec: https://integration.mediawiki.org/ci/job/WikimediaCommonsMobile%20-%20Nightly%20builds/1/ [20:11:57] looking [20:12:05] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36051 [20:12:15] awjr, whee, build fixed! [20:12:29] :D [20:12:53] wooo, awesome! [20:12:59] hashar: new project woohoo! [20:13:07] now let's see what's broken [20:13:24] yuvipanda: ndk is not used yet :-] [20:13:26] awjr: can you rebase that? [20:13:39] of course! [20:13:58] Change merged: MaxSem; [mediawiki/extensions/MobileFrontend] (esisupport) - https://gerrit.wikimedia.org/r/35825 [20:13:58] Change merged: MaxSem; [mediawiki/extensions/MobileFrontend] (esisupport) - https://gerrit.wikimedia.org/r/32894 [20:14:05] jdlrobson: its dependency needs merging [20:14:09] oh looks like max did i [20:14:10] t [20:14:19] yay! [20:14:38] MaxSem jdlrobson later today i'll work on merging curent master into the esisupport branch and then we can start doing some testing :) [20:15:24] awjr, I would like to have performance analysis of special page vs API for chnks [20:15:28] *chunks [20:15:31] yuvipanda: so a first issue is that the repo does not have a build.xml file at the root [20:15:41] MaxSem: i dont totally follow ? [20:16:04] hashar: ah, i see it. let me fix that [20:16:28] what we discussed in India: special page might not be the fastest way. we decided to try it, but left other options to be explored [20:17:29] ah yes [20:17:51] yeah we'll need to figure out how best to start perf testing [20:20:51] yuvipanda: then I guess I could simply : GSTREAMER_SDK_ROOT_ANDROID=/home/hashar/android/gstreamer-sdk debug [20:21:01] yup! [20:21:10] but note that the ndk is different from the gstreamder sdk [20:21:24] the ndk is around too [20:21:38] i can't wait for these http://www.bbc.co.uk/news/technology-20526577 [20:21:56] ah, right [20:23:17] hashar: power just went out, and this hostel's will give out in about a minute :( [20:23:23] and Apple claimed to have reinvented the iPhone .. [20:23:25] i'll poke back later, sorry [20:23:32] yuvipanda: tis ok :-] [20:23:37] yuvipanda: enjoy the blackout! [20:23:41] heh [20:23:44] yuvipanda: I will be in bed when you come back :( [20:24:04] yeah, i'll fix all the build issues locally and then poke you. tomo night / sunday night maybe [20:24:05] cya [20:24:15] will be back monday :-) [20:24:21] but he, you can drop me an email -) [20:24:33] New patchset: awjrichards; "allow html in headings (bug 41711)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36054 [20:25:00] jdlrobson: can you confirm that ^ looks ok after i fixed merge conflicts? [20:25:16] if so i'll +2 it [20:26:21] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36096 [20:30:35] yuvipanda and brion so do you think it's worth pushing this latest build out [20:30:46] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36098 [20:31:23] Project WikipediaMobile - Nightly builds build #460: FAILURE in 14 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/460/ [20:31:42] that one is caused by me sorry .. [20:32:29] MaxSem: any thoughts on mediawiki: [20:32:51] Yippie, build fixed! [20:32:52] Project WikipediaMobile - Nightly builds build #461: FIXED in 11 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/461/ [20:32:55] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36054 [20:33:19] jdlrobson, https://gerrit.wikimedia.org/r/#/c/32683/11/MobileFrontend.i18n.php ? [20:33:35] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36112 [20:33:55] MaxSem: https://bugzilla.wikimedia.org/show_bug.cgi?id=41290 < is what i meant [20:35:06] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36139 [20:38:58] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36195 [20:40:55] New patchset: Jdlrobson; "getArticleUrl returns canonical url (bug 41286)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36245 [20:43:05] New review: awjrichards; "this seems to add an extra toggle arrow to the footer and breaks footer toggling." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/36218 [20:43:23] sheesh [20:44:08] first day of the month, i forgot to pay my isp again [20:44:16] doh [20:44:27] oh yeah it's the future there [20:45:32] jdlrobson, 3 sounds really promising [20:47:21] as of 1 were already limiting it to main ns but it gets ignored if the namespace is explicitly specified [20:47:43] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36151 [20:47:59] MaxSem|android: 3 sucks [20:48:11] 3 is backwards [20:48:41] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36245 [20:49:22] 2) we can't modify opensearch output format so the solution could be to create a query module that works similarly [20:51:16] thoughts? [20:52:21] * jdlrobson thinking [20:52:30] jdlrobson, yo. Will you rebase https://gerrit.wikimedia.org/r/#/c/35789/ and I'll merge ? [20:53:55] so MaxSem|android http://en.m.wikipedia.org/w/api.php?action=mobileview&format=json&page=Special%3AAbuseFilter&redirects=yes&prop=sections%7Ctext&noheadings=yes§ionprop=level%7Cline§ions=all returns {"servedby":"srv251","error":{"code":"missingtitle","info":"The page you requested doesn't exist"}} [20:54:04] so we could just reload the page in this case [20:54:26] that would just leave the Main Page as a problem [20:54:34] is there any way we can special case the main page using the api? [20:55:14] wait a minute.. i'm confused.. it does seem to be special cased [20:55:23] * jdlrobson wishes brion was online to decipher his bug [20:56:13] rmoen: doing now [20:56:20] MaxSem|android: sup! [20:57:22] jdlrobson: did you know that you can request iswatched for every page in search results in one request? [20:59:22] i assume you can pass more than one title? [20:59:42] if you open a bug i'll look at refactoring the code to do it in one [21:00:06] jdlrobson: ready in R33 whenever you are [21:03:44] jdlrobson: https://bugzilla.wikimedia.org/show_bug.cgi?id=42587 [21:07:08] jcmish, yuvi: so we can't repro the bug anymore and we're just gonna push a release and see if we can get more logs? :) [21:07:31] Brion agreed [21:07:41] ah heisenbugs [21:07:47] the two people I had test don't have the issue [21:07:56] and I can't repro it on perfecto mobile [21:08:03] weeeird [21:08:07] I'll just watch the feedback to see if it happens [21:08:13] or I can ask a few more people? [21:08:15] maybe it was a server-side issue that mysteriously vanished :P [21:08:20] want me to reach out to a few more? [21:08:28] can try [21:08:40] literally the only difference from v1.3.2-Android is three console.log() lines [21:08:48] k let me see if I can engage a few more folx [21:08:53] whee [21:08:57] thanks :) [21:09:03] you bet! [21:17:50] * MaxSem is back [21:18:00] did I miss anything? [21:18:13] just a bunch of maxsem impersonators [21:19:05] * MaxSem casts Cloudkill [21:19:34] two kills with one shot [21:20:02] :) [21:27:18] MaxSem: do you think it's safe to merge the esi stuff we've done into master? [21:27:36] awjr, have we actually tested if it works?:P [21:27:42] i have locally [21:27:51] with ESI? [21:27:53] yes [21:28:00] i have a local varnish instance running [21:28:16] still, I would like to do some perf testing [21:28:35] well the feature would be disabled by default [21:28:55] otherwise, people will start localising the page name only to see it removed [21:29:04] i have been having a hard time merging master to the remote branch and realized it might be fine to move it to master [21:29:51] i hear your point though [21:30:06] and my gut says you're right. [21:30:19] but my laziness is trying to get the better of me :p [21:41:07] tfinc: can we get one of http://en.wikipedia.org/wiki/Nokia_E52 [21:43:25] jdlrobson: link again please [21:43:52] jdlrobson: tfinc: can we get one of http://en.wikipedia.org/wiki/Nokia_E52 [21:44:12] we only have Nokia E75 - currently with Akapoor [21:44:13] jcmish: per our 1:1 about having the automated regression system available for the team … mail out today to give them a preview of whats coming [21:44:21] k, i'll take care of it [21:44:37] tfinc that sounds good [21:44:45] how do you treat Android tablets when it comes to the mobile redirect? i got this http://en.wikipedia.org/wiki/Sony_Tablet_S and currently it gives me the non-mobile version. that said, i am not even sure yet which version i prefer on this screen size [21:45:21] mutante: we do not redirect tablets … yet [21:45:43] where would you draw the line ..at a certain resolution / screen size? [21:47:06] hmm, i got 1280x800 on 9.4 inch [21:47:15] almost feelsl non-mobile [21:47:53] mutante: we draw the line relative to what WURFL marked as a tablet [21:48:01] our reg ex's are based off of WURFL [21:48:31] so i figure you would have even 3 different versions in the future? mobile-phone, mobile-tablet ? [21:48:47] ah, i heard of that ,gotcha [21:49:12] reads their sourceforge page [21:56:58] jdlrobson: awjr : http://www.burningman.com/art_of_burningman/bm13_theme.html [21:57:20] make sure to scroll down to see the man concept art [21:57:24] tfinc i saw!!! [21:58:55] jdlrobson: phone has been ordered [21:59:24] grrrrrr i am trying to merge changes from master -> the remote branch for esisupport but git review is erroring due to an abandoned change in the esisupport branch >_< [21:59:30] hashar where are you! [21:59:49] * tfinc looks around for brion [21:59:52] tfinc I just had a chat with chrismcmahon and he need to get with Zeljko to answer some of the configuration/framework questions [22:00:05] I'll send that email to the team Monday afternoon [22:00:19] jcmish: even screenshots can work for now [22:00:37] I'll do a high level [22:00:55] the extra snazzy stuff I'll update Monday [22:01:17] tfinc: just today we got the existing desktop suite all green on all browser, but our one Mobile test is not running on the right hosts yet. [22:02:01] so there''s not a lot to see on the Mobile front just right now, but we'll get that right on Monday [22:07:14] wow .. iTunes … this is going to take some time to get used to [22:07:51] tfinc compared to? [22:08:39] compared to the previous version. they just updated it today. iTunes 11 [22:08:48] ah yes I updated [22:09:02] I wondered if that's what you meant … never a dull moment with apple [22:09:28] tfinc btw, Norbert LOVES his ipad Mini [22:09:39] so it was a good idea for his birthday [22:09:41] tfinc: \o/ [22:09:55] excellent [22:10:03] i need to start gaming on it to see if it works well [22:10:16] Square ENIX has ported a lot of the JRPG's that i love to iOS [22:10:33] Chrono Trigger, Final Fantasy, etc [22:10:42] he's just a surfer and has a few apps no real gaming [22:10:49] preilly, what's your concern in https://gerrit.wikimedia.org/r/29827 ? [22:10:59] he's a surfer in Colorado ? does that even work ? [22:11:25] we came from San Diego ;) [22:11:27] MaxSem: The use of dynamic manipulation [22:11:34] I meant web surfer ; [22:11:36] :D [22:11:46] preilly, what's wrong about it? [22:12:26] without it, you have to stop the server, mess with XML and start it again [22:13:50] (in addition to this way being the only recommended for core manipulation) [22:14:51] MaxSem: I think that we would want to use CoreAdminRequest directly [22:15:04] and CommonsHttpSolrServer etc [22:15:10] like? [22:15:27] like: CoreAdminRequest adminRequest = new CoreAdminRequest(); [22:15:27] adminRequest.setAction(CoreAdminAction.STATUS); [22:15:28] CoreAdminResponse adminResponse = adminRequest.process(new CommonsHttpSolrServer(solrUrl)); [22:15:29] NamedList> coreStatus = adminResponse.getCoreStatus(); [22:16:21] and we could use STATUS, [22:16:22] LOAD, [22:16:23] UNLOAD, [22:16:25] RELOAD, [22:16:26] CREATE, [22:16:28] PERSIST, [22:16:29] SWAP, [22:16:31] RENAME, [22:16:32] @Deprecated [22:16:33] ALIAS, [22:16:34] MERGEINDEXES; [22:16:35] * preilly — Sorry, for the multiline spam [22:18:35] alright, so WURFL says my tablet is_tablet: true and identified as 'Generic Fennec Tablet' [22:18:38] preilly, you're doing the same stuff but in SolrJ [22:19:00] SolrJ also does this via HTTP requests [22:19:17] and you *still* need to create the files manually [22:19:48] MaxSem: not true [22:20:02] MaxSem: You can use the EmbeddedSolrServer provides the same interface without requiring an HTTP connection. [22:20:16] New patchset: Jdlrobson; "jshint all the code base" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/35789 [22:20:33] MaxSem: If you need to use solr in an embedded application, this is the recommended approach. It allows you to work with the same interface whether or not you have access to HTTP. [22:22:33] to summarize: you're suggesting to do this in Java, with much more code [22:23:12] New review: Jdlrobson; "Merging after +2 and rebase" [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/35789 [22:23:12] Change merged: Jdlrobson; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/35789 [22:25:07] preilly, EmbeddedSolrServer works as a local copy of the Solr libs. We don't have a local app to access the data. We have a server cores of which we need to modify [22:26:32] MaxSem: Okay just do what you want to do [22:26:39] MaxSem: Nevermind me [22:27:16] preilly, if you add a core in EmbeddedSolrServer it will not appear in Jetty-hosted applet [22:27:49] (unless you save solr.xml and reload the server which will take several seconds) [22:30:57] New patchset: Jdlrobson; "ensure toggling always enabled on pages (bug 42485)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36218 [22:31:20] preilly, then please remove minuses from Gerrit:) [22:31:23] MaxSem: why use Jetty? [22:33:25] because we're already using Solr with Jetty. and because it's much less of a PITA to configure [22:33:49] ..than Tomcat, for example [22:34:07] MaxSem: on vanadium the translate wiki thing? [22:34:12] yes [22:34:27] MaxSem: that's not really a good pattern to follow [22:36:02] New patchset: Jdlrobson; "put edit link in #content (bug 41513)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36309 [22:36:13] what do you have against Jetty? http://raibledesigns.com/rd/entry/jetty_vs_tomcat_vs_resin http://www.infoq.com/news/2009/08/google-chose-jetty [22:37:57] also, we simply don't need the features of more complicated servlet container [22:43:55] New patchset: Jdlrobson; "deal with errors in request for section (bug 41290#2)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36312 [22:45:58] MaxSem: https://bugzilla.wikimedia.org/show_bug.cgi?id=41290#c3 [22:46:47] awjr: https://gerrit.wikimedia.org/r/#/c/36218/ [22:48:07] jdlrobson: lookin [22:51:07] New review: JGonera; "Just to let you know, I changed `curPage` in mf-navigation.js to `article` because of consistency. I..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36151 [22:52:04] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36218 [22:54:22] jdlrobson, what do you mean by "This is probably a good idea as the main page renders incorrectly in the app when requested in a similar fashion."? [22:55:26] is there any way of seeing a diff between two patch sets in gerrit? [22:56:00] MaxSem: so currently in the app if you search for Main Page all hell breaks loose [22:56:32] i stand corrected [22:56:33] it doesn't any more [22:56:34] or even outside of gerrit, after checking out the changeset (though I doubt it since the previous commit is amended) [22:56:34] it used to [22:56:43] is Brion around yet? [22:56:57] As I understand it the Main Page does get special cased through the api [22:57:14] when rendered the title Main Page appears at the top [22:57:22] which isn't a big deal in my opinion [22:57:26] MaxSem: I removed the objections [22:57:45] jgonera there's probably some way to do it outside of gerrit [22:58:35] jgonera there is [22:58:46] jgonera each patset has its own unique sha1 [22:58:51] *patchset [22:59:08] so you can git diff [22:59:47] awjr, right, haven't thought about that, thanks! [23:00:00] jgonera: np it would be nice to do that in gerrit tho [23:01:01] awjr, I'm checking out bigger changesets anyway, I prefer git diff to a dozen of new tabs in my browser ;) [23:01:17] preilly, thanks [23:01:48] hehe fair enough [23:04:19] jdlrobson, MP *gets* special cased [23:04:38] e.g. https://www.mediawiki.org/wiki/Special:ApiSandbox#action=mobileview&format=txt&page=MediaWiki [23:04:57] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36309 [23:05:13] New patchset: Jdlrobson; "update parameters referencing titles when title changes (bug 41710)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36314 [23:05:18] MaxSem: this is what i'm saying. I think brion is confusing me [23:05:24] but without brion I cannot become unconfused [23:05:32] i don't think there is a bug :) [23:05:36] heh [23:05:46] brion: ! [23:06:08] please explain https://bugzilla.wikimedia.org/show_bug.cgi?id=41290 brion [23:06:14] New patchset: awjrichards; "deal with errors in request for section (bug 41290#2)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36312 [23:06:17] are you simply saying we show the heading "Main Page" and shouldn't? [23:07:00] moment [23:07:26] also MaxSem do you really feel strongly about https://gerrit.wikimedia.org/r/#/c/35591/ (cc jgonera ) [23:07:42] ps. good work team - down to just 6 patches in gerrit \o/ [23:07:47] aha, the question is about noheadings [23:08:16] jdlrobson, I don't [23:10:31] jdlrobson, so you need to know if it's a main page? [23:10:44] I'm not sure MaxSem - waiting to hear back from brion [23:10:55] MaxSem: so should 35591 be merged? [23:11:06] feel free to [23:11:10] sweet [23:11:35] I've removed my -1 [23:11:45] New review: Jdlrobson; "jdlrobson: also MaxSem do you really feel strongly about https://gerrit.wikimedia.org/r/#/c/35591/ ..." [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/35591 [23:12:41] jdlrobson, have you opened a bug for the back button problem in https://gerrit.wikimedia.org/r/#/c/32552/ ? [23:13:01] jgonera: https://bugzilla.wikimedia.org/show_bug.cgi?id=40904 [23:16:48] brion: http://www.mediawiki.org/wiki/Wikimedia_Engineering/2012-13_Goals#Mobile [23:16:59] whee [23:20:00] jgonera: https://gerrit.wikimedia.org/r/#/c/35591/ could you rebase? [23:20:40] ok where was i... [23:21:20] jdlrobson: still need info on 41290? [23:21:27] brion: up [23:21:37] yup brion - not sure what the bug is [23:21:43] is the bug simply that the title "Main Page" is printed at the top ? [23:21:48] if so could you update the bug [23:21:53] as it does seem to be special cased [23:21:57] bug is that we have different display of the main page depending on how you got there [23:21:58] and it was causing me confusion [23:22:05] so it is the title ? [23:22:16] title is the main thing off the top of my head, at least on my test pages [23:22:31] i think it also doesn't do the special casing for the mw-mf-tfa sections etc but i'm less sure atm [23:23:13] New patchset: JGonera; "(bug 41091) Images in dynamic sections even when images disabled" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/35591 [23:23:29] jdlrobson, done [23:23:38] thanks jgonera [23:23:40] New patchset: Jdlrobson; "photo uploads for articles without images in the summary section" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/32683 [23:24:31] New patchset: awjrichards; "replace all tables with a link to open table in an overlay" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/32552 [23:26:46] brion, the only difference I see is heading, page content is special-cased. and the heading is added by JS [23:27:12] well then that makes it a smaller bug :) [23:27:50] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/32552 [23:29:23] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/35591 [23:32:12] awjr: shouldn't have merged that [23:32:23] jdlrobson: which? [23:32:27] https://gerrit.wikimedia.org/r/#/c/35591/ [23:32:42] toggling now broken [23:33:10] fix on way [23:33:17] jdlrobson: i was just merging it after you had approved it and jgonera fixed the resulting merge conflict, i didn't test since i figured you had already. my bad :( [23:33:47] another fix got merged which broke it [23:33:57] awjr, one small part of API changed and the code didn't work as expected after merge, my bad, should have checked before pushing [23:34:06] doh [23:34:07] it is ok [23:34:35] i should have checked too; it's hard not to get lazy after doing code review all day [23:35:12] New patchset: Jdlrobson; "follow up to I3493fa549fa082002de540fae63306e10e83154d" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36321 [23:35:26] https://gerrit.wikimedia.org/r/#/c/36321/ [23:35:38] awjr: do you want to quickly verify and merge [23:35:43] ta [23:35:45] jdlrobson, see brion ^^^ [23:35:45] *ya [23:36:01] MaxSem: yup saw that [23:36:03] i'll update bug [23:36:10] so the API needs to tell you if it's main page and you need to special case it [23:37:15] yup that works [23:37:22] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36321 [23:37:26] well.. all it needs to say is that we shouldn't show the title right? [23:38:17] yes. unless we find something else [23:38:25] (:P) [23:43:05] New patchset: MaxSem; "Simplify rules" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36323 [23:45:57] New patchset: awjrichards; "Simplify rules" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36323 [23:47:28] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36323 [23:50:54] jdlrobson: im looking at https://gerrit.wikimedia.org/r/#/c/36314/1 - is there not a way to update query string params with some function provided by one of the mediawiki resources? [23:51:09] jdlrobson, sheesh - action=mobileview already tells you if it's a main page [23:52:36] jdlrobson: i think there's some magic in mediawiki.Uri that would do the trick