[17:40:10] Change restored: awjrichards; "Restoring change to allow merge of code from master; will revert after" [mediawiki/extensions/MobileFrontend] (esisupport) - https://gerrit.wikimedia.org/r/32896 [17:40:33] New patchset: awjrichards; "log when a section is opened on beta" [mediawiki/extensions/MobileFrontend] (esisupport) - https://gerrit.wikimedia.org/r/32896 [17:40:55] awjr, gerrit fun? [17:41:04] MaxSem: hi! yes [17:42:45] MaxSem: but now the esisupport branch has changes from master, at least up until last friday afternoon (pacific) [17:43:04] Change abandoned: awjrichards; "(no reason)" [mediawiki/extensions/MobileFrontend] (esisupport) - https://gerrit.wikimedia.org/r/32896 [18:00:22] brion: are you duting jury duty today or will you be joining us for standup? [18:00:42] no jury duty for me today, guess it's time to set up the standup :D [18:00:51] brion yes please :) thanks! [18:24:31] muhaha http://wiki.openstreetmap.org/wiki/Developer_FAQ#Why_don.27t_we_spread_the_load_on_the_OpenStreetMap_database_across_a_number_of_servers.3F [18:24:58] o_0 [18:25:46] aka "you don't scale, ever" [18:25:59] that is surprising to me [18:26:12] how do they run openstreetmap.org? [18:26:22] guys can we get https://gerrit.wikimedia.org/r/#/c/32683/ reviewed before the code cut off [18:26:35] with one beefy tileserver, it appears [18:26:38] ^ brion awjr MaxSem jgonera [18:26:54] oohh when i@ brion a loud pop sound appears behind me [18:26:57] brion [18:26:59] brion [18:27:00] brion [18:27:01] hehe [18:27:14] brion [18:27:18] haha [18:27:37] :P [18:29:14] awjr: mostly they ask people not to use it, far as i can tell ;) [18:29:24] lol [18:29:27] and ;_; [18:30:07] MaxSem: does that mean we need to make OSM scalable? [18:31:01] mmm, first of all, we could try running PG and tileserver on different machines [18:31:29] though it can make things slower if they do a lot of small DB requests [18:31:56] then, just throw a lot of Varnishes at this [18:32:35] though frontend caches will not help you with tile rendering [18:33:01] MaxSem: have you had any conversations with ops about this yet? [18:33:41] now I'm trying to interrogate them about the HW we already have for this [18:33:53] roger [19:04:23] New patchset: Jdlrobson; "reorganise the section anchor rules" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36592 [19:10:12] jdlrobson, jgonera: michelle updated the current story wall with the remaining outstanding bugs that had been prioirtized for the bug fix/qa sprint [19:20:02] New patchset: Jdlrobson; "add close this section to dynamically rendered pages (bug 41605)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36593 [19:24:09] New review: awjrichards; "See inline comments. Also in general it would be nice to see more comments explaining some of the mo..." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/32683 [19:25:09] https://mingle.corp.wikimedia.org/projects/mobile/favorites/show/625 [19:25:19] jgonera ^ [19:25:34] New patchset: Jdlrobson; "photo uploads for articles without images in the summary section" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/32683 [19:25:40] thx [19:27:01] New review: awjrichards; "Same comments apply from previous patchset." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/32683 [19:30:11] New review: awjrichards; "Jon mentioned to me in IRC that mediawiki.uri is not available to use here." [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/36314 [19:31:47] jdlrobson: there is a merge conflict with https://gerrit.wikimedia.org/r/#/c/36314/ - can you take a look? [19:32:28] sure awjr story of my life [19:36:01] New patchset: Jdlrobson; "update parameters referencing titles when title changes (bug 41710)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36314 [19:36:05] awjr: ^ [19:36:31] Maryana, awjr, I'm not sure where the remaining outstanding bugs are on the story wall [19:36:37] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36314 [19:37:03] New patchset: JGonera; "photo uploads for articles without images in the summary section" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/32683 [19:37:06] jgonera: whatever is sitting in 'ready for development' on https://mingle.corp.wikimedia.org/projects/mobile/cards/grid?color_by=type&filters%5B%5D=%5BType%5D%5Bis%5D%5BStory%5D&filters%5B%5D=%5BType%5D%5Bis%5D%5BTask%5D&filters%5B%5D=%5BType%5D%5Bis%5D%5BBug%5D&filters%5B%5D=%5BIteration%5D%5Bis%5D%5B%28Current+Iteration%29%5D&group_by%5Blane%5D=status&lanes=Ready+for+Analysis%2CIn+Analysis%2CReady+for+Development%2CIn+Development%2CReady+for+ [19:37:13] that is an amazing url.. [19:37:44] thanks jdlrobson, merged [19:37:47] ;) [19:37:49] thanks [19:38:04] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36335 [19:38:18] jdlrobson: i've been meaning to ask you - have you encountered andy stickycookie related issues recently? [19:38:23] s/andy/any [19:38:37] awjr: not yet [19:38:56] jdlrobson: i think i found what was causing the problem you mentioned while in india and a fix went out a couple of weeks ago [19:41:47] andy stickycookie is our new mascot [19:41:56] lol [19:41:59] * awjr facepalm [19:42:23] kind of like leap day william (if anybody's into 30 rock here...) [19:42:43] New review: awjrichards; "This looks ok, and works nicely with search, but behavior is funky in conjunction with 'random'. Det..." [mediawiki/extensions/MobileFrontend] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/36334 [19:44:15] New patchset: awjrichards; "reorganise the section anchor rules" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36592 [19:44:46] New patchset: awjrichards; "add close this section to dynamically rendered pages (bug 41605)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36593 [19:45:36] New patchset: Jdlrobson; "photo uploads for articles without images in the summary section" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/32683 [19:45:37] awjr: ^ fixed the endpoint issue [19:46:11] cool jdlrobson [19:46:18] jdlrobson: another merge conflict - https://gerrit.wikimedia.org/r/#/c/36334/ [19:46:22] sigh [19:46:51] i've been trying to fix merge conflicts as they come up but sometimes (particularly with the js stuff) im unclear on what the Right Thing to Do is [19:47:57] New review: awjrichards; "This breaks unit tests." [mediawiki/extensions/MobileFrontend] (master); V: -1 C: -1; - https://gerrit.wikimedia.org/r/36592 [19:48:40] New patchset: Jdlrobson; "special case main page (bug 41290)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36334 [19:48:43] awjr: luckily that was an easy one ^ [19:48:49] New review: awjrichards; "dependency breaks unit tests. please fix dependency then rebase this change." [mediawiki/extensions/MobileFrontend] (master); V: -1 C: 0; - https://gerrit.wikimedia.org/r/36593 [19:49:09] awjr: good catch on the unit tests - looking forward to automated phantoms ones (jgonera :)) [19:49:31] jdlrobson: you can thank jenkins :) [19:49:46] ahh this was php unit [19:49:55] yessir [19:50:50] New patchset: Jdlrobson; "reorganise the section anchor rules" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36592 [19:50:51] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36334 [19:52:08] New review: awjrichards; "Looks ok to me; would like to have a js ninja review as well. jgonera or brion?" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/32683 [19:52:18] jgonera and/or brion can you take a look at ^ [19:52:27] jgonera tried it earlier [19:52:38] awjr, I'm looking at it right now [19:52:43] New review: Brion VIBBER; "Comments as of patchset 14:" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/32683 [19:52:43] ty [19:54:56] brion: i repied to the firefox error! [19:55:03] we don't support firefox in beta [19:55:12] fuck that dude [19:55:15] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36592 [19:55:37] New patchset: awjrichards; "add close this section to dynamically rendered pages (bug 41605)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36593 [19:56:18] I can disable it for firefox but I don't think we should waste time trying to perfect this code first time round [19:56:37] are you sure you are using latest patch set brion "mysterious error messages in Chrome on Android " <- error reporting should be better now [19:56:53] and the thumbnail thing although annoying i don't think is a showstopper [19:56:58] be nice to fix it though [19:57:01] clicking on license link opens it in the same window; when going back to the previous page we may lose data such as the file we've just selected < happy to fix that though [19:57:04] what's up with that editing thing? [19:57:25] brion the api doesn't return the thumbnail so it's not clear what size it should be [19:57:47] it should fit within the user's selected thumbnail size; you'll have to get that from the user settings and export it to the js [19:57:49] i've never seen the editing problem - looking into that now [19:58:03] yeah the editing redirect loop is weird, i see it in all browsers at least on this page [19:58:10] http://leuksman.com/mw/index.php/Upload_test [19:58:41] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36593 [20:03:01] k now seeing the infinite edit redirect loop [20:03:06] wasn't doing that before.. [20:03:11] only on firefox though [20:04:30] i get same in chrome and mobile safari [20:05:37] New review: JGonera; "Tested on Android and it works, I'll give it a +1. I agree with awjr that we could use more comments..." [mediawiki/extensions/MobileFrontend] (master) C: 1; - https://gerrit.wikimedia.org/r/32683 [20:10:12] New patchset: Jdlrobson; "photo uploads for articles without images in the summary section" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/32683 [20:12:36] New review: Jdlrobson; "In response to Brion:" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/32683 [20:13:18] so brion awjr_lunch jgonera - decision time on https://gerrit.wikimedia.org/r/#/c/32683/ > needs to be merged by 1pm otherwise we lose another week of potential photo uploads and useful testing in beta [20:13:48] New review: Brion VIBBER; "No visible error messages in Chrome if can't upload due to CORS error (not being in the Access-Contr..." [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/32683 [20:17:03] brion: seem to have worked out what's happening with the infinite redirect [20:17:08] \o/ [20:18:43] New review: Brion VIBBER; "I'm reasonably satisfied for now, we can improve the error reporting and compatibility as time goes on." [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 2; - https://gerrit.wikimedia.org/r/32683 [20:18:44] Change merged: Brion VIBBER; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/32683 [20:19:12] wheeeee [20:25:22] how do I set up various languages on my local mediawiki? I'm trying to fix this: https://bugzilla.wikimedia.org/show_bug.cgi?id=41875 [20:26:41] New patchset: Jdlrobson; "don't attempt to load the edit page dynamically" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36607 [20:27:02] brion: ^ infinite redirect bug fixed [20:27:14] awesome th\x :D [20:32:25] jgonera, $wgLanguageCode = "zh"; [20:32:30] we should get that one in as it is pretty serious and will break editing which was the subject of this thursday's metric meeting :) [20:36:20] New review: Jdlrobson; "Whoops this should have referred to bug 41446" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36593 [20:41:52] Change merged: Brion VIBBER; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36607 [20:42:27] jgonera: if you are working on https://mingle.corp.wikimedia.org/projects/mobile/cards/255 can you please drag the card over to 'in development'? [20:42:45] awjr_lunch, sure [20:44:12] jgonera: thanks :) that way noone else picks it up [20:44:45] awjr_lunch, I know, should I also marked it as assigned on bugzilla? [20:44:53] by the way... awjr_lunch, who will deploy tomorrow? [20:45:20] jgonera: sure, although we're generally less good about updating asignment in bugzilla :p [20:45:53] MaxSem: i can take it since you've done the last N deployments [20:51:44] awjr_lunch, I've no problems with deploying today, just want to know for whom of us it will cause less disruption [20:58:08] Maryana: we're meeting at 1 right? [21:00:22] yep - in r61 [21:03:51] no remote people for the design session? [21:05:42] looks like no. [21:56:40] brion when you guys are done with the design mtg, can you set up for us remoties in r31 for the kickoff meeting? [21:57:06] awjr: yeah we're still wrapping up [21:57:16] brion no worries, i figured. thanks! [22:03:50] sorry, we ran a bit overtime on dev/design, but we're heading down now [22:03:57] groovy [22:07:54] MaxSem: kickoff meeting! [22:09:11] https://mingle.corp.wikimedia.org/projects/mobile/favorites/show/625 [22:09:16] next iteration story wall ^ [22:29:59] jdlrobson: when are you leaving for the UK? im tentatively planning on being in SF 16 Dec through 28 Dec [22:30:33] im hoping to not totally miss you while in town [22:33:40] awjr: 19th is my flight [22:33:47] let me update calendar [22:34:11] jdlrobson: cool, i'll at least see you for a couple days then [23:07:43] New patchset: Jdlrobson; "fix styling of page load error message (bug 41613)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36663 [23:08:57] ^ awjr brion jgonera i know it's after the cut off time but it's a very simple contained css change [23:09:05] * awjr looks [23:10:55] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36663 [23:11:30] whee [23:21:48] brion do you know how URLs get made 'pretty' on the cluster? eg turning en.wikipedia.org/w/index.php?title=Foo into en.wikipedia.org/wiki/Foo [23:22:07] is that done with url rewrite rules in apache or something, or is it MediaWiki magic/ [23:22:25] awjr: something somewhere (possible in MediaWiki.php ?) sees that you have a page with no parameters but the title and it's not the canonical URL, and redirects you [23:22:43] we actually sorta disable that in MobileFrontend because it kept redirecting you back to the non-mobile site [23:22:55] eeenteresting [23:25:43] # UseMod compatibility URLs RewriteRule ^/wiki\.cgi$ /w/index.php?title=%1 [R=301,L] heh :) [23:26:08] hmm mutante where is that? [23:26:54] awjr: repository "operations/apache-config" ... file "remnants.conf" [23:27:19] i am not sure 100% what you said is there..but noticed those usemod compat redirects there at least [23:27:31] ok cool thanks mutante, i'll take a peak [23:27:35] redirects.conf and remnants.conf are a place to check though [23:27:45] sweet thanks [23:31:51] do we have any other materials for the DOMParse performance issue https://mingle.corp.wikimedia.org/projects/mobile/cards/262 ? [23:32:11] it looks like the average has only barely raised [23:32:18] 50th percentile shows about the same [23:32:26] there's some growth in the 90th and 99th percentile graphs [23:32:37] but it's unclear just what/why [23:32:50] brion offhand, no. but asher is the one who spoke with me about it so he might have more info [23:32:51] however the total count is waaaay up which may mean the boxes are more loaded [23:33:51] double parsing of output may have something to do with it (i think there's a bug about it somewhere) [23:35:51] awjr: definitely not; double parsing of output for collapsible sections doesn't appear to have gone live until october [23:36:00] while these increases start in april/may [23:36:07] hmm [23:36:21] if anything, the times have gone down since that went in [23:36:29] ! [23:36:32] interesting [23:36:50] from ~200ms to ~175ms on the 99th-percentile chart [23:40:10] awjr: https://mingle.corp.wikimedia.org/attachments/e62c96b3a8b9fd0cf59f86006da10af8/177/perf-graphs-domparse.pdf more graphs :) [23:40:20] MOAR GRAPHS! [23:40:53] fun with graphite :D [23:41:05] brion what is tp50? [23:41:22] 50th-percentile (50% of items are at or below this value… i think) [23:43:20] there was also a concern from preilly on mobile-tech recently (topic called "Mobile Performance Issue") [23:45:02] i'm not sure what i'm looking at in "mobile performance issue" thread [23:49:18] i don't see any obvious problems in that graph [23:49:18] preilly, ^^ [23:49:36] it just looks like a usage graph showing our usage going modestly up week on week [23:49:47] with some brief temporary spikes during deployments [23:49:53] is there anything ongoing that's a problem?\ [23:50:26] I also spent some time investigating this, found nothing that could have caused an increase around that time [23:50:42] we've all been doing different stuff at that time [23:50:53] no development=no regressions) [23:51:00] :)