[00:05:32] ok i have to sync up with tfinc when he gets back from jury duty on android deployment stuff, i'll wander out for now and be back online around 6:30-7:30ish [01:50:01] MaxSem, is there a method somewhere which would allow me to generate a proper mobile URL with a language variant from a URL without a variant? let's say I have http://sr.wikipedia.org/wiki/Slovenia and I want to get http://sr.wikipedia.org/sr-el/Slovenia [01:53:08] Title::getLocalUrl() [01:53:32] first parameter array('variant'=>'sr-el') [01:53:48] (apparently, haven't tried it myself) [01:55:35] that's what I'm using but this generates a URL with a query string ?variant=... which would be fine if the variant didn't get swallowed on redirection [01:57:48] you need to set $wgVariantArticlePath [02:03:53] MaxSem, thanks, this works, although for some reason I still get redirected to the non-variant URL on my local instance [02:04:52] nope, it's not only local instance [02:06:18] hm, I guess the problem is on the JS side [03:00:00] brion: yo! [03:00:14] hey hey [03:00:19] how's the jury duty treating ya [03:00:25] brion: ready for the key ? [03:00:29] yes [03:00:37] brion: pretty good. i'll know by noon tomorrow wether i'm on a jury or not [03:00:44] let me load up my other laptop to send you the key [03:00:50] fun fun. i have to report in tomorrow afternoon, we'll see what they do with me [03:02:06] wee ... [03:02:34] brion: ok. you have the key now [03:02:46] brion: now hop on gchat and i'll pass you the rest [03:09:41] whee [10:10:36] New review: Hashar; "recheck" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/32718 [10:51:45] New review: Hashar; "recheck" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/32718 [10:53:29] New patchset: Hashar; "JENKINS validation (do not submit)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36731 [10:54:04] New review: Hashar; "recheck" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/32718 [10:54:43] New review: Hashar; "Sorry for the spam above. The Jenkins linter was not verifying the correct directory :-/" [mediawiki/extensions/MobileFrontend] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/32718 [11:02:13] Change abandoned: Hashar; "(no reason)" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36731 [18:02:30] * yuvipanda waves at awjr jcmish [18:02:36] whattup yuvipanda [18:02:50] just got back to Chennai [18:02:51] yuvipanda are you back? [18:02:52] ! [18:02:57] jcmish: yup! [18:02:58] welcome home :) [18:03:08] just parent's house :) [18:03:08] are you exhausted? :D [18:03:23] oh then you should be well rested [18:03:25] and well fed! [18:03:42] was hearing a story of how a fellow geek is being screwed over very badly (he might drop out) by my college, and realized i'll have to go talk to those same people in a few days and act like nothing's wrong [18:03:45] so… raging :) [18:03:56] oh no way! [18:04:40] it's rage at my helplessness... [18:04:46] anyway, did brion manage to get the key? [18:04:53] if not i'll make the build [18:05:11] hmm not sure [18:07:37] preilly.. I've been testing on staging and it seems to be getting super slow, is there anything I can look at? [18:22:42] RagePanda: Did you fly out of Delhi boss ? [18:22:52] rmoen: yup :) [18:22:58] in chennai [18:23:06] sadly [18:23:26] Ahhh back with your peoples. I take it Delhi remained fun despite the discriminations ? [18:24:11] rmoen: yup! very [18:24:17] rmoen: Chennai is no fun. [18:24:28] i've been here 5 hours and already super grumpy [18:24:55] RagePanda: good to hear. Hopefully RagePanda doesn't become SadPanda later today =/ [18:25:29] just some college stuff. I'll figure it out. [18:25:43] RagePanda, was that like a 5 hour flight or something? Gotta write those exams. [18:26:10] rmoen: will. hopefully will do so without biting someone [18:26:50] RagePanda: ust don't get Rabies or something [18:26:56] Just ^^ [18:27:34] As, if you bite you may be bitten back [18:28:23] rmoen: :D [18:28:27] will try not to [18:28:36] rmoen: if you're in the office, do you see a brion? [18:28:42] oh wait, he might be on jury duty! [18:28:44] awjr: ^ ? [18:28:53] Ahhh tfinc and brion both ? [18:28:57] What are the odds [18:28:58] tfinc for sure [18:29:06] brion said he was doing jury duty but he was in yesterday [18:29:24] * rmoen peers around the office and sees no 3d brion [18:29:30] but maybe his didn't start until today [18:29:51] rmoen: not always the best tactic, it's not uncommon for him to stroll in late or WFH, but im pretty sure he's jury duty today [18:30:08] in fact i see no 2d brion either =/ [18:30:35] awjr: that's just crazy they both have jury duty the same week. [18:30:58] hehehe rmoen for real [18:31:01] trial buddies [18:31:48] awjr: it would be even crazier if they mutually knew the defendant.. [18:31:55] haha [18:32:00] some crazy mafia biz [18:32:06] even crazier if the defendant turned out to be jdlrobson [18:32:16] maybe secretly they are the defendants but are covering it up by saying they have 'jury duty' [18:32:37] RagePanda, awjr: lols [18:33:54] jcmish: alright, then i'll just make a build. Can you test it and give me an 'ok' so i can push it? [18:34:06] yup [18:34:08] jcmish: probably just labs being labs [18:34:08] ok [18:34:22] preilly aww :( [18:34:44] jcmish: you could ping Ryan Lane in #wikimedia-labs and ask as well [18:34:52] yuvipanda are you doing android [18:34:54] ? [18:35:02] and iOS or is iOS Brion's domain? [18:35:13] preilly thanks a bunch [18:35:19] jcmish: np [18:49:17] jcmish: android, yes [18:49:44] yuvipanda sounds good [18:50:19] jcmish: your irc client should have nick completion, which will also notify me :) [18:52:10] hehe I am irc challanged :D [19:02:51] * RagePanda wonders what brion did to his branch [19:02:54] a fetch is taking ages [19:03:36] RagePanda: Last time I was on IRC properly was like two months ago, and you were PissedPanda then. YOu haven't been angry for two months straight, have you? :/ [19:03:49] Jarry1250: :D [19:03:49] no [19:04:03] i think [19:05:16] bugzilla come back! [19:06:35] [WikipediaMobile] yuvipanda pushed 1 new commit to v1.3.2-Android: http://git.io/oo2EXA [19:06:35] WikipediaMobile/v1.3.2-Android fe147c5 Brion Vibber: Add minor instrumentation for XHR checks [19:07:09] RagePanda: You don't know if you've been angry or not? You're single-handedly underminding my whole Philosophy 101 course. Sheesh. :D [19:07:14] Project WikipediaMobile - Nightly builds build #463: SUCCESS in 21 sec: https://integration.mediawiki.org/ci/job/WikipediaMobile%20-%20Nightly%20builds/463/ [19:07:15] yuvipanda: Add minor instrumentation for XHR checks [19:07:18] :P [19:08:09] jcmish: https://dl.dropbox.com/u/8768784/Wikipedia-v1.3.2.apk [19:08:20] jcmish: run it through tests? [19:08:37] jcmish, could you remind me what was the wiki page with Cucumber-like acceptance tests? [19:08:38] and shoot me an email if things look okay, i'll put it on the store tonight (your time) [19:09:34] RagePanda: doing it now [19:09:46] jcmish: run it through unaffected phones too [19:12:01] RagePanda: on it [19:12:05] yup tis the plan [19:17:02] jgonera: http://www.mediawiki.org/wiki/Mobile_Browser_Regression_Tests [19:18:07] jcmish, thanks, by the way, can anyone outside the Q&A team participate in the meeting you mentioned during yesterday's standup? [19:18:33] jgonera: ? [19:19:00] oh the one for you with QA? [19:19:13] everyone's invited :D I was gonna just invite mobile tech [19:19:18] jcmish, I vaguely remember you said that the testing team was going to meet to discuss the testing tools [19:19:23] oh, ok, great ;) [19:26:53] is mingle busted for folks? [19:28:07] jdlrobson, jcmish, MaxSem, jgonera ^ [19:28:38] WFM [19:28:58] hmm [19:29:04] awjr: same here [19:29:10] working fine [19:29:11] oh now it's working o_O [19:29:24] i've been having random networking weirdness this morning :( [19:29:41] awjr: gremlins [19:29:55] jcmish: most likely [19:33:39] jgonera: did I hear you say that you're working on getting the qunit tests automated along with jshint? [19:34:44] jcmish, yes, I got it running actually, I still have to think what is the best way of dealing with the fact that everyone has their dev environment set differently [19:35:12] jgonera: ant with ivy might be nice [19:37:18] I don't have much experience with ant, but generally the way the official phantomjs runner for Qunit works is that you pass the URL to the test page, but people might have apache set up in different ways so the URL is not always the same [19:37:34] probably I'll put a configuration option somewhere [19:38:17] do we already use ant anyway? [19:38:51] did i hear is mingle busted? :) [19:40:47] jdlrobson: seems to be fine now [19:41:01] i think it was something between me and my isp [19:41:08] sorry awjr i was trolling mingle as tool again.. ;-) [19:41:12] it's been a while.. [19:41:17] hahaha [19:41:39] it's hard to pick up on subtle nuances over irc :p [19:43:31] andre__: it looks like bugzilla is back up - is it safe to use now? [19:43:48] awjr, should be [19:43:53] thanks :) [19:43:54] did some basic testing [19:44:00] cannot promise that nothing broke :P [19:45:04] * andre__ bbl [19:47:14] New patchset: awjrichards; "Make 'mobile view' link respect canonical URLs when possible" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36809 [19:52:50] jdlrobson you there? [19:52:57] yup munaf [20:49:46] jcmish: how are things looking for deployment, are we about ready to go? [20:50:16] awjr: looking good to me [20:50:31] nothing super hairy and scary [20:50:46] groovy [20:50:54] i'll start preparing the deployment branches [20:51:00] kayo [21:00:24] jcmish, jdlrobson, jgonera, MaxSem, Maryana changes should now be live on testwiki [21:00:35] w00t [21:00:38] please test away! [21:00:55] no more jury service for me [21:00:56] back in the office [21:01:01] hi tfinc [21:01:06] i never got called into the jury box [21:01:12] bummer? [21:01:12] too bad as i would have want to do the case [21:01:19] what was the case? [21:01:21] that's prolly why you got dismissed :) [21:01:23] civi landlord tenant eviction [21:01:34] likely due to a "service" animal [21:01:53] tfinc: did you run into brion? [21:02:03] tfinc: wait are you saying the landlord evicted someone because they had a service animal? [21:02:18] awjr: i did not [21:03:39] awjr, what was the address of testwiki? [21:03:51] jgonera: test.wikipedia.org [21:04:22] jdlrobson: the table on the main page of testwiki in non-beta looks different to me than it did previously - it overflows beyond the content area (to the right) [21:05:01] coming down to 3 to join the fun [21:05:03] jcmish: anything that i tell you will be whatever i put together from the judge and the lawyers questioning potential jurors. i wasn't party to the actual trial evidence. but its pretty easy to see what the trial would be about [21:05:27] tfinc: I wonder if you got dismissed because you're a renter? [21:05:37] jcmish: i was never selected into the juror box [21:05:45] jcmish: and thus never questioned [21:05:47] pure randomness there [21:05:50] tfinc: aww [21:05:57] ddin't you have to fill out the sheet [21:06:06] that tells your background? we had to do that here in CO [21:06:16] jdlrobson: i am seeing that overflow on ics and ios [21:06:46] jcmish: you declare basic information when you get selected for the juror box [21:06:56] otherwise your sitting in the room just listening [21:07:01] tfinc: aha! [21:07:45] jdlrobson: looks fine in beta tho [21:07:50] here they ask specific questions that rate to the case [21:08:18] high level like if it's a car accident case have you have been in one or has anyone in your family that kind of stuff [21:08:38] then you sit and wait til they decide who is picked and who are alternates [21:08:53] jcmish: so they would have had no clue about my renter ownership [21:09:02] feck awjr you are right :( [21:09:49] it only effects the home page [21:09:50] i did enjoy that we had a puppy in the courtroom [21:09:54] jcmish: --^ [21:10:09] HAHAHHA [21:10:12] and the judge was hilarious [21:10:13] jdlrobson: are there other articles on testwiki with large tables that you know of? [21:10:22] if that ha been my case then perhaps i wouldn't have laughed as much [21:10:24] but she was on point [21:10:26] tfinc: sounds like it would have been a neat case though [21:10:41] jcmish: yup, i wonder if the'll be public info after it settles [21:10:44] san francisco has some, i think, awjr [21:11:24] awjr: mm actually this doesn't make much sense [21:11:57] ohh yes it does [21:12:00] got it [21:12:44] beta adds a #content div [21:12:50] which isn't present in non-beta [21:12:51] not sure why [21:13:15] * tfinc wonders if brion will get selected [21:13:33] most strange [21:13:39] jdlrobson: yeah, san francisco article is also affected :( [21:13:46] awjr: ^ [21:13:55] oh [21:13:59] * awjr reads backscroll [21:14:21] jdlrobson: is that a quick fix for non-beta? [21:14:34] Finish testing non beta [21:14:38] and all looks well [21:14:47] uhoh reading about beta now… [21:15:14] jcmish: the only issue i've seen so far is in non-beta - large tables overflow to the right of the content area (this is a regression) [21:15:50] New patchset: Jdlrobson; "add #content element to non-beta" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36878 [21:15:57] awjr: yes ^ [21:16:12] deck wrong commit [21:16:31] New patchset: Jdlrobson; "add #content element to non-beta" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36878 [21:16:34] awjr: is that the big blue button with <mobile… showing on the page? [21:17:08] jcmish: i think that is only in beta (if you tap it does it load a table in an overlay?) [21:17:16] jcmish: the problem is in non-beta [21:17:28] New patchset: Jdlrobson; "add #content element to non-beta" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36878 [21:18:16] jdlrobson: looking now at ^ [21:18:23] awjr: yessir that's it [21:19:30] Change merged: awjrichards; [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36878 [21:19:51] jcmish: i see we have jshint running on MobileFrontend \o/ [21:19:58] have you had anything to do with that ? [21:20:24] jdlrobson: it's pretty awesome [21:20:32] can we blacklist certain files? [21:20:36] but nope :( [21:20:43] currently it's running on some js files that I don't want it to [21:20:50] I'll mail the list [21:20:54] I read about it this weekend [21:21:12] but usually all of the codequality stuff gives you the ability to ignore [21:21:24] certain types of files and or formats with some kind of list [21:22:11] Maryana, I'm working on https://bugzilla.wikimedia.org/show_bug.cgi?id=41875 and I'm wondering where should I put the list of language variants. should it appear after clicking the "Read in another language" button? maybe it should differ slightly from the rest of listed languages? who should I talk to about this? [21:22:30] jdlrobson, jcmish ok the new change should be live on testwiki now [21:22:35] sweet [21:23:14] awjr: fixed for me now [21:23:28] jgonera: that sounds like something the localization team should be able to help with [21:23:29] jgonera, looks like it needs a design - variants are far more important than interwikis and have a prominent place on non-mobile site [21:24:13] jdlrobson, jcmish yeah looks good now - thanks for the fix jdlrobson :) [21:24:28] yeah, i would get in touch with pau giner, who's been working on the desktop language selector, jgonera [21:24:58] Maryana, variants != languages [21:25:22] true, but of all the people we have working on similar projects, his is the most similar [21:25:54] if we currently don't provide a place for variants in MF this might be a good candidate to turn into a story card and work more formally with product/design to get it right? [21:26:30] is he on IRC or I should just write him an e-mail? [21:26:47] awjr: jdlrobson \o/ [21:27:07] awjr, sure, I already have a fix for that, I just don't know where to put it in the UI [21:27:30] yeah, we probably need to rope pau into this stuff regardless, cos he's done a lot of work on language selection and it would be nice to reuse it :) jgonera, not sure if he's on IRC (he's also in spain), but email should work - pginer@wikimedia [21:27:33] jcmish: can you make sure dbl checking tables is in the regression tests? [21:27:53] ah ok jgonera [21:28:16] yup [21:28:23] have it written up [21:28:40] jdlrobson: random page suggestions also overflow to the right [21:28:59] oh wait… not all the time [21:29:17] but sometimes for sure [21:29:24] * jdlrobson hopes equolence will prefer the new random functionality [21:29:28] thanks jcmish :) [21:29:58] test.wiki has now gone slow for me :( [21:31:57] jdlrobson: the thing you added that updates the URL to the random page selected does not appear to be working for me in ICS (though it does in desktop chrome) [21:32:59] and it appears to work in ios [21:33:15] could be https://bugzilla.wikimedia.org/show_bug.cgi?id=41605 awjr [21:33:56] maybe i missed this farther up, but is anybody seeing the photo uploader, or is it not going into today's deployment? [21:34:16] it should be in today's deployment [21:34:17] Maryana: you need to be logged in and on a suitable article [21:34:33] * awjr stabs comcast [21:34:49] got a test.wikipedia example article that's suitable? :) [21:35:14] i've been flipping through random but not seeing it [21:35:40] awjr: can you go to http://jonrobson.me.uk/mobile/pushState.html [21:36:00] jdlrobson: no - having networking problems [21:36:03] :( [21:36:05] been having weidrness all morning [21:36:06] when you get a chance then [21:36:10] ah there we go [21:37:25] Maryana: http://test.m.wikipedia.org/wiki/Test_Photo_Uploads [21:38:26] jdlrobson: yeahi think you're right [21:40:17] Maryana: Barack Obama has a mobile upload option [21:40:33] san francisco too [21:42:15] awjr: Maryana MaxSem +1 to new deployment time :D [21:42:17] fun timez [21:42:29] who's going to be obama [21:42:44] ohh awjr https://gerrit.wikimedia.org/r/#/c/36103/ [21:42:47] ^ Maryana [21:42:55] currently uploads will go to the current wiki without that [21:42:56] New patchset: Jnfsmile; "Suggestion - hook for user sections" [mediawiki/extensions/MobileFrontend] (master) - https://gerrit.wikimedia.org/r/36887 [21:43:34] thanks jdlrobson - will that work without the user explicitly logged in to commons [21:43:53] jdlrobson: the progress spinner on my photo upload has been going for a couple of minutes :| [21:44:01] awjr: yeh that needs improving [21:44:07] i can take a while [21:44:11] it's uploading full size [21:44:13] but my photo appears on the san francisco article now [21:44:15] jdlrobson deduced that my phone sucks (needs an os update), which is why i wasn't seeing the uploader [21:44:35] awjr: it should do [21:44:52] neat! [21:44:56] i suspect photo uploads will be slow to start with [21:45:04] so worst case scenario we can add move to commons templates [21:45:32] Maryana: aww bummer [21:46:35] is watch list working for people [21:46:45] it's so badly styled and full of message keys for me [21:46:50] i can see the guts, but not the skin [21:46:54] awjr: hmm san fran looks suspiciously like awjr's house :D [21:47:03] muwahahaaha [21:47:45] no, that's about right - two monitors, code [21:47:49] san francisco! [21:48:09] ha! [21:48:27] yeah i feel like watchlist is not properly rendering on testwiki [21:49:00] it's hard to tell since the messages are not there [21:49:14] but i dont see any of the pretty formatting [21:49:33] i do see timestamps (7 minutes ago) and page names [21:50:06] and when i tap, i see userrights for the user making the change [21:50:16] timestamps? we have those!?! [21:50:18] jdlrobson: any idea what might be going on? ^ [21:50:22] huh [21:50:25] awjr: no idea [21:50:31] :| [21:50:34] need brion [21:50:37] yeah [21:50:51] jdlrobson: https://bugzilla.wikimedia.org/show_bug.cgi?id=20383 [21:51:01] Maryana: are you ok with watchlists going out as-is (messages will actually appear properly in production) [21:51:04] where is brion? [21:51:09] jdlrobson: jury duty [21:51:15] awjr: any way we can see messages ? [21:51:20] its the week of jury duty ... [21:51:20] that would give me more confidence [21:51:25] yeah, i'm eager to see how it looks - it seems like the compontents are all there, just kinda… naked [21:51:28] jdlrobson: not on testwiki unless we scap [21:51:34] sigghghgh [21:51:37] salhsahdsbkasdlhds;ds;ds < frustration [21:52:05] did the new js and css definitely get added?\ [21:52:24] checking - ?debug=true makes no difference [21:52:46] mm [21:52:52] i dont think so [21:52:58] gimme a few minutes [21:54:33] i'm not seeing the rules in the css file [21:54:39] yeah me neither [21:54:45] im trying to think how to cope with that on testwiki [21:54:51] i don't know why that is.. [21:55:06] well it looks like the mobile.watchlist module wasn't loaded [21:55:07] is stylesheets/special/watchlist.css present? [21:55:17] is there a config variable or something? [21:55:33] it is present [21:55:36] dunno about config [21:55:42] incompatible mediawiki version? [21:55:51] resource loader something or other, im guessing [21:56:09] this is very odd [21:56:29] we can say the magic ResourceLoader phrase and hope some magical resource loader pixie comes and fixes the problem? [21:56:55] awjr: is that a scap issue? [21:57:22] jcmish: no i dont think so; im gonna try a few things [21:57:32] k [22:02:18] woww new bugzilla emails are much more readable [22:02:28] awjr: i can't work out what's happened here [22:02:48] ughi am getting mad latency on fenari [22:03:09] jdlrobson: RL fail i *think* since the module is not getting laoded at all [22:03:23] im trying something funky, but might take a few minutes [22:04:13] awjr: so i think RL loads the css dynamically (which explains a screen flash i kept seeing on local) [22:04:28] orly? [22:05:11] jdlrobson: it looks like it's getting loaded the standard way? [22:05:44] nope [22:05:50] just disabled javascript [22:05:56] no styling loaded on my local machine [22:06:01] there's magic here [22:06:17] ! [22:06:24] for some reason no magic on test wiki though [22:06:38] the mobile.watchlist resource is getting added with $otput->addModules() on the watchlist special page [22:06:41] what is magic about that? [22:06:58] jcmish, I just got this: http://www.cloudbees.com/webinars/getting-most-out-selenium-and-jenkins-cloudbees-sauce.cb on my personal e-mail, in case you're interested [22:07:03] i don't know.. but i'm telling you it's loaded via javascript [22:07:09] hehehe [22:07:10] sigh. [22:07:13] jgonera: already on it [22:07:16] there's something special going on here [22:07:24] since I went to the summit they sent it to everyone who attended [22:07:35] jcmish, I thought so, but just in case ;) [22:07:38] jgonera: thanks for the reminder though can you send it to mobile-tech [22:07:46] i'd say it's not worth canceling the deployment for [22:07:48] I kept forgetting to see if anyone else wanted to go [22:07:49] jcmish, sure [22:08:09] thanks! [22:09:11] ok well im not figuring this out - i think i need brion [22:09:18] http://192.168.38.164/w/extensions/MobileFrontend/stylesheets/specials/watchlist.css [22:09:34] awjr: ^ there is an additional request in my network tab for that on my local machine [22:09:47] jdlrobson: i can't see that :p [22:09:55] but i trust you :) [22:10:00] _local machine_) [22:10:04] on test it doesn't get requested [22:10:36] also jquery.hdpi gets loaded on my local machine [22:10:37] but not on test [22:10:49] i smell a different mediawiki version [22:10:55] Request URL:http://192.168.38.164/w/resources/jquery/jquery.hidpi.js [22:11:07] jdlrobson: Special:Version [22:12:10]